[jira] [Updated] (CASSANDRA-19613) Add ClusterMetadata.metadataIdentifier to GossipDigestSyn messages
[
https://issues.apache.org/jira/browse/CASSANDRA-19613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sam Tunnicliffe updated CASSANDRA-19613:
Fix Version/s: 5.1
Since Version: NA
Source Control Link:
https://github.com/apache/cassandra/commit/51d048a93a7e7cfb93a544dabba4b6f7aa1bbdd1
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
Committed, thanks!
> Add ClusterMetadata.metadataIdentifier to GossipDigestSyn messages
> --
>
> Key: CASSANDRA-19613
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19613
> Project: Cassandra
> Issue Type: Bug
> Components: Cluster/Gossip, Transactional Cluster Metadata
>Reporter: Sam Tunnicliffe
>Assignee: Sam Tunnicliffe
>Priority: Normal
> Fix For: 5.1
>
> Attachments: ci_summary.html
>
>
> We should add \{{ClusterMetadata.instance().metadataIdentifier}} to
> \{{GossipDigestSyn}} messages and compare with the local one, rejecting
> anything that has the wrong identifier like we do with cluster name.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19613) Add ClusterMetadata.metadataIdentifier to GossipDigestSyn messages
[
https://issues.apache.org/jira/browse/CASSANDRA-19613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marcus Eriksson updated CASSANDRA-19613:
Status: Ready to Commit (was: Review In Progress)
+1
> Add ClusterMetadata.metadataIdentifier to GossipDigestSyn messages
> --
>
> Key: CASSANDRA-19613
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19613
> Project: Cassandra
> Issue Type: Bug
> Components: Cluster/Gossip, Transactional Cluster Metadata
>Reporter: Sam Tunnicliffe
>Assignee: Sam Tunnicliffe
>Priority: Normal
> Attachments: ci_summary.html
>
>
> We should add \{{ClusterMetadata.instance().metadataIdentifier}} to
> \{{GossipDigestSyn}} messages and compare with the local one, rejecting
> anything that has the wrong identifier like we do with cluster name.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19613) Add ClusterMetadata.metadataIdentifier to GossipDigestSyn messages
[
https://issues.apache.org/jira/browse/CASSANDRA-19613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sam Tunnicliffe updated CASSANDRA-19613:
Attachment: ci_summary.html
> Add ClusterMetadata.metadataIdentifier to GossipDigestSyn messages
> --
>
> Key: CASSANDRA-19613
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19613
> Project: Cassandra
> Issue Type: Bug
> Components: Cluster/Gossip, Transactional Cluster Metadata
>Reporter: Sam Tunnicliffe
>Assignee: Sam Tunnicliffe
>Priority: Normal
> Attachments: ci_summary.html
>
>
> We should add \{{ClusterMetadata.instance().metadataIdentifier}} to
> \{{GossipDigestSyn}} messages and compare with the local one, rejecting
> anything that has the wrong identifier like we do with cluster name.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19613) Add ClusterMetadata.metadataIdentifier to GossipDigestSyn messages
[
https://issues.apache.org/jira/browse/CASSANDRA-19613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sam Tunnicliffe updated CASSANDRA-19613:
Reviewers: Marcus Eriksson (was: Marcus Eriksson, Sam Tunnicliffe)
> Add ClusterMetadata.metadataIdentifier to GossipDigestSyn messages
> --
>
> Key: CASSANDRA-19613
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19613
> Project: Cassandra
> Issue Type: Bug
> Components: Cluster/Gossip, Transactional Cluster Metadata
>Reporter: Sam Tunnicliffe
>Assignee: Sam Tunnicliffe
>Priority: Normal
>
> We should add \{{ClusterMetadata.instance().metadataIdentifier}} to
> \{{GossipDigestSyn}} messages and compare with the local one, rejecting
> anything that has the wrong identifier like we do with cluster name.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19613) Add ClusterMetadata.metadataIdentifier to GossipDigestSyn messages
[
https://issues.apache.org/jira/browse/CASSANDRA-19613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sam Tunnicliffe updated CASSANDRA-19613:
Reviewers: Marcus Eriksson, Sam Tunnicliffe
Status: Review In Progress (was: Patch Available)
> Add ClusterMetadata.metadataIdentifier to GossipDigestSyn messages
> --
>
> Key: CASSANDRA-19613
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19613
> Project: Cassandra
> Issue Type: Bug
> Components: Cluster/Gossip, Transactional Cluster Metadata
>Reporter: Sam Tunnicliffe
>Assignee: Sam Tunnicliffe
>Priority: Normal
>
> We should add \{{ClusterMetadata.instance().metadataIdentifier}} to
> \{{GossipDigestSyn}} messages and compare with the local one, rejecting
> anything that has the wrong identifier like we do with cluster name.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19613) Add ClusterMetadata.metadataIdentifier to GossipDigestSyn messages
[
https://issues.apache.org/jira/browse/CASSANDRA-19613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sam Tunnicliffe updated CASSANDRA-19613:
Test and Documentation Plan: New and existing tests in CI
Status: Patch Available (was: Open)
> Add ClusterMetadata.metadataIdentifier to GossipDigestSyn messages
> --
>
> Key: CASSANDRA-19613
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19613
> Project: Cassandra
> Issue Type: Bug
> Components: Cluster/Gossip, Transactional Cluster Metadata
>Reporter: Sam Tunnicliffe
>Assignee: Sam Tunnicliffe
>Priority: Normal
>
> We should add \{{ClusterMetadata.instance().metadataIdentifier}} to
> \{{GossipDigestSyn}} messages and compare with the local one, rejecting
> anything that has the wrong identifier like we do with cluster name.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19613) Add ClusterMetadata.metadataIdentifier to GossipDigestSyn messages
[
https://issues.apache.org/jira/browse/CASSANDRA-19613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sam Tunnicliffe updated CASSANDRA-19613:
Bug Category: Parent values: Correctness(12982)Level 1 values: Test
Failure(12990)
Complexity: Normal
Discovered By: Unit Test
Severity: Normal
Status: Open (was: Triage Needed)
This is relatively benign, but it is related to flakiness in
{{{}o.a.c.distributed.test.tcm.SplitBrainTest{}}}.
In that test, the two halves of a split brain cluster attempt to reestablish
communication due to having members of both in the seed lists. When this
prompts one side to try and catch up with metadata changes, this is correctly
identified as an error which is what the test asserts. The flakiness arises
when the gossip attempt is made before the epochs of the two separate clusters
have had a chance to diverge. In that case, no further communication is
performed and the error is not triggered.
The proposed patch includes a rewrite of {{SplitBrainTest}} which decouples the
catchup from gossip, removing the dependency on timing.
> Add ClusterMetadata.metadataIdentifier to GossipDigestSyn messages
> --
>
> Key: CASSANDRA-19613
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19613
> Project: Cassandra
> Issue Type: Bug
> Components: Cluster/Gossip, Transactional Cluster Metadata
>Reporter: Sam Tunnicliffe
>Assignee: Sam Tunnicliffe
>Priority: Normal
>
> We should add \{{ClusterMetadata.instance().metadataIdentifier}} to
> \{{GossipDigestSyn}} messages and compare with the local one, rejecting
> anything that has the wrong identifier like we do with cluster name.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
