[jira] [Updated] (CASSANDRA-4447) enable jamm for OpenJDK = 1.6.0.23
[ https://issues.apache.org/jira/browse/CASSANDRA-4447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] paul cannon updated CASSANDRA-4447: --- Attachment: 4447-3.txt v3 rewritten to be lots more explicit and save the vendor, arch, and version numbers for later code to use. enable jamm for OpenJDK = 1.6.0.23 --- Key: CASSANDRA-4447 URL: https://issues.apache.org/jira/browse/CASSANDRA-4447 Project: Cassandra Issue Type: Improvement Components: Packaging Environment: openjdk Reporter: Ilya Shipitsin Assignee: Brandon Williams Priority: Trivial Fix For: 1.1.3 Attachments: 4447-2.txt, 4447-3.txt, 4447.txt we tested jamm with OpenJDK, it works well starting at 1.6.0.23, so I suggest --- cassandra-env.sh.dist 2012-07-19 12:24:44.938886154 +0600 +++ cassandra-env.sh2012-07-19 12:28:34.913886847 +0600 @@ -119,8 +119,10 @@ # add the jamm javaagent check_openjdk=`${JAVA:-java} -version 21 | awk '{if (NR == 2) {print $1}}'` -if [ $check_openjdk != OpenJDK ] +check_openjdk_is_good_for_jamm=`${JAVA:-java} -version 21 | awk -F _|\ '/1\.6\.0/ $3 23 {print bad }'` +if [ $check_openjdk = OpenJDK ] [ $check_openjdk_is_good_for_jamm = bad ] then +else JVM_OPTS=$JVM_OPTS -javaagent:$CASSANDRA_HOME/lib/jamm-0.2.5.jar fi -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4447) enable jamm for OpenJDK = 1.6.0.23
[ https://issues.apache.org/jira/browse/CASSANDRA-4447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-4447: Reviewer: brandon.williams (was: thepaul) enable jamm for OpenJDK = 1.6.0.23 --- Key: CASSANDRA-4447 URL: https://issues.apache.org/jira/browse/CASSANDRA-4447 Project: Cassandra Issue Type: Improvement Components: Packaging Environment: openjdk Reporter: Ilya Shipitsin Assignee: paul cannon Priority: Trivial Fix For: 1.1.3 Attachments: 4447-2.txt, 4447-3.txt, 4447.txt we tested jamm with OpenJDK, it works well starting at 1.6.0.23, so I suggest --- cassandra-env.sh.dist 2012-07-19 12:24:44.938886154 +0600 +++ cassandra-env.sh2012-07-19 12:28:34.913886847 +0600 @@ -119,8 +119,10 @@ # add the jamm javaagent check_openjdk=`${JAVA:-java} -version 21 | awk '{if (NR == 2) {print $1}}'` -if [ $check_openjdk != OpenJDK ] +check_openjdk_is_good_for_jamm=`${JAVA:-java} -version 21 | awk -F _|\ '/1\.6\.0/ $3 23 {print bad }'` +if [ $check_openjdk = OpenJDK ] [ $check_openjdk_is_good_for_jamm = bad ] then +else JVM_OPTS=$JVM_OPTS -javaagent:$CASSANDRA_HOME/lib/jamm-0.2.5.jar fi -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4447) enable jamm for OpenJDK = 1.6.0.23
[ https://issues.apache.org/jira/browse/CASSANDRA-4447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] paul cannon updated CASSANDRA-4447: --- Attachment: 4447-4.txt v4 is dash-friendly (not completely sure if it's all the way POSIX-compatible, cause it looks like dash is no longer sticking to POSIX only?) enable jamm for OpenJDK = 1.6.0.23 --- Key: CASSANDRA-4447 URL: https://issues.apache.org/jira/browse/CASSANDRA-4447 Project: Cassandra Issue Type: Improvement Components: Packaging Environment: openjdk Reporter: Ilya Shipitsin Assignee: paul cannon Priority: Trivial Fix For: 1.1.3 Attachments: 4447-4.txt, 4447.txt we tested jamm with OpenJDK, it works well starting at 1.6.0.23, so I suggest --- cassandra-env.sh.dist 2012-07-19 12:24:44.938886154 +0600 +++ cassandra-env.sh2012-07-19 12:28:34.913886847 +0600 @@ -119,8 +119,10 @@ # add the jamm javaagent check_openjdk=`${JAVA:-java} -version 21 | awk '{if (NR == 2) {print $1}}'` -if [ $check_openjdk != OpenJDK ] +check_openjdk_is_good_for_jamm=`${JAVA:-java} -version 21 | awk -F _|\ '/1\.6\.0/ $3 23 {print bad }'` +if [ $check_openjdk = OpenJDK ] [ $check_openjdk_is_good_for_jamm = bad ] then +else JVM_OPTS=$JVM_OPTS -javaagent:$CASSANDRA_HOME/lib/jamm-0.2.5.jar fi -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4447) enable jamm for OpenJDK = 1.6.0.23
[ https://issues.apache.org/jira/browse/CASSANDRA-4447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] paul cannon updated CASSANDRA-4447: --- Attachment: (was: 4447-2.txt) enable jamm for OpenJDK = 1.6.0.23 --- Key: CASSANDRA-4447 URL: https://issues.apache.org/jira/browse/CASSANDRA-4447 Project: Cassandra Issue Type: Improvement Components: Packaging Environment: openjdk Reporter: Ilya Shipitsin Assignee: paul cannon Priority: Trivial Fix For: 1.1.3 Attachments: 4447-4.txt, 4447.txt we tested jamm with OpenJDK, it works well starting at 1.6.0.23, so I suggest --- cassandra-env.sh.dist 2012-07-19 12:24:44.938886154 +0600 +++ cassandra-env.sh2012-07-19 12:28:34.913886847 +0600 @@ -119,8 +119,10 @@ # add the jamm javaagent check_openjdk=`${JAVA:-java} -version 21 | awk '{if (NR == 2) {print $1}}'` -if [ $check_openjdk != OpenJDK ] +check_openjdk_is_good_for_jamm=`${JAVA:-java} -version 21 | awk -F _|\ '/1\.6\.0/ $3 23 {print bad }'` +if [ $check_openjdk = OpenJDK ] [ $check_openjdk_is_good_for_jamm = bad ] then +else JVM_OPTS=$JVM_OPTS -javaagent:$CASSANDRA_HOME/lib/jamm-0.2.5.jar fi -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4447) enable jamm for OpenJDK = 1.6.0.23
[ https://issues.apache.org/jira/browse/CASSANDRA-4447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] paul cannon updated CASSANDRA-4447: --- Attachment: (was: 4447-3.txt) enable jamm for OpenJDK = 1.6.0.23 --- Key: CASSANDRA-4447 URL: https://issues.apache.org/jira/browse/CASSANDRA-4447 Project: Cassandra Issue Type: Improvement Components: Packaging Environment: openjdk Reporter: Ilya Shipitsin Assignee: paul cannon Priority: Trivial Fix For: 1.1.3 Attachments: 4447-4.txt, 4447.txt we tested jamm with OpenJDK, it works well starting at 1.6.0.23, so I suggest --- cassandra-env.sh.dist 2012-07-19 12:24:44.938886154 +0600 +++ cassandra-env.sh2012-07-19 12:28:34.913886847 +0600 @@ -119,8 +119,10 @@ # add the jamm javaagent check_openjdk=`${JAVA:-java} -version 21 | awk '{if (NR == 2) {print $1}}'` -if [ $check_openjdk != OpenJDK ] +check_openjdk_is_good_for_jamm=`${JAVA:-java} -version 21 | awk -F _|\ '/1\.6\.0/ $3 23 {print bad }'` +if [ $check_openjdk = OpenJDK ] [ $check_openjdk_is_good_for_jamm = bad ] then +else JVM_OPTS=$JVM_OPTS -javaagent:$CASSANDRA_HOME/lib/jamm-0.2.5.jar fi -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4447) enable jamm for OpenJDK = 1.6.0.23
[ https://issues.apache.org/jira/browse/CASSANDRA-4447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] paul cannon updated CASSANDRA-4447: --- Attachment: 4447-2.txt I was going to recommend something like this instead, since at least on a few of my machines, java -version is pretty slow, and this would be cleaner. enable jamm for OpenJDK = 1.6.0.23 --- Key: CASSANDRA-4447 URL: https://issues.apache.org/jira/browse/CASSANDRA-4447 Project: Cassandra Issue Type: Improvement Components: Packaging Environment: openjdk Reporter: Ilya Shipitsin Assignee: Brandon Williams Priority: Trivial Fix For: 1.1.3 Attachments: 4447-2.txt, 4447.txt we tested jamm with OpenJDK, it works well starting at 1.6.0.23, so I suggest --- cassandra-env.sh.dist 2012-07-19 12:24:44.938886154 +0600 +++ cassandra-env.sh2012-07-19 12:28:34.913886847 +0600 @@ -119,8 +119,10 @@ # add the jamm javaagent check_openjdk=`${JAVA:-java} -version 21 | awk '{if (NR == 2) {print $1}}'` -if [ $check_openjdk != OpenJDK ] +check_openjdk_is_good_for_jamm=`${JAVA:-java} -version 21 | awk -F _|\ '/1\.6\.0/ $3 23 {print bad }'` +if [ $check_openjdk = OpenJDK ] [ $check_openjdk_is_good_for_jamm = bad ] then +else JVM_OPTS=$JVM_OPTS -javaagent:$CASSANDRA_HOME/lib/jamm-0.2.5.jar fi -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4447) enable jamm for OpenJDK = 1.6.0.23
[ https://issues.apache.org/jira/browse/CASSANDRA-4447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-4447: Attachment: 4447.txt Attaching a slightly different approach with cleaner logic. enable jamm for OpenJDK = 1.6.0.23 --- Key: CASSANDRA-4447 URL: https://issues.apache.org/jira/browse/CASSANDRA-4447 Project: Cassandra Issue Type: Improvement Components: Packaging Environment: openjdk Reporter: Ilya Shipitsin Priority: Trivial Fix For: 1.1.3 Attachments: 4447.txt we tested jamm with OpenJDK, it works well starting at 1.6.0.23, so I suggest --- cassandra-env.sh.dist 2012-07-19 12:24:44.938886154 +0600 +++ cassandra-env.sh2012-07-19 12:28:34.913886847 +0600 @@ -119,8 +119,10 @@ # add the jamm javaagent check_openjdk=`${JAVA:-java} -version 21 | awk '{if (NR == 2) {print $1}}'` -if [ $check_openjdk != OpenJDK ] +check_openjdk_is_good_for_jamm=`${JAVA:-java} -version 21 | awk -F _|\ '/1\.6\.0/ $3 23 {print bad }'` +if [ $check_openjdk = OpenJDK ] [ $check_openjdk_is_good_for_jamm = bad ] then +else JVM_OPTS=$JVM_OPTS -javaagent:$CASSANDRA_HOME/lib/jamm-0.2.5.jar fi -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4447) enable jamm for OpenJDK = 1.6.0.23
[ https://issues.apache.org/jira/browse/CASSANDRA-4447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-4447: Reviewer: thepaul (was: brandon.williams) enable jamm for OpenJDK = 1.6.0.23 --- Key: CASSANDRA-4447 URL: https://issues.apache.org/jira/browse/CASSANDRA-4447 Project: Cassandra Issue Type: Improvement Components: Packaging Environment: openjdk Reporter: Ilya Shipitsin Assignee: Brandon Williams Priority: Trivial Fix For: 1.1.3 Attachments: 4447.txt we tested jamm with OpenJDK, it works well starting at 1.6.0.23, so I suggest --- cassandra-env.sh.dist 2012-07-19 12:24:44.938886154 +0600 +++ cassandra-env.sh2012-07-19 12:28:34.913886847 +0600 @@ -119,8 +119,10 @@ # add the jamm javaagent check_openjdk=`${JAVA:-java} -version 21 | awk '{if (NR == 2) {print $1}}'` -if [ $check_openjdk != OpenJDK ] +check_openjdk_is_good_for_jamm=`${JAVA:-java} -version 21 | awk -F _|\ '/1\.6\.0/ $3 23 {print bad }'` +if [ $check_openjdk = OpenJDK ] [ $check_openjdk_is_good_for_jamm = bad ] then +else JVM_OPTS=$JVM_OPTS -javaagent:$CASSANDRA_HOME/lib/jamm-0.2.5.jar fi -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4447) enable jamm for OpenJDK = 1.6.0.23
[ https://issues.apache.org/jira/browse/CASSANDRA-4447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Ellis updated CASSANDRA-4447: -- Reviewer: brandon.williams Fix Version/s: 1.1.3 enable jamm for OpenJDK = 1.6.0.23 --- Key: CASSANDRA-4447 URL: https://issues.apache.org/jira/browse/CASSANDRA-4447 Project: Cassandra Issue Type: Improvement Components: Packaging Environment: openjdk Reporter: Ilya Shipitsin Priority: Trivial Fix For: 1.1.3 we tested jamm with OpenJDK, it works well starting at 1.6.0.23, so I suggest --- cassandra-env.sh.dist 2012-07-19 12:24:44.938886154 +0600 +++ cassandra-env.sh2012-07-19 12:28:34.913886847 +0600 @@ -119,8 +119,10 @@ # add the jamm javaagent check_openjdk=`${JAVA:-java} -version 21 | awk '{if (NR == 2) {print $1}}'` -if [ $check_openjdk != OpenJDK ] +check_openjdk_is_good_for_jamm=`${JAVA:-java} -version 21 | awk -F _|\ '/1\.6\.0/ $3 23 {print bad }'` +if [ $check_openjdk = OpenJDK ] [ $check_openjdk_is_good_for_jamm = bad ] then +else JVM_OPTS=$JVM_OPTS -javaagent:$CASSANDRA_HOME/lib/jamm-0.2.5.jar fi -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira