[jira] [Updated] (CASSANDRA-4872) Move manifest into sstable metadata
[ https://issues.apache.org/jira/browse/CASSANDRA-4872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei Deng updated CASSANDRA-4872: Labels: lcs qa-resolved (was: qa-resolved) > Move manifest into sstable metadata > --- > > Key: CASSANDRA-4872 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4872 > Project: Cassandra > Issue Type: Improvement >Reporter: Jonathan Ellis >Assignee: Marcus Eriksson >Priority: Minor > Labels: lcs, qa-resolved > Fix For: 2.0 beta 1 > > Attachments: > 0001-CASSANDRA-4872-move-sstable-level-into-sstable-metad-v1.patch, > 0001-CASSANDRA-4872-move-sstable-level-into-sstable-metad-v2.patch, > 0001-CASSANDRA-4872-move-sstable-level-into-sstable-metad-v3.patch, > 0001-CASSANDRA-4872-move-sstable-level-into-sstable-metad-v4.patch, > 0001-CASSANDRA-4872-wip-v6.patch, 0001-CASSANDRA-4872-wip-v7.patch, > 4872-v5.txt > > > Now that we have a metadata component it would be better to keep sstable > level there, than in a separate manifest. With information per-sstable we > don't need to do a full re-level if there is corruption. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-4872) Move manifest into sstable metadata
[ https://issues.apache.org/jira/browse/CASSANDRA-4872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan McGuire updated CASSANDRA-4872: Labels: qa-resolved (was: ) > Move manifest into sstable metadata > --- > > Key: CASSANDRA-4872 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4872 > Project: Cassandra > Issue Type: Improvement > Components: Core >Reporter: Jonathan Ellis >Assignee: Marcus Eriksson >Priority: Minor > Labels: qa-resolved > Fix For: 2.0 beta 1 > > Attachments: > 0001-CASSANDRA-4872-move-sstable-level-into-sstable-metad-v1.patch, > 0001-CASSANDRA-4872-move-sstable-level-into-sstable-metad-v2.patch, > 0001-CASSANDRA-4872-move-sstable-level-into-sstable-metad-v3.patch, > 0001-CASSANDRA-4872-move-sstable-level-into-sstable-metad-v4.patch, > 0001-CASSANDRA-4872-wip-v6.patch, 0001-CASSANDRA-4872-wip-v7.patch, > 4872-v5.txt > > > Now that we have a metadata component it would be better to keep sstable > level there, than in a separate manifest. With information per-sstable we > don't need to do a full re-level if there is corruption. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (CASSANDRA-4872) Move manifest into sstable metadata
[ https://issues.apache.org/jira/browse/CASSANDRA-4872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Ellis updated CASSANDRA-4872: -- Tester: enigmacurry Ryan, can you test this on a Windows VM? Either upgrading from 1.2's LCS, or invoking the add new sstables MBean will exercise the possibly problematic code. (Not sure Windows will allow us to rename over an existing file.) > Move manifest into sstable metadata > --- > > Key: CASSANDRA-4872 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4872 > Project: Cassandra > Issue Type: Improvement > Components: Core >Reporter: Jonathan Ellis >Assignee: Marcus Eriksson >Priority: Minor > Fix For: 2.0 > > Attachments: > 0001-CASSANDRA-4872-move-sstable-level-into-sstable-metad-v1.patch, > 0001-CASSANDRA-4872-move-sstable-level-into-sstable-metad-v2.patch, > 0001-CASSANDRA-4872-move-sstable-level-into-sstable-metad-v3.patch, > 0001-CASSANDRA-4872-move-sstable-level-into-sstable-metad-v4.patch, > 0001-CASSANDRA-4872-wip-v6.patch, 0001-CASSANDRA-4872-wip-v7.patch, > 4872-v5.txt > > > Now that we have a metadata component it would be better to keep sstable > level there, than in a separate manifest. With information per-sstable we > don't need to do a full re-level if there is corruption. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4872) Move manifest into sstable metadata
[ https://issues.apache.org/jira/browse/CASSANDRA-4872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcus Eriksson updated CASSANDRA-4872: --- Attachment: 0001-CASSANDRA-4872-wip-v7.patch As far as i can see, reseting levels was not done when moving from STCS to LCS before this, the json file was left behind, meaning, for example that a change to max sstable size might leave data with a too high level etc. anyway, v7 resets levels when changing to LCS (or when updating compaction strategy options). > Move manifest into sstable metadata > --- > > Key: CASSANDRA-4872 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4872 > Project: Cassandra > Issue Type: Improvement > Components: Core >Reporter: Jonathan Ellis >Assignee: Marcus Eriksson >Priority: Minor > Fix For: 2.0 > > Attachments: > 0001-CASSANDRA-4872-move-sstable-level-into-sstable-metad-v1.patch, > 0001-CASSANDRA-4872-move-sstable-level-into-sstable-metad-v2.patch, > 0001-CASSANDRA-4872-move-sstable-level-into-sstable-metad-v3.patch, > 0001-CASSANDRA-4872-move-sstable-level-into-sstable-metad-v4.patch, > 0001-CASSANDRA-4872-wip-v6.patch, 0001-CASSANDRA-4872-wip-v7.patch, > 4872-v5.txt > > > Now that we have a metadata component it would be better to keep sstable > level there, than in a separate manifest. With information per-sstable we > don't need to do a full re-level if there is corruption. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4872) Move manifest into sstable metadata
[ https://issues.apache.org/jira/browse/CASSANDRA-4872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcus Eriksson updated CASSANDRA-4872: --- Attachment: 0001-CASSANDRA-4872-wip-v6.patch * Removes the max(..) in SSTM * Moves the overlapping check to LeveledManifest.create(..) - this also makes sure that we are in a good state when people change compaction strategy to LCS * add license header to LegacyLeveledManifest btw, git show doesn't include the binary files, git format-patch does > Move manifest into sstable metadata > --- > > Key: CASSANDRA-4872 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4872 > Project: Cassandra > Issue Type: Improvement > Components: Core >Reporter: Jonathan Ellis >Assignee: Marcus Eriksson >Priority: Minor > Fix For: 2.0 > > Attachments: > 0001-CASSANDRA-4872-move-sstable-level-into-sstable-metad-v1.patch, > 0001-CASSANDRA-4872-move-sstable-level-into-sstable-metad-v2.patch, > 0001-CASSANDRA-4872-move-sstable-level-into-sstable-metad-v3.patch, > 0001-CASSANDRA-4872-move-sstable-level-into-sstable-metad-v4.patch, > 0001-CASSANDRA-4872-wip-v6.patch, 4872-v5.txt > > > Now that we have a metadata component it would be better to keep sstable > level there, than in a separate manifest. With information per-sstable we > don't need to do a full re-level if there is corruption. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4872) Move manifest into sstable metadata
[ https://issues.apache.org/jira/browse/CASSANDRA-4872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Ellis updated CASSANDRA-4872: -- Attachment: 4872-v5.txt v5 attached with some minor cleanup. Two questions: - How do we attach sstables to CFS after calling Table.openWithoutSSTables? Table.open(true) will just use the earlier instance. - Why does SSTM.sstableLevel throw in the max() call instead of just accepting the new level? > Move manifest into sstable metadata > --- > > Key: CASSANDRA-4872 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4872 > Project: Cassandra > Issue Type: Improvement > Components: Core >Reporter: Jonathan Ellis >Assignee: Marcus Eriksson >Priority: Minor > Fix For: 2.0 > > Attachments: > 0001-CASSANDRA-4872-move-sstable-level-into-sstable-metad-v1.patch, > 0001-CASSANDRA-4872-move-sstable-level-into-sstable-metad-v2.patch, > 0001-CASSANDRA-4872-move-sstable-level-into-sstable-metad-v3.patch, > 0001-CASSANDRA-4872-move-sstable-level-into-sstable-metad-v4.patch, > 4872-v5.txt > > > Now that we have a metadata component it would be better to keep sstable > level there, than in a separate manifest. With information per-sstable we > don't need to do a full re-level if there is corruption. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4872) Move manifest into sstable metadata
[ https://issues.apache.org/jira/browse/CASSANDRA-4872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcus Eriksson updated CASSANDRA-4872: --- Attachment: 0001-CASSANDRA-4872-move-sstable-level-into-sstable-metad-v4.patch v4 fixes overlapping sstables within a level on startup > Move manifest into sstable metadata > --- > > Key: CASSANDRA-4872 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4872 > Project: Cassandra > Issue Type: Improvement > Components: Core >Reporter: Jonathan Ellis >Assignee: Marcus Eriksson >Priority: Minor > Fix For: 2.0 > > Attachments: > 0001-CASSANDRA-4872-move-sstable-level-into-sstable-metad-v1.patch, > 0001-CASSANDRA-4872-move-sstable-level-into-sstable-metad-v2.patch, > 0001-CASSANDRA-4872-move-sstable-level-into-sstable-metad-v3.patch, > 0001-CASSANDRA-4872-move-sstable-level-into-sstable-metad-v4.patch > > > Now that we have a metadata component it would be better to keep sstable > level there, than in a separate manifest. With information per-sstable we > don't need to do a full re-level if there is corruption. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4872) Move manifest into sstable metadata
[ https://issues.apache.org/jira/browse/CASSANDRA-4872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcus Eriksson updated CASSANDRA-4872: --- Attachment: 0001-CASSANDRA-4872-move-sstable-level-into-sstable-metad-v3.patch v3 checks if the metadatafile actually exists before trying to change level > Move manifest into sstable metadata > --- > > Key: CASSANDRA-4872 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4872 > Project: Cassandra > Issue Type: Improvement > Components: Core >Reporter: Jonathan Ellis >Assignee: Marcus Eriksson >Priority: Minor > Fix For: 2.0 > > Attachments: > 0001-CASSANDRA-4872-move-sstable-level-into-sstable-metad-v1.patch, > 0001-CASSANDRA-4872-move-sstable-level-into-sstable-metad-v2.patch, > 0001-CASSANDRA-4872-move-sstable-level-into-sstable-metad-v3.patch > > > Now that we have a metadata component it would be better to keep sstable > level there, than in a separate manifest. With information per-sstable we > don't need to do a full re-level if there is corruption. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4872) Move manifest into sstable metadata
[ https://issues.apache.org/jira/browse/CASSANDRA-4872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcus Eriksson updated CASSANDRA-4872: --- Attachment: 0001-CASSANDRA-4872-move-sstable-level-into-sstable-metad-v2.patch v2 sends back files to L0 when loadNewSSTables is called also realized that people might drop in sstables manually and then restart cassandra, this could make sstables within levels overlap guess we might need to check for overlapping sstables on startup > Move manifest into sstable metadata > --- > > Key: CASSANDRA-4872 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4872 > Project: Cassandra > Issue Type: Improvement > Components: Core >Reporter: Jonathan Ellis >Assignee: Marcus Eriksson >Priority: Minor > Fix For: 2.0 > > Attachments: > 0001-CASSANDRA-4872-move-sstable-level-into-sstable-metad-v1.patch, > 0001-CASSANDRA-4872-move-sstable-level-into-sstable-metad-v2.patch > > > Now that we have a metadata component it would be better to keep sstable > level there, than in a separate manifest. With information per-sstable we > don't need to do a full re-level if there is corruption. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4872) Move manifest into sstable metadata
[ https://issues.apache.org/jira/browse/CASSANDRA-4872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcus Eriksson updated CASSANDRA-4872: --- Attachment: 0001-CASSANDRA-4872-move-sstable-level-into-sstable-metad-v1.patch > Move manifest into sstable metadata > --- > > Key: CASSANDRA-4872 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4872 > Project: Cassandra > Issue Type: Improvement > Components: Core >Reporter: Jonathan Ellis >Assignee: Marcus Eriksson >Priority: Minor > Fix For: 2.0 > > Attachments: > 0001-CASSANDRA-4872-move-sstable-level-into-sstable-metad-v1.patch > > > Now that we have a metadata component it would be better to keep sstable > level there, than in a separate manifest. With information per-sstable we > don't need to do a full re-level if there is corruption. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4872) Move manifest into sstable metadata
[ https://issues.apache.org/jira/browse/CASSANDRA-4872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Ellis updated CASSANDRA-4872: -- Agreed, it is a bit messy. I think my preferred option would be to snapshot, then rewrite metadata and remove on startup. > Move manifest into sstable metadata > --- > > Key: CASSANDRA-4872 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4872 > Project: Cassandra > Issue Type: Improvement > Components: Core >Reporter: Jonathan Ellis >Assignee: Marcus Eriksson >Priority: Minor > Fix For: 2.0 > > > Now that we have a metadata component it would be better to keep sstable > level there, than in a separate manifest. With information per-sstable we > don't need to do a full re-level if there is corruption. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
