[jira] [Updated] (CASSANDRA-5372) Broken default values for min/max timestamp

2013-03-25 Thread Jason Brown (JIRA)

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-5372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Brown updated CASSANDRA-5372:
---

Reviewer: jasobrown

 Broken default values for min/max timestamp
 ---

 Key: CASSANDRA-5372
 URL: https://issues.apache.org/jira/browse/CASSANDRA-5372
 Project: Cassandra
  Issue Type: Bug
Affects Versions: 1.1.10
Reporter: Sylvain Lebresne
Assignee: Sylvain Lebresne
Priority: Minor
 Fix For: 1.1.11, 1.2.4

 Attachments: 5372.txt


 When the SStableMetadata are not present (or are too hold), the default for 
 the min and max timestamp used is not always correct. Namely, the default 
 (i.e. when we don't know anything) for the min timestamp should be MIN_VALUE 
 and the max timestamp should be MAX_VALUE.
 And there is 2 places where we need to apply those default:
 * if the metadata is an old one that don't have the info
 * if we don't have any metadata component at all
 The only default that is correct is the case fixed by CASSANDRA-5153, but 
 even then it missed a number of occurrences of the problem.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (CASSANDRA-5372) Broken default values for min/max timestamp

2013-03-21 Thread Sylvain Lebresne (JIRA)

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-5372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sylvain Lebresne updated CASSANDRA-5372:


Attachment: 5372.txt

Patch attached to apply the correct default. The patch is against 1.2 though 
part of it affect 1.1 too (but 1.1 doesn't track the min timestamp). I'll 
happily commit the relevant part to 1.1 but attaching against 1.2 to have the 
whole fix.

The patch also remove SSTableMetadata.defaultInstance() because the 
deserializer already know what to do when the stat component is not here.

 Broken default values for min/max timestamp
 ---

 Key: CASSANDRA-5372
 URL: https://issues.apache.org/jira/browse/CASSANDRA-5372
 Project: Cassandra
  Issue Type: Bug
Affects Versions: 1.1.10
Reporter: Sylvain Lebresne
Assignee: Sylvain Lebresne
Priority: Minor
 Attachments: 5372.txt


 When the SStableMetadata are not present (or are too hold), the default for 
 the min and max timestamp used is not always correct. Namely, the default 
 (i.e. when we don't know anything) for the min timestamp should be MIN_VALUE 
 and the max timestamp should be MAX_VALUE.
 And there is 2 places where we need to apply those default:
 * if the metadata is an old one that don't have the info
 * if we don't have any metadata component at all
 The only default that is correct is the case fixed by CASSANDRA-5153, but 
 even then it missed a number of occurrences of the problem.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira