[jira] [Updated] (CASSANDRA-5395) Compaction doesn't remove index entries as designed

2014-05-02 Thread Ryan McGuire (JIRA)

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-5395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ryan McGuire updated CASSANDRA-5395:


Labels: qa-resolved  (was: )

> Compaction doesn't remove index entries as designed
> ---
>
> Key: CASSANDRA-5395
> URL: https://issues.apache.org/jira/browse/CASSANDRA-5395
> Project: Cassandra
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 1.2.0
>Reporter: Jonathan Ellis
>Assignee: Jonathan Ellis
>Priority: Minor
>  Labels: qa-resolved
> Fix For: 1.2.4
>
> Attachments: 5395-2.txt, 5395.txt
>
>
> PerColumnIndexUpdater ignores updates where the new value is a tombstone.  It 
> should still remove the index entry on oldColumn.
> (Note that this will not affect user-visible correctness, since 
> KeysSearcher/CompositeSearcher will issue deletes against stale index 
> entries, but having more stale entries than we "should" could affect 
> performance.)



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Updated] (CASSANDRA-5395) Compaction doesn't remove index entries as designed

2013-03-27 Thread Jonathan Ellis (JIRA)

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-5395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jonathan Ellis updated CASSANDRA-5395:
--

Attachment: 5395-2.txt

second patch attached (on top of the first) that also avoids creating duplicate 
index entries during PrecompactedRow.merge.  (Calling indexer.update(A, B) 
would remove the entry for A and add one for B, but since we're compacting we 
know that an entry for B already exists.)

switched to a merge-column-at-a-time approach similar to what LCR uses.

also tweaked LCR's reducer to short-circuit the column lookup if there is no 
index involved.

> Compaction doesn't remove index entries as designed
> ---
>
> Key: CASSANDRA-5395
> URL: https://issues.apache.org/jira/browse/CASSANDRA-5395
> Project: Cassandra
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 1.2.0
>Reporter: Jonathan Ellis
>Priority: Minor
> Fix For: 1.2.4
>
> Attachments: 5395-2.txt, 5395.txt
>
>
> PerColumnIndexUpdater ignores updates where the new value is a tombstone.  It 
> should still remove the index entry on oldColumn.
> (Note that this will not affect user-visible correctness, since 
> KeysSearcher/CompositeSearcher will issue deletes against stale index 
> entries, but having more stale entries than we "should" could affect 
> performance.)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (CASSANDRA-5395) Compaction doesn't remove index entries as designed

2013-03-27 Thread Jonathan Ellis (JIRA)

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-5395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jonathan Ellis updated CASSANDRA-5395:
--

Attachment: 5395.txt

> Compaction doesn't remove index entries as designed
> ---
>
> Key: CASSANDRA-5395
> URL: https://issues.apache.org/jira/browse/CASSANDRA-5395
> Project: Cassandra
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 1.2.0
>Reporter: Jonathan Ellis
>Priority: Minor
> Fix For: 1.2.4
>
> Attachments: 5395.txt
>
>
> PerColumnIndexUpdater ignores updates where the new value is a tombstone.  It 
> should still remove the index entry on oldColumn.
> (Note that this will not affect user-visible correctness, since 
> KeysSearcher/CompositeSearcher will issue deletes against stale index 
> entries, but having more stale entries than we "should" could affect 
> performance.)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira