[jira] [Updated] (CASSANDRA-9598) bad classapth for 'sstablerepairedset' in 'cassandra-tools' package

2016-03-22 Thread Yuki Morishita (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-9598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yuki Morishita updated CASSANDRA-9598:
--
   Resolution: Fixed
Fix Version/s: (was: 3.0.x)
   (was: 2.2.x)
   (was: 2.1.x)
   3.0.5
   2.2.6
   2.1.14
Reproduced In: 2.2.5, 2.1.6  (was: 2.1.6, 2.2.5)
   Status: Resolved  (was: Patch Available)

Thanks! Committed.

(42644c32401f35d2c4830773ef6a2b690bb21993)

> bad classapth for 'sstablerepairedset' in 'cassandra-tools' package
> ---
>
> Key: CASSANDRA-9598
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9598
> Project: Cassandra
>  Issue Type: Bug
>  Components: Tools
> Environment: Debian 3.16.7, cassandra-tools 2.1.6, cassandra 2.1.6
>Reporter: Clément Lardeur
>Assignee: Yuki Morishita
>Priority: Minor
> Fix For: 2.1.14, 2.2.6, 3.0.5
>
>
> The script 'sstablerepairedset' is not ready out of the box for debian 
> distro, maybe due to the refactoring of CASSANDRA-7160 to pack out tools from 
> the bin directory.
> Actually in 'sstablerepairedset' the classapth is calculated with:
> {code}
> if [ "x$CLASSPATH" = "x" ]; then
> 
> # execute from the build dir.
> if [ -d `dirname $0`/../../build/classes ]; then
> for directory in `dirname $0`/../../build/classes/*; do
> CLASSPATH=$CLASSPATH:$directory
> done
> else
> if [ -f `dirname $0`/../lib/stress.jar ]; then
> CLASSPATH=`dirname $0`/../lib/stress.jar
> fi
> fi
> for jar in `dirname $0`/../../lib/*.jar; do
> CLASSPATH=$CLASSPATH:$jar
> done
> fi
> {code}
> Whereas in other scripts from the 'bin/tools', the classpath is calculated 
> with:
> {code}
> if [ "x$CASSANDRA_INCLUDE" = "x" ]; then
> for include in "`dirname "$0"`/cassandra.in.sh" \
>"$HOME/.cassandra.in.sh" \
>/usr/share/cassandra/cassandra.in.sh \
>/usr/local/share/cassandra/cassandra.in.sh \
>/opt/cassandra/cassandra.in.sh; do
> if [ -r "$include" ]; then
> . "$include"
> break
> fi
> done
> elif [ -r "$CASSANDRA_INCLUDE" ]; then
> . "$CASSANDRA_INCLUDE"
> fi
> {code}
> I think that a little refactoring could be good to extract the common part of 
> these scripts like the computation of the CLASSPATH and the set of JAVA_HOME.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (CASSANDRA-9598) bad classapth for 'sstablerepairedset' in 'cassandra-tools' package

2016-03-22 Thread Yuki Morishita (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-9598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yuki Morishita updated CASSANDRA-9598:
--
Reproduced In: 2.2.5, 2.1.6  (was: 2.1.6, 2.2.5)
 Reviewer: Jeremiah Jordan

[~jjordan] Can you review?

> bad classapth for 'sstablerepairedset' in 'cassandra-tools' package
> ---
>
> Key: CASSANDRA-9598
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9598
> Project: Cassandra
>  Issue Type: Bug
>  Components: Tools
> Environment: Debian 3.16.7, cassandra-tools 2.1.6, cassandra 2.1.6
>Reporter: Clément Lardeur
>Assignee: Yuki Morishita
>Priority: Minor
> Fix For: 2.1.x, 2.2.x, 3.0.x
>
>
> The script 'sstablerepairedset' is not ready out of the box for debian 
> distro, maybe due to the refactoring of CASSANDRA-7160 to pack out tools from 
> the bin directory.
> Actually in 'sstablerepairedset' the classapth is calculated with:
> {code}
> if [ "x$CLASSPATH" = "x" ]; then
> 
> # execute from the build dir.
> if [ -d `dirname $0`/../../build/classes ]; then
> for directory in `dirname $0`/../../build/classes/*; do
> CLASSPATH=$CLASSPATH:$directory
> done
> else
> if [ -f `dirname $0`/../lib/stress.jar ]; then
> CLASSPATH=`dirname $0`/../lib/stress.jar
> fi
> fi
> for jar in `dirname $0`/../../lib/*.jar; do
> CLASSPATH=$CLASSPATH:$jar
> done
> fi
> {code}
> Whereas in other scripts from the 'bin/tools', the classpath is calculated 
> with:
> {code}
> if [ "x$CASSANDRA_INCLUDE" = "x" ]; then
> for include in "`dirname "$0"`/cassandra.in.sh" \
>"$HOME/.cassandra.in.sh" \
>/usr/share/cassandra/cassandra.in.sh \
>/usr/local/share/cassandra/cassandra.in.sh \
>/opt/cassandra/cassandra.in.sh; do
> if [ -r "$include" ]; then
> . "$include"
> break
> fi
> done
> elif [ -r "$CASSANDRA_INCLUDE" ]; then
> . "$CASSANDRA_INCLUDE"
> fi
> {code}
> I think that a little refactoring could be good to extract the common part of 
> these scripts like the computation of the CLASSPATH and the set of JAVA_HOME.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (CASSANDRA-9598) bad classapth for 'sstablerepairedset' in 'cassandra-tools' package

2016-03-22 Thread Yuki Morishita (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-9598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yuki Morishita updated CASSANDRA-9598:
--
Reproduced In: 2.2.5, 2.1.6  (was: 2.1.6, 2.2.5)
   Status: Patch Available  (was: Reopened)

||branch||testall||dtest||
|[9598-2.1|https://github.com/yukim/cassandra/tree/9598-2.1]|[testall|http://cassci.datastax.com/view/Dev/view/yukim/job/yukim-9598-2.1-testall/lastCompletedBuild/testReport/]|[dtest|http://cassci.datastax.com/view/Dev/view/yukim/job/yukim-9598-2.1-dtest/lastCompletedBuild/testReport/]|
|[9598-2.2|https://github.com/yukim/cassandra/tree/9598-2.2]|[testall|http://cassci.datastax.com/view/Dev/view/yukim/job/yukim-9598-2.2-testall/lastCompletedBuild/testReport/]|[dtest|http://cassci.datastax.com/view/Dev/view/yukim/job/yukim-9598-2.2-dtest/lastCompletedBuild/testReport/]|
|[9598-3.0|https://github.com/yukim/cassandra/tree/9598-3.0]|[testall|http://cassci.datastax.com/view/Dev/view/yukim/job/yukim-9598-3.0-testall/lastCompletedBuild/testReport/]|[dtest|http://cassci.datastax.com/view/Dev/view/yukim/job/yukim-9598-3.0-dtest/lastCompletedBuild/testReport/]|

SSTableExport in cassandra-2.1 and cassandra-2.2 needs to be patched also 
because scripts now have '-ea'.

> bad classapth for 'sstablerepairedset' in 'cassandra-tools' package
> ---
>
> Key: CASSANDRA-9598
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9598
> Project: Cassandra
>  Issue Type: Bug
>  Components: Tools
> Environment: Debian 3.16.7, cassandra-tools 2.1.6, cassandra 2.1.6
>Reporter: Clément Lardeur
>Assignee: Yuki Morishita
>Priority: Minor
> Fix For: 2.1.x, 2.2.x, 3.0.x
>
>
> The script 'sstablerepairedset' is not ready out of the box for debian 
> distro, maybe due to the refactoring of CASSANDRA-7160 to pack out tools from 
> the bin directory.
> Actually in 'sstablerepairedset' the classapth is calculated with:
> {code}
> if [ "x$CLASSPATH" = "x" ]; then
> 
> # execute from the build dir.
> if [ -d `dirname $0`/../../build/classes ]; then
> for directory in `dirname $0`/../../build/classes/*; do
> CLASSPATH=$CLASSPATH:$directory
> done
> else
> if [ -f `dirname $0`/../lib/stress.jar ]; then
> CLASSPATH=`dirname $0`/../lib/stress.jar
> fi
> fi
> for jar in `dirname $0`/../../lib/*.jar; do
> CLASSPATH=$CLASSPATH:$jar
> done
> fi
> {code}
> Whereas in other scripts from the 'bin/tools', the classpath is calculated 
> with:
> {code}
> if [ "x$CASSANDRA_INCLUDE" = "x" ]; then
> for include in "`dirname "$0"`/cassandra.in.sh" \
>"$HOME/.cassandra.in.sh" \
>/usr/share/cassandra/cassandra.in.sh \
>/usr/local/share/cassandra/cassandra.in.sh \
>/opt/cassandra/cassandra.in.sh; do
> if [ -r "$include" ]; then
> . "$include"
> break
> fi
> done
> elif [ -r "$CASSANDRA_INCLUDE" ]; then
> . "$CASSANDRA_INCLUDE"
> fi
> {code}
> I think that a little refactoring could be good to extract the common part of 
> these scripts like the computation of the CLASSPATH and the set of JAVA_HOME.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (CASSANDRA-9598) bad classapth for 'sstablerepairedset' in 'cassandra-tools' package

2016-03-10 Thread Yuki Morishita (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-9598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yuki Morishita updated CASSANDRA-9598:
--
Reproduced In: 2.2.5, 2.1.6  (was: 2.1.6)

> bad classapth for 'sstablerepairedset' in 'cassandra-tools' package
> ---
>
> Key: CASSANDRA-9598
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9598
> Project: Cassandra
>  Issue Type: Bug
>  Components: Tools
> Environment: Debian 3.16.7, cassandra-tools 2.1.6, cassandra 2.1.6
>Reporter: Clément Lardeur
>Priority: Minor
> Fix For: 2.1.x, 2.2.x, 3.0.x
>
>
> The script 'sstablerepairedset' is not ready out of the box for debian 
> distro, maybe due to the refactoring of CASSANDRA-7160 to pack out tools from 
> the bin directory.
> Actually in 'sstablerepairedset' the classapth is calculated with:
> {code}
> if [ "x$CLASSPATH" = "x" ]; then
> 
> # execute from the build dir.
> if [ -d `dirname $0`/../../build/classes ]; then
> for directory in `dirname $0`/../../build/classes/*; do
> CLASSPATH=$CLASSPATH:$directory
> done
> else
> if [ -f `dirname $0`/../lib/stress.jar ]; then
> CLASSPATH=`dirname $0`/../lib/stress.jar
> fi
> fi
> for jar in `dirname $0`/../../lib/*.jar; do
> CLASSPATH=$CLASSPATH:$jar
> done
> fi
> {code}
> Whereas in other scripts from the 'bin/tools', the classpath is calculated 
> with:
> {code}
> if [ "x$CASSANDRA_INCLUDE" = "x" ]; then
> for include in "`dirname "$0"`/cassandra.in.sh" \
>"$HOME/.cassandra.in.sh" \
>/usr/share/cassandra/cassandra.in.sh \
>/usr/local/share/cassandra/cassandra.in.sh \
>/opt/cassandra/cassandra.in.sh; do
> if [ -r "$include" ]; then
> . "$include"
> break
> fi
> done
> elif [ -r "$CASSANDRA_INCLUDE" ]; then
> . "$CASSANDRA_INCLUDE"
> fi
> {code}
> I think that a little refactoring could be good to extract the common part of 
> these scripts like the computation of the CLASSPATH and the set of JAVA_HOME.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (CASSANDRA-9598) bad classapth for 'sstablerepairedset' in 'cassandra-tools' package

2016-03-10 Thread Yuki Morishita (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-9598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yuki Morishita updated CASSANDRA-9598:
--
Fix Version/s: 3.0.x
   2.2.x
   2.1.x

> bad classapth for 'sstablerepairedset' in 'cassandra-tools' package
> ---
>
> Key: CASSANDRA-9598
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9598
> Project: Cassandra
>  Issue Type: Bug
>  Components: Tools
> Environment: Debian 3.16.7, cassandra-tools 2.1.6, cassandra 2.1.6
>Reporter: Clément Lardeur
>Priority: Minor
> Fix For: 2.1.x, 2.2.x, 3.0.x
>
>
> The script 'sstablerepairedset' is not ready out of the box for debian 
> distro, maybe due to the refactoring of CASSANDRA-7160 to pack out tools from 
> the bin directory.
> Actually in 'sstablerepairedset' the classapth is calculated with:
> {code}
> if [ "x$CLASSPATH" = "x" ]; then
> 
> # execute from the build dir.
> if [ -d `dirname $0`/../../build/classes ]; then
> for directory in `dirname $0`/../../build/classes/*; do
> CLASSPATH=$CLASSPATH:$directory
> done
> else
> if [ -f `dirname $0`/../lib/stress.jar ]; then
> CLASSPATH=`dirname $0`/../lib/stress.jar
> fi
> fi
> for jar in `dirname $0`/../../lib/*.jar; do
> CLASSPATH=$CLASSPATH:$jar
> done
> fi
> {code}
> Whereas in other scripts from the 'bin/tools', the classpath is calculated 
> with:
> {code}
> if [ "x$CASSANDRA_INCLUDE" = "x" ]; then
> for include in "`dirname "$0"`/cassandra.in.sh" \
>"$HOME/.cassandra.in.sh" \
>/usr/share/cassandra/cassandra.in.sh \
>/usr/local/share/cassandra/cassandra.in.sh \
>/opt/cassandra/cassandra.in.sh; do
> if [ -r "$include" ]; then
> . "$include"
> break
> fi
> done
> elif [ -r "$CASSANDRA_INCLUDE" ]; then
> . "$CASSANDRA_INCLUDE"
> fi
> {code}
> I think that a little refactoring could be good to extract the common part of 
> these scripts like the computation of the CLASSPATH and the set of JAVA_HOME.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (CASSANDRA-9598) bad classapth for 'sstablerepairedset' in 'cassandra-tools' package

2015-11-19 Thread Aleksey Yeschenko (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-9598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aleksey Yeschenko updated CASSANDRA-9598:
-
Assignee: (was: Michael Shuler)

> bad classapth for 'sstablerepairedset' in 'cassandra-tools' package
> ---
>
> Key: CASSANDRA-9598
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9598
> Project: Cassandra
>  Issue Type: Bug
>  Components: Tools
> Environment: Debian 3.16.7, cassandra-tools 2.1.6, cassandra 2.1.6
>Reporter: Clément Lardeur
>Priority: Minor
>
> The script 'sstablerepairedset' is not ready out of the box for debian 
> distro, maybe due to the refactoring of CASSANDRA-7160 to pack out tools from 
> the bin directory.
> Actually in 'sstablerepairedset' the classapth is calculated with:
> {code}
> if [ "x$CLASSPATH" = "x" ]; then
> 
> # execute from the build dir.
> if [ -d `dirname $0`/../../build/classes ]; then
> for directory in `dirname $0`/../../build/classes/*; do
> CLASSPATH=$CLASSPATH:$directory
> done
> else
> if [ -f `dirname $0`/../lib/stress.jar ]; then
> CLASSPATH=`dirname $0`/../lib/stress.jar
> fi
> fi
> for jar in `dirname $0`/../../lib/*.jar; do
> CLASSPATH=$CLASSPATH:$jar
> done
> fi
> {code}
> Whereas in other scripts from the 'bin/tools', the classpath is calculated 
> with:
> {code}
> if [ "x$CASSANDRA_INCLUDE" = "x" ]; then
> for include in "`dirname "$0"`/cassandra.in.sh" \
>"$HOME/.cassandra.in.sh" \
>/usr/share/cassandra/cassandra.in.sh \
>/usr/local/share/cassandra/cassandra.in.sh \
>/opt/cassandra/cassandra.in.sh; do
> if [ -r "$include" ]; then
> . "$include"
> break
> fi
> done
> elif [ -r "$CASSANDRA_INCLUDE" ]; then
> . "$CASSANDRA_INCLUDE"
> fi
> {code}
> I think that a little refactoring could be good to extract the common part of 
> these scripts like the computation of the CLASSPATH and the set of JAVA_HOME.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (CASSANDRA-9598) bad classapth for 'sstablerepairedset' in 'cassandra-tools' package

2015-06-15 Thread Jonathan Ellis (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-9598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jonathan Ellis updated CASSANDRA-9598:
--
Assignee: Michael Shuler

 bad classapth for 'sstablerepairedset' in 'cassandra-tools' package
 ---

 Key: CASSANDRA-9598
 URL: https://issues.apache.org/jira/browse/CASSANDRA-9598
 Project: Cassandra
  Issue Type: Bug
  Components: Tools
 Environment: Debian 3.16.7, cassandra-tools 2.1.6, cassandra 2.1.6
Reporter: Clément Lardeur
Assignee: Michael Shuler
Priority: Minor

 The script 'sstablerepairedset' is not ready out of the box for debian 
 distro, maybe due to the refactoring of CASSANDRA-7160 to pack out tools from 
 the bin directory.
 Actually in 'sstablerepairedset' the classapth is calculated with:
 {code}
 if [ x$CLASSPATH = x ]; then
 
 # execute from the build dir.
 if [ -d `dirname $0`/../../build/classes ]; then
 for directory in `dirname $0`/../../build/classes/*; do
 CLASSPATH=$CLASSPATH:$directory
 done
 else
 if [ -f `dirname $0`/../lib/stress.jar ]; then
 CLASSPATH=`dirname $0`/../lib/stress.jar
 fi
 fi
 for jar in `dirname $0`/../../lib/*.jar; do
 CLASSPATH=$CLASSPATH:$jar
 done
 fi
 {code}
 Whereas in other scripts from the 'bin/tools', the classpath is calculated 
 with:
 {code}
 if [ x$CASSANDRA_INCLUDE = x ]; then
 for include in `dirname $0`/cassandra.in.sh \
$HOME/.cassandra.in.sh \
/usr/share/cassandra/cassandra.in.sh \
/usr/local/share/cassandra/cassandra.in.sh \
/opt/cassandra/cassandra.in.sh; do
 if [ -r $include ]; then
 . $include
 break
 fi
 done
 elif [ -r $CASSANDRA_INCLUDE ]; then
 . $CASSANDRA_INCLUDE
 fi
 {code}
 I think that a little refactoring could be good to extract the common part of 
 these scripts like the computation of the CLASSPATH and the set of JAVA_HOME.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)