Re: [PR] CAY-2842 Prevent duplicate select columns when using distinct with order by [cayenne]

2024-02-15 Thread via GitHub


Jugen commented on PR #605:
URL: https://github.com/apache/cayenne/pull/605#issuecomment-1947853798

   @stariy95 I don't have any further changes in mind, so we can proceed with a 
final review when convenient 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cayenne.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] CAY-2842 Prevent duplicate select columns when using distinct with order by [cayenne]

2024-02-15 Thread via GitHub


Jugen commented on PR #605:
URL: https://github.com/apache/cayenne/pull/605#issuecomment-1945847402

   @stariy95 Have added the DbAttribute filter.
   (If I measured right then we're saving about 1ms per 100 columns)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cayenne.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org