[jira] [Commented] (CAY-1873) Move DataDomain cache configuration from the Modeler and into DI
[ https://issues.apache.org/jira/browse/CAY-1873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14612078#comment-14612078 ] ASF GitHub Bot commented on CAY-1873: - GitHub user thinline72 opened a pull request: https://github.com/apache/cayenne/pull/72 CAY-1873 | Move DataDomain cache configuration from the Modeler and into DI You can merge this pull request into a Git repository by running: $ git pull https://github.com/thinline72/cayenne CAY-1873-(2) Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cayenne/pull/72.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #72 commit 597723c796b5e58b40e33aa4f868afc56083b9df Author: Savva Kolbachev s.kolbac...@gmail.com Date: 2015-06-29T08:11:41Z CAY-1873 | Add DataDomain cache configuration into DI commit ea0b958144f9816d64bf287836b034481de3b398 Author: Savva Kolbachev s.kolbac...@gmail.com Date: 2015-06-30T09:05:06Z CAY-1873 | Remove DataDomain cache configuration from the Modeler commit aa313fd94f47933c3c4ddfa2d2aa78d33d721b52 Author: Savva Kolbachev s.kolbac...@gmail.com Date: 2015-07-02T15:32:01Z CAY-1873 | Move DataDomain cache configuration from the Modeler and into DI Move DataDomain cache configuration from the Modeler and into DI Key: CAY-1873 URL: https://issues.apache.org/jira/browse/CAY-1873 Project: Cayenne Issue Type: Task Reporter: Andrus Adamchik Assignee: Andrus Adamchik Attachments: cay1873.patch, cay1873_modeler.patch, cay1873_test.patch, cay1873v2.patch, cay1873v2_test.patch, x.png Cache configuration for DataDomain is currently done in the Modeler. (this configuration is limited to the object cache [1], query cache is configured in DI already) and this seems misplaced. Cache settings are highly environment dependent and are better managed by DI. So let's remove all these screens from the Modeler and create any needed DI services that perform this configuration function. (The next step, outside the scope of this Jira, may be combining query cache and object cache in the same cache engine) [1] http://cayenne.apache.org/docs/3.0/caching-and-fresh-data.html -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CAY-1873) Move DataDomain cache configuration from the Modeler and into DI
[ https://issues.apache.org/jira/browse/CAY-1873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14612068#comment-14612068 ] ASF GitHub Bot commented on CAY-1873: - Github user thinline72 closed the pull request at: https://github.com/apache/cayenne/pull/71 Move DataDomain cache configuration from the Modeler and into DI Key: CAY-1873 URL: https://issues.apache.org/jira/browse/CAY-1873 Project: Cayenne Issue Type: Task Reporter: Andrus Adamchik Assignee: Andrus Adamchik Attachments: cay1873.patch, cay1873_modeler.patch, cay1873_test.patch, cay1873v2.patch, cay1873v2_test.patch, x.png Cache configuration for DataDomain is currently done in the Modeler. (this configuration is limited to the object cache [1], query cache is configured in DI already) and this seems misplaced. Cache settings are highly environment dependent and are better managed by DI. So let's remove all these screens from the Modeler and create any needed DI services that perform this configuration function. (The next step, outside the scope of this Jira, may be combining query cache and object cache in the same cache engine) [1] http://cayenne.apache.org/docs/3.0/caching-and-fresh-data.html -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CAY-1873) Move DataDomain cache configuration from the Modeler and into DI
[ https://issues.apache.org/jira/browse/CAY-1873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14595908#comment-14595908 ] ASF GitHub Bot commented on CAY-1873: - GitHub user thinline72 opened a pull request: https://github.com/apache/cayenne/pull/71 CAY-1873 | Move DataDomain cache configuration from the Modeler and into DI You can merge this pull request into a Git repository by running: $ git pull https://github.com/thinline72/cayenne CAY-1873 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cayenne/pull/71.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #71 commit ee1bbef15b02bca1a4a693408a1246ca8c370c28 Author: Savva Kolbachev s.kolbac...@gmail.com Date: 2015-06-22T13:18:31Z CAY-1873 | Move DataDomain cache configuration from the Modeler and into DI Move DataDomain cache configuration from the Modeler and into DI Key: CAY-1873 URL: https://issues.apache.org/jira/browse/CAY-1873 Project: Cayenne Issue Type: Task Reporter: Andrus Adamchik Assignee: Andrus Adamchik Attachments: cay1873.patch, cay1873_modeler.patch, cay1873_test.patch, cay1873v2.patch, cay1873v2_test.patch, x.png Cache configuration for DataDomain is currently done in the Modeler. (this configuration is limited to the object cache [1], query cache is configured in DI already) and this seems misplaced. Cache settings are highly environment dependent and are better managed by DI. So let's remove all these screens from the Modeler and create any needed DI services that perform this configuration function. (The next step, outside the scope of this Jira, may be combining query cache and object cache in the same cache engine) [1] http://cayenne.apache.org/docs/3.0/caching-and-fresh-data.html -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CAY-1873) Move DataDomain cache configuration from the Modeler and into DI
[ https://issues.apache.org/jira/browse/CAY-1873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13903875#comment-13903875 ] Andrus Adamchik commented on CAY-1873: -- I actually haven't reviewed the model patch. But yeah, if we haven't added any new stuff, we should be good. Move DataDomain cache configuration from the Modeler and into DI Key: CAY-1873 URL: https://issues.apache.org/jira/browse/CAY-1873 Project: Cayenne Issue Type: Task Reporter: Andrus Adamchik Assignee: Andrus Adamchik Attachments: cay1873.patch, cay1873_modeler.patch, cay1873_test.patch, cay1873v2.patch, cay1873v2_test.patch, x.png Cache configuration for DataDomain is currently done in the Modeler. (this configuration is limited to the object cache [1], query cache is configured in DI already) and this seems misplaced. Cache settings are highly environment dependent and are better managed by DI. So let's remove all these screens from the Modeler and create any needed DI services that perform this configuration function. (The next step, outside the scope of this Jira, may be combining query cache and object cache in the same cache engine) [1] http://cayenne.apache.org/docs/3.0/caching-and-fresh-data.html -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (CAY-1873) Move DataDomain cache configuration from the Modeler and into DI
[ https://issues.apache.org/jira/browse/CAY-1873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13902371#comment-13902371 ] Andrus Adamchik commented on CAY-1873: -- Hi Oleg, Just reviewed cay1873.patch patch. IMO the approach looks sound and we should go with it. Just a few minor notes on our coding conventions (nothing related to the code essence ) : 1. Missing license headers in the new classes. You can add those to Eclipse template to never forget it again. 2. Add @since 3.2 to all the new public classes. Also to the new methods of the existing classes 3. All the removed public constants should be preserved, but be marked as @deprecated since 3.2 (explanation). Same goes for removed methods, except when we can't provide a reasonable replacement that works with the rest if the code (in such case the method can be removed). Move DataDomain cache configuration from the Modeler and into DI Key: CAY-1873 URL: https://issues.apache.org/jira/browse/CAY-1873 Project: Cayenne Issue Type: Task Reporter: Andrus Adamchik Assignee: Andrus Adamchik Attachments: cay1873.patch, cay1873_modeler.patch, cay1873_test.patch, x.png Cache configuration for DataDomain is currently done in the Modeler. (this configuration is limited to the object cache [1], query cache is configured in DI already) and this seems misplaced. Cache settings are highly environment dependent and are better managed by DI. So let's remove all these screens from the Modeler and create any needed DI services that perform this configuration function. (The next step, outside the scope of this Jira, may be combining query cache and object cache in the same cache engine) [1] http://cayenne.apache.org/docs/3.0/caching-and-fresh-data.html -- This message was sent by Atlassian JIRA (v6.1.5#6160)
