[GitHub] rhtyd commented on issue #2225: [master] Smoketest health checkrun
rhtyd commented on issue #2225: [master] Smoketest health checkrun URL: https://github.com/apache/cloudstack/pull/2225#issuecomment-323937114 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2217: [4.9] Smoketest health checkrun
blueorangutan commented on issue #2217: [4.9] Smoketest health checkrun URL: https://github.com/apache/cloudstack/pull/2217#issuecomment-323937165 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2225: [master] Smoketest health checkrun
blueorangutan commented on issue #2225: [master] Smoketest health checkrun URL: https://github.com/apache/cloudstack/pull/2225#issuecomment-323937160 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2217: [4.9] Smoketest health checkrun
rhtyd commented on issue #2217: [4.9] Smoketest health checkrun URL: https://github.com/apache/cloudstack/pull/2217#issuecomment-323937092 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2241: CLOUDSTACK-10052: Simplify dynamic roles enable checking [upgrade-bug]
rhtyd commented on issue #2241: CLOUDSTACK-10052: Simplify dynamic roles enable checking [upgrade-bug] URL: https://github.com/apache/cloudstack/pull/2241#issuecomment-323936639 LGTM, the test failures are intermittent failures, unrelated to the changes. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2186: CLOUDSTACK-10002: Restart network with cleanup spawns Redundant Routers(In Default Network Offering)
blueorangutan commented on issue #2186: CLOUDSTACK-10002: Restart network with cleanup spawns Redundant Routers(In Default Network Offering) URL: https://github.com/apache/cloudstack/pull/2186#issuecomment-323936400 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-55u3) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2186: CLOUDSTACK-10002: Restart network with cleanup spawns Redundant Routers(In Default Network Offering)
rhtyd commented on issue #2186: CLOUDSTACK-10002: Restart network with cleanup spawns Redundant Routers(In Default Network Offering) URL: https://github.com/apache/cloudstack/pull/2186#issuecomment-323712578 @blueorangutan test centos7 vmware-55u3 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #1246: CLOUDSTACK-9165 unable to use reserved IP range in a network for exte?
blueorangutan commented on issue #1246: CLOUDSTACK-9165 unable to use reserved IP range in a network for exte? URL: https://github.com/apache/cloudstack/pull/1246#issuecomment-323936406 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2186: CLOUDSTACK-10002: Restart network with cleanup spawns Redundant Routers(In Default Network Offering)
blueorangutan commented on issue #2186: CLOUDSTACK-10002: Restart network with cleanup spawns Redundant Routers(In Default Network Offering) URL: https://github.com/apache/cloudstack/pull/2186#issuecomment-323712757 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-55u3) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2186: CLOUDSTACK-10002: Restart network with cleanup spawns Redundant Routers(In Default Network Offering)
rhtyd commented on issue #2186: CLOUDSTACK-10002: Restart network with cleanup spawns Redundant Routers(In Default Network Offering) URL: https://github.com/apache/cloudstack/pull/2186#issuecomment-323936351 @blueorangutan test centos7 vmware-55u3 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #1246: CLOUDSTACK-9165 unable to use reserved IP range in a network for exte?
rhtyd commented on issue #1246: CLOUDSTACK-9165 unable to use reserved IP range in a network for exte? URL: https://github.com/apache/cloudstack/pull/1246#issuecomment-323936224 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2243: CLOUDSTACK-10019:template.properties has hardcoded id
blueorangutan commented on issue #2243: CLOUDSTACK-10019:template.properties has hardcoded id URL: https://github.com/apache/cloudstack/pull/2243#issuecomment-323936018 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2243: CLOUDSTACK-10019:template.properties has hardcoded id
rhtyd commented on issue #2243: CLOUDSTACK-10019:template.properties has hardcoded id URL: https://github.com/apache/cloudstack/pull/2243#issuecomment-323935962 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2222: CLOUDSTACK-10022: Allow domain admin to create and delete subdomains
rhtyd commented on issue #: CLOUDSTACK-10022: Allow domain admin to create and delete subdomains URL: https://github.com/apache/cloudstack/pull/#issuecomment-323935706 LGTM. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch master updated: CLOUDSTACK-10022: Allow domain admin to create and delete subdomains (#2222)
This is an automated email from the ASF dual-hosted git repository.
bhaisaab pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/master by this push:
new f62a8d7 CLOUDSTACK-10022: Allow domain admin to create and delete
subdomains (#)
f62a8d7 is described below
commit f62a8d7a5b30dd267b689a746f23c77fe5e30021
Author: Gabriel Beims Bräscher
AuthorDate: Tue Aug 22 03:51:31 2017 -0300
CLOUDSTACK-10022: Allow domain admin to create and delete subdomains (#)
---
.../cloudstack/api/command/admin/domain/CreateDomainCmd.java | 11 ++-
.../cloudstack/api/command/admin/domain/DeleteDomainCmd.java | 11 ++-
ui/scripts/domains.js | 2 ++
3 files changed, 14 insertions(+), 10 deletions(-)
diff --git
a/api/src/org/apache/cloudstack/api/command/admin/domain/CreateDomainCmd.java
b/api/src/org/apache/cloudstack/api/command/admin/domain/CreateDomainCmd.java
index 312c9ee..fe1c202 100644
---
a/api/src/org/apache/cloudstack/api/command/admin/domain/CreateDomainCmd.java
+++
b/api/src/org/apache/cloudstack/api/command/admin/domain/CreateDomainCmd.java
@@ -17,7 +17,7 @@
package org.apache.cloudstack.api.command.admin.domain;
import org.apache.log4j.Logger;
-
+import org.apache.cloudstack.acl.RoleType;
import org.apache.cloudstack.api.APICommand;
import org.apache.cloudstack.api.ApiConstants;
import org.apache.cloudstack.api.ApiErrorCode;
@@ -31,7 +31,8 @@ import com.cloud.domain.Domain;
import com.cloud.user.Account;
@APICommand(name = "createDomain", description = "Creates a domain",
responseObject = DomainResponse.class,
-requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
+ requestHasSensitiveInfo = false, responseHasSensitiveInfo = false, authorized
= {
+RoleType.Admin, RoleType.DomainAdmin })
public class CreateDomainCmd extends BaseCmd {
public static final Logger s_logger =
Logger.getLogger(CreateDomainCmd.class.getName());
@@ -45,9 +46,9 @@ public class CreateDomainCmd extends BaseCmd {
private String domainName;
@Parameter(name = ApiConstants.PARENT_DOMAIN_ID,
- type = CommandType.UUID,
- entityType = DomainResponse.class,
- description = "assigns new domain a parent domain by domain ID
of the parent. If no parent domain is specied, the ROOT domain is assumed.")
+type = CommandType.UUID,
+entityType = DomainResponse.class,
+description = "assigns new domain a parent domain by domain ID of
the parent. If no parent domain is specied, the ROOT domain is assumed.")
private Long parentDomainId;
@Parameter(name = ApiConstants.NETWORK_DOMAIN, type = CommandType.STRING,
description = "Network domain for networks in the domain")
diff --git
a/api/src/org/apache/cloudstack/api/command/admin/domain/DeleteDomainCmd.java
b/api/src/org/apache/cloudstack/api/command/admin/domain/DeleteDomainCmd.java
index a6d2b0b..037cf3d 100644
---
a/api/src/org/apache/cloudstack/api/command/admin/domain/DeleteDomainCmd.java
+++
b/api/src/org/apache/cloudstack/api/command/admin/domain/DeleteDomainCmd.java
@@ -18,8 +18,7 @@ package org.apache.cloudstack.api.command.admin.domain;
import javax.inject.Inject;
-import org.apache.log4j.Logger;
-
+import org.apache.cloudstack.acl.RoleType;
import org.apache.cloudstack.api.APICommand;
import org.apache.cloudstack.api.ApiConstants;
import org.apache.cloudstack.api.ApiErrorCode;
@@ -30,13 +29,15 @@ import org.apache.cloudstack.api.response.DomainResponse;
import org.apache.cloudstack.api.response.SuccessResponse;
import org.apache.cloudstack.context.CallContext;
import org.apache.cloudstack.region.RegionService;
+import org.apache.log4j.Logger;
import com.cloud.domain.Domain;
import com.cloud.event.EventTypes;
import com.cloud.user.Account;
@APICommand(name = "deleteDomain", description = "Deletes a specified domain",
responseObject = SuccessResponse.class,
-requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
+requestHasSensitiveInfo = false, responseHasSensitiveInfo = false, authorized
= {
+RoleType.Admin, RoleType.DomainAdmin })
public class DeleteDomainCmd extends BaseAsyncCmd {
public static final Logger s_logger =
Logger.getLogger(DeleteDomainCmd.class.getName());
private static final String s_name = "deletedomainresponse";
@@ -49,8 +50,8 @@ public class DeleteDomainCmd extends BaseAsyncCmd {
private Long id;
@Parameter(name = ApiConstants.CLEANUP,
- type = CommandType.BOOLEAN,
- description = "true if all domain resources (child domains,
accounts) have to be cleaned up, false otherwise")
+type = CommandType.BOOLEAN,
+description = "true if all domain resources (child domains,
accounts) have to be cleaned up, false otherwise")
priva
[GitHub] rhtyd closed pull request #2222: CLOUDSTACK-10022: Allow domain admin to create and delete subdomains
rhtyd closed pull request #: CLOUDSTACK-10022: Allow domain admin to create and delete subdomains URL: https://github.com/apache/cloudstack/pull/ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch master updated: CLOUDSTACK-10030: Make sure that public IPs assigned to VPC are reacheable from inside the VPC (#2221)
This is an automated email from the ASF dual-hosted git repository. bhaisaab pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new deb92d3 CLOUDSTACK-10030: Make sure that public IPs assigned to VPC are reacheable from inside the VPC (#2221) deb92d3 is described below commit deb92d32bbf743208472113874fac98960099d99 Author: Syed Mushtaq Ahmed AuthorDate: Tue Aug 22 02:50:25 2017 -0400 CLOUDSTACK-10030: Make sure that public IPs assigned to VPC are reacheable from inside the VPC (#2221) If a public IP is assigned to a VPC, a VM running inside that VPC cannot ping that public IP. This is due to the IPtables Nat rules set in such a way that drop any requests to the public IP from internal interfaces. I am fixing this so that internal hosts can also reach the public IP. Reproduction: Create a VPC Create a network inside the VPC Allocate a public IP Create a VM in the network Create a port forwarding rule enabling ICMP ping the public IP inside the VM (this will fail) --- systemvm/patches/debian/config/opt/cloud/bin/configure.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/systemvm/patches/debian/config/opt/cloud/bin/configure.py b/systemvm/patches/debian/config/opt/cloud/bin/configure.py index 252bd2c..f111309 100755 --- a/systemvm/patches/debian/config/opt/cloud/bin/configure.py +++ b/systemvm/patches/debian/config/opt/cloud/bin/configure.py @@ -892,7 +892,7 @@ class CsForwardingRules(CsDataBag): self.fw.append(["filter", "", fw7]) def forward_vpc(self, rule): -fw_prerout_rule = "-A PREROUTING -d %s/32 -i %s" % (rule["public_ip"], self.getDeviceByIp(rule['public_ip'])) +fw_prerout_rule = "-A PREROUTING -d %s/32 " % (rule["public_ip"]) if not rule["protocol"] == "any": fw_prerout_rule += " -m %s -p %s" % (rule["protocol"], rule["protocol"]) if not rule["public_ports"] == "any": -- To stop receiving notification emails like this one, please contact ['"commits@cloudstack.apache.org" '].
[GitHub] rhtyd closed pull request #2221: [CLOUDSTACK-10030] - Make publicips reachable inside VPC
rhtyd closed pull request #2221: [CLOUDSTACK-10030] - Make publicips reachable inside VPC URL: https://github.com/apache/cloudstack/pull/2221 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrunalinikankariya opened a new pull request #2243: CLOUDSTACK-10019:template.properties has hardcoded id
mrunalinikankariya opened a new pull request #2243: CLOUDSTACK-10019:template.properties has hardcoded id URL: https://github.com/apache/cloudstack/pull/2243 template.properties file created after creating template from snapshot has hardcoded id = 1 id should have templateId This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2241: CLOUDSTACK-10052: Simplify dynamic roles enable checking [upgrade-bug]
blueorangutan commented on issue #2241: CLOUDSTACK-10052: Simplify dynamic roles enable checking [upgrade-bug] URL: https://github.com/apache/cloudstack/pull/2241#issuecomment-323928659 Trillian test result (tid-1405) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 45257 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2241-t1405-kvm-centos7.zip Intermitten failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py Intermitten failure detected: /marvin/tests/smoke/test_iso.py Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py Intermitten failure detected: /marvin/tests/smoke/test_templates.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py Test completed. 50 look OK, 7 have error(s) Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_vpc_remote_access_vpn | `Failure` | 55.60 | test_vpc_vpn.py test_04_rvpc_privategw_static_routes | `Failure` | 429.28 | test_privategw_acl.py test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 1083.72 | test_privategw_acl.py test_01_create_template | `Error` | 50.34 | test_templates.py ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 1753.96 | test_routers_network_ops.py ContextSuite context=TestInternalLb>:setup | `Error` | 0.00 | test_internal_lb.py ContextSuite context=TestDeployVirtioSCSIVM>:teardown | `Error` | 45.59 | test_deploy_virtio_scsi_vm.py test_change_service_offering_for_vm_with_snapshots | Skipped | 0.00 | test_vm_snapshots.py test_09_copy_delete_template | Skipped | 0.01 | test_templates.py test_06_copy_template | Skipped | 0.00 | test_templates.py test_static_role_account_acls | Skipped | 0.01 | test_staticroles.py test_11_ss_nfs_version_on_ssvm | Skipped | 0.01 | test_ssvm.py test_01_scale_vm | Skipped | 0.00 | test_scale_vm.py test_01_primary_storage_iscsi | Skipped | 0.02 | test_primary_storage.py test_vm_nic_adapter_vmxnet3 | Skipped | 0.00 | test_nic_adapter_type.py test_nested_virtualization_vmware | Skipped | 0.00 | test_nested_virtualization.py test_06_copy_iso | Skipped | 0.00 | test_iso.py test_deploy_vgpu_enabled_vm | Skipped | 0.02 | test_deploy_vgpu_enabled_vm.py test_3d_gpu_support | Skipped | 0.02 | test_deploy_vgpu_enabled_vm.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrunalinikankariya opened a new pull request #2242: CLOUDSTACK-9958:Include tags of resources in listUsageRecords API
mrunalinikankariya opened a new pull request #2242: CLOUDSTACK-9958:Include
tags of resources in listUsageRecords API
URL: https://github.com/apache/cloudstack/pull/2242
Tags field to be included in the listusagerecords response such that it can
be used in billing report. E.g.
"tags":[
{"key":"city","value":"Toronto","resourcetype":"UserVm","resourceid":"a0cca906-f985-4b56-ad11-f33e59c4c733","account":"admin","domainid":"dec39eb8-4f81-11e7-8315-067fa031","domain":"ROOT"}
,
{"key":"region","value":"canada","resourcetype":"UserVm","resourceid":"a0cca906-f985-4b56-ad11-f33e59c4c733","account":"admin","domainid":"dec39eb8-4f81-11e7-8315-067fa031","domain":"ROOT"}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] cloudmonger commented on issue #2222: CLOUDSTACK-10022: Allow domain admin to create and delete subdomains
cloudmonger commented on issue #: CLOUDSTACK-10022: Allow domain admin to create and delete subdomains URL: https://github.com/apache/cloudstack/pull/#issuecomment-323916084 ### ACS CI BVT Run **Sumarry:** Build Number 1125 Hypervisor xenserver NetworkType Advanced Passed=106 Failed=5 Skipped=12 _Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/r2si930m8xxzavs/AAAzNrnoF1fC3auFrvsKo_8-a?dl=0 **Failed tests:** * test_router_dnsservice.py * test_router_dns_guestipquery Failed * test_routers_network_ops.py * test_01_isolate_network_FW_PF_default_routes_egress_true Failing since 123 runs * test_02_isolate_network_FW_PF_default_routes_egress_false Failing since 123 runs * test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true Failing since 119 runs * test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false Failing since 119 runs **Skipped tests:** test_vm_nic_adapter_vmxnet3 test_01_verify_libvirt test_02_verify_libvirt_after_restart test_03_verify_libvirt_attach_disk test_04_verify_guest_lspci test_05_change_vm_ostype_restart test_06_verify_guest_lspci_again test_static_role_account_acls test_11_ss_nfs_version_on_ssvm test_nested_virtualization_vmware test_3d_gpu_support test_deploy_vgpu_enabled_vm **Passed test suits:** test_deploy_vm_with_userdata.py test_affinity_groups_projects.py test_portable_publicip.py test_vm_snapshots.py test_over_provisioning.py test_global_settings.py test_scale_vm.py test_service_offerings.py test_routers_iptables_default_policy.py test_loadbalance.py test_routers.py test_reset_vm_on_reboot.py test_deploy_vms_with_varied_deploymentplanners.py test_network.py test_router_dns.py test_non_contigiousvlan.py test_login.py test_deploy_vm_iso.py test_list_ids_parameter.py test_public_ip_range.py test_multipleips_per_nic.py test_metrics_api.py test_regions.py test_affinity_groups.py test_network_acl.py test_pvlan.py test_volumes.py test_nic.py test_deploy_vm_root_resize.py test_resource_detail.py test_secondary_storage.py test_disk_offerings.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2221: [CLOUDSTACK-10030] - Make publicips reachable inside VPC
blueorangutan commented on issue #2221: [CLOUDSTACK-10030] - Make publicips reachable inside VPC URL: https://github.com/apache/cloudstack/pull/2221#issuecomment-323888726 Trillian test result (tid-1404) Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 7 Total time taken: 49339 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2221-t1404-xenserver-65sp1.zip Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py Test completed. 53 look OK, 4 have error(s) Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_vpc_remote_access_vpn | `Failure` | 156.44 | test_vpc_vpn.py test_05_rvpc_multi_tiers | `Failure` | 615.47 | test_vpc_redundant.py test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 546.18 | test_vpc_redundant.py test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Failure` | 448.40 | test_routers_network_ops.py test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Failure` | 449.87 | test_routers_network_ops.py test_04_rvpc_privategw_static_routes | `Failure` | 753.24 | test_privategw_acl.py test_05_rvpc_multi_tiers | `Error` | 802.12 | test_vpc_redundant.py test_09_copy_delete_template | Skipped | 0.02 | test_templates.py test_06_copy_template | Skipped | 0.00 | test_templates.py test_static_role_account_acls | Skipped | 0.04 | test_staticroles.py test_11_ss_nfs_version_on_ssvm | Skipped | 0.02 | test_ssvm.py test_vm_nic_adapter_vmxnet3 | Skipped | 0.00 | test_nic_adapter_type.py test_nested_virtualization_vmware | Skipped | 0.00 | test_nested_virtualization.py test_06_copy_iso | Skipped | 0.00 | test_iso.py test_06_verify_guest_lspci_again | Skipped | 0.00 | test_deploy_virtio_scsi_vm.py test_05_change_vm_ostype_restart | Skipped | 0.00 | test_deploy_virtio_scsi_vm.py test_04_verify_guest_lspci | Skipped | 0.00 | test_deploy_virtio_scsi_vm.py test_03_verify_libvirt_attach_disk | Skipped | 0.00 | test_deploy_virtio_scsi_vm.py test_02_verify_libvirt_after_restart | Skipped | 0.00 | test_deploy_virtio_scsi_vm.py test_01_verify_libvirt | Skipped | 0.00 | test_deploy_virtio_scsi_vm.py test_deploy_vgpu_enabled_vm | Skipped | 0.03 | test_deploy_vgpu_enabled_vm.py test_3d_gpu_support | Skipped | 0.04 | test_deploy_vgpu_enabled_vm.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] cloudmonger commented on issue #2214: Speed-up VR initialisation/configuration
cloudmonger commented on issue #2214: Speed-up VR initialisation/configuration URL: https://github.com/apache/cloudstack/pull/2214#issuecomment-323870070 ### ACS CI BVT Run **Sumarry:** Build Number 1124 Hypervisor xenserver NetworkType Advanced Passed=110 Failed=4 Skipped=12 _Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/r2si930m8xxzavs/AAAzNrnoF1fC3auFrvsKo_8-a?dl=0 **Failed tests:** * test_routers_network_ops.py * test_01_isolate_network_FW_PF_default_routes_egress_true Failing since 122 runs * test_02_isolate_network_FW_PF_default_routes_egress_false Failing since 122 runs * test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true Failing since 118 runs * test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false Failing since 118 runs **Skipped tests:** test_vm_nic_adapter_vmxnet3 test_01_verify_libvirt test_02_verify_libvirt_after_restart test_03_verify_libvirt_attach_disk test_04_verify_guest_lspci test_05_change_vm_ostype_restart test_06_verify_guest_lspci_again test_static_role_account_acls test_11_ss_nfs_version_on_ssvm test_nested_virtualization_vmware test_3d_gpu_support test_deploy_vgpu_enabled_vm **Passed test suits:** test_deploy_vm_with_userdata.py test_affinity_groups_projects.py test_portable_publicip.py test_vm_snapshots.py test_over_provisioning.py test_global_settings.py test_router_dnsservice.py test_scale_vm.py test_service_offerings.py test_routers_iptables_default_policy.py test_loadbalance.py test_routers.py test_reset_vm_on_reboot.py test_deploy_vms_with_varied_deploymentplanners.py test_network.py test_router_dns.py test_non_contigiousvlan.py test_login.py test_deploy_vm_iso.py test_list_ids_parameter.py test_public_ip_range.py test_multipleips_per_nic.py test_metrics_api.py test_regions.py test_affinity_groups.py test_network_acl.py test_pvlan.py test_volumes.py test_nic.py test_deploy_vm_root_resize.py test_resource_detail.py test_secondary_storage.py test_vm_life_cycle.py test_disk_offerings.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2221: [CLOUDSTACK-10030] - Make publicips reachable inside VPC
blueorangutan commented on issue #2221: [CLOUDSTACK-10030] - Make publicips reachable inside VPC URL: https://github.com/apache/cloudstack/pull/2221#issuecomment-323863190 Trillian test result (tid-1403) Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 7 Total time taken: 41151 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2221-t1403-xenserver-65sp1.zip Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py Test completed. 53 look OK, 4 have error(s) Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_vpc_remote_access_vpn | `Failure` | 151.07 | test_vpc_vpn.py test_05_rvpc_multi_tiers | `Failure` | 421.44 | test_vpc_redundant.py test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 368.03 | test_vpc_redundant.py test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Failure` | 428.58 | test_routers_network_ops.py test_04_rvpc_privategw_static_routes | `Failure` | 635.80 | test_privategw_acl.py test_09_copy_delete_template | Skipped | 0.02 | test_templates.py test_06_copy_template | Skipped | 0.00 | test_templates.py test_static_role_account_acls | Skipped | 0.02 | test_staticroles.py test_11_ss_nfs_version_on_ssvm | Skipped | 0.02 | test_ssvm.py test_vm_nic_adapter_vmxnet3 | Skipped | 0.00 | test_nic_adapter_type.py test_nested_virtualization_vmware | Skipped | 0.00 | test_nested_virtualization.py test_06_copy_iso | Skipped | 0.00 | test_iso.py test_06_verify_guest_lspci_again | Skipped | 0.00 | test_deploy_virtio_scsi_vm.py test_05_change_vm_ostype_restart | Skipped | 0.00 | test_deploy_virtio_scsi_vm.py test_04_verify_guest_lspci | Skipped | 0.00 | test_deploy_virtio_scsi_vm.py test_03_verify_libvirt_attach_disk | Skipped | 0.00 | test_deploy_virtio_scsi_vm.py test_02_verify_libvirt_after_restart | Skipped | 0.00 | test_deploy_virtio_scsi_vm.py test_01_verify_libvirt | Skipped | 0.00 | test_deploy_virtio_scsi_vm.py test_deploy_vgpu_enabled_vm | Skipped | 0.02 | test_deploy_vgpu_enabled_vm.py test_3d_gpu_support | Skipped | 0.03 | test_deploy_vgpu_enabled_vm.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] GabrielBrascher commented on issue #2222: CLOUDSTACK-10022: Allow domain admin to create and delete subdomains
GabrielBrascher commented on issue #: CLOUDSTACK-10022: Allow domain admin
to create and delete subdomains
URL: https://github.com/apache/cloudstack/pull/#issuecomment-323834910
@rhtyd I added the authorized = { RoleType.Admin, RoleType.DomainAdmin }
field in the @APICommand annotation. Thanks again.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] GabrielBrascher commented on a change in pull request #2222: CLOUDSTACK-10022: Allow domain admin to create and delete subdomains
GabrielBrascher commented on a change in pull request #: CLOUDSTACK-10022: Allow domain admin to create and delete subdomains URL: https://github.com/apache/cloudstack/pull/#discussion_r134310602 ## File path: setup/db/db/schema-41000to41100.sql ## @@ -19,6 +19,10 @@ -- Schema upgrade from 4.10.0.0 to 4.11.0.0 --; +--CLOUDSTACK-10022: Allow domain admin to create and delete subdomains +INSERT INTO `cloud`.`role_permissions` (`uuid`, `role_id`, `rule`, `permission`, `sort_order`) values (UUID(), 3, 'createDomain', 'ALLOW', 303) ON DUPLICATE KEY UPDATE rule=rule; Review comment: @rhtyd Thanks for the hint! I will update it soon. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2241: CLOUDSTACK-10052: Simplify dynamic roles enable checking [upgrade-bug]
blueorangutan commented on issue #2241: CLOUDSTACK-10052: Simplify dynamic roles enable checking [upgrade-bug] URL: https://github.com/apache/cloudstack/pull/2241#issuecomment-323805716 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2241: CLOUDSTACK-10052: Simplify dynamic roles enable checking [upgrade-bug]
blueorangutan commented on issue #2241: CLOUDSTACK-10052: Simplify dynamic roles enable checking [upgrade-bug] URL: https://github.com/apache/cloudstack/pull/2241#issuecomment-323805554 Packaging result: ?centos6 ?centos7 ?debian. JID-998 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2241: CLOUDSTACK-10052: Simplify dynamic roles enable checking [upgrade-bug]
rhtyd commented on issue #2241: CLOUDSTACK-10052: Simplify dynamic roles enable checking [upgrade-bug] URL: https://github.com/apache/cloudstack/pull/2241#issuecomment-323805572 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2241: CLOUDSTACK-10052: Simplify dynamic roles enable checking [upgrade-bug]
blueorangutan commented on issue #2241: CLOUDSTACK-10052: Simplify dynamic roles enable checking [upgrade-bug] URL: https://github.com/apache/cloudstack/pull/2241#issuecomment-323805391 Packaging result: ?centos6 ?centos7 ?debian. JID-997 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd closed pull request #2154: CLOUDSTACK-9967: Fixed static nat iptables rules order issue on addit?
rhtyd closed pull request #2154: CLOUDSTACK-9967: Fixed static nat iptables rules order issue on addit? URL: https://github.com/apache/cloudstack/pull/2154 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch master updated: CLOUDSTACK-9967: Fixed static nat iptables rules order issue on additional public subnet ip (#2154)
This is an automated email from the ASF dual-hosted git repository.
bhaisaab pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/master by this push:
new 40d7746 CLOUDSTACK-9967: Fixed static nat iptables rules order issue
on additional public subnet ip (#2154)
40d7746 is described below
commit 40d77460386342126fb5533a9139bf6d08137d1d
Author: Jayapal
AuthorDate: Mon Aug 21 22:34:40 2017 +0530
CLOUDSTACK-9967: Fixed static nat iptables rules order issue on additional
public subnet ip (#2154)
---
systemvm/patches/debian/config/opt/cloud/bin/configure.py | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/systemvm/patches/debian/config/opt/cloud/bin/configure.py
b/systemvm/patches/debian/config/opt/cloud/bin/configure.py
index a39e10b..252bd2c 100755
--- a/systemvm/patches/debian/config/opt/cloud/bin/configure.py
+++ b/systemvm/patches/debian/config/opt/cloud/bin/configure.py
@@ -928,12 +928,13 @@ class CsForwardingRules(CsDataBag):
device = self.getDeviceByIp(rule["public_ip"])
if device is None:
raise Exception("Ip address %s has no device in the ips databag" %
rule["public_ip"])
+
self.fw.append(["mangle", "",
-"-A PREROUTING -s %s/32 -m state --state NEW -j MARK
--set-xmark 0x%s/0x" % \
-(rule["internal_ip"], device[len("eth"):])])
-self.fw.append(["mangle", "",
-"-A PREROUTING -s %s/32 -m state --state NEW -j
CONNMARK --save-mark --nfmask 0x --ctmask 0x" % \
+"-I PREROUTING -s %s/32 -m state --state NEW -j
CONNMARK --save-mark --nfmask 0x --ctmask 0x" % \
rule["internal_ip"]])
+self.fw.append(["mangle", "",
+"-I PREROUTING -s %s/32 -m state --state NEW -j MARK
--set-xmark 0x%s/0x" % \
+(rule["internal_ip"], device[len("eth"):])])
self.fw.append(["nat", "front",
"-A PREROUTING -d %s/32 -j DNAT --to-destination %s" %
(rule["public_ip"], rule["internal_ip"])])
self.fw.append(["nat", "front",
--
To stop receiving notification emails like this one, please contact
['"commits@cloudstack.apache.org" '].
[GitHub] rhtyd commented on issue #2154: CLOUDSTACK-9967: Fixed static nat iptables rules order issue on addit?
rhtyd commented on issue #2154: CLOUDSTACK-9967: Fixed static nat iptables rules order issue on addit? URL: https://github.com/apache/cloudstack/pull/2154#issuecomment-323799699 I'll proceed with merging this since there are no new intermittent failures seen. @jayapalu however no improvement in current failures are seen. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2241: CLOUDSTACK-10052: Simplify dynamic roles enable checking [upgrade-bug]
blueorangutan commented on issue #2241: CLOUDSTACK-10052: Simplify dynamic roles enable checking [upgrade-bug] URL: https://github.com/apache/cloudstack/pull/2241#issuecomment-323799305 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd closed pull request #2241: CLOUDSTACK-10052: Simplify dynamic roles enable checking [upgrade-bug]
rhtyd closed pull request #2241: CLOUDSTACK-10052: Simplify dynamic roles enable checking [upgrade-bug] URL: https://github.com/apache/cloudstack/pull/2241 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2241: CLOUDSTACK-10052: Simplify dynamic roles enable checking [upgrade-bug]
rhtyd commented on issue #2241: CLOUDSTACK-10052: Simplify dynamic roles enable checking [upgrade-bug] URL: https://github.com/apache/cloudstack/pull/2241#issuecomment-323798741 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd opened a new pull request #2241: CLOUDSTACK-10052: Simplify dynamic roles enable checking [upgrade-bug]
rhtyd opened a new pull request #2241: CLOUDSTACK-10052: Simplify dynamic roles enable checking [upgrade-bug] URL: https://github.com/apache/cloudstack/pull/2241 This fixes issue of enabling dynamic roles based on the global setting only. This also fixes application of the default role/permissions mapping on upgrade from 4.8 and previous versions to 4.9+. Previously, it would make additional check to ensure commands.properties is not in the classpath however this creates confusion for admins who may skip/skim through the rn/docs and assume that mere changing the global settings was not enough. Pinging for review @PaulAngus @nvazquez @borisstoyanov @wido @pdion891 and others @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2241: CLOUDSTACK-10052: Simplify dynamic roles enable checking [upgrade-bug]
blueorangutan commented on issue #2241: CLOUDSTACK-10052: Simplify dynamic roles enable checking [upgrade-bug] URL: https://github.com/apache/cloudstack/pull/2241#issuecomment-323790652 Packaging result: ?centos6 ?centos7 ?debian. JID-996 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2214: Speed-up VR initialisation/configuration
blueorangutan commented on issue #2214: Speed-up VR initialisation/configuration URL: https://github.com/apache/cloudstack/pull/2214#issuecomment-323784919 Packaging result: ?centos6 ?centos7 ?debian. JID-995 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2241: CLOUDSTACK-10052: Simplify dynamic roles enable checking [upgrade-bug]
blueorangutan commented on issue #2241: CLOUDSTACK-10052: Simplify dynamic roles enable checking [upgrade-bug] URL: https://github.com/apache/cloudstack/pull/2241#issuecomment-323783764 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2241: CLOUDSTACK-10052: Simplify dynamic roles enable checking [upgrade-bug]
rhtyd commented on issue #2241: CLOUDSTACK-10052: Simplify dynamic roles enable checking [upgrade-bug] URL: https://github.com/apache/cloudstack/pull/2241#issuecomment-323783568 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2214: Speed-up VR initialisation/configuration
blueorangutan commented on issue #2214: Speed-up VR initialisation/configuration URL: https://github.com/apache/cloudstack/pull/2214#issuecomment-323778668 @DagSonsteboSB a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2241: CLOUDSTACK-10052: Simplify dynamic roles enable checking [upgrade-bug]
blueorangutan commented on issue #2241: CLOUDSTACK-10052: Simplify dynamic roles enable checking [upgrade-bug] URL: https://github.com/apache/cloudstack/pull/2241#issuecomment-323778552 Packaging result: ?centos6 ?centos7 ?debian. JID-994 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DagSonsteboSB commented on issue #2214: Speed-up VR initialisation/configuration
DagSonsteboSB commented on issue #2214: Speed-up VR initialisation/configuration URL: https://github.com/apache/cloudstack/pull/2214#issuecomment-323778384 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2221: [CLOUDSTACK-10030] - Make publicips reachable inside VPC
rhtyd commented on issue #2221: [CLOUDSTACK-10030] - Make publicips reachable inside VPC URL: https://github.com/apache/cloudstack/pull/2221#issuecomment-323772799 LGTM, no new errors, existing errors are known intermittent errors. @syed if possible send a marvin test for this case in a separate PR. I'll merge this as soon as xenserver results are back. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2221: [CLOUDSTACK-10030] - Make publicips reachable inside VPC
rhtyd commented on issue #2221: [CLOUDSTACK-10030] - Make publicips reachable inside VPC URL: https://github.com/apache/cloudstack/pull/2221#issuecomment-323772799 LGTM, no new errors, existing errors are known intermittent errors. @syed if possible send a marvin test for this case in a separate PR. I'll merge this now. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2241: CLOUDSTACK-10052: Simplify dynamic roles enable checking [upgrade-bug]
blueorangutan commented on issue #2241: CLOUDSTACK-10052: Simplify dynamic roles enable checking [upgrade-bug] URL: https://github.com/apache/cloudstack/pull/2241#issuecomment-323772627 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2241: CLOUDSTACK-10052: Simplify dynamic roles enable checking [upgrade-bug]
rhtyd commented on issue #2241: CLOUDSTACK-10052: Simplify dynamic roles enable checking [upgrade-bug] URL: https://github.com/apache/cloudstack/pull/2241#issuecomment-323772457 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] syed commented on a change in pull request #2221: [CLOUDSTACK-10030] - Make publicips reachable inside VPC
syed commented on a change in pull request #2221: [CLOUDSTACK-10030] - Make publicips reachable inside VPC URL: https://github.com/apache/cloudstack/pull/2221#discussion_r134241131 ## File path: systemvm/patches/debian/config/opt/cloud/bin/configure.py ## @@ -886,7 +886,7 @@ def forward_vr(self, rule): self.fw.append(["filter", "", fw7]) def forward_vpc(self, rule): -fw_prerout_rule = "-A PREROUTING -d %s/32 -i %s" % (rule["public_ip"], self.getDeviceByIp(rule['public_ip'])) +fw_prerout_rule = "-A PREROUTING -d %s/32 " % (rule["public_ip"]) Review comment: @rhtyd This is already fixed in `forward_vr` as there is only one internal network for each VR so the IPtables rules work correctly there. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2241: CLOUDSTACK-10052: Simplify dynamic roles enable checking [upgrade-bug]
blueorangutan commented on issue #2241: CLOUDSTACK-10052: Simplify dynamic roles enable checking [upgrade-bug] URL: https://github.com/apache/cloudstack/pull/2241#issuecomment-323750781 Packaging result: ?centos6 ?centos7 ?debian. JID-993 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] cloudmonger commented on issue #2240: CLOUDSTACK-10051 Mouse Scrolling is not working in instance VM console
cloudmonger commented on issue #2240: CLOUDSTACK-10051 Mouse Scrolling is not working in instance VM console URL: https://github.com/apache/cloudstack/pull/2240#issuecomment-323747253 ### ACS CI BVT Run **Sumarry:** Build Number 1122 Hypervisor xenserver NetworkType Advanced Passed=105 Failed=9 Skipped=12 _Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/r2si930m8xxzavs/AAAzNrnoF1fC3auFrvsKo_8-a?dl=0 **Failed tests:** * test_router_dnsservice.py * test_router_dns_guestipquery Failed * test_scale_vm.py * ContextSuite context=TestScaleVm>:setup Failing since 36 runs * test_loadbalance.py * test_01_create_lb_rule_src_nat Failed * test_02_create_lb_rule_non_nat Failed * test_volumes.py * test_06_download_detached_volume Failing since 3 runs * test_routers_network_ops.py * test_01_isolate_network_FW_PF_default_routes_egress_true Failing since 121 runs * test_02_isolate_network_FW_PF_default_routes_egress_false Failing since 121 runs * test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true Failing since 117 runs * test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false Failing since 117 runs **Skipped tests:** test_vm_nic_adapter_vmxnet3 test_01_verify_libvirt test_02_verify_libvirt_after_restart test_03_verify_libvirt_attach_disk test_04_verify_guest_lspci test_05_change_vm_ostype_restart test_06_verify_guest_lspci_again test_static_role_account_acls test_11_ss_nfs_version_on_ssvm test_nested_virtualization_vmware test_3d_gpu_support test_deploy_vgpu_enabled_vm **Passed test suits:** test_deploy_vm_with_userdata.py test_affinity_groups_projects.py test_portable_publicip.py test_vm_snapshots.py test_over_provisioning.py test_global_settings.py test_service_offerings.py test_routers_iptables_default_policy.py test_routers.py test_reset_vm_on_reboot.py test_deploy_vms_with_varied_deploymentplanners.py test_network.py test_router_dns.py test_non_contigiousvlan.py test_login.py test_deploy_vm_iso.py test_list_ids_parameter.py test_public_ip_range.py test_multipleips_per_nic.py test_metrics_api.py test_regions.py test_affinity_groups.py test_network_acl.py test_pvlan.py test_nic.py test_deploy_vm_root_resize.py test_resource_detail.py test_secondary_storage.py test_vm_life_cycle.py test_disk_offerings.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2226: CLOUDSTACK-10012: Towards CloudStack fat jar
rhtyd commented on issue #2226: CLOUDSTACK-10012: Towards CloudStack fat jar URL: https://github.com/apache/cloudstack/pull/2226#issuecomment-323746585 @marcaurele perhaps you don't have commit rights yet, can you send a PR to the asf branch `CLOUDSTACK-10012` and ping me I'll merge your changes right away This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on a change in pull request #2216: CLOUDSTACK-10027 Repeating the same list for Internal LB in VPC
rhtyd commented on a change in pull request #2216: CLOUDSTACK-10027 Repeating
the same list for Internal LB in VPC
URL: https://github.com/apache/cloudstack/pull/2216#discussion_r134233469
##
File path: ui/scripts/vpc.js
##
@@ -745,8 +745,19 @@
}
},
dataProvider: function(args) {
+var array1 = [];
+if (args.filterBy != null) {
+if (args.filterBy.search != null &&
args.filterBy.search.by != null && args.filterBy.search.value != null) {
+switch (args.filterBy.search.by) {
+case "name":
+if (args.filterBy.search.value.length
> 0)
+array1.push("&keyword=" +
args.filterBy.search.value);
+break;
+}
+}
+}
$.ajax({
-url: createURL('listLoadBalancers'),
+url: createURL('listLoadBalancers&page=' +
args.page + '&pagesize=' + pageSize + array1.join("")),
Review comment:
@vedulasantosh instead of appending, move the key/values to data, like it is
with `vpcid`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] vedulasantosh commented on a change in pull request #2216: CLOUDSTACK-10027 Repeating the same list for Internal LB in VPC
vedulasantosh commented on a change in pull request #2216: CLOUDSTACK-10027
Repeating the same list for Internal LB in VPC
URL: https://github.com/apache/cloudstack/pull/2216#discussion_r134221817
##
File path: ui/scripts/vpc.js
##
@@ -745,8 +745,19 @@
}
},
dataProvider: function(args) {
+var array1 = [];
+if (args.filterBy != null) {
+if (args.filterBy.search != null &&
args.filterBy.search.by != null && args.filterBy.search.value != null) {
+switch (args.filterBy.search.by) {
+case "name":
+if (args.filterBy.search.value.length
> 0)
+array1.push("&keyword=" +
args.filterBy.search.value);
+break;
+}
+}
+}
$.ajax({
-url: createURL('listLoadBalancers'),
+url: createURL('listLoadBalancers&page=' +
args.page + '&pagesize=' + pageSize + array1.join("")),
Review comment:
@rhtyd followed the format of other URL's
` $.ajax({
url:
createURL("listVpnGateways&listAll=true&page=" + args.page + "&pagesize=" +
pageSize + array1.join("")),
data: {
vpcid: args.context.vpc[0].id
},`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] marcaurele commented on issue #2226: CLOUDSTACK-10012: Towards CloudStack fat jar
marcaurele commented on issue #2226: CLOUDSTACK-10012: Towards CloudStack fat jar URL: https://github.com/apache/cloudstack/pull/2226#issuecomment-323731046 @rhtyd I cannot push to this branch This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] marcaurele commented on a change in pull request #2226: CLOUDSTACK-10012: Towards CloudStack fat jar
marcaurele commented on a change in pull request #2226: CLOUDSTACK-10012:
Towards CloudStack fat jar
URL: https://github.com/apache/cloudstack/pull/2226#discussion_r134218724
##
File path: packaging/centos63/cloud-management.rc
##
@@ -1,116 +1,153 @@
#!/bin/bash
+
+### BEGIN INIT INFO
+# Provides: cloudstack-management
+# Required-Start:$network $local_fs
+# Required-Stop: $network $local_fs
+# Default-Start: 3 4 5
+# Default-Stop: 0 1 2 6
+# Short-Description: Start/stop Apache CloudStack Usage Monitor
+# Description: This scripts Starts/Stops the Apache CloudStack Management
Server
+### END INIT INFO
+
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
-#
+#
# http://www.apache.org/licenses/LICENSE-2.0
-#
+#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-#
-# cloudstack-management This shell script takes care of starting and
stopping Tomcat
-#
-# chkconfig: - 80 20
-#
-### BEGIN INIT INFO
-# Provides: tomcat6
-# Required-Start: $network $syslog
-# Required-Stop: $network $syslog
-# Default-Start:
-# Default-Stop:
-# Description: Release implementation for Servlet 2.5 and JSP 2.1
-# Short-Description: start and stop tomcat
-### END INIT INFO
-#
-# - originally written by Henri Gomez, Keith Irwin, and Nicolas Mailhot
-# - heavily rewritten by Deepak Bhole and Jason Corley
-#
-if [ -r /etc/rc.d/init.d/functions ]; then
-. /etc/rc.d/init.d/functions
-fi
-if [ -r /lib/lsb/init-functions ]; then
-. /lib/lsb/init-functions
-fi
+. /etc/rc.d/init.d/functions
+SHORTNAME="cloudstack-management"
+PIDFILE=/var/run/"$SHORTNAME".pid
+LOCKFILE=/var/lock/subsys/"$SHORTNAME"
+LOGDIR=/var/log/cloudstack/management
+PROGNAME="CloudStack Management Server"
+CLASS="org.apache.cloudstack.ServerDaemon"
+PROG="jsvc"
+DAEMON="/usr/bin/jsvc"
+USER=cloud
-NAME="$(basename $(readlink -f $0))"
-export SERVICE_NAME="$NAME"
-stop() {
- SHUTDOWN_WAIT="30"
- count="0"
- if [ -f /var/run/${NAME}.pid ]; then
- pid=`cat /var/run/${NAME}.pid`
- kill $pid &>/dev/null
- until [ "$(ps --pid $pid | grep -c $pid)" -eq "0" ] || \
- [ "$count" -gt "$SHUTDOWN_WAIT" ]
- do
- sleep 1
- let count="${count}+1"
- done
- if [ "$(ps --pid $pid | grep -c $pid)" -eq "0" ]; then
- log_success_msg "Stopping ${NAME}:"
- rm -f /var/run/${NAME}.pid
- rm -f /var/lock/subsys/${NAME}
- else
- log_failure_msg "Stopping ${NAME}:"
- fi
- else
- echo "Cannot find PID file of ${NAME}"
- log_failure_msg "Stopping ${NAME}:"
- fi
+export HOME="/var/cloudstack/management"
+
+unset OPTIONS
+[ -r /etc/sysconfig/default/"$SHORTNAME" ] && source
/etc/sysconfig/default/"$SHORTNAME"
+
+setJavaHome() {
+ # use $JAVA_HOME if defined
+ if [ -n "$JAVA_HOME" ] ; then
+return
+ fi
+
+ # try java first
+ java=$(which java 2>/dev/null || :)
+
+ # try javac if java is not found
+ if [ -z "$java" ] ; then
+java=$(which javac 2>/dev/null || :)
+ fi
+
+ if [ -n "$java" ] ; then
+JAVA_HOME=$(dirname $(dirname $(readlink -e $java)))
+export JAVA_HOME
+return
+ fi
+
+ # didnt find java home. exiting with error
+ exit 1
}
-set_ulimit() {
-fd_limit=`ulimit -n`
-if [ "$fd_limit" != "4096" ]; then
-user=`whoami`
-if [ $user == "root" ]; then
-ulimit -n 4096
+setJavaHome
+
+JARS=$(ls /usr/share/cloudstack-management/lib/*.jar | tr '\n' ':' | sed
s'/.$//')
+CLASSPATH="/etc/cloudstack/management:/usr/share/cloudstack-common:/usr/share/cloudstack-management/setup:/usr/share/cloudstack-management:/usr/share/cloudstack-management/cloud-management-server.jar:$JARS"
Review comment:
`:$JARS` should be put in front here to first load extra JARs
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] SudharmaJain commented on issue #1246: CLOUDSTACK-9165 unable to use reserved IP range in a network for exte?
SudharmaJain commented on issue #1246: CLOUDSTACK-9165 unable to use reserved IP range in a network for exte? URL: https://github.com/apache/cloudstack/pull/1246#issuecomment-323730322 @Slair1 Please review. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] marcaurele commented on issue #2226: CLOUDSTACK-10012: Towards CloudStack fat jar
marcaurele commented on issue #2226: CLOUDSTACK-10012: Towards CloudStack fat jar URL: https://github.com/apache/cloudstack/pull/2226#issuecomment-323728996 @rhtyd 1. I will add a startup parameter `-Dwebappdir=...` to let the user change the path location instead of trying to guess things. Then if the path is incorrect at least it will return an error instead of loading the default UI. IMO it's better. 2. I'm in favor to bundle them inside the JAR. It's best for people customizing the installation to have an extra module where they do what they need, instead of editing files from the official releases. 3. +1 for the JARs ordering, that make sense for customization of the install with extra jars. I'll push some of the changes today. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2239: CLOUDSTACK-9993: Securing Agents Communications
rhtyd commented on issue #2239: CLOUDSTACK-9993: Securing Agents Communications URL: https://github.com/apache/cloudstack/pull/2239#issuecomment-323721124 @wido okay, so for you environment just keep `ca.plugin.root.auth.strictness` set to `false` for both new and existing cloudstack environments This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wido commented on issue #2239: CLOUDSTACK-9993: Securing Agents Communications
wido commented on issue #2239: CLOUDSTACK-9993: Securing Agents Communications URL: https://github.com/apache/cloudstack/pull/2239#issuecomment-323720558 Ok, good! Because I know many (like us) do not use SSH from the mgmt server to add a new KVM host, but simply generate a agent.properties and add it to the mgmt server. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2158: CLOUDSTACK-9972: Enhance listVolume API to include physical size and ?
rhtyd commented on issue #2158: CLOUDSTACK-9972: Enhance listVolume API to include physical size and ? URL: https://github.com/apache/cloudstack/pull/2158#issuecomment-323719309 @nvazquez thanks that would be great This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2239: CLOUDSTACK-9993: Securing Agents Communications
rhtyd commented on issue #2239: CLOUDSTACK-9993: Securing Agents Communications URL: https://github.com/apache/cloudstack/pull/2239#issuecomment-323718422 @wido in current implementation -- all agent-mgmt server connections are encrypted and SSL enabled, based on a random cert that the mgmt server creates, stores and uses from `cloudmanagement.keystore` reading/updating from ssl.keystore global setting; and when agents connect to the mgmt server they use a trust-all-manager to trust any certificate presented to them. So, all cloudstack env have the connections encrypted, however not authenticated and secured in one or two-way SSL. With this new work/PR -- for existing environments, after upgrade the auth strictness enforcement will be `'false`, however newer hosts/agents will be provisioned to use this new system to have CA certs etc stored in agents so they will have more secure SSL authentication, however, mgmt server will not perform additional trust validations and it will allow any clients (like it used to now). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2239: CLOUDSTACK-9993: Securing Agents Communications
rhtyd commented on issue #2239: CLOUDSTACK-9993: Securing Agents Communications URL: https://github.com/apache/cloudstack/pull/2239#issuecomment-323718422 @wido all agent-mgmt server connections are encrypted and SSL enabled, based on a random cert that the mgmt server creates, stores and uses from `cloudmanagement.keystore` reading/updating from ssl.keystore global setting; and when agents connect to the mgmt server they use a trust-all-manager to trust any certificate presented to them. So, all cloudstack env have the connections encrypted, however not authenticated and secured in one or two-way SSL. For existing environments, after upgrade the auth strictness enforcement will be `'false`, however newer hosts/agents will be provisioned to use this new system to have CA certs etc stored in agents so they will have more secure SSL authentication, however, mgmt server will not perform additional trust validations and it will allow any clients (like it used to now). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wido commented on issue #2239: CLOUDSTACK-9993: Securing Agents Communications
wido commented on issue #2239: CLOUDSTACK-9993: Securing Agents Communications URL: https://github.com/apache/cloudstack/pull/2239#issuecomment-323717315 What I am missing is that it's enforced/mandatory for all Agents, right? What if somebody doesn't want to enable this and simply wants to run unencrypted. Why shouldn't we make a opt-out somewhere? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] fmaximus commented on issue #2238: [CLOUDSTACK-10053] Performance improvement: caching of NuageVsp ID
fmaximus commented on issue #2238: [CLOUDSTACK-10053] Performance improvement: caching of NuageVsp ID URL: https://github.com/apache/cloudstack/pull/2238#issuecomment-323717198 [CLOUDSTACK-10053](https://issues.apache.org/jira/browse/CLOUDSTACK-10053) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wido commented on a change in pull request #2074: CLOUDSTACK-9899 Url validation disabling
wido commented on a change in pull request #2074: CLOUDSTACK-9899 Url
validation disabling
URL: https://github.com/apache/cloudstack/pull/2074#discussion_r134205947
##
File path: server/src/com/cloud/storage/VolumeApiServiceImpl.java
##
@@ -257,6 +257,10 @@
static final ConfigKey VmJobCheckInterval = new
ConfigKey("Advanced", Long.class, "vm.job.check.interval", "3000",
"Interval in milliseconds to check if the job is complete", false);
+static final ConfigKey VolumeUrlCheck = new
ConfigKey("Advanced", Boolean.class, "volume.url.check", "true",
+"Check the url for a volume before downloading it from the
management server. Set to flase when you managment has no internet access.",
Review comment:
Typo, flase instead of false
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] nvazquez commented on issue #2158: CLOUDSTACK-9972: Enhance listVolume API to include physical size and ?
nvazquez commented on issue #2158: CLOUDSTACK-9972: Enhance listVolume API to include physical size and ? URL: https://github.com/apache/cloudstack/pull/2158#issuecomment-323714585 Sure @rhtyd, I can pick it up if you don't mind guys @DaanHoogland @borisstoyanov This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on a change in pull request #2240: CLOUDSTACK-10051 Mouse Scrolling is not working in instance VM console
rhtyd commented on a change in pull request #2240: CLOUDSTACK-10051 Mouse Scrolling is not working in instance VM console URL: https://github.com/apache/cloudstack/pull/2240#discussion_r134202953 ## File path: systemvm/js/jquery.flot.navigate.js ## @@ -0,0 +1,336 @@ +/* Review comment: @vedulasantosh license? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2240: CLOUDSTACK-10051 Mouse Scrolling is not working in instance VM console
rhtyd commented on issue #2240: CLOUDSTACK-10051 Mouse Scrolling is not working in instance VM console URL: https://github.com/apache/cloudstack/pull/2240#issuecomment-323713677 @vedulasantosh check/fix the Travis failures This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2186: CLOUDSTACK-10002: Restart network with cleanup spawns Redundant Routers(In Default Network Offering)
blueorangutan commented on issue #2186: CLOUDSTACK-10002: Restart network with cleanup spawns Redundant Routers(In Default Network Offering) URL: https://github.com/apache/cloudstack/pull/2186#issuecomment-323712757 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-55u3) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2186: CLOUDSTACK-10002: Restart network with cleanup spawns Redundant Routers(In Default Network Offering)
rhtyd commented on issue #2186: CLOUDSTACK-10002: Restart network with cleanup spawns Redundant Routers(In Default Network Offering) URL: https://github.com/apache/cloudstack/pull/2186#issuecomment-323712578 @blueorangutan test centos7 vmware-55u3 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2241: CLOUDSTACK-10052: Simplify dynamic roles enable checking
blueorangutan commented on issue #2241: CLOUDSTACK-10052: Simplify dynamic roles enable checking URL: https://github.com/apache/cloudstack/pull/2241#issuecomment-323712368 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd opened a new pull request #2241: CLOUDSTACK-10052: Simplify dynamic roles enable checking
rhtyd opened a new pull request #2241: CLOUDSTACK-10052: Simplify dynamic roles enable checking URL: https://github.com/apache/cloudstack/pull/2241 This fixes issue of enabling dynamic roles based on the global setting only. This also fixes application of the default role/permissions mapping on upgrade from 4.8 and previous versions to 4.9+. Previously, it would make additional check to ensure commands.properties is not in the classpath however this creates confusion for admins who may skip/skim through the rn/docs and assume that mere changing the global settings was not enough. Pinging for review @PaulAngus @nvazquez @borisstoyanov @wido @pdion891 and others @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2186: CLOUDSTACK-10002: Restart network with cleanup spawns Redundant Routers(In Default Network Offering)
blueorangutan commented on issue #2186: CLOUDSTACK-10002: Restart network with cleanup spawns Redundant Routers(In Default Network Offering) URL: https://github.com/apache/cloudstack/pull/2186#issuecomment-323711218 Packaging result: ?centos6 ?centos7 ?debian. JID-992 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2203: [CLOUDSTACK-10029] All private, public, and guest interfaceses are marked as untagged ca?
blueorangutan commented on issue #2203: [CLOUDSTACK-10029] All private, public, and guest interfaceses are marked as untagged ca? URL: https://github.com/apache/cloudstack/pull/2203#issuecomment-323709964 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] borisstoyanov commented on issue #2203: [CLOUDSTACK-10029] All private, public, and guest interfaceses are marked as untagged ca?
borisstoyanov commented on issue #2203: [CLOUDSTACK-10029] All private, public, and guest interfaceses are marked as untagged ca? URL: https://github.com/apache/cloudstack/pull/2203#issuecomment-323709590 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] yvsubhash closed pull request #1722: CLOUDSTACK-9558 Cleanup the snapshots on the primary storage of Xense?
yvsubhash closed pull request #1722: CLOUDSTACK-9558 Cleanup the snapshots on the primary storage of Xense? URL: https://github.com/apache/cloudstack/pull/1722 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2221: [CLOUDSTACK-10030] - Make publicips reachable inside VPC
blueorangutan commented on issue #2221: [CLOUDSTACK-10030] - Make publicips reachable inside VPC URL: https://github.com/apache/cloudstack/pull/2221#issuecomment-323708657 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + xenserver-65sp1) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2221: [CLOUDSTACK-10030] - Make publicips reachable inside VPC
rhtyd commented on issue #2221: [CLOUDSTACK-10030] - Make publicips reachable inside VPC URL: https://github.com/apache/cloudstack/pull/2221#issuecomment-323707882 @blueorangutan test centos7 xenserver-65sp1 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2186: CLOUDSTACK-10002: Restart network with cleanup spawns Redundant Routers(In Default Network Offering)
blueorangutan commented on issue #2186: CLOUDSTACK-10002: Restart network with cleanup spawns Redundant Routers(In Default Network Offering) URL: https://github.com/apache/cloudstack/pull/2186#issuecomment-323706146 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2186: CLOUDSTACK-10002: Restart network with cleanup spawns Redundant Routers(In Default Network Offering)
rhtyd commented on issue #2186: CLOUDSTACK-10002: Restart network with cleanup spawns Redundant Routers(In Default Network Offering) URL: https://github.com/apache/cloudstack/pull/2186#issuecomment-323705926 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on a change in pull request #2186: CLOUDSTACK-10002: Restart network with cleanup spawns Redundant Routers(In Default Network Offering)
rhtyd commented on a change in pull request #2186: CLOUDSTACK-10002: Restart network with cleanup spawns Redundant Routers(In Default Network Offering) URL: https://github.com/apache/cloudstack/pull/2186#discussion_r134195195 ## File path: server/src/com/cloud/network/NetworkServiceImpl.java ## @@ -2121,7 +2121,7 @@ public Network updateGuestNetwork(final long networkId, String name, String disp networkOfferingChanged = true; //Setting the new network's isReduntant to the new network offering's RedundantRouter. - network.setIsReduntant(_networkOfferingDao.findById(networkOfferingId).getRedundantRouter()); + network.setRedundant(_networkOfferingDao.findById(networkOfferingId).getRedundantRouter()); Review comment: Alright, will run some tests and merge. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2203: [CLOUDSTACK-10029] All private, public, and guest interfaceses are marked as untagged ca?
blueorangutan commented on issue #2203: [CLOUDSTACK-10029] All private, public, and guest interfaceses are marked as untagged ca? URL: https://github.com/apache/cloudstack/pull/2203#issuecomment-323705481 Packaging result: ?centos6 ?centos7 ?debian. JID-990 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2217: [4.9] Smoketest health checkrun
blueorangutan commented on issue #2217: [4.9] Smoketest health checkrun URL: https://github.com/apache/cloudstack/pull/2217#issuecomment-32370 Packaging result: ?centos6 ?centos7 ?debian. JID-989 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] nitin-maharana commented on a change in pull request #2186: CLOUDSTACK-10002: Restart network with cleanup spawns Redundant Routers(In Default Network Offering)
nitin-maharana commented on a change in pull request #2186: CLOUDSTACK-10002: Restart network with cleanup spawns Redundant Routers(In Default Network Offering) URL: https://github.com/apache/cloudstack/pull/2186#discussion_r134191887 ## File path: server/src/com/cloud/network/NetworkServiceImpl.java ## @@ -2121,7 +2121,7 @@ public Network updateGuestNetwork(final long networkId, String name, String disp networkOfferingChanged = true; //Setting the new network's isReduntant to the new network offering's RedundantRouter. - network.setIsReduntant(_networkOfferingDao.findById(networkOfferingId).getRedundantRouter()); + network.setRedundant(_networkOfferingDao.findById(networkOfferingId).getRedundantRouter()); Review comment: @rhtyd : This change fixes the issue. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] nitin-maharana commented on issue #2186: CLOUDSTACK-10002: Restart network with cleanup spawns Redundant Routers(In Default Network Offering)
nitin-maharana commented on issue #2186: CLOUDSTACK-10002: Restart network with cleanup spawns Redundant Routers(In Default Network Offering) URL: https://github.com/apache/cloudstack/pull/2186#issuecomment-323701595 @rhtyd : As explained in the resolution part. The setter name is different from what it should be used by update call. Earlier the method name was setIsRedundant, where as it should be setRedundant. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2203: [CLOUDSTACK-10029] All private, public, and guest interfaceses are marked as untagged ca?
blueorangutan commented on issue #2203: [CLOUDSTACK-10029] All private, public, and guest interfaceses are marked as untagged ca? URL: https://github.com/apache/cloudstack/pull/2203#issuecomment-323696476 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2203: [CLOUDSTACK-10029] All private, public, and guest interfaceses are marked as untagged ca?
blueorangutan commented on issue #2203: [CLOUDSTACK-10029] All private, public, and guest interfaceses are marked as untagged ca? URL: https://github.com/apache/cloudstack/pull/2203#issuecomment-323696429 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2203: [CLOUDSTACK-10029] All private, public, and guest interfaceses are marked as untagged ca?
rhtyd commented on issue #2203: [CLOUDSTACK-10029] All private, public, and guest interfaceses are marked as untagged ca? URL: https://github.com/apache/cloudstack/pull/2203#issuecomment-323696123 @borisstoyanov trillian env requires centos7 pkgs to have been successfully built in order to run, the last env failed @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2028: CLOUDSTACK-9853: Add support for Secondary IPv6 Addresses and Subnets
blueorangutan commented on issue #2028: CLOUDSTACK-9853: Add support for Secondary IPv6 Addresses and Subnets URL: https://github.com/apache/cloudstack/pull/2028#issuecomment-323694852 Packaging result: ?centos6 ?centos7 ?debian. JID-988 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] vedulasantosh opened a new pull request #2240: CLOUDSTACK-10051 Mouse Scrolling is not working in instance VM console
vedulasantosh opened a new pull request #2240: CLOUDSTACK-10051 Mouse Scrolling is not working in instance VM console URL: https://github.com/apache/cloudstack/pull/2240 When mouse is scrolled in VM Console it is not working. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2217: [4.9] Smoketest health checkrun
blueorangutan commented on issue #2217: [4.9] Smoketest health checkrun URL: https://github.com/apache/cloudstack/pull/2217#issuecomment-323693466 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2217: [4.9] Smoketest health checkrun
rhtyd commented on issue #2217: [4.9] Smoketest health checkrun URL: https://github.com/apache/cloudstack/pull/2217#issuecomment-323693258 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2217: [4.9] Smoketest health checkrun
blueorangutan commented on issue #2217: [4.9] Smoketest health checkrun URL: https://github.com/apache/cloudstack/pull/2217#issuecomment-323693106 Packaging result: ?centos6 ?centos7 ?debian. JID-987 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2083: Iptables speedup
blueorangutan commented on issue #2083: Iptables speedup URL: https://github.com/apache/cloudstack/pull/2083#issuecomment-323689641 Trillian test result (tid-1397) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 64248 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2083-t1397-kvm-centos7.zip Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py Intermitten failure detected: /marvin/tests/smoke/test_loadbalance.py Intermitten failure detected: /marvin/tests/smoke/test_network.py Intermitten failure detected: /marvin/tests/smoke/test_password_server.py Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermitten failure detected: /marvin/tests/smoke/test_router_dhcphosts.py Intermitten failure detected: /marvin/tests/smoke/test_router_dns.py Intermitten failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py Intermitten failure detected: /marvin/tests/smoke/test_service_offerings.py Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Intermitten failure detected: /marvin/tests/smoke/test_volumes.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_router_nics.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py Test completed. 39 look OK, 15 have error(s) Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_VPC_default_routes | `Failure` | 713.35 | test_vpc_router_nics.py test_01_VPC_nics_after_destroy | `Failure` | 748.73 | test_vpc_router_nics.py test_05_rvpc_multi_tiers | `Failure` | 330.18 | test_vpc_redundant.py test_04_rvpc_network_garbage_collector_nics | `Failure` | 253.27 | test_vpc_redundant.py test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 273.88 | test_vpc_redundant.py test_02_redundant_VPC_default_routes | `Failure` | 796.05 | test_vpc_redundant.py test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 355.65 | test_vpc_redundant.py test_02_attach_volume | `Failure` | 815.90 | test_volumes.py test_01_create_volume | `Failure` | 831.17 | test_volumes.py test_10_attachAndDetach_iso | `Failure` | 830.97 | test_vm_life_cycle.py test_04_change_offering_small | `Failure` | 941.81 | test_service_offerings.py test_02_isolate_network_FW_PF_default_routes_egress_false | `Failure` | 260.97 | test_routers_network_ops.py test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Failure` | 328.02 | test_routers_network_ops.py test_01_isolate_network_FW_PF_default_routes_egress_true | `Failure` | 286.25 | test_routers_network_ops.py test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Failure` | 327.59 | test_routers_network_ops.py test_router_dns_guestipquery | `Failure` | 340.54 | test_router_dns.py test_router_dhcphosts | `Failure` | 230.80 | test_router_dhcphosts.py test_04_rvpc_privategw_static_routes | `Failure` | 921.14 | test_privategw_acl.py test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 815.08 | test_privategw_acl.py test_02_vpc_privategw_static_routes | `Failure` | 830.30 | test_privategw_acl.py test_isolate_network_password_server | `Failure` | 230.85 | test_password_server.py test_reboot_router | `Failure` | 498.20 | test_network.py test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | `Failure` | 831.78 | test_network.py test_network_rules_acquired_public_ip_2_nat_rule | `Failure` | 826.63 | test_network.py test_network_rules_acquired_public_ip_1_static_nat_rule | `Failure` | 821.93 | test_network.py test_02_port_fwd_on_non_src_nat | `Failure` | 826.14 | test_network.py test_01_port_fwd_on_src_nat | `Failure` | 821.11 | test_network.py test_assign_and_removal_lb | `Failure` | 220.47 | test_loadbalance.py test_02_create_lb_rule_non_nat | `Failure` | 220.51 | test_loadbalance.py test_01_create_lb_rule_src_nat | `Failure` | 220.54 | test_loadbalance.py test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Failure` | 263.00 | test_internal_lb.py test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Failure` | 232.99 | test_internal_lb.py test_01_vpc_site2site_vpn | `Error` | 242.56 | test_vpc_vpn.py test_01_redundant_vpc_site2site_vpn | `Error` | 318.08 | test_vpc_vpn.py test_05_rvpc_multi_tiers | `Error` | 612.47 | test_vpc_redundant.py test_01_single_VPC_iptables_policies | `Error` | 707.73 | test_routers_iptables_default_policy.py ContextSuite context=TestRouterDHCPHosts>:teardown | `Error` | 276.21 | test_router_dhcphosts.py test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 227.20 | test_internal_lb.py test_03_vpc_internallb_haproxy_stats_on_all
[GitHub] blueorangutan commented on issue #2028: CLOUDSTACK-9853: Add support for Secondary IPv6 Addresses and Subnets
blueorangutan commented on issue #2028: CLOUDSTACK-9853: Add support for Secondary IPv6 Addresses and Subnets URL: https://github.com/apache/cloudstack/pull/2028#issuecomment-323688973 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2028: CLOUDSTACK-9853: Add support for Secondary IPv6 Addresses and Subnets
rhtyd commented on issue #2028: CLOUDSTACK-9853: Add support for Secondary IPv6 Addresses and Subnets URL: https://github.com/apache/cloudstack/pull/2028#issuecomment-323688866 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2028: CLOUDSTACK-9853: Add support for Secondary IPv6 Addresses and Subnets
blueorangutan commented on issue #2028: CLOUDSTACK-9853: Add support for Secondary IPv6 Addresses and Subnets URL: https://github.com/apache/cloudstack/pull/2028#issuecomment-323688771 Packaging result: ?centos6 ?centos7 ?debian. JID-986 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch master updated: CLOUDSTACK-9717: [VMware] RVRs have mismatching MAC addresses for extra public NICs. (#1878)
This is an automated email from the ASF dual-hosted git repository.
bhaisaab pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/master by this push:
new 0c6cf69 CLOUDSTACK-9717: [VMware] RVRs have mismatching MAC addresses
for extra public NICs. (#1878)
0c6cf69 is described below
commit 0c6cf69eeec940345a6ee01b7d03a184e3c31398
Author: sureshanaparti
AuthorDate: Mon Aug 21 14:34:20 2017 +0530
CLOUDSTACK-9717: [VMware] RVRs have mismatching MAC addresses for extra
public NICs. (#1878)
Fix: When RVR is enabled and Peer Router is available, get the MAC
addresses of the extra public NICs from the Peer Router and set them to the
router.
---
engine/schema/src/com/cloud/vm/dao/NicDao.java | 2 +
engine/schema/src/com/cloud/vm/dao/NicDaoImpl.java | 20 +++
.../src/com/cloud/hypervisor/guru/VMwareGuru.java | 17 ++
.../hypervisor/vmware/resource/VmwareResource.java | 65 ++
.../vmware/resource/VmwareResourceTest.java| 34 +++
5 files changed, 138 insertions(+)
diff --git a/engine/schema/src/com/cloud/vm/dao/NicDao.java
b/engine/schema/src/com/cloud/vm/dao/NicDao.java
index d31a165..797f002 100644
--- a/engine/schema/src/com/cloud/vm/dao/NicDao.java
+++ b/engine/schema/src/com/cloud/vm/dao/NicDao.java
@@ -77,5 +77,7 @@ public interface NicDao extends GenericDao {
NicVO getControlNicForVM(long vmId);
+Long getPeerRouterId(String publicMacAddress, long routerId);
+
List listByVmIdAndKeyword(long instanceId, String keyword);
}
diff --git a/engine/schema/src/com/cloud/vm/dao/NicDaoImpl.java
b/engine/schema/src/com/cloud/vm/dao/NicDaoImpl.java
index a5edf58..daf773a 100644
--- a/engine/schema/src/com/cloud/vm/dao/NicDaoImpl.java
+++ b/engine/schema/src/com/cloud/vm/dao/NicDaoImpl.java
@@ -45,6 +45,7 @@ public class NicDaoImpl extends GenericDaoBase
implements NicDao {
private SearchBuilder NonReleasedSearch;
private GenericSearchBuilder deviceIdSearch;
private GenericSearchBuilder CountByForStartingVms;
+private SearchBuilder PeerRouterSearch;
@Inject
VMInstanceDao _vmDao;
@@ -94,6 +95,12 @@ public class NicDaoImpl extends GenericDaoBase
implements NicDao {
join1.and("state", join1.entity().getState(), Op.EQ);
CountByForStartingVms.join("vm", join1,
CountByForStartingVms.entity().getInstanceId(), join1.entity().getId(),
JoinBuilder.JoinType.INNER);
CountByForStartingVms.done();
+
+PeerRouterSearch = createSearchBuilder();
+PeerRouterSearch.and("instanceId",
PeerRouterSearch.entity().getInstanceId(), Op.NEQ);
+PeerRouterSearch.and("macAddress",
PeerRouterSearch.entity().getMacAddress(), Op.EQ);
+PeerRouterSearch.and("vmType", PeerRouterSearch.entity().getVmType(),
Op.EQ);
+PeerRouterSearch.done();
}
@Override
@@ -313,6 +320,19 @@ public class NicDaoImpl extends GenericDaoBase implements NicDao {
}
@Override
+public Long getPeerRouterId(String publicMacAddress, final long routerId) {
+final SearchCriteria sc = PeerRouterSearch.create();
+sc.setParameters("instanceId", routerId);
+sc.setParameters("macAddress", publicMacAddress);
+sc.setParameters("vmType", VirtualMachine.Type.DomainRouter);
+NicVO nicVo = findOneBy(sc);
+if (nicVo != null) {
+return nicVo.getInstanceId();
+}
+return null;
+}
+
+@Override
public List listByVmIdAndKeyword(long instanceId, String keyword) {
SearchCriteria sc = AllFieldsSearch.create();
sc.setParameters("instance", instanceId);
diff --git
a/plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java
b/plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java
index 668f4ac..7b6accf 100644
--- a/plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java
+++ b/plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java
@@ -94,6 +94,7 @@ import com.cloud.utils.Pair;
import com.cloud.utils.db.DB;
import com.cloud.utils.exception.CloudRuntimeException;
import com.cloud.utils.net.NetUtils;
+import com.cloud.vm.DomainRouterVO;
import com.cloud.vm.NicProfile;
import com.cloud.vm.NicVO;
import com.cloud.vm.SecondaryStorageVmVO;
@@ -101,6 +102,7 @@ import com.cloud.vm.VirtualMachine;
import com.cloud.vm.VirtualMachine.Type;
import com.cloud.vm.VirtualMachineProfile;
import com.cloud.vm.VmDetailConstants;
+import com.cloud.vm.dao.DomainRouterDao;
import com.cloud.vm.dao.NicDao;
import com.cloud.vm.dao.VMInstanceDao;
@@ -128,6 +130,8 @@ public class VMwareGuru extends HypervisorGuruBase
implements HypervisorGuru, Co
@Inject
private NicDao _nicDao;
@Inject
+private DomainRouterDao _domainRouterDao;
+@Inject
private PhysicalNetworkTrafficTypeDao _physicalNetworkTrafficTypeDao;
