[GitHub] blueorangutan commented on issue #2273: CLOUDSTACK-10090:createPortForwardingRule api call accepts 'halt' as ?

2017-11-05 Thread GitBox 
blueorangutan commented on issue #2273: 
CLOUDSTACK-10090:createPortForwardingRule api call accepts 'halt' as ?
URL: https://github.com/apache/cloudstack/pull/2273#issuecomment-342047369
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1211


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2242: CLOUDSTACK-9958:Include tags of resources in listUsageRecords API

2017-11-05 Thread GitBox 
blueorangutan commented on issue #2242: CLOUDSTACK-9958:Include tags of 
resources in listUsageRecords API
URL: https://github.com/apache/cloudstack/pull/2242#issuecomment-342046740
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1210


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2273: CLOUDSTACK-10090:createPortForwardingRule api call accepts 'halt' as ?

2017-11-05 Thread GitBox 
blueorangutan commented on issue #2273: 
CLOUDSTACK-10090:createPortForwardingRule api call accepts 'halt' as ?
URL: https://github.com/apache/cloudstack/pull/2273#issuecomment-342044587
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2273: CLOUDSTACK-10090:createPortForwardingRule api call accepts 'halt' as ?

2017-11-05 Thread GitBox 
rhtyd commented on issue #2273: CLOUDSTACK-10090:createPortForwardingRule api 
call accepts 'halt' as ?
URL: https://github.com/apache/cloudstack/pull/2273#issuecomment-342044537
 
 
   @mrunalinikankariya can you explain where/how this method is used and if 
putting a hardcoded protocol list can have undesirable effects, for example 
what if not both `tcp,udp` don't need to be port-forwarded.
   
   For merging, this needs to be tested first.
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2304: CLOUDSTACK-10127: KVM + Ovs: Incorrect devId on static nat

2017-11-05 Thread GitBox 
rhtyd commented on issue #2304: CLOUDSTACK-10127: KVM + Ovs: Incorrect devId on 
static nat
URL: https://github.com/apache/cloudstack/pull/2304#issuecomment-342044177
 
 
   @fmaximus can you check new/additional failures than the baseline failures 
seen in #2289 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2242: CLOUDSTACK-9958:Include tags of resources in listUsageRecords API

2017-11-05 Thread GitBox 
rhtyd commented on issue #2242: CLOUDSTACK-9958:Include tags of resources in 
listUsageRecords API
URL: https://github.com/apache/cloudstack/pull/2242#issuecomment-342043826
 
 
   @mrunalinikankariya I'll kick a round of regression tests first.
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2242: CLOUDSTACK-9958:Include tags of resources in listUsageRecords API

2017-11-05 Thread GitBox 
blueorangutan commented on issue #2242: CLOUDSTACK-9958:Include tags of 
resources in listUsageRecords API
URL: https://github.com/apache/cloudstack/pull/2242#issuecomment-342043860
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd closed pull request #2240: CLOUDSTACK-10051 Mouse Scrolling is not working in instance VM console

2017-11-05 Thread GitBox 
rhtyd closed pull request #2240: CLOUDSTACK-10051 Mouse Scrolling is not 
working in instance VM console
URL: https://github.com/apache/cloudstack/pull/2240
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/pom.xml b/pom.xml
index edfd649d759..c17414b6ba4 100644
--- a/pom.xml
+++ b/pom.xml
@@ -899,6 +899,7 @@
   systemvm/conf/agent.properties
   systemvm/conf/environment.properties
   systemvm/js/jquery.js
+  systemvm/js/jquery.flot.navigate.js
   systemvm/patches/debian/systemvm.vmx
   
systemvm/patches/debian/config/root/.ssh/authorized_keys
   
systemvm/patches/debian/config/etc/apache2/httpd.conf
diff --git 
a/services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyAjaxHandler.java
 
b/services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyAjaxHandler.java
index f586c9361f1..30a54139c0e 100644
--- 
a/services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyAjaxHandler.java
+++ 
b/services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyAjaxHandler.java
@@ -292,6 +292,7 @@ private void handleClientEvent(ConsoleProxyClient viewer, 
int event, Map

[cloudstack] branch master updated: CLOUDSTACK-10051 Mouse Scrolling is not working in instance VM console (#2240)

2017-11-05 Thread bhaisaab 
This is an automated email from the ASF dual-hosted git repository.

bhaisaab pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/master by this push:
 new 2874fc2  CLOUDSTACK-10051 Mouse Scrolling is not working in instance 
VM console (#2240)
2874fc2 is described below

commit 2874fc23e7d11ee826ee25069851d7c48381cf75
Author: vedulasantosh 
AuthorDate: Mon Nov 6 09:58:10 2017 +0530

CLOUDSTACK-10051 Mouse Scrolling is not working in instance VM console 
(#2240)

When mouse is scrolled in VM Console it is not working
---
 pom.xml|   1 +
 .../consoleproxy/ConsoleProxyAjaxHandler.java  |   1 +
 .../cloud/consoleproxy/ConsoleProxyClientBase.java |   1 +
 .../cloud/consoleproxy/ConsoleProxyVncClient.java  |  10 +
 .../src/com/cloud/consoleproxy/InputEventType.java |   4 +-
 systemvm/js/ajaxviewer.js  |  24 +-
 systemvm/js/jquery.flot.navigate.js| 339 +
 7 files changed, 378 insertions(+), 2 deletions(-)

diff --git a/pom.xml b/pom.xml
index 45095d4..4ec4d11 100644
--- a/pom.xml
+++ b/pom.xml
@@ -929,6 +929,7 @@
   systemvm/conf/agent.properties
   systemvm/conf/environment.properties
   systemvm/js/jquery.js
+  systemvm/js/jquery.flot.navigate.js
   systemvm/patches/debian/systemvm.vmx
   
systemvm/patches/debian/config/root/.ssh/authorized_keys
   
systemvm/patches/debian/config/etc/apache2/httpd.conf
diff --git 
a/services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyAjaxHandler.java
 
b/services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyAjaxHandler.java
index f586c93..30a5413 100644
--- 
a/services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyAjaxHandler.java
+++ 
b/services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyAjaxHandler.java
@@ -292,6 +292,7 @@ public class ConsoleProxyAjaxHandler implements HttpHandler 
{
 case 2: // mouse down
 case 3: // mouse up
 case 8: // mouse double click
+case 9: // mouse scroll
 str = queryMap.get("x");
 if (str != null) {
 try {
diff --git 
a/services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyClientBase.java
 
b/services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyClientBase.java
index 100e00c..bc2230b 100644
--- 
a/services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyClientBase.java
+++ 
b/services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyClientBase.java
@@ -294,6 +294,7 @@ public abstract class ConsoleProxyClientBase implements 
ConsoleProxyClient, Cons
 
 String[] content =
 new String[] {"", "", "",
+"",
 "",
 "",
 "",
diff --git 
a/services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyVncClient.java
 
b/services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyVncClient.java
index 8fce978..5992855 100644
--- 
a/services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyVncClient.java
+++ 
b/services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyVncClient.java
@@ -190,6 +190,16 @@ public class ConsoleProxyVncClient extends 
ConsoleProxyClientBase {
 }
 }
 
+if (event == InputEventType.MOUSE_SCROLL) {
+if (code == -1) {
+lastPointerMask = 8;
+} else if (code == 1) {
+lastPointerMask = 16;
+} else if (code == 0) {
+lastPointerMask = 0;
+}
+}
+
 sendModifierEvents(modifiers);
 client.sendClientMouseEvent(lastPointerMask, x, y, code, modifiers);
 if (lastPointerMask == 0)
diff --git 
a/services/console-proxy/server/src/com/cloud/consoleproxy/InputEventType.java 
b/services/console-proxy/server/src/com/cloud/consoleproxy/InputEventType.java
index 4ee8479..4658d6e 100644
--- 
a/services/console-proxy/server/src/com/cloud/consoleproxy/InputEventType.java
+++ 
b/services/console-proxy/server/src/com/cloud/consoleproxy/InputEventType.java
@@ -17,7 +17,7 @@
 package com.cloud.consoleproxy;
 
 public enum InputEventType {
-MOUSE_MOVE(1), MOUSE_DOWN(2), MOUSE_UP(3), KEY_PRESS(4), KEY_DOWN(5), 
KEY_UP(6), MOUSE_DBLCLICK(8);
+MOUSE_MOVE(1), MOUSE_DOWN(2), MOUSE_UP(3), KEY_PRESS(4), KEY_DOWN(5), 
KEY_UP(6), MOUSE_DBLCLICK(8), MOUSE_SCROLL(9);
 
 int eventCode;
 
@@ -45,6 +45,8 @@ public enum InputEventType {
 return KEY_UP;
 case 8:
 return MOUSE_DBLCLICK;
+case 9:
+return MOUSE_SCROLL;
 default:
 break;

[GitHub] rhtyd commented on issue #2240: CLOUDSTACK-10051 Mouse Scrolling is not working in instance VM console

2017-11-05 Thread GitBox 
rhtyd commented on issue #2240: CLOUDSTACK-10051 Mouse Scrolling is not working 
in instance VM console
URL: https://github.com/apache/cloudstack/pull/2240#issuecomment-342043693
 
 
   tests LGTM, some failures are known intermittent failures comparing against 
#2289 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2240: CLOUDSTACK-10051 Mouse Scrolling is not working in instance VM console

2017-11-05 Thread GitBox 
blueorangutan commented on issue #2240: CLOUDSTACK-10051 Mouse Scrolling is not 
working in instance VM console
URL: https://github.com/apache/cloudstack/pull/2240#issuecomment-342043169
 
 
   Trillian test result (tid-1620)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 31873 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2240-t1620-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_host_annotations.py
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Test completed. 59 look OK, 4 have error(s)
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_vpc_remote_access_vpn | `Failure` | 55.84 | test_vpc_vpn.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 383.60 | 
test_vpc_redundant.py
   test_04_rvpc_privategw_static_routes | `Failure` | 288.75 | 
test_privategw_acl.py
   test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 172.94 | 
test_privategw_acl.py
   test_02_vpc_privategw_static_routes | `Failure` | 162.81 | 
test_privategw_acl.py
   test_01_vpc_privategw_acl | `Failure` | 56.78 | test_privategw_acl.py
   test_05_add_annotation_for_invalid_entityType | `Error` | 0.06 | 
test_host_annotations.py
   test_change_service_offering_for_vm_with_snapshots | Skipped | 0.00 | 
test_vm_snapshots.py
   test_09_copy_delete_template | Skipped | 0.01 | test_templates.py
   test_06_copy_template | Skipped | 0.00 | test_templates.py
   test_static_role_account_acls | Skipped | 0.02 | test_staticroles.py
   test_11_ss_nfs_version_on_ssvm | Skipped | 0.02 | test_ssvm.py
   test_01_scale_vm | Skipped | 0.00 | test_scale_vm.py
   test_01_primary_storage_iscsi | Skipped | 0.08 | test_primary_storage.py
   test_vm_nic_adapter_vmxnet3 | Skipped | 0.00 | test_nic_adapter_type.py
   test_03_nic_multiple_vmware | Skipped | 1.03 | test_nic.py
   test_nested_virtualization_vmware | Skipped | 0.00 | 
test_nested_virtualization.py
   test_06_copy_iso | Skipped | 0.00 | test_iso.py
   test_list_ha_for_host_valid | Skipped | 0.02 | test_hostha_simulator.py
   test_list_ha_for_host_invalid | Skipped | 0.02 | test_hostha_simulator.py
   test_list_ha_for_host | Skipped | 0.02 | test_hostha_simulator.py
   test_hostha_enable_feature_without_setting_provider | Skipped | 0.02 | 
test_hostha_simulator.py
   test_hostha_enable_feature_valid | Skipped | 0.02 | test_hostha_simulator.py
   test_hostha_disable_feature_valid | Skipped | 0.02 | test_hostha_simulator.py
   test_hostha_configure_invalid_provider | Skipped | 0.02 | 
test_hostha_simulator.py
   test_hostha_configure_default_driver | Skipped | 0.03 | 
test_hostha_simulator.py
   test_ha_verify_fsm_recovering | Skipped | 0.02 | test_hostha_simulator.py
   test_ha_verify_fsm_fenced | Skipped | 0.02 | test_hostha_simulator.py
   test_ha_verify_fsm_degraded | Skipped | 0.02 | test_hostha_simulator.py
   test_ha_verify_fsm_available | Skipped | 0.02 | test_hostha_simulator.py
   test_ha_multiple_mgmt_server_ownership | Skipped | 0.02 | 
test_hostha_simulator.py
   test_ha_list_providers | Skipped | 0.02 | test_hostha_simulator.py
   test_ha_enable_feature_invalid | Skipped | 0.02 | test_hostha_simulator.py
   test_ha_disable_feature_invalid | Skipped | 0.02 | test_hostha_simulator.py
   test_ha_configure_enabledisable_across_clusterzones | Skipped | 0.02 | 
test_hostha_simulator.py
   test_configure_ha_provider_valid | Skipped | 0.02 | test_hostha_simulator.py
   test_configure_ha_provider_invalid | Skipped | 0.02 | 
test_hostha_simulator.py
   test_deploy_vgpu_enabled_vm | Skipped | 0.03 | test_deploy_vgpu_enabled_vm.py
   test_3d_gpu_support | Skipped | 0.03 | test_deploy_vgpu_enabled_vm.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mrunalinikankariya commented on issue #2273: CLOUDSTACK-10090:createPortForwardingRule api call accepts 'halt' as ?

2017-11-05 Thread GitBox 
mrunalinikankariya commented on issue #2273: 
CLOUDSTACK-10090:createPortForwardingRule api call accepts 'halt' as ?
URL: https://github.com/apache/cloudstack/pull/2273#issuecomment-342038747
 
 
   @rhtyd Could you merge this please


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mrunalinikankariya commented on issue #2242: CLOUDSTACK-9958:Include tags of resources in listUsageRecords API

2017-11-05 Thread GitBox 
mrunalinikankariya commented on issue #2242: CLOUDSTACK-9958:Include tags of 
resources in listUsageRecords API
URL: https://github.com/apache/cloudstack/pull/2242#issuecomment-342038691
 
 
   @rhtyd Could you merge this please?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2304: CLOUDSTACK-10127: KVM + Ovs: Incorrect devId on static nat

2017-11-05 Thread GitBox 
blueorangutan commented on issue #2304: CLOUDSTACK-10127: KVM + Ovs: Incorrect 
devId on static nat
URL: https://github.com/apache/cloudstack/pull/2304#issuecomment-342031060
 
 
   Trillian test result (tid-1619)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 35255 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2304-t1619-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermitten failure detected: /marvin/tests/smoke/test_iso.py
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_routers_iptables_default_policy.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Test completed. 48 look OK, 6 have error(s)
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_VPC_default_routes | `Failure` | 893.04 | test_vpc_router_nics.py
   test_01_VPC_nics_after_destroy | `Failure` | 822.59 | test_vpc_router_nics.py
   test_04_rvpc_privategw_static_routes | `Failure` | 1004.25 | 
test_privategw_acl.py
   test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 984.15 | 
test_privategw_acl.py
   test_02_vpc_privategw_static_routes | `Failure` | 908.70 | 
test_privategw_acl.py
   test_05_iso_permissions | `Failure` | 0.04 | test_iso.py
   test_02_edit_iso | `Failure` | 0.04 | test_iso.py
   test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Failure` | 236.22 | 
test_internal_lb.py
   test_01_vpc_site2site_vpn | `Error` | 362.93 | test_vpc_vpn.py
   test_01_single_VPC_iptables_policies | `Error` | 867.35 | 
test_routers_iptables_default_policy.py
   test_03_vpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 251.53 | 
test_internal_lb.py
   test_03_delete_vm_snapshots | Skipped | 0.00 | test_vm_snapshots.py
   test_02_revert_vm_snapshots | Skipped | 0.00 | test_vm_snapshots.py
   test_01_create_vm_snapshots | Skipped | 0.00 | test_vm_snapshots.py
   test_09_copy_delete_template | Skipped | 0.01 | test_templates.py
   test_06_copy_template | Skipped | 0.00 | test_templates.py
   test_static_role_account_acls | Skipped | 0.01 | test_staticroles.py
   test_01_scale_vm | Skipped | 0.00 | test_scale_vm.py
   test_01_primary_storage_iscsi | Skipped | 0.03 | test_primary_storage.py
   test_vm_nic_adapter_vmxnet3 | Skipped | 0.00 | test_nic_adapter_type.py
   test_06_copy_iso | Skipped | 0.00 | test_iso.py
   test_deploy_vgpu_enabled_vm | Skipped | 0.01 | test_deploy_vgpu_enabled_vm.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2240: CLOUDSTACK-10051 Mouse Scrolling is not working in instance VM console

2017-11-05 Thread GitBox 
blueorangutan commented on issue #2240: CLOUDSTACK-10051 Mouse Scrolling is not 
working in instance VM console
URL: https://github.com/apache/cloudstack/pull/2240#issuecomment-341998479
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2240: CLOUDSTACK-10051 Mouse Scrolling is not working in instance VM console

2017-11-05 Thread GitBox 
rhtyd commented on issue #2240: CLOUDSTACK-10051 Mouse Scrolling is not working 
in instance VM console
URL: https://github.com/apache/cloudstack/pull/2240#issuecomment-341998411
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2240: CLOUDSTACK-10051 Mouse Scrolling is not working in instance VM console

2017-11-05 Thread GitBox 
blueorangutan commented on issue #2240: CLOUDSTACK-10051 Mouse Scrolling is not 
working in instance VM console
URL: https://github.com/apache/cloudstack/pull/2240#issuecomment-341987892
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1209


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2304: CLOUDSTACK-10127: KVM + Ovs: Incorrect devId on static nat

2017-11-05 Thread GitBox 
rhtyd commented on issue #2304: CLOUDSTACK-10127: KVM + Ovs: Incorrect devId on 
static nat
URL: https://github.com/apache/cloudstack/pull/2304#issuecomment-341986941
 
 
   @blueorangutan test
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2304: CLOUDSTACK-10127: KVM + Ovs: Incorrect devId on static nat

2017-11-05 Thread GitBox 
blueorangutan commented on issue #2304: CLOUDSTACK-10127: KVM + Ovs: Incorrect 
devId on static nat
URL: https://github.com/apache/cloudstack/pull/2304#issuecomment-341986987
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2304: CLOUDSTACK-10127: KVM + Ovs: Incorrect devId on static nat

2017-11-05 Thread GitBox 
blueorangutan commented on issue #2304: CLOUDSTACK-10127: KVM + Ovs: Incorrect 
devId on static nat
URL: https://github.com/apache/cloudstack/pull/2304#issuecomment-341986778
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1208


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #1470: Make the generated json files unique to prevent concurrency issues

2017-11-05 Thread GitBox 
rhtyd commented on issue #1470: Make the generated json files unique to prevent 
concurrency issues
URL: https://github.com/apache/cloudstack/pull/1470#issuecomment-341986602
 
 
   @remibergsma ping, can you rebase against master?
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #1203: Fix vm cannot register and poweron on vcenter

2017-11-05 Thread GitBox 
rhtyd commented on issue #1203: Fix vm cannot register and poweron on vcenter 
URL: https://github.com/apache/cloudstack/pull/1203#issuecomment-341986564
 
 
   @ghxandsky can you fix conflicts, thanks


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2112: Add Datera CloudStack Storage Plugin 4.10.0.0

2017-11-05 Thread GitBox 
rhtyd commented on issue #2112: Add Datera CloudStack Storage Plugin 4.10.0.0
URL: https://github.com/apache/cloudstack/pull/2112#issuecomment-341986528
 
 
   Is this still WIP or experimental/PoC or you would want some feedback on 
this @jcshen007 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2099: CLOUDSTACK-8612 [VMware] Make vCenter session timeout configurable for volume snapshot

2017-11-05 Thread GitBox 
rhtyd commented on issue #2099: CLOUDSTACK-8612 [VMware] Make vCenter session 
timeout configurable for volume snapshot
URL: https://github.com/apache/cloudstack/pull/2099#issuecomment-341986492
 
 
   @sureshanaparti looks like good feature, can you rebase, fix conflicts, move 
schema change to 4.10->4.11 path?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #1832: CLOUDSTACK-9652 Job framework - Cancelling async jobs

2017-11-05 Thread GitBox 
rhtyd commented on issue #1832: CLOUDSTACK-9652 Job framework - Cancelling 
async jobs
URL: https://github.com/apache/cloudstack/pull/1832#issuecomment-341986432
 
 
   Ping @karuturi -- looks like good feature, can you fix conflicts?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2240: CLOUDSTACK-10051 Mouse Scrolling is not working in instance VM console

2017-11-05 Thread GitBox 
blueorangutan commented on issue #2240: CLOUDSTACK-10051 Mouse Scrolling is not 
working in instance VM console
URL: https://github.com/apache/cloudstack/pull/2240#issuecomment-341986215
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2240: CLOUDSTACK-10051 Mouse Scrolling is not working in instance VM console

2017-11-05 Thread GitBox 
rhtyd commented on issue #2240: CLOUDSTACK-10051 Mouse Scrolling is not working 
in instance VM console
URL: https://github.com/apache/cloudstack/pull/2240#issuecomment-341986187
 
 
   I went ahead and added the missing license from the newly added file.
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2204: [CLOUDSTACK-10025] Adding Support for NoVNC Console for KVM and XENSERVER

2017-11-05 Thread GitBox 
rhtyd commented on issue #2204: [CLOUDSTACK-10025] Adding Support for NoVNC 
Console for KVM and XENSERVER
URL: https://github.com/apache/cloudstack/pull/2204#issuecomment-341985286
 
 
   @sachinnitw1317 here are the issues I faced:
   
   If the console is opened normally (the old console/tile-based proxy), every 
new tab opened will invalidate the session of the older (previously opened 
window/console). However, this does not happen with novnc based console which 
fails to get/load the websocket URL (upgrade url fails) if the console for the 
same VM was previously opened with older vnc (tile-based, the `/ajax` path) 
provider.
   
   The other issue I'm seeing is when I copy and use the console url and append 
`websocketconsole=true`, it does open `/novnc/` path in the iframe however, 
it's bit flaky. For example, if I open the window more than once, the older 
session/tab/popup should be invalidated without which sometimes what happens is 
console does open but is not responsive to inputs (keyboard strokes). I've 
tested this so far only on KVM, I'm planning to do the same for VMware and 
XenServer next week. /cc @syed 
   
   Rebasing notes: I've rebased and fixed conflicts on your branch against 
latest master, if you wish to work on it please do a git pull --rebase  
 against your local branch. Thanks.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2204: [CLOUDSTACK-10025] Adding Support for NoVNC Console for KVM and XENSERVER

2017-11-05 Thread GitBox 
rhtyd commented on issue #2204: [CLOUDSTACK-10025] Adding Support for NoVNC 
Console for KVM and XENSERVER
URL: https://github.com/apache/cloudstack/pull/2204#issuecomment-341985286
 
 
   @sachinnitw1317 here are the issues I faced:
   
   If the console is opened normally (the old console/tile-based proxy), every 
new tab opened will invalidate the session of the older (previously opened 
window/console). However, this does not happen with novnc based console which 
fails to get/load the websocket URL (upgrade url fails) if the console for the 
same VM was previously opened with older vnc (tile-based, the `/ajax` path) 
provider.
   
   The other issue I'm seeing is when I copy and use the console url and append 
`websocketconsole=true`, it does open `/novnc/` path in the iframe however, 
it's bit flaky. For example, if I open the window more than once, the older 
session/tab/popup should be invalidated without which sometimes what happens is 
console does open but is not responsive to inputs (keyboard strokes). I've 
tested this so far only on KVM, I'm planning to do the same for VMware and 
XenServer next week. /cc @syed 
   
   Rebasing notes: I've rebased and fixed conflicts on your branch against 
latest master, if you wish to work on it please do a git pull --rebase 
` ` against your local branch. Thanks.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2304: CLOUDSTACK-10127: KVM + Ovs: Incorrect devId on static nat

2017-11-05 Thread GitBox 
blueorangutan commented on issue #2304: CLOUDSTACK-10127: KVM + Ovs: Incorrect 
devId on static nat
URL: https://github.com/apache/cloudstack/pull/2304#issuecomment-341984792
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2304: CLOUDSTACK-10127: KVM + Ovs: Incorrect devId on static nat

2017-11-05 Thread GitBox 
rhtyd commented on issue #2304: CLOUDSTACK-10127: KVM + Ovs: Incorrect devId on 
static nat
URL: https://github.com/apache/cloudstack/pull/2304#issuecomment-341984757
 
 
   Several failures seen, I'll rerun tests.
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2158: CLOUDSTACK-9972: Enhance listVolume API to include physical size and ?

2017-11-05 Thread GitBox 
rhtyd commented on issue #2158: CLOUDSTACK-9972: Enhance listVolume API to 
include physical size and ?
URL: https://github.com/apache/cloudstack/pull/2158#issuecomment-341984657
 
 
   LGTM, thanks.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd closed pull request #2158: CLOUDSTACK-9972: Enhance listVolume API to include physical size and ?

2017-11-05 Thread GitBox 
rhtyd closed pull request #2158: CLOUDSTACK-9972: Enhance listVolume API to 
include physical size and ?
URL: https://github.com/apache/cloudstack/pull/2158
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/core/src/com/cloud/agent/api/GetFileStatsCommand.java 
b/api/src/com/cloud/agent/api/BadCommand.java
similarity index 71%
rename from core/src/com/cloud/agent/api/GetFileStatsCommand.java
rename to api/src/com/cloud/agent/api/BadCommand.java
index b2da1c31647..55976f64185 100644
--- a/core/src/com/cloud/agent/api/GetFileStatsCommand.java
+++ b/api/src/com/cloud/agent/api/BadCommand.java
@@ -1,4 +1,3 @@
-//
 // Licensed to the Apache Software Foundation (ASF) under one
 // or more contributor license agreements.  See the NOTICE file
 // distributed with this work for additional information
@@ -15,30 +14,17 @@
 // KIND, either express or implied.  See the License for the
 // specific language governing permissions and limitations
 // under the License.
-//
-
 package com.cloud.agent.api;
 
-import com.cloud.agent.api.LogLevel.Log4jLevel;
-import com.cloud.storage.Volume;
-
-@LogLevel(Log4jLevel.Trace)
-public class GetFileStatsCommand extends Command {
-protected GetFileStatsCommand() {
-}
-
-String paths;
-
-public GetFileStatsCommand(Volume volume) {
-paths = volume.getPath();
-}
-
-public String getPaths() {
-return paths;
-}
+public class BadCommand extends Command {
 
 @Override
 public boolean executeInSequence() {
+// TODO Auto-generated method stub
 return false;
 }
+
+public BadCommand(){
+super();
+}
 }
diff --git a/api/src/com/cloud/storage/VolumeStats.java 
b/api/src/com/cloud/storage/VolumeStats.java
index 70c0b17f84a..81fa7eabdd7 100644
--- a/api/src/com/cloud/storage/VolumeStats.java
+++ b/api/src/com/cloud/storage/VolumeStats.java
@@ -20,5 +20,10 @@
 /**
  * @return bytes used by the volume
  */
-public long getBytesUsed();
+long getVirtualSize();
+
+/**
+ * @return bytes allocated
+ */
+long getPhysicalSize();
 }
diff --git a/api/src/org/apache/cloudstack/api/ApiConstants.java 
b/api/src/org/apache/cloudstack/api/ApiConstants.java
index 1ec340df1e8..2a2d686591d 100644
--- a/api/src/org/apache/cloudstack/api/ApiConstants.java
+++ b/api/src/org/apache/cloudstack/api/ApiConstants.java
@@ -85,6 +85,7 @@
 public static final String DEVICE_ID = "deviceid";
 public static final String DISK_OFFERING_ID = "diskofferingid";
 public static final String DISK_SIZE = "disksize";
+public static final String UTILIZATION = "utilization";
 public static final String DRIVER = "driver";
 public static final String ROOT_DISK_SIZE = "rootdisksize";
 public static final String DISPLAY_NAME = "displayname";
@@ -205,6 +206,7 @@
 public static final String SSHKEY_ENABLED = "sshkeyenabled";
 public static final String PATH = "path";
 public static final String POD_ID = "podid";
+public static final String POD_NAME = "podname";
 public static final String POD_IDS = "podids";
 public static final String POLICY_ID = "policyid";
 public static final String PORT = "port";
diff --git 
a/api/src/org/apache/cloudstack/api/command/user/volume/ListVolumesCmd.java 
b/api/src/org/apache/cloudstack/api/command/user/volume/ListVolumesCmd.java
index 059def7c167..554e029fc48 100644
--- a/api/src/org/apache/cloudstack/api/command/user/volume/ListVolumesCmd.java
+++ b/api/src/org/apache/cloudstack/api/command/user/volume/ListVolumesCmd.java
@@ -26,6 +26,7 @@
 import org.apache.cloudstack.api.BaseListTaggedResourcesCmd;
 import org.apache.cloudstack.api.Parameter;
 import org.apache.cloudstack.api.ResponseObject.ResponseView;
+import org.apache.cloudstack.api.response.ClusterResponse;
 import org.apache.cloudstack.api.response.DiskOfferingResponse;
 import org.apache.cloudstack.api.response.HostResponse;
 import org.apache.cloudstack.api.response.ListResponse;
@@ -63,6 +64,9 @@
 @Parameter(name = ApiConstants.POD_ID, type = CommandType.UUID, entityType 
= PodResponse.class, description = "the pod id the disk volume belongs to")
 private Long podId;
 
+@Parameter(name = ApiConstants.CLUSTER_ID, type = CommandType.UUID, 
entityType = ClusterResponse.class, description = "the cluster id the disk 
volume belongs to", authorized = {RoleType.Admin})
+private Long clusterId;
+
 @Parameter(name = ApiConstants.TYPE, type = CommandType.STRING, 
description = "the type of disk volume")
 private String type;
 
@@ -98,6 +102,10 @@ public Long getHostId() {
 return hostId;
 }
 
+public Long getClusterId() {
+return clusterId;
+}
+
 public Long getId() {
 return id;
 }

[cloudstack] branch master updated: CLOUDSTACK-9972: Enhance listVolume API to include physical size and … (#2158)

2017-11-05 Thread bhaisaab 
This is an automated email from the ASF dual-hosted git repository.

bhaisaab pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/master by this push:
 new 4627fb2  CLOUDSTACK-9972: Enhance listVolume API to include physical 
size and … (#2158)
4627fb2 is described below

commit 4627fb2cd7556173bd7e58bf1bec22c93a78f31d
Author: Abhinandan Prateek 
AuthorDate: Sun Nov 5 21:44:43 2017 +0530

CLOUDSTACK-9972: Enhance listVolume API to include physical size and … 
(#2158)

* CLOUDSTACK-9972: Enhance listVolume API to include physical size and 
utilization.
Also fixed pool, cluster and pod info

* CLOUDSTACK-9972: Fix volume_view and duplicate API constant

* CLOUDSTACK-9972: Backport Do not allow vms to be deployed on hosts that 
are in disabled pod

* CLOUDSTACK-9972: Fix localization missing keys

* CLOUDSTACK-9972: Fix sql path
---
 .../src/com/cloud/agent/api/BadCommand.java|  26 +---
 api/src/com/cloud/storage/VolumeStats.java |   7 +-
 .../org/apache/cloudstack/api/ApiConstants.java|   2 +
 .../api/command/user/volume/ListVolumesCmd.java|   8 ++
 .../cloudstack/api/response/VolumeResponse.java|  88 -
 .../com/cloud/agent/api/GetFileStatsAnswer.java|  41 --
 .../com/cloud/agent/api/GetVmDiskStatsCommand.java |   4 +
 .../com/cloud/agent/api/GetVolumeStatsAnswer.java  |  73 +++
 .../com/cloud/agent/api/GetVolumeStatsCommand.java |  75 +++
 core/src/com/cloud/agent/api/VolumeStatsEntry.java |  64 ++
 core/src/com/cloud/agent/transport/Request.java|   3 +
 .../com/cloud/agent/transport/RequestTest.java |  26 +++-
 .../LibvirtGetVolumeStatsCommandWrapper.java   |  66 ++
 .../hypervisor/kvm/storage/KVMPhysicalDisk.java|   5 +
 .../hypervisor/kvm/storage/LibvirtStoragePool.java |   3 +-
 .../hypervisor/vmware/resource/VmwareResource.java |  43 +++
 .../CitrixGetVolumeStatsCommandWrapper.java|  62 +
 server/src/com/cloud/api/ApiDBUtils.java   |   5 +
 .../src/com/cloud/api/query/QueryManagerImpl.java  |   4 +
 .../com/cloud/api/query/ViewResponseHelper.java|  26 
 .../com/cloud/api/query/dao/VolumeJoinDaoImpl.java |   6 +
 .../src/com/cloud/api/query/vo/VolumeJoinVO.java   |  47 +++
 server/src/com/cloud/configuration/Config.java |   2 +
 .../deploy/DeploymentPlanningManagerImpl.java  |  88 +++--
 server/src/com/cloud/server/StatsCollector.java|  68 --
 server/src/com/cloud/test/DatabaseConfig.java  |   2 +-
 server/src/com/cloud/vm/UserVmManager.java |   4 +
 server/src/com/cloud/vm/UserVmManagerImpl.java |  22 
 setup/db/db/schema-41000to41100.sql| 139 -
 test/integration/smoke/test_volumes.py |  74 ++-
 ui/l10n/ar.js  |   3 +
 ui/l10n/ca.js  |   3 +
 ui/l10n/de_DE.js   |   3 +
 ui/l10n/en.js  |   3 +
 ui/l10n/es.js  |   3 +
 ui/l10n/fr_FR.js   |   3 +
 ui/l10n/hu.js  |   3 +
 ui/l10n/it_IT.js   |   3 +
 ui/l10n/ja_JP.js   |   3 +
 ui/l10n/ko_KR.js   |   3 +
 ui/l10n/nb_NO.js   |   3 +
 ui/l10n/nl_NL.js   |   3 +
 ui/l10n/pl.js  |   3 +
 ui/l10n/pt_BR.js   |   3 +
 ui/l10n/ru_RU.js   |   3 +
 ui/l10n/zh_CN.js   |   3 +
 ui/scripts/metrics.js  |  12 ++
 ui/scripts/storage.js  |  29 -
 .../cloud/hypervisor/vmware/mo/DatastoreMO.java|  32 +
 .../hypervisor/vmware/mo/VirtualMachineMO.java |  53 
 50 files changed, 1139 insertions(+), 118 deletions(-)

diff --git a/core/src/com/cloud/agent/api/GetFileStatsCommand.java 
b/api/src/com/cloud/agent/api/BadCommand.java
similarity index 71%
rename from core/src/com/cloud/agent/api/GetFileStatsCommand.java
rename to api/src/com/cloud/agent/api/BadCommand.java
index b2da1c3..55976f6 100644
--- a/core/src/com/cloud/agent/api/GetFileStatsCommand.java
+++ b/api/src/com/cloud/agent/api/BadCommand.java
@@ -1,4 +1,3 @@
-//
 // Licensed to the Apache Software Foundation (ASF) under one
 // or more contributor license agreements.  See the NOTICE file
 // distributed with this work for additional information
@@ -15,30 +14,17 @@
 // KIND, either express or implied.  See the License for the
 // specific language governing permissions and limitations
 // under the

[GitHub] nvazquez commented on issue #2158: CLOUDSTACK-9972: Enhance listVolume API to include physical size and ?

2017-11-05 Thread GitBox 
nvazquez commented on issue #2158: CLOUDSTACK-9972: Enhance listVolume API to 
include physical size and ?
URL: https://github.com/apache/cloudstack/pull/2158#issuecomment-341981033
 
 
   Done, thanks @rhtyd 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2267: CLOUDSTACK-10077: allow to have different VPN customer gateway configs for same gateway IP

2017-11-05 Thread GitBox 
rhtyd commented on issue #2267: CLOUDSTACK-10077: allow to have different VPN 
customer gateway configs for same gateway IP
URL: https://github.com/apache/cloudstack/pull/2267#issuecomment-341960768
 
 
   LGTM, not sure any side-effects on this change. Others may help review - 
@DaanHoogland @marcaurele @swill @PaulAngus ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services