[cloudstack] 02/02: systemvm fixes

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch debian9-systemvmtemplate
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit 652e5e08ec5f1522b0329c46a57d12ba3088ce29
Author: Rohit Yadav 
AuthorDate: Tue Dec 12 13:13:57 2017 +0530

systemvm fixes

Signed-off-by: Rohit Yadav 
---
 .../appliance/definitions/systemvmtemplate/apt_upgrade.sh  | 14 --
 tools/appliance/definitions/systemvmtemplate/cleanup.sh|  2 +-
 tools/appliance/definitions/systemvmtemplate/definition.rb |  2 +-
 tools/appliance/definitions/systemvmtemplate/finalize.sh   | 11 +--
 tools/appliance/definitions/systemvmtemplate/preseed.cfg   |  7 +--
 5 files changed, 16 insertions(+), 20 deletions(-)

diff --git a/tools/appliance/definitions/systemvmtemplate/apt_upgrade.sh 
b/tools/appliance/definitions/systemvmtemplate/apt_upgrade.sh
index 1a72b3a..4d5ff26 100644
--- a/tools/appliance/definitions/systemvmtemplate/apt_upgrade.sh
+++ b/tools/appliance/definitions/systemvmtemplate/apt_upgrade.sh
@@ -19,6 +19,17 @@
 set -e
 set -x
 
+# Perform fsck check on every 2nd boot
+function fix_tune2fs() {
+  for partition in $(blkid -o list | grep ext | awk '{print $1}')
+  do
+tune2fs -m 1 $partition
+tune2fs -c 2 $partition
+  done
+  fdisk -l
+  df -h
+}
+
 function add_backports() {
   sed -i '/cdrom/d' /etc/apt/sources.list
   sed -i '/deb-src/d' /etc/apt/sources.list
@@ -30,8 +41,7 @@ function apt_upgrade() {
   DEBIAN_FRONTEND=noninteractive
   DEBIAN_PRIORITY=critical
 
-  fdisk -l
-  df -h
+  fix_tune2fs
 
   # Setup sudo
   echo 'cloud ALL=(ALL) NOPASSWD: ALL' > /etc/sudoers.d/cloud
diff --git a/tools/appliance/definitions/systemvmtemplate/cleanup.sh 
b/tools/appliance/definitions/systemvmtemplate/cleanup.sh
index fd7d9f3..eed29af 100644
--- a/tools/appliance/definitions/systemvmtemplate/cleanup.sh
+++ b/tools/appliance/definitions/systemvmtemplate/cleanup.sh
@@ -21,7 +21,7 @@ set -x
 
 function cleanup_apt() {
   apt-get -y remove --purge dictionaries-common busybox isc-dhcp-client 
isc-dhcp-common \
-task-english task-ssh-server tasksel tasksel-data laptop-detect nano 
wamerican \
+task-english task-ssh-server tasksel tasksel-data laptop-detect wamerican \
 debconf-i18n sharutils gnupg gnupg-agent
 
   apt-get -y autoremove --purge
diff --git a/tools/appliance/definitions/systemvmtemplate/definition.rb 
b/tools/appliance/definitions/systemvmtemplate/definition.rb
index b5e4da2..917dd77 100644
--- a/tools/appliance/definitions/systemvmtemplate/definition.rb
+++ b/tools/appliance/definitions/systemvmtemplate/definition.rb
@@ -36,7 +36,7 @@ architectures = {
 config = {
 :cpu_count => '1',
 :memory_size => '512',
-:disk_size => '2500', :disk_format => 'VDI', :hostiocache => 'off',
+:disk_size => '2000', :disk_format => 'VDI', :hostiocache => 'off',
 :iso_download_timeout => '1000',
 :boot_wait => '10',
 :boot_cmd_sequence => [
diff --git a/tools/appliance/definitions/systemvmtemplate/finalize.sh 
b/tools/appliance/definitions/systemvmtemplate/finalize.sh
index 82d17b9..febae7b 100644
--- a/tools/appliance/definitions/systemvmtemplate/finalize.sh
+++ b/tools/appliance/definitions/systemvmtemplate/finalize.sh
@@ -49,19 +49,11 @@ function cleanup_veewee() {
   rm -fv .veewee_version .veewee_params .vbox_version
 }
 
-# Perform fsck check on every 2nd boot
-function fix_tune2fs() {
-  for partition in $(blkid -o list | grep ext | awk '{print $1}')
-  do
-tune2fs -c 2 $partition
-  done
-}
-
 # Zero out the free space to save space in the final image:
 function zero_disk() {
   df -h
   fstrim -av
-  for path in / /boot /var /var/log /tmp
+  for path in / /boot /var/log /tmp
   do
 dd if=/dev/zero of=${path}/zero bs=1M || true
 sync
@@ -73,7 +65,6 @@ function finalize() {
   configure_misc
   configure_sudoers
   cleanup_veewee
-  fix_tune2fs
   sync
   zero_disk
   halt -p
diff --git a/tools/appliance/definitions/systemvmtemplate/preseed.cfg 
b/tools/appliance/definitions/systemvmtemplate/preseed.cfg
index 60bd9a8..217c515 100644
--- a/tools/appliance/definitions/systemvmtemplate/preseed.cfg
+++ b/tools/appliance/definitions/systemvmtemplate/preseed.cfg
@@ -63,16 +63,11 @@ d-i partman-auto/expert_recipe string   
  \
   use_filesystem{ } filesystem{ ext2 }\
   mountpoint{ /boot } \
   .   \
-  1300 40 1500 ext4   \
+  1350 40 1500 ext4   \
   method{ format } format{ }  \
   use_filesystem{ } filesystem{ ext4 }\
   mountpoint{ / } \
   .   \
-  

[cloudstack] 01/02: more fixes

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch debian9-systemvmtemplate
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit ff3de93116d2f0de8d35c220b4856db37b854792
Author: Rohit Yadav 
AuthorDate: Tue Dec 12 12:31:33 2017 +0530

more fixes

Signed-off-by: Rohit Yadav 
---
 .../cloudstack/framework/jobs/impl/AsyncJobManagerImpl.java  |  4 
 server/src/com/cloud/server/StatsCollector.java  | 12 ++--
 systemvm/debian/etc/issue|  2 +-
 test/integration/smoke/test_nic.py   |  6 +++---
 test/integration/smoke/test_service_offerings.py |  2 +-
 5 files changed, 19 insertions(+), 7 deletions(-)

diff --git 
a/framework/jobs/src/org/apache/cloudstack/framework/jobs/impl/AsyncJobManagerImpl.java
 
b/framework/jobs/src/org/apache/cloudstack/framework/jobs/impl/AsyncJobManagerImpl.java
index 7f2e156..3ce96a6 100644
--- 
a/framework/jobs/src/org/apache/cloudstack/framework/jobs/impl/AsyncJobManagerImpl.java
+++ 
b/framework/jobs/src/org/apache/cloudstack/framework/jobs/impl/AsyncJobManagerImpl.java
@@ -216,6 +216,10 @@ public class AsyncJobManagerImpl extends ManagerBase 
implements AsyncJobManager,
 @SuppressWarnings("rawtypes")
 final GenericDao dao = GenericDaoBase.getDao(job.getClass());
 
+if (dao == null) {
+throw new CloudRuntimeException(String.format("Failed to get 
dao from job's class=%s, for job id=%d, cmd=%s", job.getClass(), job.getId(), 
job.getCmd()));
+}
+
 publishOnEventBus(job, "submit");
 
 if (!_vmInstanceDao.lockInLockTable(String.valueOf(syncObjId), 
VmJobLockTimeout.value())){
diff --git a/server/src/com/cloud/server/StatsCollector.java 
b/server/src/com/cloud/server/StatsCollector.java
index 305711e..96b51f5 100644
--- a/server/src/com/cloud/server/StatsCollector.java
+++ b/server/src/com/cloud/server/StatsCollector.java
@@ -918,7 +918,12 @@ public class StatsCollector extends ManagerBase implements 
ComponentMethodInterc
 try {
 HashMap volumeStatsByUuid = 
_userVmMgr.getVolumeStatistics(pool.getClusterId(), pool.getUuid(), 
pool.getPoolType(), volumeLocators, StatsTimeout.value());
 if (volumeStatsByUuid != null){
-_volumeStats.putAll(volumeStatsByUuid);
+for (final Map.Entry 
entry : volumeStatsByUuid.entrySet()) {
+if (entry == null || entry.getKey() == null || 
entry.getValue() == null) {
+continue;
+}
+_volumeStats.put(entry.getKey(), 
entry.getValue());
+}
 }
 } catch (Exception e) {
 s_logger.warn("Failed to get volume stats for cluster 
with ID: " + pool.getClusterId(), e);
@@ -932,7 +937,10 @@ public class StatsCollector extends ManagerBase implements 
ComponentMethodInterc
 }
 
 public VolumeStats getVolumeStats(String volumeLocator) {
-return _volumeStats.get(volumeLocator);
+if (_volumeStats.containsKey(volumeLocator)) {
+return _volumeStats.get(volumeLocator);
+}
+return null;
 }
 
 class StorageCollector extends ManagedContextRunnable {
diff --git a/systemvm/debian/etc/issue b/systemvm/debian/etc/issue
index 94e8f84..84a2d1e 100644
--- a/systemvm/debian/etc/issue
+++ b/systemvm/debian/etc/issue
@@ -1,4 +1,4 @@
-   __?.o/  Apache CloudStack SystemVM 4.11
+   __?.o/  Apache CloudStack SystemVM
   (  )#https://cloudstack.apache.org
  (___(_)   \s \r \n \l
 
diff --git a/test/integration/smoke/test_nic.py 
b/test/integration/smoke/test_nic.py
index 584ccf5..c7f8468 100644
--- a/test/integration/smoke/test_nic.py
+++ b/test/integration/smoke/test_nic.py
@@ -22,7 +22,7 @@ from marvin.lib.base import (Account,
  VirtualMachine,
  NetworkOffering)
 from marvin.lib.common import (get_zone,
-   get_test_template,
+   get_template,
get_domain)
 from marvin.lib.utils import validateList
 from marvin.codes import PASS
@@ -76,10 +76,10 @@ class TestNic(cloudstackTestCase):
 self.services["service_offerings"][
 "tiny"]["storagetype"] = 'local'
 
-template = get_test_template(
+template = get_template(
 self.apiclient,
 self.zone.id,
-self.hypervisor
+self.services["ostype"]
 )
 # Set Zones and disk offerings
 

[cloudstack] branch debian9-systemvmtemplate updated (c666485 -> 652e5e0)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a change to branch debian9-systemvmtemplate
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


from c666485  fixes
 new ff3de93  more fixes
 new 652e5e0  systemvm fixes

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .../framework/jobs/impl/AsyncJobManagerImpl.java   |  4 
 server/src/com/cloud/server/StatsCollector.java| 12 ++--
 systemvm/debian/etc/issue  |  2 +-
 test/integration/smoke/test_nic.py |  6 +++---
 test/integration/smoke/test_service_offerings.py   |  2 +-
 .../appliance/definitions/systemvmtemplate/apt_upgrade.sh  | 14 --
 tools/appliance/definitions/systemvmtemplate/cleanup.sh|  2 +-
 tools/appliance/definitions/systemvmtemplate/definition.rb |  2 +-
 tools/appliance/definitions/systemvmtemplate/finalize.sh   | 11 +--
 tools/appliance/definitions/systemvmtemplate/preseed.cfg   |  7 +--
 10 files changed, 35 insertions(+), 27 deletions(-)

-- 
To stop receiving notification emails like this one, please contact
['"commits@cloudstack.apache.org" '].

[GitHub] blueorangutan commented on issue #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

[GitBox]

blueorangutan commented on issue #2211: CLOUDSTACK-10013: Migrate 
systemvmtemplate to Debian9
URL: https://github.com/apache/cloudstack/pull/2211#issuecomment-350915685
 
 
   Trillian test result (tid-1771)
   Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 31622 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2211-t1771-xenserver-65sp1.zip
   Test completed. Failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_deploy_vm_from_iso | `Error` | 761.54 | test_deploy_vm_iso.py
   test_01_nic | `Error` | 278.05 | test_nic.py
   test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Failure` | 473.97 | 
test_internal_lb.py
   test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Error` | 
1348.13 | test_routers_network_ops.py
   test_04_change_offering_small | `Failure` | 65.64 | test_service_offerings.py
   test_01_volume_usage | `Error` | 20.75 | test_usage.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 433.12 | 
test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Failure` | 379.27 | test_vpc_redundant.py
   test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 116.42 | 
test_host_maintenance.py
   
   
   Tests ran manually:
   
   ```py
   test_deploy_vm_iso.py
   Test Deploy Virtual Machine from ISO ... === TestName: 
test_deploy_vm_from_iso | Status : SUCCESS ===
   ok
   Ran 1 test in 102.014s
   OK
   
   
   test_internal_lb.py:
   Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's in a Single VPC ... === TestName: 
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Status : SUCCESS ===
   ok
   Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's in a Redundant VPC ... === TestName: 
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | Status : SUCCESS ===
   ok
   Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test_03_vpc_internallb_haproxy_stats_on_all_interfaces | Status : 
SUCCESS ===
   ok
   Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | Status : 
SUCCESS ===
   ok
   Ran 4 tests in 1906.554s
   OK
   
   
   test_nic.py:
   Test to add and update added nic to a virtual machine ... === TestName: 
test_01_nic | Status : SUCCESS ===
   ok
   Test to adding multiple nics to a VMware VM and restarting VM ... SKIP: 
Skipping test applicable for VMware
   Ran 2 tests in 631.528s
   OK (SKIP=1)
   
   test_routers_network_ops.py:
   Test redundant router internals ... === TestName: 
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
   ok
   Test redundant router internals ... === TestName: 
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
   ok
   Test redundant router internals ... === TestName: 
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
   ok
   Test redundant router internals ... === TestName: 
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
   ok
   Test redundant router internals ... === TestName: 
test_03_RVR_Network_check_router_state | Status : SUCCESS ===
   ok
   Ran 5 tests in 1220.687s
   OK
   
   test_service_offerings.py:
   Test to create service offering ... === TestName: 
test_01_create_service_offering | Status : SUCCESS ===
   ok
   Test to update existing service offering ... === TestName: 
test_02_edit_service_offering | Status : SUCCESS ===
   ok
   Test to delete service offering ... === TestName: 
test_03_delete_service_offering | Status : SUCCESS ===
   ok
   Test to change service to a small capacity ... === TestName: 
test_04_change_offering_small | Status : SUCCESS ===
   ok
   Ran 4 tests in 175.167s
   OK
   
   
   test_host_maintenance:
   test_01_cancel_host_maintenace_with_no_migration_jobs 
(tests.smoke.test_host_maintenance.TestHostMaintenance) ... === TestName: 
test_01_cancel_host_maintenace_with_no_migration_jobs | Status : SUCCESS ===
   ok
   test_02_cancel_host_maintenace_with_migration_jobs 
(tests.smoke.test_host_maintenance.TestHostMaintenance) ... === TestName: 
test_02_cancel_host_maintenace_with_migration_jobs | Status : SUCCESS ===
   ok
   Ran 2 tests in 302.243s
   OK
   
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

[GitBox]

blueorangutan commented on issue #2211: CLOUDSTACK-10013: Migrate 
systemvmtemplate to Debian9
URL: https://github.com/apache/cloudstack/pull/2211#issuecomment-350911659
 
 
   Trillian test result (tid-1768)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 30882 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2211-t1768-kvm-centos7.zip
   Test completed. Failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_10_project_activation | `Error` | 3620.74 | test_projects.py
   test_03_RVR_Network_check_router_state | `Error` | 3611.85 | 
test_routers_network_ops.py
   
   Manual test results confirm no failures for all the errored tests: :v: 
:smiley: :dancer: :tada: 
   ```
   Verify No cross domain projects ... === TestName: 
test_02_cross_domain_account_add | Status : SUCCESS ===
   ok
   Test As long as the project exists, its owner can't be removed ... === 
TestName: test_03_delete_account_with_project | Status : SUCCESS ===
   ok
   Test Verify delete domain with cleanup=true should delete projects ... === 
TestName: test_04_delete_domain_with_project | Status : SUCCESS ===
   ok
   Verify an account can own multiple projects and can belong to multiple 
projects ... === TestName: test_01_create_multiple_projects_by_account | Status 
: SUCCESS ===
   ok
   Test Verify a project user can be later promoted to become a ... === 
TestName: test_05_user_project_owner_promotion | Status : SUCCESS ===
   ok
   Test Verify there can only be one owner of a project at a time ... === 
TestName: test_06_max_one_project_owner | Status : SUCCESS ===
   ok
   Test Verify after an account is removed from the project, all its resources 
stay with the project. ... === TestName: 
test_07_project_resources_account_delete | Status : SUCCESS ===
   ok
   Test accounts are unassigned from project after project deletion ... === 
TestName: test_08_cleanup_after_project_delete | Status : SUCCESS ===
   ok
   Test Verify after an account is removed from the project, all his ... === 
TestName: test_09_project_suspend | Status : SUCCESS ===
   ok
   Test project activation after suspension ... === TestName: 
test_10_project_activation | Status : SUCCESS ===
   ok
   
   Ran 10 tests in 562.290s
   
   OK
   
   
   Test redundant router internals ... === TestName: 
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
   ok
   Test redundant router internals ... === TestName: 
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
   ok
   Test redundant router internals ... === TestName: 
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
   ok
   Test redundant router internals ... === TestName: 
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
   ok
   Test redundant router internals ... === TestName: 
test_03_RVR_Network_check_router_state | Status : SUCCESS ===
   ok
   
   Ran 5 tests in 638.726s
   
   OK
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

[GitBox]

blueorangutan commented on issue #2211: CLOUDSTACK-10013: Migrate 
systemvmtemplate to Debian9
URL: https://github.com/apache/cloudstack/pull/2211#issuecomment-350915685
 
 
   Trillian test result (tid-1771)
   Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 31622 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2211-t1771-xenserver-65sp1.zip
   Test completed. Failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_deploy_vm_from_iso | `Error` | 761.54 | test_deploy_vm_iso.py
   test_01_nic | `Error` | 278.05 | test_nic.py
   test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Failure` | 473.97 | 
test_internal_lb.py
   test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Error` | 
1348.13 | test_routers_network_ops.py
   test_04_change_offering_small | `Failure` | 65.64 | test_service_offerings.py
   test_01_volume_usage | `Error` | 20.75 | test_usage.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 433.12 | 
test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Failure` | 379.27 | test_vpc_redundant.py
   test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 116.42 | 
test_host_maintenance.py
   
   
   Tests ran manually:
   
   ```py
   test_deploy_vm_iso.py
   Test Deploy Virtual Machine from ISO ... === TestName: 
test_deploy_vm_from_iso | Status : SUCCESS ===
   ok
   Ran 1 test in 102.014s
   OK
   
   
   test_internal_lb.py:
   Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's in a Single VPC ... === TestName: 
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Status : SUCCESS ===
   ok
   Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's in a Redundant VPC ... === TestName: 
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | Status : SUCCESS ===
   ok
   Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test_03_vpc_internallb_haproxy_stats_on_all_interfaces | Status : 
SUCCESS ===
   ok
   Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | Status : 
SUCCESS ===
   ok
   Ran 4 tests in 1906.554s
   OK
   
   
   test_nic.py:
   Test to add and update added nic to a virtual machine ... === TestName: 
test_01_nic | Status : SUCCESS ===
   ok
   Test to adding multiple nics to a VMware VM and restarting VM ... SKIP: 
Skipping test applicable for VMware
   Ran 2 tests in 631.528s
   OK (SKIP=1)
   
   test_routers_network_ops.py:
   Test redundant router internals ... === TestName: 
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
   ok
   Test redundant router internals ... === TestName: 
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
   ok
   Test redundant router internals ... === TestName: 
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
   ok
   Test redundant router internals ... === TestName: 
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
   ok
   Test redundant router internals ... === TestName: 
test_03_RVR_Network_check_router_state | Status : SUCCESS ===
   ok
   Ran 5 tests in 1220.687s
   OK
   
   test_service_offerings.py:
   Test to create service offering ... === TestName: 
test_01_create_service_offering | Status : SUCCESS ===
   ok
   Test to update existing service offering ... === TestName: 
test_02_edit_service_offering | Status : SUCCESS ===
   ok
   Test to delete service offering ... === TestName: 
test_03_delete_service_offering | Status : SUCCESS ===
   ok
   Test to change service to a small capacity ... === TestName: 
test_04_change_offering_small | Status : SUCCESS ===
   ok
   Ran 4 tests in 175.167s
   OK
   
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

[GitBox]

blueorangutan commented on issue #2211: CLOUDSTACK-10013: Migrate 
systemvmtemplate to Debian9
URL: https://github.com/apache/cloudstack/pull/2211#issuecomment-350915685
 
 
   Trillian test result (tid-1771)
   Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 31622 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2211-t1771-xenserver-65sp1.zip
   Test completed. Failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_deploy_vm_from_iso | `Error` | 761.54 | test_deploy_vm_iso.py
   test_01_nic | `Error` | 278.05 | test_nic.py
   test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Failure` | 473.97 | 
test_internal_lb.py
   test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Error` | 
1348.13 | test_routers_network_ops.py
   test_04_change_offering_small | `Failure` | 65.64 | test_service_offerings.py
   test_01_volume_usage | `Error` | 20.75 | test_usage.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 433.12 | 
test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Failure` | 379.27 | test_vpc_redundant.py
   test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 116.42 | 
test_host_maintenance.py
   
   
   Tests ran manually:
   
   ```py
   test_deploy_vm_iso.py
   Test Deploy Virtual Machine from ISO ... === TestName: 
test_deploy_vm_from_iso | Status : SUCCESS ===
   ok
   Ran 1 test in 102.014s
   OK
   
   
   test_internal_lb.py:
   Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's in a Single VPC ... === TestName: 
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Status : SUCCESS ===
   ok
   Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's in a Redundant VPC ... === TestName: 
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | Status : SUCCESS ===
   ok
   Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test_03_vpc_internallb_haproxy_stats_on_all_interfaces | Status : 
SUCCESS ===
   ok
   Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | Status : 
SUCCESS ===
   ok
   Ran 4 tests in 1906.554s
   OK
   
   
   test_nic.py:
   Test to add and update added nic to a virtual machine ... === TestName: 
test_01_nic | Status : SUCCESS ===
   ok
   Test to adding multiple nics to a VMware VM and restarting VM ... SKIP: 
Skipping test applicable for VMware
   Ran 2 tests in 631.528s
   OK (SKIP=1)
   
   
   test_service_offerings.py:
   Test to create service offering ... === TestName: 
test_01_create_service_offering | Status : SUCCESS ===
   ok
   Test to update existing service offering ... === TestName: 
test_02_edit_service_offering | Status : SUCCESS ===
   ok
   Test to delete service offering ... === TestName: 
test_03_delete_service_offering | Status : SUCCESS ===
   ok
   Test to change service to a small capacity ... === TestName: 
test_04_change_offering_small | Status : SUCCESS ===
   ok
   Ran 4 tests in 175.167s
   OK
   
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

[GitBox]

blueorangutan commented on issue #2211: CLOUDSTACK-10013: Migrate 
systemvmtemplate to Debian9
URL: https://github.com/apache/cloudstack/pull/2211#issuecomment-350915685
 
 
   Trillian test result (tid-1771)
   Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 31622 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2211-t1771-xenserver-65sp1.zip
   Test completed. Failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_deploy_vm_from_iso | `Error` | 761.54 | test_deploy_vm_iso.py
   test_01_nic | `Error` | 278.05 | test_nic.py
   test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Failure` | 473.97 | 
test_internal_lb.py
   test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Error` | 
1348.13 | test_routers_network_ops.py
   test_04_change_offering_small | `Failure` | 65.64 | test_service_offerings.py
   test_01_volume_usage | `Error` | 20.75 | test_usage.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 433.12 | 
test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Failure` | 379.27 | test_vpc_redundant.py
   test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 116.42 | 
test_host_maintenance.py
   
   
   Tests ran manually:
   
   ```py
   test_deploy_vm_iso.py
   Test Deploy Virtual Machine from ISO ... === TestName: 
test_deploy_vm_from_iso | Status : SUCCESS ===
   ok
   Ran 1 test in 102.014s
   OK
   
   
   test_nic.py:
   Test to add and update added nic to a virtual machine ... === TestName: 
test_01_nic | Status : SUCCESS ===
   ok
   Test to adding multiple nics to a VMware VM and restarting VM ... SKIP: 
Skipping test applicable for VMware
   Ran 2 tests in 631.528s
   OK (SKIP=1)
   
   
   test_service_offerings.py:
   Test to create service offering ... === TestName: 
test_01_create_service_offering | Status : SUCCESS ===
   ok
   Test to update existing service offering ... === TestName: 
test_02_edit_service_offering | Status : SUCCESS ===
   ok
   Test to delete service offering ... === TestName: 
test_03_delete_service_offering | Status : SUCCESS ===
   ok
   Test to change service to a small capacity ... === TestName: 
test_04_change_offering_small | Status : SUCCESS ===
   ok
   Ran 4 tests in 175.167s
   OK
   
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

[GitBox]

blueorangutan commented on issue #2211: CLOUDSTACK-10013: Migrate 
systemvmtemplate to Debian9
URL: https://github.com/apache/cloudstack/pull/2211#issuecomment-350915685
 
 
   Trillian test result (tid-1771)
   Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 31622 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2211-t1771-xenserver-65sp1.zip
   Test completed. Failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_deploy_vm_from_iso | `Error` | 761.54 | test_deploy_vm_iso.py
   test_01_nic | `Error` | 278.05 | test_nic.py
   test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Failure` | 473.97 | 
test_internal_lb.py
   test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Error` | 
1348.13 | test_routers_network_ops.py
   test_04_change_offering_small | `Failure` | 65.64 | test_service_offerings.py
   test_01_volume_usage | `Error` | 20.75 | test_usage.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 433.12 | 
test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Failure` | 379.27 | test_vpc_redundant.py
   test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 116.42 | 
test_host_maintenance.py
   
   
   Tests ran manually:
   ```py
   test_deploy_vm_iso.py
   Test Deploy Virtual Machine from ISO ... === TestName: 
test_deploy_vm_from_iso | Status : SUCCESS ===
   ok
   Ran 1 test in 102.014s
   OK
   
   
   test_nic.py:
   Test to add and update added nic to a virtual machine ... === TestName: 
test_01_nic | Status : SUCCESS ===
   ok
   Test to adding multiple nics to a VMware VM and restarting VM ... SKIP: 
Skipping test applicable for VMware
   Ran 2 tests in 631.528s
   
   
   OK (SKIP=1)
   
   test_service_offerings.py:
   Test to create service offering ... === TestName: 
test_01_create_service_offering | Status : SUCCESS ===
   ok
   Test to update existing service offering ... === TestName: 
test_02_edit_service_offering | Status : SUCCESS ===
   ok
   Test to delete service offering ... === TestName: 
test_03_delete_service_offering | Status : SUCCESS ===
   ok
   Test to change service to a small capacity ... === TestName: 
test_04_change_offering_small | Status : SUCCESS ===
   ok
   
   Ran 4 tests in 175.167s
   
   OK
   
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

[GitBox]

blueorangutan commented on issue #2211: CLOUDSTACK-10013: Migrate 
systemvmtemplate to Debian9
URL: https://github.com/apache/cloudstack/pull/2211#issuecomment-350915685
 
 
   Trillian test result (tid-1771)
   Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 31622 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2211-t1771-xenserver-65sp1.zip
   Test completed. Failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_deploy_vm_from_iso | `Error` | 761.54 | test_deploy_vm_iso.py
   test_01_nic | `Error` | 278.05 | test_nic.py
   test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Failure` | 473.97 | 
test_internal_lb.py
   test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Error` | 
1348.13 | test_routers_network_ops.py
   test_04_change_offering_small | `Failure` | 65.64 | test_service_offerings.py
   test_01_volume_usage | `Error` | 20.75 | test_usage.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 433.12 | 
test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Failure` | 379.27 | test_vpc_redundant.py
   test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 116.42 | 
test_host_maintenance.py
   
   
   Tests ran manually:
   ```py
   test_deploy_vm_iso.py
   Test Deploy Virtual Machine from ISO ... === TestName: 
test_deploy_vm_from_iso | Status : SUCCESS ===
   ok
   Ran 1 test in 102.014s
   OK
   
   test_nic.py:
   Test to add and update added nic to a virtual machine ... === TestName: 
test_01_nic | Status : SUCCESS ===
   ok
   Test to adding multiple nics to a VMware VM and restarting VM ... SKIP: 
Skipping test applicable for VMware
   
   --
   Ran 2 tests in 631.528s
   
   OK (SKIP=1)
   
   test_service_offerings.py:
   Test to create service offering ... === TestName: 
test_01_create_service_offering | Status : SUCCESS ===
   ok
   Test to update existing service offering ... === TestName: 
test_02_edit_service_offering | Status : SUCCESS ===
   ok
   Test to delete service offering ... === TestName: 
test_03_delete_service_offering | Status : SUCCESS ===
   ok
   Test to change service to a small capacity ... === TestName: 
test_04_change_offering_small | Status : SUCCESS ===
   ok
   
   Ran 4 tests in 175.167s
   
   OK
   
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

[GitBox]

blueorangutan commented on issue #2211: CLOUDSTACK-10013: Migrate 
systemvmtemplate to Debian9
URL: https://github.com/apache/cloudstack/pull/2211#issuecomment-350915685
 
 
   Trillian test result (tid-1771)
   Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 31622 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2211-t1771-xenserver-65sp1.zip
   Test completed. Failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_deploy_vm_from_iso | `Error` | 761.54 | test_deploy_vm_iso.py
   test_01_nic | `Error` | 278.05 | test_nic.py
   test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Failure` | 473.97 | 
test_internal_lb.py
   test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Error` | 
1348.13 | test_routers_network_ops.py
   test_04_change_offering_small | `Failure` | 65.64 | test_service_offerings.py
   test_01_volume_usage | `Error` | 20.75 | test_usage.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 433.12 | 
test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Failure` | 379.27 | test_vpc_redundant.py
   test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 116.42 | 
test_host_maintenance.py
   
   
   Tests ran manually:
   ```
   test_deploy_vm_iso.py
   Test Deploy Virtual Machine from ISO ... === TestName: 
test_deploy_vm_from_iso | Status : SUCCESS ===
   ok
   Ran 1 test in 102.014s
   OK
   
   test_nic.py:
   Test to add and update added nic to a virtual machine ... === TestName: 
test_01_nic | Status : SUCCESS ===
   ok
   Test to adding multiple nics to a VMware VM and restarting VM ... SKIP: 
Skipping test applicable for VMware
   
   --
   Ran 2 tests in 631.528s
   
   OK (SKIP=1)
   
   test_service_offerings.py:
   Test to create service offering ... === TestName: 
test_01_create_service_offering | Status : SUCCESS ===
   ok
   Test to update existing service offering ... === TestName: 
test_02_edit_service_offering | Status : SUCCESS ===
   ok
   Test to delete service offering ... === TestName: 
test_03_delete_service_offering | Status : SUCCESS ===
   ok
   Test to change service to a small capacity ... === TestName: 
test_04_change_offering_small | Status : SUCCESS ===
   ok
   
   Ran 4 tests in 175.167s
   
   OK
   
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2356: CLOUDSTACK-8313: Support overprovisioning for local storage

[GitBox]

rhtyd commented on issue #2356: CLOUDSTACK-8313: Support overprovisioning for 
local storage
URL: https://github.com/apache/cloudstack/pull/2356#issuecomment-350948598
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2356: CLOUDSTACK-8313: Support overprovisioning for local storage

[GitBox]

blueorangutan commented on issue #2356: CLOUDSTACK-8313: Support 
overprovisioning for local storage
URL: https://github.com/apache/cloudstack/pull/2356#issuecomment-350948618
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

[GitBox]

blueorangutan commented on issue #2211: CLOUDSTACK-10013: Migrate 
systemvmtemplate to Debian9
URL: https://github.com/apache/cloudstack/pull/2211#issuecomment-350915685
 
 
   Trillian test result (tid-1771)
   Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 31622 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2211-t1771-xenserver-65sp1.zip
   Test completed. Failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_deploy_vm_from_iso | `Error` | 761.54 | test_deploy_vm_iso.py
   test_01_nic | `Error` | 278.05 | test_nic.py
   test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Failure` | 473.97 | 
test_internal_lb.py
   test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Error` | 
1348.13 | test_routers_network_ops.py
   test_04_change_offering_small | `Failure` | 65.64 | test_service_offerings.py
   test_01_volume_usage | `Error` | 20.75 | test_usage.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 433.12 | 
test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Failure` | 379.27 | test_vpc_redundant.py
   test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 116.42 | 
test_host_maintenance.py
   
   
   Tests ran manually:
   ```
   test_deploy_vm_iso.py
   Test Deploy Virtual Machine from ISO ... === TestName: 
test_deploy_vm_from_iso | Status : SUCCESS ===
   ok
   Ran 1 test in 102.014s
   OK
   
   test_service_offerings.py:
   Test to create service offering ... === TestName: 
test_01_create_service_offering | Status : SUCCESS ===
   ok
   Test to update existing service offering ... === TestName: 
test_02_edit_service_offering | Status : SUCCESS ===
   ok
   Test to delete service offering ... === TestName: 
test_03_delete_service_offering | Status : SUCCESS ===
   ok
   Test to change service to a small capacity ... === TestName: 
test_04_change_offering_small | Status : SUCCESS ===
   ok
   
   Ran 4 tests in 175.167s
   
   OK
   
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

[GitBox]

blueorangutan commented on issue #2211: CLOUDSTACK-10013: Migrate 
systemvmtemplate to Debian9
URL: https://github.com/apache/cloudstack/pull/2211#issuecomment-350948140
 
 
   Trillian test result (tid-1769)
   Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 45552 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2211-t1769-vmware-55u3.zip
   Test completed. Failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | `Error` | 
906.68 | test_network.py
   test_00_deploy_vm_root_resize | `Error` | 6.00 | 
test_deploy_vm_root_resize.py
   ContextSuite context=TestDeployVmRootSize>:teardown | `Error` | 0.24 | 
test_deploy_vm_root_resize.py
   test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Error` | 2066.93 | 
test_internal_lb.py
   test_assign_and_removal_lb | `Error` | 614.31 | test_loadbalance.py
   test_01_deploy_vms_storage_tags | `Error` | 35.77 | test_primary_storage.py
   test_01_deploy_vms_storage_tags | `Error` | 35.81 | test_primary_storage.py
   ContextSuite context=TestStorageTags>:teardown | `Error` | 85.94 | 
test_primary_storage.py
   test_02_vpc_privategw_static_routes | `Error` | 2298.10 | 
test_privategw_acl.py
   ContextSuite context=TestRedundantIsolateNetworks>:teardown | `Error` | 0.00 
| test_routers_network_ops.py
   test_02_list_snapshots_with_removed_data_store | `Error` | 25.94 | 
test_snapshots.py
   test_02_list_snapshots_with_removed_data_store | `Error` | 25.98 | 
test_snapshots.py
   test_05_stop_ssvm | `Failure` | 287.46 | test_ssvm.py
   test_06_stop_cpvm | `Failure` | 294.65 | test_ssvm.py
   test_08_reboot_cpvm | `Failure` | 0.04 | test_ssvm.py
   test_01_volume_usage | `Error` | 26.26 | test_usage.py
   test_01_create_volume | `Error` | 30.48 | test_volumes.py
   test_02_attach_volume | `Error` | 20.23 | test_volumes.py
   test_03_download_attached_volume | `Error` | 5.09 | test_volumes.py
   test_04_delete_attached_volume | `Error` | 5.11 | test_volumes.py
   test_05_detach_volume | `Error` | 5.09 | test_volumes.py
   test_06_download_detached_volume | `Error` | 5.09 | test_volumes.py
   test_07_resize_fail | `Error` | 10.28 | test_volumes.py
   test_08_resize_volume | `Error` | 5.09 | test_volumes.py
   test_09_delete_detached_volume | `Error` | 20.32 | test_volumes.py
   ContextSuite context=TestVolumes>:teardown | `Error` | 218.18 | 
test_volumes.py
   ContextSuite context=TestVPCRedundancy>:teardown | `Error` | 0.00 | 
test_vpc_redundant.py
   ContextSuite context=TestRVPCSite2SiteVpn>:teardown | `Error` | 0.00 | 
test_vpc_vpn.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

[GitBox]

blueorangutan commented on issue #2211: CLOUDSTACK-10013: Migrate 
systemvmtemplate to Debian9
URL: https://github.com/apache/cloudstack/pull/2211#issuecomment-350915685
 
 
   Trillian test result (tid-1771)
   Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 31622 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2211-t1771-xenserver-65sp1.zip
   Test completed. Failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_deploy_vm_from_iso | `Error` | 761.54 | test_deploy_vm_iso.py
   test_01_nic | `Error` | 278.05 | test_nic.py
   test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Failure` | 473.97 | 
test_internal_lb.py
   test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Error` | 
1348.13 | test_routers_network_ops.py
   test_04_change_offering_small | `Failure` | 65.64 | test_service_offerings.py
   test_01_volume_usage | `Error` | 20.75 | test_usage.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 433.12 | 
test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Failure` | 379.27 | test_vpc_redundant.py
   test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 116.42 | 
test_host_maintenance.py
   
   
   Tests ran manually:
   ```test_deploy_vm_iso.py
   Test Deploy Virtual Machine from ISO ... === TestName: 
test_deploy_vm_from_iso | Status : SUCCESS ===
   ok
   Ran 1 test in 102.014s
   OK
   
   test_service_offerings.py:
   Test to create service offering ... === TestName: 
test_01_create_service_offering | Status : SUCCESS ===
   ok
   Test to update existing service offering ... === TestName: 
test_02_edit_service_offering | Status : SUCCESS ===
   ok
   Test to delete service offering ... === TestName: 
test_03_delete_service_offering | Status : SUCCESS ===
   ok
   Test to change service to a small capacity ... === TestName: 
test_04_change_offering_small | Status : SUCCESS ===
   ok
   
   Ran 4 tests in 175.167s
   
   OK
   
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

[GitBox]

blueorangutan commented on issue #2211: CLOUDSTACK-10013: Migrate 
systemvmtemplate to Debian9
URL: https://github.com/apache/cloudstack/pull/2211#issuecomment-350911659
 
 
   Trillian test result (tid-1768)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 30882 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2211-t1768-kvm-centos7.zip
   Test completed. Failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_10_project_activation | `Error` | 3620.74 | test_projects.py
   test_03_RVR_Network_check_router_state | `Error` | 3611.85 | 
test_routers_network_ops.py
   
   Manual test results confirm no failures for all the errored tests:
   ```
   Verify No cross domain projects ... === TestName: 
test_02_cross_domain_account_add | Status : SUCCESS ===
   ok
   Test As long as the project exists, its owner can't be removed ... === 
TestName: test_03_delete_account_with_project | Status : SUCCESS ===
   ok
   Test Verify delete domain with cleanup=true should delete projects ... === 
TestName: test_04_delete_domain_with_project | Status : SUCCESS ===
   ok
   Verify an account can own multiple projects and can belong to multiple 
projects ... === TestName: test_01_create_multiple_projects_by_account | Status 
: SUCCESS ===
   ok
   Test Verify a project user can be later promoted to become a ... === 
TestName: test_05_user_project_owner_promotion | Status : SUCCESS ===
   ok
   Test Verify there can only be one owner of a project at a time ... === 
TestName: test_06_max_one_project_owner | Status : SUCCESS ===
   ok
   Test Verify after an account is removed from the project, all its resources 
stay with the project. ... === TestName: 
test_07_project_resources_account_delete | Status : SUCCESS ===
   ok
   Test accounts are unassigned from project after project deletion ... === 
TestName: test_08_cleanup_after_project_delete | Status : SUCCESS ===
   ok
   Test Verify after an account is removed from the project, all his ... === 
TestName: test_09_project_suspend | Status : SUCCESS ===
   ok
   Test project activation after suspension ... === TestName: 
test_10_project_activation | Status : SUCCESS ===
   ok
   
   Ran 10 tests in 562.290s
   
   OK
   
   
   Test redundant router internals ... === TestName: 
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
   ok
   Test redundant router internals ... === TestName: 
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
   ok
   Test redundant router internals ... === TestName: 
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
   ok
   Test redundant router internals ... === TestName: 
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
   ok
   Test redundant router internals ... === TestName: 
test_03_RVR_Network_check_router_state | Status : SUCCESS ===
   ok
   
   Ran 5 tests in 638.726s
   
   OK
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

[GitBox]

blueorangutan commented on issue #2211: CLOUDSTACK-10013: Migrate 
systemvmtemplate to Debian9
URL: https://github.com/apache/cloudstack/pull/2211#issuecomment-350915685
 
 
   Trillian test result (tid-1771)
   Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 31622 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2211-t1771-xenserver-65sp1.zip
   Test completed. Failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_deploy_vm_from_iso | `Error` | 761.54 | test_deploy_vm_iso.py
   test_01_nic | `Error` | 278.05 | test_nic.py
   test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Failure` | 473.97 | 
test_internal_lb.py
   test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Error` | 
1348.13 | test_routers_network_ops.py
   test_04_change_offering_small | `Failure` | 65.64 | test_service_offerings.py
   test_01_volume_usage | `Error` | 20.75 | test_usage.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 433.12 | 
test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Failure` | 379.27 | test_vpc_redundant.py
   test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 116.42 | 
test_host_maintenance.py
   
   
   Tests ran manually:
   ```test_deploy_vm_iso.py
   Test Deploy Virtual Machine from ISO ... === TestName: 
test_deploy_vm_from_iso | Status : SUCCESS ===
   ok
   Ran 1 test in 102.014s
   OK
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

[GitBox]

blueorangutan commented on issue #2211: CLOUDSTACK-10013: Migrate 
systemvmtemplate to Debian9
URL: https://github.com/apache/cloudstack/pull/2211#issuecomment-350915685
 
 
   Trillian test result (tid-1771)
   Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 31622 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2211-t1771-xenserver-65sp1.zip
   Test completed. Failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_deploy_vm_from_iso | `Error` | 761.54 | test_deploy_vm_iso.py
   test_01_nic | `Error` | 278.05 | test_nic.py
   test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Failure` | 473.97 | 
test_internal_lb.py
   test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Error` | 
1348.13 | test_routers_network_ops.py
   test_04_change_offering_small | `Failure` | 65.64 | test_service_offerings.py
   test_01_volume_usage | `Error` | 20.75 | test_usage.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 433.12 | 
test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Failure` | 379.27 | test_vpc_redundant.py
   test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 116.42 | 
test_host_maintenance.py
   
   
   Tests ran manually:
   ```test_deploy_vm_iso.py
   Test Deploy Virtual Machine from ISO ... === TestName: 
test_deploy_vm_from_iso | Status : SUCCESS ===
   ok
   --
   Ran 1 test in 102.014s
   OK
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

[GitBox]

blueorangutan commented on issue #2211: CLOUDSTACK-10013: Migrate 
systemvmtemplate to Debian9
URL: https://github.com/apache/cloudstack/pull/2211#issuecomment-350915685
 
 
   Trillian test result (tid-1771)
   Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 31622 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2211-t1771-xenserver-65sp1.zip
   Test completed. Failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_deploy_vm_from_iso | `Error` | 761.54 | test_deploy_vm_iso.py
   test_01_nic | `Error` | 278.05 | test_nic.py
   test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Failure` | 473.97 | 
test_internal_lb.py
   test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Error` | 
1348.13 | test_routers_network_ops.py
   test_04_change_offering_small | `Failure` | 65.64 | test_service_offerings.py
   test_01_volume_usage | `Error` | 20.75 | test_usage.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 433.12 | 
test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Failure` | 379.27 | test_vpc_redundant.py
   test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 116.42 | 
test_host_maintenance.py
   
   
   Tests ran manually:
   Test Deploy Virtual Machine from ISO ... === TestName: 
test_deploy_vm_from_iso | Status : SUCCESS ===
   ok
   --
   Ran 1 test in 102.014s
   OK
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch debian9-systemvmtemplate updated: fixes

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch debian9-systemvmtemplate
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/debian9-systemvmtemplate by 
this push:
 new c666485  fixes
c666485 is described below

commit c666485dfdd655103608a9fb6e04d67737518506
Author: Rohit Yadav 
AuthorDate: Tue Dec 12 10:24:39 2017 +0530

fixes

Signed-off-by: Rohit Yadav 
---
 .travis.yml| 11 ++---
 .../etc/systemd/system/cloud-postinit.service  |  2 +-
 systemvm/debian/opt/cloud/bin/cs/CsApp.py  |  2 +-
 systemvm/debian/opt/cloud/bin/passwd_server| 26 
 systemvm/debian/opt/cloud/bin/passwd_server_ip | 29 -
 systemvm/debian/opt/cloud/bin/update_config.py | 14 +++
 systemvm/debian/opt/cloud/bin/vpc_passwd_server| 32 ---
 .../opt/cloud/templates/keepalived.conf.templ  |  4 +-
 .../definitions/systemvmtemplate/apt_upgrade.sh| 13 ++
 .../definitions/systemvmtemplate/configure_grub.sh |  2 +-
 .../definitions/systemvmtemplate/finalize.sh   |  9 
 tools/marvin/marvin/config/test_data.py| 48 +-
 tools/marvin/marvin/lib/common.py  | 47 +
 13 files changed, 79 insertions(+), 160 deletions(-)

diff --git a/.travis.yml b/.travis.yml
index a206cbe..b4749c0 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -115,8 +115,7 @@ env:
  component/test_acl_sharednetwork_deployVM-impersonation
  component/test_affinity_groups_projects
  component/test_cpu_domain_limits
- component/test_cpu_limits
- component/test_volumes"
+ component/test_cpu_limits"
 
 - TESTS="component/test_cpu_max_limits
  component/test_acl_isolatednetwork
@@ -144,10 +143,12 @@ env:
  component/test_snapshots
  component/test_stopped_vm"
 
-- TESTS="component/test_resource_limits
- component/test_tags
+- TESTS="component/test_resource_limits"
+
+- TESTS="component/test_tags
  component/test_templates
- component/test_update_vm"
+ component/test_update_vm
+ component/test_volumes"
 
 - TESTS="component/test_vpc
  component/test_vpc_network
diff --git a/systemvm/debian/etc/systemd/system/cloud-postinit.service 
b/systemvm/debian/etc/systemd/system/cloud-postinit.service
index 83f0636..04f71a3 100644
--- a/systemvm/debian/etc/systemd/system/cloud-postinit.service
+++ b/systemvm/debian/etc/systemd/system/cloud-postinit.service
@@ -11,4 +11,4 @@ WantedBy=multi-user.target
 Type=oneshot
 ExecStart=/opt/cloud/bin/setup/postinit.sh
 RemainAfterExit=true
-TimeoutStartSec=1min
+TimeoutStartSec=5min
diff --git a/systemvm/debian/opt/cloud/bin/cs/CsApp.py 
b/systemvm/debian/opt/cloud/bin/cs/CsApp.py
index 2085088..031ac05 100755
--- a/systemvm/debian/opt/cloud/bin/cs/CsApp.py
+++ b/systemvm/debian/opt/cloud/bin/cs/CsApp.py
@@ -66,7 +66,7 @@ class CsApache(CsApp):
 
 class CsPasswdSvc():
 """
-  nohup bash /opt/cloud/bin/vpc_passwd_server $ip >/dev/null 2>&1 &
+  CloudStack VR password server
 """
 
 def __init__(self, ip):
diff --git a/systemvm/debian/opt/cloud/bin/passwd_server 
b/systemvm/debian/opt/cloud/bin/passwd_server
deleted file mode 100755
index 295e720..000
--- a/systemvm/debian/opt/cloud/bin/passwd_server
+++ /dev/null
@@ -1,26 +0,0 @@
-#!/bin/bash
-# Licensed to the Apache Software Foundation (ASF) under one
-# or more contributor license agreements.  See the NOTICE file
-# distributed with this work for additional information
-# regarding copyright ownership.  The ASF licenses this file
-# to you under the Apache License, Version 2.0 (the
-# "License"); you may not use this file except in compliance
-# with the License.  You may obtain a copy of the License at
-#
-#   http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing,
-# software distributed under the License is distributed on an
-# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-# KIND, either express or implied.  See the License for the
-# specific language governing permissions and limitations
-# under the License.
-
-#we have intentionally split the ip gathering command into two.
-#This was done to avoid getting a SIGPIPE during certain load conditions.
-ipInfo=$(ip addr show dev eth0 | grep inet | grep eth0 )
-ips=$(echo "$ipInfo" | awk '{print $2}' ); echo $ips
-for ip in $ips; do
-   addr=$(echo $ip | awk -F'/' '{print $1}')
-   /opt/cloud/bin/passwd_server_ip $addr >> /var/log/cloud.log 2>&1 &
-done;
diff --git a/systemvm/debian/opt/cloud/bin/passwd_server_ip 
b/systemvm/debian/opt/cloud/bin/passwd_server_ip
deleted file mode 100755
index 

[GitHub] blueorangutan commented on issue #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

[GitBox]

blueorangutan commented on issue #2211: CLOUDSTACK-10013: Migrate 
systemvmtemplate to Debian9
URL: https://github.com/apache/cloudstack/pull/2211#issuecomment-350529540
 
 
   Trillian test result (tid-1758)
   Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 65401 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2211-t1758-vmware-55u3.zip
   Test completed. Failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_00_deploy_vm_root_resize | `Error` | 5.71 | 
test_deploy_vm_root_resize.py
   ContextSuite context=TestDeployVmRootSize>:teardown | `Error` | 0.10 | 
test_deploy_vm_root_resize.py
   test_01_deploy_vms_storage_tags | `Error` | 41.16 | test_primary_storage.py
   test_01_deploy_vms_storage_tags | `Error` | 41.24 | test_primary_storage.py
   ContextSuite context=TestStorageTags>:teardown | `Error` | 86.04 | 
test_primary_storage.py
   ContextSuite context=TestRedundantIsolateNetworks>:teardown | `Error` | 0.00 
| test_routers_network_ops.py
   test_02_list_snapshots_with_removed_data_store | `Error` | 31.05 | 
test_snapshots.py
   test_02_list_snapshots_with_removed_data_store | `Error` | 31.08 | 
test_snapshots.py
   test_05_stop_ssvm | `Failure` | 292.65 | test_ssvm.py
   test_06_stop_cpvm | `Failure` | 296.68 | test_ssvm.py
   test_07_reboot_ssvm | `Error` | 281.00 | test_ssvm.py
   test_08_reboot_cpvm | `Failure` | 0.05 | test_ssvm.py
   test_09_destroy_ssvm | `Error` | 375.56 | test_ssvm.py
   test_01_volume_usage | `Error` | 26.52 | test_usage.py
   ContextSuite context=TestVMLifeCycle>:setup | `Error` | 1599.08 | 
test_vm_life_cycle.py
   test_01_create_volume | `Error` | 25.63 | test_volumes.py
   test_02_attach_volume | `Error` | 15.23 | test_volumes.py
   test_03_download_attached_volume | `Error` | 5.14 | test_volumes.py
   test_04_delete_attached_volume | `Error` | 5.13 | test_volumes.py
   test_05_detach_volume | `Error` | 5.12 | test_volumes.py
   test_06_download_detached_volume | `Error` | 5.19 | test_volumes.py
   test_07_resize_fail | `Error` | 10.36 | test_volumes.py
   test_08_resize_volume | `Error` | 5.13 | test_volumes.py
   test_09_delete_detached_volume | `Error` | 20.39 | test_volumes.py
   ContextSuite context=TestVolumes>:teardown | `Error` | 43.44 | 
test_volumes.py
   ContextSuite context=TestVPCRedundancy>:teardown | `Error` | 0.00 | 
test_vpc_redundant.py
   ContextSuite context=TestRVPCSite2SiteVpn>:teardown | `Error` | 0.00 | 
test_vpc_vpn.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

[GitBox]

blueorangutan commented on issue #2211: CLOUDSTACK-10013: Migrate 
systemvmtemplate to Debian9
URL: https://github.com/apache/cloudstack/pull/2211#issuecomment-350915685
 
 
   Trillian test result (tid-1771)
   Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 31622 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2211-t1771-xenserver-65sp1.zip
   Test completed. Failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_deploy_vm_from_iso | `Error` | 761.54 | test_deploy_vm_iso.py
   test_01_nic | `Error` | 278.05 | test_nic.py
   test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Failure` | 473.97 | 
test_internal_lb.py
   test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Error` | 
1348.13 | test_routers_network_ops.py
   test_04_change_offering_small | `Failure` | 65.64 | test_service_offerings.py
   test_01_volume_usage | `Error` | 20.75 | test_usage.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 433.12 | 
test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Failure` | 379.27 | test_vpc_redundant.py
   test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 116.42 | 
test_host_maintenance.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

[GitBox]

blueorangutan commented on issue #2211: CLOUDSTACK-10013: Migrate 
systemvmtemplate to Debian9
URL: https://github.com/apache/cloudstack/pull/2211#issuecomment-350911659
 
 
   Trillian test result (tid-1768)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 30882 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2211-t1768-kvm-centos7.zip
   Test completed. Failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_10_project_activation | `Error` | 3620.74 | test_projects.py
   test_03_RVR_Network_check_router_state | `Error` | 3611.85 | 
test_routers_network_ops.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #1499: Undetected bug correct and refactor of the class NfsSecondaryStorageResource

[GitBox]

rafaelweingartner commented on issue #1499: Undetected bug correct and refactor 
of the class NfsSecondaryStorageResource
URL: https://github.com/apache/cloudstack/pull/1499#issuecomment-350824692
 
 
   @rhtyd Alexandre is not working with us anymore. So, I took over this PR.
   The bug fix is at line 2451; however, @alexandrelimassantana took the 
liberty to break down some bigger methods into smaller ones.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

[GitBox]

blueorangutan commented on issue #2211: CLOUDSTACK-10013: Migrate 
systemvmtemplate to Debian9
URL: https://github.com/apache/cloudstack/pull/2211#issuecomment-350622490
 
 
   Trillian test result (tid-1764)
   Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 27678 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2211-t1764-xenserver-65sp1.zip
   Test completed. Failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_04_change_offering_small | `Failure` | 32.61 | test_service_offerings.py
   ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | 
test_snapshots.py
   test_01_volume_usage | `Error` | 25.71 | test_usage.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 402.30 | 
test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Failure` | 359.00 | test_vpc_redundant.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2354: CLOUDSTACK-10176:VM Start Api Job returns success for failed Job

[GitBox]

rhtyd commented on a change in pull request #2354: CLOUDSTACK-10176:VM Start 
Api Job returns success for failed Job
URL: https://github.com/apache/cloudstack/pull/2354#discussion_r156147452
 
 

 ##
 File path: engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java
 ##
 @@ -4731,7 +4732,8 @@ protected VirtualMachine retrieve() {
 }
 catch (CloudRuntimeException e){
 s_logger.info("Caught CloudRuntimeException, returning job 
failed");
 
 Review comment:
   @niteshsarda can you at least log the caught error here. I'm fine with 
throwing/returning a general error message to the user.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd closed pull request #2326: [CLOUDSTACK-10184] Re-work method QuotaResponseBuilderImpl.startOfNextDay and its test cases

[GitBox]

rhtyd closed pull request #2326: [CLOUDSTACK-10184] Re-work method 
QuotaResponseBuilderImpl.startOfNextDay and its test cases
URL: https://github.com/apache/cloudstack/pull/2326
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java
 
b/plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java
index 5748de58965..76a68cf7f0e 100644
--- 
a/plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java
+++ 
b/plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java
@@ -16,15 +16,22 @@
 //under the License.
 package org.apache.cloudstack.api.response;
 
-import com.cloud.domain.DomainVO;
-import com.cloud.domain.dao.DomainDao;
-import com.cloud.exception.InvalidParameterValueException;
-import com.cloud.user.Account;
-import com.cloud.user.AccountManager;
-import com.cloud.user.AccountVO;
-import com.cloud.user.User;
-import com.cloud.user.dao.AccountDao;
-import com.cloud.user.dao.UserDao;
+import java.math.BigDecimal;
+import java.math.RoundingMode;
+import java.time.LocalDate;
+import java.time.ZoneId;
+import java.util.ArrayList;
+import java.util.Calendar;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.Comparator;
+import java.util.Date;
+import java.util.HashMap;
+import java.util.Iterator;
+import java.util.List;
+import java.util.ListIterator;
+
+import javax.inject.Inject;
 
 import org.apache.cloudstack.api.command.QuotaBalanceCmd;
 import org.apache.cloudstack.api.command.QuotaEmailTemplateListCmd;
@@ -53,24 +60,17 @@
 import org.apache.log4j.Logger;
 import org.springframework.stereotype.Component;
 
-import javax.ejb.Local;
-import javax.inject.Inject;
-
-import java.math.BigDecimal;
-import java.math.RoundingMode;
-import java.util.ArrayList;
-import java.util.Calendar;
-import java.util.Collection;
-import java.util.Collections;
-import java.util.Comparator;
-import java.util.Date;
-import java.util.HashMap;
-import java.util.Iterator;
-import java.util.List;
-import java.util.ListIterator;
+import com.cloud.domain.DomainVO;
+import com.cloud.domain.dao.DomainDao;
+import com.cloud.exception.InvalidParameterValueException;
+import com.cloud.user.Account;
+import com.cloud.user.AccountManager;
+import com.cloud.user.AccountVO;
+import com.cloud.user.User;
+import com.cloud.user.dao.AccountDao;
+import com.cloud.user.dao.UserDao;
 
 @Component
-@Local(value = QuotaResponseBuilderImpl.class)
 public class QuotaResponseBuilderImpl implements QuotaResponseBuilder {
 private static final Logger s_logger = 
Logger.getLogger(QuotaResponseBuilderImpl.class);
 
@@ -141,7 +141,9 @@ public QuotaTariffResponse 
createQuotaTariffResponse(QuotaTariffVO tariff) {
 } else {
 for (final QuotaAccountVO quotaAccount : 
_quotaAccountDao.listAllQuotaAccount()) {
 AccountVO account = _accountDao.findById(quotaAccount.getId());
-if (account == null) continue;
+if (account == null) {
+continue;
+}
 QuotaSummaryResponse qr = getQuotaSummaryResponse(account);
 result.add(qr);
 }
@@ -181,6 +183,7 @@ public QuotaBalanceResponse 
createQuotaBalanceResponse(List quot
 throw new InvalidParameterValueException("The request period does 
not contain balance entries.");
 }
 Collections.sort(quotaBalance, new Comparator() {
+@Override
 public int compare(QuotaBalanceVO o1, QuotaBalanceVO o2) {
 o1 = o1 == null ? new QuotaBalanceVO() : o1;
 o2 = o2 == null ? new QuotaBalanceVO() : o2;
@@ -287,13 +290,15 @@ public QuotaStatementResponse 
createQuotaStatementResponse(final 

[GitHub] rhtyd closed pull request #2122: CLOUDSTACK-9909: Logrotate config for tomcat needs to be updated for ?

[GitBox]

rhtyd closed pull request #2122: CLOUDSTACK-9909: Logrotate config for tomcat 
needs to be updated for ?
URL: https://github.com/apache/cloudstack/pull/2122
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/packaging/centos7/cloud.spec b/packaging/centos7/cloud.spec
index 5dbddab059d..c5451c4ddf5 100644
--- a/packaging/centos7/cloud.spec
+++ b/packaging/centos7/cloud.spec
@@ -291,7 +291,7 @@ install -D packaging/systemd/cloudstack-management.service 
${RPM_BUILD_ROOT}%{_u
 install -D packaging/systemd/cloudstack-management.default 
${RPM_BUILD_ROOT}%{_sysconfdir}/default/%{name}-management
 install -D server/target/conf/cloudstack-sudoers 
${RPM_BUILD_ROOT}%{_sysconfdir}/sudoers.d/%{name}-management
 touch ${RPM_BUILD_ROOT}%{_localstatedir}/run/%{name}-management.pid
-install -D server/target/conf/cloudstack-catalina.logrotate 
${RPM_BUILD_ROOT}%{_sysconfdir}/logrotate.d/%{name}-catalina
+install -D server/target/conf/cloudstack-catalina7.logrotate 
${RPM_BUILD_ROOT}%{_sysconfdir}/logrotate.d/%{name}-catalina
 
 chmod 440 ${RPM_BUILD_ROOT}%{_sysconfdir}/sudoers.d/%{name}-management
 chmod 770 ${RPM_BUILD_ROOT}%{_sysconfdir}/%{name}/management/Catalina
diff --git a/server/conf/cloudstack-catalina7.logrotate 
b/server/conf/cloudstack-catalina7.logrotate
new file mode 100644
index 000..5896aacaa62
--- /dev/null
+++ b/server/conf/cloudstack-catalina7.logrotate
@@ -0,0 +1,27 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+
+/var/log/cloudstack/management/catalina.out {
+copytruncate
+daily
+rotate 14
+compress
+missingok
+create 0644 cloud cloud
+su cloud cloud
+}
\ No newline at end of file


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2122: CLOUDSTACK-9909: Logrotate config for tomcat needs to be updated for ?

[GitBox]

rhtyd commented on issue #2122: CLOUDSTACK-9909: Logrotate config for tomcat 
needs to be updated for ?
URL: https://github.com/apache/cloudstack/pull/2122#issuecomment-350787180
 
 
   Thanks @jayakarteek for the pull request, this is not relevant to master 
anymore where we've moved to embedded Jetty now. Closing this PR on this 
remark, you may re-submit a different PR against master for embedded-jetty.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #793: CLOUDSTACK-8827: Move the VM snapshots stuck in transitional states to stable states during managment server restart

[GitBox]

rhtyd commented on issue #793: CLOUDSTACK-8827: Move the VM snapshots stuck in 
transitional states to stable states during managment server restart
URL: https://github.com/apache/cloudstack/pull/793#issuecomment-350786746
 
 
   @anshul1886 is this still relevant, if so please fix conflicts and rebase 
against latest master?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2128: CLOUDSTACK-9885: VPCVR: Updated to the private the traffic_type

[GitBox]

rhtyd commented on issue #2128: CLOUDSTACK-9885: VPCVR: Updated to the private 
the traffic_type
URL: https://github.com/apache/cloudstack/pull/2128#issuecomment-350786439
 
 
   @jayapalu can you fix conflicts and move sql related changes to appropriate 
4.10->4.11 path?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2139: CLOUDSTACK-9921: NPE when storage garbage collector is running.

[GitBox]

blueorangutan commented on issue #2139: CLOUDSTACK-9921: NPE when storage 
garbage collector is running.
URL: https://github.com/apache/cloudstack/pull/2139#issuecomment-350786351
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1364


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2088: CLOUDSTACK-9892: Primary storage resource check is broken when using ?

[GitBox]

rhtyd commented on issue #2088: CLOUDSTACK-9892: Primary storage resource check 
is broken when using ?
URL: https://github.com/apache/cloudstack/pull/2088#issuecomment-350786151
 
 
   LGTM based on regression tests, is this read for merging? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2088: CLOUDSTACK-9892: Primary storage resource check is broken when using ?

[GitBox]

rhtyd commented on issue #2088: CLOUDSTACK-9892: Primary storage resource check 
is broken when using ?
URL: https://github.com/apache/cloudstack/pull/2088#issuecomment-350786151
 
 
   LGTM based on regression tests, is this ready for merging? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2088: CLOUDSTACK-9892: Primary storage resource check is broken when using ?

[GitBox]

rhtyd commented on a change in pull request #2088: CLOUDSTACK-9892: Primary 
storage resource check is broken when using ?
URL: https://github.com/apache/cloudstack/pull/2088#discussion_r156132782
 
 

 ##
 File path: test/integration/smoke/test_deploy_vm_root_resize.py
 ##
 @@ -219,30 +220,34 @@ def test_00_deploy_vm_root_resize(self):
 """
 
 newrootsize = (self.template.size >> 30) + 2
-if(self.hypervisor.lower() == 'kvm' or self.hypervisor.lower() ==
-'xenserver'or self.hypervisor.lower() == 'vmware'  ):
+if (self.hypervisor.lower() == 'kvm' or self.hypervisor.lower() == 
'xenserver'
 
 Review comment:
   This could have been rewritten as `obj in array:`


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #1906: CLOUDSTACK-9743 - ODL plugin responds to deleteHost causing other plugin in the chain to be ignored

[GitBox]

rhtyd commented on issue #1906: CLOUDSTACK-9743 - ODL plugin responds to 
deleteHost causing other plugin in the chain to be ignored 
URL: https://github.com/apache/cloudstack/pull/1906#issuecomment-350785141
 
 
   LGTM, are we okay to merge this ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #1499: Undetected bug correct and refactor of the class NfsSecondaryStorageResource

[GitBox]

rhtyd commented on issue #1499: Undetected bug correct and refactor of the 
class NfsSecondaryStorageResource
URL: https://github.com/apache/cloudstack/pull/1499#issuecomment-350784728
 
 
   @alexandrelimassantana can you rebase and fix conflicts?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd closed pull request #1432: Fix for CLOUDSTACK-9253

[GitBox]

rhtyd closed pull request #1432: Fix for CLOUDSTACK-9253
URL: https://github.com/apache/cloudstack/pull/1432
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/tools/docker/Dockerfile b/tools/docker/Dockerfile
index 9d8b2e062b6..3fe14cea891 100644
--- a/tools/docker/Dockerfile
+++ b/tools/docker/Dockerfile
@@ -20,7 +20,7 @@
 FROM ubuntu:14.04
 
 MAINTAINER "Apache CloudStack" 
-LABEL Vendor="Apache.org" License="ApacheV2" Version="4.6.0"
+LABEL Vendor="Apache.org" License="ApacheV2" Version="4.8.0"
 
 RUN apt-get -y update && apt-get install -y \
 genisoimage \
@@ -40,8 +40,6 @@ RUN apt-get install -qqy mysql-server && \
 
 RUN (/usr/bin/mysqld_safe &); sleep 5; mysqladmin -u root -proot password ''
 
-RUN pip install --allow-external mysql-connector-python mysql-connector-python
-
 COPY tools/docker/supervisord.conf /etc/supervisor/conf.d/supervisord.conf
 COPY . ./root
 WORKDIR /root
@@ -51,9 +49,12 @@ RUN mvn -Pdeveloper -Dsimulator -DskipTests clean install
 RUN (/usr/bin/mysqld_safe &); \
 sleep 3; \
 mvn -Pdeveloper -pl developer -Ddeploydb; \
-mvn -Pdeveloper -pl developer -Ddeploydb-simulator; \
-MARVIN_FILE=`find tools/marvin/dist/ -name "Marvin*.tar.gz"` \
-pip install $MARVIN_FILE
+mvn -Pdeveloper -pl developer -Ddeploydb-simulator
+
+RUN pip install 
http://cdn.mysql.com/Downloads/Connector-Python/mysql-connector-python-2.0.4.zip
+RUN pip install paramiko
+RUN pip install /root/tools/marvin/dist/Marvin*.tar.gz
+   
 
 EXPOSE 8080 8096
 


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #1432: Fix for CLOUDSTACK-9253

[GitBox]

rhtyd commented on issue #1432: Fix for CLOUDSTACK-9253
URL: https://github.com/apache/cloudstack/pull/1432#issuecomment-350784426
 
 
   Thanks @pfarmer for the pull request, given it's not applicable to 
master/4.11 anymore I'll close this. Kindly re-submit a new PR. Thanks again 
for your contribution.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #1148: Update JuniperSrxResource.java

[GitBox]

rhtyd commented on issue #1148: Update JuniperSrxResource.java  
URL: https://github.com/apache/cloudstack/pull/1148#issuecomment-350784174
 
 
   @wenwenxiong any update?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2289: [4.11/master] Smoketest Health Check

[GitBox]

rhtyd commented on issue #2289: [4.11/master] Smoketest Health Check
URL: https://github.com/apache/cloudstack/pull/2289#issuecomment-350783637
 
 
   @borisstoyanov good find, under what params/API cases this happens and it's 
not failing for KVM/XS?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2289: [4.11/master] Smoketest Health Check

[GitBox]

rhtyd commented on issue #2289: [4.11/master] Smoketest Health Check
URL: https://github.com/apache/cloudstack/pull/2289#issuecomment-350783637
 
 
   @borisstoyanov good find, under what params/API cases this happens and it's 
not failing for KVM/Vmware?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2045: Fix snmptrap alert bug

[GitBox]

rhtyd commented on issue #2045: Fix snmptrap alert bug
URL: https://github.com/apache/cloudstack/pull/2045#issuecomment-350781468
 
 
   LGTM. @WingkaiHo can you add a JIRA ID for this?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2326: [CLOUDSTACK-10184] Re-work method QuotaResponseBuilderImpl.startOfNextDay and its test cases

[GitBox]

rafaelweingartner commented on issue #2326: [CLOUDSTACK-10184] Re-work method 
QuotaResponseBuilderImpl.startOfNextDay and its test cases
URL: https://github.com/apache/cloudstack/pull/2326#issuecomment-350781610
 
 
   @rhtyd done.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2045: Fix snmptrap alert bug

[GitBox]

rhtyd commented on issue #2045: Fix snmptrap alert bug
URL: https://github.com/apache/cloudstack/pull/2045#issuecomment-350781468
 
 
   LGTM. Merging this based on BVT and Travis test results.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] GabrielBrascher commented on issue #2185: CLOUDSTACK-9976: Redirect saml2 failed login message to a configurable URL

[GitBox]

GabrielBrascher commented on issue #2185: CLOUDSTACK-9976: Redirect saml2 
failed login message to a configurable URL
URL: https://github.com/apache/cloudstack/pull/2185#issuecomment-350781228
 
 
   @rhtyd I will check on that.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd closed pull request #2190: CLOUDSTACK-10010: Fixed the negotiation of S2S VPN connections

[GitBox]

rhtyd closed pull request #2190: CLOUDSTACK-10010: Fixed the negotiation of S2S 
VPN connections
URL: https://github.com/apache/cloudstack/pull/2190
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/systemvm/patches/debian/config/opt/cloud/bin/configure.py 
b/systemvm/patches/debian/config/opt/cloud/bin/configure.py
index 9efc07c7188..5b4b062dba2 100755
--- a/systemvm/patches/debian/config/opt/cloud/bin/configure.py
+++ b/systemvm/patches/debian/config/opt/cloud/bin/configure.py
@@ -566,7 +566,7 @@ def configure_ipsec(self, obj):
 file.addeq(" lifetime=%s" % self.convert_sec_to_h(obj['esp_lifetime']))
 file.addeq(" pfs=%s" % pfs)
 file.addeq(" keyingtries=2")
-file.addeq(" auto=start")
+file.addeq(" auto=route")
 if 'encap' not in obj:
 obj['encap']=False
 file.addeq(" forceencaps=%s" % CsHelper.bool_to_yn(obj['encap']))
@@ -582,10 +582,21 @@ def configure_ipsec(self, obj):
 logging.info("Configured vpn %s %s", leftpeer, rightpeer)
 CsHelper.execute("ipsec rereadsecrets")
 
-# This will load the new config and start the connection when needed 
since auto=start in the config
+# This will load the new config
 CsHelper.execute("ipsec reload")
 os.chmod(vpnsecretsfile, 0400)
 
+# Check that the ipsec config is ready
+for i in range(2):
+result = CsHelper.execute('ipsec status vpn-%s | grep "%s"' % 
(rightpeer, peerlist.split(",", 1)[0]))
+if len(result) > 0:
+break
+time.sleep(1)
+
+# With 'auto=route', connections are established with an attempt to 
communicate over the S2S VPN
+# Attempt to ping the other side to initialize the connection of the 
S2S VPN configuration
+CsHelper.execute("timeout 0.5 ping -c 1 %s" % (peerlist.split("/", 
1)[0]))
+
 def convert_sec_to_h(self, val):
 hrs = int(val) / 3600
 return "%sh" % hrs
diff --git a/test/integration/smoke/test_vpc_vpn.py 
b/test/integration/smoke/test_vpc_vpn.py
index ddf76930050..9ed1d0109ac 100644
--- a/test/integration/smoke/test_vpc_vpn.py
+++ b/test/integration/smoke/test_vpc_vpn.py
@@ -57,6 +57,7 @@
 from nose.plugins.attrib import attr
 
 import logging
+import subprocess
 import time
 
 
@@ -1177,3 +1178,447 @@ def tearDownClass(cls):
 cleanup_resources(cls.apiclient, cls.cleanup)
 except Exception, e:
 raise Exception("Cleanup failed with %s" % e)
+
+
+class TestVPCSite2SiteVPNMultipleOptions(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+cls.logger = logging.getLogger('TestVPCSite2SiteVPNMultipleOptions')
+cls.stream_handler = logging.StreamHandler()
+cls.logger.setLevel(logging.DEBUG)
+cls.logger.addHandler(cls.stream_handler)
+
+testClient = super(TestVPCSite2SiteVPNMultipleOptions, 
cls).getClsTestClient()
+cls.apiclient = testClient.getApiClient()
+cls.services = Services().services
+
+cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
+cls.domain = get_domain(cls.apiclient)
+
+cls.compute_offering = ServiceOffering.create(
+cls.apiclient,
+cls.services["compute_offering"]
+)
+
+cls.account = Account.create(
+cls.apiclient, services=cls.services["account"])
+
+cls.hypervisor = testClient.getHypervisorInfo()
+
+cls.logger.debug("Downloading Template: %s from: %s" % 
(cls.services["template"][
+ cls.hypervisor.lower()], 
cls.services["template"][cls.hypervisor.lower()]["url"]))
+cls.template = Template.register(cls.apiclient, 
cls.services["template"][cls.hypervisor.lower(
+)], cls.zone.id, hypervisor=cls.hypervisor.lower(), 
account=cls.account.name, domainid=cls.domain.id)
+cls.template.download(cls.apiclient)
+
+if cls.template == FAILED:
+assert False, "get_template() failed to return template"
+
+cls.logger.debug("Successfully created account: %s, id: \
+   %s" % (cls.account.name,
+  cls.account.id))
+
+cls.cleanup = [cls.account, cls.compute_offering]
+return
+
+def _get_ssh_client(self, virtual_machine, services, retries):
+""" Setup ssh client connection and return connection
+vm requires attributes public_ip, public_port, username, password """
+
+try:
+ssh_client = SshClient(
+virtual_machine.public_ip,
+services["virtual_machine"]["ssh_port"],
+services["virtual_machine"]["username"],
+

[GitHub] rhtyd commented on issue #2190: CLOUDSTACK-10010: Fixed the negotiation of S2S VPN connections

[GitBox]

rhtyd commented on issue #2190: CLOUDSTACK-10010: Fixed the negotiation of S2S 
VPN connections
URL: https://github.com/apache/cloudstack/pull/2190#issuecomment-350780939
 
 
   @swill thanks for the PR, I've ported the commit from your PR to #2211 where 
I'm able to repeatedly get the tests pass on KVM and XenServer now! Given there 
is no activity/response on this PR, I'll close this PR and get your stuff 
tested and merged via #2211 now. Again, many thanks for the work.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

[GitBox]

blueorangutan commented on issue #2211: CLOUDSTACK-10013: Migrate 
systemvmtemplate to Debian9
URL: https://github.com/apache/cloudstack/pull/2211#issuecomment-350780478
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1362


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2185: CLOUDSTACK-9976: Redirect saml2 failed login message to a configurable URL

[GitBox]

rhtyd commented on issue #2185: CLOUDSTACK-9976: Redirect saml2 failed login 
message to a configurable URL
URL: https://github.com/apache/cloudstack/pull/2185#issuecomment-350780324
 
 
   @GabrielBrascher ping, update on this PR? (looks like build failure)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2304: CLOUDSTACK-10127: KVM + Ovs: Incorrect devId on static nat

[GitBox]

rhtyd commented on issue #2304: CLOUDSTACK-10127: KVM + Ovs: Incorrect devId on 
static nat
URL: https://github.com/apache/cloudstack/pull/2304#issuecomment-350779961
 
 
   @svenvogel we need to hear from @fmaximus on the failures seen in the test 
results -- if they are caused by this change or intermittent/env introduced


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2149: CLOUDSTACK-9932 snapshot is getting deleted while volume is in creating state

[GitBox]

rhtyd commented on issue #2149: CLOUDSTACK-9932 snapshot is getting deleted 
while volume is in creating state
URL: https://github.com/apache/cloudstack/pull/2149#issuecomment-350780075
 
 
   @pavanaravapalli  please rebase and fix conflicts


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2139: CLOUDSTACK-9921: NPE when storage garbage collector is running.

[GitBox]

blueorangutan commented on issue #2139: CLOUDSTACK-9921: NPE when storage 
garbage collector is running.
URL: https://github.com/apache/cloudstack/pull/2139#issuecomment-350779884
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2208: CLOUDSTACK-9542 make listNics and ListUserVms return uniform NIC data

[GitBox]

rhtyd commented on issue #2208: CLOUDSTACK-9542 make listNics and ListUserVms 
return uniform NIC data
URL: https://github.com/apache/cloudstack/pull/2208#issuecomment-350779543
 
 
   @DaanHoogland please rebase and fix conflicts


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2139: CLOUDSTACK-9921: NPE when storage garbage collector is running.

[GitBox]

rhtyd commented on issue #2139: CLOUDSTACK-9921: NPE when storage garbage 
collector is running.
URL: https://github.com/apache/cloudstack/pull/2139#issuecomment-350779711
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2348: Remove ejb-api 3.0 dependency

[GitBox]

rhtyd commented on issue #2348: Remove ejb-api 3.0 dependency
URL: https://github.com/apache/cloudstack/pull/2348#issuecomment-350778042
 
 
   Good cleanup, we'll need some extended testing on this one.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2356: CLOUDSTACK-8313: Support overprovisioning for local storage

[GitBox]

blueorangutan commented on issue #2356: CLOUDSTACK-8313: Support 
overprovisioning for local storage
URL: https://github.com/apache/cloudstack/pull/2356#issuecomment-350778031
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2356: CLOUDSTACK-8313: Support overprovisioning for local storage

[GitBox]

rhtyd commented on issue #2356: CLOUDSTACK-8313: Support overprovisioning for 
local storage
URL: https://github.com/apache/cloudstack/pull/2356#issuecomment-350777897
 
 
   Code LGTM.
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2267: CLOUDSTACK-10077: allow to have different VPN customer gateway configs for same gateway IP

[GitBox]

rhtyd commented on issue #2267: CLOUDSTACK-10077: allow to have different VPN 
customer gateway configs for same gateway IP
URL: https://github.com/apache/cloudstack/pull/2267#issuecomment-350777084
 
 
   Merged based on prod test recommendation and regression test results.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch master updated: CLOUDSTACK-10077: allow to have different VPN customer gateway configs for same gateway IP (#2267)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/master by this push:
 new e5f0a68a CLOUDSTACK-10077: allow to have different VPN customer 
gateway configs for same gateway IP (#2267)
e5f0a68a is described below

commit e5f0a68a4d5cbd520b9043a1e62959328a52f2af
Author: René Moser 
AuthorDate: Mon Dec 11 17:28:21 2017 +0100

CLOUDSTACK-10077: allow to have different VPN customer gateway configs for 
same gateway IP (#2267)

Related 
https://github.com/apache/cloudstack/commit/86bbe211f2341d52d1d64b0b6d3abcdcef85d3ee
 and CLOUDSTACK-494. Currently we can not have serveral VPCs in one account 
with different VPN customer gateways configuration per same gateway IP.
---
 .../com/cloud/network/dao/Site2SiteCustomerGatewayDao.java   |  2 --
 .../cloud/network/dao/Site2SiteCustomerGatewayDaoImpl.java   | 12 
 .../src/com/cloud/network/vpn/Site2SiteVpnManagerImpl.java   |  9 +
 3 files changed, 1 insertion(+), 22 deletions(-)

diff --git 
a/engine/schema/src/com/cloud/network/dao/Site2SiteCustomerGatewayDao.java 
b/engine/schema/src/com/cloud/network/dao/Site2SiteCustomerGatewayDao.java
index afcd4b6..d0439a5 100644
--- a/engine/schema/src/com/cloud/network/dao/Site2SiteCustomerGatewayDao.java
+++ b/engine/schema/src/com/cloud/network/dao/Site2SiteCustomerGatewayDao.java
@@ -21,8 +21,6 @@ import java.util.List;
 import com.cloud.utils.db.GenericDao;
 
 public interface Site2SiteCustomerGatewayDao extends 
GenericDao {
-Site2SiteCustomerGatewayVO findByGatewayIpAndAccountId(String ip, long 
accountId);
-
 Site2SiteCustomerGatewayVO findByNameAndAccountId(String name, long 
accountId);
 
 List listByAccountId(long accountId);
diff --git 
a/engine/schema/src/com/cloud/network/dao/Site2SiteCustomerGatewayDaoImpl.java 
b/engine/schema/src/com/cloud/network/dao/Site2SiteCustomerGatewayDaoImpl.java
index 4db826b..3aad27c 100644
--- 
a/engine/schema/src/com/cloud/network/dao/Site2SiteCustomerGatewayDaoImpl.java
+++ 
b/engine/schema/src/com/cloud/network/dao/Site2SiteCustomerGatewayDaoImpl.java
@@ -18,8 +18,6 @@ package com.cloud.network.dao;
 
 import java.util.List;
 
-
-import org.apache.log4j.Logger;
 import org.springframework.stereotype.Component;
 
 import com.cloud.utils.db.GenericDaoBase;
@@ -28,8 +26,6 @@ import com.cloud.utils.db.SearchCriteria;
 
 @Component
 public class Site2SiteCustomerGatewayDaoImpl extends 
GenericDaoBase implements 
Site2SiteCustomerGatewayDao {
-private static final Logger s_logger = 
Logger.getLogger(Site2SiteCustomerGatewayDaoImpl.class);
-
 private final SearchBuilder AllFieldsSearch;
 
 protected Site2SiteCustomerGatewayDaoImpl() {
@@ -41,14 +37,6 @@ public class Site2SiteCustomerGatewayDaoImpl extends 
GenericDaoBase sc = 
AllFieldsSearch.create();
-sc.setParameters("gatewayIp", ip);
-sc.setParameters("accountId", accountId);
-return findOneBy(sc);
-}
-
-@Override
 public Site2SiteCustomerGatewayVO findByNameAndAccountId(String name, long 
accountId) {
 SearchCriteria sc = 
AllFieldsSearch.create();
 sc.setParameters("name", name);
diff --git a/server/src/com/cloud/network/vpn/Site2SiteVpnManagerImpl.java 
b/server/src/com/cloud/network/vpn/Site2SiteVpnManagerImpl.java
index ba8c1d1..f188ad3 100644
--- a/server/src/com/cloud/network/vpn/Site2SiteVpnManagerImpl.java
+++ b/server/src/com/cloud/network/vpn/Site2SiteVpnManagerImpl.java
@@ -224,9 +224,6 @@ public class Site2SiteVpnManagerImpl extends ManagerBase 
implements Site2SiteVpn
 }
 
 long accountId = owner.getAccountId();
-if (_customerGatewayDao.findByGatewayIpAndAccountId(gatewayIp, 
accountId) != null) {
-throw new InvalidParameterValueException("The customer gateway 
with ip " + gatewayIp + " already existed in the system!");
-}
 if (_customerGatewayDao.findByNameAndAccountId(name, accountId) != 
null) {
 throw new InvalidParameterValueException("The customer gateway 
with name " + name + " already existed!");
 }
@@ -480,11 +477,7 @@ public class Site2SiteVpnManagerImpl extends ManagerBase 
implements Site2SiteVpn
 checkCustomerGatewayCidrList(guestCidrList);
 
 long accountId = gw.getAccountId();
-Site2SiteCustomerGatewayVO existedGw = 
_customerGatewayDao.findByGatewayIpAndAccountId(gatewayIp, accountId);
-if (existedGw != null && existedGw.getId() != gw.getId()) {
-throw new InvalidParameterValueException("The customer gateway 
with ip " + gatewayIp + " already existed in the system!");
-}
-existedGw = _customerGatewayDao.findByNameAndAccountId(name, 
accountId);
+Site2SiteCustomerGatewayVO existedGw = 

[GitHub] rhtyd closed pull request #2267: CLOUDSTACK-10077: allow to have different VPN customer gateway configs for same gateway IP

[GitBox]

rhtyd closed pull request #2267: CLOUDSTACK-10077: allow to have different VPN 
customer gateway configs for same gateway IP
URL: https://github.com/apache/cloudstack/pull/2267
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/engine/schema/src/com/cloud/network/dao/Site2SiteCustomerGatewayDao.java 
b/engine/schema/src/com/cloud/network/dao/Site2SiteCustomerGatewayDao.java
index afcd4b608dd..d0439a523d0 100644
--- a/engine/schema/src/com/cloud/network/dao/Site2SiteCustomerGatewayDao.java
+++ b/engine/schema/src/com/cloud/network/dao/Site2SiteCustomerGatewayDao.java
@@ -21,8 +21,6 @@
 import com.cloud.utils.db.GenericDao;
 
 public interface Site2SiteCustomerGatewayDao extends 
GenericDao {
-Site2SiteCustomerGatewayVO findByGatewayIpAndAccountId(String ip, long 
accountId);
-
 Site2SiteCustomerGatewayVO findByNameAndAccountId(String name, long 
accountId);
 
 List listByAccountId(long accountId);
diff --git 
a/engine/schema/src/com/cloud/network/dao/Site2SiteCustomerGatewayDaoImpl.java 
b/engine/schema/src/com/cloud/network/dao/Site2SiteCustomerGatewayDaoImpl.java
index 4db826b6459..3aad27c3909 100644
--- 
a/engine/schema/src/com/cloud/network/dao/Site2SiteCustomerGatewayDaoImpl.java
+++ 
b/engine/schema/src/com/cloud/network/dao/Site2SiteCustomerGatewayDaoImpl.java
@@ -18,8 +18,6 @@
 
 import java.util.List;
 
-
-import org.apache.log4j.Logger;
 import org.springframework.stereotype.Component;
 
 import com.cloud.utils.db.GenericDaoBase;
@@ -28,8 +26,6 @@
 
 @Component
 public class Site2SiteCustomerGatewayDaoImpl extends 
GenericDaoBase implements 
Site2SiteCustomerGatewayDao {
-private static final Logger s_logger = 
Logger.getLogger(Site2SiteCustomerGatewayDaoImpl.class);
-
 private final SearchBuilder AllFieldsSearch;
 
 protected Site2SiteCustomerGatewayDaoImpl() {
@@ -40,14 +36,6 @@ protected Site2SiteCustomerGatewayDaoImpl() {
 AllFieldsSearch.done();
 }
 
-@Override
-public Site2SiteCustomerGatewayVO findByGatewayIpAndAccountId(String ip, 
long accountId) {
-SearchCriteria sc = 
AllFieldsSearch.create();
-sc.setParameters("gatewayIp", ip);
-sc.setParameters("accountId", accountId);
-return findOneBy(sc);
-}
-
 @Override
 public Site2SiteCustomerGatewayVO findByNameAndAccountId(String name, long 
accountId) {
 SearchCriteria sc = 
AllFieldsSearch.create();
diff --git a/server/src/com/cloud/network/vpn/Site2SiteVpnManagerImpl.java 
b/server/src/com/cloud/network/vpn/Site2SiteVpnManagerImpl.java
index ba8c1d1ade0..f188ad3545b 100644
--- a/server/src/com/cloud/network/vpn/Site2SiteVpnManagerImpl.java
+++ b/server/src/com/cloud/network/vpn/Site2SiteVpnManagerImpl.java
@@ -224,9 +224,6 @@ public Site2SiteCustomerGateway 
createCustomerGateway(CreateVpnCustomerGatewayCm
 }
 
 long accountId = owner.getAccountId();
-if (_customerGatewayDao.findByGatewayIpAndAccountId(gatewayIp, 
accountId) != null) {
-throw new InvalidParameterValueException("The customer gateway 
with ip " + gatewayIp + " already existed in the system!");
-}
 if (_customerGatewayDao.findByNameAndAccountId(name, accountId) != 
null) {
 throw new InvalidParameterValueException("The customer gateway 
with name " + name + " already existed!");
 }
@@ -480,11 +477,7 @@ public Site2SiteCustomerGateway 
updateCustomerGateway(UpdateVpnCustomerGatewayCm
 checkCustomerGatewayCidrList(guestCidrList);
 
 long accountId = gw.getAccountId();
-Site2SiteCustomerGatewayVO existedGw = 
_customerGatewayDao.findByGatewayIpAndAccountId(gatewayIp, accountId);
-if (existedGw != null && existedGw.getId() != gw.getId()) {
-throw new InvalidParameterValueException("The customer gateway 
with ip " + gatewayIp + " already existed in the system!");
-}
-existedGw = _customerGatewayDao.findByNameAndAccountId(name, 
accountId);
+Site2SiteCustomerGatewayVO existedGw = 
_customerGatewayDao.findByNameAndAccountId(name, accountId);
 if (existedGw != null && existedGw.getId() != gw.getId()) {
 throw new InvalidParameterValueException("The customer gateway 
with name " + name + " already existed!");
 }


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2315: A comprehensive solution for CLOUDSTACK-9025 and CLOUDSTACK-10128.

[GitBox]

rafaelweingartner commented on issue #2315: A comprehensive solution for 
CLOUDSTACK-9025 and CLOUDSTACK-10128.
URL: https://github.com/apache/cloudstack/pull/2315#issuecomment-350776866
 
 
   @rhtyd if this helps for anything, I have this solution running in 
production for over a month now.
   Let's see what other have to say now


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2353: CLOUDSTACK-9986: Use host table to iterate for zone/cluster metrics

[GitBox]

rhtyd commented on issue #2353: CLOUDSTACK-9986: Use host table to iterate for 
zone/cluster metrics
URL: https://github.com/apache/cloudstack/pull/2353#issuecomment-350775989
 
 
   Thanks @GabrielBrascher for the review. However, perhaps another way to 
solve the issue is to fix `host_view`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2315: A comprehensive solution for CLOUDSTACK-9025 and CLOUDSTACK-10128.

[GitBox]

rhtyd commented on issue #2315: A comprehensive solution for CLOUDSTACK-9025 
and CLOUDSTACK-10128.
URL: https://github.com/apache/cloudstack/pull/2315#issuecomment-350775759
 
 
   Ping - can we have +1/-1 on code review?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2204: [CLOUDSTACK-10025] Adding Support for NoVNC Console for KVM and XENSERVER

[GitBox]

rhtyd commented on issue #2204: [CLOUDSTACK-10025] Adding Support for NoVNC 
Console for KVM and XENSERVER
URL: https://github.com/apache/cloudstack/pull/2204#issuecomment-350774975
 
 
   @sachinnitw1317 the expectation is that once you've the novnc console/UI you 
should be able to click on ti and start typing. Anyway to fix that?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2351: CLOUDSTACK-10173: VR's guest/public nic to pick network rate from offering

[GitBox]

rhtyd commented on issue #2351: CLOUDSTACK-10173: VR's guest/public nic to pick 
network rate from offering
URL: https://github.com/apache/cloudstack/pull/2351#issuecomment-350774668
 
 
   Tests LGTM, the failures are known intermittent issues and not caused by 
this PR.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch master updated: CLOUDSTACK-10157: Wrong notification while migration (#2337)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/master by this push:
 new 8c6fb0e  CLOUDSTACK-10157: Wrong notification while migration (#2337)
8c6fb0e is described below

commit 8c6fb0e3120e80e0682b5666b13e70d640e58daf
Author: Nitin Kumar Maharana 
AuthorDate: Mon Dec 11 21:50:37 2017 +0530

CLOUDSTACK-10157: Wrong notification while migration (#2337)

Root Cause:
Earlier, it was failing with ArrayIndexOutOfBoundsException, when the list 
is empty and accessing the first element.
The error was only observed in Log, but was not showing in UI as it was not 
throwing any exception.
Hence the API call was in turn successful.

Solution:
Added the empty check before sending device details.
Which says either the required GPU device is not available or out of 
capacity.
---
 .../src/com/cloud/resource/ResourceManagerImpl.java   | 19 ++-
 1 file changed, 14 insertions(+), 5 deletions(-)

diff --git a/server/src/com/cloud/resource/ResourceManagerImpl.java 
b/server/src/com/cloud/resource/ResourceManagerImpl.java
index 9feb9b7..33c36de 100755
--- a/server/src/com/cloud/resource/ResourceManagerImpl.java
+++ b/server/src/com/cloud/resource/ResourceManagerImpl.java
@@ -29,6 +29,10 @@ import java.util.Map;
 import javax.inject.Inject;
 import javax.naming.ConfigurationException;
 
+import org.apache.commons.lang.ObjectUtils;
+import org.apache.log4j.Logger;
+import org.springframework.stereotype.Component;
+
 import org.apache.cloudstack.api.ApiConstants;
 import org.apache.cloudstack.api.command.admin.cluster.AddClusterCmd;
 import org.apache.cloudstack.api.command.admin.cluster.DeleteClusterCmd;
@@ -44,9 +48,7 @@ import 
org.apache.cloudstack.framework.config.dao.ConfigurationDao;
 import org.apache.cloudstack.storage.datastore.db.PrimaryDataStoreDao;
 import org.apache.cloudstack.storage.datastore.db.StoragePoolVO;
 import org.apache.cloudstack.utils.identity.ManagementServerNode;
-import org.apache.commons.lang.ObjectUtils;
-import org.apache.log4j.Logger;
-import org.springframework.stereotype.Component;
+import org.apache.commons.collections.CollectionUtils;
 
 import com.cloud.agent.AgentManager;
 import com.cloud.agent.api.Answer;
@@ -2755,8 +2757,15 @@ public class ResourceManagerImpl extends ManagerBase 
implements ResourceManager,
 
 @Override
 public GPUDeviceTO getGPUDevice(final long hostId, final String groupName, 
final String vgpuType) {
-final HostGpuGroupsVO gpuDevice = listAvailableGPUDevice(hostId, 
groupName, vgpuType).get(0);
-return new GPUDeviceTO(gpuDevice.getGroupName(), vgpuType, null);
+final List gpuDeviceList = 
listAvailableGPUDevice(hostId, groupName, vgpuType);
+
+if (CollectionUtils.isEmpty(gpuDeviceList)) {
+final String errorMsg = "Host " + hostId + " does not have 
required GPU device or out of capacity. GPU group: " + groupName + ", vGPU 
Type: " + vgpuType;
+s_logger.error(errorMsg);
+throw new CloudRuntimeException(errorMsg);
+}
+
+return new GPUDeviceTO(gpuDeviceList.get(0).getGroupName(), vgpuType, 
null);
 }
 
 @Override

-- 
To stop receiving notification emails like this one, please contact
['"commits@cloudstack.apache.org" '].

[GitHub] rhtyd closed pull request #2337: CLOUDSTACK-10157: Wrong notification while migration.

[GitBox]

rhtyd closed pull request #2337: CLOUDSTACK-10157: Wrong notification while 
migration.
URL: https://github.com/apache/cloudstack/pull/2337
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/server/src/com/cloud/resource/ResourceManagerImpl.java 
b/server/src/com/cloud/resource/ResourceManagerImpl.java
index 9feb9b7f683..33c36de2f8e 100755
--- a/server/src/com/cloud/resource/ResourceManagerImpl.java
+++ b/server/src/com/cloud/resource/ResourceManagerImpl.java
@@ -29,6 +29,10 @@
 import javax.inject.Inject;
 import javax.naming.ConfigurationException;
 
+import org.apache.commons.lang.ObjectUtils;
+import org.apache.log4j.Logger;
+import org.springframework.stereotype.Component;
+
 import org.apache.cloudstack.api.ApiConstants;
 import org.apache.cloudstack.api.command.admin.cluster.AddClusterCmd;
 import org.apache.cloudstack.api.command.admin.cluster.DeleteClusterCmd;
@@ -44,9 +48,7 @@
 import org.apache.cloudstack.storage.datastore.db.PrimaryDataStoreDao;
 import org.apache.cloudstack.storage.datastore.db.StoragePoolVO;
 import org.apache.cloudstack.utils.identity.ManagementServerNode;
-import org.apache.commons.lang.ObjectUtils;
-import org.apache.log4j.Logger;
-import org.springframework.stereotype.Component;
+import org.apache.commons.collections.CollectionUtils;
 
 import com.cloud.agent.AgentManager;
 import com.cloud.agent.api.Answer;
@@ -2755,8 +2757,15 @@ public boolean isGPUDeviceAvailable(final long hostId, 
final String groupName, f
 
 @Override
 public GPUDeviceTO getGPUDevice(final long hostId, final String groupName, 
final String vgpuType) {
-final HostGpuGroupsVO gpuDevice = listAvailableGPUDevice(hostId, 
groupName, vgpuType).get(0);
-return new GPUDeviceTO(gpuDevice.getGroupName(), vgpuType, null);
+final List gpuDeviceList = 
listAvailableGPUDevice(hostId, groupName, vgpuType);
+
+if (CollectionUtils.isEmpty(gpuDeviceList)) {
+final String errorMsg = "Host " + hostId + " does not have 
required GPU device or out of capacity. GPU group: " + groupName + ", vGPU 
Type: " + vgpuType;
+s_logger.error(errorMsg);
+throw new CloudRuntimeException(errorMsg);
+}
+
+return new GPUDeviceTO(gpuDeviceList.get(0).getGroupName(), vgpuType, 
null);
 }
 
 @Override


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2337: CLOUDSTACK-10157: Wrong notification while migration.

[GitBox]

rhtyd commented on issue #2337: CLOUDSTACK-10157: Wrong notification while 
migration.
URL: https://github.com/apache/cloudstack/pull/2337#issuecomment-350774432
 
 
   Given our current regression testing system does not have GPU capabilties, 
I'll use travis test results as verification of the build/code, two 
reviews/lgtms and merge this PR.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2337: CLOUDSTACK-10157: Wrong notification while migration.

[GitBox]

rhtyd commented on issue #2337: CLOUDSTACK-10157: Wrong notification while 
migration.
URL: https://github.com/apache/cloudstack/pull/2337#issuecomment-350774179
 
 
   LGTM, simple NPE check.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2326: Re-work method QuotaResponseBuilderImpl.startOfNextDay and its test cases

[GitBox]

rhtyd commented on issue #2326: Re-work method 
QuotaResponseBuilderImpl.startOfNextDay and its test cases
URL: https://github.com/apache/cloudstack/pull/2326#issuecomment-350773984
 
 
   @rafaelweingartner please add a JIRA id for this, thanks.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2355: CLOUDSTACK-10177: Only pass IPv6 address to Security Group Python scr?

[GitBox]

rhtyd commented on issue #2355: CLOUDSTACK-10177: Only pass IPv6 address to 
Security Group Python scr?
URL: https://github.com/apache/cloudstack/pull/2355#issuecomment-350773511
 
 
   LGTM, merging. All errors seen are intermittent.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch master updated: CLOUDSTACK-10177: Only pass IPv6 address to Security Group Python script if present (#2355)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/master by this push:
 new be3a39e  CLOUDSTACK-10177: Only pass IPv6 address to Security Group 
Python script if present (#2355)
be3a39e is described below

commit be3a39ea4fcb1f758d72c4e4abc43f428845c4d1
Author: Wido den Hollander 
AuthorDate: Mon Dec 11 17:17:50 2017 +0100

CLOUDSTACK-10177: Only pass IPv6 address to Security Group Python script if 
present (#2355)

Otherwise we send down a 'null' to a ProcessBuilder in Java instead of a 
String and this
causes a NPE.

We should check first if the Instance has a IPv6 address before sending it 
there.

Signed-off-by: Wido den Hollander 
---
 .../com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java   | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git 
a/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 
b/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
index 7794249..952fe9e 100644
--- 
a/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
+++ 
b/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
@@ -3478,7 +3478,9 @@ public class LibvirtComputingResource extends 
ServerResourceBase implements Serv
 cmd.add("--vmname", vmName);
 cmd.add("--vmid", vmId);
 cmd.add("--vmip", guestIP);
-cmd.add("--vmip6", guestIP6);
+if (StringUtils.isNotBlank(guestIP6)) {
+cmd.add("--vmip6", guestIP6);
+}
 cmd.add("--sig", sig);
 cmd.add("--seq", seq);
 cmd.add("--vmmac", mac);

-- 
To stop receiving notification emails like this one, please contact
['"commits@cloudstack.apache.org" '].

[GitHub] rhtyd commented on issue #2355: CLOUDSTACK-10177: Only pass IPv6 address to Security Group Python scr?

[GitBox]

rhtyd commented on issue #2355: CLOUDSTACK-10177: Only pass IPv6 address to 
Security Group Python scr?
URL: https://github.com/apache/cloudstack/pull/2355#issuecomment-350773511
 
 
   LGTM, merging. All errors seen are intermittent and env related.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd closed pull request #2355: CLOUDSTACK-10177: Only pass IPv6 address to Security Group Python scr?

[GitBox]

rhtyd closed pull request #2355: CLOUDSTACK-10177: Only pass IPv6 address to 
Security Group Python scr?
URL: https://github.com/apache/cloudstack/pull/2355
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 
b/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
index 77942499a93..952fe9e7cc9 100644
--- 
a/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
+++ 
b/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
@@ -3478,7 +3478,9 @@ public boolean addNetworkRules(final String vmName, final 
String vmId, final Str
 cmd.add("--vmname", vmName);
 cmd.add("--vmid", vmId);
 cmd.add("--vmip", guestIP);
-cmd.add("--vmip6", guestIP6);
+if (StringUtils.isNotBlank(guestIP6)) {
+cmd.add("--vmip6", guestIP6);
+}
 cmd.add("--sig", sig);
 cmd.add("--seq", seq);
 cmd.add("--vmmac", mac);


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch debian9-systemvmtemplate updated: use new get_test_templates

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch debian9-systemvmtemplate
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/debian9-systemvmtemplate by 
this push:
 new 16025e8  use new get_test_templates
16025e8 is described below

commit 16025e8af07d3984111f67aaeea2c28152d62889
Author: Rohit Yadav 
AuthorDate: Mon Dec 11 21:40:49 2017 +0530

use new get_test_templates

Signed-off-by: Rohit Yadav 
---
 test/integration/smoke/test_accounts.py| 22 +++--
 test/integration/smoke/test_affinity_groups.py | 10 +++---
 .../smoke/test_affinity_groups_projects.py | 11 ---
 test/integration/smoke/test_deploy_vm_iso.py   |  7 +++--
 test/integration/smoke/test_host_maintenance.py|  6 ++--
 test/integration/smoke/test_hostha_kvm.py  |  4 +--
 test/integration/smoke/test_list_ids_parameter.py  | 10 +++---
 .../smoke/test_nested_virtualization.py| 16 +-
 test/integration/smoke/test_network.py | 36 +++---
 test/integration/smoke/test_nic.py |  6 ++--
 test/integration/smoke/test_projects.py|  7 +++--
 test/integration/smoke/test_reset_vm_on_reboot.py  |  7 +++--
 test/integration/smoke/test_router_dhcphosts.py| 12 +---
 test/integration/smoke/test_vpc_router_nics.py | 30 ++
 14 files changed, 99 insertions(+), 85 deletions(-)

diff --git a/test/integration/smoke/test_accounts.py 
b/test/integration/smoke/test_accounts.py
index a64d922..00047bf 100644
--- a/test/integration/smoke/test_accounts.py
+++ b/test/integration/smoke/test_accounts.py
@@ -32,7 +32,7 @@ from marvin.lib.base import (Domain,
  PublicIPAddress)
 from marvin.lib.common import (get_domain,
get_zone,
-   get_template,
+   get_test_template,
list_accounts,
list_virtual_machines,
list_service_offering,
@@ -128,11 +128,12 @@ class TestAccounts(cloudstackTestCase):
 
 cls.services = Services().services
 cls.zone = get_zone(cls.api_client, cls.testClient.getZoneForTests())
+cls.hypervisor = cls.testClient.getHypervisorInfo()
 cls.services['mode'] = cls.zone.networktype
-cls.template = get_template(
+cls.template = get_test_template(
 cls.api_client,
 cls.zone.id,
-cls.services["ostype"]
+cls.hypervisor
 )
 cls.services["virtual_machine"]["zoneid"] = cls.zone.id
 cls.services["virtual_machine"]["template"] = cls.template.id
@@ -270,11 +271,12 @@ class TestRemoveUserFromAccount(cloudstackTestCase):
 
 cls.services = Services().services
 cls.zone = get_zone(cls.api_client, cls.testClient.getZoneForTests())
+cls.hypervisor = cls.testClient.getHypervisorInfo()
 cls.services['mode'] = cls.zone.networktype
-cls.template = get_template(
+cls.template = get_test_template(
 cls.api_client,
 cls.zone.id,
-cls.services["ostype"]
+cls.hypervisor
 )
 cls.services["virtual_machine"]["zoneid"] = cls.zone.id
 cls.services["virtual_machine"]["template"] = cls.template.id
@@ -948,6 +950,7 @@ class TestAddVmToSubDomain(cloudstackTestCase):
 cls.services = Services().services
 cls.domain = get_domain(cls.api_client)
 cls.zone = get_zone(cls.api_client, cls.testClient.getZoneForTests())
+cls.hypervisor = cls.testClient.getHypervisorInfo()
 cls.services['mode'] = cls.zone.networktype
 cls.sub_domain = Domain.create(
 cls.api_client,
@@ -983,10 +986,10 @@ class TestAddVmToSubDomain(cloudstackTestCase):
 cls.sub_domain,
 cls.service_offering
 ]
-cls.template = get_template(
+cls.template = get_test_template(
 cls.api_client,
 cls.zone.id,
-cls.services["ostype"]
+cls.hypervisor
 )
 cls.services["virtual_machine"]["zoneid"] = cls.zone.id
 cls.vm_1 = VirtualMachine.create(
@@ -1717,12 +1720,13 @@ class TestDomainForceRemove(cloudstackTestCase):
 cls.services = Services().services
 cls.domain = get_domain(cls.api_client)
 cls.zone = get_zone(cls.api_client, cls.testClient.getZoneForTests())
+cls.hypervisor = cls.testClient.getHypervisorInfo()
 cls.services['mode'] = cls.zone.networktype
 
-cls.template = get_template(
+cls.template = get_test_template(
 cls.api_client,
 cls.zone.id,
-cls.services["ostype"]
+cls.hypervisor
  

[GitHub] blueorangutan commented on issue #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

[GitBox]

blueorangutan commented on issue #2211: CLOUDSTACK-10013: Migrate 
systemvmtemplate to Debian9
URL: https://github.com/apache/cloudstack/pull/2211#issuecomment-350422232
 
 
   Trillian test result (tid-1745)
   Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 103648 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2211-t1745-vmware-55u3.zip
   Test /marvin/tests/smoke/test_accounts.py took 2026 seconds
   Test /marvin/tests/smoke/test_affinity_groups_projects.py took 315 seconds
   Test /marvin/tests/smoke/test_affinity_groups.py took 259 seconds
   Test /marvin/tests/smoke/test_certauthority_root.py took 37 seconds
   Test /marvin/tests/smoke/test_deploy_vgpu_enabled_vm.py took 507 seconds
   Test /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py took 6 seconds
   Test /marvin/tests/smoke/test_deploy_vm_iso.py took 208 seconds
   Test /marvin/tests/smoke/test_deploy_vm_root_resize.py took 158 seconds
   Test /marvin/tests/smoke/test_deploy_vms_with_varied_deploymentplanners.py 
took 573 seconds
   Test /marvin/tests/smoke/test_deploy_vm_with_userdata.py took 279 seconds
   Test /marvin/tests/smoke/test_disk_offerings.py took 6 seconds
   Test /marvin/tests/smoke/test_dynamicroles.py took 116 seconds
   Test /marvin/tests/smoke/test_global_settings.py took 6 seconds
   Test /marvin/tests/smoke/test_guest_vlan_range.py took 27 seconds
   Test /marvin/tests/smoke/test_host_annotations.py took 14 seconds
   Test /marvin/tests/smoke/test_hostha_simulator.py took 6 seconds
   Test /marvin/tests/smoke/test_host_maintenance.py took 605 seconds
   Test /marvin/tests/smoke/test_internal_lb.py took 13591 seconds
   Test /marvin/tests/smoke/test_iso.py took 247 seconds
   Test /marvin/tests/smoke/test_list_ids_parameter.py took 3632 seconds
   Test /marvin/tests/smoke/test_loadbalance.py took 3507 seconds
   Test /marvin/tests/smoke/test_login.py took 25 seconds
   Test /marvin/tests/smoke/test_metrics_api.py took 231 seconds
   Test /marvin/tests/smoke/test_multipleips_per_nic.py took 209 seconds
   Test /marvin/tests/smoke/test_nested_virtualization.py took 415 seconds
   Test /marvin/tests/smoke/test_network_acl.py took 238 seconds
   Test /marvin/tests/smoke/test_network.py took 2724 seconds
   Test /marvin/tests/smoke/test_nic_adapter_type.py took 12 seconds
   Test /marvin/tests/smoke/test_nic.py took 1282 seconds
   Test /marvin/tests/smoke/test_non_contigiousvlan.py took 21 seconds
   Test /marvin/tests/smoke/test_outofbandmanagement_nestedplugin.py took 92 
seconds
   Test /marvin/tests/smoke/test_outofbandmanagement.py took 241 seconds
   Test /marvin/tests/smoke/test_over_provisioning.py took 5 seconds
   Test /marvin/tests/smoke/test_password_server.py took 389 seconds
   Test /marvin/tests/smoke/test_portable_publicip.py took 48 seconds
   Test /marvin/tests/smoke/test_portforwardingrules.py took 245 seconds
   Test /marvin/tests/smoke/test_primary_storage.py took 829 seconds
   Test /marvin/tests/smoke/test_privategw_acl.py took 9181 seconds
   Test /marvin/tests/smoke/test_projects.py took 801 seconds
   Test /marvin/tests/smoke/test_public_ip_range.py took 12 seconds
   Test /marvin/tests/smoke/test_pvlan.py took 11 seconds
   Test /marvin/tests/smoke/test_regions.py took 6 seconds
   Test /marvin/tests/smoke/test_reset_vm_on_reboot.py took 316 seconds
   Test /marvin/tests/smoke/test_resource_detail.py took 22 seconds
   Test /marvin/tests/smoke/test_router_dhcphosts.py took 1549 seconds
   Test /marvin/tests/smoke/test_router_dns.py took 266 seconds
   Test /marvin/tests/smoke/test_router_dnsservice.py took 356 seconds
   Test /marvin/tests/smoke/test_routers_iptables_default_policy.py took 929 
seconds
   Test /marvin/tests/smoke/test_routers_network_ops.py took 2017 seconds
   Test /marvin/tests/smoke/test_routers.py took 728 seconds
   Test /marvin/tests/smoke/test_scale_vm.py took 358 seconds
   Test /marvin/tests/smoke/test_secondary_storage.py took 6 seconds
   Test /marvin/tests/smoke/test_service_offerings.py took 571 seconds
   Test /marvin/tests/smoke/test_snapshots.py took 364 seconds
   Test /marvin/tests/smoke/test_ssvm.py took 1380 seconds
   Test /marvin/tests/smoke/test_staticroles.py took 6 seconds
   Test /marvin/tests/smoke/test_templates.py took 5373 seconds
   Test /marvin/tests/smoke/test_usage_events.py took 7 seconds
   Test /marvin/tests/smoke/test_usage.py took 2932 seconds
   Test /marvin/tests/smoke/test_vm_life_cycle.py took 1938 seconds
   Test /marvin/tests/smoke/test_vm_snapshots.py took 1696 seconds
   Test /marvin/tests/smoke/test_volumes.py took 1026 seconds
   Test /marvin/tests/smoke/test_vpc_redundant.py took 25081 seconds
   Test /marvin/tests/smoke/test_vpc_router_nics.py took 7270 seconds
   Test /marvin/tests/smoke/test_vpc_vpn.py took 4578 seconds
   Test /marvin/tests/smoke/test_hostha_kvm.py took 13 seconds
   Test completed. 49 look OK, 17 have error(s)
   
   
   

[GitHub] blueorangutan commented on issue #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

[GitBox]

blueorangutan commented on issue #2211: CLOUDSTACK-10013: Migrate 
systemvmtemplate to Debian9
URL: https://github.com/apache/cloudstack/pull/2211#issuecomment-350628189
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1359


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

[GitBox]

blueorangutan commented on issue #2211: CLOUDSTACK-10013: Migrate 
systemvmtemplate to Debian9
URL: https://github.com/apache/cloudstack/pull/2211#issuecomment-350626501
 
 
   Trillian test result (tid-1763)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 30181 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2211-t1763-kvm-centos7.zip
   Test completed. Failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | 
test_snapshots.py
   ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
   test_01_template_usage | `Error` | 50.55 | test_usage.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

[GitBox]

blueorangutan commented on issue #2211: CLOUDSTACK-10013: Migrate 
systemvmtemplate to Debian9
URL: https://github.com/apache/cloudstack/pull/2211#issuecomment-350712972
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1360


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

[GitBox]

blueorangutan commented on issue #2211: CLOUDSTACK-10013: Migrate 
systemvmtemplate to Debian9
URL: https://github.com/apache/cloudstack/pull/2211#issuecomment-350725725
 
 
   Trillian test result (tid-1767)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 27156 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2211-t1767-kvm-centos7.zip
   Test completed. Failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   ContextSuite context=TestDeployVirtioSCSIVM>:setup | `Error` | 0.00 | 
test_deploy_virtio_scsi_vm.py
   test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Failure` | 367.12 | 
test_internal_lb.py
   test_02_list_cpvm_vm | `Failure` | 0.03 | test_ssvm.py
   test_04_cpvm_internals | `Failure` | 0.03 | test_ssvm.py
   test_06_stop_cpvm | `Failure` | 0.03 | test_ssvm.py
   test_08_reboot_cpvm | `Failure` | 0.04 | test_ssvm.py
   test_10_destroy_cpvm | `Error` | 5.12 | test_ssvm.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

[GitBox]

blueorangutan commented on issue #2211: CLOUDSTACK-10013: Migrate 
systemvmtemplate to Debian9
URL: https://github.com/apache/cloudstack/pull/2211#issuecomment-350721925
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1361


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

[GitBox]

blueorangutan commented on issue #2211: CLOUDSTACK-10013: Migrate 
systemvmtemplate to Debian9
URL: https://github.com/apache/cloudstack/pull/2211#issuecomment-350725725
 
 
   Trillian test result (tid-1767)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 27156 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2211-t1767-kvm-centos7.zip
   Test completed. Failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   ContextSuite context=TestDeployVirtioSCSIVM>:setup | `Error` | 0.00 | 
test_deploy_virtio_scsi_vm.py
   test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Failure` | 367.12 | 
test_internal_lb.py
   test_02_list_cpvm_vm | `Failure` | 0.03 | test_ssvm.py
   test_04_cpvm_internals | `Failure` | 0.03 | test_ssvm.py
   test_06_stop_cpvm | `Failure` | 0.03 | test_ssvm.py
   test_08_reboot_cpvm | `Failure` | 0.04 | test_ssvm.py
   test_10_destroy_cpvm | `Error` | 5.12 | test_ssvm.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] GabrielBrascher commented on issue #2353: CLOUDSTACK-9986: Use host table to iterate for zone/cluster metrics

[GitBox]

GabrielBrascher commented on issue #2353: CLOUDSTACK-9986: Use host table to 
iterate for zone/cluster metrics
URL: https://github.com/apache/cloudstack/pull/2353#issuecomment-350723513
 
 
   Code LGTM. Thanks for the PR, @rhtyd.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

[GitBox]

blueorangutan commented on issue #2211: CLOUDSTACK-10013: Migrate 
systemvmtemplate to Debian9
URL: https://github.com/apache/cloudstack/pull/2211#issuecomment-350721925
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1361


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch debian9-systemvmtemplate updated: systemvmtemplate enlargements

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch debian9-systemvmtemplate
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/debian9-systemvmtemplate by 
this push:
 new 51a2d71  systemvmtemplate enlargements
51a2d71 is described below

commit 51a2d7129b154894e812cf46ab630b345c740e0a
Author: Rohit Yadav 
AuthorDate: Mon Dec 11 18:23:11 2017 +0530

systemvmtemplate enlargements

Signed-off-by: Rohit Yadav 
---
 tools/appliance/definitions/systemvmtemplate/preseed.cfg | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/tools/appliance/definitions/systemvmtemplate/preseed.cfg 
b/tools/appliance/definitions/systemvmtemplate/preseed.cfg
index 290d867..60bd9a8 100644
--- a/tools/appliance/definitions/systemvmtemplate/preseed.cfg
+++ b/tools/appliance/definitions/systemvmtemplate/preseed.cfg
@@ -63,17 +63,17 @@ d-i partman-auto/expert_recipe string   
  \
   use_filesystem{ } filesystem{ ext2 }\
   mountpoint{ /boot } \
   .   \
-  1000 40 1200 ext4   \
+  1300 40 1500 ext4   \
   method{ format } format{ }  \
   use_filesystem{ } filesystem{ ext4 }\
   mountpoint{ / } \
   .   \
-  700 70 800 ext4 \
+  550 70 800 ext4 \
   method{ format } format{ }  \
   use_filesystem{ } filesystem{ ext4 }\
   mountpoint{ /var }  \
   .   \
-  400 60 500 ext4 \
+  350 60 500 ext4 \
   method{ format } format{ }  \
   use_filesystem{ } filesystem{ ext4 }\
   mountpoint{ /var/log }  \
@@ -83,7 +83,7 @@ d-i partman-auto/expert_recipe string 
\
   use_filesystem{ } filesystem{ ext4 }\
   mountpoint{ /tmp }  \
   .   \
-  200 100 1024 linux-swap \
+  100 100 1024 linux-swap \
   method{ swap } format{ }\
   .
 

-- 
To stop receiving notification emails like this one, please contact
['"commits@cloudstack.apache.org" '].

[cloudstack] branch debian9-systemvmtemplate updated: rvr fixes

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch debian9-systemvmtemplate
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/debian9-systemvmtemplate by 
this push:
 new fea28d8  rvr fixes
fea28d8 is described below

commit fea28d89a833ddc08c2da391dd2c38353c6dc50b
Author: Rohit Yadav 
AuthorDate: Mon Dec 11 18:14:05 2017 +0530

rvr fixes

Signed-off-by: Rohit Yadav 
---
 systemvm/debian/opt/cloud/bin/cs/CsRedundant.py| 11 ++--
 systemvm/debian/opt/cloud/bin/setup/common.sh  | 61 --
 systemvm/debian/opt/cloud/bin/setup/router.sh  |  5 --
 systemvm/debian/opt/cloud/bin/setup/vpcrouter.sh   |  5 --
 .../opt/cloud/templates/keepalived.conf.templ  |  1 -
 5 files changed, 7 insertions(+), 76 deletions(-)

diff --git a/systemvm/debian/opt/cloud/bin/cs/CsRedundant.py 
b/systemvm/debian/opt/cloud/bin/cs/CsRedundant.py
index 108f337..29b5028 100755
--- a/systemvm/debian/opt/cloud/bin/cs/CsRedundant.py
+++ b/systemvm/debian/opt/cloud/bin/cs/CsRedundant.py
@@ -75,6 +75,10 @@ class CsRedundant(object):
 def _redundant_off(self):
 CsHelper.service("conntrackd", "stop")
 CsHelper.service("keepalived", "stop")
+CsHelper.umount_tmpfs(self.CS_RAMDISK_DIR)
+CsHelper.rmdir(self.CS_RAMDISK_DIR)
+CsHelper.rm(self.CONNTRACKD_CONF)
+CsHelper.rm(self.KEEPALIVED_CONF)
 
 def _redundant_on(self):
 guest = self.address.get_guest_if()
@@ -107,10 +111,9 @@ class CsRedundant(object):
 CsHelper.service("keepalived", "stop")
 return
 
-# setup_router should execute this already:
-# CsHelper.mkdir(self.CS_RAMDISK_DIR, 0755, False)
-# CsHelper.mount_tmpfs(self.CS_RAMDISK_DIR)
-# CsHelper.mkdir(self.CS_ROUTER_DIR, 0755, False)
+CsHelper.mkdir(self.CS_RAMDISK_DIR, 0755, False)
+CsHelper.mount_tmpfs(self.CS_RAMDISK_DIR)
+CsHelper.mkdir(self.CS_ROUTER_DIR, 0755, False)
 for s in self.CS_TEMPLATES:
 d = s
 if s.endswith(".templ"):
diff --git a/systemvm/debian/opt/cloud/bin/setup/common.sh 
b/systemvm/debian/opt/cloud/bin/setup/common.sh
index 76ec826..f1f72f4 100755
--- a/systemvm/debian/opt/cloud/bin/setup/common.sh
+++ b/systemvm/debian/opt/cloud/bin/setup/common.sh
@@ -609,67 +609,6 @@ routing_svcs() {
fi
 }
 
-setup_redundant_router() {
-rrouter_bin_path="/ramdisk/rrouter"
-rrouter_log="/ramdisk/rrouter/keepalived.log"
-rrouter_bin_path_str="\/ramdisk\/rrouter"
-rrouter_log_str="\/ramdisk\/rrouter\/keepalived.log"
-mkdir -p /ramdisk
-mount tmpfs /ramdisk -t tmpfs
-mkdir -p /ramdisk/rrouter
-ip route delete default
-
-# Seed keepalived
-if [ "$RROUTER_STATE" == "MASTER" ]
-then
-sed -i "s/priority.*/priority 100/g" 
/opt/cloud/templates/keepalived.conf.templ
-else
-sed -i "s/priority.*/priority 50/g" 
/opt/cloud/templates/keepalived.conf.templ
-fi
-cp /opt/cloud/templates/keepalived.conf.templ 
/etc/keepalived/keepalived.conf # changes!
-sed -i "s/\[ROUTER_ID\]/$NAME/g" /etc/keepalived/keepalived.conf
-sed -i "s/\[ROUTER_IP\]/$GUEST_GW\/$GUEST_CIDR_SIZE/g" 
/etc/keepalived/keepalived.conf #fixme, multiple ips?
-sed -i "s/\[BOARDCAST\]/$GUEST_BRD/g" /etc/keepalived/keepalived.conf
-sed -i "s/\[PRIORITY\]/$ROUTER_PR/g" /etc/keepalived/keepalived.conf
-sed -i "s/\[PASS\]/$VM_PASSWORD/g" /etc/keepalived/keepalived.conf
-sed -i "s/\[RROUTER_BIN_PATH\]/$rrouter_bin_path_str/g" 
/etc/keepalived/keepalived.conf
-sed -i "s/\[DELTA\]/2/g" /etc/keepalived/keepalived.conf
-sed -i "s/--exec\ \$DAEMON;/--exec\ \$DAEMON\ --\ --vrrp;/g" 
/etc/init.d/keepalived
-if [ $ADVERT_INT ]
-then
-sed -i "s/advert_int 1/advert_int $ADVERT_INT/g" 
/etc/keepalived/keepalived.conf
-fi
-chmod -x /etc/keepalived/keepalived.conf
-
-# Seed conntrackd
-cp /opt/cloud/templates/conntrackd.conf.templ 
/etc/conntrackd/conntrackd.conf
-sed -i "s/\[LINK_IF\]/eth0/g" /etc/conntrackd/conntrackd.conf
-sed -i "s/\[LINK_IP\]/$ETH0_IP/g" /etc/conntrackd/conntrackd.conf
-sed -i "s/\[IGNORE_IP1\]/$GUEST_GW/g" /etc/conntrackd/conntrackd.conf # 
checkme?
-sed -i "s/\[IGNORE_IP2\]/$ETH0_IP/g" /etc/conntrackd/conntrackd.conf
-sed -i "s/\[IGNORE_IP3\]/$ETH1_IP/g" /etc/conntrackd/conntrackd.conf
-
-# ramdisk scripts
-cp /opt/cloud/templates/heartbeat.sh.templ $rrouter_bin_path/heartbeat.sh
-cp /opt/cloud/templates/check_heartbeat.sh.templ 
$rrouter_bin_path/check_heartbeat.sh
-cp /opt/cloud/templates/arping_gateways.sh.templ 
$rrouter_bin_path/arping_gateways.sh
-cp /opt/cloud/templates/check_bumpup.sh $rrouter_bin_path/
-cp /opt/cloud/templates/checkrouter.sh.templ /opt/cloud/bin/checkrouter.sh 
# changes!
-#sed -i 

[GitHub] blueorangutan commented on issue #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

[GitBox]

blueorangutan commented on issue #2211: CLOUDSTACK-10013: Migrate 
systemvmtemplate to Debian9
URL: https://github.com/apache/cloudstack/pull/2211#issuecomment-350712972
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1360


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] 01/01: more fixes

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch debian9-systemvmtemplate
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit e0c6b7cfe02cc16ade4aa17d415ee70fd0180f09
Author: Rohit Yadav 
AuthorDate: Mon Dec 11 17:39:44 2017 +0530

more fixes

Signed-off-by: Rohit Yadav 
---
 systemvm/debian/etc/issue  |  1 +
 systemvm/debian/opt/cloud/bin/update_config.py |  2 +-
 test/integration/smoke/test_templates.py   |  4 ++--
 .../definitions/systemvmtemplate/apt_upgrade.sh|  1 -
 .../appliance/definitions/systemvmtemplate/cleanup.sh  |  3 +--
 .../definitions/systemvmtemplate/configure_grub.sh |  2 +-
 .../definitions/systemvmtemplate/definition.rb |  2 +-
 .../appliance/definitions/systemvmtemplate/finalize.sh |  2 +-
 .../appliance/definitions/systemvmtemplate/preseed.cfg | 18 ++
 tools/marvin/marvin/lib/common.py  | 15 +--
 10 files changed, 27 insertions(+), 23 deletions(-)

diff --git a/systemvm/debian/etc/issue b/systemvm/debian/etc/issue
index 2d2b7c0..94e8f84 100644
--- a/systemvm/debian/etc/issue
+++ b/systemvm/debian/etc/issue
@@ -1,3 +1,4 @@
__?.o/  Apache CloudStack SystemVM 4.11
   (  )#https://cloudstack.apache.org
  (___(_)   \s \r \n \l
+
diff --git a/systemvm/debian/opt/cloud/bin/update_config.py 
b/systemvm/debian/opt/cloud/bin/update_config.py
index a603f47..db47c53 100755
--- a/systemvm/debian/opt/cloud/bin/update_config.py
+++ b/systemvm/debian/opt/cloud/bin/update_config.py
@@ -41,7 +41,7 @@ currentGuestNetConfig = "/etc/cloudstack/guestnetwork.json"
 
 # If the command line json file is unprocessed process it
 # This is important or, the control interfaces will get deleted!
-if os.path.isfile(jsonPath % "cmd_line.json"):
+if jsonFilename != "cmd_line.json" and os.path.isfile(jsonPath % 
"cmd_line.json"):
 qf = QueueFile()
 qf.setFile("cmd_line.json")
 qf.load(None)
diff --git a/test/integration/smoke/test_templates.py 
b/test/integration/smoke/test_templates.py
index 955fe6e..6544ad2 100644
--- a/test/integration/smoke/test_templates.py
+++ b/test/integration/smoke/test_templates.py
@@ -158,7 +158,6 @@ class TestCreateTemplateWithChecksum(cloudstackTestCase):
 cmd.id = temp.id
 cmd.zoneid = self.zone.id
 self.apiclient.deleteTemplate(cmd)
-
 except Exception as e:
 raise Exception("Warning: Exception during cleanup : %s" % e)
 return
@@ -227,7 +226,8 @@ class TestCreateTemplateWithChecksum(cloudstackTestCase):
 
 def registerTemplate(self, cmd):
 temp = self.apiclient.registerTemplate(cmd)[0]
-self.cleanup.append(temp)
+if not temp:
+self.cleanup.append(temp)
 return temp
 
 def getOsType(self, param):
diff --git a/tools/appliance/definitions/systemvmtemplate/apt_upgrade.sh 
b/tools/appliance/definitions/systemvmtemplate/apt_upgrade.sh
index 2d7394d..4a408c3 100644
--- a/tools/appliance/definitions/systemvmtemplate/apt_upgrade.sh
+++ b/tools/appliance/definitions/systemvmtemplate/apt_upgrade.sh
@@ -22,7 +22,6 @@ set -x
 function fix_tune2fs() {
   for partition in $(blkid -o list | grep ext | awk '{print $1}')
   do
-tune2fs -m0 $partition
 tune2fs -c 1 $partition
   done
   fdisk -l
diff --git a/tools/appliance/definitions/systemvmtemplate/cleanup.sh 
b/tools/appliance/definitions/systemvmtemplate/cleanup.sh
index 00f068d..fd7d9f3 100644
--- a/tools/appliance/definitions/systemvmtemplate/cleanup.sh
+++ b/tools/appliance/definitions/systemvmtemplate/cleanup.sh
@@ -22,7 +22,7 @@ set -x
 function cleanup_apt() {
   apt-get -y remove --purge dictionaries-common busybox isc-dhcp-client 
isc-dhcp-common \
 task-english task-ssh-server tasksel tasksel-data laptop-detect nano 
wamerican \
-debconf-i18n sharutils gnupg gnupg-agent keyboard-configuration
+debconf-i18n sharutils gnupg gnupg-agent
 
   apt-get -y autoremove --purge
   apt-get autoclean
@@ -59,7 +59,6 @@ function cleanup_misc() {
   # Docs and data files
   rm -fr /var/lib/apt/*
   rm -fr /var/cache/apt/*
-  rm -fr /usr/lib/gnupg*
   rm -fr /usr/share/doc
   rm -fr /usr/share/man
   rm -fr /usr/share/info
diff --git a/tools/appliance/definitions/systemvmtemplate/configure_grub.sh 
b/tools/appliance/definitions/systemvmtemplate/configure_grub.sh
index 4a42dc6..c0a2596 100644
--- a/tools/appliance/definitions/systemvmtemplate/configure_grub.sh
+++ b/tools/appliance/definitions/systemvmtemplate/configure_grub.sh
@@ -27,7 +27,7 @@ function configure_grub() {
 GRUB_DEFAULT=0
 GRUB_TIMEOUT=0
 GRUB_DISTRIBUTOR=Debian
-GRUB_CMDLINE_LINUX_DEFAULT="quiet"
+GRUB_CMDLINE_LINUX_DEFAULT=""
 GRUB_CMDLINE_LINUX="console=tty0 console=ttyS0,115200n8 console=hvc0 
earlyprintk=xen net.ifnames=0 biosdevname=0 debian-installer=en_US 

[cloudstack] branch debian9-systemvmtemplate updated (507f732 -> e0c6b7c)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a change to branch debian9-systemvmtemplate
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


 discard 507f732  more fixes
 new e0c6b7c  more fixes

This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version.  This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:

 * -- * -- B -- O -- O -- O   (507f732)
\
 N -- N -- N   refs/heads/debian9-systemvmtemplate (e0c6b7c)

You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.

Any revisions marked "omit" are not gone; other references still
refer to them.  Any revisions marked "discard" are gone forever.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 systemvm/debian/etc/issue  |  1 +
 systemvm/debian/opt/cloud/bin/update_config.py |  7 +++
 .../definitions/systemvmtemplate/apt_upgrade.sh|  1 -
 .../appliance/definitions/systemvmtemplate/cleanup.sh  |  3 +--
 .../definitions/systemvmtemplate/configure_grub.sh |  2 +-
 .../definitions/systemvmtemplate/definition.rb |  2 +-
 .../appliance/definitions/systemvmtemplate/finalize.sh |  2 +-
 .../appliance/definitions/systemvmtemplate/preseed.cfg | 18 ++
 tools/marvin/marvin/lib/common.py  | 15 +--
 9 files changed, 31 insertions(+), 20 deletions(-)

-- 
To stop receiving notification emails like this one, please contact
['"commits@cloudstack.apache.org" '].

[GitHub] asfbot commented on issue #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

[GitBox]

asfbot commented on issue #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to 
Debian9
URL: https://github.com/apache/cloudstack/pull/2211#issuecomment-350644278
 
 
   Mohammad Aladwan  on d...@cloudstack.apache.org replies:
   hi,
   
   please i want to leave this group,i am not sure how i  can leave it
   
   
   my best regards


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch debian9-systemvmtemplate updated: more fixes

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch debian9-systemvmtemplate
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/debian9-systemvmtemplate by 
this push:
 new 507f732  more fixes
507f732 is described below

commit 507f732ed9571bf6d5ccc5d7efbc21fc05920257
Author: Rohit Yadav 
AuthorDate: Mon Dec 11 16:48:01 2017 +0530

more fixes

Signed-off-by: Rohit Yadav 
---
 systemvm/debian/opt/cloud/bin/update_config.py   | 7 ---
 test/integration/smoke/test_templates.py | 4 ++--
 tools/appliance/definitions/systemvmtemplate/preseed.cfg | 4 ++--
 3 files changed, 4 insertions(+), 11 deletions(-)

diff --git a/systemvm/debian/opt/cloud/bin/update_config.py 
b/systemvm/debian/opt/cloud/bin/update_config.py
index a603f47..7b86378 100755
--- a/systemvm/debian/opt/cloud/bin/update_config.py
+++ b/systemvm/debian/opt/cloud/bin/update_config.py
@@ -39,13 +39,6 @@ jsonFilename = sys.argv[1]
 jsonConfigFile = jsonPath % jsonFilename
 currentGuestNetConfig = "/etc/cloudstack/guestnetwork.json"
 
-# If the command line json file is unprocessed process it
-# This is important or, the control interfaces will get deleted!
-if os.path.isfile(jsonPath % "cmd_line.json"):
-qf = QueueFile()
-qf.setFile("cmd_line.json")
-qf.load(None)
-
 
 def finish_config():
 # Converge
diff --git a/test/integration/smoke/test_templates.py 
b/test/integration/smoke/test_templates.py
index 955fe6e..6544ad2 100644
--- a/test/integration/smoke/test_templates.py
+++ b/test/integration/smoke/test_templates.py
@@ -158,7 +158,6 @@ class TestCreateTemplateWithChecksum(cloudstackTestCase):
 cmd.id = temp.id
 cmd.zoneid = self.zone.id
 self.apiclient.deleteTemplate(cmd)
-
 except Exception as e:
 raise Exception("Warning: Exception during cleanup : %s" % e)
 return
@@ -227,7 +226,8 @@ class TestCreateTemplateWithChecksum(cloudstackTestCase):
 
 def registerTemplate(self, cmd):
 temp = self.apiclient.registerTemplate(cmd)[0]
-self.cleanup.append(temp)
+if not temp:
+self.cleanup.append(temp)
 return temp
 
 def getOsType(self, param):
diff --git a/tools/appliance/definitions/systemvmtemplate/preseed.cfg 
b/tools/appliance/definitions/systemvmtemplate/preseed.cfg
index 7fbe2a1..9f8d988 100644
--- a/tools/appliance/definitions/systemvmtemplate/preseed.cfg
+++ b/tools/appliance/definitions/systemvmtemplate/preseed.cfg
@@ -57,7 +57,7 @@ d-i partman-auto/method string regular
 d-i partman-auto/choose_recipe select atomic
 d-i partman-auto/expert_recipe string \
   boot-root ::\
-  100 50 100 ext2 \
+  50 50 100 ext2  \
   $primary{ } $bootable{ }\
   method{ format } format{ }  \
   use_filesystem{ } filesystem{ ext2 }\
@@ -73,7 +73,7 @@ d-i partman-auto/expert_recipe string 
\
   use_filesystem{ } filesystem{ ext4 }\
   mountpoint{ /var/log }  \
   .   \
-  50 100 200 linux-swap   \
+  100 100 200 linux-swap  \
   method{ swap } format{ }\
   .
 

-- 
To stop receiving notification emails like this one, please contact
['"commits@cloudstack.apache.org" '].

[GitHub] niteshsarda commented on a change in pull request #2354: CLOUDSTACK-10176:VM Start Api Job returns success for failed Job

[GitBox]

niteshsarda commented on a change in pull request #2354: CLOUDSTACK-10176:VM 
Start Api Job returns success for failed Job
URL: https://github.com/apache/cloudstack/pull/2354#discussion_r156034674
 
 

 ##
 File path: engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java
 ##
 @@ -4731,7 +4732,8 @@ protected VirtualMachine retrieve() {
 }
 catch (CloudRuntimeException e){
 s_logger.info("Caught CloudRuntimeException, returning job 
failed");
-return new Pair(JobInfo.Status.FAILED, 
null);
+CloudRuntimeException ex = new CloudRuntimeException("Unable to 
start VM instance : " + e);
+return new Pair(JobInfo.Status.FAILED, 
JobSerializerHelper.toObjectSerializedString(ex));
 
 Review comment:
   @rhtyd : If you are fine with the fix then, can you please merge this PR?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfbot commented on issue #2204: [CLOUDSTACK-10025] Adding Support for NoVNC Console for KVM and XENSERVER

[GitBox]

asfbot commented on issue #2204: [CLOUDSTACK-10025] Adding Support for NoVNC 
Console for KVM and XENSERVER
URL: https://github.com/apache/cloudstack/pull/2204#issuecomment-350661280
 
 
   Sigert GOEMINNE  on d...@cloudstack.apache.org replies:
   Hi,
   
   Send an email to dev-unsubscr...@cloudstack.apache.org to unsubscribe from
   the mailing list. (https://cloudstack.apache.org/mailing-lists.html)
   
   Kind regards,
   Sigert
   
   *Sigert Goeminne*
   Software Development Engineer
   
   *nuage*networks.net 
   Copernicuslaan 50
   2018 Antwerp
   Belgium


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] bwsw commented on issue #2355: CLOUDSTACK-10177: Only pass IPv6 address to Security Group Python scr?

[GitBox]

bwsw commented on issue #2355: CLOUDSTACK-10177: Only pass IPv6 address to 
Security Group Python scr?
URL: https://github.com/apache/cloudstack/pull/2355#issuecomment-350651070
 
 
   @wido Great!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfbot commented on issue #2204: [CLOUDSTACK-10025] Adding Support for NoVNC Console for KVM and XENSERVER

[GitBox]

asfbot commented on issue #2204: [CLOUDSTACK-10025] Adding Support for NoVNC 
Console for KVM and XENSERVER
URL: https://github.com/apache/cloudstack/pull/2204#issuecomment-350650334
 
 
   Mohammad Aladwan  on d...@cloudstack.apache.org replies:
   hi,
   
   please i want to leave this group,i am not sure how i  can leave it
   
   
   my best regards


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services