[GitHub] borisstoyanov commented on issue #2301: CLOUDSTACK-10121 moveUser

[GitBox]

borisstoyanov commented on issue #2301: CLOUDSTACK-10121 moveUser
URL: https://github.com/apache/cloudstack/pull/2301#issuecomment-354411785
 
 
   Same error here @DaanHoogland "NameError: global name 'get_template' is not 
defined\n" 
   Looks like this run didn't picked up your latest changes.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2146: CLOUDSTACK-4757: Support OVA files with multiple disks for templates

[GitBox]

borisstoyanov commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-354410643
 
 
   @rhtyd @nvazquez, I've manually executed the multi disk templates tests and 
they're looking good, also resolved the conflicts and will re-run the VMware 
tests, hopefully they'll look better now.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2146: CLOUDSTACK-4757: Support OVA files with multiple disks for templates

[GitBox]

borisstoyanov commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-354410346
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2146: CLOUDSTACK-4757: Support OVA files with multiple disks for templates

[GitBox]

blueorangutan commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-354410361
 
 
   @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] yvsubhash commented on issue #1940: CLOUDSTACK-9781:ACS records ID in events tables instead of UUID.

[GitBox]

yvsubhash commented on issue #1940: CLOUDSTACK-9781:ACS records ID in events 
tables instead of UUID.
URL: https://github.com/apache/cloudstack/pull/1940#issuecomment-354396471
 
 
   thanks @DaanHoogland 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2301: CLOUDSTACK-10121 moveUser

[GitBox]

blueorangutan commented on issue #2301: CLOUDSTACK-10121 moveUser
URL: https://github.com/apache/cloudstack/pull/2301#issuecomment-354389264
 
 
   Trillian test result (tid-1941)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 40609 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2301-t1941-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_accounts.py
   Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 64 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   ContextSuite context=TestMoveUser>:setup | `Error` | 268.31 | 
test_accounts.py
   test_07_resize_fail | `Failure` | 15.39 | test_volumes.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2369: CLOUDSTACK-10117 Domain level ldap configuration

[GitBox]

blueorangutan commented on issue #2369: CLOUDSTACK-10117 Domain level ldap 
configuration
URL: https://github.com/apache/cloudstack/pull/2369#issuecomment-354375895
 
 
   Trillian test result (tid-1942)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 30430 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2369-t1942-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Smoke tests completed. 65 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_redundant_VPC_default_routes | `Failure` | 886.86 | 
test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Failure` | 340.99 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Error` | 386.63 | test_vpc_redundant.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2368: CLOUDSTACK-10126: Separate Subnet for SSVM and CPVM

[GitBox]

blueorangutan commented on issue #2368: CLOUDSTACK-10126: Separate Subnet for 
SSVM and CPVM
URL: https://github.com/apache/cloudstack/pull/2368#issuecomment-354369020
 
 
   Trillian test result (tid-1939)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 40798 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2368-t1939-kvm-centos7.zip
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 65 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 263.21 | 
test_privategw_acl.py
   test_04_rvpc_privategw_static_routes | `Failure` | 551.59 | 
test_privategw_acl.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2156: CLOUDSTACK-9971: Bugfix/listaccounts parameter consistency

[GitBox]

blueorangutan commented on issue #2156: CLOUDSTACK-9971: Bugfix/listaccounts 
parameter consistency
URL: https://github.com/apache/cloudstack/pull/2156#issuecomment-354366983
 
 
   Trillian test result (tid-1940)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 36986 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2156-t1940-kvm-centos7.zip
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
   Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 65 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_hostha_kvm_host_fencing | `Error` | 656.03 | test_hostha_kvm.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2378: CLOUDSTACK-10205 make LinkDomainToLdap return UUID instead of internal id

[GitBox]

blueorangutan commented on issue #2378: CLOUDSTACK-10205 make LinkDomainToLdap 
return UUID instead of internal id
URL: https://github.com/apache/cloudstack/pull/2378#issuecomment-354353577
 
 
   Trillian test result (tid-1938)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 35673 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2378-t1938-kvm-centos7.zip
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 65 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_hostha_kvm_host_fencing | `Error` | 639.73 | test_hostha_kvm.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2073: CLOUDSTACK-9896: API: listDedicatedXXX should respect pagination

[GitBox]

blueorangutan commented on issue #2073: CLOUDSTACK-9896: API: listDedicatedXXX 
should respect pagination
URL: https://github.com/apache/cloudstack/pull/2073#issuecomment-354349993
 
 
   Trillian test result (tid-1937)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 34358 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2073-t1937-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_accounts.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_affinity_groups_projects.py
   Intermitten failure detected: /marvin/tests/smoke/test_affinity_groups.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 63 look OK, 3 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   ContextSuite context=TestAccounts>:setup | `Error` | 0.00 | test_accounts.py
   ContextSuite context=TestAddVmToSubDomain>:setup | `Error` | 0.00 | 
test_accounts.py
   test_DeleteDomain | `Error` | 1.59 | test_accounts.py
   test_forceDeleteDomain | `Error` | 1.62 | test_accounts.py
   ContextSuite context=TestRemoveUserFromAccount>:setup | `Error` | 22.09 | 
test_accounts.py
   ContextSuite context=TestDeployVmWithAffinityGroup>:setup | `Error` | 0.00 | 
test_affinity_groups_projects.py
   ContextSuite context=TestDeployVmWithAffinityGroup>:setup | `Error` | 0.00 | 
test_affinity_groups.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2282: CLOUDSTACK-10104:Optimize database transactions in ListDomain API to improve performance

[GitBox]

blueorangutan commented on issue #2282: CLOUDSTACK-10104:Optimize database 
transactions in ListDomain API to improve performance
URL: https://github.com/apache/cloudstack/pull/2282#issuecomment-354341852
 
 
   Trillian test result (tid-1936)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 32835 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2282-t1936-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 65 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_hostha_kvm_host_fencing | `Error` | 658.64 | test_hostha_kvm.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on issue #1940: CLOUDSTACK-9781:ACS records ID in events tables instead of UUID.

[GitBox]

DaanHoogland commented on issue #1940: CLOUDSTACK-9781:ACS records ID in events 
tables instead of UUID.
URL: https://github.com/apache/cloudstack/pull/1940#issuecomment-354308156
 
 
   @yvsubhash @rhtyd some peiople might run into issues but i think we should 
go ahead. (please have a look at my #2378 where I make a similar change. I 
think exposing an internal id is a bug in any case, beit a domain id or a 
region or whatever.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2369: CLOUDSTACK-10117 Domain level ldap configuration

[GitBox]

blueorangutan commented on issue #2369: CLOUDSTACK-10117 Domain level ldap 
configuration
URL: https://github.com/apache/cloudstack/pull/2369#issuecomment-354303971
 
 
   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on issue #2369: CLOUDSTACK-10117 Domain level ldap configuration

[GitBox]

DaanHoogland commented on issue #2369: CLOUDSTACK-10117 Domain level ldap 
configuration
URL: https://github.com/apache/cloudstack/pull/2369#issuecomment-354303889
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on issue #2301: CLOUDSTACK-10121 moveUser

[GitBox]

DaanHoogland commented on issue #2301: CLOUDSTACK-10121 moveUser
URL: https://github.com/apache/cloudstack/pull/2301#issuecomment-354303759
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2301: CLOUDSTACK-10121 moveUser

[GitBox]

blueorangutan commented on issue #2301: CLOUDSTACK-10121 moveUser
URL: https://github.com/apache/cloudstack/pull/2301#issuecomment-354303816
 
 
   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nvazquez commented on issue #2368: CLOUDSTACK-10126: Separate Subnet for SSVM and CPVM

[GitBox]

nvazquez commented on issue #2368: CLOUDSTACK-10126: Separate Subnet for SSVM 
and CPVM
URL: https://github.com/apache/cloudstack/pull/2368#issuecomment-354300819
 
 
   Pushed fix and rebased, we should repeat test after this round finishes


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2369: CLOUDSTACK-10117 Domain level ldap configuration

[GitBox]

blueorangutan commented on issue #2369: CLOUDSTACK-10117 Domain level ldap 
configuration
URL: https://github.com/apache/cloudstack/pull/2369#issuecomment-354296782
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1523


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2301: CLOUDSTACK-10121 moveUser

[GitBox]

blueorangutan commented on issue #2301: CLOUDSTACK-10121 moveUser
URL: https://github.com/apache/cloudstack/pull/2301#issuecomment-354296784
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1524


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2301: CLOUDSTACK-10121 moveUser

[GitBox]

blueorangutan commented on issue #2301: CLOUDSTACK-10121 moveUser
URL: https://github.com/apache/cloudstack/pull/2301#issuecomment-354291800
 
 
   @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on issue #2301: CLOUDSTACK-10121 moveUser

[GitBox]

DaanHoogland commented on issue #2301: CLOUDSTACK-10121 moveUser
URL: https://github.com/apache/cloudstack/pull/2301#issuecomment-354291695
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2369: CLOUDSTACK-10117 Domain level ldap configuration

[GitBox]

blueorangutan commented on issue #2369: CLOUDSTACK-10117 Domain level ldap 
configuration
URL: https://github.com/apache/cloudstack/pull/2369#issuecomment-354291657
 
 
   @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on issue #2369: CLOUDSTACK-10117 Domain level ldap configuration

[GitBox]

DaanHoogland commented on issue #2369: CLOUDSTACK-10117 Domain level ldap 
configuration
URL: https://github.com/apache/cloudstack/pull/2369#issuecomment-354291503
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] krissterckx commented on a change in pull request #2374: CLOUDSTACK-10024: Network Migration: Tackle review comments

[GitBox]

krissterckx commented on a change in pull request #2374: CLOUDSTACK-10024: 
Network Migration: Tackle review comments
URL: https://github.com/apache/cloudstack/pull/2374#discussion_r158944104
 
 

 ##
 File path: tools/marvin/marvin/config/test_data.py
 ##
 @@ -419,8 +419,8 @@
 "displaytext": "MySharedOffering",
 "guestiptype": "Shared",
 "supportedservices": "Dhcp,Dns,UserData",
-"specifyVlan": "True",
-"specifyIpRanges": "True",
+"specifyVlan": "False",
 
 Review comment:
   @rhtyd this change is exactly the revert you asked for. I think we shd merge 
in this PR as your comment was legitimate.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2344: CLOUDSTACK-10163: Component tests sanity

[GitBox]

borisstoyanov commented on issue #2344: CLOUDSTACK-10163: Component tests sanity
URL: https://github.com/apache/cloudstack/pull/2344#issuecomment-354283458
 
 
   Thanks @nvazquez I've addressed your comments, @rhtyd I think we're in a 
good position to merge now, lets address the new failures in separate PRs.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2344: CLOUDSTACK-10163: Component tests sanity

[GitBox]

borisstoyanov commented on issue #2344: CLOUDSTACK-10163: Component tests sanity
URL: https://github.com/apache/cloudstack/pull/2344#issuecomment-354283458
 
 
   Thanks @nvazquez, @rhtyd I think we're in a good position to merge now, lets 
address the new failures in separate PRs.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nvazquez commented on a change in pull request #2344: CLOUDSTACK-10163: Component tests sanity

[GitBox]

nvazquez commented on a change in pull request #2344: CLOUDSTACK-10163: 
Component tests sanity
URL: https://github.com/apache/cloudstack/pull/2344#discussion_r158935974
 
 

 ##
 File path: test/integration/component/test_VirtualRouter_alerts.py
 ##
 @@ -47,6 +47,7 @@ def setUpClass(cls):
 cls).getClsTestClient()
 cls.api_client = cls.testClient.getApiClient()
 cls.services = cls.testClient.getParsedTestDataConfig()
+cls.hostConfig = 
cls.config.__dict__["zones"][0].__dict__["pods"][0].__dict__["clusters"][0].__dict__["hosts"][0].__dict__
 
 Review comment:
   Ok, sorry, copy that. Please ignore similar comments, thanks


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2156: CLOUDSTACK-9971: Bugfix/listaccounts parameter consistency

[GitBox]

blueorangutan commented on issue #2156: CLOUDSTACK-9971: Bugfix/listaccounts 
parameter consistency
URL: https://github.com/apache/cloudstack/pull/2156#issuecomment-354278312
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nvazquez commented on a change in pull request #2344: CLOUDSTACK-10163: Component tests sanity

[GitBox]

nvazquez commented on a change in pull request #2344: CLOUDSTACK-10163: 
Component tests sanity
URL: https://github.com/apache/cloudstack/pull/2344#discussion_r158934771
 
 

 ##
 File path: test/integration/component/test_volumes.py
 ##
 @@ -123,17 +67,17 @@ def setUpClass(cls):
 return
 cls.disk_offering = DiskOffering.create(
 cls.api_client,
-cls.services["disk_offering"]
+cls.testdata["disk_offering"]
 )
 cls._cleanup.append(cls.disk_offering)
-template = get_template(
+cls.template = get_template(
 cls.api_client,
 cls.zone.id,
-cls.services["ostype"]
+cls.testdata["ostype"]
 )
-cls.services["zoneid"] = cls.zone.id
-cls.services["virtual_machine"]["zoneid"] = cls.zone.id
-cls.services["virtual_machine"]["template"] = template.id
+#cls.testdata["zoneid"] = cls.zone.id
 
 Review comment:
   Multiple commented lines


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2156: CLOUDSTACK-9971: Bugfix/listaccounts parameter consistency

[GitBox]

rhtyd commented on issue #2156: CLOUDSTACK-9971: Bugfix/listaccounts parameter 
consistency
URL: https://github.com/apache/cloudstack/pull/2156#issuecomment-354278258
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2156: CLOUDSTACK-9971: Bugfix/listaccounts parameter consistency

[GitBox]

blueorangutan commented on issue #2156: CLOUDSTACK-9971: Bugfix/listaccounts 
parameter consistency
URL: https://github.com/apache/cloudstack/pull/2156#issuecomment-354278009
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1521


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nvazquez commented on a change in pull request #2344: CLOUDSTACK-10163: Component tests sanity

[GitBox]

nvazquez commented on a change in pull request #2344: CLOUDSTACK-10163: 
Component tests sanity
URL: https://github.com/apache/cloudstack/pull/2344#discussion_r158934414
 
 

 ##
 File path: test/integration/component/test_overcommit.py
 ##
 @@ -99,8 +100,9 @@ def setUpClass(cls):
 cls.domain = get_domain(cls.apiclient)
 cls.zone = get_zone(cls.apiclient)
 cls.testdata["mode"] = cls.zone.networktype
-cls.testdata["configurableData"]["password"] = "xenroot"
+#cls.testdata["configurableData"]["password"] = "xenroot"
 
 Review comment:
   Can we remove this commented line?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2058: CLOUDSTACK-9888: Duplicate usage while processing usage events

[GitBox]

blueorangutan commented on issue #2058: CLOUDSTACK-9888: Duplicate usage while 
processing usage events 
URL: https://github.com/apache/cloudstack/pull/2058#issuecomment-354278008
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1522


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nvazquez commented on a change in pull request #2344: CLOUDSTACK-10163: Component tests sanity

[GitBox]

nvazquez commented on a change in pull request #2344: CLOUDSTACK-10163: 
Component tests sanity
URL: https://github.com/apache/cloudstack/pull/2344#discussion_r158934387
 
 

 ##
 File path: test/integration/component/test_overcommit.py
 ##
 @@ -99,8 +100,9 @@ def setUpClass(cls):
 cls.domain = get_domain(cls.apiclient)
 cls.zone = get_zone(cls.apiclient)
 cls.testdata["mode"] = cls.zone.networktype
-cls.testdata["configurableData"]["password"] = "xenroot"
+#cls.testdata["configurableData"]["password"] = "xenroot"
 cls.hypervisor = testClient.getHypervisorInfo()
+cls.hostConfig = 
cls.config.__dict__["zones"][0].__dict__["pods"][0].__dict__["clusters"][0].__dict__["hosts"][0].__dict__
 
 Review comment:
   Same here


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nvazquez commented on a change in pull request #2344: CLOUDSTACK-10163: Component tests sanity

[GitBox]

nvazquez commented on a change in pull request #2344: CLOUDSTACK-10163: 
Component tests sanity
URL: https://github.com/apache/cloudstack/pull/2344#discussion_r158934319
 
 

 ##
 File path: test/integration/component/test_host_ha.py
 ##
 @@ -45,6 +45,8 @@ def setUp(self):
 self.services = self.testClient.getParsedTestDataConfig()
 self.zone = get_zone(self.apiclient, self.testClient.getZoneForTests())
 self.pod = get_pod(self.apiclient, self.zone.id)
+self.hostConfig = 
self.config.__dict__["zones"][0].__dict__["pods"][0].__dict__["clusters"][0].__dict__["hosts"][0].__dict__
 
 Review comment:
   Same here


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2376: [4.11/master] Smoketest Health Check

[GitBox]

blueorangutan commented on issue #2376: [4.11/master] Smoketest Health Check
URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-35421
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1519


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #1740: CLOUDSTACK-9572 Snapshot on primary storage not cleaned up after Stor?

[GitBox]

blueorangutan commented on issue #1740: CLOUDSTACK-9572 Snapshot on primary 
storage not cleaned up after Stor?
URL: https://github.com/apache/cloudstack/pull/1740#issuecomment-354277793
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1520


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nvazquez commented on a change in pull request #2344: CLOUDSTACK-10163: Component tests sanity

[GitBox]

nvazquez commented on a change in pull request #2344: CLOUDSTACK-10163: 
Component tests sanity
URL: https://github.com/apache/cloudstack/pull/2344#discussion_r158934256
 
 

 ##
 File path: test/integration/component/test_escalations_routers.py
 ##
 @@ -46,6 +46,7 @@ def setUpClass(cls):
 cls).getClsTestClient()
 cls.api_client = cls.testClient.getApiClient()
 cls.services = cls.testClient.getParsedTestDataConfig()
+cls.hostConfig = 
cls.config.__dict__["zones"][0].__dict__["pods"][0].__dict__["clusters"][0].__dict__["hosts"][0].__dict__
 
 Review comment:
   Same question here


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2374: CLOUDSTACK-10024: Network Migration: Tackle review comments

[GitBox]

blueorangutan commented on issue #2374: CLOUDSTACK-10024: Network Migration: 
Tackle review comments
URL: https://github.com/apache/cloudstack/pull/2374#issuecomment-35422
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1518


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on a change in pull request #2344: CLOUDSTACK-10163: Component tests sanity

[GitBox]

borisstoyanov commented on a change in pull request #2344: CLOUDSTACK-10163: 
Component tests sanity
URL: https://github.com/apache/cloudstack/pull/2344#discussion_r158934104
 
 

 ##
 File path: test/integration/component/test_VirtualRouter_alerts.py
 ##
 @@ -47,6 +47,7 @@ def setUpClass(cls):
 cls).getClsTestClient()
 cls.api_client = cls.testClient.getApiClient()
 cls.services = cls.testClient.getParsedTestDataConfig()
+cls.hostConfig = 
cls.config.__dict__["zones"][0].__dict__["pods"][0].__dict__["clusters"][0].__dict__["hosts"][0].__dict__
 
 Review comment:
   This is a configuration, not a test data which we consider as 'services'. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nvazquez commented on a change in pull request #2344: CLOUDSTACK-10163: Component tests sanity

[GitBox]

nvazquez commented on a change in pull request #2344: CLOUDSTACK-10163: 
Component tests sanity
URL: https://github.com/apache/cloudstack/pull/2344#discussion_r158933656
 
 

 ##
 File path: test/integration/component/test_VirtualRouter_alerts.py
 ##
 @@ -47,6 +47,7 @@ def setUpClass(cls):
 cls).getClsTestClient()
 cls.api_client = cls.testClient.getApiClient()
 cls.services = cls.testClient.getParsedTestDataConfig()
+cls.hostConfig = 
cls.config.__dict__["zones"][0].__dict__["pods"][0].__dict__["clusters"][0].__dict__["hosts"][0].__dict__
 
 Review comment:
   Is `cls.config` set here or should it be `cls.services?` Can we add basic 
check for each dictionary key?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nvazquez commented on a change in pull request #2344: CLOUDSTACK-10163: Component tests sanity

[GitBox]

nvazquez commented on a change in pull request #2344: CLOUDSTACK-10163: 
Component tests sanity
URL: https://github.com/apache/cloudstack/pull/2344#discussion_r158933656
 
 

 ##
 File path: test/integration/component/test_VirtualRouter_alerts.py
 ##
 @@ -47,6 +47,7 @@ def setUpClass(cls):
 cls).getClsTestClient()
 cls.api_client = cls.testClient.getApiClient()
 cls.services = cls.testClient.getParsedTestDataConfig()
+cls.hostConfig = 
cls.config.__dict__["zones"][0].__dict__["pods"][0].__dict__["clusters"][0].__dict__["hosts"][0].__dict__
 
 Review comment:
   Is `cls.config` set here or should it be `cls.services`? Can we add basic 
check for each dictionary key?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #1499: Undetected bug correct and refactor of the class NfsSecondaryStorageResource

[GitBox]

blueorangutan commented on issue #1499: Undetected bug correct and refactor of 
the class NfsSecondaryStorageResource
URL: https://github.com/apache/cloudstack/pull/1499#issuecomment-354276985
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1517


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] fmaximus commented on a change in pull request #2374: CLOUDSTACK-10024: Network Migration: Tackle review comments

[GitBox]

fmaximus commented on a change in pull request #2374: CLOUDSTACK-10024: Network 
Migration: Tackle review comments
URL: https://github.com/apache/cloudstack/pull/2374#discussion_r158933487
 
 

 ##
 File path: tools/marvin/marvin/config/test_data.py
 ##
 @@ -419,8 +419,8 @@
 "displaytext": "MySharedOffering",
 "guestiptype": "Shared",
 "supportedservices": "Dhcp,Dns,UserData",
-"specifyVlan": "True",
-"specifyIpRanges": "True",
+"specifyVlan": "False",
 
 Review comment:
   This *is* the revert of test data, done in PR #2259


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2373: CLOUDSTACK-10202:createSnapshotPolicy API create multiple entries in DB for same volume.

[GitBox]

blueorangutan commented on issue #2373: CLOUDSTACK-10202:createSnapshotPolicy 
API create multiple entries in DB for same volume.
URL: https://github.com/apache/cloudstack/pull/2373#issuecomment-354276702
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1516


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2377: CLOUDSTACK-10207: updateVpnCustomerGateway: fix defaulting for option?

[GitBox]

blueorangutan commented on issue #2377: CLOUDSTACK-10207: 
updateVpnCustomerGateway: fix defaulting for option?
URL: https://github.com/apache/cloudstack/pull/2377#issuecomment-354275570
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1515


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #1773: CLOUDSTACK-9607: Preventing template deletion when template is in use.

[GitBox]

blueorangutan commented on issue #1773: CLOUDSTACK-9607: Preventing template 
deletion when template is in use.
URL: https://github.com/apache/cloudstack/pull/1773#issuecomment-354274885
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1514


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2149: CLOUDSTACK-9932 snapshot is getting deleted while volume is in creating state

[GitBox]

blueorangutan commented on issue #2149: CLOUDSTACK-9932 snapshot is getting 
deleted while volume is in creating state
URL: https://github.com/apache/cloudstack/pull/2149#issuecomment-354274039
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1513


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2344: CLOUDSTACK-10163: Component tests sanity

[GitBox]

borisstoyanov commented on issue #2344: CLOUDSTACK-10163: Component tests sanity
URL: https://github.com/apache/cloudstack/pull/2344#issuecomment-354273994
 
 
   Many of these are issues that are not fixed yet, others may be regressions, 
but the failure number is down to 41 from ~100
   ping @PaulAngus @DaanHoogland @nvazquez for review and lgtm. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #1604: improvement: systemvm slow operations

[GitBox]

rhtyd commented on issue #1604: improvement: systemvm slow operations
URL: https://github.com/apache/cloudstack/pull/1604#issuecomment-354270128
 
 
   @romain-dartigues @dpassante any update on this?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #1355: Refactor test_vpc_vpn, add test for multiple VPNs

[GitBox]

rhtyd commented on issue #1355: Refactor test_vpc_vpn, add test for multiple 
VPNs
URL: https://github.com/apache/cloudstack/pull/1355#issuecomment-354269877
 
 
   @bheuvel is this still relevant as there have been several change in code, 
can you rebase and update on the changes/status?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2058: CLOUDSTACK-9888: Duplicate usage while processing usage events

[GitBox]

blueorangutan commented on issue #2058: CLOUDSTACK-9888: Duplicate usage while 
processing usage events 
URL: https://github.com/apache/cloudstack/pull/2058#issuecomment-354269776
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2058: CLOUDSTACK-9888: Duplicate usage while processing usage events

[GitBox]

rhtyd commented on issue #2058: CLOUDSTACK-9888: Duplicate usage while 
processing usage events 
URL: https://github.com/apache/cloudstack/pull/2058#issuecomment-354269675
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2073: CLOUDSTACK-9896: API: listDedicatedXXX should respect pagination

[GitBox]

rhtyd commented on issue #2073: CLOUDSTACK-9896: API: listDedicatedXXX should 
respect pagination
URL: https://github.com/apache/cloudstack/pull/2073#issuecomment-354269610
 
 
   Additional review requested on this PR.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2116: CLOUDSTACK-8959: Option to attach the config drive

[GitBox]

rhtyd commented on issue #2116: CLOUDSTACK-8959: Option to attach the config 
drive
URL: https://github.com/apache/cloudstack/pull/2116#issuecomment-354269510
 
 
   Ping @jayapalu 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2156: CLOUDSTACK-9971: Bugfix/listaccounts parameter consistency

[GitBox]

blueorangutan commented on issue #2156: CLOUDSTACK-9971: Bugfix/listaccounts 
parameter consistency
URL: https://github.com/apache/cloudstack/pull/2156#issuecomment-354269539
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2156: CLOUDSTACK-9971: Bugfix/listaccounts parameter consistency

[GitBox]

rhtyd commented on issue #2156: CLOUDSTACK-9971: Bugfix/listaccounts parameter 
consistency
URL: https://github.com/apache/cloudstack/pull/2156#issuecomment-354269438
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #1740: CLOUDSTACK-9572 Snapshot on primary storage not cleaned up after Stor?

[GitBox]

blueorangutan commented on issue #1740: CLOUDSTACK-9572 Snapshot on primary 
storage not cleaned up after Stor?
URL: https://github.com/apache/cloudstack/pull/1740#issuecomment-354268718
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #1740: CLOUDSTACK-9572 Snapshot on primary storage not cleaned up after Stor?

[GitBox]

rhtyd commented on issue #1740: CLOUDSTACK-9572 Snapshot on primary storage not 
cleaned up after Stor?
URL: https://github.com/apache/cloudstack/pull/1740#issuecomment-354268627
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2376: [4.11/master] Smoketest Health Check

[GitBox]

blueorangutan commented on issue #2376: [4.11/master] Smoketest Health Check
URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-354268212
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2376: [4.11/master] Smoketest Health Check

[GitBox]

rhtyd commented on issue #2376: [4.11/master] Smoketest Health Check
URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-354268139
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2378: CLOUDSTACK-10205 make LinkDomainToLdap return UUID instead of internal id

[GitBox]

blueorangutan commented on issue #2378: CLOUDSTACK-10205 make LinkDomainToLdap 
return UUID instead of internal id
URL: https://github.com/apache/cloudstack/pull/2378#issuecomment-354267065
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2073: CLOUDSTACK-9896: API: listDedicatedXXX should respect pagination

[GitBox]

blueorangutan commented on issue #2073: CLOUDSTACK-9896: API: listDedicatedXXX 
should respect pagination
URL: https://github.com/apache/cloudstack/pull/2073#issuecomment-354266929
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2073: CLOUDSTACK-9896: API: listDedicatedXXX should respect pagination

[GitBox]

rhtyd commented on issue #2073: CLOUDSTACK-9896: API: listDedicatedXXX should 
respect pagination
URL: https://github.com/apache/cloudstack/pull/2073#issuecomment-354266917
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2378: CLOUDSTACK-10205 make LinkDomainToLdap return UUID instead of internal id

[GitBox]

rhtyd commented on issue #2378: CLOUDSTACK-10205 make LinkDomainToLdap return 
UUID instead of internal id
URL: https://github.com/apache/cloudstack/pull/2378#issuecomment-354266931
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2073: CLOUDSTACK-9896: API: listDedicatedXXX should respect pagination

[GitBox]

blueorangutan commented on issue #2073: CLOUDSTACK-9896: API: listDedicatedXXX 
should respect pagination
URL: https://github.com/apache/cloudstack/pull/2073#issuecomment-354266297
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1512


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2374: CLOUDSTACK-10024: Network Migration: Tackle review comments

[GitBox]

rhtyd commented on a change in pull request #2374: CLOUDSTACK-10024: Network 
Migration: Tackle review comments
URL: https://github.com/apache/cloudstack/pull/2374#discussion_r158924899
 
 

 ##
 File path: tools/marvin/marvin/config/test_data.py
 ##
 @@ -419,8 +419,8 @@
 "displaytext": "MySharedOffering",
 "guestiptype": "Shared",
 "supportedservices": "Dhcp,Dns,UserData",
-"specifyVlan": "True",
-"specifyIpRanges": "True",
+"specifyVlan": "False",
 
 Review comment:
   @fmaximus This test data is in use by several test cases, changing the 
values from 'true' to 'false' may cause regressions. Can you change them back, 
and in your tests perhaps change the value to False if necessary?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2378: CLOUDSTACK-10205 make LinkDomainToLdap return UUID instead of internal id

[GitBox]

blueorangutan commented on issue #2378: CLOUDSTACK-10205 make LinkDomainToLdap 
return UUID instead of internal id
URL: https://github.com/apache/cloudstack/pull/2378#issuecomment-354265926
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1511


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2374: CLOUDSTACK-10024: Network Migration: Tackle review comments

[GitBox]

blueorangutan commented on issue #2374: CLOUDSTACK-10024: Network Migration: 
Tackle review comments
URL: https://github.com/apache/cloudstack/pull/2374#issuecomment-354265566
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2374: CLOUDSTACK-10024: Network Migration: Tackle review comments

[GitBox]

rhtyd commented on issue #2374: CLOUDSTACK-10024: Network Migration: Tackle 
review comments
URL: https://github.com/apache/cloudstack/pull/2374#issuecomment-354265497
 
 
   Thanks @fmaximus Trillian uses it's own test_data. I'll move your test data 
changes to 
https://github.com/shapeblue/Trillian/blob/master/Ansible/roles/marvin/templates/test_data.py.j2
 before running the next test round. It is advisable to include test data with 
the test and leave merging changes to the marvin test_data.
   
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #1499: Undetected bug correct and refactor of the class NfsSecondaryStorageResource

[GitBox]

blueorangutan commented on issue #1499: Undetected bug correct and refactor of 
the class NfsSecondaryStorageResource
URL: https://github.com/apache/cloudstack/pull/1499#issuecomment-354265246
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #1499: Undetected bug correct and refactor of the class NfsSecondaryStorageResource

[GitBox]

rhtyd commented on issue #1499: Undetected bug correct and refactor of the 
class NfsSecondaryStorageResource
URL: https://github.com/apache/cloudstack/pull/1499#issuecomment-354265148
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd closed pull request #1554: CLOUDSTACK-9602: API: improve resource limits comprehension

[GitBox]

rhtyd closed pull request #1554: CLOUDSTACK-9602: API: improve resource limits 
comprehension
URL: https://github.com/apache/cloudstack/pull/1554
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/api/src/com/cloud/configuration/Resource.java 
b/api/src/com/cloud/configuration/Resource.java
index 5550e29eca4..7ef1b0bb90e 100644
--- a/api/src/com/cloud/configuration/Resource.java
+++ b/api/src/com/cloud/configuration/Resource.java
@@ -71,6 +71,15 @@ public boolean supportsOwner(ResourceOwnerType ownerType) {
 public int getOrdinal() {
 return ordinal;
 }
+
+public static ResourceType fromOrdinal(int ordinal) {
+for (ResourceType r : ResourceType.values()) {
+if (r.ordinal == ordinal) {
+return r;
+}
+}
+return null;
+}
 }
 
 public static class ResourceOwnerType {
diff --git a/api/src/com/cloud/user/ResourceLimitService.java 
b/api/src/com/cloud/user/ResourceLimitService.java
index fef16da942f..8e9f2c2de89 100644
--- a/api/src/com/cloud/user/ResourceLimitService.java
+++ b/api/src/com/cloud/user/ResourceLimitService.java
@@ -64,11 +64,11 @@
  *TODO
  * @param domainId
  *TODO
- * @param type
+ * @param resourceType
  *TODO
  * @return a list of limits that match the criteria
  */
-public List searchForLimits(Long id, Long 
accountId, Long domainId, Integer type, Long startIndex, Long pageSizeVal);
+public List searchForLimits(Long id, Long 
accountId, Long domainId, ResourceType resourceType, Long startIndex, Long 
pageSizeVal);
 
 /**
  * Finds the resource limit for a specified account and type. If the 
account has an infinite limit, will check
diff --git a/api/src/org/apache/cloudstack/api/ApiConstants.java 
b/api/src/org/apache/cloudstack/api/ApiConstants.java
index 1d0b4a3756a..df6f86c9352 100644
--- a/api/src/org/apache/cloudstack/api/ApiConstants.java
+++ b/api/src/org/apache/cloudstack/api/ApiConstants.java
@@ -216,6 +216,7 @@
 public static final String RECEIVED_BYTES = "receivedbytes";
 public static final String REQUIRES_HVM = "requireshvm";
 public static final String RESOURCE_TYPE = "resourcetype";
+public static final String RESOURCE_TYPE_NAME = "resourcetypename";
 public static final String RESPONSE = "response";
 public static final String REVERTABLE = "revertable";
 public static final String REGISTERED = "registered";
diff --git 
a/api/src/org/apache/cloudstack/api/command/user/resource/ListResourceLimitsCmd.java
 
b/api/src/org/apache/cloudstack/api/command/user/resource/ListResourceLimitsCmd.java
index 14d1d55ff8b..68c09c27fb0 100644
--- 
a/api/src/org/apache/cloudstack/api/command/user/resource/ListResourceLimitsCmd.java
+++ 
b/api/src/org/apache/cloudstack/api/command/user/resource/ListResourceLimitsCmd.java
@@ -19,6 +19,8 @@
 import java.util.ArrayList;
 import java.util.List;
 
+import com.cloud.configuration.Resource;
+import com.cloud.exception.InvalidParameterValueException;
 import org.apache.cloudstack.api.APICommand;
 import org.apache.cloudstack.api.ApiConstants;
 import org.apache.cloudstack.api.BaseListProjectAndAccountResourcesCmd;
@@ -58,6 +60,21 @@
 + "11 - SecondaryStorage. Total secondary storage space (in GiB) a 
user can use. ")
 private Integer resourceType;
 
+@Parameter(name = ApiConstants.RESOURCE_TYPE_NAME, type = 
CommandType.STRING, description = "Type of resource (wins over resourceType if 
both are provided). Values are: "
++ "user_vm - Instance. Number of instances a user can create. "
++ "public_ip - IP. Number of public IP addresses an account can 
own. "
++ "volume - Volume. Number of disk volumes an account can own. "
++ "snapshot - Snapshot. Number of snapshots an account can own. "
++ "template - Template. Number of templates an account can 
register/create. "
++ "project - Project. Number of projects an account can own. "
++ "network - Network. Number of networks an account can own. "
++ "vpc - VPC. Number of VPC an account can own. "
++ "cpu - CPU. Number of CPU an account can allocate for his 
resources. "
++ "memory - Memory. Amount of RAM an account can allocate for his 
resources. "
++ "primary_storage - PrimaryStorage. Total primary storage space 
(in GiB) a user can use. "
++ "secondary_storage - SecondaryStorage. Total secondary storage 
space (in GiB) a user can use. ")
+private String resourceTypeName;
+
 /
 /// Accessors 

[cloudstack] branch master updated: CLOUDSTACK-9602: Improve resource limits comprehension in listResources (#1554)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/master by this push:
 new e27b3e1  CLOUDSTACK-9602: Improve resource limits comprehension in 
listResources (#1554)
e27b3e1 is described below

commit e27b3e120dbf8c61d6db5e8a97604817c3a82c4c
Author: Marc-Aurèle Brothier 
AuthorDate: Thu Dec 28 11:16:24 2017 +0100

CLOUDSTACK-9602: Improve resource limits comprehension in listResources 
(#1554)

Add resource type name in request and response for listResources API call.
This adds in the response a new attribute typename with the String value 
for the corresponding resource enum.

{
  "capacitytotal": 0,
  "capacityused": 0,
  "percentused": "0",
  "type": 19,
  "typename": "gpu",
  "zoneid": "381d0a95-ed4a-4ad9-b41c-b97073c1a433",
  "zonename": "ch-dk-2"
}

Signed-off-by: Marc-Aurèle Brothier 
---
 api/src/com/cloud/configuration/Resource.java  |  9 +
 api/src/com/cloud/user/ResourceLimitService.java   |  4 +--
 .../org/apache/cloudstack/api/ApiConstants.java|  1 +
 .../user/resource/ListResourceLimitsCmd.java   | 42 +-
 .../api/response/ResourceCountResponse.java| 10 --
 .../api/response/ResourceLimitResponse.java| 10 --
 server/src/com/cloud/api/ApiResponseHelper.java|  4 +--
 .../resourcelimit/ResourceLimitManagerImpl.java| 12 +--
 .../cloud/vpc/MockResourceLimitManagerImpl.java|  4 +--
 9 files changed, 74 insertions(+), 22 deletions(-)

diff --git a/api/src/com/cloud/configuration/Resource.java 
b/api/src/com/cloud/configuration/Resource.java
index 5550e29..7ef1b0b 100644
--- a/api/src/com/cloud/configuration/Resource.java
+++ b/api/src/com/cloud/configuration/Resource.java
@@ -71,6 +71,15 @@ public interface Resource {
 public int getOrdinal() {
 return ordinal;
 }
+
+public static ResourceType fromOrdinal(int ordinal) {
+for (ResourceType r : ResourceType.values()) {
+if (r.ordinal == ordinal) {
+return r;
+}
+}
+return null;
+}
 }
 
 public static class ResourceOwnerType {
diff --git a/api/src/com/cloud/user/ResourceLimitService.java 
b/api/src/com/cloud/user/ResourceLimitService.java
index 0ec2dc1..901fa06 100644
--- a/api/src/com/cloud/user/ResourceLimitService.java
+++ b/api/src/com/cloud/user/ResourceLimitService.java
@@ -68,11 +68,11 @@ public interface ResourceLimitService {
  *TODO
  * @param domainId
  *TODO
- * @param type
+ * @param resourceType
  *TODO
  * @return a list of limits that match the criteria
  */
-public List searchForLimits(Long id, Long 
accountId, Long domainId, Integer type, Long startIndex, Long pageSizeVal);
+public List searchForLimits(Long id, Long 
accountId, Long domainId, ResourceType resourceType, Long startIndex, Long 
pageSizeVal);
 
 /**
  * Finds the resource limit for a specified account and type. If the 
account has an infinite limit, will check
diff --git a/api/src/org/apache/cloudstack/api/ApiConstants.java 
b/api/src/org/apache/cloudstack/api/ApiConstants.java
index 24099c4..0e275b5 100644
--- a/api/src/org/apache/cloudstack/api/ApiConstants.java
+++ b/api/src/org/apache/cloudstack/api/ApiConstants.java
@@ -243,6 +243,7 @@ public class ApiConstants {
 public static final String RECOVER = "recover";
 public static final String REQUIRES_HVM = "requireshvm";
 public static final String RESOURCE_TYPE = "resourcetype";
+public static final String RESOURCE_TYPE_NAME = "resourcetypename";
 public static final String RESPONSE = "response";
 public static final String REVERTABLE = "revertable";
 public static final String REGISTERED = "registered";
diff --git 
a/api/src/org/apache/cloudstack/api/command/user/resource/ListResourceLimitsCmd.java
 
b/api/src/org/apache/cloudstack/api/command/user/resource/ListResourceLimitsCmd.java
index 14d1d55..68c09c2 100644
--- 
a/api/src/org/apache/cloudstack/api/command/user/resource/ListResourceLimitsCmd.java
+++ 
b/api/src/org/apache/cloudstack/api/command/user/resource/ListResourceLimitsCmd.java
@@ -19,6 +19,8 @@ package org.apache.cloudstack.api.command.user.resource;
 import java.util.ArrayList;
 import java.util.List;
 
+import com.cloud.configuration.Resource;
+import com.cloud.exception.InvalidParameterValueException;
 import org.apache.cloudstack.api.APICommand;
 import org.apache.cloudstack.api.ApiConstants;
 import org.apache.cloudstack.api.BaseListProjectAndAccountResourcesCmd;
@@ -58,6 +60,21 @@ public class ListResourceLimitsCmd extends 
BaseListProjectAndAccountResourcesCmd

[GitHub] rhtyd commented on issue #1554: CLOUDSTACK-9602: API: improve resource limits comprehension

[GitBox]

rhtyd commented on issue #1554: CLOUDSTACK-9602: API: improve resource limits 
comprehension
URL: https://github.com/apache/cloudstack/pull/1554#issuecomment-354264825
 
 
   Thanks. Merging this based on 2lgtm/code reviews and test results.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2046: CLOUDSTACK-7958: Add configuration for limit to CIDRs for Admin API calls

[GitBox]

rhtyd commented on issue #2046: CLOUDSTACK-7958: Add configuration for limit to 
CIDRs for Admin API calls
URL: https://github.com/apache/cloudstack/pull/2046#issuecomment-354264728
 
 
   Sure, ping me @wido


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2373: CLOUDSTACK-10202:createSnapshotPolicy API create multiple entries in DB for same volume.

[GitBox]

blueorangutan commented on issue #2373: CLOUDSTACK-10202:createSnapshotPolicy 
API create multiple entries in DB for same volume.
URL: https://github.com/apache/cloudstack/pull/2373#issuecomment-354263854
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2373: CLOUDSTACK-10202:createSnapshotPolicy API create multiple entries in DB for same volume.

[GitBox]

rhtyd commented on issue #2373: CLOUDSTACK-10202:createSnapshotPolicy API 
create multiple entries in DB for same volume.
URL: https://github.com/apache/cloudstack/pull/2373#issuecomment-354263715
 
 
   Re-kick as commit was pushed after last pkg build run
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2282: CLOUDSTACK-10104:Optimize database transactions in ListDomain API to improve performance

[GitBox]

rhtyd commented on issue #2282: CLOUDSTACK-10104:Optimize database transactions 
in ListDomain API to improve performance
URL: https://github.com/apache/cloudstack/pull/2282#issuecomment-354263667
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2282: CLOUDSTACK-10104:Optimize database transactions in ListDomain API to improve performance

[GitBox]

blueorangutan commented on issue #2282: CLOUDSTACK-10104:Optimize database 
transactions in ListDomain API to improve performance
URL: https://github.com/apache/cloudstack/pull/2282#issuecomment-354263723
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2373: CLOUDSTACK-10202:createSnapshotPolicy API create multiple entries in DB for same volume.

[GitBox]

blueorangutan commented on issue #2373: CLOUDSTACK-10202:createSnapshotPolicy 
API create multiple entries in DB for same volume.
URL: https://github.com/apache/cloudstack/pull/2373#issuecomment-354263550
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1510


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2377: CLOUDSTACK-10207: updateVpnCustomerGateway: fix defaulting for option?

[GitBox]

blueorangutan commented on issue #2377: CLOUDSTACK-10207: 
updateVpnCustomerGateway: fix defaulting for option?
URL: https://github.com/apache/cloudstack/pull/2377#issuecomment-354263462
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2377: CLOUDSTACK-10207: updateVpnCustomerGateway: fix defaulting for option?

[GitBox]

rhtyd commented on issue #2377: CLOUDSTACK-10207: updateVpnCustomerGateway: fix 
defaulting for option?
URL: https://github.com/apache/cloudstack/pull/2377#issuecomment-354263441
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on issue #2378: CLOUDSTACK-10205 make LinkDomainToLdap return UUID instead of internal id

[GitBox]

DaanHoogland commented on issue #2378: CLOUDSTACK-10205 make LinkDomainToLdap 
return UUID instead of internal id
URL: https://github.com/apache/cloudstack/pull/2378#issuecomment-35426
 
 
   @rhtyd I changed the title back. it describes the situation as it is 
implemented not as it was (that is more a title of an issue reported)
   litle improvement added


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] resmo commented on issue #2377: CLOUDSTACK-10207: updateVpnCustomerGateway: fix defaulting for option?

[GitBox]

resmo commented on issue #2377: CLOUDSTACK-10207: updateVpnCustomerGateway: fix 
defaulting for option?
URL: https://github.com/apache/cloudstack/pull/2377#issuecomment-354262749
 
 
   @rhtyd yes, please :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #1278: CLOUDSTACK-9198: Virtual router gets deployed in disabled Pod

[GitBox]

rhtyd commented on issue #1278: CLOUDSTACK-9198: Virtual router gets deployed 
in disabled Pod
URL: https://github.com/apache/cloudstack/pull/1278#issuecomment-354262674
 
 
   @anshul-gangwar please address outstanding issues, and questions.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2320: CLOUDSTACK-10178: Hotfixes to make 4.10 work

[GitBox]

rhtyd commented on issue #2320: CLOUDSTACK-10178: Hotfixes to make 4.10 work
URL: https://github.com/apache/cloudstack/pull/2320#issuecomment-354262477
 
 
   Any update on this, ping?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] niteshsarda commented on issue #2373: CLOUDSTACK-10202:createSnapshotPolicy API create multiple entries in DB for same volume.

[GitBox]

niteshsarda commented on issue #2373: CLOUDSTACK-10202:createSnapshotPolicy API 
create multiple entries in DB for same volume.
URL: https://github.com/apache/cloudstack/pull/2373#issuecomment-354262520
 
 
   @rhtyd : Thank you.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch master updated: CLOUDSTACK-9593: userdata: enforce data is a multiple of 4 characters (#1760)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/master by this push:
 new a26a502  CLOUDSTACK-9593: userdata: enforce data is a multiple of 4 
characters (#1760)
a26a502 is described below

commit a26a5023458b8b95779409fb231ad12badacc8a8
Author: Marc-Aurèle Brothier 
AuthorDate: Thu Dec 28 10:57:33 2017 +0100

CLOUDSTACK-9593: userdata: enforce data is a multiple of 4 characters 
(#1760)

Python base64 requires that the string is a multiple of 4 characters but
the Apache codec does not. RFC states is not mandatory so the data should
not fail the VR script (vmdata.py).

Signed-off-by: Marc-Aurèle Brothier 
Signed-off-by: Rohit Yadav 
---
 .../com/cloud/upgrade/dao/Upgrade41000to41100.java | 41 ++
 server/src/com/cloud/vm/UserVmManagerImpl.java |  9 +++--
 server/test/com/cloud/vm/UserVmManagerTest.java| 13 +++
 3 files changed, 60 insertions(+), 3 deletions(-)

diff --git a/engine/schema/src/com/cloud/upgrade/dao/Upgrade41000to41100.java 
b/engine/schema/src/com/cloud/upgrade/dao/Upgrade41000to41100.java
index fbe9d78..6afd976 100644
--- a/engine/schema/src/com/cloud/upgrade/dao/Upgrade41000to41100.java
+++ b/engine/schema/src/com/cloud/upgrade/dao/Upgrade41000to41100.java
@@ -27,6 +27,7 @@ import java.util.HashSet;
 import java.util.Map;
 import java.util.Set;
 
+import org.apache.commons.codec.binary.Base64;
 import org.apache.log4j.Logger;
 
 import com.cloud.hypervisor.Hypervisor;
@@ -64,9 +65,49 @@ public class Upgrade41000to41100 implements DbUpgrade {
 
 @Override
 public void performDataMigration(Connection conn) {
+validateUserDataInBase64(conn);
 updateSystemVmTemplates(conn);
 }
 
+private void validateUserDataInBase64(Connection conn) {
+try (final PreparedStatement selectStatement = 
conn.prepareStatement("SELECT `id`, `user_data` FROM `cloud`.`user_vm` WHERE 
`user_data` IS NOT NULL;");
+ final ResultSet selectResultSet = selectStatement.executeQuery()) 
{
+while (selectResultSet.next()) {
+final Long userVmId = selectResultSet.getLong(1);
+final String userData = selectResultSet.getString(2);
+if (Base64.isBase64(userData)) {
+final String newUserData = 
Base64.encodeBase64String(Base64.decodeBase64(userData.getBytes()));
+if (!userData.equals(newUserData)) {
+try (final PreparedStatement updateStatement = 
conn.prepareStatement("UPDATE `cloud`.`user_vm` SET `user_data` = ? WHERE `id` 
= ? ;")) {
+updateStatement.setString(1, newUserData);
+updateStatement.setLong(2, userVmId);
+updateStatement.executeUpdate();
+} catch (SQLException e) {
+LOG.error("Failed to update cloud.user_vm 
user_data for id:" + userVmId + " with exception: " + e.getMessage());
+throw new CloudRuntimeException("Exception while 
updating cloud.user_vm for id " + userVmId, e);
+}
+}
+} else {
+// Update to NULL since it's invalid
+LOG.warn("Removing user_data for vm id " + userVmId + " 
because it's invalid");
+LOG.warn("Removed data was: " + userData);
+try (final PreparedStatement updateStatement = 
conn.prepareStatement("UPDATE `cloud`.`user_vm` SET `user_data` = NULL WHERE 
`id` = ? ;")) {
+updateStatement.setLong(1, userVmId);
+updateStatement.executeUpdate();
+} catch (SQLException e) {
+LOG.error("Failed to update cloud.user_vm user_data 
for id:" + userVmId + " to NULL with exception: " + e.getMessage());
+throw new CloudRuntimeException("Exception while 
updating cloud.user_vm for id " + userVmId + " to NULL", e);
+}
+}
+}
+} catch (SQLException e) {
+throw new CloudRuntimeException("Exception while validating 
existing user_vm table's user_data column to be base64 valid with padding", e);
+}
+if (LOG.isDebugEnabled()) {
+LOG.debug("Done validating base64 content of user data");
+}
+}
+
 @SuppressWarnings("serial")
 private void updateSystemVmTemplates(final Connection conn) {
 LOG.debug("Updating System Vm template IDs");
diff --git a/server/src/com/cloud/vm/UserVmManagerImpl.java 
b/server/src/com/cloud/vm/UserVmManagerImpl.java
index c4edf4f..72c4793 100644
--- 

[GitHub] DaanHoogland commented on issue #2378: CLOUDSTACK-10205 LinkDomainToLdap return UUID instead of internal id

[GitBox]

DaanHoogland commented on issue #2378: CLOUDSTACK-10205 LinkDomainToLdap return 
UUID instead of internal id
URL: https://github.com/apache/cloudstack/pull/2378#issuecomment-35426
 
 
   @rhtyd I changed the title back. it describes the situation as it is 
implemented not as it was (that is more a title of an issue reported)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #1773: CLOUDSTACK-9607: Preventing template deletion when template is in use.

[GitBox]

blueorangutan commented on issue #1773: CLOUDSTACK-9607: Preventing template 
deletion when template is in use.
URL: https://github.com/apache/cloudstack/pull/1773#issuecomment-354262259
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd closed pull request #1760: CLOUDSTACK-9593: userdata: enforce data is a multiple of 4 characters

[GitBox]

rhtyd closed pull request #1760: CLOUDSTACK-9593: userdata: enforce data is a 
multiple of 4 characters
URL: https://github.com/apache/cloudstack/pull/1760
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/engine/schema/src/com/cloud/upgrade/dao/Upgrade41000to41100.java 
b/engine/schema/src/com/cloud/upgrade/dao/Upgrade41000to41100.java
index fbe9d784432..6afd976e7e2 100644
--- a/engine/schema/src/com/cloud/upgrade/dao/Upgrade41000to41100.java
+++ b/engine/schema/src/com/cloud/upgrade/dao/Upgrade41000to41100.java
@@ -27,6 +27,7 @@
 import java.util.Map;
 import java.util.Set;
 
+import org.apache.commons.codec.binary.Base64;
 import org.apache.log4j.Logger;
 
 import com.cloud.hypervisor.Hypervisor;
@@ -64,9 +65,49 @@ public boolean supportsRollingUpgrade() {
 
 @Override
 public void performDataMigration(Connection conn) {
+validateUserDataInBase64(conn);
 updateSystemVmTemplates(conn);
 }
 
+private void validateUserDataInBase64(Connection conn) {
+try (final PreparedStatement selectStatement = 
conn.prepareStatement("SELECT `id`, `user_data` FROM `cloud`.`user_vm` WHERE 
`user_data` IS NOT NULL;");
+ final ResultSet selectResultSet = selectStatement.executeQuery()) 
{
+while (selectResultSet.next()) {
+final Long userVmId = selectResultSet.getLong(1);
+final String userData = selectResultSet.getString(2);
+if (Base64.isBase64(userData)) {
+final String newUserData = 
Base64.encodeBase64String(Base64.decodeBase64(userData.getBytes()));
+if (!userData.equals(newUserData)) {
+try (final PreparedStatement updateStatement = 
conn.prepareStatement("UPDATE `cloud`.`user_vm` SET `user_data` = ? WHERE `id` 
= ? ;")) {
+updateStatement.setString(1, newUserData);
+updateStatement.setLong(2, userVmId);
+updateStatement.executeUpdate();
+} catch (SQLException e) {
+LOG.error("Failed to update cloud.user_vm 
user_data for id:" + userVmId + " with exception: " + e.getMessage());
+throw new CloudRuntimeException("Exception while 
updating cloud.user_vm for id " + userVmId, e);
+}
+}
+} else {
+// Update to NULL since it's invalid
+LOG.warn("Removing user_data for vm id " + userVmId + " 
because it's invalid");
+LOG.warn("Removed data was: " + userData);
+try (final PreparedStatement updateStatement = 
conn.prepareStatement("UPDATE `cloud`.`user_vm` SET `user_data` = NULL WHERE 
`id` = ? ;")) {
+updateStatement.setLong(1, userVmId);
+updateStatement.executeUpdate();
+} catch (SQLException e) {
+LOG.error("Failed to update cloud.user_vm user_data 
for id:" + userVmId + " to NULL with exception: " + e.getMessage());
+throw new CloudRuntimeException("Exception while 
updating cloud.user_vm for id " + userVmId + " to NULL", e);
+}
+}
+}
+} catch (SQLException e) {
+throw new CloudRuntimeException("Exception while validating 
existing user_vm table's user_data column to be base64 valid with padding", e);
+}
+if (LOG.isDebugEnabled()) {
+LOG.debug("Done validating base64 content of user data");
+}
+}
+
 @SuppressWarnings("serial")
 private void updateSystemVmTemplates(final Connection conn) {
 LOG.debug("Updating System Vm template IDs");
diff --git a/server/src/com/cloud/vm/UserVmManagerImpl.java 
b/server/src/com/cloud/vm/UserVmManagerImpl.java
index 3591e603b0a..cd725b1b6ab 100644
--- a/server/src/com/cloud/vm/UserVmManagerImpl.java
+++ b/server/src/com/cloud/vm/UserVmManagerImpl.java
@@ -2525,7 +2525,7 @@ public UserVm updateVirtualMachine(long id, String 
displayName, String group, Bo
 if (userData != null) {
 // check and replace newlines
 userData = userData.replace("\\n", "");
-validateUserData(userData, httpMethod);
+userData = validateUserData(userData, httpMethod);
 // update userData on domain router.
 updateUserdata = true;
 } else {
@@ -3395,7 +3395,7 @@ protected UserVm createVirtualMachine(DataCenter zone, 
ServiceOffering serviceOf
 _accountMgr.checkAccess(owner, AccessType.UseEntry, false, template);
 
 // check if the user data is correct
-

[GitHub] rhtyd commented on issue #1760: CLOUDSTACK-9593: userdata: enforce data is a multiple of 4 characters

[GitBox]

rhtyd commented on issue #1760: CLOUDSTACK-9593: userdata: enforce data is a 
multiple of 4 characters
URL: https://github.com/apache/cloudstack/pull/1760#issuecomment-354262246
 
 
   Merging this based on two lgtms and test results (ignoring env related 
Trillian failures).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2149: CLOUDSTACK-9932 snapshot is getting deleted while volume is in creating state

[GitBox]

blueorangutan commented on issue #2149: CLOUDSTACK-9932 snapshot is getting 
deleted while volume is in creating state
URL: https://github.com/apache/cloudstack/pull/2149#issuecomment-354262121
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #1773: CLOUDSTACK-9607: Preventing template deletion when template is in use.

[GitBox]

rhtyd commented on issue #1773: CLOUDSTACK-9607: Preventing template deletion 
when template is in use.
URL: https://github.com/apache/cloudstack/pull/1773#issuecomment-354262107
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2149: CLOUDSTACK-9932 snapshot is getting deleted while volume is in creating state

[GitBox]

rhtyd commented on issue #2149: CLOUDSTACK-9932 snapshot is getting deleted 
while volume is in creating state
URL: https://github.com/apache/cloudstack/pull/2149#issuecomment-354262069
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2282: CLOUDSTACK-10104:Optimize database transactions in ListDomain API to improve performance

[GitBox]

blueorangutan commented on issue #2282: CLOUDSTACK-10104:Optimize database 
transactions in ListDomain API to improve performance
URL: https://github.com/apache/cloudstack/pull/2282#issuecomment-354261853
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1509


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #1940: CLOUDSTACK-9781:ACS records ID in events tables instead of UUID.

[GitBox]

rhtyd commented on issue #1940: CLOUDSTACK-9781:ACS records ID in events tables 
instead of UUID.
URL: https://github.com/apache/cloudstack/pull/1940#issuecomment-354261150
 
 
   @DaanHoogland @syed I'll wait for few days for your response. I don't see 
any blockers with the change, ~~and may merge next week~~. Most crms, billing 
tools would consume (raw/processed) usage data from usage related tables and 
not events, my understanding is events are only used largely for auditing and 
tracking purposes.
   
   I'll started a discussion on users@ and dev@ on this. Let's wait till end of 
next week if this is really a blocker. Thanks.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #1940: CLOUDSTACK-9781:ACS records ID in events tables instead of UUID.

[GitBox]

rhtyd commented on issue #1940: CLOUDSTACK-9781:ACS records ID in events tables 
instead of UUID.
URL: https://github.com/apache/cloudstack/pull/1940#issuecomment-354261150
 
 
   @DaanHoogland @syed I'll wait for few days for your response. I don't see 
any blockers with the change, and may merge next week. Most crms, billing tools 
would consume (raw/processed) usage data from usage related tables and not 
events, my understanding is events are only used largely for auditing and 
tracking purposes. Thanks.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services