[GitHub] ustcweizhou commented on a change in pull request #2452: CLOUDSTACK-10285: Fix db upgrade failure for 4.10.0.0 users

[GitBox]

ustcweizhou commented on a change in pull request #2452: CLOUDSTACK-10285: Fix 
db upgrade failure for 4.10.0.0 users
URL: https://github.com/apache/cloudstack/pull/2452#discussion_r167781635
 
 

 ##
 File path: engine/schema/resources/META-INF/db/schema-41000to41100.sql
 ##
 @@ -546,3 +546,24 @@ ALTER TABLE cloud.ldap_trust_map ADD COLUMN account_id 
BIGINT(20) DEFAULT 0;
 ALTER TABLE cloud.ldap_trust_map DROP FOREIGN KEY fk_ldap_trust_map__domain_id;
 DROP INDEX uk_ldap_trust_map__domain_id ON cloud.ldap_trust_map;
 CREATE UNIQUE INDEX uk_ldap_trust_map__bind_location ON ldap_trust_map 
(domain_id, account_id);
+
+CREATE TABLE IF NOT EXISTS `cloud`.`netscaler_servicepackages` (
+  `id` bigint unsigned NOT NULL AUTO_INCREMENT COMMENT 'id',
+  `uuid` varchar(255) UNIQUE,
+  `name` varchar(255) UNIQUE COMMENT 'name of the service package',
+  `description` varchar(255) COMMENT 'description of the service package',
+  PRIMARY KEY  (`id`)
+) ENGINE=InnoDB DEFAULT CHARSET=utf8;
+
+CREATE TABLE IF NOT EXISTS `cloud`.`external_netscaler_controlcenter` (
+  `id` bigint unsigned NOT NULL AUTO_INCREMENT COMMENT 'id',
+  `uuid` varchar(255) UNIQUE,
+  `username` varchar(255) COMMENT 'username of the NCC',
+  `password` varchar(255) COMMENT 'password of NCC',
+  `ncc_ip` varchar(255) COMMENT 'IP of NCC Manager',
+  `num_retries` bigint unsigned NOT NULL default 2 COMMENT 'Number of retries 
in ncc for command failure',
+  PRIMARY KEY  (`id`)
+) ENGINE=InnoDB DEFAULT CHARSET=utf8;
+
+ALTER TABLE `cloud`.`sslcerts` ADD COLUMN `name` varchar(255) NULL default 
NULL COMMENT 'Name of the Certificate';
 
 Review comment:
   @rhtyd thanks for your explanation. 
   LGTM now.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] niteshsarda commented on issue #2451: CLOUDSTACK-10284:Creating a snapshot from VM Snapshot generates error if hypervisor is not KVM.

[GitBox]

niteshsarda commented on issue #2451: CLOUDSTACK-10284:Creating a snapshot from 
VM Snapshot generates error if hypervisor is not KVM.
URL: https://github.com/apache/cloudstack/pull/2451#issuecomment-365164038
 
 
   @ustcweizhou : I have address your second issue in latest code, but could 
not understand first point. Can you please provide more clarification around 
first issue ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2452: CLOUDSTACK-10285: Fix db upgrade failure for 4.10.0.0 users

[GitBox]

blueorangutan commented on issue #2452: CLOUDSTACK-10285: Fix db upgrade 
failure for 4.10.0.0 users
URL: https://github.com/apache/cloudstack/pull/2452#issuecomment-365082774
 
 
   Trillian test result (tid-2254)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 23691 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2452-t2254-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 65 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_04_rvpc_privategw_static_routes | `Failure` | 277.99 | 
test_privategw_acl.py
   test_hostha_enable_ha_when_host_in_maintenance | `Error` | 3.43 | 
test_hostha_kvm.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nvazquez opened a new pull request #2423: CLOUDSTACK-10250: Reinstall VM from bypassed registered template

[GitBox]

nvazquez opened a new pull request #2423: CLOUDSTACK-10250: Reinstall VM from 
bypassed registered template
URL: https://github.com/apache/cloudstack/pull/2423
 
 
   JIRA Ticket: https://issues.apache.org/jira/browse/CLOUDSTACK-10250
   
   This fix allows users to restore a VM from a previously registered template 
using the Direct Download option (only for KVM currently)
   
   NOTE: As Reinstall VM button prompts only featured templates, to be able to 
restore a vm to a Direct Download template, it should be registered as Featured


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland closed pull request #2423: CLOUDSTACK-10250: Reinstall VM from bypassed registered template

[GitBox]

DaanHoogland closed pull request #2423: CLOUDSTACK-10250: Reinstall VM from 
bypassed registered template
URL: https://github.com/apache/cloudstack/pull/2423
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/server/src/com/cloud/vm/UserVmManagerImpl.java 
b/server/src/com/cloud/vm/UserVmManagerImpl.java
index dab741c3c27..a5bfc47584d 100644
--- a/server/src/com/cloud/vm/UserVmManagerImpl.java
+++ b/server/src/com/cloud/vm/UserVmManagerImpl.java
@@ -313,6 +313,7 @@
 import com.cloud.vm.snapshot.VMSnapshotVO;
 import com.cloud.vm.snapshot.dao.VMSnapshotDao;
 import com.cloud.storage.snapshot.SnapshotApiService;
+import com.cloud.storage.VMTemplateStorageResourceAssoc;
 
 public class UserVmManagerImpl extends ManagerBase implements UserVmManager, 
VirtualMachineGuru, UserVmService, Configurable {
 private static final Logger s_logger = 
Logger.getLogger(UserVmManagerImpl.class);
@@ -6100,10 +6101,8 @@ public UserVm restoreVMInternal(Account caller, UserVmVO 
vm, Long newTemplateId)
 throw ex;
 }
 }
-TemplateDataStoreVO tmplStore = 
_templateStoreDao.findByTemplateZoneReady(template.getId(), 
vm.getDataCenterId());
-if (tmplStore == null) {
-throw new InvalidParameterValueException("Cannot restore the 
vm as the template " + template.getUuid() + " isn't available in the zone");
-}
+
+checkRestoreVmFromTemplate(vm, template);
 
 if (needRestart) {
 try {
@@ -6217,6 +6216,27 @@ public UserVm restoreVMInternal(Account caller, UserVmVO 
vm, Long newTemplateId)
 
 }
 
+/**
+ * Perform basic checkings to make sure restore is possible. If not, 
#InvalidParameterValueException is thrown
+ * @param vm vm
+ * @param template template
+ * @throws InvalidParameterValueException if restore is not possible
+ */
+private void checkRestoreVmFromTemplate(UserVmVO vm, VMTemplateVO 
template) {
+TemplateDataStoreVO tmplStore;
+if (!template.isDirectDownload()) {
+tmplStore = 
_templateStoreDao.findByTemplateZoneReady(template.getId(), 
vm.getDataCenterId());
+if (tmplStore == null) {
+throw new InvalidParameterValueException("Cannot restore the 
vm as the template " + template.getUuid() + " isn't available in the zone");
+}
+} else {
+tmplStore = _templateStoreDao.findByTemplate(template.getId(), 
DataStoreRole.Image);
+if (tmplStore == null || (tmplStore != null && 
!tmplStore.getDownloadState().equals(VMTemplateStorageResourceAssoc.Status.BYPASSED)))
 {
+throw new InvalidParameterValueException("Cannot restore the 
vm as the bypassed template " + template.getUuid() + " isn't available in the 
zone");
+}
+}
+}
+
 private void handleManagedStorage(UserVmVO vm, VolumeVO root) {
 if (Volume.State.Allocated.equals(root.getState())) {
 return;


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on issue #2442: CLOUDSTACK-10147 Disabled Xenserver Cluster can still deploy VM's

[GitBox]

DaanHoogland commented on issue #2442: CLOUDSTACK-10147 Disabled Xenserver 
Cluster can still deploy VM's
URL: https://github.com/apache/cloudstack/pull/2442#issuecomment-365043745
 
 
   @houthuis did you ask the submitter (of CLOUDSTACK-10147) about the validity 
of the functionality?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nvazquez opened a new pull request #2423: CLOUDSTACK-10250: Reinstall VM from bypassed registered template

[GitBox]

nvazquez opened a new pull request #2423: CLOUDSTACK-10250: Reinstall VM from 
bypassed registered template
URL: https://github.com/apache/cloudstack/pull/2423
 
 
   JIRA Ticket: https://issues.apache.org/jira/browse/CLOUDSTACK-10250
   
   This fix allows users to restore a VM from a previously registered template 
using the Direct Download option (only for KVM currently)
   
   NOTE: As Reinstall VM button prompts only featured templates, to be able to 
restore a vm to a Direct Download template, it should be registered as Featured


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland closed pull request #2423: CLOUDSTACK-10250: Reinstall VM from bypassed registered template

[GitBox]

DaanHoogland closed pull request #2423: CLOUDSTACK-10250: Reinstall VM from 
bypassed registered template
URL: https://github.com/apache/cloudstack/pull/2423
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/server/src/com/cloud/vm/UserVmManagerImpl.java 
b/server/src/com/cloud/vm/UserVmManagerImpl.java
index dab741c3c27..a5bfc47584d 100644
--- a/server/src/com/cloud/vm/UserVmManagerImpl.java
+++ b/server/src/com/cloud/vm/UserVmManagerImpl.java
@@ -313,6 +313,7 @@
 import com.cloud.vm.snapshot.VMSnapshotVO;
 import com.cloud.vm.snapshot.dao.VMSnapshotDao;
 import com.cloud.storage.snapshot.SnapshotApiService;
+import com.cloud.storage.VMTemplateStorageResourceAssoc;
 
 public class UserVmManagerImpl extends ManagerBase implements UserVmManager, 
VirtualMachineGuru, UserVmService, Configurable {
 private static final Logger s_logger = 
Logger.getLogger(UserVmManagerImpl.class);
@@ -6100,10 +6101,8 @@ public UserVm restoreVMInternal(Account caller, UserVmVO 
vm, Long newTemplateId)
 throw ex;
 }
 }
-TemplateDataStoreVO tmplStore = 
_templateStoreDao.findByTemplateZoneReady(template.getId(), 
vm.getDataCenterId());
-if (tmplStore == null) {
-throw new InvalidParameterValueException("Cannot restore the 
vm as the template " + template.getUuid() + " isn't available in the zone");
-}
+
+checkRestoreVmFromTemplate(vm, template);
 
 if (needRestart) {
 try {
@@ -6217,6 +6216,27 @@ public UserVm restoreVMInternal(Account caller, UserVmVO 
vm, Long newTemplateId)
 
 }
 
+/**
+ * Perform basic checkings to make sure restore is possible. If not, 
#InvalidParameterValueException is thrown
+ * @param vm vm
+ * @param template template
+ * @throws InvalidParameterValueException if restore is not possible
+ */
+private void checkRestoreVmFromTemplate(UserVmVO vm, VMTemplateVO 
template) {
+TemplateDataStoreVO tmplStore;
+if (!template.isDirectDownload()) {
+tmplStore = 
_templateStoreDao.findByTemplateZoneReady(template.getId(), 
vm.getDataCenterId());
+if (tmplStore == null) {
+throw new InvalidParameterValueException("Cannot restore the 
vm as the template " + template.getUuid() + " isn't available in the zone");
+}
+} else {
+tmplStore = _templateStoreDao.findByTemplate(template.getId(), 
DataStoreRole.Image);
+if (tmplStore == null || (tmplStore != null && 
!tmplStore.getDownloadState().equals(VMTemplateStorageResourceAssoc.Status.BYPASSED)))
 {
+throw new InvalidParameterValueException("Cannot restore the 
vm as the bypassed template " + template.getUuid() + " isn't available in the 
zone");
+}
+}
+}
+
 private void handleManagedStorage(UserVmVO vm, VolumeVO root) {
 if (Volume.State.Allocated.equals(root.getState())) {
 return;


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on issue #2446: CLOUDSTACK-10271 maven plugin for owasp dependency check added

[GitBox]

DaanHoogland commented on issue #2446: CLOUDSTACK-10271 maven plugin for owasp 
dependency check added
URL: https://github.com/apache/cloudstack/pull/2446#issuecomment-365042857
 
 
   @marcaurele are you -1 on this chance as is?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2442: CLOUDSTACK-10147 Disabled Xenserver Cluster can still deploy VM's

[GitBox]

blueorangutan commented on issue #2442: CLOUDSTACK-10147 Disabled Xenserver 
Cluster can still deploy VM's
URL: https://github.com/apache/cloudstack/pull/2442#issuecomment-365032026
 
 
   Trillian test result (tid-2252)
   Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 36354 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2442-t2252-xenserver-65sp1.zip
   Intermitten failure detected: /marvin/tests/smoke/test_vm_snapshots.py
   Smoke tests completed. 67 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2423: CLOUDSTACK-10250: Reinstall VM from bypassed registered template

[GitBox]

blueorangutan commented on issue #2423: CLOUDSTACK-10250: Reinstall VM from 
bypassed registered template
URL: https://github.com/apache/cloudstack/pull/2423#issuecomment-364999878
 
 
   Trillian test result (tid-2253)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 30836 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2423-t2253-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 65 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 3.55 | 
test_host_maintenance.py
   test_hostha_enable_ha_when_host_in_maintenance | `Error` | 1.85 | 
test_hostha_kvm.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2446: CLOUDSTACK-10271 maven plugin for owasp dependency check added

[GitBox]

blueorangutan commented on issue #2446: CLOUDSTACK-10271 maven plugin for owasp 
dependency check added
URL: https://github.com/apache/cloudstack/pull/2446#issuecomment-364996703
 
 
   Trillian test result (tid-2251)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 30372 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2446-t2251-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 66 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_hostha_enable_ha_when_host_in_maintenance | `Error` | 0.83 | 
test_hostha_kvm.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2204: [CLOUDSTACK-10025] Adding Support for NoVNC Console for KVM and XENSERVER

[GitBox]

rhtyd commented on issue #2204: [CLOUDSTACK-10025] Adding Support for NoVNC 
Console for KVM and XENSERVER
URL: https://github.com/apache/cloudstack/pull/2204#issuecomment-364967523
 
 
   @syed great, happy to collaborate you've my support. Perhaps we can also get 
some help from @ustcweizhou and others who may have worked on novnc integration.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] syed commented on issue #2204: [CLOUDSTACK-10025] Adding Support for NoVNC Console for KVM and XENSERVER

[GitBox]

syed commented on issue #2204: [CLOUDSTACK-10025] Adding Support for NoVNC 
Console for KVM and XENSERVER
URL: https://github.com/apache/cloudstack/pull/2204#issuecomment-364958976
 
 
   @rhtyd Sorry for dropping the ball on this. We will be looking at working on 
this in the coming months.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2452: CLOUDSTACK-10285: Fix db upgrade failure for 4.10.0.0 users

[GitBox]

blueorangutan commented on issue #2452: CLOUDSTACK-10285: Fix db upgrade 
failure for 4.10.0.0 users
URL: https://github.com/apache/cloudstack/pull/2452#issuecomment-364954377
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2452: CLOUDSTACK-10285: Fix db upgrade failure for 4.10.0.0 users

[GitBox]

rhtyd commented on issue #2452: CLOUDSTACK-10285: Fix db upgrade failure for 
4.10.0.0 users
URL: https://github.com/apache/cloudstack/pull/2452#issuecomment-364954204
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2452: CLOUDSTACK-10285: Fix db upgrade failure for 4.10.0.0 users

[GitBox]

blueorangutan commented on issue #2452: CLOUDSTACK-10285: Fix db upgrade 
failure for 4.10.0.0 users
URL: https://github.com/apache/cloudstack/pull/2452#issuecomment-364930948
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1710


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2452: CLOUDSTACK-10285: Fix db upgrade failure for 4.10.0.0 users

[GitBox]

blueorangutan commented on issue #2452: CLOUDSTACK-10285: Fix db upgrade 
failure for 4.10.0.0 users
URL: https://github.com/apache/cloudstack/pull/2452#issuecomment-364923692
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2452: CLOUDSTACK-10285: Fix db upgrade failure for 4.10.0.0 users

[GitBox]

blueorangutan commented on issue #2452: CLOUDSTACK-10285: Fix db upgrade 
failure for 4.10.0.0 users
URL: https://github.com/apache/cloudstack/pull/2452#issuecomment-364901557
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2452: CLOUDSTACK-10285: Fix db upgrade failure for 4.10.0.0 users

[GitBox]

rhtyd commented on issue #2452: CLOUDSTACK-10285: Fix db upgrade failure for 
4.10.0.0 users
URL: https://github.com/apache/cloudstack/pull/2452#issuecomment-364923525
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2452: CLOUDSTACK-10285: Fix db upgrade failure for 4.10.0.0 users

[GitBox]

blueorangutan commented on issue #2452: CLOUDSTACK-10285: Fix db upgrade 
failure for 4.10.0.0 users
URL: https://github.com/apache/cloudstack/pull/2452#issuecomment-364907238
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1709


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2452: CLOUDSTACK-10285: Fix db upgrade failure for 4.10.0.0 users

[GitBox]

rhtyd commented on a change in pull request #2452: CLOUDSTACK-10285: Fix db 
upgrade failure for 4.10.0.0 users
URL: https://github.com/apache/cloudstack/pull/2452#discussion_r167555229
 
 

 ##
 File path: engine/schema/resources/META-INF/db/schema-41000to41100.sql
 ##
 @@ -546,3 +546,24 @@ ALTER TABLE cloud.ldap_trust_map ADD COLUMN account_id 
BIGINT(20) DEFAULT 0;
 ALTER TABLE cloud.ldap_trust_map DROP FOREIGN KEY fk_ldap_trust_map__domain_id;
 DROP INDEX uk_ldap_trust_map__domain_id ON cloud.ldap_trust_map;
 CREATE UNIQUE INDEX uk_ldap_trust_map__bind_location ON ldap_trust_map 
(domain_id, account_id);
+
+CREATE TABLE IF NOT EXISTS `cloud`.`netscaler_servicepackages` (
+  `id` bigint unsigned NOT NULL AUTO_INCREMENT COMMENT 'id',
+  `uuid` varchar(255) UNIQUE,
+  `name` varchar(255) UNIQUE COMMENT 'name of the service package',
+  `description` varchar(255) COMMENT 'description of the service package',
+  PRIMARY KEY  (`id`)
+) ENGINE=InnoDB DEFAULT CHARSET=utf8;
+
+CREATE TABLE IF NOT EXISTS `cloud`.`external_netscaler_controlcenter` (
+  `id` bigint unsigned NOT NULL AUTO_INCREMENT COMMENT 'id',
+  `uuid` varchar(255) UNIQUE,
+  `username` varchar(255) COMMENT 'username of the NCC',
+  `password` varchar(255) COMMENT 'password of NCC',
+  `ncc_ip` varchar(255) COMMENT 'IP of NCC Manager',
+  `num_retries` bigint unsigned NOT NULL default 2 COMMENT 'Number of retries 
in ncc for command failure',
+  PRIMARY KEY  (`id`)
+) ENGINE=InnoDB DEFAULT CHARSET=utf8;
+
+ALTER TABLE `cloud`.`sslcerts` ADD COLUMN `name` varchar(255) NULL default 
NULL COMMENT 'Name of the Certificate';
 
 Review comment:
   The assumption is it won't exist in before 4.11.0.0 release. Users of 
4.9.3.0 or earlier will get this change when they upgrade to 4.11.0.0 but 
4.10.0.0 users won't. See the dev/user ML for the discussion/proposal. But I 
see what you mean, the query is not idempotent which perhaps @ernjvr and 
@borisstoyanov may help improve.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ustcweizhou commented on a change in pull request #2452: CLOUDSTACK-10285: Fix db upgrade failure for 4.10.0.0 users

[GitBox]

ustcweizhou commented on a change in pull request #2452: CLOUDSTACK-10285: Fix 
db upgrade failure for 4.10.0.0 users
URL: https://github.com/apache/cloudstack/pull/2452#discussion_r167540175
 
 

 ##
 File path: engine/schema/resources/META-INF/db/schema-41000to41100.sql
 ##
 @@ -546,3 +546,24 @@ ALTER TABLE cloud.ldap_trust_map ADD COLUMN account_id 
BIGINT(20) DEFAULT 0;
 ALTER TABLE cloud.ldap_trust_map DROP FOREIGN KEY fk_ldap_trust_map__domain_id;
 DROP INDEX uk_ldap_trust_map__domain_id ON cloud.ldap_trust_map;
 CREATE UNIQUE INDEX uk_ldap_trust_map__bind_location ON ldap_trust_map 
(domain_id, account_id);
+
+CREATE TABLE IF NOT EXISTS `cloud`.`netscaler_servicepackages` (
+  `id` bigint unsigned NOT NULL AUTO_INCREMENT COMMENT 'id',
+  `uuid` varchar(255) UNIQUE,
+  `name` varchar(255) UNIQUE COMMENT 'name of the service package',
+  `description` varchar(255) COMMENT 'description of the service package',
+  PRIMARY KEY  (`id`)
+) ENGINE=InnoDB DEFAULT CHARSET=utf8;
+
+CREATE TABLE IF NOT EXISTS `cloud`.`external_netscaler_controlcenter` (
+  `id` bigint unsigned NOT NULL AUTO_INCREMENT COMMENT 'id',
+  `uuid` varchar(255) UNIQUE,
+  `username` varchar(255) COMMENT 'username of the NCC',
+  `password` varchar(255) COMMENT 'password of NCC',
+  `ncc_ip` varchar(255) COMMENT 'IP of NCC Manager',
+  `num_retries` bigint unsigned NOT NULL default 2 COMMENT 'Number of retries 
in ncc for command failure',
+  PRIMARY KEY  (`id`)
+) ENGINE=InnoDB DEFAULT CHARSET=utf8;
+
+ALTER TABLE `cloud`.`sslcerts` ADD COLUMN `name` varchar(255) NULL default 
NULL COMMENT 'Name of the Certificate';
 
 Review comment:
   Is it possible that `name` field already exists in `sslcerts` table ?
   If yes, upgrade will fail here.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2452: CLOUDSTACK-10285: Fix db upgrade failure for 4.10.0.0 users

[GitBox]

blueorangutan commented on issue #2452: CLOUDSTACK-10285: Fix db upgrade 
failure for 4.10.0.0 users
URL: https://github.com/apache/cloudstack/pull/2452#issuecomment-364907238
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1709


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2452: CLOUDSTACK-10285: Fix db upgrade failure for 4.10.0.0 users

[GitBox]

blueorangutan commented on issue #2452: CLOUDSTACK-10285: Fix db upgrade 
failure for 4.10.0.0 users
URL: https://github.com/apache/cloudstack/pull/2452#issuecomment-364901557
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd opened a new pull request #2452: CLOUDSTACK-10285: Fix db upgrade failure for 4.10.0.0 users

[GitBox]

rhtyd opened a new pull request #2452: CLOUDSTACK-10285: Fix db upgrade failure 
for 4.10.0.0 users
URL: https://github.com/apache/cloudstack/pull/2452
 
 
   4.10.0.0 users when upgrade to 4.11.0.0 may face db related
   discrepancies due to some PRs that got merged without moving their sql
   changes to 4.10->4.11 upgrade path. The 4.10.0.0 users can run those
   missing sql statements manually and then upgrade to 4.11.0.0, since a
   workaround like this is possible this ticket is not marked a blocker. In
   4.11.1.0+, we'll move those changes from 4.9.3.0->4.10.0.0 upgrade path
   to 4.10.0.0->4.11.0.0 upgrade path. Ideally we should not be doing this,
   but this will fix issues for a future 4.10.0.0 user who may want to
   upgrade to 4.11.1.0 or 4.12.0.0+.
   
   The failure hit is missing column `service_package_id`.
   Issue was caused primarily due to `884606f77be7621944d2f315fd8eabe8884c45d9`.
   
   Pinging for review - @PaulAngus @borisstoyanov @DaanHoogland @wido @karuturi 
@sateesh-chodapuneedi and others.
   
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch 4.11 updated: CLOUDSTACK-10261: Libvirt metadata create only one nuage-extension xml tag (#2441)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch 4.11
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/4.11 by this push:
 new dee5bb5  CLOUDSTACK-10261: Libvirt metadata create only one 
nuage-extension xml tag (#2441)
dee5bb5 is described below

commit dee5bb527e7aca4e72e2249b348cca6d688fbe5f
Author: Frank Maximus 
AuthorDate: Mon Feb 12 12:06:44 2018 +0100

CLOUDSTACK-10261: Libvirt metadata create only one nuage-extension xml tag 
(#2441)
---
 .../com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java | 15 +++
 .../cloud/hypervisor/kvm/resource/LibvirtVMDefTest.java | 17 +
 2 files changed, 24 insertions(+), 8 deletions(-)

diff --git 
a/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java
 
b/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java
index 385fe79..90674eb 100644
--- 
a/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java
+++ 
b/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java
@@ -1543,16 +1543,15 @@ public class LibvirtVMDef {
 @Override
 public String toString() {
 StringBuilder fsBuilder = new StringBuilder();
+fsBuilder.append("\n");
 for (Map.Entry address : addresses.entrySet()) {
-fsBuilder.append("\n")
-.append("  \n")
-.append("\n");
+fsBuilder.append("  \n");
 }
-return fsBuilder.toString();
+return fsBuilder.append("\n").toString();
 }
 }
 
diff --git 
a/plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/LibvirtVMDefTest.java
 
b/plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/LibvirtVMDefTest.java
index 006562c..b391b94 100644
--- 
a/plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/LibvirtVMDefTest.java
+++ 
b/plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/LibvirtVMDefTest.java
@@ -209,4 +209,21 @@ public class LibvirtVMDefTest extends TestCase {
 assertEquals(str, expected);
 }
 
+public void testMetadataDef() {
+LibvirtVMDef.MetadataDef metadataDef = new LibvirtVMDef.MetadataDef();
+
+
metadataDef.getMetadataNode(LibvirtVMDef.NuageExtensionDef.class).addNuageExtension("mac1",
 "ip1");
+
metadataDef.getMetadataNode(LibvirtVMDef.NuageExtensionDef.class).addNuageExtension("mac2",
 "ip2");
+
+String xmlDef = metadataDef.toString();
+String expectedXml = "\n" +
+"\n" +
+"  \n" +
+"  \n" +
+"\n" +
+"\n";
+
+assertEquals(xmlDef, expectedXml);
+}
+
 }

-- 
To stop receiving notification emails like this one, please contact
ro...@apache.org.

[GitHub] rhtyd closed pull request #2441: CLOUDSTACK-10261: Libvirt metadata: only create one nuage-extension tag

[GitBox]

rhtyd closed pull request #2441: CLOUDSTACK-10261: Libvirt metadata: only 
create one nuage-extension tag
URL: https://github.com/apache/cloudstack/pull/2441
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java
 
b/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java
index 385fe79ef2a..90674eb99a8 100644
--- 
a/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java
+++ 
b/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java
@@ -1543,16 +1543,15 @@ public void addNuageExtension(String macAddress, String 
vrIp) {
 @Override
 public String toString() {
 StringBuilder fsBuilder = new StringBuilder();
+fsBuilder.append("\n");
 for (Map.Entry address : addresses.entrySet()) {
-fsBuilder.append("\n")
-.append("  \n")
-.append("\n");
+fsBuilder.append("  \n");
 }
-return fsBuilder.toString();
+return fsBuilder.append("\n").toString();
 }
 }
 
diff --git 
a/plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/LibvirtVMDefTest.java
 
b/plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/LibvirtVMDefTest.java
index 006562c213e..b391b94e740 100644
--- 
a/plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/LibvirtVMDefTest.java
+++ 
b/plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/LibvirtVMDefTest.java
@@ -209,4 +209,21 @@ public void testSCSIDef() {
 assertEquals(str, expected);
 }
 
+public void testMetadataDef() {
+LibvirtVMDef.MetadataDef metadataDef = new LibvirtVMDef.MetadataDef();
+
+
metadataDef.getMetadataNode(LibvirtVMDef.NuageExtensionDef.class).addNuageExtension("mac1",
 "ip1");
+
metadataDef.getMetadataNode(LibvirtVMDef.NuageExtensionDef.class).addNuageExtension("mac2",
 "ip2");
+
+String xmlDef = metadataDef.toString();
+String expectedXml = "\n" +
+"\n" +
+"  \n" +
+"  \n" +
+"\n" +
+"\n";
+
+assertEquals(xmlDef, expectedXml);
+}
+
 }


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2441: CLOUDSTACK-10261: Libvirt metadata: only create one nuage-extension tag

[GitBox]

rhtyd commented on issue #2441: CLOUDSTACK-10261: Libvirt metadata: only create 
one nuage-extension tag
URL: https://github.com/apache/cloudstack/pull/2441#issuecomment-364891629
 
 
   LGTM, merging based on review and test results (ignoring intermittent 
failures).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack-docs-install] 01/01: source: bump version

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-docs-install.git

commit 3ae5d3e45f0f84d5a65ee9a89932d1d456506b17
Author: Rohit Yadav 
AuthorDate: Mon Feb 12 12:03:50 2018 +0100

source: bump version

Signed-off-by: Rohit Yadav 
---
 source/conf.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/source/conf.py b/source/conf.py
index 3442092..3c78bc6 100644
--- a/source/conf.py
+++ b/source/conf.py
@@ -61,9 +61,9 @@ copyright = u'2018, Apache Software Foundation'
 # built documents.
 #
 # The short X.Y version.
-version = '4.11'
+version = '4.12'
 # The full version, including alpha/beta/rc tags.
-release = '4.11.0.0'
+release = '4.12.0.0'
 
 # The language for content autogenerated by Sphinx. Refer to documentation
 # for a list of supported languages.

-- 
To stop receiving notification emails like this one, please contact
ro...@apache.org.

[cloudstack-docs-install] branch master updated (d11db4f -> 3ae5d3e)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-docs-install.git.


from d11db4f  Updates for 4.11 release
 add b2eb9cc  update preferred versions text (#34)
 new 3ae5d3e  source: bump version

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 source/conf.py| 4 ++--
 source/overview/_requirements.rst | 2 +-
 source/overview/index.rst | 4 ++--
 3 files changed, 5 insertions(+), 5 deletions(-)

-- 
To stop receiving notification emails like this one, please contact
ro...@apache.org.

[cloudstack-docs-install] branch 4.11 updated: update preferred versions text (#34)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch 4.11
in repository https://gitbox.apache.org/repos/asf/cloudstack-docs-install.git


The following commit(s) were added to refs/heads/4.11 by this push:
 new b2eb9cc  update preferred versions text (#34)
b2eb9cc is described below

commit b2eb9cc507de696bc3ec40120d734f621ac81590
Author: Paul Angus 
AuthorDate: Mon Feb 12 11:02:21 2018 +

update preferred versions text (#34)
---
 source/overview/_requirements.rst | 2 +-
 source/overview/index.rst | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/source/overview/_requirements.rst 
b/source/overview/_requirements.rst
index 92b1def..1531462 100644
--- a/source/overview/_requirements.rst
+++ b/source/overview/_requirements.rst
@@ -29,7 +29,7 @@ Management Server may be placed on a virtual machine.
 
 -  Operating system:
 
-   -  Preferred: CentOS/RHEL 6.3+ or Ubuntu 14.04(.2)
+   -  Preferred: CentOS/RHEL 7.2+, CentOS/RHEL 6.8+ or Ubuntu 14.04(.2) or 
higher
 
 -  64-bit x86 CPU (more cores results in better performance)
 
diff --git a/source/overview/index.rst b/source/overview/index.rst
index 1305f4a..c14d487 100644
--- a/source/overview/index.rst
+++ b/source/overview/index.rst
@@ -25,10 +25,10 @@ Installation overview
 .. include:: _requirements.rst
 
 
-package repository
+Package Repository
 --
 
-CloudStack is only distributed from source from the official mirrors.
+CloudStack is only distributed from source from the official Apache mirrors.
 However, members of the CloudStack community may build convenience
 binaries so that users can install Apache CloudStack without needing to
 build from source.

-- 
To stop receiving notification emails like this one, please contact
ro...@apache.org.

[GitHub] blueorangutan commented on issue #2450: CLOUDSTACK-10282: firewall rules operation should be done with ip6tab?

[GitBox]

blueorangutan commented on issue #2450: CLOUDSTACK-10282: firewall rules 
operation should be done with ip6tab?
URL: https://github.com/apache/cloudstack/pull/2450#issuecomment-364887772
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1708


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2450: CLOUDSTACK-10282: firewall rules operation should be done with ip6tab?

[GitBox]

blueorangutan commented on issue #2450: CLOUDSTACK-10282: firewall rules 
operation should be done with ip6tab?
URL: https://github.com/apache/cloudstack/pull/2450#issuecomment-364881789
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2450: CLOUDSTACK-10282: firewall rules operation should be done with ip6tab?

[GitBox]

rhtyd commented on issue #2450: CLOUDSTACK-10282: firewall rules operation 
should be done with ip6tab?
URL: https://github.com/apache/cloudstack/pull/2450#issuecomment-364881765
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition

[GitBox]

DaanHoogland commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column 
addition
URL: https://github.com/apache/cloudstack/pull/2449#issuecomment-364879178
 
 
   @ustcweizhou I agree that something like that would be preferable but 
someone has to take the heat on implementing that. And nobody is taking the 
time for such a technical/non-functional improvement.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2448: CLOUDSTACK-10274: L2 network refused to be designed on VXLAN physical network

[GitBox]

borisstoyanov commented on issue #2448: CLOUDSTACK-10274: L2 network refused to 
be designed on VXLAN physical network
URL: https://github.com/apache/cloudstack/pull/2448#issuecomment-364874573
 
 
   @NuxRo we'll be addressing this as well


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] NuxRo commented on issue #2448: CLOUDSTACK-10274: L2 network refused to be designed on VXLAN physical network

[GitBox]

NuxRo commented on issue #2448: CLOUDSTACK-10274: L2 network refused to be 
designed on VXLAN physical network
URL: https://github.com/apache/cloudstack/pull/2448#issuecomment-364873501
 
 
   A bit confused as to whether my previous complaint was noticed, so here goes 
again:
   
   - this is only HALF working, the VXLAN based L2 Network will fail to create 
if VXLAN id is over 4096, it seems to be applying VLAN limit numbers.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] marcaurele commented on issue #2450: CLOUDSTACK-10282: firewall rules operation should be done with ip6tab?

[GitBox]

marcaurele commented on issue #2450: CLOUDSTACK-10282: firewall rules operation 
should be done with ip6tab?
URL: https://github.com/apache/cloudstack/pull/2450#issuecomment-364857790
 
 
   Rebased done @rhtyd 
   
   This bug leaves the systemvm with all ports opened


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] marcaurele commented on issue #2450: CLOUDSTACK-10282: firewall rules operation should be done with ip6tab?

[GitBox]

marcaurele commented on issue #2450: CLOUDSTACK-10282: firewall rules operation 
should be done with ip6tab?
URL: https://github.com/apache/cloudstack/pull/2450#issuecomment-364857790
 
 
   Rebased done @rhtyd 
   
   This bug leaves the systemvm with all port opened


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] marcaurele commented on issue #2450: CLOUDSTACK-10282: firewall rules operation should be done with ip6tab?

[GitBox]

marcaurele commented on issue #2450: CLOUDSTACK-10282: firewall rules operation 
should be done with ip6tab?
URL: https://github.com/apache/cloudstack/pull/2450#issuecomment-364857790
 
 
   Rebased done @rhtyd 
   
   This bug leaves the systemvm with all port opens


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2442: CLOUDSTACK-10147 Disabled Xenserver Cluster can still deploy VM's

[GitBox]

borisstoyanov commented on issue #2442: CLOUDSTACK-10147 Disabled Xenserver 
Cluster can still deploy VM's
URL: https://github.com/apache/cloudstack/pull/2442#issuecomment-364855183
 
 
   @blueorangutan test centos7 xenserver-65sp1


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2442: CLOUDSTACK-10147 Disabled Xenserver Cluster can still deploy VM's

[GitBox]

blueorangutan commented on issue #2442: CLOUDSTACK-10147 Disabled Xenserver 
Cluster can still deploy VM's
URL: https://github.com/apache/cloudstack/pull/2442#issuecomment-364855206
 
 
   @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + xenserver-65sp1) 
has been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2423: CLOUDSTACK-10250: Reinstall VM from bypassed registered template

[GitBox]

blueorangutan commented on issue #2423: CLOUDSTACK-10250: Reinstall VM from 
bypassed registered template
URL: https://github.com/apache/cloudstack/pull/2423#issuecomment-364855209
 
 
   @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2446: CLOUDSTACK-10271 maven plugin for owasp dependency check added

[GitBox]

blueorangutan commented on issue #2446: CLOUDSTACK-10271 maven plugin for owasp 
dependency check added
URL: https://github.com/apache/cloudstack/pull/2446#issuecomment-364854977
 
 
   @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2423: CLOUDSTACK-10250: Reinstall VM from bypassed registered template

[GitBox]

borisstoyanov commented on issue #2423: CLOUDSTACK-10250: Reinstall VM from 
bypassed registered template
URL: https://github.com/apache/cloudstack/pull/2423#issuecomment-364855042
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2446: CLOUDSTACK-10271 maven plugin for owasp dependency check added

[GitBox]

borisstoyanov commented on issue #2446: CLOUDSTACK-10271 maven plugin for owasp 
dependency check added
URL: https://github.com/apache/cloudstack/pull/2446#issuecomment-364854961
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2423: CLOUDSTACK-10250: Reinstall VM from bypassed registered template

[GitBox]

blueorangutan commented on issue #2423: CLOUDSTACK-10250: Reinstall VM from 
bypassed registered template
URL: https://github.com/apache/cloudstack/pull/2423#issuecomment-364854140
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1707


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2442: CLOUDSTACK-10147 Disabled Xenserver Cluster can still deploy VM's

[GitBox]

blueorangutan commented on issue #2442: CLOUDSTACK-10147 Disabled Xenserver 
Cluster can still deploy VM's
URL: https://github.com/apache/cloudstack/pull/2442#issuecomment-364854142
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1706


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2446: CLOUDSTACK-10271 maven plugin for owasp dependency check added

[GitBox]

blueorangutan commented on issue #2446: CLOUDSTACK-10271 maven plugin for owasp 
dependency check added
URL: https://github.com/apache/cloudstack/pull/2446#issuecomment-364854141
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1705


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ustcweizhou commented on issue #2451: CLOUDSTACK-10284:Creating a snapshot from VM Snapshot generates error if hypervisor is not KVM.

[GitBox]

ustcweizhou commented on issue #2451: CLOUDSTACK-10284:Creating a snapshot from 
VM Snapshot generates error if hypervisor is not KVM.
URL: https://github.com/apache/cloudstack/pull/2451#issuecomment-364853929
 
 
   @niteshsarda sorry I cannot merge it now.
   two issues
   (1) what if the instance is removed ?
   (2) what if we view the vm snapshots from Storage -> VM Snapshots -> select 
vm snapshot ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services