[GitHub] rhtyd commented on issue #2633: SSVM cannot reconnect after connection disruption if there is an active event.
rhtyd commented on issue #2633: SSVM cannot reconnect after connection disruption if there is an active event. URL: https://github.com/apache/cloudstack/issues/2633#issuecomment-387979511 @PaulAngus This is by design of agent (not specific to any cloudstack version), any pending job in Agent's internal queue will block it from reconnecting until the job finishes. /cc @nvazquez @DaanHoogland - any comments on how to deal with this? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2508: CLOUDSTACK-9114: Reduce VR downtime during network restart
rhtyd commented on issue #2508: CLOUDSTACK-9114: Reduce VR downtime during network restart URL: https://github.com/apache/cloudstack/pull/2508#issuecomment-387979763 Tests LGTM, we've enough reviews to merge this. If there are no objections, this will be merged by end of the day tomorrow. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2376: [4.11] Smoketest Health Check
rhtyd commented on issue #2376: [4.11] Smoketest Health Check URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-387981139 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2376: [4.11] Smoketest Health Check
blueorangutan commented on issue #2376: [4.11] Smoketest Health Check URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-387981223 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd closed pull request #1253: CLOUDSTACK-9184: [VMware] vmware.ports.per.dvportgroup global setting is not useful from vCenter 5.0 onwards
rhtyd closed pull request #1253: CLOUDSTACK-9184: [VMware]
vmware.ports.per.dvportgroup global setting is not useful from vCenter 5.0
onwards
URL: https://github.com/apache/cloudstack/pull/1253
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
b/plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
index b0f87af648d..bb451ceb392 100644
---
a/plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
+++
b/plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
@@ -134,6 +134,10 @@
private static final long SECONDS_PER_MINUTE = 60;
private static final int STARTUP_DELAY = 6; // 60
seconds
private static final long DEFAULT_HOST_SCAN_INTERVAL = 60; //
every 10 minutes
+
+private static final int DEFAULT_PORTS_PER_DV_PORT_GROUP_VSPHERE4_x = 256;
+private static final int DEFAULT_PORTS_PER_DV_PORT_GROUP = 8;
+
private long _hostScanInterval = DEFAULT_HOST_SCAN_INTERVAL;
private int _timeout;
@@ -180,7 +184,7 @@
private StorageLayer _storage;
private final String _privateNetworkVSwitchName = "vSwitch0";
-private int _portsPerDvPortGroup = 256;
+private int _portsPerDvPortGroup = DEFAULT_PORTS_PER_DV_PORT_GROUP;
private boolean _fullCloneFlag;
private boolean _instanceNameFlag;
private String _serviceConsoleName;
@@ -267,8 +271,6 @@ public boolean configure(String name, Map
params) throws Configu
_instanceNameFlag = Boolean.parseBoolean(value);
}
-_portsPerDvPortGroup =
NumbersUtil.parseInt(_configDao.getValue(Config.VmwarePortsPerDVPortGroup.key()),
_portsPerDvPortGroup);
-
_serviceConsoleName =
_configDao.getValue(Config.VmwareServiceConsole.key());
if (_serviceConsoleName == null) {
_serviceConsoleName = "Service Console";
@@ -387,8 +389,17 @@ private void prepareHost(HostMO hostMo, String
privateTrafficLabel) throws Excep
HypervisorHostHelper.prepareNetwork(vSwitchName, "cloud.private",
hostMo, vlanId, null, null, 18, false, BroadcastDomainType.Vlan, null);
}
else {
+int portsPerDvPortGroup = _portsPerDvPortGroup;
+AboutInfo about = hostMo.getHostAboutInfo();
+if (about != null) {
+String version = about.getApiVersion();
+if (version != null && (version.equals("4.0") ||
version.equals("4.1")) && _portsPerDvPortGroup <
DEFAULT_PORTS_PER_DV_PORT_GROUP_VSPHERE4_x) {
+portsPerDvPortGroup =
DEFAULT_PORTS_PER_DV_PORT_GROUP_VSPHERE4_x;
+}
+}
+
HypervisorHostHelper.prepareNetwork(vSwitchName, "cloud.private",
hostMo, vlanId, null, null, null, 18,
-vsType, _portsPerDvPortGroup, null, false,
BroadcastDomainType.Vlan, null);
+vsType, portsPerDvPortGroup, null, false,
BroadcastDomainType.Vlan, null);
}
}
diff --git a/server/src/com/cloud/configuration/Config.java
b/server/src/com/cloud/configuration/Config.java
index 551c61ea2e4..e9ef4432f75 100644
--- a/server/src/com/cloud/configuration/Config.java
+++ b/server/src/com/cloud/configuration/Config.java
@@ -1135,14 +1135,6 @@
"false",
"Enable/Disable Nexus/Vmware dvSwitch in VMware environment",
null),
-VmwarePortsPerDVPortGroup(
-"Network",
-ManagementServer.class,
-Integer.class,
-"vmware.ports.per.dvportgroup",
-"256",
-"Default number of ports per Vmware dvPortGroup in VMware
environment",
-null),
VmwareCreateFullClone(
"Advanced",
ManagementServer.class,
diff --git a/setup/db/db/schema-4930to41000-cleanup.sql
b/setup/db/db/schema-4930to41000-cleanup.sql
index 986dcdfe7da..b9b853e34f2 100644
--- a/setup/db/db/schema-4930to41000-cleanup.sql
+++ b/setup/db/db/schema-4930to41000-cleanup.sql
@@ -21,4 +21,6 @@
DELETE FROM `cloud`.`configuration` WHERE
name='consoleproxy.loadscan.interval';
+DELETE FROM `cloud`.`configuration` WHERE
`name`='vmware.ports.per.dvportgroup';
+
DELETE FROM `cloud`.`host_details` where name = 'vmName' and value in (select
name from `cloud`.`vm_instance` where state = 'Expunging' and hypervisor_type
='BareMetal');
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries abou
[GitHub] rhtyd commented on issue #1253: CLOUDSTACK-9184: [VMware] vmware.ports.per.dvportgroup global setting is not useful from vCenter 5.0 onwards
rhtyd commented on issue #1253: CLOUDSTACK-9184: [VMware] vmware.ports.per.dvportgroup global setting is not useful from vCenter 5.0 onwards URL: https://github.com/apache/cloudstack/pull/1253#issuecomment-387985818 Closing this, will send a new PR taking over this issue. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd opened a new pull request #2634: CLOUDSTACK-9184: Fixes #2631 VMware dvs portgroup autogrowth
rhtyd opened a new pull request #2634: CLOUDSTACK-9184: Fixes #2631 VMware dvs portgroup autogrowth URL: https://github.com/apache/cloudstack/pull/2634 This deprecates the vmware.ports.per.dvportgroup global setting. The vSphere Auto Expand feature (introduced in vSphere 5.0) will take care of dynamically increasing/decreasing the dvPorts when running out of distributed ports . But in case of vSphere 4.1/4.0 (If used), as this feature is not there, the new default value (=> 8) have an impact in the existing deployments. Action item for vSphere 4.1/4.0: Admin should modify the global configuration setting "vmware.ports.per.dvportgroup" from 8 to any number based on their environment because the proposal default value of 8 would be very less without auto expand feature in general. The current default value of 256 may not need immediate modification after deployment, but 8 would be very less which means admin need to update immediately after upgrade. This continues and take-over from PR https://github.com/apache/cloudstack/pull/1253 ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## GitHub Issue/PRs ## Screenshots (if appropriate): ## How Has This Been Tested? ## Checklist: - [ ] I have read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document. - [ ] My code follows the code style of this project. - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. Testing - [ ] I have added tests to cover my changes. - [ ] All relevant new and existing integration tests have passed. - [ ] A full integration testsuite with all test that can run on my environment has passed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2634: CLOUDSTACK-9184: Fixes #2631 VMware dvs portgroup autogrowth
rhtyd commented on issue #2634: CLOUDSTACK-9184: Fixes #2631 VMware dvs portgroup autogrowth URL: https://github.com/apache/cloudstack/pull/2634#issuecomment-387987066 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2376: [4.11] Smoketest Health Check
blueorangutan commented on issue #2376: [4.11] Smoketest Health Check URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-387987070 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2039 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2634: CLOUDSTACK-9184: Fixes #2631 VMware dvs portgroup autogrowth
blueorangutan commented on issue #2634: CLOUDSTACK-9184: Fixes #2631 VMware dvs portgroup autogrowth URL: https://github.com/apache/cloudstack/pull/2634#issuecomment-387987251 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2634: CLOUDSTACK-9184: Fixes #2631 VMware dvs portgroup autogrowth
blueorangutan commented on issue #2634: CLOUDSTACK-9184: Fixes #2631 VMware dvs portgroup autogrowth URL: https://github.com/apache/cloudstack/pull/2634#issuecomment-387994777 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2040 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sureshanaparti commented on issue #1253: CLOUDSTACK-9184: [VMware] vmware.ports.per.dvportgroup global setting is not useful from vCenter 5.0 onwards
sureshanaparti commented on issue #1253: CLOUDSTACK-9184: [VMware] vmware.ports.per.dvportgroup global setting is not useful from vCenter 5.0 onwards URL: https://github.com/apache/cloudstack/pull/1253#issuecomment-387996149 @PaulAngus , @rhtyd I'll continue work on the changes required if any, on this. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2634: CLOUDSTACK-9184: Fixes #2631 VMware dvs portgroup autogrowth
rhtyd commented on issue #2634: CLOUDSTACK-9184: Fixes #2631 VMware dvs portgroup autogrowth URL: https://github.com/apache/cloudstack/pull/2634#issuecomment-388003370 @blueorangutan test centos7 vmware-65 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #1253: CLOUDSTACK-9184: [VMware] vmware.ports.per.dvportgroup global setting is not useful from vCenter 5.0 onwards
rhtyd commented on issue #1253: CLOUDSTACK-9184: [VMware] vmware.ports.per.dvportgroup global setting is not useful from vCenter 5.0 onwards URL: https://github.com/apache/cloudstack/pull/1253#issuecomment-388003293 @sureshanaparti I've moved the changes to this new PR against 4.11: https://github.com/apache/cloudstack/pull/2634#issuecomment-387994777 Perhaps you can share how you tested it, help with testing in general. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2634: CLOUDSTACK-9184: Fixes #2631 VMware dvs portgroup autogrowth
blueorangutan commented on issue #2634: CLOUDSTACK-9184: Fixes #2631 VMware dvs portgroup autogrowth URL: https://github.com/apache/cloudstack/pull/2634#issuecomment-388003574 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-65) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2544: Password Reset does not work with Isolated Networks with redundant routers
rhtyd commented on issue #2544: Password Reset does not work with Isolated Networks with redundant routers URL: https://github.com/apache/cloudstack/issues/2544#issuecomment-388006326 @s-seitz can you share the `cloudstack-set-guest-password` password that you've used? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2544: Password Reset does not work with Isolated Networks with redundant routers
rhtyd commented on issue #2544: Password Reset does not work with Isolated Networks with redundant routers URL: https://github.com/apache/cloudstack/issues/2544#issuecomment-388006629 @s-seitz ignore if this is same as: https://github.com/apache/cloudstack/blob/4.11/setup/bindir/cloud-set-guest-password.in This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd opened a new pull request #2635: router: Fixes #2544 run passwd server on dhcpserver IP on rVR
rhtyd opened a new pull request #2635: router: Fixes #2544 run passwd server on dhcpserver IP on rVR URL: https://github.com/apache/cloudstack/pull/2635 This fixes #2544, ensure that password reset script works in redudant networks. This ensures that password server runs on the dhcpserver identifier IP which is the not the VRRP virtual (10.1.1.1) IP by default but the actual ip of the interface. When dhcp client discovery is made, the `dhcp-server-identifier` contains the non VIP address that is used by password reset script to query guest VM password. ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## GitHub Issue/PRs ## Screenshots (if appropriate): ## How Has This Been Tested? Deployed a guest VM in redundant VR network, with a password enable template (macchinina). Verified on master VRs (and also on switching) that password server runs on the guest nic IP than the VIP and the password script is able to consume the nonVIP address from `dhcp-server-identifier`. ## Checklist: - [ ] I have read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document. - [ ] My code follows the code style of this project. - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. Testing - [ ] I have added tests to cover my changes. - [ ] All relevant new and existing integration tests have passed. - [ ] A full integration testsuite with all test that can run on my environment has passed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2635: router: Fixes #2544 run passwd server on dhcpserver IP on rVR
rhtyd commented on issue #2635: router: Fixes #2544 run passwd server on dhcpserver IP on rVR URL: https://github.com/apache/cloudstack/pull/2635#issuecomment-388020415 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd closed issue #2544: Password Reset does not work with Isolated Networks with redundant routers
rhtyd closed issue #2544: Password Reset does not work with Isolated Networks with redundant routers URL: https://github.com/apache/cloudstack/issues/2544 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2544: Password Reset does not work with Isolated Networks with redundant routers
rhtyd commented on issue #2544: Password Reset does not work with Isolated Networks with redundant routers URL: https://github.com/apache/cloudstack/issues/2544#issuecomment-388020508 Addressed fix in https://github.com/apache/cloudstack/pull/2635, closing now. @s-seitz you can test the PR, thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2635: router: Fixes #2544 run passwd server on dhcpserver IP on rVR
blueorangutan commented on issue #2635: router: Fixes #2544 run passwd server on dhcpserver IP on rVR URL: https://github.com/apache/cloudstack/pull/2635#issuecomment-388020449 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] izenk commented on issue #2625: Could not connect to SMTP host
izenk commented on issue #2625: Could not connect to SMTP host URL: https://github.com/apache/cloudstack/issues/2625#issuecomment-388023920 project.smtp.useAuth was already enabled Issue is related to SSL or STARTTLS. In general there are two cases for secure SMTP connection: SSL (First SSL handshake, then SMTP HELO) TLS (First SMTP HELO, then STARTLS) CloudStack by default use SSL and only it. When it should be possible to choose. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] izenk commented on issue #2625: Could not connect to SMTP host
izenk commented on issue #2625: Could not connect to SMTP host URL: https://github.com/apache/cloudstack/issues/2625#issuecomment-388023920 @rhtyd project.smtp.useAuth was already enabled Issue is related to SSL or STARTTLS. In general there are two cases for secure SMTP connection: SSL (First SSL handshake, then SMTP HELO) TLS (First SMTP HELO, then STARTLS) CloudStack by default use SSL and only it. When it should be possible to choose. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] izenk commented on issue #2625: Could not connect to SMTP host
izenk commented on issue #2625: Could not connect to SMTP host URL: https://github.com/apache/cloudstack/issues/2625#issuecomment-388023920 @rhtyd project.smtp.useAuth was already enabled Issue is related to SSL or STARTTLS. In general there are two cases for secure SMTP connection: SSL (First SSL handshake, then SMTP HELO) TLS (First SMTP HELO, then STARTLS) CloudStack by default use SSL and only it. When it should be possible to choose: SSL or STARTTLS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2635: router: Fixes #2544 run passwd server on dhcpserver IP on rVR
blueorangutan commented on issue #2635: router: Fixes #2544 run passwd server on dhcpserver IP on rVR URL: https://github.com/apache/cloudstack/pull/2635#issuecomment-388025733 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2041 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on issue #2633: SSVM cannot reconnect after connection disruption if there is an active event.
DaanHoogland commented on issue #2633: SSVM cannot reconnect after connection disruption if there is an active event. URL: https://github.com/apache/cloudstack/issues/2633#issuecomment-388031988 @rhtyd , as discussed on other media: We can make sure there is 0. make sure reconnect is always attempted 1. an other thread guarding there is always exacly one connection open. 2. have a setting that says 'agent.always.reconnect' 3. have a setting 'agent.job.queue.maximum.size' that makes sure only reconnect attempts are done when less than a certain number of jobs are in the queue. or any combination of the above This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2634: CLOUDSTACK-9184: Fixes #2631 VMware dvs portgroup autogrowth
rhtyd commented on issue #2634: CLOUDSTACK-9184: Fixes #2631 VMware dvs portgroup autogrowth URL: https://github.com/apache/cloudstack/pull/2634#issuecomment-388034846 @sureshanaparti I've concluded a standalone and upgrade test (upgrade from 4.6) and conclude no regressions. Do you have any comments on the PR? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] izenk opened a new issue #2625: Could not connect to SMTP host
izenk opened a new issue #2625: Could not connect to SMTP host
URL: https://github.com/apache/cloudstack/issues/2625
ISSUE TYPE
**Other**
COMPONENT NAME
**Management Node**
CLOUDSTACK VERSION
**4.11.0.0**
CONFIGURATION
* **Advanced Networking**
* **KVM**
OS / ENVIRONMENT
**CentOS Linux release 7.4.1708**
Summary
Goal: integrate CloudStack with external SMTP relay.
SMTP relay is Office365 relay from Office365 subscription.
Parameters to connect: smtp.office365.com:587
In general there are two cases for secure connection:
* SSL (First SSL handshake, then SMTP HELO)
* TLS (First SMTP HELO, then STARTLS)
CS does not allow to specify method to use and by default use SSL, what
leads to errors:
~~~
2018-04-25 14:26:15,723 WARN [c.c.p.ProjectManagerImpl]
(API-Job-Executor-5:ctx-0242c153 job-423 ctx-8109c588) (logid:13177452) Failed
to send project id=Project[2|name=test_project|domainid=2] invitation to
the email ; removing the invitation record from the db
javax.mail.MessagingException: Could not connect to SMTP host:
smtp.office365.com, port: 587;
nested exception is:
javax.net.ssl.SSLException: Unrecognized SSL message, plaintext
connection?
at
com.sun.mail.smtp.SMTPTransport.openServer(SMTPTransport.java:1961)
at
com.sun.mail.smtp.SMTPTransport.protocolConnect(SMTPTransport.java:654)
at javax.mail.Service.connect(Service.java:295)
at javax.mail.Service.connect(Service.java:176)
at javax.mail.Service.connect(Service.java:125)
at
com.cloud.projects.ProjectManagerImpl$EmailInvite.sendInvite(ProjectManagerImpl.java:990)
at
com.cloud.projects.ProjectManagerImpl.generateTokenBasedInvitation(ProjectManagerImpl.java:708)
at
com.cloud.projects.ProjectManagerImpl.inviteAccountToProject(ProjectManagerImpl.java:590)
at
com.cloud.projects.ProjectManagerImpl.addAccountToProject(ProjectManagerImpl.java:563)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at
org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:338)
at
org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:197)
at
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163)
at
org.apache.cloudstack.network.contrail.management.EventUtils$EventInterceptor.invoke(EventUtils.java:107)
at
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:174)
at
com.cloud.event.ActionEventInterceptor.invoke(ActionEventInterceptor.java:51)
at
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:174)
at
org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:92)
at
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:185)
at
org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:212)
at com.sun.proxy.$Proxy140.addAccountToProject(Unknown Source)
at
org.apache.cloudstack.api.command.user.account.AddAccountToProjectCmd.execute(AddAccountToProjectCmd.java:91)
at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:150)
at
com.cloud.api.ApiAsyncJobDispatcher.runJob(ApiAsyncJobDispatcher.java:108)
at
org.apache.cloudstack.framework.jobs.impl.AsyncJobManagerImpl$5.runInContext(AsyncJobManagerImpl.java:581)
at
org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:49)
at
org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56)
at
org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103)
at
org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53)
at
org.apache.cloudstack.managed.context.ManagedContextRunnable.run(ManagedContextRunnable.java:46)
at
org.apache.cloudstack.framework.jobs.impl.AsyncJobManagerImpl$5.run(AsyncJobManagerImpl.java:529)
at
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at
java.util.concurrent.Threa
[GitHub] rhtyd commented on issue #2635: router: Fixes #2544 run passwd server on dhcpserver IP on rVR
rhtyd commented on issue #2635: router: Fixes #2544 run passwd server on dhcpserver IP on rVR URL: https://github.com/apache/cloudstack/pull/2635#issuecomment-388036000 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2625: Could not connect to SMTP host
rhtyd commented on issue #2625: Could not connect to SMTP host URL: https://github.com/apache/cloudstack/issues/2625#issuecomment-388035902 @izenk I tested this against a server where it worked for me, let me re-open this. After enabling the global setting (i.e. set to `true`) was the management server restarted? Please also check iptables rules on the management server blocking egress traffic. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2635: router: Fixes #2544 run passwd server on dhcpserver IP on rVR
blueorangutan commented on issue #2635: router: Fixes #2544 run passwd server on dhcpserver IP on rVR URL: https://github.com/apache/cloudstack/pull/2635#issuecomment-388036107 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2629: Fix primary storage count when deleting volumes
rhtyd commented on issue #2629: Fix primary storage count when deleting volumes URL: https://github.com/apache/cloudstack/pull/2629#issuecomment-388036392 @blueorangutan test matrix This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2629: Fix primary storage count when deleting volumes
blueorangutan commented on issue #2629: Fix primary storage count when deleting volumes URL: https://github.com/apache/cloudstack/pull/2629#issuecomment-387859455 Trillian test result (tid-2652) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 22608 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2629-t2652-kvm-centos7.zip Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermitten failure detected: /marvin/tests/smoke/test_router_dhcphosts.py Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py Smoke tests completed. 63 look OK, 4 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_secured_vm_migration | `Error` | 5.25 | test_vm_life_cycle.py test_02_not_secured_vm_migration | `Error` | 4.24 | test_vm_life_cycle.py test_03_secured_to_nonsecured_vm_migration | `Error` | 1.13 | test_vm_life_cycle.py test_04_nonsecured_to_secured_vm_migration | `Error` | 1.12 | test_vm_life_cycle.py ContextSuite context=TestVMLifeCycle>:setup | `Error` | 4.23 | test_vm_life_cycle.py test_01_vpc_site2site_vpn_multiple_options | `Failure` | 167.38 | test_vpc_vpn.py test_01_vpc_site2site_vpn | `Failure` | 160.16 | test_vpc_vpn.py test_01_cancel_host_maintenace_with_no_migration_jobs | `Failure` | 0.11 | test_host_maintenance.py test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 2.33 | test_host_maintenance.py test_hostha_enable_ha_when_host_in_maintenance | `Error` | 4.60 | test_hostha_kvm.py test_hostha_kvm_host_fencing | `Failure` | 663.13 | test_hostha_kvm.py test_hostha_kvm_host_recovering | `Failure` | 618.88 | test_hostha_kvm.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2629: Fix primary storage count when deleting volumes
blueorangutan commented on issue #2629: Fix primary storage count when deleting volumes URL: https://github.com/apache/cloudstack/pull/2629#issuecomment-388036524 @rhtyd a Trillian-Jenkins matrix job (centos6 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] izenk commented on issue #2625: Could not connect to SMTP host
izenk commented on issue #2625: Could not connect to SMTP host URL: https://github.com/apache/cloudstack/issues/2625#issuecomment-388037265 @rhtyd yes, management server was restarted. What is your SMTP server? My is office365 SMTP on 587 port SSL is disabled on SMTP side, only STARTTLS is supported. This means, that first simple non-secure connection is established and only then its upgraded to TLS. You can try it on your server: smtp host = smtp.office365.com:587 Pick any random user and password. If you get auth error, means that you creds are incorrect - its working. If you get "Unrecognized SSL message, plaintext connection" - this is my issue. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rafaelweingartner commented on a change in pull request #2634: CLOUDSTACK-9184: Fixes #2631 VMware dvs portgroup autogrowth
rafaelweingartner commented on a change in pull request #2634: CLOUDSTACK-9184:
Fixes #2631 VMware dvs portgroup autogrowth
URL: https://github.com/apache/cloudstack/pull/2634#discussion_r187320904
##
File path:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
##
@@ -394,8 +394,16 @@ private void prepareHost(HostMO hostMo, String
privateTrafficLabel) throws Excep
HypervisorHostHelper.prepareNetwork(vSwitchName, "cloud.private",
hostMo, vlanId, null, null, 18, false, BroadcastDomainType.Vlan, null,
null);
}
else {
+int portsPerDvPortGroup = _portsPerDvPortGroup;
+AboutInfo about = hostMo.getHostAboutInfo();
+if (about != null) {
+String version = about.getApiVersion();
+if (version != null && (version.equals("4.0") ||
version.equals("4.1")) && _portsPerDvPortGroup <
DEFAULT_PORTS_PER_DV_PORT_GROUP_VSPHERE4_x) {
Review comment:
do you need that second condition there `_portsPerDvPortGroup <
DEFAULT_PORTS_PER_DV_PORT_GROUP_VSPHERE4_x`?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rafaelweingartner commented on a change in pull request #2634: CLOUDSTACK-9184: Fixes #2631 VMware dvs portgroup autogrowth
rafaelweingartner commented on a change in pull request #2634: CLOUDSTACK-9184:
Fixes #2631 VMware dvs portgroup autogrowth
URL: https://github.com/apache/cloudstack/pull/2634#discussion_r187322162
##
File path:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
##
@@ -394,8 +394,16 @@ private void prepareHost(HostMO hostMo, String
privateTrafficLabel) throws Excep
HypervisorHostHelper.prepareNetwork(vSwitchName, "cloud.private",
hostMo, vlanId, null, null, 18, false, BroadcastDomainType.Vlan, null,
null);
}
else {
+int portsPerDvPortGroup = _portsPerDvPortGroup;
+AboutInfo about = hostMo.getHostAboutInfo();
+if (about != null) {
+String version = about.getApiVersion();
Review comment:
Are the versions fixed? I mean, can't we have `4.2`, `4.3`, and so on.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rhtyd commented on issue #2376: [4.11] Smoketest Health Check
rhtyd commented on issue #2376: [4.11] Smoketest Health Check URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-388053878 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2376: [4.11] Smoketest Health Check
blueorangutan commented on issue #2376: [4.11] Smoketest Health Check URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-388053942 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2376: [4.11] Smoketest Health Check
blueorangutan commented on issue #2376: [4.11] Smoketest Health Check URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-388061785 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2042 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sureshanaparti commented on issue #2634: CLOUDSTACK-9184: Fixes #2631 VMware dvs portgroup autogrowth
sureshanaparti commented on issue #2634: CLOUDSTACK-9184: Fixes #2631 VMware dvs portgroup autogrowth URL: https://github.com/apache/cloudstack/pull/2634#issuecomment-388100897 @rhtyd No comments. Thanks for taking this up! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sureshanaparti commented on a change in pull request #2634: CLOUDSTACK-9184: Fixes #2631 VMware dvs portgroup autogrowth
sureshanaparti commented on a change in pull request #2634: CLOUDSTACK-9184:
Fixes #2631 VMware dvs portgroup autogrowth
URL: https://github.com/apache/cloudstack/pull/2634#discussion_r187379525
##
File path:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
##
@@ -394,8 +394,16 @@ private void prepareHost(HostMO hostMo, String
privateTrafficLabel) throws Excep
HypervisorHostHelper.prepareNetwork(vSwitchName, "cloud.private",
hostMo, vlanId, null, null, 18, false, BroadcastDomainType.Vlan, null,
null);
}
else {
+int portsPerDvPortGroup = _portsPerDvPortGroup;
+AboutInfo about = hostMo.getHostAboutInfo();
+if (about != null) {
+String version = about.getApiVersion();
Review comment:
@rafaelweingartner No VMware ESXi/ESX hosts with these release versions.
Take a look at the versions in the article
https://kb.vmware.com/s/article/2143832.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] sureshanaparti commented on a change in pull request #2634: CLOUDSTACK-9184: Fixes #2631 VMware dvs portgroup autogrowth
sureshanaparti commented on a change in pull request #2634: CLOUDSTACK-9184:
Fixes #2631 VMware dvs portgroup autogrowth
URL: https://github.com/apache/cloudstack/pull/2634#discussion_r187382206
##
File path:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
##
@@ -394,8 +394,16 @@ private void prepareHost(HostMO hostMo, String
privateTrafficLabel) throws Excep
HypervisorHostHelper.prepareNetwork(vSwitchName, "cloud.private",
hostMo, vlanId, null, null, 18, false, BroadcastDomainType.Vlan, null,
null);
}
else {
+int portsPerDvPortGroup = _portsPerDvPortGroup;
+AboutInfo about = hostMo.getHostAboutInfo();
+if (about != null) {
+String version = about.getApiVersion();
+if (version != null && (version.equals("4.0") ||
version.equals("4.1")) && _portsPerDvPortGroup <
DEFAULT_PORTS_PER_DV_PORT_GROUP_VSPHERE4_x) {
Review comment:
@rafaelweingartner Yes. For these versions, the default ports which is 256
shouldn't change, for the backward compatibility.
`In case of vSphere 4.1/4.0 (If used), as this feature is not there, the new
default value (=> 8) have an impact in the existing deployments. Action item
for vSphere 4.1/4.0: Admin should modify the global configuration setting
"vmware.ports.per.dvportgroup" from 8 to any number based on their environment
because the proposal default value of 8 would be very less without auto expand
feature in general. The current default value of 256 may not need immediate
modification after deployment, but 8 would be very less which means admin need
to update immediately after upgrade.`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] sureshanaparti commented on a change in pull request #2634: CLOUDSTACK-9184: Fixes #2631 VMware dvs portgroup autogrowth
sureshanaparti commented on a change in pull request #2634: CLOUDSTACK-9184:
Fixes #2631 VMware dvs portgroup autogrowth
URL: https://github.com/apache/cloudstack/pull/2634#discussion_r187382206
##
File path:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
##
@@ -394,8 +394,16 @@ private void prepareHost(HostMO hostMo, String
privateTrafficLabel) throws Excep
HypervisorHostHelper.prepareNetwork(vSwitchName, "cloud.private",
hostMo, vlanId, null, null, 18, false, BroadcastDomainType.Vlan, null,
null);
}
else {
+int portsPerDvPortGroup = _portsPerDvPortGroup;
+AboutInfo about = hostMo.getHostAboutInfo();
+if (about != null) {
+String version = about.getApiVersion();
+if (version != null && (version.equals("4.0") ||
version.equals("4.1")) && _portsPerDvPortGroup <
DEFAULT_PORTS_PER_DV_PORT_GROUP_VSPHERE4_x) {
Review comment:
@rafaelweingartner Yes. For these versions, the default ports which is 256
shouldn't change, for the backward compatibility. The below details can be
documented in the upgrade details.
`In case of vSphere 4.1/4.0 (If used), as this feature is not there, the new
default value (=> 8) have an impact in the existing deployments. Action item
for vSphere 4.1/4.0: Admin should modify the global configuration setting
"vmware.ports.per.dvportgroup" from 8 to any number based on their environment
because the proposal default value of 8 would be very less without auto expand
feature in general. The current default value of 256 may not need immediate
modification after deployment, but 8 would be very less which means admin need
to update immediately after upgrade.`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] ustcweizhou commented on issue #2635: router: Fixes #2544 run passwd server on dhcpserver IP on rVR
ustcweizhou commented on issue #2635: router: Fixes #2544 run passwd server on dhcpserver IP on rVR URL: https://github.com/apache/cloudstack/pull/2635#issuecomment-388111049 @rhtyd FYI, here is our commit for similar issue ``` if self.config.is_vpc(): ads = [o for o in self.address.get_ips() if o.needs_vrrp()] for o in ads: CsPasswdSvc(o.get_gateway()).restart() CsPasswdSvc(o.get_ip()).restart() else: interfaces = [interface for interface in self.address.get_ips() if interface.is_guest()] for interface in interfaces: CsPasswdSvc(interface.get_ip()).restart() CsPasswdSvc(self.cl.get_guest_gw()).restart() ``` the "stop" part has similar change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] khos2ow commented on issue #2613: Cleanup POMs
khos2ow commented on issue #2613: Cleanup POMs URL: https://github.com/apache/cloudstack/pull/2613#issuecomment-388118485 @rhtyd I agree, figuring out `VERSION` in `deb` packaging process is weird and totally depends on code formatting, but at the same time it's fixed within this PR (33b020319b3930ecc8cdf430789bb2fa36447de7) and generally executing `build-deb.sh` works, that's why I suspect there's something wrong with BO packaging deb (as @rafaelweingartner successfully managed to build the same artifacts himself based on the changes in this PR) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] covalle1428 commented on issue #2540: problem adding new shared network NIC to VM "A NIC with this MAC address exits for network:"
covalle1428 commented on issue #2540: problem adding new shared network NIC to VM "A NIC with this MAC address exits for network:" URL: https://github.com/apache/cloudstack/issues/2540#issuecomment-388126498 I have the same problem, I installed a fresh Cloudstack 4.11 and the same thing. Do you know how to fixed? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] GabrielBrascher commented on issue #2540: problem adding new shared network NIC to VM "A NIC with this MAC address exits for network:"
GabrielBrascher commented on issue #2540: problem adding new shared network NIC to VM "A NIC with this MAC address exits for network:" URL: https://github.com/apache/cloudstack/issues/2540#issuecomment-388131599 @covalle1428, removing the conditional as @mdesaive showed is an emergency fix; however, I am analyzing other approaches. I will cite the PR here when created. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] covalle1428 commented on issue #2540: problem adding new shared network NIC to VM "A NIC with this MAC address exits for network:"
covalle1428 commented on issue #2540: problem adding new shared network NIC to VM "A NIC with this MAC address exits for network:" URL: https://github.com/apache/cloudstack/issues/2540#issuecomment-388132267 Sorry I don't have the source package I'm installed from the .rpm normal package, how and where can remove this conditional? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] covalle1428 commented on issue #2540: problem adding new shared network NIC to VM "A NIC with this MAC address exits for network:"
covalle1428 commented on issue #2540: problem adding new shared network NIC to VM "A NIC with this MAC address exits for network:" URL: https://github.com/apache/cloudstack/issues/2540#issuecomment-388132267 Sorry I don't have the source package I'm stalled from the .rpm normal package, how and where can remove this conditional? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2629: Fix primary storage count when deleting volumes
blueorangutan commented on issue #2629: Fix primary storage count when deleting volumes URL: https://github.com/apache/cloudstack/pull/2629#issuecomment-388147798 Trillian test result (tid-2656) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 21455 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2629-t2656-kvm-centos7.zip Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py Smoke tests completed. 66 look OK, 1 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_vpc_site2site_vpn_multiple_options | `Failure` | 141.18 | test_vpc_vpn.py test_01_vpc_site2site_vpn | `Failure` | 155.06 | test_vpc_vpn.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2629: Fix primary storage count when deleting volumes
blueorangutan commented on issue #2629: Fix primary storage count when deleting volumes URL: https://github.com/apache/cloudstack/pull/2629#issuecomment-388176493 Trillian test result (tid-2655) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 6 Total time taken: 27817 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2629-t2655-xenserver-71.zip Intermitten failure detected: /marvin/tests/smoke/test_certauthority_root.py Intermitten failure detected: /marvin/tests/smoke/test_dynamicroles.py Intermitten failure detected: /marvin/tests/smoke/test_hostha_simulator.py Intermitten failure detected: /marvin/tests/smoke/test_login.py Intermitten failure detected: /marvin/tests/smoke/test_outofbandmanagement_nestedplugin.py Intermitten failure detected: /marvin/tests/smoke/test_outofbandmanagement.py Intermitten failure detected: /marvin/tests/smoke/test_primary_storage.py Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermitten failure detected: /marvin/tests/smoke/test_public_ip_range.py Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py Intermitten failure detected: /marvin/tests/smoke/test_templates.py Intermitten failure detected: /marvin/tests/smoke/test_usage.py Intermitten failure detected: /marvin/tests/smoke/test_volumes.py Smoke tests completed. 55 look OK, 12 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- login_test_saml_user | `Error` | 0.62 | test_login.py test_revoke_certificate | `Error` | 0.01 | test_certauthority_root.py test_role_account_acls_multiple_mgmt_servers | `Error` | 0.68 | test_dynamicroles.py test_configure_ha_provider_invalid | `Error` | 0.01 | test_hostha_simulator.py test_configure_ha_provider_valid | `Error` | 0.01 | test_hostha_simulator.py test_ha_configure_enabledisable_across_clusterzones | `Error` | 0.01 | test_hostha_simulator.py test_ha_disable_feature_invalid | `Error` | 0.01 | test_hostha_simulator.py test_ha_enable_feature_invalid | `Error` | 0.01 | test_hostha_simulator.py test_ha_list_providers | `Error` | 0.01 | test_hostha_simulator.py test_ha_multiple_mgmt_server_ownership | `Error` | 0.01 | test_hostha_simulator.py test_ha_verify_fsm_available | `Error` | 0.00 | test_hostha_simulator.py test_ha_verify_fsm_degraded | `Error` | 0.01 | test_hostha_simulator.py test_ha_verify_fsm_fenced | `Error` | 0.01 | test_hostha_simulator.py test_ha_verify_fsm_recovering | `Error` | 0.01 | test_hostha_simulator.py test_hostha_configure_default_driver | `Error` | 0.01 | test_hostha_simulator.py test_hostha_configure_invalid_provider | `Error` | 0.01 | test_hostha_simulator.py test_hostha_disable_feature_valid | `Error` | 0.01 | test_hostha_simulator.py test_hostha_enable_feature_valid | `Error` | 0.01 | test_hostha_simulator.py test_hostha_enable_feature_without_setting_provider | `Error` | 0.01 | test_hostha_simulator.py test_list_ha_for_host | `Error` | 0.01 | test_hostha_simulator.py test_list_ha_for_host_invalid | `Error` | 0.01 | test_hostha_simulator.py test_list_ha_for_host_valid | `Error` | 0.00 | test_hostha_simulator.py test_02_edit_primary_storage_tags | `Error` | 0.01 | test_primary_storage.py test_oobm_issue_power_cycle | `Error` | 3.48 | test_outofbandmanagement_nestedplugin.py test_oobm_issue_power_off | `Error` | 2.30 | test_outofbandmanagement_nestedplugin.py test_oobm_issue_power_on | `Error` | 3.33 | test_outofbandmanagement_nestedplugin.py test_oobm_issue_power_reset | `Error` | 2.37 | test_outofbandmanagement_nestedplugin.py test_oobm_issue_power_soft | `Error` | 3.41 | test_outofbandmanagement_nestedplugin.py test_oobm_issue_power_status | `Error` | 2.25 | test_outofbandmanagement_nestedplugin.py test_oobm_background_powerstate_sync | `Failure` | 20.49 | test_outofbandmanagement.py test_oobm_background_powerstate_sync | `Error` | 20.50 | test_outofbandmanagement.py test_oobm_configure_default_driver | `Error` | 0.05 | test_outofbandmanagement.py test_oobm_configure_invalid_driver | `Error` | 0.05 | test_outofbandmanagement.py test_oobm_disable_feature_invalid | `Error` | 0.08 | test_outofbandmanagement.py test_oobm_disable_feature_valid | `Error` | 1.17 | test_outofbandmanagement.py test_oobm_enable_feature_invalid | `Error` | 0.08 | test_outofbandmanagement.py test_oobm_enable_feature_valid | `Error` | 1.15 | test_outofbandmanagement.py test_oobm_enabledisable_across_clusterzones | `Error` | 11.98 | test_outofbandmanagement.py test_oobm_enabledisable_across_clusterzones | `Error` | 11.98 | test_outofbandmanagement.py test_oobm_issue_power_cycle | `Error` | 4.38 | test_outofbandmanagement.py test_oobm_issue_power_cycle | `Error` | 4.38 | test_outofbandmanagement.py test_o
[GitHub] rafaelweingartner opened a new pull request #2636: Fix limitation on tag matching in 'migrateVolume' with disk offering replacement
rafaelweingartner opened a new pull request #2636: Fix limitation on tag matching in 'migrateVolume' with disk offering replacement URL: https://github.com/apache/cloudstack/pull/2636 ## Description When the feature to enable disk offering replacement during volume migration was created, we were forcing the tags of the new disk offering to exact the same as the tags of the target storage poll. However, that is not how ACS manages volumes allocation. This change modifies this validation to make it consistent with volume allocation. The idea is to make the validation consistent with the mechanism used to select a storage pool to deploy a volume when a virtual machine is deployed or when a new data disk is allocated. The scenarios when this method returns true or false is presented in the following table. #Disk offering tagsStorage tagsDoes the storage support the disk offering? 1A,BANO 2A,B,CA,B,C,D,XYES 3A,B,CX,Y,ZNO 4nullA,S,DYES 5AnullNO 6nullnullYES ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [X] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## How Has This Been Tested? Locally and via unit tests that were added for the code that has been changed. ## Checklist: - [X] I have read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document. - [X] My code follows the code style of this project. - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. Testing - [X] I have added tests to cover my changes. - [X] All relevant new and existing integration tests have passed. - [ ] A full integration testsuite with all test that can run on my environment has passed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2635: router: Fixes #2544 run passwd server on dhcpserver IP on rVR
blueorangutan commented on issue #2635: router: Fixes #2544 run passwd server on dhcpserver IP on rVR URL: https://github.com/apache/cloudstack/pull/2635#issuecomment-388204068 Trillian test result (tid-2654) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 34763 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2635-t2654-kvm-centos7.zip Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py Smoke tests completed. 65 look OK, 2 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 280.78 | test_privategw_acl.py test_04_rvpc_privategw_static_routes | `Failure` | 375.74 | test_privategw_acl.py test_hostha_enable_ha_when_host_in_maintenance | `Error` | 2.45 | test_hostha_kvm.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2634: CLOUDSTACK-9184: Fixes #2631 VMware dvs portgroup autogrowth
blueorangutan commented on issue #2634: CLOUDSTACK-9184: Fixes #2631 VMware dvs portgroup autogrowth URL: https://github.com/apache/cloudstack/pull/2634#issuecomment-388205878 Trillian test result (tid-2653) Environment: vmware-65 (x2), Advanced Networking with Mgmt server 7 Total time taken: 45122 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2634-t2653-vmware-65.zip Intermitten failure detected: /marvin/tests/smoke/test_deploy_vm_iso.py Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py Smoke tests completed. 66 look OK, 1 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 2.32 | test_host_maintenance.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rafaelweingartner commented on issue #2613: Cleanup POMs
rafaelweingartner commented on issue #2613: Cleanup POMs URL: https://github.com/apache/cloudstack/pull/2613#issuecomment-388221213 I am inclined to merge this. Shall we proceed? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
