[GitHub] rhtyd opened a new issue #3155: Provide mechanism to disable TLS versions/algorithms for CloudStack server services
rhtyd opened a new issue #3155: Provide mechanism to disable TLS versions/algorithms for CloudStack server services URL: https://github.com/apache/cloudstack/issues/3155 In CloudStack secure socket-based services exists for agent server (port 8250) and jetty (8443/https). With recent limitation logged in #3140 a global fix is acceptable as a workaround however CloudStack needs to provide the mechanism (viz global settings or a commandline flag via the /etc/default/cloudstack-management) to disable TLS versions such as TLS v1.0, v1.1 etc. # ISSUE TYPE * Improvement Request # COMPONENT NAME ~~~ Management Server ~~~ # CLOUDSTACK VERSION ~~~ 4.11, 4.12 ~~~ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on a change in pull request #3154: Copy template to target KVM host if needed when migrating local <> local storage
DaanHoogland commented on a change in pull request #3154: Copy template to
target KVM host if needed when migrating local <> local storage
URL: https://github.com/apache/cloudstack/pull/3154#discussion_r251756702
##
File path:
engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
##
@@ -1859,14 +1861,21 @@ protected void setVolumePath(VolumeVO volume) {
volume.setPath(volume.get_iScsiName());
}
+/**
+ * For this strategy it is not necessary to check and migrate the
template; however, classes that extend this one may need to check if the
template is on the target storage pool (and if not then migrate) before
migrating the VM.
Review comment:
can you try to wrap this to fit in a github window?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] DaanHoogland commented on a change in pull request #3154: Copy template to target KVM host if needed when migrating local <> local storage
DaanHoogland commented on a change in pull request #3154: Copy template to
target KVM host if needed when migrating local <> local storage
URL: https://github.com/apache/cloudstack/pull/3154#discussion_r251755714
##
File path:
engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/KvmNonManagedStorageDataMotionStrategy.java
##
@@ -140,4 +160,56 @@ protected void setVolumePath(VolumeVO volume) {
protected boolean shouldMigrateVolume(StoragePoolVO sourceStoragePool,
Host destHost, StoragePoolVO destStoragePool) {
return sourceStoragePool.getPoolType() == StoragePoolType.Filesystem;
}
+
+/**
+ * If the template is not on the target primary storage then it migrates
the template.
+ * Otherwise the execution flow fails during migration and creates a null
file created on the target storage pool.
+ */
+@Override
+protected void migrateTemplateToTargetFilesystemStorageIfNeeded(VolumeInfo
srcVolumeInfo, DataStore destDataStore, StoragePool destStoragePool,
+Host destHost) {
+VMTemplateStoragePoolVO vmTemplateStoragePoolVO =
vmTemplatePoolDao.findByPoolTemplate(destStoragePool.getId(),
srcVolumeInfo.getTemplateId());
+if (vmTemplateStoragePoolVO == null && destStoragePool.getPoolType()
== StoragePoolType.Filesystem) {
+DataStore sourceTemplateDataStore =
dataStoreManagerImpl.getImageStore(srcVolumeInfo.getDataCenterId());
+TemplateInfo sourceTemplateInfo =
templateDataFactory.getTemplate(srcVolumeInfo.getTemplateId(),
sourceTemplateDataStore);
+TemplateObjectTO sourceTemplate = new
TemplateObjectTO(sourceTemplateInfo);
+
+LOGGER.debug(String.format("Could not find template [id=%s,
name=%s] on the storage pool [id=%s]; copying the template to the target
storage pool.",
+srcVolumeInfo.getTemplateId(),
sourceTemplateInfo.getName(), destDataStore.getId()));
+
+TemplateInfo destTemplateInfo =
templateDataFactory.getTemplate(srcVolumeInfo.getTemplateId(), destDataStore);
+final TemplateObjectTO destTemplate = new
TemplateObjectTO(destTemplateInfo);
+
+sendCopyCommand(destHost, sourceTemplate, destTemplate,
destDataStore);
+}
+}
+
+/**
+ * Sends the CopyCommand to migrate the template to the dest host.
+ */
+protected void sendCopyCommand(Host destHost, TemplateObjectTO
sourceTemplate, TemplateObjectTO destTemplate, DataStore destDataStore) {
+boolean executeInSequence =
virtualMachineManager.getExecuteInSequence(HypervisorType.KVM);
+CopyCommand copyCommand = new CopyCommand(sourceTemplate,
destTemplate, StorageManager.PRIMARY_STORAGE_DOWNLOAD_WAIT.value(),
executeInSequence);
+try {
+Answer copyCommandAnswer = agentManager.send(destHost.getId(),
copyCommand);
+logInCaseOfTemplateCopyFailure(copyCommandAnswer, sourceTemplate,
destDataStore);
+} catch (AgentUnavailableException | OperationTimedoutException e) {
+throw new CloudRuntimeException(String.format("Failed to copy
template [id=%s, name=%s] to the primary storage pool [id=%s].",
sourceTemplate.getId(),
+sourceTemplate.getName(), destDataStore.getId()), e);
+}
+}
+
+/**
+ * Logs in debug mode the copy command failure if the CopyCommand Answer
has result as false.
+ */
+protected void logInCaseOfTemplateCopyFailure(Answer copyCommandAnswer,
TemplateObjectTO sourceTemplate, DataStore destDataStore) {
+if (copyCommandAnswer != null && !copyCommandAnswer.getResult()) {
+String failureDetails = StringUtils.EMPTY;
+if (copyCommandAnswer.getDetails() != null) {
+failureDetails = "; details: " +
copyCommandAnswer.getDetails();
+}
+LOGGER.debug(String.format("Failed to copy template [id=%s,
name=%s] to the primary storage pool [id=%s]%s", sourceTemplate.getId(),
sourceTemplate.getName(),
Review comment:
seems like an 'ERROR' to me
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] DaanHoogland commented on a change in pull request #3154: Copy template to target KVM host if needed when migrating local <> local storage
DaanHoogland commented on a change in pull request #3154: Copy template to
target KVM host if needed when migrating local <> local storage
URL: https://github.com/apache/cloudstack/pull/3154#discussion_r251757894
##
File path:
engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
##
@@ -1859,14 +1861,21 @@ protected void setVolumePath(VolumeVO volume) {
volume.setPath(volume.get_iScsiName());
}
+/**
+ * For this strategy it is not necessary to check and migrate the
template; however, classes that extend this one may need to check if the
template is on the target storage pool (and if not then migrate) before
migrating the VM.
+ */
+protected void migrateTemplateToTargetFilesystemStorageIfNeeded(VolumeInfo
srcVolumeInfo, DataStore destDataStore, StoragePool destStoragePool, Host
destHost) {
+// This method is used by classes that extend this one
Review comment:
I am wary of this pattern. Can you explain why you implemented it this way?
It seems you are implementing a pattern for genericity while already knowing it
is only applicable for localstorage.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] DaanHoogland commented on a change in pull request #3154: Copy template to target KVM host if needed when migrating local <> local storage
DaanHoogland commented on a change in pull request #3154: Copy template to
target KVM host if needed when migrating local <> local storage
URL: https://github.com/apache/cloudstack/pull/3154#discussion_r251758952
##
File path:
engine/components-api/src/main/java/com/cloud/storage/StorageManager.java
##
@@ -101,6 +101,9 @@
ConfigKey.Scope.Cluster,
null);
+ConfigKey PRIMARY_STORAGE_DOWNLOAD_WAIT = new
ConfigKey("Storage", Integer.class, "primary.storage.download.wait",
"10800",
Review comment:
isn't such a variable already in place somewhere? there are other places
where it would have use. If not, I think it should be applied to the initial
deploy equally.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] DaanHoogland commented on a change in pull request #3154: Copy template to target KVM host if needed when migrating local <> local storage
DaanHoogland commented on a change in pull request #3154: Copy template to
target KVM host if needed when migrating local <> local storage
URL: https://github.com/apache/cloudstack/pull/3154#discussion_r251756332
##
File path:
engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/KvmNonManagedStorageDataMotionStrategy.java
##
@@ -140,4 +160,56 @@ protected void setVolumePath(VolumeVO volume) {
protected boolean shouldMigrateVolume(StoragePoolVO sourceStoragePool,
Host destHost, StoragePoolVO destStoragePool) {
return sourceStoragePool.getPoolType() == StoragePoolType.Filesystem;
}
+
+/**
+ * If the template is not on the target primary storage then it migrates
the template.
+ * Otherwise the execution flow fails during migration and creates a null
file created on the target storage pool.
+ */
+@Override
+protected void migrateTemplateToTargetFilesystemStorageIfNeeded(VolumeInfo
srcVolumeInfo, DataStore destDataStore, StoragePool destStoragePool,
+Host destHost) {
+VMTemplateStoragePoolVO vmTemplateStoragePoolVO =
vmTemplatePoolDao.findByPoolTemplate(destStoragePool.getId(),
srcVolumeInfo.getTemplateId());
+if (vmTemplateStoragePoolVO == null && destStoragePool.getPoolType()
== StoragePoolType.Filesystem) {
+DataStore sourceTemplateDataStore =
dataStoreManagerImpl.getImageStore(srcVolumeInfo.getDataCenterId());
+TemplateInfo sourceTemplateInfo =
templateDataFactory.getTemplate(srcVolumeInfo.getTemplateId(),
sourceTemplateDataStore);
+TemplateObjectTO sourceTemplate = new
TemplateObjectTO(sourceTemplateInfo);
+
+LOGGER.debug(String.format("Could not find template [id=%s,
name=%s] on the storage pool [id=%s]; copying the template to the target
storage pool.",
+srcVolumeInfo.getTemplateId(),
sourceTemplateInfo.getName(), destDataStore.getId()));
+
+TemplateInfo destTemplateInfo =
templateDataFactory.getTemplate(srcVolumeInfo.getTemplateId(), destDataStore);
+final TemplateObjectTO destTemplate = new
TemplateObjectTO(destTemplateInfo);
+
+sendCopyCommand(destHost, sourceTemplate, destTemplate,
destDataStore);
+}
+}
+
+/**
+ * Sends the CopyCommand to migrate the template to the dest host.
+ */
+protected void sendCopyCommand(Host destHost, TemplateObjectTO
sourceTemplate, TemplateObjectTO destTemplate, DataStore destDataStore) {
+boolean executeInSequence =
virtualMachineManager.getExecuteInSequence(HypervisorType.KVM);
+CopyCommand copyCommand = new CopyCommand(sourceTemplate,
destTemplate, StorageManager.PRIMARY_STORAGE_DOWNLOAD_WAIT.value(),
executeInSequence);
+try {
+Answer copyCommandAnswer = agentManager.send(destHost.getId(),
copyCommand);
+logInCaseOfTemplateCopyFailure(copyCommandAnswer, sourceTemplate,
destDataStore);
+} catch (AgentUnavailableException | OperationTimedoutException e) {
+throw new CloudRuntimeException(String.format("Failed to copy
template [id=%s, name=%s] to the primary storage pool [id=%s].",
sourceTemplate.getId(),
Review comment:
why is this string constructed twice, here and in below
logInCaseOfTemplateCopyFailure()?
they seem to describe the exact same thing
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] DaanHoogland commented on a change in pull request #3154: Copy template to target KVM host if needed when migrating local <> local storage
DaanHoogland commented on a change in pull request #3154: Copy template to
target KVM host if needed when migrating local <> local storage
URL: https://github.com/apache/cloudstack/pull/3154#discussion_r251754196
##
File path:
engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/KvmNonManagedStorageDataMotionStrategy.java
##
@@ -140,4 +160,56 @@ protected void setVolumePath(VolumeVO volume) {
protected boolean shouldMigrateVolume(StoragePoolVO sourceStoragePool,
Host destHost, StoragePoolVO destStoragePool) {
return sourceStoragePool.getPoolType() == StoragePoolType.Filesystem;
}
+
+/**
+ * If the template is not on the target primary storage then it migrates
the template.
+ * Otherwise the execution flow fails during migration and creates a null
file created on the target storage pool.
Review comment:
this comments confuses me. you wrote in the description that the template
would be copied and this problem would no longer be there. if that is true this
"Otherwise ..." is not true or badly formulated. Can you explain?
As it is written now it seems that the condition after "Otherwise" can still
occur.
If I understand this correctly you should start with "If we don't do this
...", or "This is needed to prevent ...". Am I correct?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991)
DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-458476655 @rafaelweingartner I would like to merge this and build on it. I have not seen any follow up. can you expand or comply? /cc @GabrielBrascher This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] marcaurele commented on issue #2578: api: add command to list management servers
marcaurele commented on issue #2578: api: add command to list management servers URL: https://github.com/apache/cloudstack/pull/2578#issuecomment-458495456 Sorry guys, but I don't have anymore much time to continue rebasing my code as it's not going through quick enough to avoid new conflicts. thanks @DaanHoogland to take over. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #3154: Copy template to target KVM host if needed when migrating local <> local storage
blueorangutan commented on issue #3154: Copy template to target KVM host if needed when migrating local <> local storage URL: https://github.com/apache/cloudstack/pull/3154#issuecomment-458502719 Trillian test result (tid-3353) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 29187 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3154-t3353-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_primary_storage.py Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py Smoke tests completed. 66 look OK, 4 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_add_primary_storage_disabled_host | `Error` | 0.89 | test_primary_storage.py test_01_primary_storage_nfs | `Error` | 0.15 | test_primary_storage.py ContextSuite context=TestStorageTags>:setup | `Error` | 0.26 | test_primary_storage.py test_02_list_snapshots_with_removed_data_store | `Error` | 1.17 | test_snapshots.py test_11_migrate_vm | `Error` | 19.01 | test_vm_life_cycle.py test_14_secure_to_secure_vm_migration | `Error` | 61.78 | test_vm_life_cycle.py test_01_cancel_host_maintenace_with_no_migration_jobs | `Failure` | 0.14 | test_host_maintenance.py test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 2.40 | test_host_maintenance.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rafaelweingartner commented on issue #2992: PoC for log library surface reduction (2991)
rafaelweingartner commented on issue #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-458504854 @DaanHoogland I have not had free time to work on these things lately. I also do not see the benefits of this PR. But, besides that, master is on freeze, and we are working to release 4.12. Therefore, this PR has to wait in one way or the other. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2311: CLOUDSTACK-10134 Optimization of applying port forwarding rules
blueorangutan commented on issue #2311: CLOUDSTACK-10134 Optimization of applying port forwarding rules URL: https://github.com/apache/cloudstack/pull/2311#issuecomment-458509667 Trillian test result (tid-3356) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 21993 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2311-t3356-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_network.py Smoke tests completed. 69 look OK, 1 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_network_rules_acquired_public_ip_1_static_nat_rule | `Error` | 5.33 | test_network.py test_network_rules_acquired_public_ip_2_nat_rule | `Error` | 6.33 | test_network.py test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | `Error` | 6.33 | test_network.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] GabrielBrascher commented on a change in pull request #3154: Copy template to target KVM host if needed when migrating local <> local storage
GabrielBrascher commented on a change in pull request #3154: Copy template to
target KVM host if needed when migrating local <> local storage
URL: https://github.com/apache/cloudstack/pull/3154#discussion_r251802867
##
File path:
engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
##
@@ -1859,14 +1861,21 @@ protected void setVolumePath(VolumeVO volume) {
volume.setPath(volume.get_iScsiName());
}
+/**
+ * For this strategy it is not necessary to check and migrate the
template; however, classes that extend this one may need to check if the
template is on the target storage pool (and if not then migrate) before
migrating the VM.
+ */
+protected void migrateTemplateToTargetFilesystemStorageIfNeeded(VolumeInfo
srcVolumeInfo, DataStore destDataStore, StoragePool destStoragePool, Host
destHost) {
+// This method is used by classes that extend this one
Review comment:
@DaanHoogland The class KvmNonManagedStorageDataMotionStrategy was
implemented extending the StorageSystemDataMotionStrategy and adding methods
such as this one in the superclass execution flow. This was the best that I
could think regarding using the current architecture and easying future
maintenance and extensions. Ideally, we should refactor this class structure
and use proper O.O. However, that was not a simple task, and as such I think it
is best executed separated from any new feature introduction.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] blueorangutan commented on issue #3133: feature: add libvirt / qemu io bursting
blueorangutan commented on issue #3133: feature: add libvirt / qemu io bursting URL: https://github.com/apache/cloudstack/pull/3133#issuecomment-458518031 Trillian test result (tid-3355) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 23981 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3133-t3355-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_disk_offerings.py Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Smoke tests completed. 68 look OK, 2 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_05_create_burst_type_disk_offering | `Error` | 0.01 | test_disk_offerings.py test_02_create_iops_offering | `Error` | 0.01 | test_service_offerings.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #3151: api: rename ListUsageRecords file name to ListUsageRecordsCmd
blueorangutan commented on issue #3151: api: rename ListUsageRecords file name to ListUsageRecordsCmd URL: https://github.com/apache/cloudstack/pull/3151#issuecomment-458519174 Trillian test result (tid-3354) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 24615 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3151-t3354-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py Smoke tests completed. 70 look OK, 0 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on issue #2578: api: add command to list management servers
DaanHoogland commented on issue #2578: api: add command to list management servers URL: https://github.com/apache/cloudstack/pull/2578#issuecomment-458519953 no worries @marcaurele , I know you changed focus and it is all but done. thanks for much good cooperative work over the years :+1: This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991)
DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-458520776 > But, besides that, master is on freeze, and we are working to release 4.12. Therefore, this PR has to wait in one way or the other. It was in way before the freeze so I don't see why it has to wait. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991)
DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-458521354 > I also do not see the benefits of this PR. It makes no sense not isolating dependencies and reducing surface area and this is just the most trivial example of that. I have given the benefits of such a way of working. What part do you disagree on? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland edited a comment on issue #2992: PoC for log library surface reduction (2991)
DaanHoogland edited a comment on issue #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-458521354 > I also do not see the benefits of this PR. It makes no sense not isolating dependencies and reducing surface area and this is just the most trivial example of that. I have given the benefits of such a way of working. What part do you disagree on? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991)
DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-458521892 > @rafaelweingartner I would like to merge this and build on it. > @DaanHoogland I have not had free time to work on these things lately. I am making time to build on this and am not asking you to. We do need to agree on the way forward, though. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rafaelweingartner commented on issue #2992: PoC for log library surface reduction (2991)
rafaelweingartner commented on issue #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-458522967 I do know you are not asking my help ;) The part I disagree with is the method used to do the so called "reduction of the surface of change". There are other alternatives, which in my opinion work better. I tried to explain, but I do not think you understood what I meant. Therefore, I tried to create an example for you, but I have also not been able to finish it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991)
DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-458525484 ok, then let me urge to give this priority. We are using antiquated libraries, as in out of service -, out of support libraries and moving forward will not get easier over time. If you method is the scripting search and replace of all methods used, I am afraid this is just a one of solution and not an architectural pattern for future stability. Please enlighten me because indeed I do not understand the alternative to be viable. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] GabrielBrascher commented on issue #2992: PoC for log library surface reduction (2991)
GabrielBrascher commented on issue #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-458524918 @DaanHoogland thanks for the initiative! There are still open concerns to address and to be fair, now that I had some time to review it, I am sharing the same thoughts of Rafael. I will be happy to assist in reviewing deep further and discussing different approaches; however, considering our tight schedule and the lack of reviewers, I am afraid that this one will have to wait for the freeze. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] GabrielBrascher commented on issue #3133: feature: add libvirt / qemu io bursting
GabrielBrascher commented on issue #3133: feature: add libvirt / qemu io bursting URL: https://github.com/apache/cloudstack/pull/3133#issuecomment-458527465 @nathanejohnson tests `test_05_create_burst_type_disk_offering` and `test_02_create_iops_offering` are failing. I am not sure what is causing it but they seem related to this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] GabrielBrascher commented on issue #2983: KVM live storage migration intra cluster from NFS source and destination
GabrielBrascher commented on issue #2983: KVM live storage migration intra cluster from NFS source and destination URL: https://github.com/apache/cloudstack/pull/2983#issuecomment-458531422 @rhtyd the schedule is getting tight indeed, but I think that we can still merge this one. Reviews are looking good and overall the code is OK. If tests pass (they are looking good) and we have this PR stable, I have no concerns in merging it on 4.12.0.0. Said that, could you please fix the conflicting file? Thanks! The bigger issue that I see here (and also on my PRs #3154 and #2997) is the whole architecture as it is. As I mentioned in #3154, using the KvmNonManagedStorageDataMotionStrategy was the best that I could think regarding using the current architecture and easying future maintenance and extensions. Ideally, we should refactor this class structure and use proper O.O. However, this is not a simple task, and as such, I think it is best executed separated from any new feature introduction. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] GabrielBrascher commented on issue #2992: PoC for log library surface reduction (2991)
GabrielBrascher commented on issue #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-458536820 I totally agree with you @DaanHoogland, this is an issue to give priority and as soon as we have 4.12.0.0 released this should be one of the priorities among all the CloudStack refactoring efforts. Unfortunately, I think that for this release it is still a bit raw. I would like to add that our next LTS should be delivered this year to cover the 4.11 end of life (1 July 2019) [1]. I was absent on this discussions so far but will address some effort as well to help on getting rid of all the antiquated libraries on time to merge into the next LTS. [1] https://cwiki.apache.org/confluence/display/CLOUDSTACK/LTS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] GabrielBrascher commented on a change in pull request #3154: Copy template to target KVM host if needed when migrating local <> local storage
GabrielBrascher commented on a change in pull request #3154: Copy template to
target KVM host if needed when migrating local <> local storage
URL: https://github.com/apache/cloudstack/pull/3154#discussion_r251835476
##
File path:
engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/KvmNonManagedStorageDataMotionStrategy.java
##
@@ -140,4 +160,56 @@ protected void setVolumePath(VolumeVO volume) {
protected boolean shouldMigrateVolume(StoragePoolVO sourceStoragePool,
Host destHost, StoragePoolVO destStoragePool) {
return sourceStoragePool.getPoolType() == StoragePoolType.Filesystem;
}
+
+/**
+ * If the template is not on the target primary storage then it migrates
the template.
+ * Otherwise the execution flow fails during migration and creates a null
file created on the target storage pool.
Review comment:
You are right @DaanHoogland. I will remove the `Otherwise the execution flow
fails during migration and creates a null file created on the target storage
pool.` from the Javadoc and leave just the `If the template is not on the
target primary storage then it migrates the template.`. Thanks for pointing it!
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] GabrielBrascher commented on a change in pull request #3154: Copy template to target KVM host if needed when migrating local <> local storage
GabrielBrascher commented on a change in pull request #3154: Copy template to
target KVM host if needed when migrating local <> local storage
URL: https://github.com/apache/cloudstack/pull/3154#discussion_r251835852
##
File path:
engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/KvmNonManagedStorageDataMotionStrategy.java
##
@@ -140,4 +160,56 @@ protected void setVolumePath(VolumeVO volume) {
protected boolean shouldMigrateVolume(StoragePoolVO sourceStoragePool,
Host destHost, StoragePoolVO destStoragePool) {
return sourceStoragePool.getPoolType() == StoragePoolType.Filesystem;
}
+
+/**
+ * If the template is not on the target primary storage then it migrates
the template.
+ * Otherwise the execution flow fails during migration and creates a null
file created on the target storage pool.
+ */
+@Override
+protected void migrateTemplateToTargetFilesystemStorageIfNeeded(VolumeInfo
srcVolumeInfo, DataStore destDataStore, StoragePool destStoragePool,
+Host destHost) {
+VMTemplateStoragePoolVO vmTemplateStoragePoolVO =
vmTemplatePoolDao.findByPoolTemplate(destStoragePool.getId(),
srcVolumeInfo.getTemplateId());
+if (vmTemplateStoragePoolVO == null && destStoragePool.getPoolType()
== StoragePoolType.Filesystem) {
+DataStore sourceTemplateDataStore =
dataStoreManagerImpl.getImageStore(srcVolumeInfo.getDataCenterId());
+TemplateInfo sourceTemplateInfo =
templateDataFactory.getTemplate(srcVolumeInfo.getTemplateId(),
sourceTemplateDataStore);
+TemplateObjectTO sourceTemplate = new
TemplateObjectTO(sourceTemplateInfo);
+
+LOGGER.debug(String.format("Could not find template [id=%s,
name=%s] on the storage pool [id=%s]; copying the template to the target
storage pool.",
+srcVolumeInfo.getTemplateId(),
sourceTemplateInfo.getName(), destDataStore.getId()));
+
+TemplateInfo destTemplateInfo =
templateDataFactory.getTemplate(srcVolumeInfo.getTemplateId(), destDataStore);
+final TemplateObjectTO destTemplate = new
TemplateObjectTO(destTemplateInfo);
+
+sendCopyCommand(destHost, sourceTemplate, destTemplate,
destDataStore);
+}
+}
+
+/**
+ * Sends the CopyCommand to migrate the template to the dest host.
+ */
+protected void sendCopyCommand(Host destHost, TemplateObjectTO
sourceTemplate, TemplateObjectTO destTemplate, DataStore destDataStore) {
+boolean executeInSequence =
virtualMachineManager.getExecuteInSequence(HypervisorType.KVM);
+CopyCommand copyCommand = new CopyCommand(sourceTemplate,
destTemplate, StorageManager.PRIMARY_STORAGE_DOWNLOAD_WAIT.value(),
executeInSequence);
+try {
+Answer copyCommandAnswer = agentManager.send(destHost.getId(),
copyCommand);
+logInCaseOfTemplateCopyFailure(copyCommandAnswer, sourceTemplate,
destDataStore);
+} catch (AgentUnavailableException | OperationTimedoutException e) {
+throw new CloudRuntimeException(String.format("Failed to copy
template [id=%s, name=%s] to the primary storage pool [id=%s].",
sourceTemplate.getId(),
+sourceTemplate.getName(), destDataStore.getId()), e);
+}
+}
+
+/**
+ * Logs in debug mode the copy command failure if the CopyCommand Answer
has result as false.
+ */
+protected void logInCaseOfTemplateCopyFailure(Answer copyCommandAnswer,
TemplateObjectTO sourceTemplate, DataStore destDataStore) {
+if (copyCommandAnswer != null && !copyCommandAnswer.getResult()) {
+String failureDetails = StringUtils.EMPTY;
+if (copyCommandAnswer.getDetails() != null) {
+failureDetails = "; details: " +
copyCommandAnswer.getDetails();
+}
+LOGGER.debug(String.format("Failed to copy template [id=%s,
name=%s] to the primary storage pool [id=%s]%s", sourceTemplate.getId(),
sourceTemplate.getName(),
Review comment:
I will update this to 'ERROR' I will also extract it to a method that
returns the message, avoiding duplicated code.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] GabrielBrascher commented on a change in pull request #3154: Copy template to target KVM host if needed when migrating local <> local storage
GabrielBrascher commented on a change in pull request #3154: Copy template to
target KVM host if needed when migrating local <> local storage
URL: https://github.com/apache/cloudstack/pull/3154#discussion_r251837373
##
File path:
engine/components-api/src/main/java/com/cloud/storage/StorageManager.java
##
@@ -101,6 +101,9 @@
ConfigKey.Scope.Cluster,
null);
+ConfigKey PRIMARY_STORAGE_DOWNLOAD_WAIT = new
ConfigKey("Storage", Integer.class, "primary.storage.download.wait",
"10800",
Review comment:
`Config.PrimaryStorageDownloadWait` has this configuration indeed.
I can pick from there then and removed this one. However, on the other hand,
`Config.PrimaryStorageDownloadWait` is deprecated. Should I use
`Config.PrimaryStorageDownloadWait`, or remove the
`Config.PrimaryStorageDownloadWait` and keep with the `new
ConfigKey...`?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] GabrielBrascher edited a comment on issue #3154: Copy template to target KVM host if needed when migrating local <> local storage
GabrielBrascher edited a comment on issue #3154: Copy template to target KVM host if needed when migrating local <> local storage URL: https://github.com/apache/cloudstack/pull/3154#issuecomment-458545058 @DaanHoogland I will ping you when updating the code. Thanks for the review! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] GabrielBrascher commented on issue #3154: Copy template to target KVM host if needed when migrating local <> local storage
GabrielBrascher commented on issue #3154: Copy template to target KVM host if needed when migrating local <> local storage URL: https://github.com/apache/cloudstack/pull/3154#issuecomment-458545058 @DaanHoogland I will ping when updating the code. Thanks for the review! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] GabrielBrascher commented on issue #2311: CLOUDSTACK-10134 Optimization of applying port forwarding rules
GabrielBrascher commented on issue #2311: CLOUDSTACK-10134 Optimization of applying port forwarding rules URL: https://github.com/apache/cloudstack/pull/2311#issuecomment-458546233 Thanks for the information @rhtyd. It looks like this PR will not make on time for 4.12.0.0 then. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DagSonsteboSB opened a new issue #3156: VMware standard vSwitch port group configuration when ESXi host is added to CloudStack
DagSonsteboSB opened a new issue #3156: VMware standard vSwitch port group configuration when ESXi host is added to CloudStack URL: https://github.com/apache/cloudstack/issues/3156 # ISSUE TYPE * Improvement Request # COMPONENT NAME * VMware vSphere / ESXi under CloudStack # CLOUDSTACK VERSION * Any * Tested in CloudStack 4.9 and 4.11 # CONFIGURATION * New ESXi host being added to existing cluster # OS / ENVIRONMENT * Any # SUMMARY * A newly added ESXi host added to an existing ESXi cluster utilising standard vSwitches will come online without any port group configuration. * Port groups are added when a VR and / or VM is started on that host * However if VMware native HA is utilised and an HA even occurs then a non-configured host can be chosen as failover destination without CloudStack being in the decision chain. At that point VMs will fail to fall over. * The scenario is not unfeasible - it is not uncommon to either rebuild a host or introduce a new host as part of a a HA scenario. A repeat of the HA event will then lead to VMs being left offline. Suggested solution: * Upon ESXi host addition the existing cluster should be checked for port group configurations, and all required port groups configured on the new ESXi host. # STEPS TO REPRODUCE * Configure a native HA VMware vSphere cluster in CloudStack. * Put all hosts apart from one into maintenance mode. * Now add a brand new, unconfigured host into the cluster. * Power down the remaining ESXi host with running VMs out of band / pull power / ungracefully shut it down. * Monitor the native VMware HA failover. * VMs will fail to migrate to the newly configured host. # EXPECTED RESULTS * Once added to a CloudStack managed cluster all ESXi hosts should be configured and ready to take on workloads, even if these are triggered out-of-band from CloudStack. # ACTUAL RESULTS * HA failover to unconfigured host will fail. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rafaelweingartner commented on issue #2992: PoC for log library surface reduction (2991)
rafaelweingartner commented on issue #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-458587891 @DaanHoogland on a second thought. Feel free to do what you would like here ;) I think I gave a -1, but I will not be able to finish what I started to show you. Therefore, I hereby remove it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] GabrielBrascher commented on issue #2992: PoC for log library surface reduction (2991)
GabrielBrascher commented on issue #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-458590758 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2992: PoC for log library surface reduction (2991)
blueorangutan commented on issue #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-458590886 @GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2983: KVM live storage migration intra cluster from NFS source and destination
rhtyd commented on issue #2983: KVM live storage migration intra cluster from NFS source and destination URL: https://github.com/apache/cloudstack/pull/2983#issuecomment-458596063 @GabrielBrascher thanks, I'll get the conflict by tomorrow and kick a final round of tests. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2992: PoC for log library surface reduction (2991)
blueorangutan commented on issue #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-458601049 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2577 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] GabrielBrascher commented on issue #2992: PoC for log library surface reduction (2991)
GabrielBrascher commented on issue #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-458605333 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2992: PoC for log library surface reduction (2991)
blueorangutan commented on issue #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-458605728 @GabrielBrascher a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sureshanaparti commented on issue #3156: VMware standard vSwitch port group configuration when ESXi host is added to CloudStack
sureshanaparti commented on issue #3156: VMware standard vSwitch port group configuration when ESXi host is added to CloudStack URL: https://github.com/apache/cloudstack/issues/3156#issuecomment-458610051 This PR https://github.com/apache/cloudstack/pull/1257 addresses similar issue and is verified. Newly added host in the existing cluster doesn't participate in cluster HA and DRS in VMware. Solution: The port groups of the existing oldest host were added to the newly added host, making the new host compatible for VMware cluster HA and DRS. I'll resolve conflicts and rebase. What is the planned target branch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sureshanaparti commented on issue #1257: CLOUDSTACK-9175: [VMware DRS] Adding new host to DRS cluster does not participate in load balancing.
sureshanaparti commented on issue #1257: CLOUDSTACK-9175: [VMware DRS] Adding new host to DRS cluster does not participate in load balancing. URL: https://github.com/apache/cloudstack/pull/1257#issuecomment-458612004 @rhtyd These changes are working and well tested. All the comments were addressed long back. This will resolve issue mentioned in https://github.com/apache/cloudstack/issues/3156. Please let me know the target branch for this PR. I'll rebase against the branch. Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #1257: CLOUDSTACK-9175: [VMware DRS] Adding new host to DRS cluster does not participate in load balancing.
rhtyd commented on issue #1257: CLOUDSTACK-9175: [VMware DRS] Adding new host to DRS cluster does not participate in load balancing. URL: https://github.com/apache/cloudstack/pull/1257#issuecomment-458613501 @sureshanaparti alright, ping me when you've rebased the branch. I can help run tests on it and review it, thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sureshanaparti commented on issue #1257: CLOUDSTACK-9175: [VMware DRS] Adding new host to DRS cluster does not participate in load balancing.
sureshanaparti commented on issue #1257: CLOUDSTACK-9175: [VMware DRS] Adding new host to DRS cluster does not participate in load balancing. URL: https://github.com/apache/cloudstack/pull/1257#issuecomment-458614345 > @sureshanaparti alright, ping me when you've rebased the branch. I can help run tests on it and review it, thanks. which branch to rebase? master or 4.12? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991)
DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-458615431 @rafaelweingartner I saw you IM comment and will look into what a spring suit would mean for logging. more later This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #1257: CLOUDSTACK-9175: [VMware DRS] Adding new host to DRS cluster does not participate in load balancing.
rhtyd commented on issue #1257: CLOUDSTACK-9175: [VMware DRS] Adding new host to DRS cluster does not participate in load balancing. URL: https://github.com/apache/cloudstack/pull/1257#issuecomment-458615686 @sureshanaparti up to you, if you think this is a bugfix then send to 4.11, otherwise rebase against master. There is no 4.12 branch yet. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sureshanaparti commented on issue #1257: CLOUDSTACK-9175: [VMware DRS] Adding new host to DRS cluster does not participate in load balancing.
sureshanaparti commented on issue #1257: CLOUDSTACK-9175: [VMware DRS] Adding new host to DRS cluster does not participate in load balancing. URL: https://github.com/apache/cloudstack/pull/1257#issuecomment-458618780 @rhtyd sure. thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] GabrielBrascher commented on issue #3150: api: add command to list management servers
GabrielBrascher commented on issue #3150: api: add command to list management servers URL: https://github.com/apache/cloudstack/pull/3150#issuecomment-458621468 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #3150: api: add command to list management servers
blueorangutan commented on issue #3150: api: add command to list management servers URL: https://github.com/apache/cloudstack/pull/3150#issuecomment-458621538 @GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sureshanaparti commented on a change in pull request #2983: KVM live storage migration intra cluster from NFS source and destination
sureshanaparti commented on a change in pull request #2983: KVM live storage
migration intra cluster from NFS source and destination
URL: https://github.com/apache/cloudstack/pull/2983#discussion_r251934864
##
File path:
engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
##
@@ -253,18 +262,64 @@ private boolean canHandle(DataObject dataObject) {
return false;
}
+/**
+ * True if volumes source storage are NFS
+ */
Review comment:
@nvazquez The below method returns true when the first NFS pool of a volume
found in the given volumes list. Is that the intent? or it has to check all the
volumes with NFS pool?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] sureshanaparti commented on a change in pull request #2983: KVM live storage migration intra cluster from NFS source and destination
sureshanaparti commented on a change in pull request #2983: KVM live storage
migration intra cluster from NFS source and destination
URL: https://github.com/apache/cloudstack/pull/2983#discussion_r251935914
##
File path:
engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
##
@@ -253,18 +262,64 @@ private boolean canHandle(DataObject dataObject) {
return false;
}
+/**
+ * True if volumes source storage are NFS
+ */
+protected boolean isSourceNfsPrimaryStorage(Map
volumeMap) {
Review comment:
@nvazquez The datastores in the Map is unused. Better the volumes list as
input here.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] blueorangutan commented on issue #3150: api: add command to list management servers
blueorangutan commented on issue #3150: api: add command to list management servers URL: https://github.com/apache/cloudstack/pull/3150#issuecomment-458630524 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2578 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sureshanaparti commented on a change in pull request #2983: KVM live storage migration intra cluster from NFS source and destination
sureshanaparti commented on a change in pull request #2983: KVM live storage
migration intra cluster from NFS source and destination
URL: https://github.com/apache/cloudstack/pull/2983#discussion_r251937207
##
File path:
engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
##
@@ -253,18 +262,64 @@ private boolean canHandle(DataObject dataObject) {
return false;
}
+/**
+ * True if volumes source storage are NFS
+ */
+protected boolean isSourceNfsPrimaryStorage(Map
volumeMap) {
+if (MapUtils.isNotEmpty(volumeMap)) {
+for (VolumeInfo volumeInfo : volumeMap.keySet()) {
+StoragePoolVO storagePoolVO =
_storagePoolDao.findById(volumeInfo.getPoolId());
+return storagePoolVO != null &&
+storagePoolVO.getPoolType() ==
Storage.StoragePoolType.NetworkFilesystem;
+}
+}
+return false;
+}
+
+/**
+ * True if destination storage is cluster-wide NFS
Review comment:
@nvazquez The below method is true when the first cluster wide NFS pool is
found from the given primary pools list. Is that the intent? or all pools have
to be cluster-wide NFS pools?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] sureshanaparti commented on a change in pull request #2983: KVM live storage migration intra cluster from NFS source and destination
sureshanaparti commented on a change in pull request #2983: KVM live storage
migration intra cluster from NFS source and destination
URL: https://github.com/apache/cloudstack/pull/2983#discussion_r251937530
##
File path:
engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
##
@@ -253,18 +262,64 @@ private boolean canHandle(DataObject dataObject) {
return false;
}
+/**
+ * True if volumes source storage are NFS
+ */
+protected boolean isSourceNfsPrimaryStorage(Map
volumeMap) {
+if (MapUtils.isNotEmpty(volumeMap)) {
+for (VolumeInfo volumeInfo : volumeMap.keySet()) {
+StoragePoolVO storagePoolVO =
_storagePoolDao.findById(volumeInfo.getPoolId());
+return storagePoolVO != null &&
+storagePoolVO.getPoolType() ==
Storage.StoragePoolType.NetworkFilesystem;
+}
+}
+return false;
+}
+
+/**
+ * True if destination storage is cluster-wide NFS
+ */
+protected boolean
isDestinationNfsPrimaryStorageClusterWide(Map volumeMap)
{
Review comment:
@nvazquez The volume info in the Map is unused. Better pass pools list as
input here.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] sureshanaparti commented on a change in pull request #2983: KVM live storage migration intra cluster from NFS source and destination
sureshanaparti commented on a change in pull request #2983: KVM live storage
migration intra cluster from NFS source and destination
URL: https://github.com/apache/cloudstack/pull/2983#discussion_r251935914
##
File path:
engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
##
@@ -253,18 +262,64 @@ private boolean canHandle(DataObject dataObject) {
return false;
}
+/**
+ * True if volumes source storage are NFS
+ */
+protected boolean isSourceNfsPrimaryStorage(Map
volumeMap) {
Review comment:
@nvazquez The datastores in the Map is unused. Better use volumes list as
input here.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] nathanejohnson commented on issue #3133: feature: add libvirt / qemu io bursting
nathanejohnson commented on issue #3133: feature: add libvirt / qemu io bursting URL: https://github.com/apache/cloudstack/pull/3133#issuecomment-458641564 @GabrielBrascher this error seems to be occurring because blue orangutan doesn't have the marvin version that would have been created by this PR. it included an updated configuration, and the "ioburst" key is missing. Maybe someone from shape blue could weigh in? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] richardlawley opened a new issue #3157: CentOS 6 Repo not updated for 4.11.2 GA
richardlawley opened a new issue #3157: CentOS 6 Repo not updated for 4.11.2 GA URL: https://github.com/apache/cloudstack/issues/3157 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ CentOS 6 Yum Repo ~~~ # CLOUDSTACK VERSION ~~~ 4.11.2 ~~~ # CONFIGURATION n/a # OS / ENVIRONMENT CentOS 6 # SUMMARY The version of CloudStack available from http://download.cloudstack.org/centos/6/4.11/ is 4.11.2-rc5, not the GA version. # STEPS TO REPRODUCE ~~~ cat < /etc/yum.repos.d/cloudstack.repo [apache-cloudstack] name=Apache CloudStack baseurl=http://download.cloudstack.org/centos/$releasever/4.11/ enabled=1 gpgcheck=0 EOF yum info cloudstack-management ~~~ # EXPECTED RESULTS Release should be 1.el6 # ACTUAL RESULTS ~~~ # yum info cloudstack-management Loaded plugins: fastestmirror Loading mirror speeds from cached hostfile * base: mirrors.vooservers.com * extras: mirror.bytemark.co.uk * updates: mirrors.vooservers.com Installed Packages Name: cloudstack-management Arch: x86_64 Version : 4.11.2.0 Release : rc5.el6 Size: 100 M Repo: installed From repo : cloudstack Summary : CloudStack management server UI License : ASL 2.0 Description : The CloudStack management server is the central point of coordination, : management, and intelligence in CloudStack. ~~~ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] GabrielBrascher commented on issue #3150: api: add command to list management servers
GabrielBrascher commented on issue #3150: api: add command to list management servers URL: https://github.com/apache/cloudstack/pull/3150#issuecomment-458655358 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #3150: api: add command to list management servers
blueorangutan commented on issue #3150: api: add command to list management servers URL: https://github.com/apache/cloudstack/pull/3150#issuecomment-458655659 @GabrielBrascher a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland edited a comment on issue #2992: PoC for log library surface reduction (2991)
DaanHoogland edited a comment on issue #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-458615431 @rafaelweingartner I saw you IM comment and will look into what implementing logging like in spring would mean for our logging. more later This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2992: PoC for log library surface reduction (2991)
blueorangutan commented on issue #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-458769118 Trillian test result (tid-3357) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 29187 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2992-t3357-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_primary_storage.py Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py Smoke tests completed. 65 look OK, 5 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_add_primary_storage_disabled_host | `Error` | 0.91 | test_primary_storage.py test_01_primary_storage_nfs | `Error` | 0.14 | test_primary_storage.py ContextSuite context=TestStorageTags>:setup | `Error` | 0.25 | test_primary_storage.py test_02_list_snapshots_with_removed_data_store | `Error` | 1.17 | test_snapshots.py test_11_migrate_vm | `Error` | 19.00 | test_vm_life_cycle.py test_14_secure_to_secure_vm_migration | `Error` | 62.84 | test_vm_life_cycle.py test_01_cancel_host_maintenace_with_no_migration_jobs | `Failure` | 0.12 | test_host_maintenance.py test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 2.34 | test_host_maintenance.py test_hostha_kvm_host_degraded | `Failure` | 664.27 | test_hostha_kvm.py test_hostha_kvm_host_fencing | `Failure` | 620.28 | test_hostha_kvm.py test_hostha_kvm_host_recovering | `Failure` | 623.50 | test_hostha_kvm.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #3150: api: add command to list management servers
blueorangutan commented on issue #3150: api: add command to list management servers URL: https://github.com/apache/cloudstack/pull/3150#issuecomment-458772348 Trillian test result (tid-3358) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 22119 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3150-t3358-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py Smoke tests completed. 70 look OK, 0 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
