[GitHub] [cloudstack] ustcweizhou commented on a change in pull request #3335: kvm: disable cpu features if feature starts with '-'
ustcweizhou commented on a change in pull request #3335: kvm: disable cpu
features if feature starts with '-'
URL: https://github.com/apache/cloudstack/pull/3335#discussion_r285873035
##
File path:
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java
##
@@ -1360,7 +1360,11 @@ public String toString() {
if (_features != null) {
for (String feature : _features) {
-modeBuilder.append("");
+if (feature.startsWith("-")) {
Review comment:
@anuragaw
Thanks for your suggestion.
I checked the code just now. The condition you mentioned is processed in
LibvirtComputingResource.java
```
final String cpuFeatures = (String)params.get("guest.cpu.features");
if (cpuFeatures != null) {
_cpuFeatures = new ArrayList();
for (final String feature: cpuFeatures.split(" ")) {
if (!feature.isEmpty()) {
_cpuFeatures.add(feature);
}
}
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] anuragaw commented on a change in pull request #3335: kvm: disable cpu features if feature starts with '-'
anuragaw commented on a change in pull request #3335: kvm: disable cpu features
if feature starts with '-'
URL: https://github.com/apache/cloudstack/pull/3335#discussion_r285849457
##
File path:
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java
##
@@ -1360,7 +1360,11 @@ public String toString() {
if (_features != null) {
for (String feature : _features) {
-modeBuilder.append("");
+if (feature.startsWith("-")) {
Review comment:
minor suggestion - trim to remove accidental spaces if we are checking
prefix.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] anuragaw commented on a change in pull request #3338: ui: fix enable static nat only towards first nic and not on any other interface
anuragaw commented on a change in pull request #3338: ui: fix enable static nat
only towards first nic and not on any other interface
URL: https://github.com/apache/cloudstack/pull/3338#discussion_r285848465
##
File path: ui/scripts/network.js
##
@@ -87,12 +87,21 @@
} else { //non-portable IP which has only one NIC
// Get NIC IPs
+var data = {
+virtualmachineid: instance.id,
+};
+if (args.context.networkid != undefined) {
+$.extend(data, {
+networkid: args.context.networkid
+});
+} else {
+$.extend(data, {
+networkid: network.id
+});
+}
Review comment:
very minor suggestion- Alternate way of writing could be (just to make it
smaller)-
```
var data = {
virtualmachineid: instance.id,
networkid: (args.context.networkid != undefined) ?
args.context.networkid : network.id
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan removed a comment on issue #3333: server: ssh-keygen in PEM format and reduce main systemvm patching script
blueorangutan removed a comment on issue #: server: ssh-keygen in PEM format and reduce main systemvm patching script URL: https://github.com/apache/cloudstack/pull/#issuecomment-494180310 Trillian test result (tid-3563) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 6 Total time taken: 30485 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr-t3563-xenserver-71.zip Intermittent failure detected: /marvin/tests/smoke/test_certauthority_root.py Intermittent failure detected: /marvin/tests/smoke/test_dynamicroles.py Intermittent failure detected: /marvin/tests/smoke/test_hostha_simulator.py Intermittent failure detected: /marvin/tests/smoke/test_login.py Intermittent failure detected: /marvin/tests/smoke/test_outofbandmanagement_nestedplugin.py Intermittent failure detected: /marvin/tests/smoke/test_outofbandmanagement.py Intermittent failure detected: /marvin/tests/smoke/test_primary_storage.py Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py Intermittent failure detected: /marvin/tests/smoke/test_templates.py Intermittent failure detected: /marvin/tests/smoke/test_usage.py Smoke tests completed. 56 look OK, 12 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- login_test_saml_user | `Error` | 0.67 | test_login.py test_revoke_certificate | `Error` | 0.01 | test_certauthority_root.py test_role_account_acls_multiple_mgmt_servers | `Error` | 0.71 | test_dynamicroles.py test_configure_ha_provider_invalid | `Error` | 0.01 | test_hostha_simulator.py test_configure_ha_provider_valid | `Error` | 0.01 | test_hostha_simulator.py test_ha_configure_enabledisable_across_clusterzones | `Error` | 0.01 | test_hostha_simulator.py test_ha_disable_feature_invalid | `Error` | 0.01 | test_hostha_simulator.py test_ha_enable_feature_invalid | `Error` | 0.01 | test_hostha_simulator.py test_ha_list_providers | `Error` | 0.01 | test_hostha_simulator.py test_ha_multiple_mgmt_server_ownership | `Error` | 0.01 | test_hostha_simulator.py test_ha_verify_fsm_available | `Error` | 0.01 | test_hostha_simulator.py test_ha_verify_fsm_degraded | `Error` | 0.01 | test_hostha_simulator.py test_ha_verify_fsm_fenced | `Error` | 0.01 | test_hostha_simulator.py test_ha_verify_fsm_recovering | `Error` | 0.01 | test_hostha_simulator.py test_hostha_configure_default_driver | `Error` | 0.01 | test_hostha_simulator.py test_hostha_configure_invalid_provider | `Error` | 0.01 | test_hostha_simulator.py test_hostha_disable_feature_valid | `Error` | 0.01 | test_hostha_simulator.py test_hostha_enable_feature_valid | `Error` | 0.01 | test_hostha_simulator.py test_hostha_enable_feature_without_setting_provider | `Error` | 0.01 | test_hostha_simulator.py test_list_ha_for_host | `Error` | 0.01 | test_hostha_simulator.py test_list_ha_for_host_invalid | `Error` | 0.01 | test_hostha_simulator.py test_list_ha_for_host_valid | `Error` | 0.01 | test_hostha_simulator.py test_02_edit_primary_storage_tags | `Error` | 0.01 | test_primary_storage.py test_oobm_issue_power_cycle | `Error` | 3.43 | test_outofbandmanagement_nestedplugin.py test_oobm_issue_power_off | `Error` | 2.39 | test_outofbandmanagement_nestedplugin.py test_oobm_issue_power_on | `Error` | 3.37 | test_outofbandmanagement_nestedplugin.py test_oobm_issue_power_reset | `Error` | 3.46 | test_outofbandmanagement_nestedplugin.py test_oobm_issue_power_soft | `Error` | 3.34 | test_outofbandmanagement_nestedplugin.py test_oobm_issue_power_status | `Error` | 2.26 | test_outofbandmanagement_nestedplugin.py test_oobm_background_powerstate_sync | `Failure` | 20.58 | test_outofbandmanagement.py test_oobm_background_powerstate_sync | `Error` | 20.58 | test_outofbandmanagement.py test_oobm_configure_default_driver | `Error` | 0.06 | test_outofbandmanagement.py test_oobm_configure_invalid_driver | `Error` | 0.06 | test_outofbandmanagement.py test_oobm_disable_feature_invalid | `Error` | 0.09 | test_outofbandmanagement.py test_oobm_disable_feature_valid | `Error` | 1.16 | test_outofbandmanagement.py test_oobm_enable_feature_invalid | `Error` | 0.08 | test_outofbandmanagement.py test_oobm_enable_feature_valid | `Error` | 1.15 | test_outofbandmanagement.py test_oobm_enabledisable_across_clusterzones | `Error` | 10.03 | test_outofbandmanagement.py test_oobm_enabledisable_across_clusterzones | `Error` | 10.04 | test_outofbandmanagement.py test_oobm_issue_power_cycle | `Error` | 3.47 | test_outofbandmanagement.py test_oobm_issue_power_cycle | `Error` | 3.47 | test_outofbandmanagement.py test_oobm_issue_power_off | `Error`
[GitHub] [cloudstack] nathanejohnson commented on issue #3332: Switch instance to another compute/service offering
nathanejohnson commented on issue #3332: Switch instance to another compute/service offering URL: https://github.com/apache/cloudstack/issues/3332#issuecomment-494219724 @svenvogel long-term we should make sure that this works from the UI. in the short term, I believe a workaround for you might be to use cloudmonkey. https://cwiki.apache.org/confluence/display/CLOUDSTACK/CloudStack+cloudmonkey+CLI If you need help setting it up, please feel free to pop into the slack channel or the freenode irc channel. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3333: server: ssh-keygen in PEM format and reduce main systemvm patching script
blueorangutan commented on issue #: server: ssh-keygen in PEM format and reduce main systemvm patching script URL: https://github.com/apache/cloudstack/pull/#issuecomment-494198207 Trillian test result (tid-3562) Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7 Total time taken: 41975 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr-t3562-vmware-65u2.zip Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py Intermittent failure detected: /marvin/tests/smoke/test_templates.py Intermittent failure detected: /marvin/tests/smoke/test_usage.py Intermittent failure detected: /marvin/tests/smoke/test_volumes.py Smoke tests completed. 65 look OK, 3 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_04_extract_template | `Failure` | 136.57 | test_templates.py ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py test_06_download_detached_volume | `Failure` | 171.64 | test_volumes.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3333: server: ssh-keygen in PEM format and reduce main systemvm patching script
blueorangutan commented on issue #: server: ssh-keygen in PEM format and reduce main systemvm patching script URL: https://github.com/apache/cloudstack/pull/#issuecomment-494180310 Trillian test result (tid-3563) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 6 Total time taken: 30485 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr-t3563-xenserver-71.zip Intermittent failure detected: /marvin/tests/smoke/test_certauthority_root.py Intermittent failure detected: /marvin/tests/smoke/test_dynamicroles.py Intermittent failure detected: /marvin/tests/smoke/test_hostha_simulator.py Intermittent failure detected: /marvin/tests/smoke/test_login.py Intermittent failure detected: /marvin/tests/smoke/test_outofbandmanagement_nestedplugin.py Intermittent failure detected: /marvin/tests/smoke/test_outofbandmanagement.py Intermittent failure detected: /marvin/tests/smoke/test_primary_storage.py Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py Intermittent failure detected: /marvin/tests/smoke/test_templates.py Intermittent failure detected: /marvin/tests/smoke/test_usage.py Smoke tests completed. 56 look OK, 12 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- login_test_saml_user | `Error` | 0.67 | test_login.py test_revoke_certificate | `Error` | 0.01 | test_certauthority_root.py test_role_account_acls_multiple_mgmt_servers | `Error` | 0.71 | test_dynamicroles.py test_configure_ha_provider_invalid | `Error` | 0.01 | test_hostha_simulator.py test_configure_ha_provider_valid | `Error` | 0.01 | test_hostha_simulator.py test_ha_configure_enabledisable_across_clusterzones | `Error` | 0.01 | test_hostha_simulator.py test_ha_disable_feature_invalid | `Error` | 0.01 | test_hostha_simulator.py test_ha_enable_feature_invalid | `Error` | 0.01 | test_hostha_simulator.py test_ha_list_providers | `Error` | 0.01 | test_hostha_simulator.py test_ha_multiple_mgmt_server_ownership | `Error` | 0.01 | test_hostha_simulator.py test_ha_verify_fsm_available | `Error` | 0.01 | test_hostha_simulator.py test_ha_verify_fsm_degraded | `Error` | 0.01 | test_hostha_simulator.py test_ha_verify_fsm_fenced | `Error` | 0.01 | test_hostha_simulator.py test_ha_verify_fsm_recovering | `Error` | 0.01 | test_hostha_simulator.py test_hostha_configure_default_driver | `Error` | 0.01 | test_hostha_simulator.py test_hostha_configure_invalid_provider | `Error` | 0.01 | test_hostha_simulator.py test_hostha_disable_feature_valid | `Error` | 0.01 | test_hostha_simulator.py test_hostha_enable_feature_valid | `Error` | 0.01 | test_hostha_simulator.py test_hostha_enable_feature_without_setting_provider | `Error` | 0.01 | test_hostha_simulator.py test_list_ha_for_host | `Error` | 0.01 | test_hostha_simulator.py test_list_ha_for_host_invalid | `Error` | 0.01 | test_hostha_simulator.py test_list_ha_for_host_valid | `Error` | 0.01 | test_hostha_simulator.py test_02_edit_primary_storage_tags | `Error` | 0.01 | test_primary_storage.py test_oobm_issue_power_cycle | `Error` | 3.43 | test_outofbandmanagement_nestedplugin.py test_oobm_issue_power_off | `Error` | 2.39 | test_outofbandmanagement_nestedplugin.py test_oobm_issue_power_on | `Error` | 3.37 | test_outofbandmanagement_nestedplugin.py test_oobm_issue_power_reset | `Error` | 3.46 | test_outofbandmanagement_nestedplugin.py test_oobm_issue_power_soft | `Error` | 3.34 | test_outofbandmanagement_nestedplugin.py test_oobm_issue_power_status | `Error` | 2.26 | test_outofbandmanagement_nestedplugin.py test_oobm_background_powerstate_sync | `Failure` | 20.58 | test_outofbandmanagement.py test_oobm_background_powerstate_sync | `Error` | 20.58 | test_outofbandmanagement.py test_oobm_configure_default_driver | `Error` | 0.06 | test_outofbandmanagement.py test_oobm_configure_invalid_driver | `Error` | 0.06 | test_outofbandmanagement.py test_oobm_disable_feature_invalid | `Error` | 0.09 | test_outofbandmanagement.py test_oobm_disable_feature_valid | `Error` | 1.16 | test_outofbandmanagement.py test_oobm_enable_feature_invalid | `Error` | 0.08 | test_outofbandmanagement.py test_oobm_enable_feature_valid | `Error` | 1.15 | test_outofbandmanagement.py test_oobm_enabledisable_across_clusterzones | `Error` | 10.03 | test_outofbandmanagement.py test_oobm_enabledisable_across_clusterzones | `Error` | 10.04 | test_outofbandmanagement.py test_oobm_issue_power_cycle | `Error` | 3.47 | test_outofbandmanagement.py test_oobm_issue_power_cycle | `Error` | 3.47 | test_outofbandmanagement.py test_oobm_issue_power_off | `Error` | 4.39
[GitHub] [cloudstack] blueorangutan commented on issue #3333: server: ssh-keygen in PEM format and reduce main systemvm patching script
blueorangutan commented on issue #: server: ssh-keygen in PEM format and reduce main systemvm patching script URL: https://github.com/apache/cloudstack/pull/#issuecomment-494141302 Trillian test result (tid-3560) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 28167 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr-t3560-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Smoke tests completed. 67 look OK, 1 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_04_rvpc_network_garbage_collector_nics | `Failure` | 295.01 | test_vpc_redundant.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] svenvogel edited a comment on issue #3332: Switch instance to another compute/service offering
svenvogel edited a comment on issue #3332: Switch instance to another compute/service offering URL: https://github.com/apache/cloudstack/issues/3332#issuecomment-494133023 @nathanejohnson we dont use really cloudmonkey. you mean logic was not changed? **if you see the pictures below from DB which i added you will see in the old offering there will be add a "0" NOT "NULL".** normally there should be a "NULL" because we dont chosen a QOS Type Storage! @syed @mike-tutkowski can you take a look? > @pbankonier the UI sends icsucomizediops=false or true every time it looks like. if you look at the previous logic, it still sets miniops and maxiops to 0 in this case. Which is what it still does. I agree that it probably shouldn't, but this is why I asked on the PR for someone more familiar with managed storage (@mike-tutkowski ) to weigh in. @pbankonier what do you think? why it worked before? DB View  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] svenvogel edited a comment on issue #3332: Switch instance to another compute/service offering
svenvogel edited a comment on issue #3332: Switch instance to another compute/service offering URL: https://github.com/apache/cloudstack/issues/3332#issuecomment-494133023 @nathanejohnson we dont use really cloudmonkey. you mean logic was not changed? **if you see the pictures below from DB which i added you will see in the old offering there will be add a "0" NOT "NULL".** @syed @mike-tutkowski can you take a look? > @pbankonier the UI sends icsucomizediops=false or true every time it looks like. if you look at the previous logic, it still sets miniops and maxiops to 0 in this case. Which is what it still does. I agree that it probably shouldn't, but this is why I asked on the PR for someone more familiar with managed storage (@mike-tutkowski ) to weigh in. @pbankonier what do you think? why it worked before? DB View  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] svenvogel edited a comment on issue #3332: Switch instance to another compute/service offering
svenvogel edited a comment on issue #3332: Switch instance to another compute/service offering URL: https://github.com/apache/cloudstack/issues/3332#issuecomment-494133023 @nathanejohnson we dont use really cloudmonkey. you mean logic was not changed? **if you see the pictures below from DB which i added you will see in the old offering there will be add a "NULL" NOT "0".** @syed @mike-tutkowski can you take a look? > @pbankonier the UI sends icsucomizediops=false or true every time it looks like. if you look at the previous logic, it still sets miniops and maxiops to 0 in this case. Which is what it still does. I agree that it probably shouldn't, but this is why I asked on the PR for someone more familiar with managed storage (@mike-tutkowski ) to weigh in. @pbankonier what do you think? why it worked before? DB View  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] svenvogel edited a comment on issue #3332: Switch instance to another compute/service offering
svenvogel edited a comment on issue #3332: Switch instance to another compute/service offering URL: https://github.com/apache/cloudstack/issues/3332#issuecomment-494133023 @nathanejohnson we dont use really cloudmonkey. you mean logic was not changed? **if you see the pictures above which i added you will see in the old offering there will be add a "NULL" NOT "0".** @syed @mike-tutkowski can you take a look? > @pbankonier the UI sends icsucomizediops=false or true every time it looks like. if you look at the previous logic, it still sets miniops and maxiops to 0 in this case. Which is what it still does. I agree that it probably shouldn't, but this is why I asked on the PR for someone more familiar with managed storage (@mike-tutkowski ) to weigh in. @pbankonier what do you think? why it worked before? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] svenvogel edited a comment on issue #3332: Switch instance to another compute/service offering
svenvogel edited a comment on issue #3332: Switch instance to another compute/service offering URL: https://github.com/apache/cloudstack/issues/3332#issuecomment-494133023 @nathanejohnson we dont use really cloudmonkey. you mean logic was not changed? if you see the pictures above which i added you will see in the old offering there will be add a "NULL" NOT "0". @syed @mike-tutkowski can you take a look? > @pbankonier the UI sends icsucomizediops=false or true every time it looks like. if you look at the previous logic, it still sets miniops and maxiops to 0 in this case. Which is what it still does. I agree that it probably shouldn't, but this is why I asked on the PR for someone more familiar with managed storage (@mike-tutkowski ) to weigh in. @pbankonier what do you think? why it worked before? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] svenvogel commented on issue #3332: Switch instance to another compute/service offering
svenvogel commented on issue #3332: Switch instance to another compute/service offering URL: https://github.com/apache/cloudstack/issues/3332#issuecomment-494133023 @nathanejohnson we dont use really cloudmonkey. you mean logic was not changed? @syed @mike-tutkowski can you take a look? > @pbankonier the UI sends icsucomizediops=false or true every time it looks like. if you look at the previous logic, it still sets miniops and maxiops to 0 in this case. Which is what it still does. I agree that it probably shouldn't, but this is why I asked on the PR for someone more familiar with managed storage (@mike-tutkowski ) to weigh in. @pbankonier what do you think? why it worked before? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] ustcweizhou commented on a change in pull request #3333: server: ssh-keygen in PEM format and reduce main systemvm patching script
ustcweizhou commented on a change in pull request #: server: ssh-keygen in
PEM format and reduce main systemvm patching script
URL: https://github.com/apache/cloudstack/pull/#discussion_r285744320
##
File path:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtStartCommandWrapper.java
##
@@ -125,9 +125,14 @@ public Answer execute(final StartCommand command, final
LibvirtComputingResource
// try to patch and SSH into the systemvm for up to 5 minutes
for (int count = 0; count < 10; count++) {
// wait and try passCmdLine for 30 seconds at most for
CLOUDSTACK-2823
-libvirtComputingResource.passCmdLine(vmName,
vmSpec.getBootArgs());
-// check router is up?
-final VirtualRoutingResource virtRouterResource =
libvirtComputingResource.getVirtRouterResource();
+if (libvirtComputingResource.passCmdLine(vmName,
vmSpec.getBootArgs())) {
+break;
+}
Review comment:
@rhtyd
we pass cmdline to systemvm multiple times here, is because the operation
passCmdLine will always succeed but actually systemvm cannot get the data via
/dev/vport01p1 inside it, so we pass the cmdline to systemvm around every 15
seconds (virtRouterResource.connect) until control ip is reachable.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] ustcweizhou commented on issue #3334: Cannot enable static NAT on VM with NICs on multiple VPC tiers in UI
ustcweizhou commented on issue #3334: Cannot enable static NAT on VM with NICs on multiple VPC tiers in UI URL: https://github.com/apache/cloudstack/issues/3334#issuecomment-494120656 @nvazquez could you please test fix in #3338 ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] ustcweizhou commented on issue #3335: kvm: disable cpu features if feature starts with '-'
ustcweizhou commented on issue #3335: kvm: disable cpu features if feature starts with '-' URL: https://github.com/apache/cloudstack/pull/3335#issuecomment-494120417 @rhtyd @svenvogel added unit test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] ustcweizhou edited a comment on issue #3331: api/server: Add option 'details' to listProjects and listAccounts
ustcweizhou edited a comment on issue #3331: api/server: Add option 'details' to listProjects and listAccounts URL: https://github.com/apache/cloudstack/pull/3331#issuecomment-494114076 @svenvogel both #3306 and #3331 will reduce the execution time while list projects. #3306 aims to fix the issue caused by multiple tags created for projects. #3331 aims to fix the issue when there are many accounts existing (similar issue while list domains fixed by #1901 for CLOUDSTACK-9405). UI changes are included in this pull request. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] ustcweizhou commented on issue #3331: api/server: Add option 'details' to listProjects and listAccounts
ustcweizhou commented on issue #3331: api/server: Add option 'details' to listProjects and listAccounts URL: https://github.com/apache/cloudstack/pull/3331#issuecomment-494114076 @svenvogel both #3306 and #3331 will reduce the execution time while list projects. #3306 aims to fix the issue caused by multiple tags created for projects. #3331 aims to fix the issue when there are many accounts existing (similar issue while list domains fixed by #1901 for CLOUDSTACK-9405). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nathanejohnson edited a comment on issue #3332: Switch instance to another compute/service offering
nathanejohnson edited a comment on issue #3332: Switch instance to another compute/service offering URL: https://github.com/apache/cloudstack/issues/3332#issuecomment-494107412 @pbankonier the UI sends icsucomizediops=false or true every time it looks like. if you look at the previous logic, it still sets miniops and maxiops to 0 in this case. Which is what it still does. I agree that it probably shouldn't, but this is why I asked on the PR for someone more familiar with managed storage (@mike-tutkowski ) to weigh in. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nathanejohnson edited a comment on issue #3332: Switch instance to another compute/service offering
nathanejohnson edited a comment on issue #3332: Switch instance to another compute/service offering URL: https://github.com/apache/cloudstack/issues/3332#issuecomment-494107412 @pbankonier the UI sends icsucomizediops=false every time it looks like. if you look at the previous logic, it still sets miniops and maxiops to 0 in this case. Which is what it still does. I agree that it probably shouldn't, but this is why I asked on the PR for someone more familiar with managed storage (@mike-tutkowski ) to weigh in. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nathanejohnson commented on issue #3332: Switch instance to another compute/service offering
nathanejohnson commented on issue #3332: Switch instance to another compute/service offering URL: https://github.com/apache/cloudstack/issues/3332#issuecomment-494107853 @svenvogel if you use cloudmonkey to create the service offering and omit the iscusomizediops flag, I believe it should do what you want it to. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nathanejohnson edited a comment on issue #3332: Switch instance to another compute/service offering
nathanejohnson edited a comment on issue #3332: Switch instance to another compute/service offering URL: https://github.com/apache/cloudstack/issues/3332#issuecomment-494107412 @pbankonier the UI sends icsucomizediops=false every time it looks like. if you look at the previous logic, it still sets miniops and maxiops to 0 in this case. Which what it still does. I agree that it probably shouldn't, but this is why I asked on the PR for someone more familiar with managed storage (@mike-tutkowski ) to weigh in. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nathanejohnson commented on issue #3332: Switch instance to another compute/service offering
nathanejohnson commented on issue #3332: Switch instance to another compute/service offering URL: https://github.com/apache/cloudstack/issues/3332#issuecomment-494107412 @pbankonier the UI sends icsucomizediops=false every time it looks like. if you look at the previous logic, it still sets miniops and maxiops to 0 in this case. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3333: server: ssh-keygen in PEM format and reduce main systemvm patching script
rhtyd commented on issue #: server: ssh-keygen in PEM format and reduce main systemvm patching script URL: https://github.com/apache/cloudstack/pull/#issuecomment-494094779 @ustcweizhou This is ready for review now, the issue is affecting CloudStack with latest versions of ssh-keygen primarily. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] Doni7722 opened a new issue #3341: Ability to add custom disk offer to data disk (created from multi-disk template)
Doni7722 opened a new issue #3341: Ability to add custom disk offer to data disk (created from multi-disk template) URL: https://github.com/apache/cloudstack/issues/3341 # ISSUE TYPE * Improvement Request # COMPONENT NAME ~~~ API, UI ~~~ # CLOUDSTACK VERSION ~~~ 4.11.2 ~~~ # CONFIGURATION N/A # OS / ENVIRONMENT N/A # SUMMARY With CS 4.11.2. we are able to create templates based on Multi-disks OVA file (see https://github.com/apache/cloudstack/pull/2146). If you launch a VM based on this template you need to specify a disk offer per disk you would like to create. The disk offer for the data disks (only data disks are affected) are not allowed to be custom. # STEPS TO REPRODUCE Over API: ~~~ deploy virtualmachine templateid=(ID of the MultiOVA template) name=(VM NAME) displayname=(DISPLAYNAME) zoneid=(ZONEIID) serviceofferingid=(SERVICE OFFERING ID ie small, medium,etc) datadiskofferinglist[0].datadisktemplateid=(this is the template UUID for the first data disk) datadiskofferinglist[0].diskofferingid=(ID of a disk offering) ~~~ Make sure that the disk offer ID is from a disk offer which allows to be a custom value. # EXPECTED RESULTS VM should be created and CS should allow us to specify a custom size for the data disk ~~~ ~~~ # ACTUAL RESULTS You will retrieve the following error message if used a custom disk offer: ~~~ Error: (HTTP 431, error code 4350) Invalid disk offering id X specified for datadisk template X. Custom Disk offerings are not supported for Datadisk templates ~~~ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] PaulAngus opened a new issue #3340: ACS tries to delete a root disk in zone wide primary storage
PaulAngus opened a new issue #3340: ACS tries to delete a root disk in zone
wide primary storage
URL: https://github.com/apache/cloudstack/issues/3340
# ISSUE TYPE
* Bug Report
# COMPONENT NAME
~~~
vSphere - Zone wide storage
~~~
# CLOUDSTACK VERSION
~~~
4.9, 4.11, 4.12, master
~~~
# CONFIGURATION
vSphere with zone-wide storage
# OS / ENVIRONMENT
N/A
# SUMMARY
Transferred from Jira :
https://issues.apache.org/jira/browse/CLOUDSTACK-9991
A VM is running and the disk is migrated from cluster to zone wide primary
storage. The root disk for that VM is now seen in all clusters and ACS tries to
delete it. This fails, fortunately but only because it is in use. ACS should
not try to delete the disk.
# STEPS TO REPRODUCE
~~~
~~~
# EXPECTED RESULTS
~~~
Migrate the root disk of a running VM from cluster-wide to zone wide storage.
~~~
# ACTUAL RESULTS
message seen:
Cannot delete file [Perf06_ix_stor_003] i-93-8549-VM/ROOT-8549-delta.vmdk
It looks like this message
private void deleteUnregisteredVmFiles(VirtualMachineFileLayoutEx
vmFileLayout, DatacenterMO dcMo, boolean deleteDisks) throws Exception {
s_logger.debug("Deleting files associated with an existing VM that was
unregistered");
from here:
https://github.com/apache/cloudstack/blob/a25b54cf05704bcf074e67d5500d5d221235cc86/plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java#L2712-L2713
because the start is reading this:
https://github.com/apache/cloudstack/blob/a25b54cf05704bcf074e67d5500d5d221235cc86/plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java#L2073-L2076
// Since VM was successfully powered-on, if there was an existing VM in a
different cluster that was unregistered, delete all the files associated with
it.
if (existingVmName != null && existingVmFileLayout != null)
{ deleteUnregisteredVmFiles(existingVmFileLayout, dcMo, true); }
~~~
~~~
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] pbankonier commented on issue #3332: Switch instance to another compute/service offering
pbankonier commented on issue #3332: Switch instance to another compute/service offering URL: https://github.com/apache/cloudstack/issues/3332#issuecomment-494024906 @nathanejohnson The problem is from line 2371 in the ConfigurationManagerImpl.java. You changed the condition from 'isCustomizedIops != null' to 'Boolean.TRUE.equals(isCustomizedIops)' and removed the else case where minIops and maxIops gets set to null; This changes the behavior in case isCustomizedIops is null. Now the minIops and maxIops values get set to 0 instead of null. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3333: server: ssh-keygen in PEM format and reduce main systemvm patching script
rhtyd commented on issue #: server: ssh-keygen in PEM format and reduce main systemvm patching script URL: https://github.com/apache/cloudstack/pull/#issuecomment-494012307 Kicked test with centos6 out of band. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] svenvogel commented on issue #3331: api/server: Add option 'details' to listProjects and listAccounts
svenvogel commented on issue #3331: api/server: Add option 'details' to listProjects and listAccounts URL: https://github.com/apache/cloudstack/pull/3331#issuecomment-494009627 @ustcweizhou i mean ... its a extension from #3306 ? so we need to add this in the ui to get them faster? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3333: server: ssh-keygen in PEM format and reduce main systemvm patching script
blueorangutan commented on issue #: server: ssh-keygen in PEM format and reduce main systemvm patching script URL: https://github.com/apache/cloudstack/pull/#issuecomment-494000429 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2744 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] PaulAngus opened a new issue #3339: Duplicate tags cause DB constraint exceptions
PaulAngus opened a new issue #3339: Duplicate tags cause DB constraint
exceptions
URL: https://github.com/apache/cloudstack/issues/3339
# ISSUE TYPE
* Bug Report
# COMPONENT NAME
~~~
API
~~~
# CLOUDSTACK VERSION
~~~
4.11.2, 4.12, master
~~~
# CONFIGURATION
N/A
# OS / ENVIRONMENT
N/A
# SUMMARY
# STEPS TO REPRODUCE
Create a VM
Add a tag via UI (at bottom of the instance detail page) or via API
Add a 2nd tag with THE SAME **Key** value
~~~
~~~
# EXPECTED RESULTS
~~~
The API should return that the Tag's Key already exists.
~~~
# ACTUAL RESULTS
~~~
The API command reaches the database which causes a DB exception.
Caused by:
com.mysql.jdbc.exceptions.jdbc4.MySQLIntegrityConstraintViolationException:
Duplicate entry '3-UserVm-tag1' for key
'i_tags__resource_id__resource_type__key'
```
2019-05-20 13:25:35,024 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl]
(qtp788117692-10:ctx-04e71a9a ctx-d687eb40) (logid:22b79668) submit async
job-35, details: AsyncJobVO {id:35, userId: 2, accountId: 2, instanceType:
None, instanceId: null, cmd:
org.apache.cloudstack.api.command.user.tag.CreateTagsCmd, cmdInfo:
{"response":"json","ctxUserId":"2","tags[0].key":"tag1","tags[0].value":"tag2","httpmethod":"GET","ctxStartEventId":"86","ctxDetails":"{}","ctxAccountId":"2","cmdEventType":"CREATE_TAGS","resourceIds":"485c48cd-336b-4e05-bb8c-9d747a973e68","resourceType":"UserVm","_":"1558358731396"},
cmdVersion: 0, status: IN_PROGRESS, processStatus: 0, resultCode: 0, result:
null, initMsid: 32987345389531, completeMsid: null, lastUpdated: null,
lastPolled: null, created: null}
2019-05-20 13:25:35,025 DEBUG [c.c.a.ApiServlet]
(qtp788117692-10:ctx-04e71a9a ctx-d687eb40) (logid:22b79668) ===END===
10.0.0.20 -- GET
command=createTags&response=json&tags%5B0%5D.key=tag1&tags%5B0%5D.value=tag2&resourceIds=485c48cd-336b-4e05-bb8c-9d747a973e68&resourceType=UserVm&_=1558358731396
2019-05-20 13:25:35,026 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl]
(API-Job-Executor-27:ctx-988547b9 job-35) (logid:826e9fb7) Executing AsyncJobVO
{id:35, userId: 2, accountId: 2, instanceType: None, instanceId: null, cmd:
org.apache.cloudstack.api.command.user.tag.CreateTagsCmd, cmdInfo:
{"response":"json","ctxUserId":"2","tags[0].key":"tag1","tags[0].value":"tag2","httpmethod":"GET","ctxStartEventId":"86","ctxDetails":"{}","ctxAccountId":"2","cmdEventType":"CREATE_TAGS","resourceIds":"485c48cd-336b-4e05-bb8c-9d747a973e68","resourceType":"UserVm","_":"1558358731396"},
cmdVersion: 0, status: IN_PROGRESS, processStatus: 0, resultCode: 0, result:
null, initMsid: 32987345389531, completeMsid: null, lastUpdated: null,
lastPolled: null, created: null}
2019-05-20 13:25:35,034 DEBUG [c.c.u.d.T.Transaction]
(API-Job-Executor-27:ctx-988547b9 job-35 ctx-4d668f1d) (logid:826e9fb7) Rolling
back the transaction: Time = 5 Name = API-Job-Executor-27; called by
-TransactionLegacy.rollback:890-TransactionLegacy.removeUpTo:833-TransactionLegacy.close:657-TransactionContextInterceptor.invoke:36-ReflectiveMethodInvocation.proceed:174-ExposeInvocationInterceptor.invoke:92-ReflectiveMethodInvocation.proceed:185-JdkDynamicAopProxy.invoke:212-$Proxy51.persist:-1-TaggedResourceManagerImpl$1.doInTransactionWithoutResult:313-TransactionCallbackNoReturn.doInTransaction:25-Transaction$2.doInTransaction:50
2019-05-20 13:25:35,042 ERROR [c.c.a.ApiAsyncJobDispatcher]
(API-Job-Executor-27:ctx-988547b9 job-35) (logid:826e9fb7) Unexpected exception
while executing org.apache.cloudstack.api.command.user.tag.CreateTagsCmd
javax.persistence.EntityExistsException: Entity already exists:
at com.cloud.utils.db.GenericDaoBase.persist(GenericDaoBase.java:1434)
at sun.reflect.GeneratedMethodAccessor79.invoke(Unknown Source)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at
org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:338)
at
org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:197)
at
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163)
at
com.cloud.utils.db.TransactionContextInterceptor.invoke(TransactionContextInterceptor.java:34)
at
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:174)
at
org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:92)
at
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:185)
at
org.springframewor
[GitHub] [cloudstack] blueorangutan commented on issue #3333: server: ssh-keygen in PEM format and reduce main systemvm patching script
blueorangutan commented on issue #: server: ssh-keygen in PEM format and reduce main systemvm patching script URL: https://github.com/apache/cloudstack/pull/#issuecomment-493992439 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3333: server: ssh-keygen in PEM format and reduce main systemvm patching script
rhtyd commented on issue #: server: ssh-keygen in PEM format and reduce main systemvm patching script URL: https://github.com/apache/cloudstack/pull/#issuecomment-493992130 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] ustcweizhou opened a new pull request #3338: ui: fix enable static nat only towards first nic and not on any other interface
ustcweizhou opened a new pull request #3338: ui: fix enable static nat only towards first nic and not on any other interface URL: https://github.com/apache/cloudstack/pull/3338 ## Description When enable static nat in a vpc on UI, it only lists the primary and secondary ips of first nic of a vm, no matter which vpc tier is selected. The same issue happens when add a vm to load balancer. Fixes: #3334 ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [X] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## Screenshots (if appropriate): ## How Has This Been Tested? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nvazquez commented on issue #3334: Cannot enable static NAT on VM with NICs on multiple VPC tiers in UI
nvazquez commented on issue #3334: Cannot enable static NAT on VM with NICs on multiple VPC tiers in UI URL: https://github.com/apache/cloudstack/issues/3334#issuecomment-493958908 Done @PaulAngus thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3333: server: ssh-keygen in PEM format and reduce main systemvm patching script
rhtyd commented on issue #: server: ssh-keygen in PEM format and reduce main systemvm patching script URL: https://github.com/apache/cloudstack/pull/#issuecomment-493957265 @blueorangutan test matrix This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3333: server: ssh-keygen in PEM format and reduce main systemvm patching script
blueorangutan commented on issue #: server: ssh-keygen in PEM format and reduce main systemvm patching script URL: https://github.com/apache/cloudstack/pull/#issuecomment-493957694 @rhtyd a Trillian-Jenkins matrix job (centos6 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3333: server: ssh-keygen in PEM format and reduce main systemvm patching script
blueorangutan commented on issue #: server: ssh-keygen in PEM format and reduce main systemvm patching script URL: https://github.com/apache/cloudstack/pull/#issuecomment-493946832 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2743 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3333: server: ssh-keygen in PEM format and reduce main systemvm patching script
blueorangutan commented on issue #: server: ssh-keygen in PEM format and reduce main systemvm patching script URL: https://github.com/apache/cloudstack/pull/#issuecomment-493940678 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3333: [WIP] server: save SSH keypair exactly as generated by ssh-keygen
rhtyd commented on issue #: [WIP] server: save SSH keypair exactly as generated by ssh-keygen URL: https://github.com/apache/cloudstack/pull/#issuecomment-493940385 The main issue with failing VR came out to be due to the ssh private key having 'OPENSS... PRIVATE KEY' instead of 'RSA PRIVATE KEY' that ssh trilead-ssh2 library expects. This happens when you update to latest openssh-client @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] ustcweizhou removed a comment on issue #3334: Cannot enable static NAT on VM with NICs on multiple VPC tiers in UI
ustcweizhou removed a comment on issue #3334: Cannot enable static NAT on VM
with NICs on multiple VPC tiers in UI
URL: https://github.com/apache/cloudstack/issues/3334#issuecomment-493916561
patch
```
diff --git a/ui/scripts/vpc.js b/ui/scripts/vpc.js
index 8058f07..b7fac5b 100644
--- a/ui/scripts/vpc.js
+++ b/ui/scripts/vpc.js
@@ -39,7 +39,7 @@
url: createURL('listNics'),
data: {
virtualmachineid: instance.id,
-nicId: instance.nic[0].id
+networkId: network.id
},
success: function(json) {
var nic = json.listnicsresponse.nic[0];
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3335: kvm: disable cpu features if feature starts with '-'
blueorangutan commented on issue #3335: kvm: disable cpu features if feature starts with '-' URL: https://github.com/apache/cloudstack/pull/3335#issuecomment-493923786 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2742 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] ustcweizhou commented on issue #3334: Cannot enable static NAT on VM with NICs on multiple VPC tiers in UI
ustcweizhou commented on issue #3334: Cannot enable static NAT on VM with NICs
on multiple VPC tiers in UI
URL: https://github.com/apache/cloudstack/issues/3334#issuecomment-493916561
patch
```
diff --git a/ui/scripts/vpc.js b/ui/scripts/vpc.js
index 8058f07..b7fac5b 100644
--- a/ui/scripts/vpc.js
+++ b/ui/scripts/vpc.js
@@ -39,7 +39,7 @@
url: createURL('listNics'),
data: {
virtualmachineid: instance.id,
-nicId: instance.nic[0].id
+networkId: network.id
},
success: function(json) {
var nic = json.listnicsresponse.nic[0];
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3335: kvm: disable cpu features if feature starts with '-'
blueorangutan commented on issue #3335: kvm: disable cpu features if feature starts with '-' URL: https://github.com/apache/cloudstack/pull/3335#issuecomment-493916325 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3335: kvm: disable cpu features if feature starts with '-'
rhtyd commented on issue #3335: kvm: disable cpu features if feature starts with '-' URL: https://github.com/apache/cloudstack/pull/3335#issuecomment-493915939 @ustcweizhou thanks for explaining @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] ustcweizhou commented on issue #3335: kvm: disable cpu features if feature starts with '-'
ustcweizhou commented on issue #3335: kvm: disable cpu features if feature starts with '-' URL: https://github.com/apache/cloudstack/pull/3335#issuecomment-493909611 @rhtyd these features are not supported by our CPU (a quite old CPU) so I want to disable these cpu features. according to qemu documents, if we want to disable a cpu feature, we add hyphen before the cpu feature in qemu command line. Currently cloudstack only support 'require' cpu features, but does not support 'disable' cpu features. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd removed a comment on issue #3333: [WIP] server: save SSH keypair exactly as generated by ssh-keygen
rhtyd removed a comment on issue #: [WIP] server: save SSH keypair exactly as generated by ssh-keygen URL: https://github.com/apache/cloudstack/pull/#issuecomment-493436691 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan removed a comment on issue #3333: [WIP] server: save SSH keypair exactly as generated by ssh-keygen
blueorangutan removed a comment on issue #: [WIP] server: save SSH keypair exactly as generated by ssh-keygen URL: https://github.com/apache/cloudstack/pull/#issuecomment-493436966 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan removed a comment on issue #3333: [WIP] server: save SSH keypair exactly as generated by ssh-keygen
blueorangutan removed a comment on issue #: [WIP] server: save SSH keypair exactly as generated by ssh-keygen URL: https://github.com/apache/cloudstack/pull/#issuecomment-493420910 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2741 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan removed a comment on issue #3333: [WIP] server: save SSH keypair exactly as generated by ssh-keygen
blueorangutan removed a comment on issue #: [WIP] server: save SSH keypair exactly as generated by ssh-keygen URL: https://github.com/apache/cloudstack/pull/#issuecomment-493416072 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd removed a comment on issue #3333: [WIP] server: save SSH keypair exactly as generated by ssh-keygen
rhtyd removed a comment on issue #: [WIP] server: save SSH keypair exactly as generated by ssh-keygen URL: https://github.com/apache/cloudstack/pull/#issuecomment-493415891 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd removed a comment on issue #3333: [WIP] server: save SSH keypair exactly as generated by ssh-keygen
rhtyd removed a comment on issue #: [WIP] server: save SSH keypair exactly as generated by ssh-keygen URL: https://github.com/apache/cloudstack/pull/#issuecomment-493436754 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3335: kvm: disable cpu features if feature starts with '-'
rhtyd commented on issue #3335: kvm: disable cpu features if feature starts with '-' URL: https://github.com/apache/cloudstack/pull/3335#issuecomment-493900907 @ustcweizhou why not simply configure the agent.properties without the hyphen `-`? For example: ``` guest.cpu.features=avx xsave aes tsc-deadline x2apic pclmuldq ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] PaulAngus commented on issue #3334: Cannot enable static NAT on VM with NICs on multiple VPC tiers
PaulAngus commented on issue #3334: Cannot enable static NAT on VM with NICs on multiple VPC tiers URL: https://github.com/apache/cloudstack/issues/3334#issuecomment-493886182 @nvazquez please can you detail where in the UI you are trying to add this IP. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
