[GitHub] [cloudstack] blueorangutan commented on issue #3240: [WIP DO NOT MERGE] api: instance and template details are free text
blueorangutan commented on issue #3240: [WIP DO NOT MERGE] api: instance and template details are free text URL: https://github.com/apache/cloudstack/pull/3240#issuecomment-505343337 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-14 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3259: [WIP DO NOT MERGE] server: export granular volume bytes and iops metrics
rhtyd commented on issue #3259: [WIP DO NOT MERGE] server: export granular volume bytes and iops metrics URL: https://github.com/apache/cloudstack/pull/3259#issuecomment-505343402 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3241: [WIP DO NOT MERGE] Allow users to share templates with Accounts or Projects through the
blueorangutan commented on issue #3241: [WIP DO NOT MERGE] Allow users to share templates with Accounts or Projects through the URL: https://github.com/apache/cloudstack/pull/3241#issuecomment-505343395 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3365: KVM: DPDK live migrations
rhtyd commented on issue #3365: KVM: DPDK live migrations URL: https://github.com/apache/cloudstack/pull/3365#issuecomment-505342817 @anuragaw @shwstppr @DaanHoogland please review, thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3271: [WIP DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available
rhtyd commented on issue #3271: [WIP DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-505342961 is this branch/PR stable and ready for review @nvazquez ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3268: Support sort_key for vpc_offerings table
blueorangutan commented on issue #3268: Support sort_key for vpc_offerings table URL: https://github.com/apache/cloudstack/pull/3268#issuecomment-505342357 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3374: KVM: Enhancements for direct download feature
rhtyd commented on issue #3374: KVM: Enhancements for direct download feature URL: https://github.com/apache/cloudstack/pull/3374#issuecomment-505342418 @anuragaw @shwstppr @DaanHoogland please review, thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3297: Support copy tags from template/iso image to VM from deploy vm command
blueorangutan commented on issue #3297: Support copy tags from template/iso image to VM from deploy vm command URL: https://github.com/apache/cloudstack/pull/3297#issuecomment-505342340 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3297: Support copy tags from template/iso image to VM from deploy vm command
rhtyd commented on issue #3297: Support copy tags from template/iso image to VM from deploy vm command URL: https://github.com/apache/cloudstack/pull/3297#issuecomment-505342014 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3268: Support sort_key for vpc_offerings table
rhtyd commented on issue #3268: Support sort_key for vpc_offerings table URL: https://github.com/apache/cloudstack/pull/3268#issuecomment-505341916 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3248: [WIP DO NOT MERGE] server: offerings for specified domain(s) and zone(s)
blueorangutan commented on issue #3248: [WIP DO NOT MERGE] server: offerings for specified domain(s) and zone(s) URL: https://github.com/apache/cloudstack/pull/3248#issuecomment-505341617 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3248: [WIP DO NOT MERGE] server: offerings for specified domain(s) and zone(s)
rhtyd commented on issue #3248: [WIP DO NOT MERGE] server: offerings for specified domain(s) and zone(s) URL: https://github.com/apache/cloudstack/pull/3248#issuecomment-505341539 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3246: server: allow disk offering selection for volume from snapshot
rhtyd commented on issue #3246: server: allow disk offering selection for volume from snapshot URL: https://github.com/apache/cloudstack/pull/3246#issuecomment-505341004 This can be merged as soon as the tests are in and are OK. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd edited a comment on issue #3415: Fix interval descrption
rhtyd edited a comment on issue #3415: Fix interval descrption URL: https://github.com/apache/cloudstack/pull/3415#issuecomment-505340681 Since this is strictly a doc string change, LGTM based on travis job1 https://travis-ci.org/apache/cloudstack/jobs/549120173, packging+smoketests are not necessary. @anuragaw @shwstppr @nvazquez please review This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3415: Fix interval descrption
rhtyd commented on issue #3415: Fix interval descrption URL: https://github.com/apache/cloudstack/pull/3415#issuecomment-505340681 Since this is strictly a doc string change, LGTM based on travis job #1, packging+smoketests are not necessary. @anuragaw @shwstppr @nvazquez please review This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd removed a comment on issue #3415: Fix interval descrption
rhtyd removed a comment on issue #3415: Fix interval descrption URL: https://github.com/apache/cloudstack/pull/3415#issuecomment-505340163 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3415: Fix interval descrption
rhtyd commented on issue #3415: Fix interval descrption URL: https://github.com/apache/cloudstack/pull/3415#issuecomment-505340163 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on a change in pull request #3421: RvR: VPC redundant vrs run on same hypervisor
rhtyd commented on a change in pull request #3421: RvR: VPC redundant vrs run
on same hypervisor
URL: https://github.com/apache/cloudstack/pull/3421#discussion_r297060395
##
File path: server/src/com/cloud/network/router/NetworkHelperImpl.java
##
@@ -388,6 +388,19 @@ public DomainRouterVO startVirtualRouter(final
DomainRouterVO router, final User
routerToBeAvoid = rrouter;
}
}
+} else if (router.getVpcId() != null) {
+final List routerList =
_routerDao.listByVpcId(router.getVpcId());
+for (final DomainRouterVO rrouter : routerList) {
+if (rrouter.getHostId() != null &&
rrouter.getIsRedundantRouter() && rrouter.getState() == State.Running) {
+if (routerToBeAvoid != null) {
Review comment:
should this also check that the routerList.size() is >= 2?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3240: [WIP DO NOT MERGE] api: instance and template details are free text
blueorangutan commented on issue #3240: [WIP DO NOT MERGE] api: instance and template details are free text URL: https://github.com/apache/cloudstack/pull/3240#issuecomment-505335529 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3240: [WIP DO NOT MERGE] api: instance and template details are free text
rhtyd commented on issue #3240: [WIP DO NOT MERGE] api: instance and template details are free text URL: https://github.com/apache/cloudstack/pull/3240#issuecomment-505335453 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3228: [WIP DO NOT MERGE] api: snapshot, snapshotpolicy tag support
blueorangutan commented on issue #3228: [WIP DO NOT MERGE] api: snapshot, snapshotpolicy tag support URL: https://github.com/apache/cloudstack/pull/3228#issuecomment-505328380 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-13 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3228: [WIP DO NOT MERGE] api: snapshot, snapshotpolicy tag support
blueorangutan commented on issue #3228: [WIP DO NOT MERGE] api: snapshot, snapshotpolicy tag support URL: https://github.com/apache/cloudstack/pull/3228#issuecomment-505323540 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-12 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3228: [WIP DO NOT MERGE] api: snapshot, snapshotpolicy tag support
blueorangutan commented on issue #3228: [WIP DO NOT MERGE] api: snapshot, snapshotpolicy tag support URL: https://github.com/apache/cloudstack/pull/3228#issuecomment-505321402 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] borisstoyanov commented on issue #3228: [WIP DO NOT MERGE] api: snapshot, snapshotpolicy tag support
borisstoyanov commented on issue #3228: [WIP DO NOT MERGE] api: snapshot, snapshotpolicy tag support URL: https://github.com/apache/cloudstack/pull/3228#issuecomment-505321122 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3417: engine/schema: add upgrade path for source 4.11.2.0 version
rhtyd commented on issue #3417: engine/schema: add upgrade path for source 4.11.2.0 version URL: https://github.com/apache/cloudstack/pull/3417#issuecomment-505317743 KVM env test failed due to backend IP-range issues, I've rekicked the test job. Will merge this as soon as the KVM tests are in. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] anuragaw commented on issue #3228: [WIP DO NOT MERGE] api: snapshot, snapshotpolicy tag support
anuragaw commented on issue #3228: [WIP DO NOT MERGE] api: snapshot, snapshotpolicy tag support URL: https://github.com/apache/cloudstack/pull/3228#issuecomment-505316461 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3228: [WIP DO NOT MERGE] api: snapshot, snapshotpolicy tag support
blueorangutan commented on issue #3228: [WIP DO NOT MERGE] api: snapshot, snapshotpolicy tag support URL: https://github.com/apache/cloudstack/pull/3228#issuecomment-505316548 @anuragaw a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] anuragaw commented on issue #3228: [WIP DO NOT MERGE] api: snapshot, snapshotpolicy tag support
anuragaw commented on issue #3228: [WIP DO NOT MERGE] api: snapshot, snapshotpolicy tag support URL: https://github.com/apache/cloudstack/pull/3228#issuecomment-505315292 Updated heght of the dilague box -  @andrijapanic , @rhtyd , @shwstppr This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] shwstppr commented on issue #3248: [WIP DO NOT MERGE] server: offerings for specified domain(s) and zone(s)
shwstppr commented on issue #3248: [WIP DO NOT MERGE] server: offerings for specified domain(s) and zone(s) URL: https://github.com/apache/cloudstack/pull/3248#issuecomment-505314088 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
