[GitHub] [cloudstack] blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available

2019-07-22 Thread GitBox
blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow 
configuring appliances on the VM instance wizard when OVF properties are 
available
URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-514078496
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-171


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] digitalgust opened a new issue #3509: 4.12 add host fail , using tls connection

2019-07-22 Thread GitBox
digitalgust opened a new issue #3509: 4.12 add host fail ,using tls connection
URL: https://github.com/apache/cloudstack/issues/3509
 
 
   
Bug Report
   
   # ISSUE TYPE
   
* Bug Report
* Improvement Request
* Enhancement Request
* Feature Idea
* Documentation Report
* Other
   
   # COMPONENT NAME
   INSTALL
   
   
   ~~~
   
   ~~~
   
   # CLOUDSTACK VERSION
   4.12
   
   
   ~~~
   
   ~~~
   
   # CONFIGURATION
   advanced networking
   
   
   
   # OS / ENVIRONMENT
   CentOS7.6
   
   
   
   # SUMMARY
   
   
I am an experience user of cloudstack ,  we built enterprise private cloud 
in cloudstack two years .
   now we test the new 4.12 version  for update .
   we install management ok.
   install agent in hypervisor ok.
   but we encounter an issue when add first zone.  one of step is add host,  
4.12 using tls  comucation with agent and manager, but  libvirtd connect 
error , tls can't work ,the host note as alert .
   
   add host log like:
   
   
   
   # STEPS TO REPRODUCE
   
   
   
   ~~~
   
   ~~~
   
   
   
   # EXPECTED RESULTS
   
   
   ~~~
   
   ~~~
   
   # ACTUAL RESULTS
   
   2019-07-23 01:07:30,306 INFO  [utils.nio.NioClient] (main:null) (logid:) 
Connecting to localhost:8250
   2019-07-23 01:07:30,306 WARN  [utils.nio.NioConnection] (main:null) (logid:) 
Unable to connect to remote: is there a server running on port 8250
   2019-07-23 01:07:35,307 INFO  [cloud.agent.Agent] (main:null) (logid:) 
Connecting to host:localhost
   2019-07-23 01:07:35,308 INFO  [utils.nio.NioClient] (main:null) (logid:) 
Connecting to localhost:8250
   2019-07-23 01:07:35,313 WARN  [utils.nio.NioConnection] (main:null) (logid:) 
Unable to connect to remote: is there a server running on port 8250
   2019-07-23 01:07:38,229 INFO  [cloud.agent.Agent] (AgentShutdownThread:null) 
(logid:) Stopping the agent: Reason = sig.kill
   2019-07-23 01:08:50,219 INFO  [cloud.agent.AgentShell] (main:null) (logid:) 
Agent started
   2019-07-23 01:08:50,221 INFO  [cloud.agent.AgentShell] (main:null) (logid:) 
Implementation Version is 4.12.0.0
   2019-07-23 01:08:50,222 INFO  [cloud.agent.AgentShell] (main:null) (logid:) 
agent.properties found at /etc/cloudstack/agent/agent.properties
   2019-07-23 01:08:50,235 INFO  [cloud.agent.AgentShell] (main:null) (logid:) 
Defaulting to using properties file for storage
   2019-07-23 01:08:50,236 INFO  [cloud.agent.AgentShell] (main:null) (logid:) 
Defaulting to the constant time backoff algorithm
   2019-07-23 01:08:50,246 INFO  [cloud.utils.LogUtils] (main:null) (logid:) 
log4j configuration found at /etc/cloudstack/agent/log4j-cloud.xml
   2019-07-23 01:08:50,254 INFO  [cloud.agent.AgentShell] (main:null) (logid:) 
Using default Java settings for IPv6 preference for agent connection
   2019-07-23 01:08:50,355 INFO  [cloud.agent.Agent] (main:null) (logid:) id is 
   2019-07-23 01:08:50,357 WARN  [cloud.resource.ServerResourceBase] 
(main:null) (logid:) Nics are not specified in properties file/db, will try to 
autodiscover
   2019-07-23 01:08:50,361 INFO  [cloud.resource.ServerResourceBase] 
(main:null) (logid:) Designating private to be nic cloudbr0
   2019-07-23 01:08:50,374 INFO  [kvm.resource.LibvirtConnection] (main:null) 
(logid:) No existing libvirtd connection found. Opening a new one
   2019-07-23 01:08:50,529 INFO  [org.reflections.Reflections] (main:null) 
(logid:) Reflections took 26 ms to scan 1 urls, producing 7 keys and 10 values 
   2019-07-23 01:08:50,541 INFO  [kvm.resource.LibvirtComputingResource] 
(main:null) (logid:) No libvirt.vif.driver specified. Defaults to 
BridgeVifDriver.
   2019-07-23 01:08:50,646 INFO  [cloud.agent.Agent] (main:null) (logid:) Agent 
[id = new : type = LibvirtComputingResource : zone = default : pod = default : 
workers = 5 : host = localhost : port = 8250
   2019-07-23 01:08:50,650 INFO  [utils.nio.NioClient] (main:null) (logid:) 
Connecting to localhost:8250
   2019-07-23 01:08:50,651 WARN  [utils.nio.NioConnection] (main:null) (logid:) 
Unable to connect to remote: is there a server running on port 8250
   2019-07-23 01:08:55,652 INFO  [cloud.agent.Agent] (main:null) (logid:) 
Connecting to host:localhost
   2019-07-23 01:08:55,655 INFO  [utils.nio.NioClient] (main:null) (logid:) 
Connecting to localhost:8250
   2019-07-23 01:08:55,656 WARN  [utils.nio.NioConnection] (main:null) (logid:) 
Unable to connect to remote: is there a server running on port 8250
   2019-07-23 01:09:00,539 INFO  [cloud.agent.Agent] (AgentShutdownThread:null) 
(logid:) Stopping the agent: Reason = sig.kill
   2019-07-23 01:09:00,657 INFO  [cloud.agent.Agent] (main:null) (logid:) 
Connecting to host:localhost
   2019-07-23 01:09:00,659 INFO  [utils.nio.NioClient] (main:null) (logid:) 
Connecting to localhost:8250
   2019-07-23 01:09:00,660 WARN  [utils.nio.NioConnection] (main:null) (logid:) 
Unable to connect to remote: is there a server running on port 8250
   2019-07-23 

[GitHub] [cloudstack] blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available

2019-07-22 Thread GitBox
blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow 
configuring appliances on the VM instance wizard when OVF properties are 
available
URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-514073252
 
 
   @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] borisstoyanov commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available

2019-07-22 Thread GitBox
borisstoyanov commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow 
configuring appliances on the VM instance wizard when OVF properties are 
available
URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-514072998
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] jcsdatera commented on issue #3470: Datera storage plugin

2019-07-22 Thread GitBox
jcsdatera commented on issue #3470: Datera storage plugin
URL: https://github.com/apache/cloudstack/pull/3470#issuecomment-514051577
 
 
   Added integrated tests with the following test result:
   

   Attach a volume to a stopped virtual machine, then start VM ... === 
TestName: test_01_attach_new_volume_to_stopped_VM | Status : SUCCESS ===
   ok
   Attach, detach, and attach volume to a running VM ... === TestName: 
test_02_attach_detach_attach_volume | Status : SUCCESS ===
   ok
   Attach volume to running VM, then reboot. ... === TestName: 
test_03_attached_volume_reboot_VM | Status : SUCCESS ===
   ok
   
   --
   XML: /data/git/cs1/cloudstack/test/integration/nosetests.xml
   --
   Ran 3 tests in 885.349s
   
   OK


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3501: Fix stop VM issue on basic zones

2019-07-22 Thread GitBox
blueorangutan commented on issue #3501: Fix stop VM issue on basic zones
URL: https://github.com/apache/cloudstack/pull/3501#issuecomment-514049965
 
 
   @nvazquez a Trillian-Jenkins matrix job (centos6 mgmt + xs71, centos7 mgmt + 
vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] nvazquez commented on issue #3501: Fix stop VM issue on basic zones

2019-07-22 Thread GitBox
nvazquez commented on issue #3501: Fix stop VM issue on basic zones
URL: https://github.com/apache/cloudstack/pull/3501#issuecomment-514049821
 
 
   @blueorangutan test matrix


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3501: Fix stop VM issue on basic zones

2019-07-22 Thread GitBox
blueorangutan commented on issue #3501: Fix stop VM issue on basic zones
URL: https://github.com/apache/cloudstack/pull/3501#issuecomment-514049171
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-170


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3501: Fix stop VM issue on basic zones

2019-07-22 Thread GitBox
blueorangutan commented on issue #3501: Fix stop VM issue on basic zones
URL: https://github.com/apache/cloudstack/pull/3501#issuecomment-514045971
 
 
   @nvazquez a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] nvazquez commented on issue #3501: Fix stop VM issue on basic zones

2019-07-22 Thread GitBox
nvazquez commented on issue #3501: Fix stop VM issue on basic zones
URL: https://github.com/apache/cloudstack/pull/3501#issuecomment-514045834
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] nvazquez edited a comment on issue #3501: Fix stop VM issue on basic zones

2019-07-22 Thread GitBox
nvazquez edited a comment on issue #3501: Fix stop VM issue on basic zones
URL: https://github.com/apache/cloudstack/pull/3501#issuecomment-514045739
 
 
   @server24 I have pushed a fix based on your previous comment, thanks!
   
   Regarding network restart with cleanup, it is possible by previously 
changing the setting 'network.rolling.restart' to false.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] nvazquez commented on issue #3501: Fix stop VM issue on basic zones

2019-07-22 Thread GitBox
nvazquez commented on issue #3501: Fix stop VM issue on basic zones
URL: https://github.com/apache/cloudstack/pull/3501#issuecomment-514045739
 
 
   @server24 I have pushed a fix based on your previous comment, thanks!
   
   Regarding network restart with cleanup, it is possible by previously 
changing the setting 'network.rolling.restart' to false


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd edited a comment on issue #3508: Enable KVM storage data motion on KVM hypervisor_capabilities

2019-07-22 Thread GitBox
rhtyd edited a comment on issue #3508: Enable KVM storage data motion on KVM 
hypervisor_capabilities
URL: https://github.com/apache/cloudstack/pull/3508#issuecomment-513853509
 
 
   @GabrielBrascher Moved to 4.14 as this is not a blocker/critical change for 
4.13 and in 4.14 when we'll drop support for centos6 and older kvm based 
distros. Storage motion was not enabled by default in 4.13 and older because it 
may not work on centos6 as it works with newer libvirt/distros such on centos7 
with qemu-ev and with Ubuntu 16.04/18.04+.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3480: [WIP DO NOT MERGE] engine, server, services: fix for respecting secondary storage threshold limit

2019-07-22 Thread GitBox
blueorangutan commented on issue #3480: [WIP DO NOT MERGE] engine, server, 
services: fix for respecting secondary storage threshold limit
URL: https://github.com/apache/cloudstack/pull/3480#issuecomment-514011698
 
 
   Trillian test result (tid-192)
   Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 42101 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3480-t192-vmware-65u2.zip
   Intermittent failure detected: /marvin/tests/smoke/test_network.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers.py
   Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
   Intermittent failure detected: /marvin/tests/smoke/test_usage.py
   Smoke tests completed. 74 look OK, 3 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_reboot_router | `Error` | 325.60 | test_network.py
   test_02_list_snapshots_with_removed_data_store | `Error` | 1.16 | 
test_snapshots.py
   test_01_volume_usage | `Error` | 9.29 | test_usage.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3500: kvm/bridge: Allow Link Local Cidr (cloud0 interface) to be configured

2019-07-22 Thread GitBox
blueorangutan commented on issue #3500: kvm/bridge: Allow Link Local Cidr 
(cloud0 interface) to be configured
URL: https://github.com/apache/cloudstack/pull/3500#issuecomment-513988168
 
 
   Trillian test result (tid-191)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 35446 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3500-t191-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 76 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_05_rvpc_multi_tiers | `Failure` | 417.48 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Error` | 446.76 | test_vpc_redundant.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3477: RvR: Set up metadata/password/dhcp server on gateway IP instead of guest IP in RVR

2019-07-22 Thread GitBox
blueorangutan commented on issue #3477: RvR: Set up metadata/password/dhcp 
server on gateway IP instead of guest IP in RVR
URL: https://github.com/apache/cloudstack/pull/3477#issuecomment-513949908
 
 
   Trillian test result (tid-190)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 35609 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3477-t190-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_accounts.py
   Intermittent failure detected: /marvin/tests/smoke/test_iso.py
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermittent failure detected: /marvin/tests/smoke/test_templates.py
   Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
   Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 70 look OK, 7 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   ContextSuite context=TestTemplateHierarchy>:setup | `Error` | 1518.00 | 
test_accounts.py
   test_04_extract_Iso | `Failure` | 1.06 | test_iso.py
   test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 261.19 | 
test_privategw_acl.py
   test_04_extract_template | `Failure` | 1.07 | test_templates.py
   test_06_download_detached_volume | `Failure` | 9.31 | test_volumes.py
   test_01_cancel_host_maintenace_with_no_migration_jobs | `Failure` | 1.10 | 
test_host_maintenance.py
   test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 3.43 | 
test_host_maintenance.py
   test_hostha_enable_ha_when_host_disabled | `Error` | 4.46 | 
test_hostha_kvm.py
   test_hostha_enable_ha_when_host_in_maintenance | `Error` | 303.51 | 
test_hostha_kvm.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3501: Fix stop VM issue on basic zones

2019-07-22 Thread GitBox
blueorangutan commented on issue #3501: Fix stop VM issue on basic zones
URL: https://github.com/apache/cloudstack/pull/3501#issuecomment-513935365
 
 
   Trillian test result (tid-188)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 35351 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3501-t188-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 76 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_05_rvpc_multi_tiers | `Failure` | 414.60 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Error` | 440.82 | test_vpc_redundant.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[cloudstack-documentation] branch master updated: KVM direct downloads (#54)

2019-07-22 Thread paul_a
This is an automated email from the ASF dual-hosted git repository.

paul_a pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git


The following commit(s) were added to refs/heads/master by this push:
 new 86e3834  KVM direct downloads (#54)
86e3834 is described below

commit 86e38340b77aebf7af3bfc54752fe0311254fa34
Author: Nicolas Vazquez 
AuthorDate: Mon Jul 22 16:33:41 2019 -0300

KVM direct downloads (#54)

Update documentation for KVM direct downloads
---
 source/_static/images/kvm-direct-download.png  | Bin 0 -> 6710 bytes
 source/adminguide/templates.rst|   3 +
 .../templates/_bypass-secondary-storage-kvm.rst|  90 +
 3 files changed, 93 insertions(+)

diff --git a/source/_static/images/kvm-direct-download.png 
b/source/_static/images/kvm-direct-download.png
new file mode 100644
index 000..d29dab6
Binary files /dev/null and b/source/_static/images/kvm-direct-download.png 
differ
diff --git a/source/adminguide/templates.rst b/source/adminguide/templates.rst
index 51f2361..ca4f96d 100644
--- a/source/adminguide/templates.rst
+++ b/source/adminguide/templates.rst
@@ -273,6 +273,8 @@ To upload a template:
   the Featured Templates list. Only an administrator can make a
   template Featured.
 
+.. include:: templates/_bypass-secondary-storage-kvm.rst
+
 Uploading Templates from a local computer
 ---
 
@@ -319,3 +321,4 @@ template.
:alt: Depicts hiding the EULA page.
 .. |change-admin-password.png| image:: 
/_static/images/change-admin-password.png
:alt: Depicts changing the administrator password
+.. |kvm-direct-download.png| image:: /_static/images/kvm-direct-download.png
diff --git a/source/adminguide/templates/_bypass-secondary-storage-kvm.rst 
b/source/adminguide/templates/_bypass-secondary-storage-kvm.rst
new file mode 100644
index 000..7f6de4c
--- /dev/null
+++ b/source/adminguide/templates/_bypass-secondary-storage-kvm.rst
@@ -0,0 +1,90 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
+   or more contributor license agreements.  See the NOTICE file
+   distributed with this work for additional information#
+   regarding copyright ownership.  The ASF licenses this file
+   to you under the Apache License, Version 2.0 (the
+   "License"); you may not use this file except in compliance
+   with the License.  You may obtain a copy of the License at
+   http://www.apache.org/licenses/LICENSE-2.0
+   Unless required by applicable law or agreed to in writing,
+   software distributed under the License is distributed on an
+   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+   KIND, either express or implied.  See the License for the
+   specific language governing permissions and limitations
+   under the License.
+
+
+.. _bypass-secondary-storage-kvm:
+
+Bypassing Secondary Storage For KVM templates
+
+
+CloudStack provides an additional way to register and use templates on KVM.
+
+Instead of registering a template and storing it on secondary storage, the 
user can opt to skip downloading the template to secondary storage for KVM at 
template registration. At deployment time, the template is downloaded directly 
to primary storage from the registered source, instead of being copied from 
secondary storage.
+
+Supported protocols: HTTP/HTTPS, NFS and metalinks. The protocol is obtained 
from the template URL.
+
+To enable this option for a template:
+
+#. In the left navigation bar, click Templates.
+
+#. Click Register Template.
+
+#. Select KVM as hypervisor:
+
+   |kvm-direct-download.png|
+
+   -  **Direct Download**. This option will be shown in the UI when KVM is 
selected as the hypervisor. Choose Yes to enable the bypassing secondary 
storage option.
+
+   -  **Checksum**. Optional field. If this field is populated, the checksum 
is compared to the downloaded template checksum when the template is downloaded 
to primary storage at deployment time.
+
+After the template is registered, it is automatically available for VM 
deployments.
+
+Uploading Certificates for Direct Downloads
+~~~
+For direct downloads over HTTPS, the KVM hosts must have valid certificates. 
These certificates can be either self-signed or signed and will allow the KVM 
hosts to access the templates/ISOs and download them.
+
+CloudStack provides some APIs to handle certificates for direct downloads:
+
+- Upload a certificate to hosts in 'Up' state in a zone with id = ZONE_ID:
+
+   .. code:: bash
+
+ upload templatedirectdownloadcertificate hypervisor=KVM 
name=CERTIFICATE_ALIAS zoneid=ZONE_ID certificate=CERTIFICATE_FORMATTED
+
+   where:
+  - CERTIFICATE_FORMATTED is the string format of a X509 certificate
+  - CERTIFICATE_ALIAS is the alias which will be used to import the 
certificate on each KVM host
+
+   **Note:**.

[cloudstack] branch master updated: server: fix the subnet overlap checking logic for tagged and untagged vlans when adding ipranges (#3430)

2019-07-22 Thread rohit
This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/master by this push:
 new 5690cd6  server: fix the subnet overlap checking logic for tagged and 
untagged vlans when adding ipranges (#3430)
5690cd6 is described below

commit 5690cd636427eb70ea09a732bf75163ec77af15e
Author: Anurag Awasthi 
AuthorDate: Tue Jul 23 00:27:50 2019 +0530

server: fix the subnet overlap checking logic for tagged and untagged vlans 
when adding ipranges (#3430)

Fixes: #3114

When adding iprange for VLANs there are 3 cases -

VLAN under consideration has a tag (like 101)
VLAN under consideration has a tag but as a range (like 101-124)
VLAN is untagged (i.e. id is "untagged")
Before adding iprange we have to check for possible overlaps and throw 
exception. This needs to be done as follows -

If VLAN Tag ID is numeric or a range we need to call 
UriUtils.checkVlanUriOverlapmethod which internally tries to expand the range 
as verifies if there are overlaps. If URI overlaps (i.e. there are overlapping 
VLAN tags) we then need to verify if the iprange being added overlaps with 
previously added ranges.
If there are no overlapping tags we simply need to test for public networks 
being present in the VLAN.
A Regression was introduced in 
41fdb88#diff-6e2b61984e8fa2823bb47da3caafa4eeR3174 which caused comparing 
'untagged' string as a numeric VLAN Tag range and and attempted expanding it to 
test overlap in UriUtils.checkVlanUriOverlap.

To fix the bug in the issue, we need to handle the untagged case separately 
as it's non-numeric tag in code. For untagged VLANs and overlapping VLAN URIs 
we need to check for ipranges and gateways which happens naturally after this 
change. For tagged VLANs with non-overlapping URIs we need to check if there is 
a public network.
---
 .../configuration/ConfigurationManagerImpl.java| 45 +++---
 1 file changed, 23 insertions(+), 22 deletions(-)

diff --git 
a/server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java 
b/server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
index bf238b0..2c71f0d 100755
--- a/server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
+++ b/server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
@@ -3815,29 +3815,10 @@ public class ConfigurationManagerImpl extends 
ManagerBase implements Configurati
 continue;
 }
 // from here, subnet overlaps
-if (!UriUtils.checkVlanUriOverlap(
+if (vlanId.toLowerCase().contains(Vlan.UNTAGGED) || 
UriUtils.checkVlanUriOverlap(
 
BroadcastDomainType.getValue(BroadcastDomainType.fromString(vlanId)),
 
BroadcastDomainType.getValue(BroadcastDomainType.fromString(vlan.getVlanTag()
 {
-boolean overlapped = false;
-if( network.getTrafficType() == TrafficType.Public ) {
-overlapped = true;
-} else {
-final Long nwId = vlan.getNetworkId();
-if ( nwId != null ) {
-final Network nw = _networkModel.getNetwork(nwId);
-if ( nw != null && nw.getTrafficType() == 
TrafficType.Public ) {
-overlapped = true;
-}
-}
-
-}
-if ( overlapped ) {
-throw new InvalidParameterValueException("The IP range 
with tag: " + vlan.getVlanTag()
-+ " in zone " + zone.getName()
-+ " has overlapped with the subnet. Please 
specify a different gateway/netmask.");
-}
-} else {
-
+// For untagged VLAN Id and overlapping URIs we need to 
expand and verify IP ranges
 final String[] otherVlanIpRange = 
vlan.getIpRange().split("\\-");
 final String otherVlanStartIP = otherVlanIpRange[0];
 String otherVlanEndIP = null;
@@ -3854,9 +3835,29 @@ public class ConfigurationManagerImpl extends 
ManagerBase implements Configurati
 if (!NetUtils.is31PrefixCidr(newCidr)) {
 if (NetUtils.ipRangesOverlap(startIP, endIP, 
otherVlanStartIP, otherVlanEndIP)) {
 throw new InvalidParameterValueException("The IP 
range already has IPs that overlap with the new range." +
-" Please specify a different start IP/end 
IP.");
+" Please specify a different start IP/end 
IP.");
 }
 

[GitHub] [cloudstack] rhtyd merged pull request #3430: server: fix the subnet overlap checking logic for tagged and untagged vlans when adding ipranges

2019-07-22 Thread GitBox
rhtyd merged pull request #3430: server: fix the subnet overlap checking logic 
for tagged and untagged vlans when adding ipranges
URL: https://github.com/apache/cloudstack/pull/3430
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd closed issue #3114: One can no longer add multiple Public IP ranges, which share the same subnet.

2019-07-22 Thread GitBox
rhtyd closed issue #3114: One can no longer add multiple Public IP ranges, 
which share the same subnet.
URL: https://github.com/apache/cloudstack/issues/3114
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3430: server: fix the subnet overlap checking logic for tagged and untagged vlans when adding ipranges

2019-07-22 Thread GitBox
blueorangutan commented on issue #3430: server: fix the subnet overlap checking 
logic for tagged and untagged vlans when adding ipranges
URL: https://github.com/apache/cloudstack/pull/3430#issuecomment-513910226
 
 
   Trillian test result (tid-185)
   Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 44166 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3430-t185-vmware-65u2.zip
   Intermittent failure detected: /marvin/tests/smoke/test_network.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers.py
   Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
   Intermittent failure detected: /marvin/tests/smoke/test_usage.py
   Smoke tests completed. 74 look OK, 3 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_08_start_router | `Error` | 74.34 | test_routers.py
   test_09_reboot_router | `Error` | 1.14 | test_routers.py
   test_02_list_snapshots_with_removed_data_store | `Error` | 1.22 | 
test_snapshots.py
   test_01_volume_usage | `Error` | 9.47 | test_usage.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] nvazquez commented on issue #3505: Agent LB for CloudStack failed

2019-07-22 Thread GitBox
nvazquez commented on issue #3505: Agent LB for CloudStack failed
URL: https://github.com/apache/cloudstack/issues/3505#issuecomment-513874010
 
 
   Thanks, @div8cn. @rhtyd we'll to address this issue as it takes 15 minutes 
to connect to the next mgmt server


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] nvazquez commented on issue #3501: Fix stop VM issue on basic zones

2019-07-22 Thread GitBox
nvazquez commented on issue #3501: Fix stop VM issue on basic zones
URL: https://github.com/apache/cloudstack/pull/3501#issuecomment-513868837
 
 
   @rhtyd @server24 I'll address the open comments today


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] nvazquez commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available

2019-07-22 Thread GitBox
nvazquez commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow 
configuring appliances on the VM instance wizard when OVF properties are 
available
URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-513868429
 
 
   Yes working on it with @borisstoyanov, will update this asap


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] GabrielBrascher commented on issue #3278: systemvm: new qemu-guest-agent based patching for KVM

2019-07-22 Thread GitBox
GabrielBrascher commented on issue #3278: systemvm: new qemu-guest-agent based 
patching for KVM
URL: https://github.com/apache/cloudstack/pull/3278#issuecomment-513863987
 
 
   @svenvogel @wido I am taking a look into this. Deploying a 4.13 staging 
environment, I hope to have feedback soon.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] wido commented on a change in pull request #3500: kvm/bridge: Allow Link Local Cidr (cloud0 interface) to be configured

2019-07-22 Thread GitBox
wido commented on a change in pull request #3500: kvm/bridge: Allow Link Local 
Cidr (cloud0 interface) to be configured
URL: https://github.com/apache/cloudstack/pull/3500#discussion_r305921492
 
 

 ##
 File path: utils/src/main/java/com/cloud/utils/net/NetUtils.java
 ##
 @@ -962,26 +962,29 @@ public static String getLinkLocalNetMask() {
 }
 
 public static String getLinkLocalGateway() {
-return "169.254.0.1";
+return getLinkLocalFirstAddressFromCIDR(getLinkLocalCIDR());
 }
 
 public static String getLinkLocalCIDR() {
 return "169.254.0.0/16";
 
 Review comment:
   Do we have access to the configuration here? I don't think so. Therefor I 
changed it this way.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] wido commented on a change in pull request #3500: kvm/bridge: Allow Link Local Cidr (cloud0 interface) to be configured

2019-07-22 Thread GitBox
wido commented on a change in pull request #3500: kvm/bridge: Allow Link Local 
Cidr (cloud0 interface) to be configured
URL: https://github.com/apache/cloudstack/pull/3500#discussion_r305921221
 
 

 ##
 File path: 
plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/resource/BridgeVifDriverTest.java
 ##
 @@ -55,4 +55,5 @@ public void isValidProtocolAndVnetId() {
 Assert.assertTrue(driver.isValidProtocolAndVnetId("123", "vlan"));
 Assert.assertTrue(driver.isValidProtocolAndVnetId("456", "vxlan"));
 }
+
 
 Review comment:
   Argh!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] wido commented on a change in pull request #3500: kvm/bridge: Allow Link Local Cidr (cloud0 interface) to be configured

2019-07-22 Thread GitBox
wido commented on a change in pull request #3500: kvm/bridge: Allow Link Local 
Cidr (cloud0 interface) to be configured
URL: https://github.com/apache/cloudstack/pull/3500#discussion_r305921173
 
 

 ##
 File path: 
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java
 ##
 @@ -397,15 +403,16 @@ private void deleteExistingLinkLocalRouteTable(String 
linkLocalBr) {
 }
 final String device = tokens[2];
 if (!Strings.isNullOrEmpty(device) && 
!device.equalsIgnoreCase(linkLocalBr)) {
-Script.runSimpleBashScript("ip route del " + 
NetUtils.getLinkLocalCIDR() + " dev " + tokens[2]);
+Script.runSimpleBashScript("ip route del " + _controlCidr 
+ " dev " + tokens[2]);
 } else {
 foundLinkLocalBr = true;
 }
 }
 }
+
 if (!foundLinkLocalBr) {
-Script.runSimpleBashScript("ip address add 169.254.0.1/16 dev " + 
linkLocalBr + ";" + "ip route add " + NetUtils.getLinkLocalCIDR() + " dev " + 
linkLocalBr + " src " +
-NetUtils.getLinkLocalGateway());
+Script.runSimpleBashScript("ip address add " + 
NetUtils.getLinkLocalAddressFromCIDR(_controlCidr) + " dev " + linkLocalBr);
+Script.runSimpleBashScript("ip route add " + _controlCidr + " dev 
" + linkLocalBr + " src " + 
NetUtils.getLinkLocalFirstAddressFromCIDR(_controlCidr));
 
 Review comment:
   Could be, but there aren't many methods calling it. I see what you mean, I 
don't have a try preference for it though.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] wido commented on a change in pull request #3500: kvm/bridge: Allow Link Local Cidr (cloud0 interface) to be configured

2019-07-22 Thread GitBox
wido commented on a change in pull request #3500: kvm/bridge: Allow Link Local 
Cidr (cloud0 interface) to be configured
URL: https://github.com/apache/cloudstack/pull/3500#discussion_r305920932
 
 

 ##
 File path: 
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/IvsVifDriver.java
 ##
 @@ -1,296 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-package com.cloud.hypervisor.kvm.resource;
-
-import java.io.File;
-import java.util.Map;
-import java.util.regex.Matcher;
-import java.util.regex.Pattern;
-
-import javax.naming.ConfigurationException;
-
-import org.apache.log4j.Logger;
-import org.libvirt.LibvirtException;
-
-import com.cloud.agent.api.to.NicTO;
-import com.cloud.exception.InternalErrorException;
-import com.cloud.hypervisor.kvm.resource.LibvirtVMDef.InterfaceDef;
-import com.cloud.network.Networks;
-import com.cloud.utils.NumbersUtil;
-import com.cloud.utils.net.NetUtils;
-import com.cloud.utils.script.OutputInterpreter;
-import com.cloud.utils.script.Script;
-
-public class IvsVifDriver extends VifDriverBase {
 
 Review comment:
   This file is removed. It seems also that it was a type or some case.
   
   It was unused, so that's why this PR removes it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd commented on a change in pull request #3480: [WIP DO NOT MERGE] engine, server, services: fix for respecting secondary storage threshold limit

2019-07-22 Thread GitBox
rhtyd commented on a change in pull request #3480: [WIP DO NOT MERGE] engine, 
server, services: fix for respecting secondary storage threshold limit
URL: https://github.com/apache/cloudstack/pull/3480#discussion_r305917673
 
 

 ##
 File path: 
engine/api/src/main/java/org/apache/cloudstack/engine/subsystem/api/storage/DataStoreManager.java
 ##
 @@ -33,7 +33,11 @@
 
 List getImageStoresByScope(ZoneScope scope);
 
-DataStore getImageStore(long zoneId);
+DataStore getImageStoreForRead(long zoneId);
 
 Review comment:
   `getRandomImageStore` or something that conveys meaning? You may also put 
javadocs on them to convey which method does what?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd commented on a change in pull request #3480: [WIP DO NOT MERGE] engine, server, services: fix for respecting secondary storage threshold limit

2019-07-22 Thread GitBox
rhtyd commented on a change in pull request #3480: [WIP DO NOT MERGE] engine, 
server, services: fix for respecting secondary storage threshold limit
URL: https://github.com/apache/cloudstack/pull/3480#discussion_r305917156
 
 

 ##
 File path: 
engine/api/src/main/java/org/apache/cloudstack/engine/subsystem/api/storage/DataStoreManager.java
 ##
 @@ -33,7 +33,11 @@
 
 List getImageStoresByScope(ZoneScope scope);
 
-DataStore getImageStore(long zoneId);
+DataStore getImageStoreForRead(long zoneId);
+
+DataStore getImageStoreForWrite(long zoneId);
+
+List getImageStoresForWrite(long zoneId);
 
 Review comment:
   Rename it something more meaningful like `listImagesStoresWithFreeCapacity`?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd commented on a change in pull request #3480: [WIP DO NOT MERGE] engine, server, services: fix for respecting secondary storage threshold limit

2019-07-22 Thread GitBox
rhtyd commented on a change in pull request #3480: [WIP DO NOT MERGE] engine, 
server, services: fix for respecting secondary storage threshold limit
URL: https://github.com/apache/cloudstack/pull/3480#discussion_r305917264
 
 

 ##
 File path: 
engine/api/src/main/java/org/apache/cloudstack/engine/subsystem/api/storage/DataStoreManager.java
 ##
 @@ -33,7 +33,11 @@
 
 List getImageStoresByScope(ZoneScope scope);
 
-DataStore getImageStore(long zoneId);
+DataStore getImageStoreForRead(long zoneId);
+
+DataStore getImageStoreForWrite(long zoneId);
 
 Review comment:
   How about getImagesStoresWithFreeCapacity?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd commented on issue #3500: kvm/bridge: Allow Link Local Cidr (cloud0 interface) to be configured

2019-07-22 Thread GitBox
rhtyd commented on issue #3500: kvm/bridge: Allow Link Local Cidr (cloud0 
interface) to be configured
URL: https://github.com/apache/cloudstack/pull/3500#issuecomment-513856497
 
 
   Left some remark, some changes I'll need to re-review, meanwhile I'll wait 
for regression tests to come back.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd commented on a change in pull request #3500: kvm/bridge: Allow Link Local Cidr (cloud0 interface) to be configured

2019-07-22 Thread GitBox
rhtyd commented on a change in pull request #3500: kvm/bridge: Allow Link Local 
Cidr (cloud0 interface) to be configured
URL: https://github.com/apache/cloudstack/pull/3500#discussion_r305916094
 
 

 ##
 File path: 
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/IvsVifDriver.java
 ##
 @@ -1,296 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-package com.cloud.hypervisor.kvm.resource;
-
-import java.io.File;
-import java.util.Map;
-import java.util.regex.Matcher;
-import java.util.regex.Pattern;
-
-import javax.naming.ConfigurationException;
-
-import org.apache.log4j.Logger;
-import org.libvirt.LibvirtException;
-
-import com.cloud.agent.api.to.NicTO;
-import com.cloud.exception.InternalErrorException;
-import com.cloud.hypervisor.kvm.resource.LibvirtVMDef.InterfaceDef;
-import com.cloud.network.Networks;
-import com.cloud.utils.NumbersUtil;
-import com.cloud.utils.net.NetUtils;
-import com.cloud.utils.script.OutputInterpreter;
-import com.cloud.utils.script.Script;
-
-public class IvsVifDriver extends VifDriverBase {
 
 Review comment:
   Ping @wido @GabrielBrascher is this unused class? If you not sure, can you 
not remove it?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available

2019-07-22 Thread GitBox
rhtyd commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring 
appliances on the VM instance wizard when OVF properties are available
URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-513855830
 
 
   Tests LGTM, the failure on vmware are known/seen 
https://github.com/apache/cloudstack/issues/3507
   @nvazquez can you address any outstanding issues if any, we would want to 
freeze master asap.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd commented on issue #3502: Rbd snapshot rollback

2019-07-22 Thread GitBox
rhtyd commented on issue #3502: Rbd snapshot rollback
URL: https://github.com/apache/cloudstack/pull/3502#issuecomment-513855031
 
 
   Left a minor remark, tests also LGTM.
   We can merge this as soon as any outstanding issues are fixed and we've 
another lgtm @GabrielBrascher 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[cloudstack-documentation] branch master updated: Network offering scopes (#55)

2019-07-22 Thread paul_a
This is an automated email from the ASF dual-hosted git repository.

paul_a pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git


The following commit(s) were added to refs/heads/master by this push:
 new 663838d  Network offering scopes (#55)
663838d is described below

commit 663838db60feba84d9ac7f1c4538146a2f82ba1c
Author: Paul Angus 
AuthorDate: Mon Jul 22 17:26:20 2019 +0100

Network offering scopes (#55)

update network offering configuration text to allow for multi-domain and 
multi-zone
---
 source/_global.rst|  1 +
 source/adminguide/networking.rst  | 70 ++-
 source/upgrading/upgrade/upgrade-4.12.rst |  1 -
 3 files changed, 43 insertions(+), 29 deletions(-)

diff --git a/source/_global.rst b/source/_global.rst
index 7f2b439..d7a83ba 100644
--- a/source/_global.rst
+++ b/source/_global.rst
@@ -24,6 +24,7 @@
 .. |documentation_home| replace:: http://docs.cloudstack.apache.org/
 
 .. Latest version systemvm template name
+
 .. |sysvm64-name-xen|replace:: systemvm-xenserver-4.11.3
 .. |sysvm64-name-kvm|replace:: systemvm-kvm-4.11.3
 .. |sysvm64-name-vmware| replace:: systemvm-vmware-4.11.3
diff --git a/source/adminguide/networking.rst b/source/adminguide/networking.rst
index fe16847..ec8d2d3 100644
--- a/source/adminguide/networking.rst
+++ b/source/adminguide/networking.rst
@@ -340,41 +340,40 @@ To create a network offering:
-  **LB Isolation**: Specify what type of load balancer isolation you
   want for the network: Shared or Dedicated.
 
-  **Dedicated**: If you select dedicated LB isolation, a dedicated
-  load balancer device is assigned for the network from the pool of
-  dedicated load balancer devices provisioned in the zone. If no
-  sufficient dedicated load balancer devices are available in the
-  zone, network creation fails. Dedicated device is a good choice
-  for the high-traffic networks that make full use of the device's
-  resources.
-
-  **Shared**: If you select shared LB isolation, a shared load
-  balancer device is assigned for the network from the pool of
-  shared load balancer devices provisioned in the zone. While
-  provisioning CloudStack picks the shared load balancer device that
-  is used by the least number of accounts. Once the device reaches
-  its maximum capacity, the device will not be allocated to a new
-  account.
+  -  **Dedicated**: If you select dedicated LB isolation, a dedicated
+ load balancer device is assigned for the network from the pool of
+ dedicated load balancer devices provisioned in the zone. If no
+ sufficient dedicated load balancer devices are available in the
+ zone, network creation fails. Dedicated device is a good choice
+ for the high-traffic networks that make full use of the device's
+ resources.
+
+  -  **Shared**: If you select shared LB isolation, a shared load
+ balancer device is assigned for the network from the pool of
+ shared load balancer devices provisioned in the zone. While
+ provisioning CloudStack picks the shared load balancer device that
+ is used by the least number of accounts. Once the device reaches
+ its maximum capacity, the device will not be allocated to a new
+ account.
 
-  **Mode**: You can select either Inline mode or Side by Side mode:
 
-  **Inline mode**: Supported only for Juniper SRX firewall and BigF5
-  load balancer devices. In inline mode, a firewall device is placed
-  in front of a load balancing device. The firewall acts as the
-  gateway for all the incoming traffic, then redirect the load
-  balancing traffic to the load balancer behind it. The load
-  balancer in this case will not have the direct access to the
-  public network.
-
-  **Side by Side**: In side by side mode, a firewall device is
-  deployed in parallel with the load balancer device. So the traffic
-  to the load balancer public IP is not routed through the firewall,
-  and therefore, is exposed to the public network.
+  -  **Inline mode**: Supported only for Juniper SRX firewall and BigF5
+ load balancer devices. In inline mode, a firewall device is placed
+ in front of a load balancing device. The firewall acts as the
+ gateway for all the incoming traffic, then redirect the load
+ balancing traffic to the load balancer behind it. The load
+ balancer in this case will not have the direct access to the
+ public network.
+  
+  -  **Side by Side**: In side by side mode, a firewall device is
+ deployed in parallel with the load balancer device. So the traffic
+ to the load balancer public IP is not routed through the firewall,
+ and therefore, is exposed to the public network.
 
-  **Associat

[GitHub] [cloudstack] rhtyd commented on issue #3501: Fix stop VM issue on basic zones

2019-07-22 Thread GitBox
rhtyd commented on issue #3501: Fix stop VM issue on basic zones
URL: https://github.com/apache/cloudstack/pull/3501#issuecomment-513855338
 
 
   @server24 can you test the PR?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd commented on a change in pull request #3502: Rbd snapshot rollback

2019-07-22 Thread GitBox
rhtyd commented on a change in pull request #3502: Rbd snapshot rollback
URL: https://github.com/apache/cloudstack/pull/3502#discussion_r305914726
 
 

 ##
 File path: 
engine/storage/snapshot/src/main/resources/META-INF/cloudstack/storage/spring-engine-storage-snapshot-storage-context.xml
 ##
 @@ -32,6 +32,9 @@
 
 
+
+

[GitHub] [cloudstack] rhtyd commented on a change in pull request #3502: Rbd snapshot rollback

2019-07-22 Thread GitBox
rhtyd commented on a change in pull request #3502: Rbd snapshot rollback
URL: https://github.com/apache/cloudstack/pull/3502#discussion_r305914471
 
 

 ##
 File path: 
engine/storage/snapshot/src/main/java/org/apache/cloudstack/storage/snapshot/CephSnapshotStrategy.java
 ##
 @@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.cloudstack.storage.snapshot;
+
+import javax.inject.Inject;
+
+import org.apache.cloudstack.engine.subsystem.api.storage.SnapshotInfo;
+import 
org.apache.cloudstack.engine.subsystem.api.storage.SnapshotStrategy.SnapshotOperation;
+import org.apache.cloudstack.engine.subsystem.api.storage.StrategyPriority;
+import org.apache.cloudstack.engine.subsystem.api.storage.VolumeInfo;
+import org.apache.cloudstack.storage.datastore.db.PrimaryDataStoreDao;
+import org.apache.cloudstack.storage.datastore.db.SnapshotDataStoreDao;
+import org.apache.cloudstack.storage.datastore.db.SnapshotDataStoreVO;
+import org.apache.cloudstack.storage.datastore.db.StoragePoolVO;
+import org.apache.log4j.Logger;
+import org.springframework.stereotype.Component;
+
+import com.cloud.storage.DataStoreRole;
+import com.cloud.storage.Snapshot;
+import com.cloud.storage.Storage.ImageFormat;
+import com.cloud.storage.Storage.StoragePoolType;
+import com.cloud.storage.VolumeVO;
+import com.cloud.storage.dao.VolumeDao;
+
+@Component
 
 Review comment:
   We don't have `@Component` scanning, please remove this annotation and 
instead place the class/bean in respective spring xml context file (if not done 
already).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure

2019-07-22 Thread GitBox
blueorangutan commented on issue #3425: [WIP DO NOT MERGE] Better tracking host 
maintanence success and failure
URL: https://github.com/apache/cloudstack/pull/3425#issuecomment-513853588
 
 
   Trillian test result (tid-187)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 34153 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3425-t187-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Smoke tests completed. 76 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_cancel_host_maintenace_with_migration_jobs | `Failure` | 415.08 | 
test_host_maintenance.py
   test_03_cancel_host_maintenace_with_migration_jobs_ports_blocked | `Error` | 
190.93 | test_host_maintenance.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd commented on issue #3508: Enable KVM storage data motion on KVM hypervisor_capabilities

2019-07-22 Thread GitBox
rhtyd commented on issue #3508: Enable KVM storage data motion on KVM 
hypervisor_capabilities
URL: https://github.com/apache/cloudstack/pull/3508#issuecomment-513853509
 
 
   @GabrielBrascher Moved to 4.14 as this is not a blocker changes and in 4.14 
when we'll drop support for centos6 and older kvm based distros. Storage motion 
was not enabled by default in 4.13 and older because it may not work on centos6 
as it works with newer libvirt/distros such on centos7 with qemu-ev and with 
Ubuntu 16.04/18.04+.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] GabrielBrascher opened a new pull request #3508: Enable KVM storage data motion on KVM hypervisor_capabilities

2019-07-22 Thread GitBox
GabrielBrascher opened a new pull request #3508: Enable KVM storage data motion 
on KVM hypervisor_capabilities
URL: https://github.com/apache/cloudstack/pull/3508
 
 
   ## Description
   
   Considering that we have addressed a considerable effort on allowing KVM to 
perform storage data motion, this PR proposes updating the 
'hypervisor_capabilities' table setting the 'storage_motion_supported' to '1' 
for KVM.
   
   **PRs that implemented KVM storage motion features:**
   - Non-managed storages
   #2997 KVM VM live migration with ROOT volume on file storage type
   #2983 KVM live storage migration intra cluster from NFS source and 
destination
   - Managed storages
   #2298 CLOUDSTACK-9620: Enhancements for managed storage
   
   
   
   
   
   
   
   ## Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3502: Rbd snapshot rollback

2019-07-22 Thread GitBox
blueorangutan commented on issue #3502: Rbd snapshot rollback
URL: https://github.com/apache/cloudstack/pull/3502#issuecomment-513820643
 
 
   Trillian test result (tid-186)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 29023 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3502-t186-kvm-centos7.zip
   Smoke tests completed. 77 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3350: [WIP] Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router

2019-07-22 Thread GitBox
blueorangutan commented on issue #3350: [WIP] Get Diagnostics: Download logs 
and diagnostics data from SSVM, CPVM, Router
URL: https://github.com/apache/cloudstack/pull/3350#issuecomment-513807278
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-169


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3350: [WIP] Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router

2019-07-22 Thread GitBox
blueorangutan commented on issue #3350: [WIP] Get Diagnostics: Download logs 
and diagnostics data from SSVM, CPVM, Router
URL: https://github.com/apache/cloudstack/pull/3350#issuecomment-513798610
 
 
   @anuragaw a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] anuragaw commented on issue #3350: [WIP] Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router

2019-07-22 Thread GitBox
anuragaw commented on issue #3350: [WIP] Get Diagnostics: Download logs and 
diagnostics data from SSVM, CPVM, Router
URL: https://github.com/apache/cloudstack/pull/3350#issuecomment-513798377
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] shwstppr commented on issue #3480: [WIP DO NOT MERGE] engine, server, services: fix for respecting secondary storage threshold limit

2019-07-22 Thread GitBox
shwstppr commented on issue #3480: [WIP DO NOT MERGE] engine, server, services: 
fix for respecting secondary storage threshold limit
URL: https://github.com/apache/cloudstack/pull/3480#issuecomment-513780478
 
 
   @rhtyd yes I made the changes for vmware migration issue. Would help if you 
can review last 2 commits


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


Jenkins build is back to normal : cloudstack-marvin #2727

2019-07-22 Thread Apache Jenkins Server
See 




[GitHub] [cloudstack] blueorangutan commented on issue #3480: [WIP DO NOT MERGE] engine, server, services: fix for respecting secondary storage threshold limit

2019-07-22 Thread GitBox
blueorangutan commented on issue #3480: [WIP DO NOT MERGE] engine, server, 
services: fix for respecting secondary storage threshold limit
URL: https://github.com/apache/cloudstack/pull/3480#issuecomment-513778495
 
 
   @shwstppr a Trillian-Jenkins test job (centos7 mgmt + vmware-65u2) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] shwstppr commented on issue #3480: [WIP DO NOT MERGE] engine, server, services: fix for respecting secondary storage threshold limit

2019-07-22 Thread GitBox
shwstppr commented on issue #3480: [WIP DO NOT MERGE] engine, server, services: 
fix for respecting secondary storage threshold limit
URL: https://github.com/apache/cloudstack/pull/3480#issuecomment-513778383
 
 
   @blueorangutan test centos7 vmware-65u2


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3500: kvm/bridge: Allow Link Local Cidr (cloud0 interface) to be configured

2019-07-22 Thread GitBox
blueorangutan commented on issue #3500: kvm/bridge: Allow Link Local Cidr 
(cloud0 interface) to be configured
URL: https://github.com/apache/cloudstack/pull/3500#issuecomment-513775544
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3500: kvm/bridge: Allow Link Local Cidr (cloud0 interface) to be configured

2019-07-22 Thread GitBox
blueorangutan commented on issue #3500: kvm/bridge: Allow Link Local Cidr 
(cloud0 interface) to be configured
URL: https://github.com/apache/cloudstack/pull/3500#issuecomment-513774925
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-168


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd commented on issue #3500: kvm/bridge: Allow Link Local Cidr (cloud0 interface) to be configured

2019-07-22 Thread GitBox
rhtyd commented on issue #3500: kvm/bridge: Allow Link Local Cidr (cloud0 
interface) to be configured
URL: https://github.com/apache/cloudstack/pull/3500#issuecomment-513775174
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3480: [WIP DO NOT MERGE] engine, server, services: fix for respecting secondary storage threshold limit

2019-07-22 Thread GitBox
blueorangutan commented on issue #3480: [WIP DO NOT MERGE] engine, server, 
services: fix for respecting secondary storage threshold limit
URL: https://github.com/apache/cloudstack/pull/3480#issuecomment-513774836
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-167


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd closed issue #3503: create snapshot fail with error domain not found

2019-07-22 Thread GitBox
rhtyd closed issue #3503: create snapshot fail with error domain not found
URL: https://github.com/apache/cloudstack/issues/3503
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd commented on issue #3503: create snapshot fail with error domain not found

2019-07-22 Thread GitBox
rhtyd commented on issue #3503: create snapshot fail with error domain not found
URL: https://github.com/apache/cloudstack/issues/3503#issuecomment-513763571
 
 
   This is not a problem, stopped VMs cannot have VM snapshot but only volume 
snapshot.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd commented on issue #3505: Agent LB for CloudStack failed

2019-07-22 Thread GitBox
rhtyd commented on issue #3505: Agent LB for CloudStack failed
URL: https://github.com/apache/cloudstack/issues/3505#issuecomment-513763399
 
 
   @nvazquez any comments, is this a valid bug?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] skattoju4 commented on issue #3486: filter volumes by host when refreshing stats

2019-07-22 Thread GitBox
skattoju4 commented on issue #3486: filter volumes by host when refreshing stats
URL: https://github.com/apache/cloudstack/pull/3486#issuecomment-513763347
 
 
   yes you are right. better to factor it out...
   
   On Mon., Jul. 22, 2019, 7:29 a.m. dahn,  wrote:
   
   > *@DaanHoogland* approved this pull request.
   > --
   >
   > In server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
   > :
   >
   > >  List neighbors = 
_resourceMgr.listHostsInClusterByStatus(clusterId, Status.Up);
   >  for (HostVO neighbor : neighbors) {
   > -GetVolumeStatsCommand cmd = new 
GetVolumeStatsCommand(poolType, poolUuid, volumeLocator);
   > +StoragePool storagePool = 
_storagePoolDao.findPoolByUUID(poolUuid);
   > +List volumeLocatorsForHost;
   > +if (storagePool.isManaged()) {
   > +List vmsPerHost = 
_vmDao.listByHostId(neighbor.getId());
   >
   > looks good but can you isolate the body of the if in a method like filter
   > hostsToQueryForVmVolumes() (and maybe add a test)? Please don't kill me but
   > it is kind of hard to read like this.
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > 
,
   > or mute the thread
   > 

   > .
   >
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd commented on issue #3501: Fix stop VM issue on basic zones

2019-07-22 Thread GitBox
rhtyd commented on issue #3501: Fix stop VM issue on basic zones
URL: https://github.com/apache/cloudstack/pull/3501#issuecomment-513763237
 
 
   @DaanHoogland it has been discussed but a concrete plan has not been 
proposed. I think that's a very long term thing, till then the feature should 
be supported like other features.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[cloudstack] branch master updated (e1fa270 -> 38f97c6)

2019-07-22 Thread rohit
This is an automated email from the ASF dual-hosted git repository.

rohit pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


from e1fa270  vmware: fix volume stats logic (#3473)
 add 38f97c6  server: Fix hardcoded max data volumes when VM has been 
created but not started before (#3494)

No new revisions were added by this update.

Summary of changes:
 .../com/cloud/hypervisor/dao/HypervisorCapabilitiesDao.java |  2 ++
 .../cloud/hypervisor/dao/HypervisorCapabilitiesDaoImpl.java | 13 +
 .../main/java/com/cloud/storage/VolumeApiServiceImpl.java   | 12 +++-
 .../java/com/cloud/storage/VolumeApiServiceImplTest.java|  3 +++
 4 files changed, 29 insertions(+), 1 deletion(-)



[GitHub] [cloudstack] rhtyd merged pull request #3494: Fix hardcoded max data volumes when VM has been created but not started before

2019-07-22 Thread GitBox
rhtyd merged pull request #3494: Fix hardcoded max data volumes when VM has 
been created but not started before
URL: https://github.com/apache/cloudstack/pull/3494
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd commented on issue #3494: Fix hardcoded max data volumes when VM has been created but not started before

2019-07-22 Thread GitBox
rhtyd commented on issue #3494: Fix hardcoded max data volumes when VM has been 
created but not started before
URL: https://github.com/apache/cloudstack/pull/3494#issuecomment-513762684
 
 
   Tests LGTM, they are failing irrespective of this PR.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd commented on issue #3500: kvm/bridge: Allow Link Local Cidr (cloud0 interface) to be configured

2019-07-22 Thread GitBox
rhtyd commented on issue #3500: kvm/bridge: Allow Link Local Cidr (cloud0 
interface) to be configured
URL: https://github.com/apache/cloudstack/pull/3500#issuecomment-513762433
 
 
   @wido cc @GabrielBrascher - can you review the oustanding comments. Tests 
LGTM.
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3500: kvm/bridge: Allow Link Local Cidr (cloud0 interface) to be configured

2019-07-22 Thread GitBox
blueorangutan commented on issue #3500: kvm/bridge: Allow Link Local Cidr 
(cloud0 interface) to be configured
URL: https://github.com/apache/cloudstack/pull/3500#issuecomment-513762636
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3480: [WIP DO NOT MERGE] engine, server, services: fix for respecting secondary storage threshold limit

2019-07-22 Thread GitBox
blueorangutan commented on issue #3480: [WIP DO NOT MERGE] engine, server, 
services: fix for respecting secondary storage threshold limit
URL: https://github.com/apache/cloudstack/pull/3480#issuecomment-513762353
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd commented on issue #3480: [WIP DO NOT MERGE] engine, server, services: fix for respecting secondary storage threshold limit

2019-07-22 Thread GitBox
rhtyd commented on issue #3480: [WIP DO NOT MERGE] engine, server, services: 
fix for respecting secondary storage threshold limit
URL: https://github.com/apache/cloudstack/pull/3480#issuecomment-513762082
 
 
   @shwstppr were the vmware specific fixes also done? You can kick tests now.
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd closed issue #3416: VMware: volume statistics show wrong values

2019-07-22 Thread GitBox
rhtyd closed issue #3416: VMware: volume statistics show wrong values
URL: https://github.com/apache/cloudstack/issues/3416
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] andrijapanicsb opened a new issue #3416: VMware: volume statistics show wrong values

2019-07-22 Thread GitBox
andrijapanicsb opened a new issue #3416: VMware: volume statistics show wrong 
values
URL: https://github.com/apache/cloudstack/issues/3416
 
 
   # ISSUE TYPE
   
* Bug Report
   
   # COMPONENT NAME
   
   ~~~
   GetVolumeStatsCommand
   ~~~
   
   # CLOUDSTACK VERSION
   
   
   ~~~
   4.11+ (tested 4.11.2 and Master)
   ~~~
   
   # CONFIGURATION
   
   NA
   
   # OS / ENVIRONMENT
   
   NA
   
   # SUMMARY
   
   
   physical volume size reported is wrong, and doesn't change after you write a 
lot of data to the VM's root disk (be it linked clone or full clone)
   
   # STEPS TO REPRODUCE
   
   configure "volume.stats.interval" to 6 (these are milliseconds, not 
seconds as stated atm - I raised a separate PR for this).
   
   1. Grep management-server.log for "GetVolumeStatsCommand" and observe it's 
running each minute
   
   2. Inside the VM, write i.e. 50MB to disk  -  "dd=/dev/urandom of=ddfile 
bs=1M count=50; sync"
   
   3. Wait for next run of GetVolumeStatsCommand from the mgmt logs - check the 
size reported in the text output and also on the GUI
   
   
   
   # EXPECTED RESULTS
   
   
   
   Correct physical size is reported
   
   
   # ACTUAL RESULTS
   
   
   
   
   
   0.53KB reported instead of the real size (linked clone - from image bellow 
is ~ 220MB)
   
   
![image](https://user-images.githubusercontent.com/45762285/59966004-09ef2f00-9516-11e9-93d0-397d5db15802.png)
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[cloudstack] branch master updated: vmware: fix volume stats logic (#3473)

2019-07-22 Thread rohit
This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/master by this push:
 new e1fa270  vmware: fix volume stats logic (#3473)
e1fa270 is described below

commit e1fa270593bb49ccbc85ffa2315570b8d7d8b2e1
Author: Rohit Yadav 
AuthorDate: Mon Jul 22 17:27:41 2019 +0530

vmware: fix volume stats logic (#3473)

During volume stats calculation, if a volume has more than one disk in
the chain-info it is not used to sum the physical and virtual size
in the loop, instead any previous entry was overwritten by the last disk.

Signed-off-by: Rohit Yadav 
---
 .../com/cloud/hypervisor/vmware/resource/VmwareResource.java | 12 ++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git 
a/plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 
b/plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java
index c195712..141f2f6 100644
--- 
a/plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java
+++ 
b/plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java
@@ -3612,8 +3612,16 @@ public class VmwareResource implements 
StoragePoolResource, ServerResource, Vmwa
 Pair vds = 
vmMo.getDiskDevice(file.getFileName(), true);
 long virtualsize = 
vds.first().getCapacityInKB() * 1024;
 long physicalsize = 
primaryStorageDatastoreMo.fileDiskSize(file.getPath());
-VolumeStatsEntry vse = new 
VolumeStatsEntry(chainInfo, physicalsize, virtualsize);
-statEntry.put(chainInfo, vse);
+if (statEntry.containsKey(chainInfo)) {
+VolumeStatsEntry vse = 
statEntry.get(chainInfo);
+if (vse != null) {
+
vse.setPhysicalSize(vse.getPhysicalSize() + physicalsize);
+
vse.setVirtualSize(vse.getVirtualSize() + virtualsize);
+}
+} else {
+VolumeStatsEntry vse = new 
VolumeStatsEntry(chainInfo, physicalsize, virtualsize);
+statEntry.put(chainInfo, vse);
+}
 }
 }
 }



[GitHub] [cloudstack] rhtyd commented on issue #3416: VMware: volume statistics show wrong values

2019-07-22 Thread GitBox
rhtyd commented on issue #3416: VMware: volume statistics show wrong values
URL: https://github.com/apache/cloudstack/issues/3416#issuecomment-513761524
 
 
   Reopened due to this case where flat files are not part of the chain/info 
and are ignored in stats calculations: 
https://github.com/apache/cloudstack/pull/3473#issuecomment-512731291


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd merged pull request #3473: vmware: fix volume stats logic

2019-07-22 Thread GitBox
rhtyd merged pull request #3473: vmware: fix volume stats logic
URL: https://github.com/apache/cloudstack/pull/3473
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd commented on issue #3473: vmware: fix volume stats logic

2019-07-22 Thread GitBox
rhtyd commented on issue #3473: vmware: fix volume stats logic
URL: https://github.com/apache/cloudstack/pull/3473#issuecomment-513761297
 
 
   Merging this based on lgtms and reviews. It's possible that more fixes need 
to be done, but at least this change ensures that multi-chained disks are not 
ignored. I'll keep the original issue open but close/merge this PR.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[cloudstack] branch master updated: server: disable unauthenticated integration.api.port by default (#3504)

2019-07-22 Thread rohit
This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/master by this push:
 new 6a336f8  server: disable unauthenticated integration.api.port by 
default (#3504)
6a336f8 is described below

commit 6a336f8bc11b80846ed86e188fa6e5da18524d69
Author: Gabriel Beims Bräscher 
AuthorDate: Mon Jul 22 08:52:02 2019 -0300

server: disable unauthenticated integration.api.port by default (#3504)

Set integration.api.port to (0) zero as default. CloudStack provides 
CloudStack API Unauthenticated Access through port 8096. It should not be open 
to the Internet in any case.
---
 server/src/main/java/com/cloud/api/ApiServer.java | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/server/src/main/java/com/cloud/api/ApiServer.java 
b/server/src/main/java/com/cloud/api/ApiServer.java
index a8ab7b0..cc9ec73 100644
--- a/server/src/main/java/com/cloud/api/ApiServer.java
+++ b/server/src/main/java/com/cloud/api/ApiServer.java
@@ -228,8 +228,8 @@ public class ApiServer extends ManagerBase implements 
HttpRequestHandler, ApiSer
 private static final ConfigKey IntegrationAPIPort = new 
ConfigKey("Advanced"
 , Integer.class
 , "integration.api.port"
-, "8096"
-, "Default API port"
+, "0"
+, "Integration (unauthenticated) API port. To disable set it to 0 
or negative."
 , false
 , ConfigKey.Scope.Global);
 private static final ConfigKey ConcurrentSnapshotsThresholdPerHost = 
new ConfigKey("Advanced"



[GitHub] [cloudstack] rhtyd merged pull request #3504: Set integration.api.port to 0 (zero) as default.

2019-07-22 Thread GitBox
rhtyd merged pull request #3504: Set integration.api.port to 0 (zero) as 
default.
URL: https://github.com/apache/cloudstack/pull/3504
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd closed issue #3450: Port 8096 allows unauthenticated access from any IP.

2019-07-22 Thread GitBox
rhtyd closed issue #3450: Port 8096 allows unauthenticated access from any IP.
URL: https://github.com/apache/cloudstack/issues/3450
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd commented on issue #3504: Set integration.api.port to 0 (zero) as default.

2019-07-22 Thread GitBox
rhtyd commented on issue #3504: Set integration.api.port to 0 (zero) as default.
URL: https://github.com/apache/cloudstack/pull/3504#issuecomment-513759495
 
 
   Trillian is full capacity, merging this based on Travis job 
https://travis-ci.org/apache/cloudstack/jobs/561936104 and lgtms


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3504: Set integration.api.port to 0 (zero) as default.

2019-07-22 Thread GitBox
blueorangutan commented on issue #3504: Set integration.api.port to 0 (zero) as 
default.
URL: https://github.com/apache/cloudstack/pull/3504#issuecomment-513756972
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-166


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3486: filter volumes by host when refreshing stats

2019-07-22 Thread GitBox
DaanHoogland commented on a change in pull request #3486: filter volumes by 
host when refreshing stats
URL: https://github.com/apache/cloudstack/pull/3486#discussion_r305795840
 
 

 ##
 File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
 ##
 @@ -1904,10 +1904,21 @@ public void removeCustomOfferingDetails(long vmId) {
 }
 
 @Override
-public HashMap getVolumeStatistics(long 
clusterId, String poolUuid, StoragePoolType poolType, List 
volumeLocator, int timeout) {
+public HashMap getVolumeStatistics(long 
clusterId, String poolUuid, StoragePoolType poolType, List 
volumeLocators, int timeout) {
 List neighbors = 
_resourceMgr.listHostsInClusterByStatus(clusterId, Status.Up);
 for (HostVO neighbor : neighbors) {
-GetVolumeStatsCommand cmd = new GetVolumeStatsCommand(poolType, 
poolUuid, volumeLocator);
+StoragePool storagePool = _storagePoolDao.findPoolByUUID(poolUuid);
+List volumeLocatorsForHost;
+if (storagePool.isManaged()) {
+List vmsPerHost = 
_vmDao.listByHostId(neighbor.getId());
 
 Review comment:
   looks good but can you isolate the body of the if in a method like filter 
hostsToQueryForVmVolumes() (and maybe add a test)? Please don't kill me but it 
is kind of hard to read like this.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3504: Set integration.api.port to 0 (zero) as default.

2019-07-22 Thread GitBox
blueorangutan commented on issue #3504: Set integration.api.port to 0 (zero) as 
default.
URL: https://github.com/apache/cloudstack/pull/3504#issuecomment-513751074
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd commented on issue #3504: Set integration.api.port to 0 (zero) as default.

2019-07-22 Thread GitBox
rhtyd commented on issue #3504: Set integration.api.port to 0 (zero) as default.
URL: https://github.com/apache/cloudstack/pull/3504#issuecomment-513750873
 
 
   @blueorangutan package
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland commented on issue #3501: Fix stop VM issue on basic zones

2019-07-22 Thread GitBox
DaanHoogland commented on issue #3501: Fix stop VM issue on basic zones
URL: https://github.com/apache/cloudstack/pull/3501#issuecomment-513748922
 
 
   Aren't we going to drop support for basic zones? How does this fit in that 
scenario? cc @GabrielBrascher @wido @rhtyd 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3477: RvR: Set up metadata/password/dhcp server on gateway IP instead of guest IP in RVR

2019-07-22 Thread GitBox
blueorangutan commented on issue #3477: RvR: Set up metadata/password/dhcp 
server on gateway IP instead of guest IP in RVR
URL: https://github.com/apache/cloudstack/pull/3477#issuecomment-513736729
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd commented on issue #3477: RvR: Set up metadata/password/dhcp server on gateway IP instead of guest IP in RVR

2019-07-22 Thread GitBox
rhtyd commented on issue #3477: RvR: Set up metadata/password/dhcp server on 
gateway IP instead of guest IP in RVR
URL: https://github.com/apache/cloudstack/pull/3477#issuecomment-513736478
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3477: RvR: Set up metadata/password/dhcp server on gateway IP instead of guest IP in RVR

2019-07-22 Thread GitBox
blueorangutan commented on issue #3477: RvR: Set up metadata/password/dhcp 
server on gateway IP instead of guest IP in RVR
URL: https://github.com/apache/cloudstack/pull/3477#issuecomment-513729286
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-165


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3152: Refactoring to remove duplicate code.

2019-07-22 Thread GitBox
blueorangutan commented on issue #3152: Refactoring to remove duplicate code.
URL: https://github.com/apache/cloudstack/pull/3152#issuecomment-513722336
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3501: Fix stop VM issue on basic zones

2019-07-22 Thread GitBox
blueorangutan commented on issue #3501: Fix stop VM issue on basic zones
URL: https://github.com/apache/cloudstack/pull/3501#issuecomment-513722328
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3477: RvR: Set up metadata/password/dhcp server on gateway IP instead of guest IP in RVR

2019-07-22 Thread GitBox
blueorangutan commented on issue #3477: RvR: Set up metadata/password/dhcp 
server on gateway IP instead of guest IP in RVR
URL: https://github.com/apache/cloudstack/pull/3477#issuecomment-513722315
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd commented on issue #3477: RvR: Set up metadata/password/dhcp server on gateway IP instead of guest IP in RVR

2019-07-22 Thread GitBox
rhtyd commented on issue #3477: RvR: Set up metadata/password/dhcp server on 
gateway IP instead of guest IP in RVR
URL: https://github.com/apache/cloudstack/pull/3477#issuecomment-513722182
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd commented on issue #3152: Refactoring to remove duplicate code.

2019-07-22 Thread GitBox
rhtyd commented on issue #3152: Refactoring to remove duplicate code.
URL: https://github.com/apache/cloudstack/pull/3152#issuecomment-513722010
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd commented on issue #3501: Fix stop VM issue on basic zones

2019-07-22 Thread GitBox
rhtyd commented on issue #3501: Fix stop VM issue on basic zones
URL: https://github.com/apache/cloudstack/pull/3501#issuecomment-513722075
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3504: Set integration.api.port to 0 (zero) as default.

2019-07-22 Thread GitBox
blueorangutan commented on issue #3504: Set integration.api.port to 0 (zero) as 
default.
URL: https://github.com/apache/cloudstack/pull/3504#issuecomment-513667057
 
 
   Packaging result: ✖centos6 ✔centos7 ✔debian. JID-163


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3501: Fix stop VM issue on basic zones

2019-07-22 Thread GitBox
blueorangutan commented on issue #3501: Fix stop VM issue on basic zones
URL: https://github.com/apache/cloudstack/pull/3501#issuecomment-513667056
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-164


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3152: Refactoring to remove duplicate code.

2019-07-22 Thread GitBox
blueorangutan commented on issue #3152: Refactoring to remove duplicate code.
URL: https://github.com/apache/cloudstack/pull/3152#issuecomment-51374
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-161


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3477: RvR: Set up metadata/password/dhcp server on gateway IP instead of guest IP in RVR

2019-07-22 Thread GitBox
blueorangutan commented on issue #3477: RvR: Set up metadata/password/dhcp 
server on gateway IP instead of guest IP in RVR
URL: https://github.com/apache/cloudstack/pull/3477#issuecomment-51375
 
 
   Packaging result: ✔centos6 ✖centos7 ✔debian. JID-162


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services