[GitHub] [cloudstack] digitalgust edited a comment on issue #3509: 4.12 add host fail , using tls connection

2019-07-30 Thread GitBox
digitalgust edited a comment on issue #3509: 4.12 add host fail ,using tls 
connection
URL: https://github.com/apache/cloudstack/issues/3509#issuecomment-515991276
 
 
   I reinstall cloudstack ,it works with these changes :
   exchange cloudbr0 /cloudbr1 bridge to physic nic, maybe unrelated that .
   uninstall qemu2.9 and reinstall centos7 qemu (1.53) , maybe the problem 
cause.
   
   after reinstall , agent connect to mgmt quickly.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] kioie opened a new pull request #3532: Add new "Add volume" button, to add volume to VM instance directly

2019-07-30 Thread GitBox
kioie opened a new pull request #3532: Add new "Add volume" button, to add 
volume to VM instance directly
URL: https://github.com/apache/cloudstack/pull/3532
 
 
   ## Description
   
   Volume button to allow user to quickly add volume to a VM instance.
   Also slight edit of createVolumeCmd to allow for direct volume attachment to 
VM.
   
   
   
   
   
   
   
   ## Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [x] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   ![Screen Shot 2019-07-30 at 8 31 17 
PM](https://user-images.githubusercontent.com/20902920/62169307-94eef080-b330-11e9-8856-8c732551295b.png)
   
   ![Screen Shot 2019-07-30 at 8 35 08 
PM](https://user-images.githubusercontent.com/20902920/62169326-9e785880-b330-11e9-9de8-148bdea14903.png)
   
   ![Screen Shot 2019-07-30 at 8 35 46 
PM](https://user-images.githubusercontent.com/20902920/62169358-a801c080-b330-11e9-90bc-c3034c7357b6.png)
   Volume already attached to instance
   
   ![Screen Shot 2019-07-30 at 8 37 38 
PM](https://user-images.githubusercontent.com/20902920/62169377-b64fdc80-b330-11e9-98b2-0187396ed153.png)
   Trying to attach Volume to VM instance with snapshots
   ## How Has This Been Tested?
   
   
   
   Tested createVolume API
   Tried to attach Volume to VM instance with snapshots
   Tried to attach Volume to VM instance without snapshots
   Tried to attach Volume to running VM
   Tried to attach Volume to stopped VM
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[cloudstack-documentation] branch template-sharing-doc-update updated (0dd6804 -> 52803c5)

2019-07-30 Thread andrijapanic
This is an automated email from the ASF dual-hosted git repository.

andrijapanic pushed a change to branch template-sharing-doc-update
in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git.


from 0dd6804  typos fix
 add 52803c5  minor fix

No new revisions were added by this update.

Summary of changes:
 source/adminguide/templates.rst | 10 +-
 1 file changed, 9 insertions(+), 1 deletion(-)



[cloudstack-documentation] branch template-sharing-doc-update updated (44b0392 -> 0dd6804)

2019-07-30 Thread andrijapanic
This is an automated email from the ASF dual-hosted git repository.

andrijapanic pushed a change to branch template-sharing-doc-update
in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git.


from 44b0392  images
 add 0dd6804  typos fix

No new revisions were added by this update.

Summary of changes:
 source/adminguide/templates.rst | 19 +--
 1 file changed, 9 insertions(+), 10 deletions(-)



[cloudstack-documentation] branch template-sharing-doc-update updated (8a5e64f -> 44b0392)

2019-07-30 Thread andrijapanic
This is an automated email from the ASF dual-hosted git repository.

andrijapanic pushed a change to branch template-sharing-doc-update
in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git.


from 8a5e64f  Template sharing doc update
 add 44b0392  images

No new revisions were added by this update.

Summary of changes:
 source/_static/images/template-permissions-update-1.PNG | Bin 0 -> 20073 bytes
 source/_static/images/template-permissions-update-2.PNG | Bin 0 -> 21337 bytes
 source/_static/images/template-permissions-update-3.PNG | Bin 0 -> 19891 bytes
 source/_static/images/template-permissions-update-4.PNG | Bin 0 -> 20761 bytes
 source/_static/images/template-permissions-update-5.PNG | Bin 0 -> 14706 bytes
 .../images/template-permissions-update-manually-1.PNG   | Bin 0 -> 18295 bytes
 .../images/template-permissions-update-manually-2.PNG   | Bin 0 -> 18484 bytes
 7 files changed, 0 insertions(+), 0 deletions(-)
 create mode 100644 source/_static/images/template-permissions-update-1.PNG
 create mode 100644 source/_static/images/template-permissions-update-2.PNG
 create mode 100644 source/_static/images/template-permissions-update-3.PNG
 create mode 100644 source/_static/images/template-permissions-update-4.PNG
 create mode 100644 source/_static/images/template-permissions-update-5.PNG
 create mode 100644 
source/_static/images/template-permissions-update-manually-1.PNG
 create mode 100644 
source/_static/images/template-permissions-update-manually-2.PNG



[cloudstack-documentation] branch template-sharing-doc-update created (now 8a5e64f)

2019-07-30 Thread andrijapanic
This is an automated email from the ASF dual-hosted git repository.

andrijapanic pushed a change to branch template-sharing-doc-update
in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git.


  at 8a5e64f  Template sharing doc update

This branch includes the following new commits:

 new 8a5e64f  Template sharing doc update

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.




[cloudstack-documentation] 01/01: Template sharing doc update

2019-07-30 Thread andrijapanic
This is an automated email from the ASF dual-hosted git repository.

andrijapanic pushed a commit to branch template-sharing-doc-update
in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git

commit 8a5e64f97166265a7b813ed42ece9ef6bb4f5346
Author: Andrija Panic <45762285+andrijapani...@users.noreply.github.com>
AuthorDate: Tue Jul 30 18:52:52 2019 +0200

Template sharing doc update
---
 source/adminguide/templates.rst | 57 +++--
 1 file changed, 55 insertions(+), 2 deletions(-)

diff --git a/source/adminguide/templates.rst b/source/adminguide/templates.rst
index 07c0423..d4e64e0 100644
--- a/source/adminguide/templates.rst
+++ b/source/adminguide/templates.rst
@@ -207,7 +207,7 @@ Uploading Templates from a remote HTTP server
 
 
 vSphere Templates and ISOs
---
+^^
 .. warning:: 
   If you are uploading a template that was created using vSphere Client,
   be sure the OVA file does not contain an ISO. If it does, the deployment
@@ -288,6 +288,46 @@ Example GUI dialog of uploading (ISO) from local (browser) 
is given below:
 |upload-iso-from-local.png|
 
 
+Sharing templates with other accounts/projects
+--
+
+When adding a template, the owner can choose to make template public or to 
keep it private. Once the template is created, the owner can choose to share 
this template so that other accounts/projects can also use the template. 
+
+Currently, the template owner can share his template with:
+  - other acounts inside his own domain (i.e. can't share the template with 
other accounts in the subdomain of his domain or any other domains)
+  - projects where he belongs to (ie. if he is the owner/creator or projects 
of other users where he has been joined)
+
+Template permissions can be changed via updateTemplatePermissions API call or 
via GUI. It is supported to add, remove or reset (remove all) template 
permissions.
+
+When adding or removing permissons to/from a template, it is required to 
specify account/project name which is being added/removed from the template 
permissions. 
+
+Global setting "allow.user.view.all.domain.accounts" has a default value of 
"false". This makes sure that when the user wants to share a template via GUI, 
he will not be shown the list of all accounts in his domain and he will need to 
know the name of the destination account with which he is sharing the template. 
This makes sense in public clouds where each account of a single domain is a 
different tenant/customer and privacy is imperative. In this case, the user 
will be presented with a [...]
+
+|template-permissions-update-manually-1.PNG|
+Sharing template with account "user2"
+
+|template-permissions-update-manually-2.PNG|
+Revoking permissions from account "user2"
+
+But in environments where privacy within a domain is not an issues, setting 
"allow.user.view.all.domain.accounts" setting to "true" will make sure that the 
user, who is sharing the template, will be presented a more user-friendly 
multi-select list, listing all the accounts in his domain. THis is shown in the 
images below;
+
+|template-permissions-update-1.PNG|
+Sharing template with just account "user8"
+
+|template-permissions-update-2.PNG|
+Sharing template with 2 specific projects
+
+|template-permissions-update-3.PNG|
+Revoking permissins from account "user8"
+
+|template-permissions-update-4.PNG|
+Revoking permsissons from both projects previously added
+
+Finally, template permissions can be reset:
+
+
+|template-permissions-update-5.PNG"
+Reseting (removing all) permissions
 
 Exporting Templates
 ---
@@ -330,4 +370,17 @@ template.
 .. |kvm-direct-download.png| image:: /_static/images/kvm-direct-download.png
 .. |upload-iso-from-local.png| image:: 
/_static/images/upload-iso-from-local.png
:alt: Upload ISO from local
-
+.. |template-permissions-update-manually-1.PNG| image:: 
/_static/images/template-permissions-update-manually-1.PNG
+   :alt: USharing template with account "user2"
+.. |template-permissions-update-manually-2.PNG| image:: 
/_static/images/template-permissions-update-manually-2.PNG
+   :alt: Revoking permissions from account "user2"
+.. |template-permissions-update-1.PNG| image:: 
/_static/images/template-permissions-update-1.PNG
+   :alt: Sharing template with just account "user8"
+.. |template-permissions-update-2.PNG| image:: 
/_static/images/template-permissions-update-2.PNG
+   :alt: Sharing template with 2 specific projects
+.. |template-permissions-update-3.PNG| image:: 
/_static/images/template-permissions-update-3.PNG
+   :alt: Revoking permissins from account "user8"
+.. |template-permissions-update-4.PNG| image:: 
/_static/images/template-permissions-update-4.PNG
+   :alt: Revoking permsissons from both projects previously added
+.. |template-permissions-update-5.PNG| image:: 
/_static/images/template-permissions-update-5.PNG
+   :alt: 

[GitHub] [cloudstack] blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available

2019-07-30 Thread GitBox
blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow 
configuring appliances on the VM instance wizard when OVF properties are 
available
URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-516459569
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-201


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available

2019-07-30 Thread GitBox
blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow 
configuring appliances on the VM instance wizard when OVF properties are 
available
URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-516449358
 
 
   @nvazquez a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] nvazquez commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available

2019-07-30 Thread GitBox
nvazquez commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow 
configuring appliances on the VM instance wizard when OVF properties are 
available
URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-516449198
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3529: Add size to list usage records for VMSnapShotOnPrimary (type 27)

2019-07-30 Thread GitBox
blueorangutan commented on issue #3529: Add size to list usage records for 
VMSnapShotOnPrimary (type 27)
URL: https://github.com/apache/cloudstack/pull/3529#issuecomment-516422458
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-200


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3529: Add size to list usage records for VMSnapShotOnPrimary (type 27)

2019-07-30 Thread GitBox
blueorangutan commented on issue #3529: Add size to list usage records for 
VMSnapShotOnPrimary (type 27)
URL: https://github.com/apache/cloudstack/pull/3529#issuecomment-516414476
 
 
   @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] borisstoyanov commented on issue #3529: Add size to list usage records for VMSnapShotOnPrimary (type 27)

2019-07-30 Thread GitBox
borisstoyanov commented on issue #3529: Add size to list usage records for 
VMSnapShotOnPrimary (type 27)
URL: https://github.com/apache/cloudstack/pull/3529#issuecomment-516414240
 
 
   @blueorangutan package
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] digitalgust opened a new issue #3531: Create VM error in iso network/KVM

2019-07-30 Thread GitBox
digitalgust opened a new issue #3531: Create VM error  in iso network/KVM
URL: https://github.com/apache/cloudstack/issues/3531
 
 
   
   
   # ISSUE TYPE
   
* Bug Report
   
   
   # COMPONENT NAME
   
   ~~~
   Mgmt
   ~~~
   
   # CLOUDSTACK VERSION
   
   
   ~~~
   cloudstack 4.11.3.0
   template 4.11.3
   ~~~
   
   # CONFIGURATION
   
   advanced network
   
   # OS / ENVIRONMENT
   
   centos 7.6
   
   # SUMMARY
   
   
   install cloudstack , 
   add advance network zone, 
   system vm startup ok , 
   then "add isolated network" ok , state show allocated,
   then "add instance" , using "CentOS 5.5(64-bit) no GUI (KVM)" template that 
download completed.
   then error occured. 
   the main error:
   ```
   Unable to allocate vnet as a part of network Ntwk[204|Guest|8] implement 
Scope=interface com.cloud.dc.DataCenter; id=1
   ```
   full log: 
   ```
   2019-07-30 19:32:50,134 DEBUG [c.c.a.ApiServlet] 
(qtp504527234-20:ctx-0e8ecf9d) (logid:9b131587) ===START===  10.0.1.11 -- GET  
command=deployVirtualMachine=json=404db444-d810-4806-b3f9-a624e7cd9591=0c41f176-b2b4-11e9-92de-000c29a29fa5=KVM=20=b9a4919e-4c64-44c8-980c-1b40ddccf418%5B0%5D.networkid=ea5afaea-559a-42ed-8402-64d80d1b5536=test=test=us&_=1564482383498
   2019-07-30 19:32:50,138 DEBUG [c.c.a.ApiServer] 
(qtp504527234-20:ctx-0e8ecf9d ctx-4d5c6019) (logid:9b131587) CIDRs from which 
account 'Acct[29b131fa-b2b4-11e9-92de-000c29a29fa5-admin]' is allowed to 
perform API calls: 0.0.0.0/0,::/0
   2019-07-30 19:32:50,149 DEBUG [c.c.u.AccountManagerImpl] 
(qtp504527234-20:ctx-0e8ecf9d ctx-4d5c6019) (logid:9b131587) Access granted to 
Acct[29b131fa-b2b4-11e9-92de-000c29a29fa5-admin] to 
org.apache.cloudstack.quota.vo.ServiceOfferingVO$$EnhancerByCGLIB$$ac9cd3cc@5eabe31
 by AffinityGroupAccessChecker
   2019-07-30 19:32:50,149 DEBUG [c.c.u.AccountManagerImpl] 
(qtp504527234-20:ctx-0e8ecf9d ctx-4d5c6019) (logid:9b131587) Access granted to 
Acct[29b131fa-b2b4-11e9-92de-000c29a29fa5-admin] to null by 
AffinityGroupAccessChecker
   2019-07-30 19:32:50,157 DEBUG [c.c.n.NetworkModelImpl] 
(qtp504527234-20:ctx-0e8ecf9d ctx-4d5c6019) (logid:9b131587) Service 
SecurityGroup is not supported in the network id=204
   2019-07-30 19:32:50,164 DEBUG [c.c.v.UserVmManagerImpl] 
(qtp504527234-20:ctx-0e8ecf9d ctx-4d5c6019) (logid:9b131587) Rootdisksize 
override validation successful. Template root disk size 8GB Root disk size 
specified 20GB
   2019-07-30 19:32:50,170 DEBUG [c.c.v.UserVmManagerImpl] 
(qtp504527234-20:ctx-0e8ecf9d ctx-4d5c6019) (logid:9b131587) Allocating in the 
DB for vm
   2019-07-30 19:32:50,180 DEBUG [c.c.v.VirtualMachineManagerImpl] 
(qtp504527234-20:ctx-0e8ecf9d ctx-4d5c6019) (logid:9b131587) Allocating entries 
for VM: VM[User|i-2-4-VM]
   2019-07-30 19:32:50,181 DEBUG [c.c.v.VirtualMachineManagerImpl] 
(qtp504527234-20:ctx-0e8ecf9d ctx-4d5c6019) (logid:9b131587) Allocating nics 
for VM[User|i-2-4-VM]
   2019-07-30 19:32:50,181 DEBUG [o.a.c.e.o.NetworkOrchestrator] 
(qtp504527234-20:ctx-0e8ecf9d ctx-4d5c6019) (logid:9b131587) Allocating nic for 
vm VM[User|i-2-4-VM] in network Ntwk[204|Guest|8] with requested profile 
NicProfile[0-0-null-null-null
   2019-07-30 19:32:50,194 DEBUG [c.c.n.NetworkModelImpl] 
(qtp504527234-20:ctx-0e8ecf9d ctx-4d5c6019) (logid:9b131587) Service 
SecurityGroup is not supported in the network id=204
   2019-07-30 19:32:50,196 DEBUG [c.c.v.VirtualMachineManagerImpl] 
(qtp504527234-20:ctx-0e8ecf9d ctx-4d5c6019) (logid:9b131587) Allocating disks 
for VM[User|i-2-4-VM]
   2019-07-30 19:32:50,198 DEBUG [o.a.c.e.o.VolumeOrchestrator] 
(qtp504527234-20:ctx-0e8ecf9d ctx-4d5c6019) (logid:9b131587) Using root disk 
size of 21474836480 Bytes for volume ROOT-4
   2019-07-30 19:32:50,204 DEBUG [c.c.r.ResourceLimitManagerImpl] 
(qtp504527234-20:ctx-0e8ecf9d ctx-4d5c6019) (logid:9b131587) Updating resource 
Type = volume count for Account = 2 Operation = increasing Amount = 1
   2019-07-30 19:32:50,209 DEBUG [c.c.r.ResourceLimitManagerImpl] 
(qtp504527234-20:ctx-0e8ecf9d ctx-4d5c6019) (logid:9b131587) Updating resource 
Type = primary_storage count for Account = 2 Operation = increasing Amount = 
21474836480
   2019-07-30 19:32:50,213 DEBUG [c.c.v.VirtualMachineManagerImpl] 
(qtp504527234-20:ctx-0e8ecf9d ctx-4d5c6019) (logid:9b131587) Allocation 
completed for VM: VM[User|i-2-4-VM]
   2019-07-30 19:32:50,213 DEBUG [c.c.v.UserVmManagerImpl] 
(qtp504527234-20:ctx-0e8ecf9d ctx-4d5c6019) (logid:9b131587) Successfully 
allocated DB entry for VM[User|i-2-4-VM]
   2019-07-30 19:32:50,215 DEBUG [c.c.r.ResourceLimitManagerImpl] 
(qtp504527234-20:ctx-0e8ecf9d ctx-4d5c6019) (logid:9b131587) Updating resource 
Type = user_vm count for Account = 2 Operation = increasing Amount = 1
   2019-07-30 19:32:50,218 DEBUG [c.c.r.ResourceLimitManagerImpl] 
(qtp504527234-20:ctx-0e8ecf9d ctx-4d5c6019) (logid:9b131587) Updating resource 
Type = cpu count for Account = 2 Operation = increasing Amount = 1
   2019-07-30 

[GitHub] [cloudstack] blueorangutan commented on issue #3529: Add size to list usage records for VMSnapShotOnPrimary (type 27)

2019-07-30 Thread GitBox
blueorangutan commented on issue #3529: Add size to list usage records for 
VMSnapShotOnPrimary (type 27)
URL: https://github.com/apache/cloudstack/pull/3529#issuecomment-516378548
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-199


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] borisstoyanov commented on issue #3480: engine, server, services: fix for respecting secondary storage threshold limit

2019-07-30 Thread GitBox
borisstoyanov commented on issue #3480: engine, server, services: fix for 
respecting secondary storage threshold limit
URL: https://github.com/apache/cloudstack/pull/3480#issuecomment-516378322
 
 
   Sure, thanks on the investigation @shwstppr, will check 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3529: Add size to list usage records for VMSnapShotOnPrimary (type 27)

2019-07-30 Thread GitBox
blueorangutan commented on issue #3529: Add size to list usage records for 
VMSnapShotOnPrimary (type 27)
URL: https://github.com/apache/cloudstack/pull/3529#issuecomment-516372236
 
 
   @anuragaw a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] anuragaw commented on issue #3529: Add size to list usage records for VMSnapShotOnPrimary (type 27)

2019-07-30 Thread GitBox
anuragaw commented on issue #3529: Add size to list usage records for 
VMSnapShotOnPrimary (type 27)
URL: https://github.com/apache/cloudstack/pull/3529#issuecomment-516372189
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] anuragaw commented on a change in pull request #3529: Add size to list usage records for VMSnapShotOnPrimary (type 27)

2019-07-30 Thread GitBox
anuragaw commented on a change in pull request #3529: Add size to list usage 
records for VMSnapShotOnPrimary (type 27)
URL: https://github.com/apache/cloudstack/pull/3529#discussion_r308661000
 
 

 ##
 File path: server/src/main/java/com/cloud/api/ApiResponseHelper.java
 ##
 @@ -3691,6 +3691,7 @@ public UsageRecordResponse createUsageResponse(Usage 
usageRecord, Map

[GitHub] [cloudstack] anuragaw commented on a change in pull request #3529: Add size to list usage records for VMSnapShotOnPrimary (type 27)

2019-07-30 Thread GitBox
anuragaw commented on a change in pull request #3529: Add size to list usage 
records for VMSnapShotOnPrimary (type 27)
URL: https://github.com/apache/cloudstack/pull/3529#discussion_r308660617
 
 

 ##
 File path: server/src/main/java/com/cloud/api/ApiResponseHelper.java
 ##
 @@ -3691,6 +3691,7 @@ public UsageRecordResponse createUsageResponse(Usage 
usageRecord, Map

[GitHub] [cloudstack] blueorangutan commented on issue #3529: Add size to list usage records for VMSnapShotOnPrimary (type 27)

2019-07-30 Thread GitBox
blueorangutan commented on issue #3529: Add size to list usage records for 
VMSnapShotOnPrimary (type 27)
URL: https://github.com/apache/cloudstack/pull/3529#issuecomment-516367224
 
 
   Packaging result: ✖centos6 ✔centos7 ✔debian. JID-198


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] shwstppr commented on a change in pull request #3529: Add size to list usage records for VMSnapShotOnPrimary (type 27)

2019-07-30 Thread GitBox
shwstppr commented on a change in pull request #3529: Add size to list usage 
records for VMSnapShotOnPrimary (type 27)
URL: https://github.com/apache/cloudstack/pull/3529#discussion_r308653446
 
 

 ##
 File path: server/src/main/java/com/cloud/api/ApiResponseHelper.java
 ##
 @@ -3691,6 +3691,7 @@ public UsageRecordResponse createUsageResponse(Usage 
usageRecord, Map

[GitHub] [cloudstack] borisstoyanov commented on issue #3530: add size to usage type 27

2019-07-30 Thread GitBox
borisstoyanov commented on issue #3530: add size to usage type 27
URL: https://github.com/apache/cloudstack/issues/3530#issuecomment-516364061
 
 
   fixed by #3529 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] borisstoyanov opened a new issue #3530: add size to usage type 27

2019-07-30 Thread GitBox
borisstoyanov opened a new issue #3530: add size to usage type 27
URL: https://github.com/apache/cloudstack/issues/3530
 
 
   
   
   # ISSUE TYPE
   
* Bug Report
   
   # COMPONENT NAME
   
   ~~~
   usage
   ~~~
   
   # CLOUDSTACK VERSION
   
   
   ~~~
   master
   ~~~
   
   # CONFIGURATION
   
   
   
   # OS / ENVIRONMENT
   
   
   
   # SUMMARY
   
   size is missing from usage type 27, but available in related type 25. For 
consistency it's good to have
   
   # STEPS TO REPRODUCE
   
   
   
   ~~~
   
   ~~~
   
   
   
   # EXPECTED RESULTS
   
   
   ~~~
   size should be available 
   ~~~
   
   # ACTUAL RESULTS
   
   
   
   ~~~
   it's missing
   ~~~
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3529: Add size to list usage records for VMSnapShotOnPrimary (type 27)

2019-07-30 Thread GitBox
blueorangutan commented on issue #3529: Add size to list usage records for 
VMSnapShotOnPrimary (type 27)
URL: https://github.com/apache/cloudstack/pull/3529#issuecomment-516361178
 
 
   @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] borisstoyanov commented on issue #3529: Add size to list usage records for VMSnapShotOnPrimary (type 27)

2019-07-30 Thread GitBox
borisstoyanov commented on issue #3529: Add size to list usage records for 
VMSnapShotOnPrimary (type 27)
URL: https://github.com/apache/cloudstack/pull/3529#issuecomment-516360920
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] anuragaw opened a new pull request #3529: Add size to list usage records for VMSnapShotOnPrimary (type 27)

2019-07-30 Thread GitBox
anuragaw opened a new pull request #3529: Add size to list usage records for 
VMSnapShotOnPrimary (type 27)
URL: https://github.com/apache/cloudstack/pull/3529
 
 
   Add size to list usage records for VMSnapShotOnPrimary (type 27)
   
   The size was included in description but missing from response.
   ## Description
   
   
   
   
   
   
   
   
   
   ## Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   
   
   
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available

2019-07-30 Thread GitBox
blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow 
configuring appliances on the VM instance wizard when OVF properties are 
available
URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-516312305
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-197


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] shwstppr edited a comment on issue #3480: engine, server, services: fix for respecting secondary storage threshold limit

2019-07-30 Thread GitBox
shwstppr edited a comment on issue #3480: engine, server, services: fix for 
respecting secondary storage threshold limit
URL: https://github.com/apache/cloudstack/pull/3480#issuecomment-516309301
 
 
   > I think I'm hitting an issue with this one. I cannot sync the templates 
across a newly added image store. Here's my steps:
   > 
   > Originally created environement with 4 secondary storages
   > deleted 3 of them so I just have 1 running.
   > On the deleted storages I've clean all files.
   > Registered a few templates in cloudstack and they ended up on the running 
storage
   > Added back one of the storages and destroyed the SSVM in a while
   > After a day I went back to the machine and the newly added templates were 
not on the new image store, just the default ones were added. Also the new 
secondary storage is not being mounted on any of the hosts
   
   @borisstoyanov I've verified, the issue you are facing is unrelated to this 
PR. Currently, code skips downloading a template to new secondary store if is 
not public and not featured and not a system template.
   
https://github.com/apache/cloudstack/blob/master/engine/storage/image/src/main/java/org/apache/cloudstack/storage/image/TemplateServiceImpl.java#L517-L520
   If you can repeat your steps while making new template public/fetured(or 
remove your new stores, edit template to make it public and re-add store) it 
will be downloaded instantly after storage addition. There is no issue with 
template sync and it should start as soon as a new storage is added. I fixed 
that with #3302 and have verified with env running this PR.
   Not sure if it is by design that a normal template(not featured, not public) 
will remain on a single secondary store for a zone. @rhtyd @nvazquez any 
thoughts?
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] shwstppr commented on issue #3480: engine, server, services: fix for respecting secondary storage threshold limit

2019-07-30 Thread GitBox
shwstppr commented on issue #3480: engine, server, services: fix for respecting 
secondary storage threshold limit
URL: https://github.com/apache/cloudstack/pull/3480#issuecomment-516309301
 
 
   > I think I'm hitting an issue with this one. I cannot sync the templates 
across a newly added image store. Here's my steps:
   > 
   > Originally created environement with 4 secondary storages
   > deleted 3 of them so I just have 1 running.
   > On the deleted storages I've clean all files.
   > Registered a few templates in cloudstack and they ended up on the running 
storage
   > Added back one of the storages and destroyed the SSVM in a while
   > After a day I went back to the machine and the newly added templates were 
not on the new image store, just the default ones were added. Also the new 
secondary storage is not being mounted on any of the hosts
   
   @borisstoyanov I've verified, the issue you are facing is unrelated to this 
PR. Currently, code skips downloading a template to new secondary store if is 
not public and not featured and not a system template.
   
https://github.com/apache/cloudstack/blob/master/engine/storage/image/src/main/java/org/apache/cloudstack/storage/image/TemplateServiceImpl.java#L517-L520
   If you can repeat your steps while making new template public/fetured(or 
remove your new stores, edit template to make it public and re-add store) it 
will be downloaded instantly after storage addition. There is no issue with 
template sync and it should start as soon as a new storage is added. I fixed 
that with #3302 
   Not sure if it is by design that a normal template(not featured, not public) 
will remain on a single secondary store for a zone. @rhtyd @nvazquez any 
thoughts?
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available

2019-07-30 Thread GitBox
blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow 
configuring appliances on the VM instance wizard when OVF properties are 
available
URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-516305481
 
 
   @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] borisstoyanov commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available

2019-07-30 Thread GitBox
borisstoyanov commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow 
configuring appliances on the VM instance wizard when OVF properties are 
available
URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-516305259
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd merged pull request #3528: [UI] Improve visibility of dropdown menus on dialogs

2019-07-30 Thread GitBox
rhtyd merged pull request #3528: [UI] Improve visibility of dropdown menus on 
dialogs
URL: https://github.com/apache/cloudstack/pull/3528
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[cloudstack] branch master updated: ui: Improve visibility of dropdown menus on dialogs (#3528)

2019-07-30 Thread rohit
This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/master by this push:
 new 1141377  ui: Improve visibility of dropdown menus on dialogs (#3528)
1141377 is described below

commit 1141377e50247377166bd1be5521d108d9f363ab
Author: Nicolas Vazquez 
AuthorDate: Tue Jul 30 03:46:28 2019 -0300

ui: Improve visibility of dropdown menus on dialogs (#3528)

It was not possible to display the entire name of items in dropdown menus 
within dialogs in CloudStack, such as:

Create compute offering
Create network offering
Create VPC offering
---
 ui/css/cloudstack3.css | 4 
 1 file changed, 4 insertions(+)

diff --git a/ui/css/cloudstack3.css b/ui/css/cloudstack3.css
index a40e252..c1b79b2 100644
--- a/ui/css/cloudstack3.css
+++ b/ui/css/cloudstack3.css
@@ -3866,6 +3866,10 @@ table tr.selected td.actions .action.disabled .icon {
   background-position: -3px -368px;
 }
 
+.ui-dialog select {
+  overflow: scroll;
+}
+
 .ui-dialog.confirm .ui-button {
   margin-top: 0;
   margin-left: 11px;