[GitHub] [cloudstack] blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available
blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-518521640 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-223 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available
blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-518516214 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] borisstoyanov commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available
borisstoyanov commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-518515886 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3542: # of CPU_CORE capacity has been shown wrongly
rhtyd commented on issue #3542: # of CPU_CORE capacity has been shown wrongly URL: https://github.com/apache/cloudstack/issues/3542#issuecomment-518504547 It's because it adds all the CPU cores from all the VM instances, while the total cores is from the hosts. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan removed a comment on issue #3517: 4.13.0.0/master: health checks smoketests
blueorangutan removed a comment on issue #3517: 4.13.0.0/master: health checks smoketests URL: https://github.com/apache/cloudstack/pull/3517#issuecomment-518430766 Trillian test result (tid-266) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 20920 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3517-t266-xenserver-71.zip Intermittent failure detected: /marvin/tests/smoke/test_list_ids_parameter.py Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py Intermittent failure detected: /marvin/tests/smoke/test_routers.py Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py Intermittent failure detected: /marvin/tests/smoke/test_secondary_storage.py Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py Intermittent failure detected: /marvin/tests/smoke/test_templates.py Intermittent failure detected: /marvin/tests/smoke/test_usage.py Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py Intermittent failure detected: /marvin/tests/smoke/test_volumes.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py Smoke tests completed. 55 look OK, 22 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_03_list_snapshots | `Error` | 0.05 | test_list_ids_parameter.py ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py test_01_so_removal_resource_update | `Error` | 1.54 | test_resource_accounting.py ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py test_01_sys_vm_start | `Failure` | 0.14 | test_secondary_storage.py ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py test_02_routervm_iptables_policies | `Error` | 1.37 | test_routers_iptables_default_policy.py test_01_single_VPC_iptables_policies | `Error` | 5.48 | test_routers_iptables_default_policy.py test_01_isolate_network_FW_PF_default_routes_egress_true | `Error` | 1.55 | test_routers_network_ops.py test_02_isolate_network_FW_PF_default_routes_egress_false | `Error` | 1.52 | test_routers_network_ops.py test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Error` | 6.29 | test_routers_network_ops.py test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Error` | 5.99 | test_routers_network_ops.py test_03_RVR_Network_check_router_state | `Error` | 6.01 | test_routers_network_ops.py ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py ContextSuite context=TestScaleVm>:setup | `Error` | 0.00 | test_scale_vm.py ContextSuite context=TestServiceOfferings>:setup | `Error` | 2.45 | test_service_offerings.py test_01_list_sec_storage_vm | `Failure` | 0.05 | test_ssvm.py test_02_list_cpvm_vm | `Failure` | 0.05 | test_ssvm.py test_03_ssvm_internals | `Failure` | 0.05 | test_ssvm.py test_04_cpvm_internals | `Failure` | 0.05 | test_ssvm.py test_05_stop_ssvm | `Failure` | 0.06 | test_ssvm.py test_06_stop_cpvm | `Failure` | 0.05 | test_ssvm.py test_07_reboot_ssvm | `Failure` | 0.05 | test_ssvm.py test_08_reboot_cpvm | `Failure` | 0.05 | test_ssvm.py test_09_destroy_ssvm | `Failure` | 0.05 | test_ssvm.py test_10_destroy_cpvm | `Failure` | 0.05 | test_ssvm.py test_02_create_template_with_checksum_sha1 | `Error` | 65.54 | test_templates.py test_03_create_template_with_checksum_sha256 | `Error` | 65.56 | test_templates.py test_04_create_template_with_checksum_md5 | `Error` | 65.57 | test_templates.py test_05_create_template_wit
[GitHub] [cloudstack] blueorangutan removed a comment on issue #3517: 4.13.0.0/master: health checks smoketests
blueorangutan removed a comment on issue #3517: 4.13.0.0/master: health checks smoketests URL: https://github.com/apache/cloudstack/pull/3517#issuecomment-518275426 Trillian test result (tid-263) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 15354 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3517-t263-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py Intermittent failure detected: /marvin/tests/smoke/test_routers.py Intermittent failure detected: /marvin/tests/smoke/test_secondary_storage.py Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py Intermittent failure detected: /marvin/tests/smoke/test_templates.py Intermittent failure detected: /marvin/tests/smoke/test_usage.py Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py Intermittent failure detected: /marvin/tests/smoke/test_volumes.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py Smoke tests completed. 57 look OK, 20 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py test_01_so_removal_resource_update | `Error` | 1.32 | test_resource_accounting.py ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py ContextSuite context=TestServiceOfferings>:setup | `Error` | 1.99 | test_service_offerings.py ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py test_01_sys_vm_start | `Failure` | 0.10 | test_secondary_storage.py ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py test_02_routervm_iptables_policies | `Error` | 1.23 | test_routers_iptables_default_policy.py test_01_single_VPC_iptables_policies | `Error` | 5.33 | test_routers_iptables_default_policy.py test_01_isolate_network_FW_PF_default_routes_egress_true | `Error` | 1.33 | test_routers_network_ops.py test_02_isolate_network_FW_PF_default_routes_egress_false | `Error` | 1.35 | test_routers_network_ops.py test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Error` | 4.66 | test_routers_network_ops.py test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Error` | 6.00 | test_routers_network_ops.py test_03_RVR_Network_check_router_state | `Error` | 6.01 | test_routers_network_ops.py ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py test_01_list_sec_storage_vm | `Failure` | 0.03 | test_ssvm.py test_02_list_cpvm_vm | `Failure` | 0.03 | test_ssvm.py test_03_ssvm_internals | `Failure` | 0.03 | test_ssvm.py test_04_cpvm_internals | `Failure` | 0.03 | test_ssvm.py test_05_stop_ssvm | `Failure` | 0.03 | test_ssvm.py test_06_stop_cpvm | `Failure` | 0.04 | test_ssvm.py test_07_reboot_ssvm | `Failure` | 0.04 | test_ssvm.py test_08_reboot_cpvm | `Failure` | 0.03 | test_ssvm.py test_09_destroy_ssvm | `Failure` | 0.03 | test_ssvm.py test_10_destroy_cpvm | `Failure` | 0.04 | test_ssvm.py test_02_create_template_with_checksum_sha1 | `Error` | 65.41 | test_templates.py test_03_create_template_with_checksum_sha256 | `Error` | 65.41 | test_templates.py test_04_create_template_with_checksum_md5 | `Error` | 65.40 | test_templates.py test_05_create_template_with_no_checksum | `Error` | 65.41 | test_templates.py test_02_deploy_vm_from_direct_download_template | `Error` | 1.24 | test_templates.py test_03_deploy_vm_wrong_checksum | `Error` | 1.27 | test
[GitHub] [cloudstack] blueorangutan commented on issue #3517: 4.13.0.0/master: health checks smoketests
blueorangutan commented on issue #3517: 4.13.0.0/master: health checks smoketests URL: https://github.com/apache/cloudstack/pull/3517#issuecomment-518430766 Trillian test result (tid-266) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 20920 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3517-t266-xenserver-71.zip Intermittent failure detected: /marvin/tests/smoke/test_list_ids_parameter.py Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py Intermittent failure detected: /marvin/tests/smoke/test_routers.py Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py Intermittent failure detected: /marvin/tests/smoke/test_secondary_storage.py Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py Intermittent failure detected: /marvin/tests/smoke/test_templates.py Intermittent failure detected: /marvin/tests/smoke/test_usage.py Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py Intermittent failure detected: /marvin/tests/smoke/test_volumes.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py Smoke tests completed. 55 look OK, 22 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_03_list_snapshots | `Error` | 0.05 | test_list_ids_parameter.py ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py test_01_so_removal_resource_update | `Error` | 1.54 | test_resource_accounting.py ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py test_01_sys_vm_start | `Failure` | 0.14 | test_secondary_storage.py ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py test_02_routervm_iptables_policies | `Error` | 1.37 | test_routers_iptables_default_policy.py test_01_single_VPC_iptables_policies | `Error` | 5.48 | test_routers_iptables_default_policy.py test_01_isolate_network_FW_PF_default_routes_egress_true | `Error` | 1.55 | test_routers_network_ops.py test_02_isolate_network_FW_PF_default_routes_egress_false | `Error` | 1.52 | test_routers_network_ops.py test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Error` | 6.29 | test_routers_network_ops.py test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Error` | 5.99 | test_routers_network_ops.py test_03_RVR_Network_check_router_state | `Error` | 6.01 | test_routers_network_ops.py ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py ContextSuite context=TestScaleVm>:setup | `Error` | 0.00 | test_scale_vm.py ContextSuite context=TestServiceOfferings>:setup | `Error` | 2.45 | test_service_offerings.py test_01_list_sec_storage_vm | `Failure` | 0.05 | test_ssvm.py test_02_list_cpvm_vm | `Failure` | 0.05 | test_ssvm.py test_03_ssvm_internals | `Failure` | 0.05 | test_ssvm.py test_04_cpvm_internals | `Failure` | 0.05 | test_ssvm.py test_05_stop_ssvm | `Failure` | 0.06 | test_ssvm.py test_06_stop_cpvm | `Failure` | 0.05 | test_ssvm.py test_07_reboot_ssvm | `Failure` | 0.05 | test_ssvm.py test_08_reboot_cpvm | `Failure` | 0.05 | test_ssvm.py test_09_destroy_ssvm | `Failure` | 0.05 | test_ssvm.py test_10_destroy_cpvm | `Failure` | 0.05 | test_ssvm.py test_02_create_template_with_checksum_sha1 | `Error` | 65.54 | test_templates.py test_03_create_template_with_checksum_sha256 | `Error` | 65.56 | test_templates.py test_04_create_template_with_checksum_md5 | `Error` | 65.57 | test_templates.py test_05_create_template_with_no_che
[GitHub] [cloudstack] blueorangutan commented on issue #3540: [WIP DO NOT MERGE] VM ingestion
blueorangutan commented on issue #3540: [WIP DO NOT MERGE] VM ingestion URL: https://github.com/apache/cloudstack/pull/3540#issuecomment-518403741 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-222 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3540: [WIP DO NOT MERGE] VM ingestion
blueorangutan commented on issue #3540: [WIP DO NOT MERGE] VM ingestion URL: https://github.com/apache/cloudstack/pull/3540#issuecomment-518392388 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-221 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3517: 4.13.0.0/master: health checks smoketests
blueorangutan commented on issue #3517: 4.13.0.0/master: health checks smoketests URL: https://github.com/apache/cloudstack/pull/3517#issuecomment-518381853 Trillian test result (tid-264) Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7 Total time taken: 33303 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3517-t264-vmware-65u2.zip Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_root_resize.py Intermittent failure detected: /marvin/tests/smoke/test_network.py Intermittent failure detected: /marvin/tests/smoke/test_routers.py Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py Intermittent failure detected: /marvin/tests/smoke/test_usage.py Smoke tests completed. 73 look OK, 4 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_reboot_router | `Error` | 274.59 | test_network.py test_08_start_router | `Error` | 47.45 | test_routers.py test_09_reboot_router | `Error` | 1.13 | test_routers.py test_02_list_snapshots_with_removed_data_store | `Error` | 1.22 | test_snapshots.py test_01_volume_usage | `Error` | 8.44 | test_usage.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] onitake commented on issue #3518: Unhandled NPE in VMSnapShotManagerImpl.orchestrateCreateVMSnapshot produces snapshots that cannot be deleted
onitake commented on issue #3518: Unhandled NPE in VMSnapShotManagerImpl.orchestrateCreateVMSnapshot produces snapshots that cannot be deleted URL: https://github.com/apache/cloudstack/issues/3518#issuecomment-518358885 I can replace the `return null` with a `throw`, but I don't know if this has unexpected side effects. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available
blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-518337728 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-219 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available
blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-518330094 @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nvazquez commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available
nvazquez commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-518329896 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] msinhore opened a new issue #3542: The # of CPU_CORE capacity has been shown wrongly
msinhore opened a new issue #3542: The # of CPU_CORE capacity has been shown wrongly URL: https://github.com/apache/cloudstack/issues/3542 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ capacity calculation ~~~ # CLOUDSTACK VERSION ~~~ 4.11 ~~~ # CONFIGURATION # OS / ENVIRONMENT # SUMMARY The # of CPU_CORE capacity has been shown wrongly when, even considering the operprovisioning factor, the value presented should be for maximum capacity = 100% and no more than this. Example in CloudMonkey command: cloudmonkey list capacity filter=name,percentused, | grep CPU_CORE CPU_CORE,195.72 In the UI, the CPU_CORE value, shown out of margin in "Infrastructure > Zones > select zone > Resources"   This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3540: [WIP DO NOT MERGE] VM ingestion
blueorangutan commented on issue #3540: [WIP DO NOT MERGE] VM ingestion URL: https://github.com/apache/cloudstack/pull/3540#issuecomment-518320456 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-218 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] andrijapanicsb closed issue #3541: add host
andrijapanicsb closed issue #3541: add host URL: https://github.com/apache/cloudstack/issues/3541 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] andrijapanicsb opened a new issue #3541: add host
andrijapanicsb opened a new issue #3541: add host URL: https://github.com/apache/cloudstack/issues/3541 # ISSUE TYPE [*] Bug Report * Improvement Request * Enhancement Request * Feature Idea * Documentation Report * Other # COMPONENT NAME ~~~ GUI ~~~ # CLOUDSTACK VERSION ~~~ Master (4.13.0 snapshot) ~~~ # CONFIGURATION NA # OS / ENVIRONMENT NA # SUMMARY Adding a host via GUI, results in following being sent (captured via Developer Tools in Chrome), and the API never reaches apilog.log http://10.2.2.34:8080/client/api?command=addHost&response=json (note the missing tag for the host, and more importantly IP address) # STEPS TO REPRODUCE ~~~ Read the summary ~~~ # EXPECTED RESULTS ~~~ Can add host via GUI normally ~~~ # ACTUAL RESULTS ~~~ Read the summary. ~~~ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3517: 4.13.0.0/master: health checks smoketests
blueorangutan commented on issue #3517: 4.13.0.0/master: health checks smoketests URL: https://github.com/apache/cloudstack/pull/3517#issuecomment-518275426 Trillian test result (tid-263) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 15354 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3517-t263-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py Intermittent failure detected: /marvin/tests/smoke/test_routers.py Intermittent failure detected: /marvin/tests/smoke/test_secondary_storage.py Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py Intermittent failure detected: /marvin/tests/smoke/test_templates.py Intermittent failure detected: /marvin/tests/smoke/test_usage.py Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py Intermittent failure detected: /marvin/tests/smoke/test_volumes.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py Smoke tests completed. 57 look OK, 20 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py test_01_so_removal_resource_update | `Error` | 1.32 | test_resource_accounting.py ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py ContextSuite context=TestServiceOfferings>:setup | `Error` | 1.99 | test_service_offerings.py ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py test_01_sys_vm_start | `Failure` | 0.10 | test_secondary_storage.py ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py test_02_routervm_iptables_policies | `Error` | 1.23 | test_routers_iptables_default_policy.py test_01_single_VPC_iptables_policies | `Error` | 5.33 | test_routers_iptables_default_policy.py test_01_isolate_network_FW_PF_default_routes_egress_true | `Error` | 1.33 | test_routers_network_ops.py test_02_isolate_network_FW_PF_default_routes_egress_false | `Error` | 1.35 | test_routers_network_ops.py test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Error` | 4.66 | test_routers_network_ops.py test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Error` | 6.00 | test_routers_network_ops.py test_03_RVR_Network_check_router_state | `Error` | 6.01 | test_routers_network_ops.py ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py test_01_list_sec_storage_vm | `Failure` | 0.03 | test_ssvm.py test_02_list_cpvm_vm | `Failure` | 0.03 | test_ssvm.py test_03_ssvm_internals | `Failure` | 0.03 | test_ssvm.py test_04_cpvm_internals | `Failure` | 0.03 | test_ssvm.py test_05_stop_ssvm | `Failure` | 0.03 | test_ssvm.py test_06_stop_cpvm | `Failure` | 0.04 | test_ssvm.py test_07_reboot_ssvm | `Failure` | 0.04 | test_ssvm.py test_08_reboot_cpvm | `Failure` | 0.03 | test_ssvm.py test_09_destroy_ssvm | `Failure` | 0.03 | test_ssvm.py test_10_destroy_cpvm | `Failure` | 0.04 | test_ssvm.py test_02_create_template_with_checksum_sha1 | `Error` | 65.41 | test_templates.py test_03_create_template_with_checksum_sha256 | `Error` | 65.41 | test_templates.py test_04_create_template_with_checksum_md5 | `Error` | 65.40 | test_templates.py test_05_create_template_with_no_checksum | `Error` | 65.41 | test_templates.py test_02_deploy_vm_from_direct_download_template | `Error` | 1.24 | test_templates.py test_03_deploy_vm_wrong_checksum | `Error` | 1.27 | test_templat
[cloudstack-documentation] branch master updated: Template sharing doc update (#62)
This is an automated email from the ASF dual-hosted git repository. andrijapanic pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git The following commit(s) were added to refs/heads/master by this push: new 41a4012 Template sharing doc update (#62) 41a4012 is described below commit 41a401297f5c617c7112e3fef8eac112696f9edc Author: Andrija Panic <45762285+andrijapani...@users.noreply.github.com> AuthorDate: Mon Aug 5 16:33:23 2019 +0200 Template sharing doc update (#62) * Template sharing doc update * images * typos fix * minor fix * minor addition * Minor updates --- .../images/template-permissions-update-1.PNG | Bin 0 -> 20073 bytes .../images/template-permissions-update-2.PNG | Bin 0 -> 21337 bytes .../images/template-permissions-update-3.PNG | Bin 0 -> 19891 bytes .../images/template-permissions-update-4.PNG | Bin 0 -> 20761 bytes .../images/template-permissions-update-5.PNG | Bin 0 -> 14706 bytes .../template-permissions-update-manually-1.PNG | Bin 0 -> 18295 bytes .../template-permissions-update-manually-2.PNG | Bin 0 -> 18484 bytes source/adminguide/templates.rst| 67 - 8 files changed, 66 insertions(+), 1 deletion(-) diff --git a/source/_static/images/template-permissions-update-1.PNG b/source/_static/images/template-permissions-update-1.PNG new file mode 100644 index 000..f0bb692 Binary files /dev/null and b/source/_static/images/template-permissions-update-1.PNG differ diff --git a/source/_static/images/template-permissions-update-2.PNG b/source/_static/images/template-permissions-update-2.PNG new file mode 100644 index 000..334db4f Binary files /dev/null and b/source/_static/images/template-permissions-update-2.PNG differ diff --git a/source/_static/images/template-permissions-update-3.PNG b/source/_static/images/template-permissions-update-3.PNG new file mode 100644 index 000..33d19cd Binary files /dev/null and b/source/_static/images/template-permissions-update-3.PNG differ diff --git a/source/_static/images/template-permissions-update-4.PNG b/source/_static/images/template-permissions-update-4.PNG new file mode 100644 index 000..4ab127f Binary files /dev/null and b/source/_static/images/template-permissions-update-4.PNG differ diff --git a/source/_static/images/template-permissions-update-5.PNG b/source/_static/images/template-permissions-update-5.PNG new file mode 100644 index 000..9ce8d28 Binary files /dev/null and b/source/_static/images/template-permissions-update-5.PNG differ diff --git a/source/_static/images/template-permissions-update-manually-1.PNG b/source/_static/images/template-permissions-update-manually-1.PNG new file mode 100644 index 000..c2fe69f Binary files /dev/null and b/source/_static/images/template-permissions-update-manually-1.PNG differ diff --git a/source/_static/images/template-permissions-update-manually-2.PNG b/source/_static/images/template-permissions-update-manually-2.PNG new file mode 100644 index 000..2107d0b Binary files /dev/null and b/source/_static/images/template-permissions-update-manually-2.PNG differ diff --git a/source/adminguide/templates.rst b/source/adminguide/templates.rst index 63f90c8..353db9f 100644 --- a/source/adminguide/templates.rst +++ b/source/adminguide/templates.rst @@ -207,7 +207,7 @@ Uploading Templates from a remote HTTP server vSphere Templates and ISOs --- +^^ .. warning:: If you are uploading a template that was created using vSphere Client, be sure the OVA file does not contain an ISO. If it does, the deployment @@ -295,6 +295,57 @@ Example GUI dialog of uploading Template/ISO from local (browser) is given below Note that uploading multi-disk templates is also supported. +Sharing templates with other accounts/projects +-- + +When adding a template, the owner can choose to make template public or to keep it private. Once the template is created, the owner can choose to share this template so that other accounts/projects can also use the template. + +Currently, the template owner can share his template with: + - other accounts inside his own domain (i.e. can't share the template with other accounts in the subdomain of his domain or any other domains) + - projects where he belongs to (i.e. projects where he is the owner/creator or other projects where he has been joined) + +Template permissions can be changed via updateTemplatePermissions API call or via GUI. It is supported to add, remove or reset (remove all) template permissions. + +When adding or removing permissions to/from a template, it is required to specify account/project name which is being added/removed from the template permissions. + +Global setting "allow.user.view.all.domain.accounts"
[cloudstack-documentation] branch template-sharing-doc-update deleted (was 159bf3f)
This is an automated email from the ASF dual-hosted git repository. andrijapanic pushed a change to branch template-sharing-doc-update in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git. was 159bf3f Minor updates The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
[cloudstack-documentation] branch template-sharing-doc-update updated (7ee47d8 -> 159bf3f)
This is an automated email from the ASF dual-hosted git repository. andrijapanic pushed a change to branch template-sharing-doc-update in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git. from 7ee47d8 minor addition add 159bf3f Minor updates No new revisions were added by this update. Summary of changes: source/adminguide/templates.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
[cloudstack-documentation] branch volume-snap-policies-doc-update updated (0f11f74 -> 83301c8)
This is an automated email from the ASF dual-hosted git repository. andrijapanic pushed a change to branch volume-snap-policies-doc-update in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git. from 0f11f74 typo add 83301c8 minor update No new revisions were added by this update. Summary of changes: source/adminguide/storage.rst | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
[cloudstack-documentation] branch volume-snap-policies-doc-update updated (82ed2fd -> 0f11f74)
This is an automated email from the ASF dual-hosted git repository. andrijapanic pushed a change to branch volume-snap-policies-doc-update in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git. from 82ed2fd Rewording old content add 0f11f74 typo No new revisions were added by this update. Summary of changes: source/adminguide/storage.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
[cloudstack-documentation] branch volume-snap-policies-doc-update updated (731c7e8 -> 82ed2fd)
This is an automated email from the ASF dual-hosted git repository. andrijapanic pushed a change to branch volume-snap-policies-doc-update in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git. from 731c7e8 images uploaded add 82ed2fd Rewording old content No new revisions were added by this update. Summary of changes: source/adminguide/storage.rst | 25 - 1 file changed, 12 insertions(+), 13 deletions(-)
[cloudstack-documentation] branch volume-snap-policies-doc-update updated: images uploaded
This is an automated email from the ASF dual-hosted git repository. andrijapanic pushed a commit to branch volume-snap-policies-doc-update in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git The following commit(s) were added to refs/heads/volume-snap-policies-doc-update by this push: new 731c7e8 images uploaded 731c7e8 is described below commit 731c7e876d9c87c05c33f914edb581e8e33edadf Author: Andrija Panic <45762285+andrijapani...@users.noreply.github.com> AuthorDate: Mon Aug 5 15:14:05 2019 +0200 images uploaded --- source/_static/images/snap-policy-tag-1.PNG | Bin 0 -> 25030 bytes source/_static/images/snap-policy-tag-2.PNG | Bin 0 -> 16145 bytes source/_static/images/snap-tags-1.PNG | Bin 0 -> 14585 bytes source/_static/images/snap-tags-2.PNG | Bin 0 -> 16080 bytes 4 files changed, 0 insertions(+), 0 deletions(-) diff --git a/source/_static/images/snap-policy-tag-1.PNG b/source/_static/images/snap-policy-tag-1.PNG new file mode 100644 index 000..938504d Binary files /dev/null and b/source/_static/images/snap-policy-tag-1.PNG differ diff --git a/source/_static/images/snap-policy-tag-2.PNG b/source/_static/images/snap-policy-tag-2.PNG new file mode 100644 index 000..85119a8 Binary files /dev/null and b/source/_static/images/snap-policy-tag-2.PNG differ diff --git a/source/_static/images/snap-tags-1.PNG b/source/_static/images/snap-tags-1.PNG new file mode 100644 index 000..cc048ec Binary files /dev/null and b/source/_static/images/snap-tags-1.PNG differ diff --git a/source/_static/images/snap-tags-2.PNG b/source/_static/images/snap-tags-2.PNG new file mode 100644 index 000..13ac966 Binary files /dev/null and b/source/_static/images/snap-tags-2.PNG differ
[cloudstack-documentation] branch volume-snap-policies-doc-update updated: typos fix
This is an automated email from the ASF dual-hosted git repository. andrijapanic pushed a commit to branch volume-snap-policies-doc-update in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git The following commit(s) were added to refs/heads/volume-snap-policies-doc-update by this push: new 3a14095 typos fix 3a14095 is described below commit 3a14095aa3de8f1c86cbae6fa3a136af41d1ecf5 Author: Andrija Panic <45762285+andrijapani...@users.noreply.github.com> AuthorDate: Mon Aug 5 15:13:16 2019 +0200 typos fix --- source/adminguide/storage.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/source/adminguide/storage.rst b/source/adminguide/storage.rst index 6fd2460..a391c74 100644 --- a/source/adminguide/storage.rst +++ b/source/adminguide/storage.rst @@ -652,12 +652,12 @@ both root disks and data disks are supported. However, CloudStack does not currently support booting a VM from a recovered root disk. A disk recovered from snapshot of a root disk is treated as a regular data disk; the data on recovered disk can be accessed by attaching the disk -to a VM. Exception to this is when using KVM with NFS - with this setup, +to a VM. An exception to this is when using KVM with NFS - with this setup, both root and data volumes can be restored to their previous state. A completed snapshot is copied from primary storage to secondary storage, where it is stored until deleted or purged by newer snapshot. -The copy process can optionally be asynchronous (parameter asynbackupc=true) +The copy process can optionally be asynchronous (parameter asyncbackup=true) meaning that API call will complete once the snapshot is created initially on the Primary Storage, and after that the snapshot will be copied in the background to the Secondary Storage.
[cloudstack-documentation] 01/01: Update on snapshot policies
This is an automated email from the ASF dual-hosted git repository. andrijapanic pushed a commit to branch volume-snap-policies-doc-update in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git commit 65f464cc2eb3ec815a267e195f351a19f3aae104 Author: Andrija Panic <45762285+andrijapani...@users.noreply.github.com> AuthorDate: Mon Aug 5 15:09:26 2019 +0200 Update on snapshot policies Volume snapshots can have tags associated with it (both manual and scheduled ones). Minor general volume snapshot updates --- source/adminguide/storage.rst | 38 +- 1 file changed, 37 insertions(+), 1 deletion(-) diff --git a/source/adminguide/storage.rst b/source/adminguide/storage.rst index 44f5fcb..6fd2460 100644 --- a/source/adminguide/storage.rst +++ b/source/adminguide/storage.rst @@ -652,11 +652,39 @@ both root disks and data disks are supported. However, CloudStack does not currently support booting a VM from a recovered root disk. A disk recovered from snapshot of a root disk is treated as a regular data disk; the data on recovered disk can be accessed by attaching the disk -to a VM. +to a VM. Exception to this is when using KVM with NFS - with this setup, +both root and data volumes can be restored to their previous state. A completed snapshot is copied from primary storage to secondary storage, where it is stored until deleted or purged by newer snapshot. +The copy process can optionally be asynchronous (parameter asynbackupc=true) +meaning that API call will complete once the snapshot is created initially +on the Primary Storage, and after that the snapshot will be copied in the +background to the Secondary Storage. +Volume snapshot can have tags associated with it. With a manual volume snapshot, +tags can be set during the creation of the snapshot, or can be added (and removed) +later during the lifetime of the snapshot, as shown below. + +|snap-tags-1.PNG| + +Adding tags during snapshot creation + +|snap-tags-2.PNG| + +Existing tags are visible and new ones can be added + +Tags can be also added to the snapshot policies (scheduled snapshots) +and all the snapshots produced by that snapshot policy will have the same +tags associated with it. This is shown on the images below. + +|snap-policy-tag-1.PNG| + +Adding tags when creating a snapshot policy + +|snap-policy-tag-2.PNG| + +Snaps produced by the snapshot policy have the same tags How to Snapshot a Volume @@ -802,3 +830,11 @@ snapshot data. :alt: Detach Disk Button. .. |Migrateinstance.png| image:: /_static/images/migrate-instance.png :alt: button to migrate a volume. +.. |snap-tags-1.PNG| image:: /_static/images/snap-tags-1.PNG + :alt: Adding tags while creating a snapshot +.. |snap-tags-2.PNG| image:: /_static/images/snap-tags-2.PNG + :alt: Tags can be added after a snapshot is created +.. |snap-policy-tag-1.PNG| image:: /_static/images/snap-policy-tag-1.PNG + :alt: Setting tags on the snapshot policy +.. |snap-policy-tag-2.PNG| image:: /_static/images/snap-policy-tag-2.PNG + :alt: Tags can be added after the snapshot policy is created.
[cloudstack-documentation] branch volume-snap-policies-doc-update created (now 65f464c)
This is an automated email from the ASF dual-hosted git repository. andrijapanic pushed a change to branch volume-snap-policies-doc-update in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git. at 65f464c Update on snapshot policies This branch includes the following new commits: new 65f464c Update on snapshot policies The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
[GitHub] [cloudstack] DaanHoogland commented on issue #3525: NioServer: retain links by address string to minimize resource leak
DaanHoogland commented on issue #3525: NioServer: retain links by address string to minimize resource leak URL: https://github.com/apache/cloudstack/pull/3525#issuecomment-518226730 > Caveat: for multiple-mgmt servers behind an LB, it will end up creating only one weak entry in the weak hash map. I'm not sure if it could cause any issues. Do you mean that the two servers would share that hashmap, @rhtyd ? that seem strange to me. And if you mean on the agent side, that would only be a problem if the MSses are natted behind the same address, would it? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3532: Add new "Add volume" button, to add volume to VM instance directly
DaanHoogland commented on a change in pull request #3532: Add new "Add volume" button, to add volume to VM instance directly URL: https://github.com/apache/cloudstack/pull/3532#discussion_r310589963 ## File path: server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java ## @@ -736,8 +717,47 @@ public VolumeVO allocVolume(CreateVolumeCmd cmd) throws ResourceAllocationExcept String userSpecifiedName = getVolumeNameFromCommand(cmd); -return commitVolume(cmd, caller, owner, displayVolume, zoneId, diskOfferingId, provisioningType, size, minIops, maxIops, parentVolume, userSpecifiedName, +VolumeVO volume= commitVolume(cmd, caller, owner, displayVolume, zoneId, diskOfferingId, provisioningType, size, +minIops, +maxIops, parentVolume, userSpecifiedName, _uuidMgr.generateUuid(Volume.class, cmd.getCustomId())); + Review comment: @kioie can you modularise this code somewhat? as it has moved it is hard to compare with the old situation and the method is to complex for an overview at first glance. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3532: Add new "Add volume" button, to add volume to VM instance directly
DaanHoogland commented on a change in pull request #3532: Add new "Add volume"
button, to add volume to VM instance directly
URL: https://github.com/apache/cloudstack/pull/3532#discussion_r310590443
##
File path: server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java
##
@@ -736,8 +717,47 @@ public VolumeVO allocVolume(CreateVolumeCmd cmd) throws
ResourceAllocationExcept
String userSpecifiedName = getVolumeNameFromCommand(cmd);
-return commitVolume(cmd, caller, owner, displayVolume, zoneId,
diskOfferingId, provisioningType, size, minIops, maxIops, parentVolume,
userSpecifiedName,
+VolumeVO volume= commitVolume(cmd, caller, owner, displayVolume,
zoneId, diskOfferingId, provisioningType, size,
+minIops,
+maxIops, parentVolume, userSpecifiedName,
_uuidMgr.generateUuid(Volume.class, cmd.getCustomId()));
+
+// one step operation - create volume in VM's cluster and attach it
+// to the VM
+Long vmId = cmd.getVirtualMachineId();
+if (vmId != null) {
+// Check that the virtual machine ID is valid and it's a user vm
+UserVmVO vm = _userVmDao.findById(vmId);
+if (vm == null || vm.getType() != VirtualMachine.Type.User) {
+throw new InvalidParameterValueException("Please specify a
valid User VM.");
+}
+
+// Check that the VM is in the correct state
+if (vm.getState() != State.Running && vm.getState() !=
State.Stopped) {
+throw new InvalidParameterValueException("Please specify a VM
that is either running or stopped.");
+}
+
+// permission check
+_accountMgr.checkAccess(caller, null, false, vm);
+{
+try {
Review comment:
maybe extract this try block as well into a separate method.?!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3532: Add new "Add volume" button, to add volume to VM instance directly
DaanHoogland commented on a change in pull request #3532: Add new "Add volume"
button, to add volume to VM instance directly
URL: https://github.com/apache/cloudstack/pull/3532#discussion_r310590076
##
File path: server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java
##
@@ -736,8 +717,47 @@ public VolumeVO allocVolume(CreateVolumeCmd cmd) throws
ResourceAllocationExcept
String userSpecifiedName = getVolumeNameFromCommand(cmd);
-return commitVolume(cmd, caller, owner, displayVolume, zoneId,
diskOfferingId, provisioningType, size, minIops, maxIops, parentVolume,
userSpecifiedName,
+VolumeVO volume= commitVolume(cmd, caller, owner, displayVolume,
zoneId, diskOfferingId, provisioningType, size,
+minIops,
+maxIops, parentVolume, userSpecifiedName,
_uuidMgr.generateUuid(Volume.class, cmd.getCustomId()));
+
+// one step operation - create volume in VM's cluster and attach it
+// to the VM
+Long vmId = cmd.getVirtualMachineId();
+if (vmId != null) {
+// Check that the virtual machine ID is valid and it's a user vm
+UserVmVO vm = _userVmDao.findById(vmId);
+if (vm == null || vm.getType() != VirtualMachine.Type.User) {
+throw new InvalidParameterValueException("Please specify a
valid User VM.");
+}
+
+// Check that the VM is in the correct state
+if (vm.getState() != State.Running && vm.getState() !=
State.Stopped) {
+throw new InvalidParameterValueException("Please specify a VM
that is either running or stopped.");
+}
+
+// permission check
+_accountMgr.checkAccess(caller, null, false, vm);
+{
Review comment:
why this extra block level?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3522: New API endpoint: UpdateVlanIpRange
DaanHoogland commented on a change in pull request #3522: New API endpoint:
UpdateVlanIpRange
URL: https://github.com/apache/cloudstack/pull/3522#discussion_r310583024
##
File path:
api/src/org/apache/cloudstack/api/command/admin/vlan/UpdateVlanIpRangeCmd.java
##
@@ -0,0 +1,137 @@
+package org.apache.cloudstack.api.command.admin.vlan;
+
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseAsyncCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.VlanIpRangeResponse;
+import org.apache.log4j.Logger;
+
+import com.cloud.dc.Vlan;
+import com.cloud.event.EventTypes;
+import com.cloud.exception.ConcurrentOperationException;
+import com.cloud.exception.ResourceAllocationException;
+import com.cloud.exception.ResourceUnavailableException;
+import com.cloud.user.Account;
+import com.cloud.utils.net.NetUtils;
+
+
+@APICommand(name = "updateVlanIpRange", description = "Updates a VLAN IP
range.", responseObject =
+VlanIpRangeResponse.class, since = "4.13.0",
+requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
+public class UpdateVlanIpRangeCmd extends BaseAsyncCmd {
+public static final Logger s_logger =
Logger.getLogger(UpdateVlanIpRangeCmd.class.getName());
+
+private static final String s_name = "updatevlaniprangeresponse";
Review comment:
better use the name to put on the Annotation.name= here and add response and
to lower in the getCommandName() method. examples of this are plenty (no biggy)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3522: New API endpoint: UpdateVlanIpRange
DaanHoogland commented on a change in pull request #3522: New API endpoint:
UpdateVlanIpRange
URL: https://github.com/apache/cloudstack/pull/3522#discussion_r310583787
##
File path:
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
##
@@ -3958,6 +3961,116 @@ public VlanVO doInTransaction(final TransactionStatus
status) {
}
+@Override
+public Vlan updateVlanAndPublicIpRange(UpdateVlanIpRangeCmd cmd) throws
ConcurrentOperationException,
+ResourceUnavailableException, ResourceAllocationException{
+
+return updateVlanAndPublicIpRange(cmd.getId(),
cmd.getStartIp(),cmd.getEndIp(),
+cmd.getGateway(),cmd.getNetmask());
+}
+
+@DB
+@ActionEvent(eventType = EventTypes.EVENT_VLAN_IP_RANGE_UPDATE,
eventDescription = "update vlan ip Range", async
+= false)
+public Vlan updateVlanAndPublicIpRange(final long id, String startIp,
+ String endIp,
+ String gateway,
+ String netmask) throws
ConcurrentOperationException{
+
+// verify parameters
+VlanVO vlanRange = _vlanDao.findById(id);
+if (vlanRange == null) {
+throw new InvalidParameterValueException("Please specify a valid
IP range id.");
+}
+
+if (gateway == null) {
+gateway = vlanRange.getVlanGateway();
+}
+
+if (netmask == null) {
+netmask = vlanRange.getVlanNetmask();
+}
+
+final String[] existingVlanIPRangeArray =
vlanRange.getIpRange().split("-");
+final String currentStartIP= existingVlanIPRangeArray[0];
+final String currentEndIP = existingVlanIPRangeArray [1];
+
+if(startIp == null){
+startIp= currentStartIP;
+}
+
+if(endIp == null){
+endIp= currentEndIP;
+}
+
+// Check if the VLAN has any allocated public IPs
+final List ips = _publicIpAddressDao.listByVlanId(id);
+for (final IPAddressVO ip : ips) {
+if (ip.getState()== IpAddress.State.Allocated){
+if (!Strings.isNullOrEmpty(startIp) &&
NetUtils.ip2Long(startIp) > NetUtils.ip2Long(ip.getAddress().addr())) {
Review comment:
👍
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3522: New API endpoint: UpdateVlanIpRange
DaanHoogland commented on a change in pull request #3522: New API endpoint:
UpdateVlanIpRange
URL: https://github.com/apache/cloudstack/pull/3522#discussion_r310584112
##
File path:
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
##
@@ -3958,6 +3961,116 @@ public VlanVO doInTransaction(final TransactionStatus
status) {
}
+@Override
+public Vlan updateVlanAndPublicIpRange(UpdateVlanIpRangeCmd cmd) throws
ConcurrentOperationException,
+ResourceUnavailableException, ResourceAllocationException{
+
+return updateVlanAndPublicIpRange(cmd.getId(),
cmd.getStartIp(),cmd.getEndIp(),
+cmd.getGateway(),cmd.getNetmask());
+}
+
+@DB
+@ActionEvent(eventType = EventTypes.EVENT_VLAN_IP_RANGE_UPDATE,
eventDescription = "update vlan ip Range", async
+= false)
+public Vlan updateVlanAndPublicIpRange(final long id, String startIp,
+ String endIp,
+ String gateway,
+ String netmask) throws
ConcurrentOperationException{
+
+// verify parameters
+VlanVO vlanRange = _vlanDao.findById(id);
+if (vlanRange == null) {
+throw new InvalidParameterValueException("Please specify a valid
IP range id.");
+}
+
+if (gateway == null) {
+gateway = vlanRange.getVlanGateway();
+}
+
+if (netmask == null) {
+netmask = vlanRange.getVlanNetmask();
+}
+
+final String[] existingVlanIPRangeArray =
vlanRange.getIpRange().split("-");
+final String currentStartIP= existingVlanIPRangeArray[0];
+final String currentEndIP = existingVlanIPRangeArray [1];
+
+if(startIp == null){
+startIp= currentStartIP;
+}
+
+if(endIp == null){
+endIp= currentEndIP;
+}
+
+// Check if the VLAN has any allocated public IPs
+final List ips = _publicIpAddressDao.listByVlanId(id);
+for (final IPAddressVO ip : ips) {
+if (ip.getState()== IpAddress.State.Allocated){
+if (!Strings.isNullOrEmpty(startIp) &&
NetUtils.ip2Long(startIp) > NetUtils.ip2Long(ip.getAddress().addr())) {
+throw new InvalidParameterValueException("The start IP
address must have a lower IP address value" +
+" " +
+"than" +
+" "+ ip.getAddress() +
+" which is already in use.");
+}
+if (!Strings.isNullOrEmpty(endIp) && NetUtils.ip2Long(endIp) <
NetUtils.ip2Long(ip.getAddress().addr())) {
Review comment:
👍
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3522: New API endpoint: UpdateVlanIpRange
DaanHoogland commented on a change in pull request #3522: New API endpoint: UpdateVlanIpRange URL: https://github.com/apache/cloudstack/pull/3522#discussion_r310582179 ## File path: api/src/org/apache/cloudstack/api/command/admin/vlan/UpdateVlanIpRangeCmd.java ## @@ -0,0 +1,137 @@ +package org.apache.cloudstack.api.command.admin.vlan; Review comment: license header is missing, this won't pass the RAT This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3522: New API endpoint: UpdateVlanIpRange
DaanHoogland commented on a change in pull request #3522: New API endpoint:
UpdateVlanIpRange
URL: https://github.com/apache/cloudstack/pull/3522#discussion_r310585195
##
File path:
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
##
@@ -3958,6 +3961,116 @@ public VlanVO doInTransaction(final TransactionStatus
status) {
}
+@Override
+public Vlan updateVlanAndPublicIpRange(UpdateVlanIpRangeCmd cmd) throws
ConcurrentOperationException,
+ResourceUnavailableException, ResourceAllocationException{
+
+return updateVlanAndPublicIpRange(cmd.getId(),
cmd.getStartIp(),cmd.getEndIp(),
+cmd.getGateway(),cmd.getNetmask());
+}
+
+@DB
+@ActionEvent(eventType = EventTypes.EVENT_VLAN_IP_RANGE_UPDATE,
eventDescription = "update vlan ip Range", async
+= false)
+public Vlan updateVlanAndPublicIpRange(final long id, String startIp,
+ String endIp,
+ String gateway,
+ String netmask) throws
ConcurrentOperationException{
+
+// verify parameters
+VlanVO vlanRange = _vlanDao.findById(id);
+if (vlanRange == null) {
+throw new InvalidParameterValueException("Please specify a valid
IP range id.");
+}
+
+if (gateway == null) {
+gateway = vlanRange.getVlanGateway();
+}
+
+if (netmask == null) {
+netmask = vlanRange.getVlanNetmask();
+}
+
+final String[] existingVlanIPRangeArray =
vlanRange.getIpRange().split("-");
+final String currentStartIP= existingVlanIPRangeArray[0];
+final String currentEndIP = existingVlanIPRangeArray [1];
+
+if(startIp == null){
+startIp= currentStartIP;
+}
+
+if(endIp == null){
+endIp= currentEndIP;
+}
+
+// Check if the VLAN has any allocated public IPs
+final List ips = _publicIpAddressDao.listByVlanId(id);
+for (final IPAddressVO ip : ips) {
+if (ip.getState()== IpAddress.State.Allocated){
Review comment:
very good below, but.. does it make sense to look for the first used from
the range for lower boundry and the highest for upper boundry, to facilitate
admins? Now and exception is thrown for the first mismatch and some usefull
information may be withheld from the user.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3540: [WIP DO NOT MERGE] VM ingestion
blueorangutan commented on issue #3540: [WIP DO NOT MERGE] VM ingestion URL: https://github.com/apache/cloudstack/pull/3540#issuecomment-518217490 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-216 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3518: Unhandled NPE in VMSnapShotManagerImpl.orchestrateCreateVMSnapshot produces snapshots that cannot be deleted
DaanHoogland commented on issue #3518: Unhandled NPE in VMSnapShotManagerImpl.orchestrateCreateVMSnapshot produces snapshots that cannot be deleted URL: https://github.com/apache/cloudstack/issues/3518#issuecomment-518215810 @onitake are you writing a PR for this? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3517: 4.13.0.0/master: health checks smoketests
blueorangutan commented on issue #3517: 4.13.0.0/master: health checks smoketests URL: https://github.com/apache/cloudstack/pull/3517#issuecomment-518179078 @rhtyd a Trillian-Jenkins matrix job (centos6 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack-documentation] 01/01: Merge pull request #64 from apache/vm-snapshot-doc-update
This is an automated email from the ASF dual-hosted git repository. andrijapanic pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git commit b7c8ca8ed5f215a4374f1907b2205578fe27e0a4 Merge: 002e998 75459f7 Author: Andrija Panic <45762285+andrijapani...@users.noreply.github.com> AuthorDate: Mon Aug 5 12:07:13 2019 +0200 Merge pull request #64 from apache/vm-snapshot-doc-update vm snapshots tags and corrections source/adminguide/virtual_machines.rst | 31 +++ 1 file changed, 15 insertions(+), 16 deletions(-)
[cloudstack-documentation] branch vm-snapshot-doc-update deleted (was 75459f7)
This is an automated email from the ASF dual-hosted git repository. andrijapanic pushed a change to branch vm-snapshot-doc-update in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git. was 75459f7 minor fix The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
[cloudstack-documentation] branch vm-snapshot-doc-update updated (5264ac0 -> 75459f7)
This is an automated email from the ASF dual-hosted git repository. andrijapanic pushed a change to branch vm-snapshot-doc-update in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git. from 5264ac0 vm snapshots tags and corrections add 75459f7 minor fix No new revisions were added by this update. Summary of changes: source/adminguide/virtual_machines.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
[cloudstack-documentation] branch master updated (002e998 -> b7c8ca8)
This is an automated email from the ASF dual-hosted git repository. andrijapanic pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git. from 002e998 Merge pull request #63 from apache/upload-template-from-local-doc-update add 5264ac0 vm snapshots tags and corrections add 75459f7 minor fix new b7c8ca8 Merge pull request #64 from apache/vm-snapshot-doc-update The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: source/adminguide/virtual_machines.rst | 31 +++ 1 file changed, 15 insertions(+), 16 deletions(-)
[GitHub] [cloudstack] rhtyd commented on issue #3517: 4.13.0.0/master: health checks smoketests
rhtyd commented on issue #3517: 4.13.0.0/master: health checks smoketests URL: https://github.com/apache/cloudstack/pull/3517#issuecomment-518167099 @blueorangutan test matrix This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] borisstoyanov commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available
borisstoyanov commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-518127052 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available
blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-518127208 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
