[GitHub] [cloudstack] blueorangutan commented on issue #3517: 4.13.0.0/master: health checks smoketests

2019-08-06 Thread GitBox
blueorangutan commented on issue #3517: 4.13.0.0/master: health checks 
smoketests
URL: https://github.com/apache/cloudstack/pull/3517#issuecomment-518938466
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + xenserver-71) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd commented on issue #3517: 4.13.0.0/master: health checks smoketests

2019-08-06 Thread GitBox
rhtyd commented on issue #3517: 4.13.0.0/master: health checks smoketests
URL: https://github.com/apache/cloudstack/pull/3517#issuecomment-518938433
 
 
   @blueorangutan test centos7 xenserver-71


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3517: 4.13.0.0/master: health checks smoketests

2019-08-06 Thread GitBox
blueorangutan commented on issue #3517: 4.13.0.0/master: health checks 
smoketests
URL: https://github.com/apache/cloudstack/pull/3517#issuecomment-518937955
 
 
   Trillian test result (tid-275)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 26543 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3517-t275-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
   Smoke tests completed. 77 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] msinhore commented on issue #3542: # of CPU_CORE capacity has been shown wrongly

2019-08-06 Thread GitBox
msinhore commented on issue #3542: # of CPU_CORE capacity has been shown wrongly
URL: https://github.com/apache/cloudstack/issues/3542#issuecomment-518894406
 
 
   Thanks @rhtyd for the explanation. 
   
   Maybe the better way to display these information is use the 
overprovisioning algorithm, considering it as the maximum resources available 
to be used. As it is, isn't a polished UX.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3517: 4.13.0.0/master: health checks smoketests

2019-08-06 Thread GitBox
blueorangutan commented on issue #3517: 4.13.0.0/master: health checks 
smoketests
URL: https://github.com/apache/cloudstack/pull/3517#issuecomment-518841397
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd commented on issue #3517: 4.13.0.0/master: health checks smoketests

2019-08-06 Thread GitBox
rhtyd commented on issue #3517: 4.13.0.0/master: health checks smoketests
URL: https://github.com/apache/cloudstack/pull/3517#issuecomment-518841237
 
 
   @blueorangutan test 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] andrijapanicsb commented on issue #3533: KVM local migration issue #3521

2019-08-06 Thread GitBox
andrijapanicsb commented on issue #3533: KVM local migration issue #3521
URL: https://github.com/apache/cloudstack/pull/3533#issuecomment-518744431
 
 
   @GabrielBrascher 
   here they are:
   mgmt logs: https://pastebin.com/L97FgFut
   agent logs: https://pastebin.com/D6HnZSnJ
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] andrijapanicsb commented on issue #3533: KVM local migration issue #3521

2019-08-06 Thread GitBox
andrijapanicsb commented on issue #3533: KVM local migration issue #3521
URL: https://github.com/apache/cloudstack/pull/3533#issuecomment-518739812
 
 
   @svenvogel can you kindly test if KVM live migration with SF works fine 
(NFS/CEPH to SF) ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] GabrielBrascher commented on issue #3533: KVM local migration issue #3521

2019-08-06 Thread GitBox
GabrielBrascher commented on issue #3533: KVM local migration issue #3521
URL: https://github.com/apache/cloudstack/pull/3533#issuecomment-518660171
 
 
   Thanks for testing @andrijapanicsb. I did all tests on KVM + Ubuntu and it 
worked well; however, I did not test with CentOS6. Is there any log for share 
so that we can tackle the CentOS6 issue?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #3533: KVM local migration issue #3521

2019-08-06 Thread GitBox
GabrielBrascher commented on a change in pull request #3533: KVM local 
migration issue #3521
URL: https://github.com/apache/cloudstack/pull/3533#discussion_r311048538
 
 

 ##
 File path: 
engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
 ##
 @@ -1905,6 +1911,23 @@ public void copyAsync(Map 
volumeDataStoreMap, VirtualMach
 }
 }
 
+/**
+ * Returns true if at least one of the entries on the map 
'volumeDataStoreMap' has both source and destination storage pools of Network 
Filesystem (NFS).
+ */
+protected boolean isSourceAndDestinationPoolTypeOfNfs(Map volumeDataStoreMap) {
+for (Map.Entry entry : 
volumeDataStoreMap.entrySet()) {
+VolumeInfo srcVolumeInfo = entry.getKey();
+DataStore destDataStore = entry.getValue();
+
+StoragePoolVO destStoragePool = 
_storagePoolDao.findById(destDataStore.getId());
+StoragePoolVO sourceStoragePool = 
_storagePoolDao.findById(srcVolumeInfo.getPoolId());
+if (sourceStoragePool.getPoolType() == 
StoragePoolType.NetworkFilesystem && destStoragePool.getPoolType() == 
StoragePoolType.NetworkFilesystem) {
 
 Review comment:
   @rhtyd The idea is that if at least one of the disks is NFS it cannot be 
migrated on the execution flow of local storage. Taking a second look I see 
that the method name might need enhancements.
   
   Am I missing something? Please let me know if something doesn't look right. 
Thanks for the review.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] andrijapanicsb edited a comment on issue #3533: KVM local migration issue #3521

2019-08-06 Thread GitBox
andrijapanicsb edited a comment on issue #3533: KVM local migration issue #3521
URL: https://github.com/apache/cloudstack/pull/3533#issuecomment-518630268
 
 
   @mike-tutkowski any chance to test live storage migration with KVM+SolidFire 
- I see a lot of removed/changed code "xxx_managed_yyy"?
   
   @GabrielBrascher can you advise on above ^^ ^?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] andrijapanicsb edited a comment on issue #3533: KVM local migration issue #3521

2019-08-06 Thread GitBox
andrijapanicsb edited a comment on issue #3533: KVM local migration issue #3521
URL: https://github.com/apache/cloudstack/pull/3533#issuecomment-518629856
 
 
   CentOS6, VM+ROOT on local storage, fails in CloudStack with following lines 
on the destination KVM host:
   
   _2019-08-06 12:08:05,608 INFO  [kvm.storage.LibvirtStorageAdaptor] 
(agentRequest-Handler-1:null) (logid:a900bfb2) Trying to fetch storage pool 
7d69d5bf-0383-476a-90bd-41139db0d596 from libvirt
   2019-08-06 12:08:05,610 WARN  [cloud.agent.Agent] 
(agentRequest-Handler-1:null) (logid:a900bfb2) Caught:
   com.cloud.utils.exception.CloudRuntimeException: Could not fetch storage 
pool 7d69d5bf-0383-476a-90bd-41139db0d596 from libvirt
   at 
com.cloud.hypervisor.kvm.storage.KVMStoragePoolManager.getStoragePool(KVMStoragePoolManager.java:256)
   at 
com.cloud.hypervisor.kvm.storage.KVMStoragePoolManager.getStoragePool(KVMStoragePoolManager.java:242)_
   
   The storage pool 7d69d5bf-0383-476a-90bd-41139db0d596 is the local pool on 
SOURCE host.
   
   @GabrielBrascher not sure if you want this fixed on CentOS6, since we 
officially support it ?
   
   Ubuntu 18, VM+ROOT on local storage - migration to another host works fine.
   
   CentOS7 doesn't work (thanks to RedHat $$$hitty commercial logic and qemu 
code changes...)
   
   Will test shared storage volume migration...


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3540: [WIP DO NOT MERGE] VM ingestion

2019-08-06 Thread GitBox
blueorangutan commented on issue #3540: [WIP DO NOT MERGE] VM ingestion
URL: https://github.com/apache/cloudstack/pull/3540#issuecomment-518642600
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-228


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] andrijapanicsb edited a comment on issue #3533: KVM local migration issue #3521

2019-08-06 Thread GitBox
andrijapanicsb edited a comment on issue #3533: KVM local migration issue #3521
URL: https://github.com/apache/cloudstack/pull/3533#issuecomment-518629856
 
 
   _Testing local storage with CentOS6 - breaks heavily - migration of VM+ROOT 
volume is, in reality, successful, but ACS will report an error and DB will 
still point VM/volumes exist on the original host. Stopping and starting VM is 
not working even when fixing the DB (vm_instance and volumes tables, probably I 
have not dug deep enough...)._
   Could not reproduce again with a new VM - it fails immediately...
   
   Works fine on Ubuntu 18 (VM+ROOT on local storage, migration to another 
host).
   CentOS7 doesn't work (thanks to RedHat $$$hitty commercial logic)
   
   Will test shared storage volume migration...


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] andrijapanicsb commented on issue #3533: KVM local migration issue #3521

2019-08-06 Thread GitBox
andrijapanicsb commented on issue #3533: KVM local migration issue #3521
URL: https://github.com/apache/cloudstack/pull/3533#issuecomment-518632571
 
 
   @syed ^^^


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] andrijapanicsb edited a comment on issue #3533: KVM local migration issue #3521

2019-08-06 Thread GitBox
andrijapanicsb edited a comment on issue #3533: KVM local migration issue #3521
URL: https://github.com/apache/cloudstack/pull/3533#issuecomment-518630268
 
 
   @mike-tutkowski any chance to test live storage migration with KVM+SolidFire 
- I see a lot of removed/changed code "xxx_manaded_yyy"?
   
   @GabrielBrascher can you advise on above ^^ ^?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] andrijapanicsb edited a comment on issue #3533: KVM local migration issue #3521

2019-08-06 Thread GitBox
andrijapanicsb edited a comment on issue #3533: KVM local migration issue #3521
URL: https://github.com/apache/cloudstack/pull/3533#issuecomment-518630268
 
 
   @mike-tutkowski any chance to test live storage migration wiht KVM+SolidFire 
- I see a lot of removed/changed code "xxx_manaded_yyy" ?
   
   @GabrielBrascher can you advise on above ^^^ ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] andrijapanicsb commented on issue #3533: KVM local migration issue #3521

2019-08-06 Thread GitBox
andrijapanicsb commented on issue #3533: KVM local migration issue #3521
URL: https://github.com/apache/cloudstack/pull/3533#issuecomment-518630268
 
 
   @mike-tutkowski any change to test live storage migration wiht KVM+SolidFire 
- I see a lot of removed/changed code "xxx_manaded_yyy" ?
   
   @GabrielBrascher can you advise on above ^^^ ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] andrijapanicsb commented on issue #3533: KVM local migration issue #3521

2019-08-06 Thread GitBox
andrijapanicsb commented on issue #3533: KVM local migration issue #3521
URL: https://github.com/apache/cloudstack/pull/3533#issuecomment-518629856
 
 
   Testing local storage with CentOS6 - breaks heavily - migration of VM+ROOT 
volume is, in reality, successful, but ACS will report an error and DB will 
still point VM/volumes exist on the original host. Stopping and starting VM is 
not working even when fixing the DB (vm_instance and volumes tables, probably I 
have not dug deep enough...).
   
   Since we also officially support CentOS6, I would like to see this fixed if 
possible.
   
   Works fine on Ubuntu 18 (VM+ROOT on local storage, migration to another 
host).
   CentOS7 doesn't work (thanks to RedHat $$$hitty commercial logic)
   
   Will test shared storage volume migration...


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3540: [WIP DO NOT MERGE] VM ingestion

2019-08-06 Thread GitBox
blueorangutan commented on issue #3540: [WIP DO NOT MERGE] VM ingestion
URL: https://github.com/apache/cloudstack/pull/3540#issuecomment-518626753
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-227


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3540: [WIP DO NOT MERGE] VM ingestion

2019-08-06 Thread GitBox
blueorangutan commented on issue #3540: [WIP DO NOT MERGE] VM ingestion
URL: https://github.com/apache/cloudstack/pull/3540#issuecomment-518594048
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-226


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3540: [WIP DO NOT MERGE] VM ingestion

2019-08-06 Thread GitBox
blueorangutan commented on issue #3540: [WIP DO NOT MERGE] VM ingestion
URL: https://github.com/apache/cloudstack/pull/3540#issuecomment-518574908
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-225


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd opened a new issue #3543: Live Volume Resize when fails returns as success on KVM

2019-08-06 Thread GitBox
rhtyd opened a new issue #3543: Live Volume Resize when fails returns as 
success on KVM
URL: https://github.com/apache/cloudstack/issues/3543
 
 
   While live resizing a volume on KVM (CentOS 6.x), when the resize script 
fails it outputs `failed to live resize...` but as part of the resize volume 
answer it returns the correct/current new size as the old size and returns the 
success as `true`, the requested resize value is then set in the `volumes.size`.
   
   # ISSUE TYPE
   
* Bug Report
   
   # COMPONENT NAME
   
   ~~~
   KVM, volumes
   ~~~
   
   # CLOUDSTACK VERSION
   
   ~~~
   4.9, 4.11
   ~~~
   
   # CONFIGURATION
   
   
   CentOS/EL6.x


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3540: [WIP DO NOT MERGE] VM ingestion

2019-08-06 Thread GitBox
blueorangutan commented on issue #3540: [WIP DO NOT MERGE] VM ingestion
URL: https://github.com/apache/cloudstack/pull/3540#issuecomment-518536950
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-224


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available

2019-08-06 Thread GitBox
blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow 
configuring appliances on the VM instance wizard when OVF properties are 
available
URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-518521640
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-223


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available

2019-08-06 Thread GitBox
blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow 
configuring appliances on the VM instance wizard when OVF properties are 
available
URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-518516214
 
 
   @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] borisstoyanov commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available

2019-08-06 Thread GitBox
borisstoyanov commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow 
configuring appliances on the VM instance wizard when OVF properties are 
available
URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-518515886
 
 
   @blueorangutan package
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services