[GitHub] [cloudstack] blueorangutan commented on issue #3477: RvR: Set up metadata/password/dhcp server on gateway IP instead of guest IP in RVR

2019-10-22 Thread GitBox
blueorangutan commented on issue #3477: RvR: Set up metadata/password/dhcp 
server on gateway IP instead of guest IP in RVR
URL: https://github.com/apache/cloudstack/pull/3477#issuecomment-545231925
 
 
   Trillian test result (tid-425)
   Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 53497 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3477-t425-vmware-65u2.zip
   Intermittent failure detected: /marvin/tests/smoke/test_accounts.py
   Intermittent failure detected: /marvin/tests/smoke/test_iso.py
   Intermittent failure detected: /marvin/tests/smoke/test_templates.py
   Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
   Smoke tests completed. 73 look OK, 4 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   ContextSuite context=TestTemplateHierarchy>:setup | `Error` | 1517.79 | 
test_accounts.py
   test_04_extract_Iso | `Failure` | 1.06 | test_iso.py
   test_04_extract_template | `Failure` | 74.53 | test_templates.py
   test_06_download_detached_volume | `Failure` | 89.92 | test_volumes.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3605: fix issue #3590 'Revert Ceph/RBD Snapshot'

2019-10-22 Thread GitBox
blueorangutan commented on issue #3605: fix issue #3590 'Revert Ceph/RBD 
Snapshot'
URL: https://github.com/apache/cloudstack/pull/3605#issuecomment-545208697
 
 
   Trillian test result (tid-426)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 26556 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3605-t426-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
   Smoke tests completed. 77 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3623: kvm: Use 'ip' instead of 'brctl'

2019-10-22 Thread GitBox
blueorangutan commented on issue #3623: kvm: Use 'ip' instead of 'brctl'
URL: https://github.com/apache/cloudstack/pull/3623#issuecomment-545132843
 
 
   Trillian test result (tid-422)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 36375 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3623-t422-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Smoke tests completed. 76 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_vpc_privategw_static_routes | `Failure` | 244.80 | 
test_privategw_acl.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] ustcweizhou commented on issue #3597: kvm: Logrotate should not touch agent.log

2019-10-22 Thread GitBox
ustcweizhou commented on issue #3597: kvm: Logrotate should not touch agent.log
URL: https://github.com/apache/cloudstack/pull/3597#issuecomment-545126565
 
 
   @rhtyd can you cherry-pick this commit to 4.13 branch ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[cloudstack-documentation] branch remove-mysql-python-connector-requirements updated (2bb8f7f -> 4f7901d)

2019-10-22 Thread andrijapanic
This is an automated email from the ASF dual-hosted git repository.

andrijapanic pushed a change to branch 
remove-mysql-python-connector-requirements
in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git.


from 2bb8f7f  remove mysql-python-connector requirements
 add 4f7901d  replace 4.11 with 4.13

No new revisions were added by this update.

Summary of changes:
 source/quickinstallationguide/qig.rst | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)



[cloudstack-documentation] 01/01: remove mysql-python-connector requirements

2019-10-22 Thread andrijapanic
This is an automated email from the ASF dual-hosted git repository.

andrijapanic pushed a commit to branch 
remove-mysql-python-connector-requirements
in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git

commit 2bb8f7f186998d1d9c41627060eeb4a897f3e8d3
Author: Andrija Panic <45762285+andrijapani...@users.noreply.github.com>
AuthorDate: Tue Oct 22 19:05:11 2019 +0200

remove mysql-python-connector requirements

It's needed only to build packages, QiG assumes packages taken from public 
repo
---
 source/quickinstallationguide/qig.rst | 27 ---
 1 file changed, 27 deletions(-)

diff --git a/source/quickinstallationguide/qig.rst 
b/source/quickinstallationguide/qig.rst
index 0e96a8c..83f978e 100644
--- a/source/quickinstallationguide/qig.rst
+++ b/source/quickinstallationguide/qig.rst
@@ -421,33 +421,6 @@ start on boot as follows:
# systemctl start mysqld
 
 
-MySQL connector Installation
-
-
-Install Python MySQL connector using the official MySQL packages repository.
-Create the file ``/etc/yum.repos.d/mysql.repo`` with the following content:
-
-.. parsed-literal::
-
-   [mysql-connectors-community]
-   name=MySQL Community connectors
-   
baseurl=http://repo.mysql.com/yum/mysql-connectors-community/el/$releasever/$basearch/
-   enabled=1
-   gpgcheck=1
-
-Import GPG public key from MySQL:
-
-.. parsed-literal::
-
-   rpm --import http://repo.mysql.com/RPM-GPG-KEY-mysql
-
-Install mysql-connector
-
-.. parsed-literal::
-
-   yum install mysql-connector-python
-
-
 Installation
 
 



[cloudstack-documentation] branch remove-mysql-python-connector-requirements created (now 2bb8f7f)

2019-10-22 Thread andrijapanic
This is an automated email from the ASF dual-hosted git repository.

andrijapanic pushed a change to branch 
remove-mysql-python-connector-requirements
in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git.


  at 2bb8f7f  remove mysql-python-connector requirements

This branch includes the following new commits:

 new 2bb8f7f  remove mysql-python-connector requirements

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.




[GitHub] [cloudstack] rhtyd commented on issue #3605: fix issue #3590 'Revert Ceph/RBD Snapshot'

2019-10-22 Thread GitBox
rhtyd commented on issue #3605: fix issue #3590 'Revert Ceph/RBD Snapshot'
URL: https://github.com/apache/cloudstack/pull/3605#issuecomment-545044778
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3605: fix issue #3590 'Revert Ceph/RBD Snapshot'

2019-10-22 Thread GitBox
blueorangutan commented on issue #3605: fix issue #3590 'Revert Ceph/RBD 
Snapshot'
URL: https://github.com/apache/cloudstack/pull/3605#issuecomment-545044892
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[cloudstack-documentation] 01/01: test

2019-10-22 Thread andrijapanic
This is an automated email from the ASF dual-hosted git repository.

andrijapanic pushed a commit to branch test
in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git

commit 83aabff6a0d12307c4df78f6a957aef86e97c359
Author: Andrija Panic <45762285+andrijapani...@users.noreply.github.com>
AuthorDate: Tue Oct 22 16:10:37 2019 +0200

test
---
 README.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/README.rst b/README.rst
index 2cd4ed7..2f67952 100644
--- a/README.rst
+++ b/README.rst
@@ -142,7 +142,7 @@ This process will do the following:
 Making a pull request on GitHub to contribute your changes
 --
 
-When you are happy with your changes and you want to contribute them, you will 
be creating a Pull Request on GitHub to do so.  This is done by pushing your 
changes to your forked repository (usually called 'origin') and then initiating 
a pull request.
+When you are happy with your changes and you want to contribute them, you will 
be creating a Pull Request on GitHub to do so.  This is done by pushing your 
changes to your forked repository (usually called 'origin') and then initiating 
a pull request .
 
 .. note:: Make sure you have merged `upstream/master` into your `dev` branch 
before you do this.
 



[cloudstack-documentation] branch test created (now 83aabff)

2019-10-22 Thread andrijapanic
This is an automated email from the ASF dual-hosted git repository.

andrijapanic pushed a change to branch test
in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git.


  at 83aabff  test

This branch includes the following new commits:

 new 83aabff  test

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.




[cloudstack-documentation] annotated tag 4.13.0.0 updated (701ee28 -> 14486f6)

2019-10-22 Thread andrijapanic
This is an automated email from the ASF dual-hosted git repository.

andrijapanic pushed a change to annotated tag 4.13.0.0
in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git.


*** WARNING: tag 4.13.0.0 was modified! ***

from 701ee28  (commit)
  to 14486f6  (tag)
 tagging 701ee28955784a6ac136d5f29ca0507fe34f6fbe (commit)
 replaces 4.12.0.0
  by andrijapanicsb
  on Tue Oct 22 16:04:22 2019 +0200

- Log -
---


No new revisions were added by this update.

Summary of changes:



[cloudstack-documentation] branch volumes-from-snaps-doc-update updated (6c6b088 -> e9cd752)

2019-10-22 Thread andrijapanic
This is an automated email from the ASF dual-hosted git repository.

andrijapanic pushed a change to branch volumes-from-snaps-doc-update
in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git.


from 6c6b088  Update source/adminguide/storage.rst
 add e9cd752  Update source/adminguide/storage.rst

No new revisions were added by this update.

Summary of changes:
 source/adminguide/storage.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)



[cloudstack-documentation] branch volumes-from-snaps-doc-update updated (4c5fdd6 -> 6c6b088)

2019-10-22 Thread andrijapanic
This is an automated email from the ASF dual-hosted git repository.

andrijapanic pushed a change to branch volumes-from-snaps-doc-update
in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git.


from 4c5fdd6  spell check
 add 6c6b088  Update source/adminguide/storage.rst

No new revisions were added by this update.

Summary of changes:
 source/adminguide/storage.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)



[GitHub] [cloudstack] blueorangutan commented on issue #3632: add class cleanup method

2019-10-22 Thread GitBox
blueorangutan commented on issue #3632: add class cleanup method
URL: https://github.com/apache/cloudstack/pull/3632#issuecomment-544926141
 
 
   Packaging result: ✖centos6 ✔centos7 ✔debian. JID-330


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3605: fix issue #3590 'Revert Ceph/RBD Snapshot'

2019-10-22 Thread GitBox
blueorangutan commented on issue #3605: fix issue #3590 'Revert Ceph/RBD 
Snapshot'
URL: https://github.com/apache/cloudstack/pull/3605#issuecomment-544922342
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-329


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3632: add class cleanup method

2019-10-22 Thread GitBox
blueorangutan commented on issue #3632: add class cleanup method
URL: https://github.com/apache/cloudstack/pull/3632#issuecomment-544919603
 
 
   @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] borisstoyanov commented on issue #3632: add class cleanup method

2019-10-22 Thread GitBox
borisstoyanov commented on issue #3632: add class cleanup method
URL: https://github.com/apache/cloudstack/pull/3632#issuecomment-544919321
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd commented on issue #3605: fix issue #3590 'Revert Ceph/RBD Snapshot'

2019-10-22 Thread GitBox
rhtyd commented on issue #3605: fix issue #3590 'Revert Ceph/RBD Snapshot'
URL: https://github.com/apache/cloudstack/pull/3605#issuecomment-544914393
 
 
   I don't have ceph setup to test this, maybe @andrijapanicsb can review?
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3605: fix issue #3590 'Revert Ceph/RBD Snapshot'

2019-10-22 Thread GitBox
blueorangutan commented on issue #3605: fix issue #3590 'Revert Ceph/RBD 
Snapshot'
URL: https://github.com/apache/cloudstack/pull/3605#issuecomment-544914494
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd merged pull request #3641: security_group.py: fix NameError: name 'd' is not defined

2019-10-22 Thread GitBox
rhtyd merged pull request #3641: security_group.py: fix NameError: name 'd' is 
not defined
URL: https://github.com/apache/cloudstack/pull/3641
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[cloudstack] branch master updated (9258c7c -> 848860d)

2019-10-22 Thread rohit
This is an automated email from the ASF dual-hosted git repository.

rohit pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


from 9258c7c  Revert "9ee129ae6a08935645734ad520bec72bf5f22217"
 add 848860d  security_group.py: fix NameError: name 'd' is not defined 
(#3641)

No new revisions were added by this update.

Summary of changes:
 scripts/vm/network/security_group.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)



[GitHub] [cloudstack] rhtyd commented on issue #3641: security_group.py: fix NameError: name 'd' is not defined

2019-10-22 Thread GitBox
rhtyd commented on issue #3641: security_group.py: fix NameError: name 'd' is 
not defined
URL: https://github.com/apache/cloudstack/pull/3641#issuecomment-544913932
 
 
   Tested locally, the issue is pythonic iteration. LGTM.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd merged pull request #3648: Security Group: limit returns in get_bridge_physdev to 1

2019-10-22 Thread GitBox
rhtyd merged pull request #3648: Security Group: limit returns in 
get_bridge_physdev to 1
URL: https://github.com/apache/cloudstack/pull/3648
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[cloudstack] branch 4.13 updated (cc27095 -> 3114907)

2019-10-22 Thread rohit
This is an automated email from the ASF dual-hosted git repository.

rohit pushed a change to branch 4.13
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


from cc27095  server: Do NOT cleanup dhcp and dns when stop a vm (#3627)
 add 3114907  security_group: Add `head -1` to `get_bridge_physdev` (#3648)

No new revisions were added by this update.

Summary of changes:
 scripts/vm/network/security_group.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)



[GitHub] [cloudstack] rhtyd commented on issue #3648: Security Group: limit returns in get_bridge_physdev to 1

2019-10-22 Thread GitBox
rhtyd commented on issue #3648: Security Group: limit returns in 
get_bridge_physdev to 1
URL: https://github.com/apache/cloudstack/pull/3648#issuecomment-544913006
 
 
   Thanks for  confirming the change and tests. I'll merge this.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3477: RvR: Set up metadata/password/dhcp server on gateway IP instead of guest IP in RVR

2019-10-22 Thread GitBox
blueorangutan commented on issue #3477: RvR: Set up metadata/password/dhcp 
server on gateway IP instead of guest IP in RVR
URL: https://github.com/apache/cloudstack/pull/3477#issuecomment-544907552
 
 
   @borisstoyanov a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 
mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] borisstoyanov commented on issue #3477: RvR: Set up metadata/password/dhcp server on gateway IP instead of guest IP in RVR

2019-10-22 Thread GitBox
borisstoyanov commented on issue #3477: RvR: Set up metadata/password/dhcp 
server on gateway IP instead of guest IP in RVR
URL: https://github.com/apache/cloudstack/pull/3477#issuecomment-544907345
 
 
   @blueorangutan test matrix 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3477: RvR: Set up metadata/password/dhcp server on gateway IP instead of guest IP in RVR

2019-10-22 Thread GitBox
blueorangutan commented on issue #3477: RvR: Set up metadata/password/dhcp 
server on gateway IP instead of guest IP in RVR
URL: https://github.com/apache/cloudstack/pull/3477#issuecomment-544903312
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-328


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] borisstoyanov commented on issue #3477: RvR: Set up metadata/password/dhcp server on gateway IP instead of guest IP in RVR

2019-10-22 Thread GitBox
borisstoyanov commented on issue #3477: RvR: Set up metadata/password/dhcp 
server on gateway IP instead of guest IP in RVR
URL: https://github.com/apache/cloudstack/pull/3477#issuecomment-544896557
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3477: RvR: Set up metadata/password/dhcp server on gateway IP instead of guest IP in RVR

2019-10-22 Thread GitBox
blueorangutan commented on issue #3477: RvR: Set up metadata/password/dhcp 
server on gateway IP instead of guest IP in RVR
URL: https://github.com/apache/cloudstack/pull/3477#issuecomment-544896719
 
 
   @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] ustcweizhou commented on issue #3477: RvR: Set up metadata/password/dhcp server on gateway IP instead of guest IP in RVR

2019-10-22 Thread GitBox
ustcweizhou commented on issue #3477: RvR: Set up metadata/password/dhcp server 
on gateway IP instead of guest IP in RVR
URL: https://github.com/apache/cloudstack/pull/3477#issuecomment-544894194
 
 
   @rhtyd can you kick off a test ?
   I have rebased with 4.13, and run some integration tests, it seems good.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3641: security_group.py: fix NameError: name 'd' is not defined

2019-10-22 Thread GitBox
blueorangutan commented on issue #3641: security_group.py: fix NameError: name 
'd' is not defined
URL: https://github.com/apache/cloudstack/pull/3641#issuecomment-544892922
 
 
   Packaging result: ✖centos6 ✔centos7 ✔debian. JID-326


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3617: [KVM] Agent LB Fix: Connections from disabled KVM host agents are refused

2019-10-22 Thread GitBox
blueorangutan commented on issue #3617: [KVM] Agent LB Fix: Connections from 
disabled KVM host agents are refused
URL: https://github.com/apache/cloudstack/pull/3617#issuecomment-544892924
 
 
   Packaging result: ✖centos6 ✔centos7 ✔debian. JID-327


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] ustcweizhou commented on issue #3648: Security Group: limit returns in get_bridge_physdev to 1

2019-10-22 Thread GitBox
ustcweizhou commented on issue #3648: Security Group: limit returns in 
get_bridge_physdev to 1
URL: https://github.com/apache/cloudstack/pull/3648#issuecomment-544892275
 
 
   > state forwarding priority 32 cost 2
   
   @RPDiep thanks . this change looks good to me.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3648: Security Group: limit returns in get_bridge_physdev to 1

2019-10-22 Thread GitBox
blueorangutan commented on issue #3648: Security Group: limit returns in 
get_bridge_physdev to 1
URL: https://github.com/apache/cloudstack/pull/3648#issuecomment-544891731
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-325


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3623: kvm: Use 'ip' instead of 'brctl'

2019-10-22 Thread GitBox
blueorangutan commented on issue #3623: kvm: Use 'ip' instead of 'brctl'
URL: https://github.com/apache/cloudstack/pull/3623#issuecomment-544880521
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd commented on issue #3623: kvm: Use 'ip' instead of 'brctl'

2019-10-22 Thread GitBox
rhtyd commented on issue #3623: kvm: Use 'ip' instead of 'brctl'
URL: https://github.com/apache/cloudstack/pull/3623#issuecomment-544880302
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd commented on issue #3612: systemvm: for ip route show command don't use the throw command

2019-10-22 Thread GitBox
rhtyd commented on issue #3612: systemvm: for ip route show command don't use 
the throw command
URL: https://github.com/apache/cloudstack/pull/3612#issuecomment-544879891
 
 
   Can you review this @ustcweizhou ? Thanks.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd commented on issue #3525: NioServer: retain links by address string to minimize resource leak

2019-10-22 Thread GitBox
rhtyd commented on issue #3525: NioServer: retain links by address string to 
minimize resource leak
URL: https://github.com/apache/cloudstack/pull/3525#issuecomment-544879554
 
 
   Sorry, reverting this PR because I remembered why it was put On-Hold, as the 
change would cause a single Link to be added to a Map when the mgmt server is 
behind a LB. So the changes are not optimal for all cases.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[cloudstack] branch master updated (9ee129a -> 9258c7c)

2019-10-22 Thread rohit
This is an automated email from the ASF dual-hosted git repository.

rohit pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


from 9ee129a  NioServer: retain links by address string to minimize 
resource leak (#3525)
 add 9258c7c  Revert "9ee129ae6a08935645734ad520bec72bf5f22217"

No new revisions were added by this update.

Summary of changes:
 utils/src/main/java/com/cloud/utils/nio/NioServer.java | 11 +--
 1 file changed, 5 insertions(+), 6 deletions(-)



[cloudstack] branch master updated (294813e -> 9ee129a)

2019-10-22 Thread rohit
This is an automated email from the ASF dual-hosted git repository.

rohit pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


from 294813e  Merge remote-tracking branch 'origin/4.13'
 add 9ee129a  NioServer: retain links by address string to minimize 
resource leak (#3525)

No new revisions were added by this update.

Summary of changes:
 utils/src/main/java/com/cloud/utils/nio/Link.java  |  2 +-
 utils/src/main/java/com/cloud/utils/nio/NioServer.java | 13 +++--
 2 files changed, 8 insertions(+), 7 deletions(-)



[GitHub] [cloudstack] blueorangutan commented on issue #3623: kvm: Use 'ip' instead of 'brctl'

2019-10-22 Thread GitBox
blueorangutan commented on issue #3623: kvm: Use 'ip' instead of 'brctl'
URL: https://github.com/apache/cloudstack/pull/3623#issuecomment-544876701
 
 
   Packaging result: ✖centos6 ✔centos7 ✔debian. JID-324


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd merged pull request #3525: NioServer: retain links by address string to minimize resource leak

2019-10-22 Thread GitBox
rhtyd merged pull request #3525: NioServer: retain links by address string to 
minimize resource leak
URL: https://github.com/apache/cloudstack/pull/3525
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd commented on issue #3617: [KVM] Agent LB Fix: Connections from disabled KVM host agents are refused

2019-10-22 Thread GitBox
rhtyd commented on issue #3617: [KVM] Agent LB Fix: Connections from disabled 
KVM host agents are refused
URL: https://github.com/apache/cloudstack/pull/3617#issuecomment-544876227
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3617: [KVM] Agent LB Fix: Connections from disabled KVM host agents are refused

2019-10-22 Thread GitBox
blueorangutan commented on issue #3617: [KVM] Agent LB Fix: Connections from 
disabled KVM host agents are refused
URL: https://github.com/apache/cloudstack/pull/3617#issuecomment-544876588
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3641: security_group.py: fix NameError: name 'd' is not defined

2019-10-22 Thread GitBox
blueorangutan commented on issue #3641: security_group.py: fix NameError: name 
'd' is not defined
URL: https://github.com/apache/cloudstack/pull/3641#issuecomment-544875447
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd commented on issue #3641: security_group.py: fix NameError: name 'd' is not defined

2019-10-22 Thread GitBox
rhtyd commented on issue #3641: security_group.py: fix NameError: name 'd' is 
not defined
URL: https://github.com/apache/cloudstack/pull/3641#issuecomment-544875155
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd commented on issue #3641: security_group.py: fix NameError: name 'd' is not defined

2019-10-22 Thread GitBox
rhtyd commented on issue #3641: security_group.py: fix NameError: name 'd' is 
not defined
URL: https://github.com/apache/cloudstack/pull/3641#issuecomment-544875056
 
 
   The changes are in SG related file that trillian doesn't test by default, 
can you share any confirmation of testing @ustcweizhou @wido @GabrielBrascher ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3648: Security Group: limit returns in get_bridge_physdev to 1

2019-10-22 Thread GitBox
blueorangutan commented on issue #3648: Security Group: limit returns in 
get_bridge_physdev to 1
URL: https://github.com/apache/cloudstack/pull/3648#issuecomment-544874707
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd commented on issue #3648: Security Group: limit returns in get_bridge_physdev to 1

2019-10-22 Thread GitBox
rhtyd commented on issue #3648: Security Group: limit returns in 
get_bridge_physdev to 1
URL: https://github.com/apache/cloudstack/pull/3648#issuecomment-544874560
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[cloudstack-primate] 01/02: CONTRIBUTING: fix new repo url

2019-10-22 Thread rohit
This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git

commit ae2c190d8827cd4516d5a20bdf17e0e53a7a6643
Author: Rohit Yadav 
AuthorDate: Tue Oct 22 14:12:39 2019 +0530

CONTRIBUTING: fix new repo url

Signed-off-by: Rohit Yadav 
---
 CONTRIBUTING.md | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index 32bf658..3efe031 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -27,7 +27,7 @@ No back porting / cherry-picking features to existing 
branches!
 
 ## Forking
 
-In your browser, navigate to: 
[https://github.com/shapeblue/primate](https://github.com/shapeblue/primate)
+In your browser, navigate to: 
[https://github.com/apache/cloudstack-primate](https://github.com/apache/cloudstack-primate)
 
 Fork the repository by clicking on the 'Fork' button on the top right hand 
side.
 The fork will happen and you will be taken to your own fork of the repository.
@@ -38,7 +38,7 @@ On your workstation, follow these steps to setup a local 
repository for working
 ``` bash
 $ git clone https://github.com/YOUR_ACCOUNT/primate.git
 $ cd primate
-$ git remote add upstream https://github.com/shapeblue/primate.git
+$ git remote add upstream https://github.com/apache/cloudstack-primate.git
 $ git checkout master
 $ git fetch upstream
 $ git rebase upstream/master



[cloudstack-primate] branch master updated (df58a20 -> 7047634)

2019-10-22 Thread rohit
This is an automated email from the ASF dual-hosted git repository.

rohit pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git.


from df58a20  README: add voting/result history
 new ae2c190  CONTRIBUTING: fix new repo url
 new 7047634  api: fix sorting, checking of outstanding APIs to support

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 CONTRIBUTING.md  | 4 ++--
 docs/api/apis.primate.sh | 6 +-
 2 files changed, 7 insertions(+), 3 deletions(-)



[cloudstack-primate] 02/02: api: fix sorting, checking of outstanding APIs to support

2019-10-22 Thread rohit
This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git

commit 70476340331ae88b2483edb3a20ba45ebcfdd5b8
Author: Rohit Yadav 
AuthorDate: Tue Oct 22 14:32:26 2019 +0530

api: fix sorting, checking of outstanding APIs to support

Signed-off-by: Rohit Yadav 
---
 docs/api/apis.primate.sh | 6 +-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/docs/api/apis.primate.sh b/docs/api/apis.primate.sh
index 92bf6a6..ed43739 100644
--- a/docs/api/apis.primate.sh
+++ b/docs/api/apis.primate.sh
@@ -5,6 +5,10 @@ grep api -R config | sed "s/.*api: '//g" | sed "s/'.*//g" | 
grep -v \.js | sort
 grep store.getters.apis -R . | sed "s/' in.*//g" | sed "s/').*//g" | grep "'" 
| sed "s/.*'//g" | grep -v ']' >> apis.txt
 grep 'permission:\ \[' -R config | sed "s/.*permission: \[ '//g" | grep -v .js 
| sed "s/', '/\\n/g" | sed "s/'.*//g" >> apis.txt
 cat apis.txt | sort | uniq > apis.uniq
+rm -f apis.txt
 mv apis.uniq ../docs/api/apis.txt
 cd ../docs/api
-diff -Naur apis.old apis.txt | grep ^- | grep -v "^--" | sed 's/^-//g' | grep 
-v -i -e cisco -e nicira -e baremetal -e srx -e f5 -e brocade -e palo -e 
autoscale -e counter -e condition -e ucs -e netscaler -e bigswitch -e ovs -e 
globalloadbalancer -e opendaylight -e region -e quota >> apis.remaining
+diff -Naur apis.old apis.txt | grep ^- | grep -v "^--" | sed 's/^-//g' | grep 
-v -i -e cisco -e nicira -e baremetal -e srx -e f5 -e brocade -e palo -e 
autoscale -e counter -e condition -e ucs -e netscaler -e bigswitch -e ovs -e 
globalloadbalancer -e opendaylight -e region -e quota | sort | uniq > 
apis.remaining
+
+echo "$(cat apis.txt | wc -l) APIs are supported by Primate"
+echo "$(cat apis.remaining | wc -l) APIs are remaining"



[GitHub] [cloudstack] blueorangutan commented on issue #3623: kvm: Use 'ip' instead of 'brctl'

2019-10-22 Thread GitBox
blueorangutan commented on issue #3623: kvm: Use 'ip' instead of 'brctl'
URL: https://github.com/apache/cloudstack/pull/3623#issuecomment-544869412
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd commented on issue #3623: kvm: Use 'ip' instead of 'brctl'

2019-10-22 Thread GitBox
rhtyd commented on issue #3623: kvm: Use 'ip' instead of 'brctl'
URL: https://github.com/apache/cloudstack/pull/3623#issuecomment-544869058
 
 
   Something went wrong at the backend, I'll rekick test.
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] RPDiep commented on issue #3648: Security Group: limit returns in get_bridge_physdev to 1

2019-10-22 Thread GitBox
RPDiep commented on issue #3648: Security Group: limit returns in 
get_bridge_physdev to 1
URL: https://github.com/apache/cloudstack/pull/3648#issuecomment-544865583
 
 
   @ustcweizhou 
   
   I'm sure this is something now on the hypervisor, but it appears that corner 
cases exist in which a second line appears. As we only need one result, I added 
the `| head -1` in this commit.
   
   Here's the output you requested (I added the vnet filter)
   ```
   root@n02:~# bridge -o link show | awk '/master cloudbr0 / && !/^[0-9]+: 
vnet/'
   7: bond0.701 state UP @bond0:  mtu 1500 
master cloudbr0 state forwarding priority 32 cost 2 
   7: bond0.701 state UP @bond0:  mtu 1500 
master cloudbr0 
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] GabrielBrascher commented on issue #3623: kvm: Use 'ip' instead of 'brctl'

2019-10-22 Thread GitBox
GabrielBrascher commented on issue #3623: kvm: Use 'ip' instead of 'brctl'
URL: https://github.com/apache/cloudstack/pull/3623#issuecomment-544863217
 
 
   This one looks ready to merge.
   @rhtyd Is there any issue with the **blueorangutan** test?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] ustcweizhou commented on issue #3648: Security Group: limit returns in get_bridge_physdev to 1

2019-10-22 Thread GitBox
ustcweizhou commented on issue #3648: Security Group: limit returns in 
get_bridge_physdev to 1
URL: https://github.com/apache/cloudstack/pull/3648#issuecomment-544838226
 
 
   @RPDiep @GabrielBrascher 
   I did not see this issue on all our platforms. we also use bonding on some 
platforms.
   it seems to be caused by another issue. 
   could you please paste result of command "bridge -o link show | awk '/master 
cloudbr0 /'
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services