[GitHub] [cloudstack] blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router

[GitBox]

blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature 
for virtual router
URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-575867979
 
 
   @anuragaw a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] anuragaw commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router

[GitBox]

anuragaw commented on issue #3575: [WIP DO NOT MERGE] Health check feature for 
virtual router
URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-575867945
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router

[GitBox]

blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature 
for virtual router
URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-575867664
 
 
   Packaging result: ✖centos6 ✔centos7 ✔debian. JID-627


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router

[GitBox]

blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature 
for virtual router
URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-575866647
 
 
   @anuragaw a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] anuragaw commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router

[GitBox]

anuragaw commented on issue #3575: [WIP DO NOT MERGE] Health check feature for 
virtual router
URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-575866644
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] DaanHoogland commented on issue #3383: template: copy md5 mismatch

[GitBox]

DaanHoogland commented on issue #3383: template: copy md5 mismatch
URL: https://github.com/apache/cloudstack/pull/3383#issuecomment-575768353
 
 
   @blueorangutan test matrix


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] DaanHoogland commented on issue #3383: template: copy md5 mismatch

[GitBox]

DaanHoogland commented on issue #3383: template: copy md5 mismatch
URL: https://github.com/apache/cloudstack/pull/3383#issuecomment-575768198
 
 
   @andrijapanicsb my "hack in the chksm" seems to have done it. source 
checksum will be ignored for cross  zone cp. Not a final sturdy design but it 
deals with old urls and archive checksums.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] svenvogel commented on issue #3819: Clean up inactive iscsi sessions when VMs are removed.

[GitBox]

svenvogel commented on issue #3819: Clean up inactive iscsi sessions when VMs 
are removed.
URL: https://github.com/apache/cloudstack/pull/3819#issuecomment-575745250
 
 
   @syed can you review please?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] svenvogel commented on issue #3819: Clean up inactive iscsi sessions when VMs are removed.

[GitBox]

svenvogel commented on issue #3819: Clean up inactive iscsi sessions when VMs 
are removed.
URL: https://github.com/apache/cloudstack/pull/3819#issuecomment-575745119
 
 
   @syed @skattoju4 thanks for your work! we tested it in our production 
environment and it works fine. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] svenvogel commented on issue #3819: Clean up inactive iscsi sessions when VMs are removed.

[GitBox]

svenvogel commented on issue #3819: Clean up inactive iscsi sessions when VMs 
are removed.
URL: https://github.com/apache/cloudstack/pull/3819#issuecomment-575740240
 
 
   I will add details. It’s for kvm and an cleanup of sessions they are not 
removed if move an vm from one host to another, crash of an vm and host crash. 
This fixes the sessions they are there but should removed. This is not good for 
managed storage or solidfire.
   
   This fix is tested with us in our production environment.
   
   
   __
   
   Sven Vogel
   Teamlead Platform
   
   EWERK DIGITAL GmbH
   Brühl 24, D-04109 Leipzig
   P +49 341 42649 - 99
   F +49 341 42649 - 98
   s.vo...@ewerk.com
   www.ewerk.com
   
   Geschäftsführer:
   Dr. Erik Wende, Hendrik Schubert, Frank Richter
   Registergericht: Leipzig HRB 9065
   
   Support:
   +49 341 42649 555
   
   Zertifiziert nach:
   ISO/IEC 27001:2013
   DIN EN ISO 9001:2015
   DIN ISO/IEC 2-1:2011
   
   ISAE 3402 Typ II Assessed
   
   EWERK-Blog | 
LinkedIn | 
Xing | 
Twitter | 
Facebook
   
   E-World 2020 in Essen.
   Das EWERK ist dabei! Treffen Sie uns vom 11-13.02.20 in Halle 5 am Stand: 
5-724, mit spannenden Vorträgen rund um das Thema Urban Data.
   
   Mit Handelsregistereintragung vom 09.07.2019 ist die EWERK RZ GmbH auf die 
EWERK IT GmbH verschmolzen und firmiert nun gemeinsam unter dem Namen: EWERK 
DIGITAL GmbH, für weitere Informationen klicken Sie 
hier.
   
   Auskünfte und Angebote per Mail sind freibleibend und unverbindlich.
   
   Disclaimer Privacy:
   Der Inhalt dieser E-Mail (einschließlich etwaiger beigefügter Dateien) ist 
vertraulich und nur für den Empfänger bestimmt. Sollten Sie nicht der 
bestimmungsgemäße Empfänger sein, ist Ihnen jegliche Offenlegung, 
Vervielfältigung, Weitergabe oder Nutzung des Inhalts untersagt. Bitte 
informieren Sie in diesem Fall unverzüglich den Absender und löschen Sie die 
E-Mail (einschließlich etwaiger beigefügter Dateien) von Ihrem System. Vielen 
Dank.
   
   The contents of this e-mail (including any attachments) are confidential and 
may be legally privileged. If you are not the intended recipient of this 
e-mail, any disclosure, copying, distribution or use of its contents is 
strictly prohibited, and you should please notify the sender immediately and 
then delete it (including any attachments) from your system. Thank you.
   
   Am 17.01.2020 um 19:15 schrieb Andrija Panic :
   
   
   
   Hm - when does this happen exactly @skattoju4
   I recall the Mike T. implemented a fix for the same when VMs are being 
stopped inside the OS (originally iSCSI session would not be removed)
   
   —
   You are receiving this because you are subscribed to this thread.
   Reply to this email directly, view it on 
GitHub,
 or 
unsubscribe.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] andrijapanicsb commented on issue #3819: Clean up inactive iscsi sessions when VMs are removed.

[GitBox]

andrijapanicsb commented on issue #3819: Clean up inactive iscsi sessions when 
VMs are removed.
URL: https://github.com/apache/cloudstack/pull/3819#issuecomment-575736759
 
 
   Hm - when does this happen exactly @skattoju4 
   I recall the Mike T. implemented a fix for the same when VMs are being 
stopped inside the OS (originally iSCSI session would not be removed)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #3383: template: copy md5 mismatch

[GitBox]

blueorangutan commented on issue #3383: template: copy md5 mismatch
URL: https://github.com/apache/cloudstack/pull/3383#issuecomment-575716670
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-626


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] somejfn commented on issue #3820: All agents goes into Alert state if more then 50 KVM hosts in zone on every time MS restarts

[GitBox]

somejfn commented on issue #3820: All agents goes into Alert state if more then 
50 KVM hosts in zone on every time MS restarts
URL: https://github.com/apache/cloudstack/issues/3820#issuecomment-575708720
 
 
   Since I don't have that issue on 4.11.2 with 225 KVM hosts (but also with 
NFS primary storage), I still think there is either a regression in 4.11.3 or 
there's something with the fact the KVMInvestigator is not used in the context 
only managed storage is used.  
   
   Looking at the load on the controller... it is CPU idle 99% after the 
restarts so some contention or bug is happening in MS


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] weizhouapache commented on issue #3820: All agents goes into Alert state if more then 50 KVM hosts in zone on every time MS restarts

[GitBox]

weizhouapache commented on issue #3820: All agents goes into Alert state if 
more then 50 KVM hosts in zone on every time MS restarts
URL: https://github.com/apache/cloudstack/issues/3820#issuecomment-575701677
 
 
   @somejfn we had similar issue when restart cloudstack-agent in backend, but 
do not have issue when we change to restart cloudstack-agent one by one (we use 
NFS).
   this issue seems to be difficult to be reproduced.
   my suggestion is, adding "sleep X" behind "systemctl restart 
cloudstack-agent".
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] somejfn commented on issue #3820: All agents goes into Alert state if more then 50 KVM hosts in zone on every time MS restarts

[GitBox]

somejfn commented on issue #3820: All agents goes into Alert state if more then 
50 KVM hosts in zone on every time MS restarts
URL: https://github.com/apache/cloudstack/issues/3820#issuecomment-575694416
 
 
   The agent restart were triggered using a loop over ssh call "systemctl 
restart cloudstack-agent"  so they are restarted one by one at a few 
seconds interval.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] weizhouapache commented on issue #3820: All agents goes into Alert state if more then 50 KVM hosts in zone on every time MS restarts

[GitBox]

weizhouapache commented on issue #3820: All agents goes into Alert state if 
more then 50 KVM hosts in zone on every time MS restarts
URL: https://github.com/apache/cloudstack/issues/3820#issuecomment-575692655
 
 
   @somejfn do you restart cloudstack-agent on a server, wait until it is done, 
then continue on next server ? or restart cloudstack-agent in backend without 
waiting for the result ?
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] somejfn opened a new issue #3820: All agents goes into Alert state if more then 50 KVM hosts in zone on every time MS restarts

[GitBox]

somejfn opened a new issue #3820: All agents goes into Alert state if more then 
50 KVM hosts in zone on every time MS restarts
URL: https://github.com/apache/cloudstack/issues/3820
 
 
   
   
   # ISSUE TYPE
   
* Bug Report
   
   # COMPONENT NAME
   
   ~~~
   
   ~~~
   
   # CLOUDSTACK VERSION
   
   
   ~~~
   
   ~~~
   
   # CONFIGURATION
   
   
   
   # OS / ENVIRONMENT
   
   
   
   # SUMMARY
   
   In 2 new CS deployments setup as described above,  all agents goes into 
alert state
   a few minutes after every MS restarts.   Restarting all agents at once will 
not solve the issue,
   they would momentarily go all in Up state but then all would PingTimeout and 
get disconnected by MS
   
   The problem seems to have surfaced after adding more KVM hosts agents to the 
zone.
   The current workaround after an MS restart to recover agents is to stop them 
all agents,
   start 50 of them, wait a few minutes then start the remaining.
   
   I tried raising the "workers" global setting from 5 to 15 with no effect.
   
   
   # STEPS TO REPRODUCE
   
   
   
   ~~~
   
   ~~~
   
   
   
   # EXPECTED RESULTS
   
   
   ~~~
   
   ~~~
   
   # ACTUAL RESULTS
   
   
   
   In the MS logs it starts with:
   
   2020-01-16 21:26:51,104 INFO  [c.c.a.m.AgentManagerImpl] 
(AgentMonitor-1:ctx-b00dcc9a) (logid:735e1735) Found the following agents 
behind on ping: [3, 4, 5, 6, 7, 8, 20, 21, 22, 24, 25, 27, 28, 29, 30, 31, 32, 
33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 
55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 
75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 
95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 123, 125, 
126, 127, 130]
   2020-01-16 21:26:51,106 DEBUG [c.c.h.Status] (AgentMonitor-1:ctx-b00dcc9a) 
(logid:735e1735) Ping timeout for agent 3, do invstigation
   2020-01-16 21:26:51,109 INFO  [c.c.a.m.AgentManagerImpl] 
(AgentTaskPool-3:ctx-06879123) (logid:7706df4a) Investigating why host 3 has 
disconnected with event PingTimeout
   2020-01-16 21:26:51,110 DEBUG [c.c.h.Status] (AgentMonitor-1:ctx-b00dcc9a) 
(logid:735e1735) Ping timeout for agent 4, do invstigation
   2020-01-16 21:26:51,111 DEBUG [c.c.a.m.AgentManagerImpl] 
(AgentTaskPool-3:ctx-06879123) (logid:7706df4a) checking if agent (3) is alive
   2020-01-16 21:26:51,112 INFO  [c.c.a.m.AgentManagerImpl] 
(AgentTaskPool-4:ctx-63834273) (logid:c3cd0ece) Investigating why host 4 has 
disconnected with event PingTimeout
   2020-01-16 21:26:51,112 DEBUG [c.c.h.Status] (AgentMonitor-1:ctx-b00dcc9a) 
(logid:735e1735) Ping timeout for agent 5, do invstigation
   2020-01-16 21:26:51,113 DEBUG [c.c.a.m.AgentManagerImpl] 
(AgentTaskPool-4:ctx-63834273) (logid:c3cd0ece) checking if agent (4) is alive
   2020-01-16 21:26:51,113 INFO  [c.c.a.m.AgentManagerImpl] 
(AgentTaskPool-5:ctx-625e8cc2) (logid:5468e471) Investigating why host 5 has 
disconnected with event PingTimeout
   ... 
   2020-01-16 21:26:51,139 DEBUG [c.c.h.Status] (AgentMonitor-1:ctx-b00dcc9a) 
(logid:735e1735) Ping timeout for agent 35, do invstigation
   2020-01-16 21:26:51,141 DEBUG [c.c.h.Status] (AgentMonitor-1:ctx-b00dcc9a) 
(logid:735e1735) Ping timeout for agent 36, do invstigation
   2020-01-16 21:26:51,142 DEBUG [c.c.h.Status] (AgentMonitor-1:ctx-b00dcc9a) 
(logid:735e1735) Ping timeout for agent 37, do invstigation
   2020-01-16 21:26:51,143 DEBUG [c.c.h.Status] (AgentMonitor-1:ctx-b00dcc9a) 
(logid:735e1735) Ping timeout for agent 38, do invstigation
   2020-01-16 21:26:51,144 DEBUG [c.c.h.Status] (AgentMonitor-1:ctx-b00dcc9a) 
(logid:735e1735) Ping timeout for agent 39, do invstigation
   2020-01-16 21:26:51,145 DEBUG [c.c.h.Status] (AgentMonitor-1:ctx-b00dcc9a) 
(logid:735e1735) Ping timeout for agent 40, do invstigation
   ...
   2020-01-16 21:27:41,116 DEBUG [c.c.a.m.AgentAttache] 
(AgentTaskPool-4:ctx-63834273) (logid:c3cd0ece) Seq 4-3368973996249841679: 
Waiting some more time because this is the current command
   2020-01-16 21:27:41,117 DEBUG [c.c.a.m.AgentAttache] 
(AgentTaskPool-5:ctx-625e8cc2) (logid:5468e471) Seq 5-31798752909327: 
Waiting some more time because this is the current command
   2020-01-16 21:27:41,119 DEBUG [c.c.a.m.AgentAttache] 
(AgentTaskPool-6:ctx-54b5f3e5) (logid:838274a3) Seq 6-1602155567437053968: 
Waiting some more time because this is the current command
   2020-01-16 21:27:41,121 DEBUG [c.c.a.m.AgentAttache] 
(AgentTaskPool-7:ctx-923bd0e4) (logid:94e561b3) Seq 7-1566408245394800655: 
Waiting some more time because this is the current command
   2020-01-16 21:27:41,122 DEBUG [c.c.a.m.AgentAttache] 
(AgentTaskPool-8:ctx-ac135079) (logid:2f9a3a8c) Seq 8-7536211026451103758: 
Waiting some more time because this is the current command
   2020-01-16 21:27:41,125 DEBUG [c.c.a.m.AgentAttache] 
(AgentTaskPool-9:ctx-fab4fc39) (logid:ee2d5d66) Seq 20-2074189103380824079: 
Waiting 

[GitHub] [cloudstack] skattoju4 opened a new pull request #3819: Clean up inactive iscsi sessions when VMs are removed.

[GitBox]

skattoju4 opened a new pull request #3819: Clean up inactive iscsi sessions 
when VMs are removed.
URL: https://github.com/apache/cloudstack/pull/3819
 
 
   ## Description
   
   Previously, iscsi sessions would not be cleaned up when VMs are removed. 
This changes adds ankvm.storage.IscsiStorageCleanupMonitor class that cleans up 
inactive iscsi sessions.
   
   
   
   
   
   
   
   
   ## Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   
   
   
   This has been tested by observing that inactive iscsi sessions are cleaned 
up when VMs are removed.
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] wido commented on issue #3817: cloudstack 4.13v unable to start management server

[GitBox]

wido commented on issue #3817: cloudstack 4.13v unable to start management 
server
URL: https://github.com/apache/cloudstack/issues/3817#issuecomment-575665884
 
 
   Seems like you are missing a generic Python dependency:
   
   dns.resolver
   
   
   wido@wido-laptop:~$ python
   Python 2.7.17 (default, Nov  7 2019, 10:07:09) 
   [GCC 7.4.0] on linux2
   Type "help", "copyright", "credits" or "license" for more information.
   >>> import dns.resolver
   >>> quit()
   wido@wido-laptop:~$
   
   
   You need to fix that.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] ravening opened a new pull request #3818: Display numeric value in exception instead of variable name

[GitBox]

ravening opened a new pull request #3818: Display numeric value in exception 
instead of variable name
URL: https://github.com/apache/cloudstack/pull/3818
 
 
   ## Description
   
   If the disk size of the VM to be created is greater
   then the volume size, then the exception message should
   display the numeric value instead of the variable name
   
   
   
   
   
   
   
   ## Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [X] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   Below is the exception which is thrown when error happens while creating a VM
   
   ![Screenshot 2020-01-17 at 13 14 
54](https://user-images.githubusercontent.com/10645273/72620185-179b5480-393f-11ea-9754-3366b8605fb2.png)
   
   After the fix, below is the message which is displayed
   
   ![Screenshot 2020-01-17 at 13 18 
29](https://user-images.githubusercontent.com/10645273/72620204-2124bc80-393f-11ea-97b2-d5ad636d8c1c.png)
   
   ## How Has This Been Tested?
   
   
   
   Set the global setting ```custom.diskoffering.size.max``` to lower value and 
try to create a vm with disk size greater the value of setting 
```custom.diskoffering.size.max```
   
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router

[GitBox]

blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature 
for virtual router
URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-575642172
 
 
   Packaging result: ✖centos6 ✔centos7 ✔debian. JID-625


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] DaanHoogland commented on issue #3364: LDAP users with similar permissions do not see each other's networks

[GitBox]

DaanHoogland commented on issue #3364: LDAP users with similar permissions do 
not see each other's networks
URL: https://github.com/apache/cloudstack/issues/3364#issuecomment-575641249
 
 
   the js isAdmin() only returns true for admin never for another root-admin. 
please amend if you feel this should change @PPisz .


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3680: [WIP: DO NOT MERGE] CloudStack Kubernetes Service

[GitBox]

DaanHoogland commented on a change in pull request #3680: [WIP: DO NOT MERGE] 
CloudStack Kubernetes Service
URL: https://github.com/apache/cloudstack/pull/3680#discussion_r367948102
 
 

 ##
 File path: 
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/version/KubernetesVersionManagerImpl.java
 ##
 @@ -163,47 +169,15 @@ private VirtualMachineTemplate 
registerKubernetesVersionIso(final String version
 f.setAccessible(true);
 f.set(registerIsoCmd, isoChecksum);
 }
+f = registerIsoCmd.getClass().getDeclaredField("accountName");
+f.setAccessible(true);
+f.set(registerIsoCmd, 
accountManager.getSystemAccount().getAccountName());
+f = registerIsoCmd.getClass().getDeclaredField("domainId");
+f.setAccessible(true);
+f.set(registerIsoCmd, accountManager.getSystemAccount().getDomainId());
 return templateService.registerIso(registerIsoCmd);
 }
 
-private void validateExistingTemplateForKubernetesVersionIso(final 
VirtualMachineTemplate template, final Long zoneId) {
-if (!template.getFormat().equals(Storage.ImageFormat.ISO)) {
-throw new InvalidParameterValueException(String.format("%s is not 
an ISO", template.getUuid()));
-}
-if (!template.isPublicTemplate()) {
-throw new InvalidParameterValueException(String.format("ISO ID: %s 
is not public", template.getUuid()));
-}
-if (!template.isCrossZones() && zoneId == null) {
-throw new InvalidParameterValueException(String.format("ISO ID: %s 
is not available across zones", template.getUuid()));
-}
-if (!template.isCrossZones() && zoneId != null) {
-List templatesZoneVOs = 
templateZoneDao.listByZoneTemplate(zoneId, template.getId());
-if (templatesZoneVOs.isEmpty()) {
-DataCenterVO zone = dataCenterDao.findById(zoneId);
-throw new InvalidParameterValueException(String.format("ISO 
ID: %s is not available for zone ID: %s", template.getUuid(), zone.getUuid()));
-}
-}
-}
-
-private VMTemplateVO registerKubernetesVersionIsoIfNeeded(final Long 
isoId, final Long zoneId, final String name, final String isoUrl, final String 
isoChecksum) throws CloudRuntimeException {
-VMTemplateVO templateVO = null;
-if (isoId != null) {
-templateVO = templateDao.findById(isoId);
-}
-if (templateVO == null) {
-try {
-VirtualMachineTemplate vmTemplate = 
registerKubernetesVersionIso(name, isoUrl, isoChecksum);
-templateVO = templateDao.findById(vmTemplate.getId());
-} catch (IllegalAccessException | NoSuchFieldException | 
IllegalArgumentException | ResourceAllocationException ex) {
-LOGGER.error(String.format("Unable to register binaries ISO 
for supported kubernetes version, %s", name), ex);
-throw new CloudRuntimeException(String.format("Unable to 
register binaries ISO for supported kubernetes version, %s", name));
-}
-} else {
-validateExistingTemplateForKubernetesVersionIso(templateVO, 
zoneId);
-}
-return templateVO;
-}
-
 private void deleteKubernetesVersionIso(long templateId) throws 
IllegalAccessException, NoSuchFieldException,
 IllegalArgumentException {
 DeleteIsoCmd deleteIsoCmd = new DeleteIsoCmd();
 
 Review comment:
   same here. just add the setters or the constructor to deal with this.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3680: [WIP: DO NOT MERGE] CloudStack Kubernetes Service

[GitBox]

DaanHoogland commented on a change in pull request #3680: [WIP: DO NOT MERGE] 
CloudStack Kubernetes Service
URL: https://github.com/apache/cloudstack/pull/3680#discussion_r367947474
 
 

 ##
 File path: 
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/version/KubernetesVersionManagerImpl.java
 ##
 @@ -163,47 +169,15 @@ private VirtualMachineTemplate 
registerKubernetesVersionIso(final String version
 f.setAccessible(true);
 f.set(registerIsoCmd, isoChecksum);
 }
+f = registerIsoCmd.getClass().getDeclaredField("accountName");
+f.setAccessible(true);
+f.set(registerIsoCmd, 
accountManager.getSystemAccount().getAccountName());
+f = registerIsoCmd.getClass().getDeclaredField("domainId");
+f.setAccessible(true);
+f.set(registerIsoCmd, accountManager.getSystemAccount().getDomainId());
 return templateService.registerIso(registerIsoCmd);
 }
 
 Review comment:
   I must have mist this before, but i would add setters or add an appropriate 
constructor instead of this tinkering with access.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router

[GitBox]

blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature 
for virtual router
URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-575634170
 
 
   @anuragaw a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] anuragaw commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router

[GitBox]

anuragaw commented on issue #3575: [WIP DO NOT MERGE] Health check feature for 
virtual router
URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-575633933
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #3680: [WIP: DO NOT MERGE] CloudStack Kubernetes Service

[GitBox]

blueorangutan commented on issue #3680: [WIP: DO NOT MERGE] CloudStack 
Kubernetes Service
URL: https://github.com/apache/cloudstack/pull/3680#issuecomment-575629531
 
 
   Packaging result: ✖centos6 ✔centos7 ✔debian. JID-624


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #3606: [WIP DO NOT MERGE] VM ingestion

[GitBox]

blueorangutan commented on issue #3606: [WIP DO NOT MERGE] VM ingestion
URL: https://github.com/apache/cloudstack/pull/3606#issuecomment-575624410
 
 
   Packaging result: ✖centos6 ✔centos7 ✔debian. JID-623


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] svenvogel commented on issue #3179: Redundant VRouter guest network on wrong interface

[GitBox]

svenvogel commented on issue #3179: Redundant VRouter guest network on wrong 
interface
URL: https://github.com/apache/cloudstack/issues/3179#issuecomment-575622505
 
 
   @weizhouapache ping  


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] svenvogel edited a comment on issue #3179: Redundant VRouter guest network on wrong interface

[GitBox]

svenvogel edited a comment on issue #3179: Redundant VRouter guest network on 
wrong interface
URL: https://github.com/apache/cloudstack/issues/3179#issuecomment-573421736
 
 
   @weizhouapache Hi ... back from holiday. i dont know whats tested. there are 
things from your side they needs to be tested so that we come ready to a PR?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] anuragaw commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router

[GitBox]

anuragaw commented on a change in pull request #3575: [WIP DO NOT MERGE] Health 
check feature for virtual router
URL: https://github.com/apache/cloudstack/pull/3575#discussion_r367915557
 
 

 ##
 File path: 
server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
 ##
 @@ -1252,39 +1254,60 @@ protected void runInContext() {
 
 for (final DomainRouterVO router : routers) {
 GetRouterMonitorResultsAnswer answer = 
fetchAndUpdateRouterHealthChecks(router, false);
-String checkFailsToRestartVr = 
RouterHealthChecksFailuresToRestartVr.valueIn(router.getDataCenterId());
-if (answer == null) {
-s_logger.warn("Unable to fetch monitor results for 
router " + router);
-updateRouterConnectivityHealthCheck(router.getId(), 
false, "Communication failed");
-} else if (!answer.getResult()) {
-s_logger.warn("Failed to fetch monitor results from 
router " + router + " with details: " + answer.getDetails());
-updateRouterConnectivityHealthCheck(router.getId(), 
false, "Failed to fetch results with details: " + answer.getDetails());
-} else {
-updateRouterConnectivityHealthCheck(router.getId(), 
true, "Successfully fetched data");
-updateDbHealthChecksFromRouterResponse(router.getId(), 
answer.getMonitoringResults());
-
-// Check failing tests and restart if needed
-if (answer.getFailingChecks().size() > 0 && 
StringUtils.isNotBlank(checkFailsToRestartVr)) {
-s_logger.warn("Found failing checks on router " + 
router + ". " +
-"Checking failed health checks to see if 
router needs reboot");
-for (String failedCheck : 
answer.getFailingChecks()) {
-
ActionEventUtils.onActionEvent(User.UID_SYSTEM, Account.ACCOUNT_ID_SYSTEM,
-Domain.ROOT_DOMAIN, 
EventTypes.EVENT_ROUTER_HEALTH_CHECKS,
-"Router " + router.getUuid() + " has 
failing check " + failedCheck);
-if 
(checkFailsToRestartVr.contains(failedCheck)) {
-s_logger.warn("Health Check Alert: Found 
failing check " + failedCheck + " in " +
-
RouterHealthChecksFailuresToRestartVrCK + ", attempting restart of router.");
-recreateRouter(router.getId());
-}
-}
-}
-}
+List failingChecks = getFailingChecks(router, 
answer);
+handleFailingChecks(router, failingChecks);
 }
 } catch (final Exception ex) {
 s_logger.error("Fail to complete the 
FetchRouterHealthChecksResultTask! ", ex);
 ex.printStackTrace();
 }
 }
+
+private List getFailingChecks(DomainRouterVO router, 
GetRouterMonitorResultsAnswer answer) {
+if (answer == null) {
+s_logger.warn("Unable to fetch monitor results for router " + 
router);
+updateRouterConnectivityHealthCheck(router.getId(), false, 
"Communication failed");
+return Arrays.asList(CONNECTIVITY_TEST);
+} else if (!answer.getResult()) {
+s_logger.warn("Failed to fetch monitor results from router " + 
router + " with details: " + answer.getDetails());
+updateRouterConnectivityHealthCheck(router.getId(), false, 
"Failed to fetch results with details: " + answer.getDetails());
+return Arrays.asList(CONNECTIVITY_TEST);
+} else {
+updateRouterConnectivityHealthCheck(router.getId(), true, 
"Successfully fetched data");
+updateDbHealthChecksFromRouterResponse(router.getId(), 
answer.getMonitoringResults());
+return answer.getFailingChecks();
+}
+}
+
+private void handleFailingChecks(DomainRouterVO router, List 
failingChecks) {
+if (failingChecks == null || failingChecks.size() == 0) {
+return;
+}
+
+String alertMessage = "Health checks failed: " + 
failingChecks.size() + " failing checks on router " + router.getUuid();
+_alertMgr.sendAlert(AlertType.ALERT_TYPE_DOMAIN_ROUTER, 
router.getDataCenterId(), router.getPodIdToDeployIn(),
+alertMessage, alertMessage);
+s_logger.warn(alertMessage + ". Checking failed health checks to 
see if router needs reboot");
+
+String checkFailsToRecreateVr = 

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router

[GitBox]

DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] 
Health check feature for virtual router
URL: https://github.com/apache/cloudstack/pull/3575#discussion_r367914999
 
 

 ##
 File path: 
server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
 ##
 @@ -1252,39 +1254,60 @@ protected void runInContext() {
 
 for (final DomainRouterVO router : routers) {
 GetRouterMonitorResultsAnswer answer = 
fetchAndUpdateRouterHealthChecks(router, false);
-String checkFailsToRestartVr = 
RouterHealthChecksFailuresToRestartVr.valueIn(router.getDataCenterId());
-if (answer == null) {
-s_logger.warn("Unable to fetch monitor results for 
router " + router);
-updateRouterConnectivityHealthCheck(router.getId(), 
false, "Communication failed");
-} else if (!answer.getResult()) {
-s_logger.warn("Failed to fetch monitor results from 
router " + router + " with details: " + answer.getDetails());
-updateRouterConnectivityHealthCheck(router.getId(), 
false, "Failed to fetch results with details: " + answer.getDetails());
-} else {
-updateRouterConnectivityHealthCheck(router.getId(), 
true, "Successfully fetched data");
-updateDbHealthChecksFromRouterResponse(router.getId(), 
answer.getMonitoringResults());
-
-// Check failing tests and restart if needed
-if (answer.getFailingChecks().size() > 0 && 
StringUtils.isNotBlank(checkFailsToRestartVr)) {
-s_logger.warn("Found failing checks on router " + 
router + ". " +
-"Checking failed health checks to see if 
router needs reboot");
-for (String failedCheck : 
answer.getFailingChecks()) {
-
ActionEventUtils.onActionEvent(User.UID_SYSTEM, Account.ACCOUNT_ID_SYSTEM,
-Domain.ROOT_DOMAIN, 
EventTypes.EVENT_ROUTER_HEALTH_CHECKS,
-"Router " + router.getUuid() + " has 
failing check " + failedCheck);
-if 
(checkFailsToRestartVr.contains(failedCheck)) {
-s_logger.warn("Health Check Alert: Found 
failing check " + failedCheck + " in " +
-
RouterHealthChecksFailuresToRestartVrCK + ", attempting restart of router.");
-recreateRouter(router.getId());
-}
-}
-}
-}
+List failingChecks = getFailingChecks(router, 
answer);
+handleFailingChecks(router, failingChecks);
 }
 } catch (final Exception ex) {
 s_logger.error("Fail to complete the 
FetchRouterHealthChecksResultTask! ", ex);
 ex.printStackTrace();
 }
 }
+
+private List getFailingChecks(DomainRouterVO router, 
GetRouterMonitorResultsAnswer answer) {
+if (answer == null) {
+s_logger.warn("Unable to fetch monitor results for router " + 
router);
+updateRouterConnectivityHealthCheck(router.getId(), false, 
"Communication failed");
+return Arrays.asList(CONNECTIVITY_TEST);
+} else if (!answer.getResult()) {
+s_logger.warn("Failed to fetch monitor results from router " + 
router + " with details: " + answer.getDetails());
+updateRouterConnectivityHealthCheck(router.getId(), false, 
"Failed to fetch results with details: " + answer.getDetails());
+return Arrays.asList(CONNECTIVITY_TEST);
+} else {
+updateRouterConnectivityHealthCheck(router.getId(), true, 
"Successfully fetched data");
+updateDbHealthChecksFromRouterResponse(router.getId(), 
answer.getMonitoringResults());
+return answer.getFailingChecks();
+}
+}
+
+private void handleFailingChecks(DomainRouterVO router, List 
failingChecks) {
+if (failingChecks == null || failingChecks.size() == 0) {
+return;
+}
+
+String alertMessage = "Health checks failed: " + 
failingChecks.size() + " failing checks on router " + router.getUuid();
+_alertMgr.sendAlert(AlertType.ALERT_TYPE_DOMAIN_ROUTER, 
router.getDataCenterId(), router.getPodIdToDeployIn(),
+alertMessage, alertMessage);
+s_logger.warn(alertMessage + ". Checking failed health checks to 
see if router needs reboot");
+
+String checkFailsToRecreateVr = 

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router

[GitBox]

DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] 
Health check feature for virtual router
URL: https://github.com/apache/cloudstack/pull/3575#discussion_r367914586
 
 

 ##
 File path: 
server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
 ##
 @@ -1252,39 +1254,60 @@ protected void runInContext() {
 
 for (final DomainRouterVO router : routers) {
 GetRouterMonitorResultsAnswer answer = 
fetchAndUpdateRouterHealthChecks(router, false);
-String checkFailsToRestartVr = 
RouterHealthChecksFailuresToRestartVr.valueIn(router.getDataCenterId());
-if (answer == null) {
-s_logger.warn("Unable to fetch monitor results for 
router " + router);
-updateRouterConnectivityHealthCheck(router.getId(), 
false, "Communication failed");
-} else if (!answer.getResult()) {
-s_logger.warn("Failed to fetch monitor results from 
router " + router + " with details: " + answer.getDetails());
-updateRouterConnectivityHealthCheck(router.getId(), 
false, "Failed to fetch results with details: " + answer.getDetails());
-} else {
-updateRouterConnectivityHealthCheck(router.getId(), 
true, "Successfully fetched data");
-updateDbHealthChecksFromRouterResponse(router.getId(), 
answer.getMonitoringResults());
-
-// Check failing tests and restart if needed
-if (answer.getFailingChecks().size() > 0 && 
StringUtils.isNotBlank(checkFailsToRestartVr)) {
-s_logger.warn("Found failing checks on router " + 
router + ". " +
-"Checking failed health checks to see if 
router needs reboot");
-for (String failedCheck : 
answer.getFailingChecks()) {
-
ActionEventUtils.onActionEvent(User.UID_SYSTEM, Account.ACCOUNT_ID_SYSTEM,
-Domain.ROOT_DOMAIN, 
EventTypes.EVENT_ROUTER_HEALTH_CHECKS,
-"Router " + router.getUuid() + " has 
failing check " + failedCheck);
-if 
(checkFailsToRestartVr.contains(failedCheck)) {
-s_logger.warn("Health Check Alert: Found 
failing check " + failedCheck + " in " +
-
RouterHealthChecksFailuresToRestartVrCK + ", attempting restart of router.");
-recreateRouter(router.getId());
-}
-}
-}
-}
+List failingChecks = getFailingChecks(router, 
answer);
+handleFailingChecks(router, failingChecks);
 }
 } catch (final Exception ex) {
 s_logger.error("Fail to complete the 
FetchRouterHealthChecksResultTask! ", ex);
 ex.printStackTrace();
 }
 }
+
+private List getFailingChecks(DomainRouterVO router, 
GetRouterMonitorResultsAnswer answer) {
+if (answer == null) {
+s_logger.warn("Unable to fetch monitor results for router " + 
router);
+updateRouterConnectivityHealthCheck(router.getId(), false, 
"Communication failed");
+return Arrays.asList(CONNECTIVITY_TEST);
+} else if (!answer.getResult()) {
+s_logger.warn("Failed to fetch monitor results from router " + 
router + " with details: " + answer.getDetails());
+updateRouterConnectivityHealthCheck(router.getId(), false, 
"Failed to fetch results with details: " + answer.getDetails());
+return Arrays.asList(CONNECTIVITY_TEST);
+} else {
+updateRouterConnectivityHealthCheck(router.getId(), true, 
"Successfully fetched data");
+updateDbHealthChecksFromRouterResponse(router.getId(), 
answer.getMonitoringResults());
+return answer.getFailingChecks();
+}
+}
+
+private void handleFailingChecks(DomainRouterVO router, List 
failingChecks) {
+if (failingChecks == null || failingChecks.size() == 0) {
+return;
+}
+
+String alertMessage = "Health checks failed: " + 
failingChecks.size() + " failing checks on router " + router.getUuid();
+_alertMgr.sendAlert(AlertType.ALERT_TYPE_DOMAIN_ROUTER, 
router.getDataCenterId(), router.getPodIdToDeployIn(),
+alertMessage, alertMessage);
+s_logger.warn(alertMessage + ". Checking failed health checks to 
see if router needs reboot");
+
+String checkFailsToRecreateVr = 

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router

[GitBox]

DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] 
Health check feature for virtual router
URL: https://github.com/apache/cloudstack/pull/3575#discussion_r367913932
 
 

 ##
 File path: 
server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
 ##
 @@ -1252,39 +1254,60 @@ protected void runInContext() {
 
 for (final DomainRouterVO router : routers) {
 GetRouterMonitorResultsAnswer answer = 
fetchAndUpdateRouterHealthChecks(router, false);
-String checkFailsToRestartVr = 
RouterHealthChecksFailuresToRestartVr.valueIn(router.getDataCenterId());
-if (answer == null) {
-s_logger.warn("Unable to fetch monitor results for 
router " + router);
-updateRouterConnectivityHealthCheck(router.getId(), 
false, "Communication failed");
-} else if (!answer.getResult()) {
-s_logger.warn("Failed to fetch monitor results from 
router " + router + " with details: " + answer.getDetails());
-updateRouterConnectivityHealthCheck(router.getId(), 
false, "Failed to fetch results with details: " + answer.getDetails());
-} else {
-updateRouterConnectivityHealthCheck(router.getId(), 
true, "Successfully fetched data");
-updateDbHealthChecksFromRouterResponse(router.getId(), 
answer.getMonitoringResults());
-
-// Check failing tests and restart if needed
-if (answer.getFailingChecks().size() > 0 && 
StringUtils.isNotBlank(checkFailsToRestartVr)) {
-s_logger.warn("Found failing checks on router " + 
router + ". " +
-"Checking failed health checks to see if 
router needs reboot");
-for (String failedCheck : 
answer.getFailingChecks()) {
-
ActionEventUtils.onActionEvent(User.UID_SYSTEM, Account.ACCOUNT_ID_SYSTEM,
-Domain.ROOT_DOMAIN, 
EventTypes.EVENT_ROUTER_HEALTH_CHECKS,
-"Router " + router.getUuid() + " has 
failing check " + failedCheck);
-if 
(checkFailsToRestartVr.contains(failedCheck)) {
-s_logger.warn("Health Check Alert: Found 
failing check " + failedCheck + " in " +
-
RouterHealthChecksFailuresToRestartVrCK + ", attempting restart of router.");
-recreateRouter(router.getId());
-}
-}
-}
-}
+List failingChecks = getFailingChecks(router, 
answer);
 
 Review comment:
    


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] anuragaw commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router

[GitBox]

anuragaw commented on a change in pull request #3575: [WIP DO NOT MERGE] Health 
check feature for virtual router
URL: https://github.com/apache/cloudstack/pull/3575#discussion_r367913577
 
 

 ##
 File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java
 ##
 @@ -1197,19 +1194,15 @@
 Pair, Integer> result = 
searchForRoutersInternal(cmd, cmd.getId(), cmd.getRouterName(), cmd.getState(), 
cmd.getZoneId(), cmd.getPodId(), null, cmd.getHostId(),
 cmd.getKeyword(), cmd.getNetworkId(), cmd.getVpcId(), 
cmd.getForVpc(), cmd.getRole(), null);
 ListResponse response = new 
ListResponse();
-if (!VirtualNetworkApplianceManager.RouterHealthChecksEnabled.value()) 
{
-s_logger.debug("Skipping health checks data for internal lbvms as 
it's router.health.checks.enabled is false");
-return response;
-}
-
-
 List routerResponses = 
ViewResponseHelper.createDomainRouterResponse(result.first().toArray(new 
DomainRouterJoinVO[result.first().size()]));
 for (DomainRouterResponse res : routerResponses) {
 DomainRouterVO resRouter = _routerDao.findByUuid(res.getId());
-
res.setHealthChecksFailed(routerHealthCheckResultDao.hasFailingChecks(resRouter.getId()));
-if (cmd.shouldFetchHealthCheckResults()) {
-
res.setHealthCheckResults(responseGenerator.createHealthCheckResponse(resRouter,
-new 
ArrayList<>(routerHealthCheckResultDao.getHealthCheckResults(resRouter.getId();
+if 
(VirtualNetworkApplianceManager.RouterHealthChecksEnabled.value()) {
 
 Review comment:
   Does not depend but we want to trim the response for each router based on 
this flag being true/false


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] anuragaw commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router

[GitBox]

anuragaw commented on a change in pull request #3575: [WIP DO NOT MERGE] Health 
check feature for virtual router
URL: https://github.com/apache/cloudstack/pull/3575#discussion_r367913605
 
 

 ##
 File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java
 ##
 @@ -1174,18 +1174,15 @@
 Pair, Integer> result = 
searchForRoutersInternal(cmd, cmd.getId(), cmd.getRouterName(), cmd.getState(), 
cmd.getZoneId(), cmd.getPodId(), cmd.getClusterId(),
 cmd.getHostId(), cmd.getKeyword(), cmd.getNetworkId(), 
cmd.getVpcId(), cmd.getForVpc(), cmd.getRole(), cmd.getVersion());
 ListResponse response = new 
ListResponse();
-if (!VirtualNetworkApplianceManager.RouterHealthChecksEnabled.value()) 
{
-s_logger.debug("Skipping health checks data in router as 
router.health.checks.enabled is false for router");
-return response;
-}
-
 List routerResponses = 
ViewResponseHelper.createDomainRouterResponse(result.first().toArray(new 
DomainRouterJoinVO[result.first().size()]));
 for (DomainRouterResponse res : routerResponses) {
 DomainRouterVO resRouter = _routerDao.findByUuid(res.getId());
-
res.setHealthChecksFailed(routerHealthCheckResultDao.hasFailingChecks(resRouter.getId()));
-if (cmd.shouldFetchHealthCheckResults()) {
-
res.setHealthCheckResults(responseGenerator.createHealthCheckResponse(resRouter,
-new 
ArrayList<>(routerHealthCheckResultDao.getHealthCheckResults(resRouter.getId();
+if 
(VirtualNetworkApplianceManager.RouterHealthChecksEnabled.value()) {
 
 Review comment:
   Does not depend but we want to trim the response for each router based on 
this flag being true/false


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router

[GitBox]

DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] 
Health check feature for virtual router
URL: https://github.com/apache/cloudstack/pull/3575#discussion_r367913299
 
 

 ##
 File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java
 ##
 @@ -1197,19 +1194,15 @@
 Pair, Integer> result = 
searchForRoutersInternal(cmd, cmd.getId(), cmd.getRouterName(), cmd.getState(), 
cmd.getZoneId(), cmd.getPodId(), null, cmd.getHostId(),
 cmd.getKeyword(), cmd.getNetworkId(), cmd.getVpcId(), 
cmd.getForVpc(), cmd.getRole(), null);
 ListResponse response = new 
ListResponse();
-if (!VirtualNetworkApplianceManager.RouterHealthChecksEnabled.value()) 
{
-s_logger.debug("Skipping health checks data for internal lbvms as 
it's router.health.checks.enabled is false");
-return response;
-}
-
-
 List routerResponses = 
ViewResponseHelper.createDomainRouterResponse(result.first().toArray(new 
DomainRouterJoinVO[result.first().size()]));
 for (DomainRouterResponse res : routerResponses) {
 DomainRouterVO resRouter = _routerDao.findByUuid(res.getId());
-
res.setHealthChecksFailed(routerHealthCheckResultDao.hasFailingChecks(resRouter.getId()));
-if (cmd.shouldFetchHealthCheckResults()) {
-
res.setHealthCheckResults(responseGenerator.createHealthCheckResponse(resRouter,
-new 
ArrayList<>(routerHealthCheckResultDao.getHealthCheckResults(resRouter.getId();
+if 
(VirtualNetworkApplianceManager.RouterHealthChecksEnabled.value()) {
 
 Review comment:
   why put this condition in the loop? it seems its value would not depend on 
the iteration


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router

[GitBox]

DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] 
Health check feature for virtual router
URL: https://github.com/apache/cloudstack/pull/3575#discussion_r367913352
 
 

 ##
 File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java
 ##
 @@ -1174,18 +1174,15 @@
 Pair, Integer> result = 
searchForRoutersInternal(cmd, cmd.getId(), cmd.getRouterName(), cmd.getState(), 
cmd.getZoneId(), cmd.getPodId(), cmd.getClusterId(),
 cmd.getHostId(), cmd.getKeyword(), cmd.getNetworkId(), 
cmd.getVpcId(), cmd.getForVpc(), cmd.getRole(), cmd.getVersion());
 ListResponse response = new 
ListResponse();
-if (!VirtualNetworkApplianceManager.RouterHealthChecksEnabled.value()) 
{
-s_logger.debug("Skipping health checks data in router as 
router.health.checks.enabled is false for router");
-return response;
-}
-
 List routerResponses = 
ViewResponseHelper.createDomainRouterResponse(result.first().toArray(new 
DomainRouterJoinVO[result.first().size()]));
 for (DomainRouterResponse res : routerResponses) {
 DomainRouterVO resRouter = _routerDao.findByUuid(res.getId());
-
res.setHealthChecksFailed(routerHealthCheckResultDao.hasFailingChecks(resRouter.getId()));
-if (cmd.shouldFetchHealthCheckResults()) {
-
res.setHealthCheckResults(responseGenerator.createHealthCheckResponse(resRouter,
-new 
ArrayList<>(routerHealthCheckResultDao.getHealthCheckResults(resRouter.getId();
+if 
(VirtualNetworkApplianceManager.RouterHealthChecksEnabled.value()) {
 
 Review comment:
   why put this condition in the loop? it seems its value would not depend on 
the iteration


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router

[GitBox]

blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature 
for virtual router
URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-575587292
 
 
   Packaging result: ✖centos6 ✔centos7 ✔debian. JID-622


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #3606: [WIP DO NOT MERGE] VM ingestion

[GitBox]

blueorangutan commented on issue #3606: [WIP DO NOT MERGE] VM ingestion
URL: https://github.com/apache/cloudstack/pull/3606#issuecomment-575582630
 
 
   Packaging result: ✖centos6 ✔centos7 ✔debian. JID-621


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router

[GitBox]

blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature 
for virtual router
URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-575580104
 
 
   @anuragaw a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] anuragaw commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router

[GitBox]

anuragaw commented on issue #3575: [WIP DO NOT MERGE] Health check feature for 
virtual router
URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-575579788
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router

[GitBox]

blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature 
for virtual router
URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-575548126
 
 
   Packaging result: ✖centos6 ✔centos7 ✔debian. JID-620


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #3606: [WIP DO NOT MERGE] VM ingestion

[GitBox]

blueorangutan commented on issue #3606: [WIP DO NOT MERGE] VM ingestion
URL: https://github.com/apache/cloudstack/pull/3606#issuecomment-575547174
 
 
   Packaging result: ✖centos6 ✔centos7 ✔debian. JID-619


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #3748: [WIP DO NOT MERGE] Systemvm template api

[GitBox]

blueorangutan commented on issue #3748: [WIP DO NOT MERGE] Systemvm template api
URL: https://github.com/apache/cloudstack/pull/3748#issuecomment-575539569
 
 
   Packaging result: ✖centos6 ✔centos7 ✔debian. JID-617


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router

[GitBox]

blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature 
for virtual router
URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-575539089
 
 
   @anuragaw a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] anuragaw commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router

[GitBox]

anuragaw commented on issue #3575: [WIP DO NOT MERGE] Health check feature for 
virtual router
URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-575538974
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #3748: [WIP DO NOT MERGE] Systemvm template api

[GitBox]

blueorangutan commented on issue #3748: [WIP DO NOT MERGE] Systemvm template api
URL: https://github.com/apache/cloudstack/pull/3748#issuecomment-575532356
 
 
   @Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] Spaceman1984 commented on issue #3748: [WIP DO NOT MERGE] Systemvm template api

[GitBox]

Spaceman1984 commented on issue #3748: [WIP DO NOT MERGE] Systemvm template api
URL: https://github.com/apache/cloudstack/pull/3748#issuecomment-575532114
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] prashant2594 opened a new issue #3817: cloudstack 4.13v unable to start management server

[GitBox]

prashant2594 opened a new issue #3817: cloudstack 4.13v unable to start 
management server
URL: https://github.com/apache/cloudstack/issues/3817
 
 
   @rhtyd 
   
   # ISSUE TYPE
   
   
* Other
   
   # COMPONENT NAME
   
   ~~~
   cloudstack management 
   ~~~
   
   # CLOUDSTACK VERSION
   
   
   ~~~
   4.13
   ~~~
   
   # CONFIGURATION
   
   cloudstack 4.13v , hypervisor : KVM
   
   # OS / ENVIRONMENT
   
   centos7
   
   # SUMMARY
   
   I'm trying to setup cloudstack 4.13v, till two days back everything was 
working fine, but from last night,, when I formatted and re-tried to install 
cloudstack management  using the cmd : **cloudstack-setup-management** I'm 
getting the error : **ImportError: No module named dns.reslover** . And unable 
to start cloudstack management server.
   
   # STEPS TO REPRODUCE
   
   
   
   ~~~
   cloudstack-setup-management
   [Screen Shot 2020-01-17 at
@@@12.47..zip](https://github.com/apache/cloudstack/files/4075765/Screen.Shot.2020-01-17.at.12.47.zip)
   
   ~~~
   
   
   
   # EXPECTED RESULTS
   
   
   ~~~
   to install cloudstack management without facing above issue
   ~~~
   
   # ACTUAL RESULTS
   
   
   
   ~~~
   cloudstack-setup-management
   Traceback (most recent call last):
 File "/usr/bin/cloudstack-setup-management", line 24, in 
   from cloudutils.serviceConfigServer import cloudManagementConfig
 File 
"/usr/lib64/python2.7/site-packages/cloudutils/serviceConfigServer.py", line 
17, in 
   from db import Database
 File "/usr/lib64/python2.7/site-packages/cloudutils/db.py", line 20, in 

   import mysql.connector
 File "/usr/lib64/python2.7/site-packages/mysql/connector/__init__.py", 
line 41, in 
   import dns.resolver
   ImportError: No module named dns.resolver
   ~~~
   
   
   grep -i -E 'exception|unable|fail|invalid|leak|warn|error' 
/var/log/cloudstack/management/management-server.log
   2020-01-16 16:09:31,558 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
CREATE TABLE `cloud`.`s3` ( `id` bigint unsigned NOT NULL AUTO_INCREMENT 
COMMENT 'id', `uuid` varchar(40), `access_key` varchar(20) NOT NULL COMMENT ' 
The S3 access key', `secret_key` varchar(40) NOT NULL COMMENT ' The S3 secret 
key', `end_point` varchar(1024) COMMENT ' The S3 host', `bucket` varchar(63) 
NOT NULL COMMENT ' The S3 host', `https` tinyint unsigned DEFAULT NULL COMMENT 
' Flag indicating whether or not to connect over HTTPS', `connection_timeout` 
integer COMMENT ' The amount of time to wait (in milliseconds) when initially 
establishing a connection before giving up and timing out.', `max_error_retry` 
integer COMMENT ' The maximum number of retry attempts for failed retryable 
requests (ex: 5xx error responses from services).', `socket_timeout` integer 
COMMENT ' The amount of time to wait (in milliseconds) for data to be 
transfered over an established, open connection before the connection times out 
and is closed.', `created` datetime COMMENT 'date the s3 first signed on', 
PRIMARY KEY (`id`), CONSTRAINT `uc_s3__uuid` UNIQUE (`uuid`) ) ENGINE=InnoDB 
DEFAULT CHARSET=utf8 
   2020-01-16 16:09:37,681 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
CREATE VIEW `cloud`.`volume_view` AS select volumes.id, volumes.uuid, 
volumes.name, volumes.device_id, volumes.volume_type, volumes.size, 
volumes.created, volumes.state, volumes.attached, volumes.removed, 
volumes.pod_id, account.id account_id, account.uuid account_uuid, 
account.account_name account_name, account.type account_type, domain.id 
domain_id, domain.uuid domain_uuid, domain.name domain_name, domain.path 
domain_path, projects.id project_id, projects.uuid project_uuid, projects.name 
project_name, data_center.id data_center_id, data_center.uuid data_center_uuid, 
data_center.name data_center_name, vm_instance.id vm_id, vm_instance.uuid 
vm_uuid, vm_instance.name vm_name, vm_instance.state vm_state, 
vm_instance.vm_type, user_vm.display_name vm_display_name, volume_host_ref.size 
volume_host_size, volume_host_ref.created volume_host_created, 
volume_host_ref.format, volume_host_ref.download_pct, 
volume_host_ref.download_state, volume_host_ref.error_str, disk_offering.id 
disk_offering_id, disk_offering.uuid disk_offering_uuid, disk_offering.name 
disk_offering_name, disk_offering.display_text disk_offering_display_text, 
disk_offering.use_local_storage, disk_offering.system_use, storage_pool.id 
pool_id, storage_pool.uuid pool_uuid, storage_pool.name pool_name, 
cluster.hypervisor_type, vm_template.id template_id, vm_template.uuid 
template_uuid, vm_template.extractable, vm_template.type template_type, 
resource_tags.id tag_id, resource_tags.uuid tag_uuid, resource_tags.key 
tag_key, resource_tags.value tag_value, resource_tags.domain_id tag_domain_id, 
resource_tags.account_id tag_account_id, resource_tags.resource_id 
tag_resource_id, resource_tags.resource_uuid tag_resource_uuid, 
resource_tags.resource_type