[GitHub] [cloudstack] GabrielBrascher opened a new pull request #3681: Validate disk offering IOPS normal and maximum read/write values
GabrielBrascher opened a new pull request #3681: Validate disk offering IOPS
normal and maximum read/write values
URL: https://github.com/apache/cloudstack/pull/3681
## Description
When creating a new disk offering ('createDiskOffering' command on API) one
can set _normal_ IOPS (write/read) higher than the maximum, breaking the logics
on the disk offerings.
This PR adds verifications ensuring that _normal_ read/write cannot be
greater than _maximum_ read/write. Additionally, it was added a global settings
'iops.maximum.rate.length' to ensure realistic values for the IOPS burst length
(seconds).
The global settings 'iops.maximum.rate.length' configures the maximum IOPS
read/write length; thus, preventing irrealistic values for a disk offering
(e.g. hours or days of burst IOPS). The default value is 0 (zero), allowing any
IOPS maximum rate length; thus keeping backward compatibility and not affecting
any environment configuration after upgrades.
# Example:
One can set the 'iops.maximum.rate.length' to '3600' (seconds); once the
parameter is updated on the management server it will not be possible to create
disk offerings with IOPS length higher than 3600 seconds (60 minutes).
## Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)g
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] GabrielBrascher closed pull request #3681: Validate disk offering IOPS normal and maximum read/write values
GabrielBrascher closed pull request #3681: Validate disk offering IOPS normal and maximum read/write values URL: https://github.com/apache/cloudstack/pull/3681 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3847: VR: Fix Redundant VRouter guest network on wrong interface
blueorangutan commented on issue #3847: VR: Fix Redundant VRouter guest network on wrong interface URL: https://github.com/apache/cloudstack/pull/3847#issuecomment-588084011 @rhtyd a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3847: VR: Fix Redundant VRouter guest network on wrong interface
rhtyd commented on issue #3847: VR: Fix Redundant VRouter guest network on wrong interface URL: https://github.com/apache/cloudstack/pull/3847#issuecomment-588083777 @blueorangutan test matrix This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3847: VR: Fix Redundant VRouter guest network on wrong interface
blueorangutan commented on issue #3847: VR: Fix Redundant VRouter guest network on wrong interface URL: https://github.com/apache/cloudstack/pull/3847#issuecomment-588083396 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-899 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #3639: Multiple networks support for vms in advanced zone with security group (and kvm support)
GabrielBrascher commented on a change in pull request #3639: Multiple networks
support for vms in advanced zone with security group (and kvm support)
URL: https://github.com/apache/cloudstack/pull/3639#discussion_r381113242
##
File path: core/src/main/java/com/cloud/agent/api/SecurityGroupRulesCmd.java
##
@@ -30,12 +30,13 @@
import org.apache.log4j.Logger;
import com.cloud.agent.api.LogLevel.Log4jLevel;
+import com.cloud.agent.api.to.VirtualMachineTO;
import com.cloud.utils.net.NetUtils;
public class SecurityGroupRulesCmd extends Command {
private static final String CIDR_LENGTH_SEPARATOR = "/";
-private static final char RULE_TARGET_SEPARATOR = ',';
-private static final char RULE_COMMAND_SEPARATOR = ';';
+public static final char RULE_TARGET_SEPARATOR = ',';
Review comment:
I see that RULE_TARGET_SEPARATOR is not being used outside this class. Is
that correct? If it is indeed the case, this should be set back to private.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #3639: Multiple networks support for vms in advanced zone with security group (and kvm support)
GabrielBrascher commented on a change in pull request #3639: Multiple networks
support for vms in advanced zone with security group (and kvm support)
URL: https://github.com/apache/cloudstack/pull/3639#discussion_r381114940
##
File path:
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
##
@@ -3548,7 +3550,117 @@ public boolean destroyNetworkRulesForVM(final Connect
conn, final String vmName)
return true;
}
-public boolean defaultNetworkRules(final Connect conn, final String
vmName, final NicTO nic, final Long vmId, final String secIpStr) {
+/**
+ * Function to destroy the security group rules applied to the nic's
+ * @param conn
+ * @param vmName
+ * @param nic
+ * @return
+ * true : If success
+ * false : If failure
+ */
+public boolean destroyNetworkRulesForNic(final Connect conn, final String
vmName, final NicTO nic) {
+if (!_canBridgeFirewall) {
+return false;
+}
+final List nicSecIps = nic.getNicSecIps();
+String secIpsStr;
+final StringBuilder sb = new StringBuilder();
+if (nicSecIps != null) {
+for (final String ip : nicSecIps) {
+
sb.append(ip).append(SecurityGroupRulesCmd.RULE_COMMAND_SEPARATOR);
+}
+secIpsStr = sb.toString();
+} else {
+secIpsStr = "0" + SecurityGroupRulesCmd.RULE_COMMAND_SEPARATOR;
+}
+final List intfs = getInterfaces(conn, vmName);
+if (intfs.size() == 0 || intfs.size() < nic.getDeviceId()) {
+return false;
+}
+
+final InterfaceDef intf = intfs.get(nic.getDeviceId());
+final String brname = intf.getBrName();
+final String vif = intf.getDevName();
+
+final Script cmd = new Script(_securityGroupPath, _timeout, s_logger);
+cmd.add("destroy_network_rules_for_vm");
+cmd.add("--vmname", vmName);
+if (nic.getIp() != null) {
+cmd.add("--vmip", nic.getIp());
+}
+cmd.add("--vmmac", nic.getMac());
+cmd.add("--vif", vif);
+cmd.add("--nicsecips", secIpsStr);
+
+final String result = cmd.execute();
+if (result != null) {
+return false;
+}
+return true;
+}
+
+/**
+ * Function to apply default network rules for a VM
+ * @param conn
+ * @param vm
+ * @param checkBeforeApply
+ * @return
Review comment:
Thanks for adding documentation.
**Just a note:** I don't think that `@param` adds much info when it holds
only the parameter name, normally I would vote to remove them, or add some
description on each param.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #3639: Multiple networks support for vms in advanced zone with security group (and kvm support)
GabrielBrascher commented on a change in pull request #3639: Multiple networks support for vms in advanced zone with security group (and kvm support) URL: https://github.com/apache/cloudstack/pull/3639#discussion_r381124218 ## File path: engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java ## @@ -333,6 +335,8 @@ private NetworkOfferingDetailsDao networkOfferingDetailsDao; @Inject private NetworkDetailsDao networkDetailsDao; +@Inject +private SecurityGroupManager _securityGroupManager; Review comment: [Java Naming Conventions](https://docs.oracle.com/javase/tutorial/java/nutsandbolts/variables.html) does not recommend using _ (underscore) before variable name. Can you please remove it? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #3639: Multiple networks support for vms in advanced zone with security group (and kvm support)
GabrielBrascher commented on a change in pull request #3639: Multiple networks
support for vms in advanced zone with security group (and kvm support)
URL: https://github.com/apache/cloudstack/pull/3639#discussion_r381113242
##
File path: core/src/main/java/com/cloud/agent/api/SecurityGroupRulesCmd.java
##
@@ -30,12 +30,13 @@
import org.apache.log4j.Logger;
import com.cloud.agent.api.LogLevel.Log4jLevel;
+import com.cloud.agent.api.to.VirtualMachineTO;
import com.cloud.utils.net.NetUtils;
public class SecurityGroupRulesCmd extends Command {
private static final String CIDR_LENGTH_SEPARATOR = "/";
-private static final char RULE_TARGET_SEPARATOR = ',';
-private static final char RULE_COMMAND_SEPARATOR = ';';
+public static final char RULE_TARGET_SEPARATOR = ',';
Review comment:
I see that RULE_TARGET_SEPARATOR is not being used on tests. Is that
correct? If it is indeed not necessary on tests, it can be set back to private.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3491: KVM: Propagating changes on host parameters to the agents
rhtyd commented on issue #3491: KVM: Propagating changes on host parameters to the agents URL: https://github.com/apache/cloudstack/pull/3491#issuecomment-588080289 @nvazquez @DaanHoogland @andrijapanicsb can you review? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3886: maven: configure toolchains based on ASF infra jdk names
rhtyd commented on issue #3886: maven: configure toolchains based on ASF infra jdk names URL: https://github.com/apache/cloudstack/pull/3886#issuecomment-588079968 You've my support @DaanHoogland, maybe discuss a workaround - perhaps we did not understand the usage/configuration of toolchains well? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch master updated (4ab6b42 -> 3950de1)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 4ab6b42 server: Add new command to update security group name (#3739) add 649ed45 kvm: fix exception in volume statts after storage migration (#3884) add 37d2b85 kvm: Enable virtio drivers based on guest os display name (#3879) new 3950de1 Merge remote-tracking branch 'origin/4.13' The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: server/src/main/java/com/cloud/hypervisor/KVMGuru.java| 2 +- server/src/main/java/com/cloud/server/StatsCollector.java | 8 +--- 2 files changed, 2 insertions(+), 8 deletions(-)
[cloudstack] 01/01: Merge remote-tracking branch 'origin/4.13'
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit 3950de116d61fb9605b1f2aa319fc88e07c17075 Merge: 4ab6b42 37d2b85 Author: Rohit Yadav AuthorDate: Wed Feb 19 13:13:04 2020 +0530 Merge remote-tracking branch 'origin/4.13' server/src/main/java/com/cloud/hypervisor/KVMGuru.java| 2 +- server/src/main/java/com/cloud/server/StatsCollector.java | 8 +--- 2 files changed, 2 insertions(+), 8 deletions(-)
[cloudstack] branch 4.13 updated: kvm: Enable virtio drivers based on guest os display name (#3879)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch 4.13
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/4.13 by this push:
new 37d2b85 kvm: Enable virtio drivers based on guest os display name
(#3879)
37d2b85 is described below
commit 37d2b8537c454cdafdaf240dba37a4e1767afe2e
Author: Wei Zhou
AuthorDate: Wed Feb 19 08:42:20 2020 +0100
kvm: Enable virtio drivers based on guest os display name (#3879)
When we add new guest os, sometimes we missed the records in
guest_os_hypervisor.
However, the guest disk model (virtio/ide) is determined by record in the
table.
It causes the issue that some new guest os(eg Debian 8/9) uses e1000
instead of virtio nic, and ide disk instead of virtio disk.
To fix the issue permanantly, pass the guest os name in guest_os if the
record for kvm is not found in guest_os_hypervisor.
Related commit:7ac9f00eeeb4cd37ec39efeba066e799b581b1a0
---
server/src/main/java/com/cloud/hypervisor/KVMGuru.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/server/src/main/java/com/cloud/hypervisor/KVMGuru.java
b/server/src/main/java/com/cloud/hypervisor/KVMGuru.java
index 2b84ff9b..cf29a1a 100644
--- a/server/src/main/java/com/cloud/hypervisor/KVMGuru.java
+++ b/server/src/main/java/com/cloud/hypervisor/KVMGuru.java
@@ -132,7 +132,7 @@ public class KVMGuru extends HypervisorGuruBase implements
HypervisorGuru {
guestOsMapping =
_guestOsHypervisorDao.findByOsIdAndHypervisor(guestOS.getId(),
getHypervisorType().toString(), host.getHypervisorVersion());
}
if (guestOsMapping == null || host == null) {
-to.setPlatformEmulator("Other");
+to.setPlatformEmulator(guestOS.getDisplayName() == null ? "Other"
: guestOS.getDisplayName());
} else {
to.setPlatformEmulator(guestOsMapping.getGuestOsName());
}
[cloudstack] branch master updated (0c46dfa -> 4ab6b42)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.
from 0c46dfa Merge remote-tracking branch 'origin/4.13'
add 4ab6b42 server: Add new command to update security group name (#3739)
No new revisions were added by this update.
Summary of changes:
.travis.yml| 1 +
api/src/main/java/com/cloud/event/EventTypes.java | 1 +
.../network/security/SecurityGroupService.java | 11 +-
.../UpdateSecurityGroupCmd.java} | 54 ++--
.../cloud/network/security/SecurityGroupVO.java| 4 +
.../network/security/SecurityGroupManagerImpl.java | 59
.../com/cloud/server/ManagementServerImpl.java | 2 +
.../smoke/test_update_security_group.py| 312 +
ui/scripts/network.js | 31 +-
9 files changed, 449 insertions(+), 26 deletions(-)
copy
api/src/main/java/org/apache/cloudstack/api/command/user/{vmgroup/UpdateVMGroupCmd.java
=> securitygroup/UpdateSecurityGroupCmd.java} (63%)
create mode 100644 test/integration/smoke/test_update_security_group.py
[cloudstack] branch 4.13 updated (bbe2bf1 -> 649ed45)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch 4.13 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from bbe2bf1 server: ignore site to site vpn status check on internallbvm (#3864) add 649ed45 kvm: fix exception in volume statts after storage migration (#3884) No new revisions were added by this update. Summary of changes: server/src/main/java/com/cloud/server/StatsCollector.java | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-)
[cloudstack-primate] branch master updated (212e16e -> 25d9fbf)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git. from 212e16e permission: validate login against cookies, clear all cookies on logout add 25d9fbf permission: read cookie from both default and /client path No new revisions were added by this update. Summary of changes: src/permission.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
[cloudstack-primate] branch master updated (6927504 -> 212e16e)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git. from 6927504 permission: fix cookie handling to allow saml to work add 212e16e permission: validate login against cookies, clear all cookies on logout No new revisions were added by this update. Summary of changes: src/permission.js | 9 +++-- src/store/modules/user.js | 15 +-- 2 files changed, 8 insertions(+), 16 deletions(-)
[GitHub] [cloudstack] blueorangutan commented on issue #3681: Validate disk offering IOPS normal and maximum read/write values
blueorangutan commented on issue #3681: Validate disk offering IOPS normal and maximum read/write values URL: https://github.com/apache/cloudstack/pull/3681#issuecomment-588058234 Packaging result: ✖centos6 ✖centos7 ✖debian. JID-898 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3681: Validate disk offering IOPS normal and maximum read/write values
blueorangutan commented on issue #3681: Validate disk offering IOPS normal and maximum read/write values URL: https://github.com/apache/cloudstack/pull/3681#issuecomment-588056196 @GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] GabrielBrascher commented on issue #3681: Validate disk offering IOPS normal and maximum read/write values
GabrielBrascher commented on issue #3681: Validate disk offering IOPS normal and maximum read/write values URL: https://github.com/apache/cloudstack/pull/3681#issuecomment-588056036 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack-primate] 02/02: permission: fix cookie handling to allow saml to work
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git
commit 6927504e40479ec971da45d0218d245700f64616
Author: Rohit Yadav
AuthorDate: Wed Feb 19 11:09:44 2020 +0530
permission: fix cookie handling to allow saml to work
Signed-off-by: Rohit Yadav
---
src/permission.js | 5 +
src/store/modules/user.js | 22 +++---
2 files changed, 16 insertions(+), 11 deletions(-)
diff --git a/src/permission.js b/src/permission.js
index 04e0925..3216a4d 100644
--- a/src/permission.js
+++ b/src/permission.js
@@ -15,6 +15,7 @@
// specific language governing permissions and limitations
// under the License.
+import Cookies from 'js-cookie'
import Vue from 'vue'
import router from './router'
import store from './store'
@@ -33,6 +34,10 @@ router.beforeEach((to, from, next) => {
// start progress bar
NProgress.start()
to.meta && (typeof to.meta.title !== 'undefined' &&
setDocumentTitle(`${to.meta.title} - ${domTitle}`))
+ const sessionKeyCookie = Cookies.get('sessionkey')
+ if (sessionKeyCookie && !Vue.ls.get(ACCESS_TOKEN)) {
+Vue.ls.set(ACCESS_TOKEN, sessionKeyCookie, 24 * 60 * 60 * 1000)
+ }
if (Vue.ls.get(ACCESS_TOKEN)) {
if (to.path === '/user/login') {
next({ path: '/dashboard' })
diff --git a/src/store/modules/user.js b/src/store/modules/user.js
index be0e963..b2482a4 100644
--- a/src/store/modules/user.js
+++ b/src/store/modules/user.js
@@ -85,17 +85,17 @@ const user = {
login(userInfo).then(response => {
const result = response.loginresponse || {}
- Cookies.set('account', result.account)
- Cookies.set('domainid', result.domainid)
- Cookies.set('role', result.type)
- Cookies.set('sessionkey', result.sessionkey)
- Cookies.set('timezone', result.timezone)
- Cookies.set('timezoneoffset', result.timezoneoffset)
- Cookies.set('userfullname', result.firstname + ' ' + result.lastname)
- Cookies.set('userid', result.userid)
- Cookies.set('username', result.username)
-
- Vue.ls.set(ACCESS_TOKEN, result.sessionkey, 60 * 60 * 1000)
+ Cookies.set('account', result.account, { expires: 1 })
+ Cookies.set('domainid', result.domainid, { expires: 1 })
+ Cookies.set('role', result.type, { expires: 1 })
+ Cookies.set('sessionkey', result.sessionkey, { expires: 1 })
+ Cookies.set('timezone', result.timezone, { expires: 1 })
+ Cookies.set('timezoneoffset', result.timezoneoffset, { expires: 1 })
+ Cookies.set('userfullname', result.firstname + ' ' +
result.lastname, { expires: 1 })
+ Cookies.set('userid', result.userid, { expires: 1 })
+ Cookies.set('username', result.username, { expires: 1 })
+
+ Vue.ls.set(ACCESS_TOKEN, result.sessionkey, 24 * 60 * 60 * 1000)
commit('SET_TOKEN', result.sessionkey)
commit('SET_PROJECT', {})
commit('SET_ASYNC_JOB_IDS', [])
[cloudstack-primate] 01/02: login: fix unhandled promise issue
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git
commit f499f2e35faf5728112dee9284715c99047465e8
Author: Rohit Yadav
AuthorDate: Wed Feb 19 10:53:47 2020 +0530
login: fix unhandled promise issue
Signed-off-by: Rohit Yadav
---
src/views/auth/Login.vue | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/views/auth/Login.vue b/src/views/auth/Login.vue
index c64c38b..1bc6ec0 100644
--- a/src/views/auth/Login.vue
+++ b/src/views/auth/Login.vue
@@ -174,8 +174,8 @@ export default {
})
},
loginSuccess (res) {
- this.$router.push({ name: 'dashboard' })
this.$message.loading('Login Successful. Discovering Features...', 5)
+ this.$router.push({ path: '/dashboard' }).catch(() => {})
},
requestFailed (err) {
if (err && err.response && err.response.data &&
err.response.data.loginresponse) {
[cloudstack-primate] branch master updated (8498821 -> 6927504)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git. from 8498821 store: remove set cookies on logout new f499f2e login: fix unhandled promise issue new 6927504 permission: fix cookie handling to allow saml to work The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: src/permission.js | 5 + src/store/modules/user.js | 22 +++--- src/views/auth/Login.vue | 2 +- 3 files changed, 17 insertions(+), 12 deletions(-)
[GitHub] [cloudstack] blueorangutan commented on issue #3884: kvm: fix exception in volume stats after storage migration
blueorangutan commented on issue #3884: kvm: fix exception in volume stats after storage migration URL: https://github.com/apache/cloudstack/pull/3884#issuecomment-587926175 Trillian test result (tid-1030) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 25326 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3884-t1030-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py Smoke tests completed. 76 look OK, 1 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_vpc_privategw_static_routes | `Failure` | 166.72 | test_privategw_acl.py test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 164.54 | test_privategw_acl.py test_04_rvpc_privategw_static_routes | `Failure` | 217.70 | test_privategw_acl.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3891: Upgrade script - vpc_offering_details add 'if not exist'
andrijapanicsb commented on issue #3891: Upgrade script - vpc_offering_details add 'if not exist' URL: https://github.com/apache/cloudstack/issues/3891#issuecomment-587894191 Please see my comment on the PR #3892 . Closing as non-issue. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] andrijapanicsb closed issue #3891: Upgrade script - vpc_offering_details add 'if not exist'
andrijapanicsb closed issue #3891: Upgrade script - vpc_offering_details add 'if not exist' URL: https://github.com/apache/cloudstack/issues/3891 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3892: Add if not exists constraint to create table on upgrade paths
andrijapanicsb commented on issue #3892: Add if not exists constraint to create table on upgrade paths URL: https://github.com/apache/cloudstack/pull/3892#issuecomment-587892895 To further explain myself - if you attempt the upgrade on top of DB which previously failed to be upgraded, you might end up with duplicate entries trying to be inserted and that would be chaos. The only "normal" way (acceptable in production) to proceed with the failed upgrade, is to start clean (drop DB, restore DB) and try again. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] andrijapanicsb closed pull request #3892: Add if not exists constraint to create table on upgrade paths
andrijapanicsb closed pull request #3892: Add if not exists constraint to create table on upgrade paths URL: https://github.com/apache/cloudstack/pull/3892 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3893: VR Health check errors seen in logs
andrijapanicsb commented on issue #3893: VR Health check errors seen in logs URL: https://github.com/apache/cloudstack/issues/3893#issuecomment-587887784 Sounds like FR36 related code... I didn't observe this during testing... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3891: Upgrade script - vpc_offering_details add 'if not exist'
andrijapanicsb commented on issue #3891: Upgrade script - vpc_offering_details add 'if not exist' URL: https://github.com/apache/cloudstack/issues/3891#issuecomment-587882777 Not an issue, but I would say an exectation that you can run upgrade again after the previous one failed. For DB consistency reasons, I vote this problem be closed (and voted -1 on the related PR) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] andrijapanicsb edited a comment on issue #3891: Upgrade script - vpc_offering_details add 'if not exist'
andrijapanicsb edited a comment on issue #3891: Upgrade script - vpc_offering_details add 'if not exist' URL: https://github.com/apache/cloudstack/issues/3891#issuecomment-587882777 Not an issue, but I would say an (untested, unpredicateble) expectation that you can run upgrade again after the previous one failed. For DB consistency reasons, I vote this problem be closed (and voted -1 on the related PR) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3892: Add if not exists constraint to create table on upgrade paths
andrijapanicsb commented on issue #3892: Add if not exists constraint to create table on upgrade paths URL: https://github.com/apache/cloudstack/pull/3892#issuecomment-587881492 wow what, why? -1 If there was previous failure on upgrade, bunch of other things will fail, like extending the existing table or such. I saw the issue which this PR is supposed to fix, and I vote for closing both. The correct action is failed upgrade --> roll back DB --> start again. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3770: UI: JOB does not complete when you create a template from snapshot
andrijapanicsb commented on issue #3770: UI: JOB does not complete when you create a template from snapshot URL: https://github.com/apache/cloudstack/issues/3770#issuecomment-587875434 This was fixed by some commit, not sure which. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack-primate] branch master updated: store: remove set cookies on logout
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git
The following commit(s) were added to refs/heads/master by this push:
new 8498821 store: remove set cookies on logout
8498821 is described below
commit 84988219d8a1c13cf86418519bb31e73d1e23ce4
Author: Rohit Yadav
AuthorDate: Wed Feb 19 01:31:19 2020 +0530
store: remove set cookies on logout
Signed-off-by: Rohit Yadav
---
src/store/modules/user.js | 10 ++
1 file changed, 10 insertions(+)
diff --git a/src/store/modules/user.js b/src/store/modules/user.js
index 0ff1dd8..be0e963 100644
--- a/src/store/modules/user.js
+++ b/src/store/modules/user.js
@@ -178,6 +178,16 @@ const user = {
Vue.ls.remove(ASYNC_JOB_IDS)
logout(state.token).then(() => {
+ Cookies.remove('account')
+ Cookies.remove('domainid')
+ Cookies.remove('role')
+ Cookies.remove('sessionkey')
+ Cookies.remove('timezone')
+ Cookies.remove('timezoneoffset')
+ Cookies.remove('userfullname')
+ Cookies.remove('userid')
+ Cookies.remove('username')
+
if (cloudianUrl) {
window.location.href = cloudianUrl
} else {
[cloudstack-primate] branch master updated: store: set cookie to allow old UI work with Primate
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git
The following commit(s) were added to refs/heads/master by this push:
new b83426a store: set cookie to allow old UI work with Primate
b83426a is described below
commit b83426afcbdcdf9a1f97850713b1bd42613ac810
Author: Rohit Yadav
AuthorDate: Wed Feb 19 01:15:32 2020 +0530
store: set cookie to allow old UI work with Primate
Signed-off-by: Rohit Yadav
---
src/store/modules/user.js | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/src/store/modules/user.js b/src/store/modules/user.js
index f65215e..0ff1dd8 100644
--- a/src/store/modules/user.js
+++ b/src/store/modules/user.js
@@ -15,6 +15,7 @@
// specific language governing permissions and limitations
// under the License.
+import Cookies from 'js-cookie'
import Vue from 'vue'
import md5 from 'md5'
import { login, logout, api } from '@/api'
@@ -82,7 +83,17 @@ const user = {
Login ({ commit }, userInfo) {
return new Promise((resolve, reject) => {
login(userInfo).then(response => {
- const result = response.loginresponse
+ const result = response.loginresponse || {}
+
+ Cookies.set('account', result.account)
+ Cookies.set('domainid', result.domainid)
+ Cookies.set('role', result.type)
+ Cookies.set('sessionkey', result.sessionkey)
+ Cookies.set('timezone', result.timezone)
+ Cookies.set('timezoneoffset', result.timezoneoffset)
+ Cookies.set('userfullname', result.firstname + ' ' + result.lastname)
+ Cookies.set('userid', result.userid)
+ Cookies.set('username', result.username)
Vue.ls.set(ACCESS_TOKEN, result.sessionkey, 60 * 60 * 1000)
commit('SET_TOKEN', result.sessionkey)
[GitHub] [cloudstack] blueorangutan commented on issue #3894: Fixed count value in the list apis
blueorangutan commented on issue #3894: Fixed count value in the list apis URL: https://github.com/apache/cloudstack/pull/3894#issuecomment-587721425 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-897 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3894: Fixed count value in the list apis
blueorangutan commented on issue #3894: Fixed count value in the list apis URL: https://github.com/apache/cloudstack/pull/3894#issuecomment-587697577 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3894: Fixed count value in the list apis
rhtyd commented on issue #3894: Fixed count value in the list apis URL: https://github.com/apache/cloudstack/pull/3894#issuecomment-587696333 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack-primate] branch master updated: config: list all routers and ilbvms including projects
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git
The following commit(s) were added to refs/heads/master by this push:
new afc3018 config: list all routers and ilbvms including projects
afc3018 is described below
commit afc3018d936feafaf4095dc78cf52db6e74112e1
Author: Rohit Yadav
AuthorDate: Wed Feb 19 00:51:02 2020 +0530
config: list all routers and ilbvms including projects
Signed-off-by: Rohit Yadav
---
src/config/section/infra/ilbvms.js | 1 +
src/config/section/infra/routers.js | 1 +
2 files changed, 2 insertions(+)
diff --git a/src/config/section/infra/ilbvms.js
b/src/config/section/infra/ilbvms.js
index df96dba..2cf7cb4 100644
--- a/src/config/section/infra/ilbvms.js
+++ b/src/config/section/infra/ilbvms.js
@@ -20,6 +20,7 @@ export default {
title: 'Internal LB VMs',
icon: 'share-alt',
permission: ['listInternalLoadBalancerVMs'],
+ params: { projectid: '-1' },
columns: ['name', 'state', 'publicip', 'guestnetworkname', 'vpcname',
'version', 'hostname', 'account', 'zonename', 'requiresupgrade'],
details: ['name', 'id', 'version', 'requiresupgrade', 'guestnetworkname',
'vpcname', 'publicip', 'guestipaddress', 'linklocalip', 'serviceofferingname',
'networkdomain', 'isredundantrouter', 'redundantstate', 'hostname', 'account',
'zonename', 'created'],
actions: [
diff --git a/src/config/section/infra/routers.js
b/src/config/section/infra/routers.js
index 4491693..d9ca32f 100644
--- a/src/config/section/infra/routers.js
+++ b/src/config/section/infra/routers.js
@@ -20,6 +20,7 @@ export default {
title: 'Virtual Routers',
icon: 'fork',
permission: ['listRouters'],
+ params: { projectid: '-1' },
columns: ['name', 'state', 'publicip', 'guestnetworkname', 'vpcname',
'redundantstate', 'version', 'hostname', 'account', 'zonename',
'requiresupgrade'],
details: ['name', 'id', 'version', 'requiresupgrade', 'guestnetworkname',
'vpcname', 'publicip', 'guestipaddress', 'linklocalip', 'serviceofferingname',
'networkdomain', 'isredundantrouter', 'redundantstate', 'hostname', 'account',
'zonename', 'created'],
actions: [
[GitHub] [cloudstack] rhtyd edited a comment on issue #3894: Fixed count value in the list apis
rhtyd edited a comment on issue #3894: Fixed count value in the list apis URL: https://github.com/apache/cloudstack/pull/3894#issuecomment-587486497 Test plan: cc @DaanHoogland @andrijapanicsb @borisstoyanov Verified on http://primate-qa.cloudstack.cloud:8080/client/master (this runs latest master + this PR) - [x] listVirtualMachinesMetrics - [x] listVolumesMetrics - [x] listHostsMetrics - [x] listStoragePoolsMetrics - [x] listZonesMetrics - [x] listClustersMetrics - [x] listClusters - [x] listAffinityGroups - [x] findHostsForMigration - [x] listServiceOfferings - [x] listDiskOfferings Alerts, ilbvm keys: - [x] listInfrastructure This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3894: Fixed count value in the list apis
blueorangutan commented on issue #3894: Fixed count value in the list apis URL: https://github.com/apache/cloudstack/pull/3894#issuecomment-587599266 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3894: Fixed count value in the list apis
rhtyd commented on issue #3894: Fixed count value in the list apis URL: https://github.com/apache/cloudstack/pull/3894#issuecomment-587598951 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3894: Fixed count value in the list apis
blueorangutan commented on issue #3894: Fixed count value in the list apis URL: https://github.com/apache/cloudstack/pull/3894#issuecomment-587586797 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-896 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3894: Fixed count value in the list apis
blueorangutan commented on issue #3894: Fixed count value in the list apis URL: https://github.com/apache/cloudstack/pull/3894#issuecomment-587578959 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3894: Fixed count value in the list apis
rhtyd commented on issue #3894: Fixed count value in the list apis URL: https://github.com/apache/cloudstack/pull/3894#issuecomment-587578599 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] GabrielBrascher commented on issue #3639: Multiple networks support for vms in advanced zone with security group (and kvm support)
GabrielBrascher commented on issue #3639: Multiple networks support for vms in advanced zone with security group (and kvm support) URL: https://github.com/apache/cloudstack/pull/3639#issuecomment-587565595 @andrijapanicsb got delayed with other tasks, just finishing to build it for a staging environment. I will be able to test it today. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3892: Add if not exists constraint to create table on upgrade paths
blueorangutan commented on issue #3892: Add if not exists constraint to create table on upgrade paths URL: https://github.com/apache/cloudstack/pull/3892#issuecomment-587563162 Trillian test result (tid-1029) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 28249 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3892-t1029-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermittent failure detected: /marvin/tests/smoke/test_templates.py Smoke tests completed. 78 look OK, 1 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_vpc_privategw_static_routes | `Failure` | 172.72 | test_privategw_acl.py test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 166.77 | test_privategw_acl.py test_04_rvpc_privategw_static_routes | `Failure` | 229.75 | test_privategw_acl.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3739: Add new command to update security group name
blueorangutan commented on issue #3739: Add new command to update security group name URL: https://github.com/apache/cloudstack/pull/3739#issuecomment-587560937 Trillian test result (tid-1027) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 28042 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3739-t1027-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py Smoke tests completed. 79 look OK, 1 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_vpc_privategw_static_routes | `Failure` | 172.91 | test_privategw_acl.py test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 170.93 | test_privategw_acl.py test_04_rvpc_privategw_static_routes | `Failure` | 232.08 | test_privategw_acl.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3491: KVM: Propagating changes on host parameters to the agents
blueorangutan commented on issue #3491: KVM: Propagating changes on host parameters to the agents URL: https://github.com/apache/cloudstack/pull/3491#issuecomment-587554278 Trillian test result (tid-1028) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 27248 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3491-t1028-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py Smoke tests completed. 78 look OK, 1 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_vpc_privategw_static_routes | `Failure` | 171.54 | test_privategw_acl.py test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 172.53 | test_privategw_acl.py test_04_rvpc_privategw_static_routes | `Failure` | 231.01 | test_privategw_acl.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on a change in pull request #3894: Fixed count value in the list apis
rhtyd commented on a change in pull request #3894: Fixed count value in the list apis URL: https://github.com/apache/cloudstack/pull/3894#discussion_r380780775 ## File path: server/src/main/java/com/cloud/server/ManagementServerImpl.java ## @@ -1515,6 +1515,89 @@ private boolean hasSuitablePoolsForVolume(final VolumeVO volume, final Host host return suitablePools; } + Review comment: @Pearl1594 curb adding newlines This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd edited a comment on issue #3894: Fixed count value in the list apis
rhtyd edited a comment on issue #3894: Fixed count value in the list apis URL: https://github.com/apache/cloudstack/pull/3894#issuecomment-587486497 Test plan: - [x] listVirtualMachinesMetrics - [x] listVolumesMetrics - [x] listHostsMetrics - [x] listStoragePoolsMetrics - [x] listZonesMetrics - [x] listClustersMetrics - [x] listClusters - [x] listAffinityGroups - [x] findHostsForMigration - [x] listServiceOfferings - [x] listDiskOfferings Alerts, ilbvm keys: - [x] listInfrastructure This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd edited a comment on issue #3894: Fixed count value in the list apis
rhtyd edited a comment on issue #3894: Fixed count value in the list apis URL: https://github.com/apache/cloudstack/pull/3894#issuecomment-587486497 Test plan: - [x] listVirtualMachinesMetrics - [x] listVolumesMetrics - [x] listHostsMetrics - [x] listStoragePoolsMetrics - [x] listZonesMetrics - [x] listClustersMetrics - [x] listClusters - [x] listAffinityGroups - [x] findHostsForMigration - [x] listServiceOfferings - [x] listDiskOfferings Alerts, ilbvm keys: - [ ] listInfrastructure This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd edited a comment on issue #3894: Fixed count value in the list apis
rhtyd edited a comment on issue #3894: Fixed count value in the list apis URL: https://github.com/apache/cloudstack/pull/3894#issuecomment-587486497 Test plan: - [x] listVirtualMachinesMetrics - [x] listVolumesMetrics - [ ] listHostsMetrics - [x] listStoragePoolsMetrics - [x] listZonesMetrics - [x] listClustersMetrics - [x] listClusters - [x] listAffinityGroups - [x] findHostsForMigration - [x] listServiceOfferings - [x] listDiskOfferings Alerts, ilbvm keys: - [ ] listInfrastructure This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd edited a comment on issue #3894: Fixed count value in the list apis
rhtyd edited a comment on issue #3894: Fixed count value in the list apis URL: https://github.com/apache/cloudstack/pull/3894#issuecomment-587486497 Test plan: - [x] listVirtualMachinesMetrics - [x] listVolumesMetrics - [ ] listHostsMetrics - [x] listStoragePoolsMetrics - [x] listZonesMetrics - [x] listClustersMetrics - [x] listClusters - [x] listAffinityGroups - [ ] findHostsForMigration - [x] listServiceOfferings - [x] listDiskOfferings Alerts, ilbvm keys: - [ ] listInfrastructure This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd edited a comment on issue #3894: Fixed count value in the list apis
rhtyd edited a comment on issue #3894: Fixed count value in the list apis URL: https://github.com/apache/cloudstack/pull/3894#issuecomment-587486497 Test plan: - [x] listVirtualMachinesMetrics - [x] listVolumesMetrics - [ ] listHostsMetrics - [x] listStoragePoolsMetrics - [x] listZonesMetrics - [x] listClustersMetrics - [x] listClusters - [x] listAffinityGroups - [ ] findHostsForMigration - [ ] listServiceOfferings - [ ] listDiskOfferings Alerts, ilbvm keys: - [ ] listInfrastructure This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd edited a comment on issue #3894: Fixed count value in the list apis
rhtyd edited a comment on issue #3894: Fixed count value in the list apis URL: https://github.com/apache/cloudstack/pull/3894#issuecomment-587486497 Test plan: - [x] listVirtualMachinesMetrics - [x] listVolumesMetrics - [ ] listHostsMetrics - [x] listStoragePoolsMetrics - [x] listZonesMetrics - [x] listClustersMetrics - [x] listClusters - [x] listAffinityGroups - [ ] findHostsForMigration - [x] listServiceOfferings - [ ] listDiskOfferings Alerts, ilbvm keys: - [ ] listInfrastructure This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd edited a comment on issue #3894: Fixed count value in the list apis
rhtyd edited a comment on issue #3894: Fixed count value in the list apis URL: https://github.com/apache/cloudstack/pull/3894#issuecomment-587486497 Test plan: - [x] listVirtualMachinesMetrics - [x] listVolumesMetrics - [ ] listHostsMetrics - [x] listStoragePoolsMetrics - [x] listZonesMetrics - [x] listClustersMetrics - [x] listClusters - [ ] listAffinityGroups - [ ] findHostsForMigration - [ ] listServiceOfferings - [ ] listDiskOfferings Alerts, ilbvm keys: - [ ] listInfrastructure This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd edited a comment on issue #3894: Fixed count value in the list apis
rhtyd edited a comment on issue #3894: Fixed count value in the list apis URL: https://github.com/apache/cloudstack/pull/3894#issuecomment-587486497 Test plan: - [x] listVirtualMachinesMetrics - [x] listVolumesMetrics - [ ] listHostsMetrics - [ ] listStoragePoolsMetrics - [ ] listZonesMetrics - [ ] listClustersMetrics - [ ] listClusters - [ ] listAffinityGroups - [ ] findHostsForMigration - [ ] listServiceOfferings - [ ] listDiskOfferings Alerts, ilbvm keys: - [ ] listInfrastructure This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd edited a comment on issue #3894: Fixed count value in the list apis
rhtyd edited a comment on issue #3894: Fixed count value in the list apis URL: https://github.com/apache/cloudstack/pull/3894#issuecomment-587486497 Test plan: - [x] listVirtualMachinesMetrics - [x] listVolumesMetrics - [ ] listHostsMetrics - [ ] listStoragePoolsMetrics - [x] listZonesMetrics - [x] listClustersMetrics - [ ] listClusters - [ ] listAffinityGroups - [ ] findHostsForMigration - [ ] listServiceOfferings - [ ] listDiskOfferings Alerts, ilbvm keys: - [ ] listInfrastructure This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd edited a comment on issue #3894: Fixed count value in the list apis
rhtyd edited a comment on issue #3894: Fixed count value in the list apis URL: https://github.com/apache/cloudstack/pull/3894#issuecomment-587486497 Test plan: - [x] listVirtualMachinesMetrics - [x] listVolumesMetrics - [ ] listHostsMetrics - [ ] listStoragePoolsMetrics - [x] listZonesMetrics - [x] listClustersMetrics - [x] listClusters - [ ] listAffinityGroups - [ ] findHostsForMigration - [ ] listServiceOfferings - [ ] listDiskOfferings Alerts, ilbvm keys: - [ ] listInfrastructure This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd edited a comment on issue #3894: Fixed count value in the list apis
rhtyd edited a comment on issue #3894: Fixed count value in the list apis URL: https://github.com/apache/cloudstack/pull/3894#issuecomment-587486497 Test plan: - [x] listVirtualMachinesMetrics - [x] listVolumesMetrics - [ ] listHostsMetrics - [ ] listStoragePoolsMetrics - [x] listZonesMetrics - [ ] listClustersMetrics - [ ] listClusters - [ ] listAffinityGroups - [ ] findHostsForMigration - [ ] listServiceOfferings - [ ] listDiskOfferings Alerts, ilbvm keys: - [ ] listInfrastructure This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd edited a comment on issue #3894: Fixed count value in the list apis
rhtyd edited a comment on issue #3894: Fixed count value in the list apis URL: https://github.com/apache/cloudstack/pull/3894#issuecomment-587486497 Test plan: - [x] listVirtualMachinesMetrics - [ ] listVolumesMetrics - [ ] listHostsMetrics - [ ] listStoragePoolsMetrics - [ ] listZonesMetrics - [ ] listClustersMetrics - [ ] listClusters - [ ] listAffinityGroups - [ ] findHostsForMigration - [ ] listServiceOfferings - [ ] listDiskOfferings Alerts, ilbvm keys: - [ ] listInfrastructure This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3894: Fixed count value in the list apis
blueorangutan commented on issue #3894: Fixed count value in the list apis URL: https://github.com/apache/cloudstack/pull/3894#issuecomment-587530444 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3894: Fixed count value in the list apis
rhtyd commented on issue #3894: Fixed count value in the list apis URL: https://github.com/apache/cloudstack/pull/3894#issuecomment-587530036 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] Pearl1594 commented on a change in pull request #3894: Fixed count value in the list apis
Pearl1594 commented on a change in pull request #3894: Fixed count value in the
list apis
URL: https://github.com/apache/cloudstack/pull/3894#discussion_r380727019
##
File path: server/src/main/java/com/cloud/server/ManagementServerImpl.java
##
@@ -1248,7 +1248,7 @@ private HypervisorType getHypervisorType(VMInstanceVO
vm, StoragePool srcVolumeP
final Map requiresStorageMotion = new HashMap();
DataCenterDeployment plan = null;
if (canMigrateWithStorage) {
-allHostsPair = searchForServers(startIndex, pageSize, null,
hostType, null, srcHost.getDataCenterId(), null, null, null, keyword, null,
null, srcHost.getHypervisorType(),
+allHostsPair = searchForServersExcluding(startIndex, pageSize,
null, hostType, null, srcHost.getDataCenterId(), null, null, srcHostId,
keyword, null, null, srcHost.getHypervisorType(),
srcHost.getHypervisorVersion());
allHosts = allHostsPair.first();
allHosts.remove(srcHost);
Review comment:
@weizhouapache True, however, it was noticed that, say if there were 15
hosts, with a default pagesize of 10, the 1st page (considering it contained
the src host) will have 9 objects returned and the 2nd page will have the
remaining 5, as opposed to the ideal behavior of the 1st page containing 10
items and the remaining 4 being listed on page 2.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] weizhouapache commented on a change in pull request #3894: Fixed count value in the list apis
weizhouapache commented on a change in pull request #3894: Fixed count value in
the list apis
URL: https://github.com/apache/cloudstack/pull/3894#discussion_r380717812
##
File path: server/src/main/java/com/cloud/server/ManagementServerImpl.java
##
@@ -1248,7 +1248,7 @@ private HypervisorType getHypervisorType(VMInstanceVO
vm, StoragePool srcVolumeP
final Map requiresStorageMotion = new HashMap();
DataCenterDeployment plan = null;
if (canMigrateWithStorage) {
-allHostsPair = searchForServers(startIndex, pageSize, null,
hostType, null, srcHost.getDataCenterId(), null, null, null, keyword, null,
null, srcHost.getHypervisorType(),
+allHostsPair = searchForServersExcluding(startIndex, pageSize,
null, hostType, null, srcHost.getDataCenterId(), null, null, srcHostId,
keyword, null, null, srcHost.getHypervisorType(),
srcHost.getHypervisorVersion());
allHosts = allHostsPair.first();
allHosts.remove(srcHost);
Review comment:
@Pearl1594 can you share why you add the method searchForServersExcluding ?
source host is removed in line
```
allHosts.remove(srcHost);
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3894: Fixed count value in the list apis
blueorangutan commented on issue #3894: Fixed count value in the list apis URL: https://github.com/apache/cloudstack/pull/3894#issuecomment-587493846 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-895 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3850: [HEALTH][master/4.14] Health Check Run
rhtyd commented on issue #3850: [HEALTH][master/4.14] Health Check Run URL: https://github.com/apache/cloudstack/pull/3850#issuecomment-587491673 @nvazquez can you address this? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3884: kvm: fix exception in volume stats after storage migration
rhtyd commented on issue #3884: kvm: fix exception in volume stats after storage migration URL: https://github.com/apache/cloudstack/pull/3884#issuecomment-587491253 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3884: kvm: fix exception in volume stats after storage migration
blueorangutan commented on issue #3884: kvm: fix exception in volume stats after storage migration URL: https://github.com/apache/cloudstack/pull/3884#issuecomment-587491460 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3894: Fixed count value in the list apis
rhtyd commented on issue #3894: Fixed count value in the list apis URL: https://github.com/apache/cloudstack/pull/3894#issuecomment-587486497 Test plan: - [ ] listVirtualMachinesMetrics - [ ] listVolumesMetrics - [ ] listHostsMetrics - [ ] listStoragePoolsMetrics - [ ] listZonesMetrics - [ ] listClustersMetrics - [ ] listClusters - [ ] listAffinityGroups - [ ] findHostsForMigration - [ ] listServiceOfferings - [ ] listDiskOfferings Alerts, ilbvm keys: - [ ] listInfrastructure This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3894: Fixed count value in the list apis
blueorangutan commented on issue #3894: Fixed count value in the list apis URL: https://github.com/apache/cloudstack/pull/3894#issuecomment-587485715 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3894: Fixed count value in the list apis
rhtyd commented on issue #3894: Fixed count value in the list apis URL: https://github.com/apache/cloudstack/pull/3894#issuecomment-587485251 I'll test against Primate @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on a change in pull request #3894: Fixed count value in the list apis
rhtyd commented on a change in pull request #3894: Fixed count value in the
list apis
URL: https://github.com/apache/cloudstack/pull/3894#discussion_r380702071
##
File path:
plugins/metrics/src/main/java/org/apache/cloudstack/metrics/MetricsServiceImpl.java
##
@@ -140,7 +145,9 @@ public InfrastructureResponse listInfrastructure() {
response.setStoragePools(storagePoolDao.listAll().size());
response.setImageStores(imageStoreDao.listImageStores().size());
response.setSystemvms(vmInstanceDao.listByTypes(VirtualMachine.Type.ConsoleProxy,
VirtualMachine.Type.SecondaryStorageVm).size());
-response.setRouters(domainRouterDao.listAll().size());
+
response.setRouters(domainRouterDao.listByRole(VirtualRouter.Role.VIRTUAL_ROUTER).size());
Review comment:
@Pearl1594 calling listAll() i.e. getting all the rows will make the APIs
slow in a large env; this is fine but can you explore a way to simply get the
count (instead of the rows).
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on a change in pull request #3894: Fixed count value in the list apis
rhtyd commented on a change in pull request #3894: Fixed count value in the
list apis
URL: https://github.com/apache/cloudstack/pull/3894#discussion_r380702333
##
File path:
plugins/metrics/src/main/java/org/apache/cloudstack/metrics/MetricsServiceImpl.java
##
@@ -140,7 +145,9 @@ public InfrastructureResponse listInfrastructure() {
response.setStoragePools(storagePoolDao.listAll().size());
response.setImageStores(imageStoreDao.listImageStores().size());
response.setSystemvms(vmInstanceDao.listByTypes(VirtualMachine.Type.ConsoleProxy,
VirtualMachine.Type.SecondaryStorageVm).size());
-response.setRouters(domainRouterDao.listAll().size());
+
response.setRouters(domainRouterDao.listByRole(VirtualRouter.Role.VIRTUAL_ROUTER).size());
+
response.setInternalLbs(domainRouterDao.listByRole(VirtualRouter.Role.INTERNAL_LB_VM).size());
+response.setAlerts(alertDao.listAll().size());
Review comment:
Same as above ^^ if it may be done quickly.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3862: Userdata to display static NAT as public ip instead of VR ip
blueorangutan commented on issue #3862: Userdata to display static NAT as public ip instead of VR ip URL: https://github.com/apache/cloudstack/pull/3862#issuecomment-587478587 Trillian test result (tid-1024) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 33752 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3862-t1024-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py Smoke tests completed. 77 look OK, 2 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_vpc_privategw_static_routes | `Failure` | 180.30 | test_privategw_acl.py test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 177.38 | test_privategw_acl.py test_04_rvpc_privategw_static_routes | `Failure` | 240.66 | test_privategw_acl.py test_hostha_kvm_host_degraded | `Error` | 672.07 | test_hostha_kvm.py test_hostha_kvm_host_fencing | `Error` | 665.49 | test_hostha_kvm.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3886: maven: configure toolchains based on ASF infra jdk names
DaanHoogland commented on issue #3886: maven: configure toolchains based on ASF infra jdk names URL: https://github.com/apache/cloudstack/pull/3886#issuecomment-587467726 @rhtyd I think we should tell infra that we are not going for their toolchains plugin (as it requires to many people and installations to adjust). Thoughts? btw I agree we should separate the jdk/qa tools issues. I was a bit optimistic, sorry This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] Pearl1594 opened a new pull request #3894: Fixed count value in the list apis
Pearl1594 opened a new pull request #3894: Fixed count value in the list apis URL: https://github.com/apache/cloudstack/pull/3894 ## Description The count value returned in the APIs responses is incorrect Addresses: https://github.com/apache/cloudstack/issues/3890 ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [X] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3847: VR: Fix Redundant VRouter guest network on wrong interface
blueorangutan commented on issue #3847: VR: Fix Redundant VRouter guest network on wrong interface URL: https://github.com/apache/cloudstack/pull/3847#issuecomment-587447824 Trillian test result (tid-1023) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 29355 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3847-t1023-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermittent failure detected: /marvin/tests/smoke/test_volumes.py Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py Smoke tests completed. 74 look OK, 3 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_vpc_privategw_static_routes | `Failure` | 170.25 | test_privategw_acl.py test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 171.97 | test_privategw_acl.py test_04_rvpc_privategw_static_routes | `Failure` | 229.55 | test_privategw_acl.py test_01_cancel_host_maintenace_with_no_migration_jobs | `Failure` | 0.10 | test_host_maintenance.py test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 2.43 | test_host_maintenance.py test_hostha_enable_ha_when_host_disabled | `Error` | 2.45 | test_hostha_kvm.py test_hostha_enable_ha_when_host_in_maintenance | `Error` | 303.54 | test_hostha_kvm.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nvazquez commented on issue #3850: [HEALTH][master/4.14] Health Check Run
nvazquez commented on issue #3850: [HEALTH][master/4.14] Health Check Run URL: https://github.com/apache/cloudstack/pull/3850#issuecomment-587410845 Hi @rhtyd looks like pvlan had intermittent failure where a network has not been properly cleaned up, as the error on `test_pvlan.py` was this: `CloudstackAPIException: Execute cmd: createnetwork failed, due to: errorCode: 431, errorText:The VLAN tag 1234 is already being used for dynamic vlan allocation for the guest network in zone pr3850-t980-vmware-65u2` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack-primate] branch master updated (ac9af88 -> db96d81)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git.
from ac9af88 infra: display full list of service providers in NSP tab
(#159)
add db96d81 plugin: add support for Cloudian (#163)
No new revisions were added by this update.
Summary of changes:
src/assets/icons/cloudian.svg | 87 ++
src/config/router.js | 6 +-
src/config/section/plugin.js | 36 -
.../section/plugin/cloudian.js}| 19 ++---
src/config/section/plugin/quota.js | 49
src/store/getters.js | 3 +-
src/store/modules/user.js | 25 ++-
src/views/plugins/CloudianPlugin.vue | 62 +++
8 files changed, 233 insertions(+), 54 deletions(-)
create mode 100644 src/assets/icons/cloudian.svg
delete mode 100644 src/config/section/plugin.js
copy src/{layouts/BlankLayout.vue => config/section/plugin/cloudian.js} (78%)
create mode 100644 src/config/section/plugin/quota.js
create mode 100644 src/views/plugins/CloudianPlugin.vue
[GitHub] [cloudstack] weizhouapache edited a comment on issue #3859: test_privategw_acl.py failed in some Trillian tests
weizhouapache edited a comment on issue #3859: test_privategw_acl.py failed in some Trillian tests URL: https://github.com/apache/cloudstack/issues/3859#issuecomment-587355882 > I think it is expected that vlan shouldn't be same? @rhtyd exactly. however in smoke test it creates two VPCs and private gateway with same vlan for each VPC, then test the connectivity between them. hence we have to add a new parameter bypassvlanoverlapcheck to private gateway so that the test can still go on. > @weizhouapache - should we fix this in the test or test's config instead? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] weizhouapache commented on issue #3859: test_privategw_acl.py failed in some Trillian tests
weizhouapache commented on issue #3859: test_privategw_acl.py failed in some Trillian tests URL: https://github.com/apache/cloudstack/issues/3859#issuecomment-587355882 > I think it is expected that vlan shouldn't be same? @rhtyd exactly. however in smoke test it creates two VPCs and private gateway with same vlan for each VPC, then test the connectivity between them. hence we have to add a new parameter bypassvlanoverlapcheck to private gateway so that the test can still go on. > @weizhouapache - should we fix this in the test or test's config instead? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3884: kvm: fix exception in volume stats after storage migration
blueorangutan commented on issue #3884: kvm: fix exception in volume stats after storage migration URL: https://github.com/apache/cloudstack/pull/3884#issuecomment-587348571 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-894 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch master updated (77fc102 -> 0c46dfa)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 77fc102 engine/schema: remove duplicate index region (#3882) add bbe2bf1 server: ignore site to site vpn status check on internallbvm (#3864) add 0c46dfa Merge remote-tracking branch 'origin/4.13' No new revisions were added by this update. Summary of changes: .../com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java | 4 1 file changed, 4 insertions(+)
[GitHub] [cloudstack] rhtyd commented on issue #3739: Add new command to update security group name
rhtyd commented on issue #3739: Add new command to update security group name URL: https://github.com/apache/cloudstack/pull/3739#issuecomment-587343698 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3491: KVM: Propagating changes on host parameters to the agents
blueorangutan commented on issue #3491: KVM: Propagating changes on host parameters to the agents URL: https://github.com/apache/cloudstack/pull/3491#issuecomment-587343772 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3739: Add new command to update security group name
blueorangutan commented on issue #3739: Add new command to update security group name URL: https://github.com/apache/cloudstack/pull/3739#issuecomment-587343757 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3491: KVM: Propagating changes on host parameters to the agents
rhtyd commented on issue #3491: KVM: Propagating changes on host parameters to the agents URL: https://github.com/apache/cloudstack/pull/3491#issuecomment-587343638 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch master updated (5a42862 -> 77fc102)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 5a42862 Merge remote-tracking branch 'origin/4.13' add 77fc102 engine/schema: remove duplicate index region (#3882) No new revisions were added by this update. Summary of changes: .../src/main/resources/META-INF/db/schema-41300to41400-cleanup.sql | 3 +++ 1 file changed, 3 insertions(+)
[GitHub] [cloudstack] rhtyd merged pull request #3882: remove duplicate index region
rhtyd merged pull request #3882: remove duplicate index region URL: https://github.com/apache/cloudstack/pull/3882 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3882: remove duplicate index region
rhtyd commented on issue #3882: remove duplicate index region URL: https://github.com/apache/cloudstack/pull/3882#issuecomment-587343444 Checked backend, we've some issues. Based on previous test run and Travis LGTM. Essentially this is a simple DB related fix, validated through Travis. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3884: kvm: fix exception in volume stats after storage migration
blueorangutan commented on issue #3884: kvm: fix exception in volume stats after storage migration URL: https://github.com/apache/cloudstack/pull/3884#issuecomment-587342720 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3884: kvm: fix exception in volume stats after storage migration
rhtyd commented on issue #3884: kvm: fix exception in volume stats after storage migration URL: https://github.com/apache/cloudstack/pull/3884#issuecomment-587342531 @skattoju3 can you review this? @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3859: test_privategw_acl.py failed in some Trillian tests
rhtyd commented on issue #3859: test_privategw_acl.py failed in some Trillian tests URL: https://github.com/apache/cloudstack/issues/3859#issuecomment-587341421 I think it is expected that vlan shouldn't be same? @weizhouapache - should we fix this in the test or test's config instead? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch 4.13 updated: server: ignore site to site vpn status check on internallbvm (#3864)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch 4.13
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/4.13 by this push:
new bbe2bf1 server: ignore site to site vpn status check on internallbvm
(#3864)
bbe2bf1 is described below
commit bbe2bf1a6ef6728132a92bb3b586795f068a403d
Author: Rakesh
AuthorDate: Tue Feb 18 09:33:30 2020 +0100
server: ignore site to site vpn status check on internallbvm (#3864)
When the state of the site to site vpn changes, the check
is done on all the virtual routers including the internal
load balancing vm as well. It is not needed to check the
state for internal load balancing vm
---
.../com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java | 4
1 file changed, 4 insertions(+)
diff --git
a/server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
b/server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
index 643ccbb..43069cb 100644
---
a/server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
+++
b/server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
@@ -840,6 +840,10 @@ Configurable, StateListener routers) {
for (final DomainRouterVO router : routers) {
+if (router.getRole() == Role.INTERNAL_LB_VM) {
+continue;
+}
+
final List conns =
_s2sVpnMgr.getConnectionsForRouter(router);
if (conns == null || conns.isEmpty()) {
continue;
[GitHub] [cloudstack] rhtyd merged pull request #3864: Ignore site to site vpn status check on internallbvm
rhtyd merged pull request #3864: Ignore site to site vpn status check on internallbvm URL: https://github.com/apache/cloudstack/pull/3864 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3864: Ignore site to site vpn status check on internallbvm
rhtyd commented on issue #3864: Ignore site to site vpn status check on internallbvm URL: https://github.com/apache/cloudstack/pull/3864#issuecomment-587340847 I checked some issue at the backend. Considering the test on https://github.com/apache/cloudstack/pull/3864#issuecomment-585653882 LGTM. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on a change in pull request #3888: jdk versions
rhtyd commented on a change in pull request #3888: jdk versions URL: https://github.com/apache/cloudstack/pull/3888#discussion_r380521027 ## File path: pom.xml ## @@ -51,7 +51,8 @@ UTF-8 -11 +14 Review comment: This would cause PR to be built against jdk14, given what got broken and fixed to make it work for jdk11 - moving to a newer jdk may be more work. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
