[GitHub] [cloudstack] weizhouapache commented on a change in pull request #3839: FEATURE-3823: kvm agent hooks

2020-03-10 Thread GitBox
weizhouapache commented on a change in pull request #3839: FEATURE-3823: kvm 
agent hooks
URL: https://github.com/apache/cloudstack/pull/3839#discussion_r390162557
 
 

 ##
 File path: .gitlab-ci.yml
 ##
 @@ -0,0 +1,46 @@
+# Licensed to the Apache Software Foundation (ASF) under one
 
 Review comment:
   @bwsw could you explain what this file is used for and how to use it ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3952: vrouter: remove a POSTROUTING rule for port forwarding in VPC router

2020-03-10 Thread GitBox
blueorangutan commented on issue #3952: vrouter: remove a POSTROUTING rule for 
port forwarding in VPC router
URL: https://github.com/apache/cloudstack/pull/3952#issuecomment-596971069
 
 
   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland commented on issue #3952: vrouter: remove a POSTROUTING rule for port forwarding in VPC router

2020-03-10 Thread GitBox
DaanHoogland commented on issue #3952: vrouter: remove a POSTROUTING rule for 
port forwarding in VPC router
URL: https://github.com/apache/cloudstack/pull/3952#issuecomment-596971016
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] weizhouapache commented on issue #1304: [CLOUDSTACK-9207] Test to verify restarting vpc network with cleanup does not delete the secondary ip address from VR

2020-03-10 Thread GitBox
weizhouapache commented on issue #1304: [CLOUDSTACK-9207] Test to verify 
restarting vpc network with cleanup does not delete the secondary ip address 
from VR
URL: https://github.com/apache/cloudstack/pull/1304#issuecomment-596975953
 
 
   @DaanHoogland I think this can be closed (not merged).
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland commented on issue #3950: Docker build fails in master

2020-03-10 Thread GitBox
DaanHoogland commented on issue #3950: Docker build fails in master
URL: https://github.com/apache/cloudstack/issues/3950#issuecomment-596980586
 
 
   @ravening I said try with that *reverted*, maybe it should be applied on 
4.13? or Wei's new chenges must go on 4.13 as well?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] borisstoyanov commented on issue #3932: Prevent overflow on StatsCollector.java

2020-03-10 Thread GitBox
borisstoyanov commented on issue #3932: Prevent overflow on StatsCollector.java
URL: https://github.com/apache/cloudstack/pull/3932#issuecomment-596982269
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland commented on issue #3955: docker: upgrade to ubuntu 18.04 and fix some issues

2020-03-10 Thread GitBox
DaanHoogland commented on issue #3955: docker: upgrade to ubuntu 18.04 and fix 
some issues
URL: https://github.com/apache/cloudstack/pull/3955#issuecomment-596982866
 
 
   @weizhouapache do we need this on 4.13 as well?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3932: Prevent overflow on StatsCollector.java

2020-03-10 Thread GitBox
blueorangutan commented on issue #3932: Prevent overflow on StatsCollector.java
URL: https://github.com/apache/cloudstack/pull/3932#issuecomment-596982525
 
 
   @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3952: vrouter: remove a POSTROUTING rule for port forwarding in VPC router

2020-03-10 Thread GitBox
DaanHoogland commented on a change in pull request #3952: vrouter: remove a 
POSTROUTING rule for port forwarding in VPC router
URL: https://github.com/apache/cloudstack/pull/3952#discussion_r390183744
 
 

 ##
 File path: systemvm/debian/opt/cloud/bin/configure.py
 ##
 @@ -918,15 +918,6 @@ def forward_vpc(self, rule):
 if not rule["internal_ports"] == "any":
 fw_prerout_rule += ":" + 
self.portsToString(rule["internal_ports"], "-")
 
-fw_postrout_rule = "-A POSTROUTING -d %s/32 " % rule["public_ip"]
 
 Review comment:
   pylint error: no longer defined but still used in 942


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3952: vrouter: remove a POSTROUTING rule for port forwarding in VPC router

2020-03-10 Thread GitBox
DaanHoogland commented on a change in pull request #3952: vrouter: remove a 
POSTROUTING rule for port forwarding in VPC router
URL: https://github.com/apache/cloudstack/pull/3952#discussion_r390183744
 
 

 ##
 File path: systemvm/debian/opt/cloud/bin/configure.py
 ##
 @@ -918,15 +918,6 @@ def forward_vpc(self, rule):
 if not rule["internal_ports"] == "any":
 fw_prerout_rule += ":" + 
self.portsToString(rule["internal_ports"], "-")
 
-fw_postrout_rule = "-A POSTROUTING -d %s/32 " % rule["public_ip"]
 
 Review comment:
   pylint error: no longer defined but still used in 942 (old line 951)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland closed pull request #1304: [CLOUDSTACK-9207] Test to verify restarting vpc network with cleanup does not delete the secondary ip address from VR

2020-03-10 Thread GitBox
DaanHoogland closed pull request #1304: [CLOUDSTACK-9207] Test to verify 
restarting vpc network with cleanup does not delete the secondary ip address 
from VR
URL: https://github.com/apache/cloudstack/pull/1304
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3932: Prevent overflow on StatsCollector.java

2020-03-10 Thread GitBox
blueorangutan commented on issue #3932: Prevent overflow on StatsCollector.java
URL: https://github.com/apache/cloudstack/pull/3932#issuecomment-596990921
 
 
   Packaging result: ✖centos6 ✔centos7 ✔debian. JID-1037


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3932: Prevent overflow on StatsCollector.java

2020-03-10 Thread GitBox
blueorangutan commented on issue #3932: Prevent overflow on StatsCollector.java
URL: https://github.com/apache/cloudstack/pull/3932#issuecomment-596991370
 
 
   @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] borisstoyanov commented on issue #3932: Prevent overflow on StatsCollector.java

2020-03-10 Thread GitBox
borisstoyanov commented on issue #3932: Prevent overflow on StatsCollector.java
URL: https://github.com/apache/cloudstack/pull/3932#issuecomment-596991315
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rvalle edited a comment on issue #3954: Cloudstack Management Improper shutdown

2020-03-10 Thread GitBox
rvalle edited a comment on issue #3954: Cloudstack Management Improper shutdown
URL: https://github.com/apache/cloudstack/issues/3954#issuecomment-596642236
 
 
   Exceptions during shutdown: https://pastebin.com/YWCJqEir
   Exceptions after restart: https://pastebin.com/RWRPCSd1


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rvalle commented on issue #3909: Cannot Add Host, wrong manager IP passed

2020-03-10 Thread GitBox
rvalle commented on issue #3909: Cannot Add Host, wrong manager IP passed
URL: https://github.com/apache/cloudstack/issues/3909#issuecomment-597005361
 
 
   I believe issue #3954 is getting in the way of my testing. Normally I reboot 
and reapply the roles to create the cluster again (indenpotency test) before 
concluding the setup of the cluster. I am going to disable it to properly check 
this.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland commented on issue #3954: Cloudstack Management Improper shutdown

2020-03-10 Thread GitBox
DaanHoogland commented on issue #3954: Cloudstack Management Improper shutdown
URL: https://github.com/apache/cloudstack/issues/3954#issuecomment-597019583
 
 
   @rvalle can you confirm this with 4.14 as well?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland opened a new pull request #3956: no default build phase for dep-check

2020-03-10 Thread GitBox
DaanHoogland opened a new pull request #3956: no default build phase for 
dep-check
URL: https://github.com/apache/cloudstack/pull/3956
 
 
   ## Description
   
   owasp dependency checker update.
   
   
   
   
   
   
   
   ## Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   
   
   
   
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] aleskxyz opened a new issue #3957: Root disk size reverts to its template size after rebuild

2020-03-10 Thread GitBox
aleskxyz opened a new issue #3957: Root disk size reverts to its template size 
after rebuild
URL: https://github.com/apache/cloudstack/issues/3957
 
 
   
   
   # ISSUE TYPE
   
* Bug Report
   
   # COMPONENT NAME
   
   ~~~
   Management Server
   ~~~
   
   # CLOUDSTACK VERSION
   
   
   ~~~
   4.13
   ~~~
   
   # CONFIGURATION
   
   CloudStack 4.13
   vSphere 6.5
   
   # OS / ENVIRONMENT
   
   
   
   # SUMMARY
   
   
   
   # STEPS TO REPRODUCE
   
   
   - resize root disk to larger size
   - rebuild vm
   - root disk size reverts to its original template size
   - CloudStack reports root disk size has not been reverted
   
   
   ~~~
   
   ~~~
   
   
   
   # EXPECTED RESULTS
   
   
   ~~~
   
   ~~~
   
   # ACTUAL RESULTS
   
   
   CloudStack resize root disk to larger size after rebuild
   
   
   ~~~
   
   ~~~
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] ravening commented on issue #3950: Docker build fails in master

2020-03-10 Thread GitBox
ravening commented on issue #3950: Docker build fails in master
URL: https://github.com/apache/cloudstack/issues/3950#issuecomment-597029902
 
 
   @weizhouapache yes the changes you mentioned works fine. 
   @DaanHoogland I didnt see this issue in 4.13 as its still using ubuntu 16 
and java 8


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] ravening commented on issue #3955: docker: upgrade to ubuntu 18.04 and fix some issues

2020-03-10 Thread GitBox
ravening commented on issue #3955: docker: upgrade to ubuntu 18.04 and fix some 
issues
URL: https://github.com/apache/cloudstack/pull/3955#issuecomment-597030147
 
 
   Tested it and works fine.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] weizhouapache commented on a change in pull request #3952: vrouter: remove a POSTROUTING rule for port forwarding in VPC router

2020-03-10 Thread GitBox
weizhouapache commented on a change in pull request #3952: vrouter: remove a 
POSTROUTING rule for port forwarding in VPC router
URL: https://github.com/apache/cloudstack/pull/3952#discussion_r390243851
 
 

 ##
 File path: systemvm/debian/opt/cloud/bin/configure.py
 ##
 @@ -918,15 +918,6 @@ def forward_vpc(self, rule):
 if not rule["internal_ports"] == "any":
 fw_prerout_rule += ":" + 
self.portsToString(rule["internal_ports"], "-")
 
-fw_postrout_rule = "-A POSTROUTING -d %s/32 " % rule["public_ip"]
 
 Review comment:
   should be fixed now


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] weizhouapache commented on issue #3955: docker: upgrade to ubuntu 18.04 and fix some issues

2020-03-10 Thread GitBox
weizhouapache commented on issue #3955: docker: upgrade to ubuntu 18.04 and fix 
some issues
URL: https://github.com/apache/cloudstack/pull/3955#issuecomment-597032738
 
 
   > @weizhouapache do we need this on 4.13 as well?
   
   @DaanHoogland no... in 4.13 we use openjdk 8 which is supported by ubuntu 
16.04


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland commented on issue #3955: docker: upgrade to ubuntu 18.04 and fix some issues

2020-03-10 Thread GitBox
DaanHoogland commented on issue #3955: docker: upgrade to ubuntu 18.04 and fix 
some issues
URL: https://github.com/apache/cloudstack/pull/3955#issuecomment-597036650
 
 
   👍 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rvalle commented on issue #3954: Cloudstack Management Improper shutdown

2020-03-10 Thread GitBox
rvalle commented on issue #3954: Cloudstack Management Improper shutdown
URL: https://github.com/apache/cloudstack/issues/3954#issuecomment-597037998
 
 
   @DaanHoogland should be feasible. are there packages in any centos repo? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rvalle edited a comment on issue #3954: Cloudstack Management Improper shutdown

2020-03-10 Thread GitBox
rvalle edited a comment on issue #3954: Cloudstack Management Improper shutdown
URL: https://github.com/apache/cloudstack/issues/3954#issuecomment-597037998
 
 
   @DaanHoogland should be feasible. are there packages in any centos repo? 
   
   I can see I have frozen my playbooks at 4.13. 
   
   Let me check with 4.14


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland commented on issue #3957: Root disk size reverts to its template size after rebuild

2020-03-10 Thread GitBox
DaanHoogland commented on issue #3957: Root disk size reverts to its template 
size after rebuild
URL: https://github.com/apache/cloudstack/issues/3957#issuecomment-597042761
 
 
   @aleskxyz what diskoffering did the VM have to begin with?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland edited a comment on issue #3950: Docker build fails in master

2020-03-10 Thread GitBox
DaanHoogland edited a comment on issue #3950: Docker build fails in master
URL: https://github.com/apache/cloudstack/issues/3950#issuecomment-596980586
 
 
   @ravening I said try with that *reverted*, maybe it should be applied on 
4.13? or Wei's new changes must go on 4.13 as well?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rvalle commented on issue #3954: Cloudstack Management Improper shutdown

2020-03-10 Thread GitBox
rvalle commented on issue #3954: Cloudstack Management Improper shutdown
URL: https://github.com/apache/cloudstack/issues/3954#issuecomment-597045964
 
 
   I cannot find 4.14 in the release repo. Is there a nightly build repo? If 
there is a repo I can run my tests easily. And could also check 4.11 LTS 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland commented on issue #3955: docker: upgrade to ubuntu 18.04 and fix some issues

2020-03-10 Thread GitBox
DaanHoogland commented on issue #3955: docker: upgrade to ubuntu 18.04 and fix 
some issues
URL: https://github.com/apache/cloudstack/pull/3955#issuecomment-597046405
 
 
   not sure what happened but travis is not at all happy as the DB is 
unreachable for root@localhost


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3952: vrouter: remove a POSTROUTING rule for port forwarding in VPC router

2020-03-10 Thread GitBox
blueorangutan commented on issue #3952: vrouter: remove a POSTROUTING rule for 
port forwarding in VPC router
URL: https://github.com/apache/cloudstack/pull/3952#issuecomment-597047126
 
 
   @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland commented on issue #3952: vrouter: remove a POSTROUTING rule for port forwarding in VPC router

2020-03-10 Thread GitBox
DaanHoogland commented on issue #3952: vrouter: remove a POSTROUTING rule for 
port forwarding in VPC router
URL: https://github.com/apache/cloudstack/pull/3952#issuecomment-597047056
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland commented on issue #3954: Cloudstack Management Improper shutdown

2020-03-10 Thread GitBox
DaanHoogland commented on issue #3954: Cloudstack Management Improper shutdown
URL: https://github.com/apache/cloudstack/issues/3954#issuecomment-597048475
 
 
   @rvalle 4.14 is not released and would be a snapshot of master. if you can't 
build yourself there are nightly builds around.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3952: vrouter: remove a POSTROUTING rule for port forwarding in VPC router

2020-03-10 Thread GitBox
blueorangutan commented on issue #3952: vrouter: remove a POSTROUTING rule for 
port forwarding in VPC router
URL: https://github.com/apache/cloudstack/pull/3952#issuecomment-597056882
 
 
   Packaging result: ✖centos6 ✔centos7 ✔debian. JID-1038


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3952: vrouter: remove a POSTROUTING rule for port forwarding in VPC router

2020-03-10 Thread GitBox
blueorangutan commented on issue #3952: vrouter: remove a POSTROUTING rule for 
port forwarding in VPC router
URL: https://github.com/apache/cloudstack/pull/3952#issuecomment-597061992
 
 
   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland commented on issue #3952: vrouter: remove a POSTROUTING rule for port forwarding in VPC router

2020-03-10 Thread GitBox
DaanHoogland commented on issue #3952: vrouter: remove a POSTROUTING rule for 
port forwarding in VPC router
URL: https://github.com/apache/cloudstack/pull/3952#issuecomment-597061939
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] aleskxyz commented on issue #3957: Root disk size reverts to its template size after rebuild

2020-03-10 Thread GitBox
aleskxyz commented on issue #3957: Root disk size reverts to its template size 
after rebuild
URL: https://github.com/apache/cloudstack/issues/3957#issuecomment-597067542
 
 
   > @aleskxyz what diskoffering did the VM have to begin with?
I have create VM from a template which its root disk is created from a 
dynamic disk offering.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] aleskxyz commented on issue #3957: Root disk size reverts to its template size after rebuild

2020-03-10 Thread GitBox
aleskxyz commented on issue #3957: Root disk size reverts to its template size 
after rebuild
URL: https://github.com/apache/cloudstack/issues/3957#issuecomment-597077559
 
 
   More investigation results:
   
   **Scenario 1:**
   1. Create a VM with root disk same as template
   2. Upgrade root disk
   3. Rebuild VM
   Result: root disk size reverts to template size
   
   **Scenario 2:**
   1. Create a VM with increased root disk size
   2. Rebuild VM
   Result: root disk size is ok
   
   **Scenario 3:**
   1. Create a VM with increased root disk size
   2. Upgrade root disk
   3. Rebuild VM
   Result: root disk size is ok


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] div8cn opened a new issue #3958: Volume migration across pools sometimes loses volume

2020-03-10 Thread GitBox
div8cn opened a new issue #3958: Volume migration across pools sometimes loses 
volume
URL: https://github.com/apache/cloudstack/issues/3958
 
 
   
   
   # ISSUE TYPE
   
* Bug Report
   # COMPONENT NAME
   
   
   # CLOUDSTACK VERSION
   
   
   ~~~
   4.11.*
   4.13.0
   ~~~
   
   # CONFIGURATION
   
   
   
   # OS / ENVIRONMENT
   
   
   
   # SUMMARY
   
   When migrating between volumes across primary storage, if the zone's 
secondary storage has made the capacity> 90%, migration will fail. It also 
deletes VOLUME on the source primary storage.
   
   In this case the data is lost ...
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] GabrielBrascher commented on issue #3681: Validate disk offering IOPS normal and maximum read/write values

2020-03-10 Thread GitBox
GabrielBrascher commented on issue #3681: Validate disk offering IOPS normal 
and maximum read/write values
URL: https://github.com/apache/cloudstack/pull/3681#issuecomment-597114256
 
 
   Hi @borisstoyanov , thanks for testing this PR. The global settings affect 
the following disk offering parameters:
   
   ```
   bytesreadratemaxlength
   byteswriteratemaxlength
   iopsreadratemaxlength
   iopswriteratemaxlength
   
   ```
   The setup on global settings are according to the following parameters:
   ```
   vm.disk.bytes.maximum.read.length = 0
   vm.disk.bytes.maximum.write.length = 0
   vm.disk.iops.maximum.read.length = 0
   vm.disk.iops.maximum.write.length = 0
   
   ```
   
   Quick resume on the length parameters. The verifications ensure that either 
Bytes or IOPS bursts cannot be greater than a configured value of those global 
settings variables.
   
   Additionally, this PR checks the normal IOPS (write/read) ensuring that it 
cannot be higher than the respective maximum value (if the maximum has been set 
by the operator, otherwise, if null, it ignores the maximum).
   
   Example of all parameters necessary to check if length (e.g. 
bytesreadratemaxlength) and normal (e.g. bytesreadrate) vs maximum 
(bytesreadratemax) are OK:
   
   - Bytes (read / right)
   ```
   bytesreadrate, bytesreadratemax, bytesreadratemaxlength
   byteswriterate, byteswriteratemax, byteswriteratemaxlength
   ```
   
   - IOPS (read / right)
   ```
   iopsreadrate, iopsreadratemax, iopsreadratemaxlength
   iopswriterate, iopswriteratemax, iopswriteratemaxlength
   ```
   
   Therefore, the test that you presented should indeed accept the deploy as 
you have done (no length neither maximum IOPS/bytes have been configured via 
the disk offering command).
   
   Once again, thanks for checking this PR, in case of any question just ping 
me.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] aleskxyz commented on issue #3957: Root disk size reverts to its template size after rebuild

2020-03-10 Thread GitBox
aleskxyz commented on issue #3957: Root disk size reverts to its template size 
after rebuild
URL: https://github.com/apache/cloudstack/issues/3957#issuecomment-597128458
 
 
   **Workaround:**
   It seems that when you increase root disk size at deployment, CloudStack 
initializes "rootdisksize" as a variable in "details" list with the size of 
root disk.
   When you request for rebuild, CloudStack looks for "rootdisksize" 
_regardless of its value_, and recreates root disk according to its latest size.
   So this scenario is a workaround to this bug:
   
   1. Create a VM with root disk same as template
   2. Upgrade root disk
   3. Call "updateVirtualMachine" by adding "rootdisksize=0" to "details" list.
   4. Rebuild VM
   Result: root disk size is ok


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] GabrielBrascher opened a new pull request #3681: Validate disk offering IOPS normal and maximum read/write values

2020-03-10 Thread GitBox
GabrielBrascher opened a new pull request #3681: Validate disk offering IOPS 
normal and maximum read/write values
URL: https://github.com/apache/cloudstack/pull/3681
 
 
   ## Description
   
   When creating a new disk offering ('createDiskOffering' command on API) one 
can set _normal_ IOPS (write/read) higher than the maximum, breaking the logics 
on the disk offerings. Additionally, one can (by mistake) put irrealistic 
values for the bursting length. Example if adding few zeros by mistake and 
configuring **36** seconds, which turns out to be a bursting length of 
**100** hours.
   
   This PR adds verifications ensuring that either Bytes or IOPS bursts cannot 
be greater than a configured value of the following global settings variables.
   
   ```
   vm.disk.bytes.maximum.read.length
   vm.disk.bytes.maximum.write.length
   vm.disk.iops.maximum.read.length
   vm.disk.iops.maximum.write.length
   ```
   
   The default value is 0 (zero), allows any IOPS maximum rate length; thus 
keeping backward compatibility and not affecting any environment configuration 
after upgrades.
   
   # Example:
   One can set the 'vm.disk.bytes.maximum.read.length' to '3600' (seconds); 
once the parameter is updated on the management server it will not be possible 
to create disk offerings with IOPS length higher than 3600 seconds (60 minutes).
   
   ## Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [X] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)g


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland closed pull request #3681: Validate disk offering IOPS normal and maximum read/write values

2020-03-10 Thread GitBox
DaanHoogland closed pull request #3681: Validate disk offering IOPS normal and 
maximum read/write values
URL: https://github.com/apache/cloudstack/pull/3681
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland commented on issue #3274: Service offerings too small

2020-03-10 Thread GitBox
DaanHoogland commented on issue #3274: Service offerings too small
URL: https://github.com/apache/cloudstack/issues/3274#issuecomment-597131461
 
 
   @NuxRo @rhtyd is this still an issue?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland closed pull request #3563: Limit API from trying to start a VM that is already running

2020-03-10 Thread GitBox
DaanHoogland closed pull request #3563: Limit API from trying to start a VM 
that is already running
URL: https://github.com/apache/cloudstack/pull/3563
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] kioie opened a new pull request #3563: Limit API from trying to start a VM that is already running

2020-03-10 Thread GitBox
kioie opened a new pull request #3563: Limit API from trying to start a VM that 
is already running
URL: https://github.com/apache/cloudstack/pull/3563
 
 
   ## Description
   
   Enhancement for issue #2736
   
   
   
   
   
   
   
   ## Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   ![Screen Shot 2019-08-17 at 4 51 26 
PM](https://user-images.githubusercontent.com/20902920/63212627-266fa800-c110-11e9-9e55-cb09973b211e.png)
   
   ## How Has This Been Tested?
   
   
   
   
   1. Start a VM
   2. With cloudmonkey, start the same VM
   3. Observe the result
   Response should fail the job and say VM is already in running state. 
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] div8cn opened a new pull request #3959: fix Volume migration across pools sometimes loses volume

2020-03-10 Thread GitBox
div8cn opened a new pull request #3959: fix Volume migration across pools 
sometimes loses volume
URL: https://github.com/apache/cloudstack/pull/3959
 
 
   ## Description
   
   When secondary storage usage is> 90%, VOLUME migration across primary 
storage will cause the migration to fail and lose VOLUME
   
   
   
   
   
   3958
   
   
   ## Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   
   
   
   
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland commented on issue #2801: Prometheus integration: requiring allowed ips is too restrictive

2020-03-10 Thread GitBox
DaanHoogland commented on issue #2801: Prometheus integration: requiring 
allowed ips is too restrictive
URL: https://github.com/apache/cloudstack/issues/2801#issuecomment-597138550
 
 
   @csquire @rhtyd @robisonjoel anybody planning to work on this? If we won't 
fix let's close it


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland commented on issue #3040: Broadcast URI not set to vxlan, but vlan

2020-03-10 Thread GitBox
DaanHoogland commented on issue #3040: Broadcast URI not set to vxlan, but vlan
URL: https://github.com/apache/cloudstack/issues/3040#issuecomment-597143019
 
 
   @wido is this still an issue and is work on this underway? or can we close?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland commented on issue #3957: Root disk size reverts to its template size after rebuild

2020-03-10 Thread GitBox
DaanHoogland commented on issue #3957: Root disk size reverts to its template 
size after rebuild
URL: https://github.com/apache/cloudstack/issues/3957#issuecomment-597151464
 
 
   Sounds like this can be done by :
   
   1. Create a VM with root disk same as template
   2. (under the hood) Call "updateVirtualMachine" by adding "rootdisksize=0" 
to "details" list.
   3. Upgrade root disk
   4. Rebuild VM
  Result: root disk size should be ok
   
   are you planning to fix this @aleskxyz ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3959: fix Volume migration across pools sometimes loses volume

2020-03-10 Thread GitBox
DaanHoogland commented on a change in pull request #3959: fix Volume migration 
across pools sometimes loses volume
URL: https://github.com/apache/cloudstack/pull/3959#discussion_r390407552
 
 

 ##
 File path: 
engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/AncientDataMotionStrategy.java
 ##
 @@ -486,6 +486,9 @@ public void copyAsync(DataObject srcData, DataObject 
destData, Host destHost, As
 if (answer != null && !answer.getResult()) {
 errMsg = answer.getDetails();
 }
+if (answer == null) {
+errMsg = "answer is null, set to error for CopyCommandResult";
 
 Review comment:
   I don't understand this error message. Can you make it very clear, please?
   for example "no answer from came back from copyCommand, considering it as 
failed."
   preferably even with some data like src, dest, src.type and dest.type


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rvalle commented on issue #3909: Cannot Add Host, wrong manager IP passed

2020-03-10 Thread GitBox
rvalle commented on issue #3909: Cannot Add Host, wrong manager IP passed
URL: https://github.com/apache/cloudstack/issues/3909#issuecomment-597153814
 
 
   @DaanHoogland  yes, confirmed. It was #3954 that got my manager broken 
before attempting to change the **host** and **management.network.cidr** global 
values.
   
   Re-tested without peforming any reboot as part of the clustiner installation 
process and changed this paramenters with no problem. The management server 
starts, with the new paramenters, there is only one all seems OK to me.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rvalle closed issue #3909: Cannot Add Host, wrong manager IP passed

2020-03-10 Thread GitBox
rvalle closed issue #3909: Cannot Add Host, wrong manager IP passed
URL: https://github.com/apache/cloudstack/issues/3909
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rvalle commented on issue #3954: Cloudstack Management Improper shutdown

2020-03-10 Thread GitBox
rvalle commented on issue #3954: Cloudstack Management Improper shutdown
URL: https://github.com/apache/cloudstack/issues/3954#issuecomment-597159192
 
 
   @DaanHoogland I am currently migrating/extending an ansible collection of 
roles to manage my cloud form opennebula to cloudstack. The interesting thing 
is that I did setup a cloud Continuous Integration infrastructure. On every 
push a 3 node cloudstack cluster is created and tested .

   Let me advance a little bit more on this front and I would be happy to 
integrate this CI with a Nightly Builds or Travis that generates packages that 
I can take. We can discuss.
   
   ![Screenshot_2020-03-10 Pipeline · privazio 
ansible-collection-vdc](https://user-images.githubusercontent.com/412837/76330715-7c937b00-62ee-11ea-97cd-6b52146ac9c7.png)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland commented on issue #3563: Limit API from trying to start a VM that is already running

2020-03-10 Thread GitBox
DaanHoogland commented on issue #3563: Limit API from trying to start a VM that 
is already running
URL: https://github.com/apache/cloudstack/pull/3563#issuecomment-597168490
 
 
   Not sure if those are all, but `import *` are not accepted at least, @kioie .


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] GabrielBrascher commented on issue #3649: Garbage snapshots are left on Primary and Secondary

2020-03-10 Thread GitBox
GabrielBrascher commented on issue #3649: Garbage snapshots are left on Primary 
and Secondary
URL: https://github.com/apache/cloudstack/pull/3649#issuecomment-597170533
 
 
   @DaanHoogland I am working on it, the fix that I am implementing is working 
for KVM + NFS (primary) It still needs more testing (not yet updated here the 
fix). I am also Implementing now the KVM +NFS (secondary) snapshot deletion.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] weizhouapache commented on issue #3955: docker: upgrade to ubuntu 18.04 and fix some issues

2020-03-10 Thread GitBox
weizhouapache commented on issue #3955: docker: upgrade to ubuntu 18.04 and fix 
some issues
URL: https://github.com/apache/cloudstack/pull/3955#issuecomment-597180765
 
 
   travis test still failed. I will have a look when I have time.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] aleskxyz commented on issue #3957: Root disk size reverts to its template size after rebuild

2020-03-10 Thread GitBox
aleskxyz commented on issue #3957: Root disk size reverts to its template size 
after rebuild
URL: https://github.com/apache/cloudstack/issues/3957#issuecomment-597180718
 
 
   > Sounds like this can be done by :
   > 
   > 1. Create a VM with root disk same as template
   > 2. (under the hood) Call "updateVirtualMachine" by adding "rootdisksize=0" 
to "details" list.
   > 3. Upgrade root disk
   > 4. Rebuild VM
   >Result: root disk size should be ok
   > 
   > are you planning to fix this @aleskxyz ?
   
   @DaanHoogland 
   I really want to contribute on CS code but unfortunately I'm not a developer 
:(



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd commented on issue #1371: OSPF: adding dynamically routing capability to VPC

2020-03-10 Thread GitBox
rhtyd commented on issue #1371: OSPF: adding dynamically routing capability to 
VPC 
URL: https://github.com/apache/cloudstack/pull/1371#issuecomment-597212569
 
 
   Hold-on, maybe useful in future when we want to allow route-able networks 
with bgp/ospf.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] wido commented on issue #3040: Broadcast URI not set to vxlan, but vlan

2020-03-10 Thread GitBox
wido commented on issue #3040: Broadcast URI not set to vxlan, but vlan
URL: https://github.com/apache/cloudstack/issues/3040#issuecomment-597219136
 
 
   This issue is still relevant. At the moment there has been no work on this I 
think.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland commented on issue #3957: Root disk size reverts to its template size after rebuild

2020-03-10 Thread GitBox
DaanHoogland commented on issue #3957: Root disk size reverts to its template 
size after rebuild
URL: https://github.com/apache/cloudstack/issues/3957#issuecomment-597219042
 
 
   ok @aleskxyz , unfortunately that means there is no guarantee it will 
actually be implemented. I will if i find the time but make no promises


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3952: vrouter: remove a POSTROUTING rule for port forwarding in VPC router

2020-03-10 Thread GitBox
blueorangutan commented on issue #3952: vrouter: remove a POSTROUTING rule for 
port forwarding in VPC router
URL: https://github.com/apache/cloudstack/pull/3952#issuecomment-597232200
 
 
   Trillian test result (tid-1224)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 31879 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3952-t1224-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_routers_iptables_default_policy.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Smoke tests completed. 77 look OK, 6 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Error` | 169.23 | 
test_internal_lb.py
   test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Error` | 199.77 | 
test_internal_lb.py
   test_03_vpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 77.69 | 
test_internal_lb.py
   test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 102.11 | 
test_internal_lb.py
   test_02_vpc_privategw_static_routes | `Error` | 167.40 | 
test_privategw_acl.py
   test_03_vpc_privategw_restart_vpc_cleanup | `Error` | 153.96 | 
test_privategw_acl.py
   test_04_rvpc_privategw_static_routes | `Error` | 291.48 | 
test_privategw_acl.py
   test_01_single_VPC_iptables_policies | `Error` | 117.03 | 
test_routers_iptables_default_policy.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Error` | 258.67 | 
test_vpc_redundant.py
   test_02_redundant_VPC_default_routes | `Error` | 253.00 | 
test_vpc_redundant.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
`Error` | 167.29 | test_vpc_redundant.py
   test_04_rvpc_network_garbage_collector_nics | `Error` | 124.70 | 
test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Error` | 208.96 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Error` | 236.31 | test_vpc_redundant.py
   test_01_VPC_nics_after_destroy | `Error` | 127.49 | test_vpc_router_nics.py
   test_02_VPC_default_routes | `Error` | 116.01 | test_vpc_router_nics.py
   test_01_redundant_vpc_site2site_vpn | `Failure` | 269.21 | test_vpc_vpn.py
   test_01_vpc_site2site_vpn_multiple_options | `Failure` | 142.69 | 
test_vpc_vpn.py
   test_01_vpc_site2site_vpn | `Failure` | 166.50 | test_vpc_vpn.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3932: Prevent overflow on StatsCollector.java

2020-03-10 Thread GitBox
blueorangutan commented on issue #3932: Prevent overflow on StatsCollector.java
URL: https://github.com/apache/cloudstack/pull/3932#issuecomment-597270185
 
 
   Trillian test result (tid-1225)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 33837 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3932-t1225-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Smoke tests completed. 76 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_vpc_privategw_static_routes | `Failure` | 219.74 | 
test_privategw_acl.py
   test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 210.20 | 
test_privategw_acl.py
   test_04_rvpc_privategw_static_routes | `Failure` | 942.54 | 
test_privategw_acl.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] NuxRo commented on issue #3274: Service offerings too small

2020-03-10 Thread GitBox
NuxRo commented on issue #3274: Service offerings too small
URL: https://github.com/apache/cloudstack/issues/3274#issuecomment-597356040
 
 
   Since we mess up backwards compatibility, I guess this is not an "issue" and 
will need to be worked around some other way.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] NuxRo closed issue #3274: Service offerings too small

2020-03-10 Thread GitBox
NuxRo closed issue #3274: Service offerings too small
URL: https://github.com/apache/cloudstack/issues/3274
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3952: vrouter: remove a POSTROUTING rule for port forwarding in VPC router

2020-03-10 Thread GitBox
blueorangutan commented on issue #3952: vrouter: remove a POSTROUTING rule for 
port forwarding in VPC router
URL: https://github.com/apache/cloudstack/pull/3952#issuecomment-597359780
 
 
   Trillian test result (tid-1226)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 35843 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3952-t1226-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Smoke tests completed. 82 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_vpc_privategw_static_routes | `Failure` | 215.00 | 
test_privategw_acl.py
   test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 202.71 | 
test_privategw_acl.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland commented on issue #3952: vrouter: remove a POSTROUTING rule for port forwarding in VPC router

2020-03-10 Thread GitBox
DaanHoogland commented on issue #3952: vrouter: remove a POSTROUTING rule for 
port forwarding in VPC router
URL: https://github.com/apache/cloudstack/pull/3952#issuecomment-597375802
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3952: vrouter: remove a POSTROUTING rule for port forwarding in VPC router

2020-03-10 Thread GitBox
blueorangutan commented on issue #3952: vrouter: remove a POSTROUTING rule for 
port forwarding in VPC router
URL: https://github.com/apache/cloudstack/pull/3952#issuecomment-597375898
 
 
   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland removed a comment on issue #3952: vrouter: remove a POSTROUTING rule for port forwarding in VPC router

2020-03-10 Thread GitBox
DaanHoogland removed a comment on issue #3952: vrouter: remove a POSTROUTING 
rule for port forwarding in VPC router
URL: https://github.com/apache/cloudstack/pull/3952#issuecomment-596607462
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan removed a comment on issue #3952: vrouter: remove a POSTROUTING rule for port forwarding in VPC router

2020-03-10 Thread GitBox
blueorangutan removed a comment on issue #3952: vrouter: remove a POSTROUTING 
rule for port forwarding in VPC router
URL: https://github.com/apache/cloudstack/pull/3952#issuecomment-596971069
 
 
   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan removed a comment on issue #3952: vrouter: remove a POSTROUTING rule for port forwarding in VPC router

2020-03-10 Thread GitBox
blueorangutan removed a comment on issue #3952: vrouter: remove a POSTROUTING 
rule for port forwarding in VPC router
URL: https://github.com/apache/cloudstack/pull/3952#issuecomment-596607737
 
 
   @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan removed a comment on issue #3952: vrouter: remove a POSTROUTING rule for port forwarding in VPC router

2020-03-10 Thread GitBox
blueorangutan removed a comment on issue #3952: vrouter: remove a POSTROUTING 
rule for port forwarding in VPC router
URL: https://github.com/apache/cloudstack/pull/3952#issuecomment-596622736
 
 
   Packaging result: ✖centos6 ✔centos7 ✔debian. JID-1036


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland removed a comment on issue #3952: vrouter: remove a POSTROUTING rule for port forwarding in VPC router

2020-03-10 Thread GitBox
DaanHoogland removed a comment on issue #3952: vrouter: remove a POSTROUTING 
rule for port forwarding in VPC router
URL: https://github.com/apache/cloudstack/pull/3952#issuecomment-596971016
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan removed a comment on issue #3952: vrouter: remove a POSTROUTING rule for port forwarding in VPC router

2020-03-10 Thread GitBox
blueorangutan removed a comment on issue #3952: vrouter: remove a POSTROUTING 
rule for port forwarding in VPC router
URL: https://github.com/apache/cloudstack/pull/3952#issuecomment-597359780
 
 
   Trillian test result (tid-1226)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 35843 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3952-t1226-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Smoke tests completed. 82 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_vpc_privategw_static_routes | `Failure` | 215.00 | 
test_privategw_acl.py
   test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 202.71 | 
test_privategw_acl.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland removed a comment on issue #3952: vrouter: remove a POSTROUTING rule for port forwarding in VPC router

2020-03-10 Thread GitBox
DaanHoogland removed a comment on issue #3952: vrouter: remove a POSTROUTING 
rule for port forwarding in VPC router
URL: https://github.com/apache/cloudstack/pull/3952#issuecomment-597061939
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan removed a comment on issue #3952: vrouter: remove a POSTROUTING rule for port forwarding in VPC router

2020-03-10 Thread GitBox
blueorangutan removed a comment on issue #3952: vrouter: remove a POSTROUTING 
rule for port forwarding in VPC router
URL: https://github.com/apache/cloudstack/pull/3952#issuecomment-597061992
 
 
   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan removed a comment on issue #3952: vrouter: remove a POSTROUTING rule for port forwarding in VPC router

2020-03-10 Thread GitBox
blueorangutan removed a comment on issue #3952: vrouter: remove a POSTROUTING 
rule for port forwarding in VPC router
URL: https://github.com/apache/cloudstack/pull/3952#issuecomment-597232200
 
 
   Trillian test result (tid-1224)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 31879 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3952-t1224-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_routers_iptables_default_policy.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Smoke tests completed. 77 look OK, 6 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Error` | 169.23 | 
test_internal_lb.py
   test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Error` | 199.77 | 
test_internal_lb.py
   test_03_vpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 77.69 | 
test_internal_lb.py
   test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 102.11 | 
test_internal_lb.py
   test_02_vpc_privategw_static_routes | `Error` | 167.40 | 
test_privategw_acl.py
   test_03_vpc_privategw_restart_vpc_cleanup | `Error` | 153.96 | 
test_privategw_acl.py
   test_04_rvpc_privategw_static_routes | `Error` | 291.48 | 
test_privategw_acl.py
   test_01_single_VPC_iptables_policies | `Error` | 117.03 | 
test_routers_iptables_default_policy.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Error` | 258.67 | 
test_vpc_redundant.py
   test_02_redundant_VPC_default_routes | `Error` | 253.00 | 
test_vpc_redundant.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
`Error` | 167.29 | test_vpc_redundant.py
   test_04_rvpc_network_garbage_collector_nics | `Error` | 124.70 | 
test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Error` | 208.96 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Error` | 236.31 | test_vpc_redundant.py
   test_01_VPC_nics_after_destroy | `Error` | 127.49 | test_vpc_router_nics.py
   test_02_VPC_default_routes | `Error` | 116.01 | test_vpc_router_nics.py
   test_01_redundant_vpc_site2site_vpn | `Failure` | 269.21 | test_vpc_vpn.py
   test_01_vpc_site2site_vpn_multiple_options | `Failure` | 142.69 | 
test_vpc_vpn.py
   test_01_vpc_site2site_vpn | `Failure` | 166.50 | test_vpc_vpn.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] aleskxyz commented on issue #3957: Root disk size reverts to its template size after rebuild

2020-03-10 Thread GitBox
aleskxyz commented on issue #3957: Root disk size reverts to its template size 
after rebuild
URL: https://github.com/apache/cloudstack/issues/3957#issuecomment-597381823
 
 
   **Better workaround:**
   Based on [this line of 
code](https://github.com/apache/cloudstack/blob/4.13.0.0/server/src/main/java/com/cloud/vm/UserVmManagerImpl.java#L3841)
 we can abuse (?!) template details and inject "rootdisksize" in vm details:
   
   
![image](https://user-images.githubusercontent.com/39186039/76369575-eaaa6300-632b-11ea-9760-dd115cc2b082.png)
   
   By this workaround everything goes as expected.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services