[GitHub] [cloudstack] blueorangutan commented on issue #4002: server: Search zone-wide storage pool when allocation algothrim is firstfitleastconsumed

2020-04-03 Thread GitBox
blueorangutan commented on issue #4002: server: Search zone-wide storage pool 
when allocation algothrim is firstfitleastconsumed
URL: https://github.com/apache/cloudstack/pull/4002#issuecomment-608972226
 
 
   Trillian test result (tid-1358)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 30179 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4002-t1358-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Smoke tests completed. 76 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_vpc_privategw_static_routes | `Failure` | 177.50 | 
test_privategw_acl.py
   test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 174.52 | 
test_privategw_acl.py
   test_04_rvpc_privategw_static_routes | `Failure` | 244.24 | 
test_privategw_acl.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #4002: server: Search zone-wide storage pool when allocation algothrim is firstfitleastconsumed

2020-04-03 Thread GitBox
blueorangutan commented on issue #4002: server: Search zone-wide storage pool 
when allocation algothrim is firstfitleastconsumed
URL: https://github.com/apache/cloudstack/pull/4002#issuecomment-608969023
 
 
   Trillian test result (tid-1355)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 31759 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4002-t1355-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Smoke tests completed. 76 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_vpc_privategw_static_routes | `Failure` | 190.39 | 
test_privategw_acl.py
   test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 178.21 | 
test_privategw_acl.py
   test_04_rvpc_privategw_static_routes | `Failure` | 252.20 | 
test_privategw_acl.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] weizhouapache commented on issue #4002: server: Search zone-wide storage pool when allocation algothrim is firstfitleastconsumed

2020-04-03 Thread GitBox
weizhouapache commented on issue #4002: server: Search zone-wide storage pool 
when allocation algothrim is firstfitleastconsumed
URL: https://github.com/apache/cloudstack/pull/4002#issuecomment-608656465
 
 
   > Single zone-wide - VM started fine
   > 
![image](https://user-images.githubusercontent.com/45762285/78398574-9aa18200-75f3-11ea-9f21-cf7560eec7aa.png)
   > 
![image](https://user-images.githubusercontent.com/45762285/78398470-6b8b1080-75f3-11ea-8588-9377b0ce2b41.png)
   > 
![image](https://user-images.githubusercontent.com/45762285/78398508-78a7ff80-75f3-11ea-9b66-0eb7a0e53a77.png)
   > 
   > Added another zone-wide, and was able to spring VM as expected:
   > 
![image](https://user-images.githubusercontent.com/45762285/78399553-6333d500-75f5-11ea-8988-35969cb855fd.png)
   > 
![image](https://user-images.githubusercontent.com/45762285/78399584-747ce180-75f5-11ea-95bd-b16966abac66.png)
   > 
   > Have not reproduced before the fix - but the fix is working fine
   > 
   > LGTM
   
   @andrijapanicsb Have you restarted the management server after 
vm.allocation.algorithm is changed to firstfitleastconsumed (it is 'random' by 
default) ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] andrijapanicsb commented on issue #3987: Exception in long running Java11/MySQL8 management server

2020-04-03 Thread GitBox
andrijapanicsb commented on issue #3987: Exception in long running 
Java11/MySQL8 management server
URL: https://github.com/apache/cloudstack/issues/3987#issuecomment-608635031
 
 
   @DaanHoogland did you tell me you had spun Trillian env for this one - can't 
find it?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] andrijapanicsb commented on issue #4002: server: Search zone-wide storage pool when allocation algothrim is firstfitleastconsumed

2020-04-03 Thread GitBox
andrijapanicsb commented on issue #4002: server: Search zone-wide storage pool 
when allocation algothrim is firstfitleastconsumed
URL: https://github.com/apache/cloudstack/pull/4002#issuecomment-608628853
 
 
   Single zone-wide - VM started fine
   
![image](https://user-images.githubusercontent.com/45762285/78398574-9aa18200-75f3-11ea-9f21-cf7560eec7aa.png)
   
![image](https://user-images.githubusercontent.com/45762285/78398470-6b8b1080-75f3-11ea-8588-9377b0ce2b41.png)
   
![image](https://user-images.githubusercontent.com/45762285/78398508-78a7ff80-75f3-11ea-9b66-0eb7a0e53a77.png)
   
   Added another zone-wide, and was able to spring VM as expected:
   
![image](https://user-images.githubusercontent.com/45762285/78399553-6333d500-75f5-11ea-8988-35969cb855fd.png)
   
![image](https://user-images.githubusercontent.com/45762285/78399584-747ce180-75f5-11ea-95bd-b16966abac66.png)
   
   Have not reproduced before the fix - but the fix is working fine
   
   LGTM


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #4002: server: Search zone-wide storage pool when allocation algothrim is firstfitleastconsumed

2020-04-03 Thread GitBox
blueorangutan commented on issue #4002: server: Search zone-wide storage pool 
when allocation algothrim is firstfitleastconsumed
URL: https://github.com/apache/cloudstack/pull/4002#issuecomment-608623047
 
 
   @andrijapanicsb a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3999: Update schema-41310to41400.sql

2020-04-03 Thread GitBox
blueorangutan commented on issue #3999: Update schema-41310to41400.sql
URL: https://github.com/apache/cloudstack/pull/3999#issuecomment-608622658
 
 
   @andrijapanicsb a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] andrijapanicsb commented on issue #4002: server: Search zone-wide storage pool when allocation algothrim is firstfitleastconsumed

2020-04-03 Thread GitBox
andrijapanicsb commented on issue #4002: server: Search zone-wide storage pool 
when allocation algothrim is firstfitleastconsumed
URL: https://github.com/apache/cloudstack/pull/4002#issuecomment-608622550
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] andrijapanicsb commented on issue #3999: Update schema-41310to41400.sql

2020-04-03 Thread GitBox
andrijapanicsb commented on issue #3999: Update schema-41310to41400.sql
URL: https://github.com/apache/cloudstack/pull/3999#issuecomment-608622280
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] andrijapanicsb commented on issue #4002: server: Search zone-wide storage pool when allocation algothrim is firstfitleastconsumed

2020-04-03 Thread GitBox
andrijapanicsb commented on issue #4002: server: Search zone-wide storage pool 
when allocation algothrim is firstfitleastconsumed
URL: https://github.com/apache/cloudstack/pull/4002#issuecomment-608619465
 
 
   @weizhouapache is this "if ALL pools are zone-wide" - i.e. in mixed 
cluster/zone-wide pools you did NOT observe the issue?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] harikrishna-patnala commented on issue #3969: Snapshot deletion issues

2020-04-03 Thread GitBox
harikrishna-patnala commented on issue #3969: Snapshot deletion issues
URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-608618008
 
 
   > @harikrishna-patnala thanks for sharing that commit. Can you please share 
a branch with that commit?
   > 
   > The access issue is due to the fact that Apache branches are open only for 
committers.
   
   You may please apply this patch on this branch and update the PR. I could 
not create a private branch, I'm a committer though but have to check about 
access rights.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3984: Remove rolling-maintenance service from debian rules

2020-04-03 Thread GitBox
blueorangutan commented on issue #3984: Remove rolling-maintenance service from 
debian rules
URL: https://github.com/apache/cloudstack/pull/3984#issuecomment-608617295
 
 
   @andrijapanicsb a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] andrijapanicsb commented on issue #3984: Remove rolling-maintenance service from debian rules

2020-04-03 Thread GitBox
andrijapanicsb commented on issue #3984: Remove rolling-maintenance service 
from debian rules
URL: https://github.com/apache/cloudstack/pull/3984#issuecomment-608617030
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3984: Remove rolling-maintenance service from debian rules

2020-04-03 Thread GitBox
blueorangutan commented on issue #3984: Remove rolling-maintenance service from 
debian rules
URL: https://github.com/apache/cloudstack/pull/3984#issuecomment-608615869
 
 
   Packaging result: ✔centos7 ✔debian. JID-1124


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3999: Update schema-41310to41400.sql

2020-04-03 Thread GitBox
blueorangutan commented on issue #3999: Update schema-41310to41400.sql
URL: https://github.com/apache/cloudstack/pull/3999#issuecomment-608615791
 
 
   Packaging result: ✔centos7 ✔debian. JID-1123


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] andrijapanicsb closed pull request #3917: Add logging around arping in CsAddress.py

2020-04-03 Thread GitBox
andrijapanicsb closed pull request #3917: Add logging around arping in 
CsAddress.py
URL: https://github.com/apache/cloudstack/pull/3917
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] andrijapanicsb merged pull request #4012: Update schema-41310to41400.sql

2020-04-03 Thread GitBox
andrijapanicsb merged pull request #4012: Update schema-41310to41400.sql
URL: https://github.com/apache/cloudstack/pull/4012
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[cloudstack] branch update-the-desc-of-snapshot.backup.to.secondary updated (09b1ea4 -> 4dca4c9)

2020-04-03 Thread andrijapanic
This is an automated email from the ASF dual-hosted git repository.

andrijapanic pushed a change to branch 
update-the-desc-of-snapshot.backup.to.secondary
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


from 09b1ea4  update the config key as well
 add 4dca4c9  Update schema-41310to41400.sql (#4012)

No new revisions were added by this update.

Summary of changes:
 engine/schema/src/main/resources/META-INF/db/schema-41310to41400.sql | 2 +-
 server/src/main/java/com/cloud/storage/snapshot/SnapshotManager.java | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)



[cloudstack] branch andrijapanicsb-patch-3 updated (8236e4a -> e12691f)

2020-04-03 Thread andrijapanic
This is an automated email from the ASF dual-hosted git repository.

andrijapanic pushed a change to branch andrijapanicsb-patch-3
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


from 8236e4a  Update schema-41310to41400.sql
 add e12691f  update configkey desc

No new revisions were added by this update.

Summary of changes:
 server/src/main/java/com/cloud/storage/snapshot/SnapshotManager.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)



[cloudstack] branch andrijapanicsb-patch-3 created (now 8236e4a)

2020-04-03 Thread andrijapanic
This is an automated email from the ASF dual-hosted git repository.

andrijapanic pushed a change to branch andrijapanicsb-patch-3
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


  at 8236e4a  Update schema-41310to41400.sql

This branch includes the following new commits:

 new 8236e4a  Update schema-41310to41400.sql

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.




[GitHub] [cloudstack] andrijapanicsb opened a new pull request #4012: Update schema-41310to41400.sql

2020-04-03 Thread GitBox
andrijapanicsb opened a new pull request #4012: Update schema-41310to41400.sql
URL: https://github.com/apache/cloudstack/pull/4012
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[cloudstack] 01/01: Update schema-41310to41400.sql

2020-04-03 Thread andrijapanic
This is an automated email from the ASF dual-hosted git repository.

andrijapanic pushed a commit to branch andrijapanicsb-patch-3
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit 8236e4a6981f97667ce9d73bde5ad8210bd4563d
Author: Andrija Panic <45762285+andrijapani...@users.noreply.github.com>
AuthorDate: Fri Apr 3 20:58:08 2020 +0200

Update schema-41310to41400.sql
---
 engine/schema/src/main/resources/META-INF/db/schema-41310to41400.sql | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git 
a/engine/schema/src/main/resources/META-INF/db/schema-41310to41400.sql 
b/engine/schema/src/main/resources/META-INF/db/schema-41310to41400.sql
index 8620369..baa7bcf 100644
--- a/engine/schema/src/main/resources/META-INF/db/schema-41310to41400.sql
+++ b/engine/schema/src/main/resources/META-INF/db/schema-41310to41400.sql
@@ -21,7 +21,7 @@
 
 -- Update the description to indicate this only works with KVM + Ceph 
 -- (not implemented properly atm for KVM+NFS/local, and it accidentaly works 
with XS + NFS. Not applicable for VMware)
-UPDATE `cloud`.`configuration` SET `description`='Indicates whether to always 
backup primary storage snapshot to secondary storage. Applicable for KVM + Ceph 
only.' WHERE  `name`='snapshot.backup.to.secondary';
+UPDATE `cloud`.`configuration` SET `description`='Indicates whether to always 
backup primary storage snapshot to secondary storage. Keeping snapshots only on 
Primary storage is applicable for KVM + Ceph only.' WHERE  
`name`='snapshot.backup.to.secondary';
 
 -- KVM: enable storage data motion on KVM hypervisor_capabilities
 UPDATE `cloud`.`hypervisor_capabilities` SET `storage_motion_supported` = 1 
WHERE `hypervisor_capabilities`.`hypervisor_type` = 'KVM';



[GitHub] [cloudstack] andrijapanicsb commented on issue #3999: Update schema-41310to41400.sql

2020-04-03 Thread GitBox
andrijapanicsb commented on issue #3999: Update schema-41310to41400.sql
URL: https://github.com/apache/cloudstack/pull/3999#issuecomment-608605569
 
 
   Looks good, except the description is incomplete 🤦‍♂ 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] andrijapanicsb opened a new issue #4011: Allow .img extension for qcow2 type of template

2020-04-03 Thread GitBox
andrijapanicsb opened a new issue #4011: Allow .img extension for qcow2 type of 
template
URL: https://github.com/apache/cloudstack/issues/4011
 
 
   
   
   # ISSUE TYPE
   
* Bug Report
* Improvement Request
* Enhancement Request
* Feature Idea
* Documentation Report
* Other
   
   KVM ".img" extension is used for both qcow2 and raw image types (for reasons 
to confuse you and nothing else!) and since Canonical (and others, i.e. 
OpenStack) distributed some linux/cloud qcow2 images with .img extension, it 
makes sense to allow .img extension for qcow2 as well
   
   Currently, this extension is allowed for RAW image type only.
   Change is simple but requires careful unit test change.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #4008: Fix template registration error

2020-04-03 Thread GitBox
blueorangutan commented on issue #4008: Fix template registration error
URL: https://github.com/apache/cloudstack/pull/4008#issuecomment-608602856
 
 
   Packaging result: ✔centos7 ✔debian. JID-1122


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #4002: server: Search zone-wide storage pool when allocation algothrim is firstfitleastconsumed

2020-04-03 Thread GitBox
blueorangutan commented on issue #4002: server: Search zone-wide storage pool 
when allocation algothrim is firstfitleastconsumed
URL: https://github.com/apache/cloudstack/pull/4002#issuecomment-608599539
 
 
   @andrijapanicsb a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3984: Remove rolling-maintenance service from debian rules

2020-04-03 Thread GitBox
blueorangutan commented on issue #3984: Remove rolling-maintenance service from 
debian rules
URL: https://github.com/apache/cloudstack/pull/3984#issuecomment-608599127
 
 
   @andrijapanicsb a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] andrijapanicsb commented on issue #4002: server: Search zone-wide storage pool when allocation algothrim is firstfitleastconsumed

2020-04-03 Thread GitBox
andrijapanicsb commented on issue #4002: server: Search zone-wide storage pool 
when allocation algothrim is firstfitleastconsumed
URL: https://github.com/apache/cloudstack/pull/4002#issuecomment-608599107
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3999: Update schema-41310to41400.sql

2020-04-03 Thread GitBox
blueorangutan commented on issue #3999: Update schema-41310to41400.sql
URL: https://github.com/apache/cloudstack/pull/3999#issuecomment-608598716
 
 
   @andrijapanicsb a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] andrijapanicsb commented on issue #3984: Remove rolling-maintenance service from debian rules

2020-04-03 Thread GitBox
andrijapanicsb commented on issue #3984: Remove rolling-maintenance service 
from debian rules
URL: https://github.com/apache/cloudstack/pull/3984#issuecomment-608598623
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] andrijapanicsb commented on issue #3999: Update schema-41310to41400.sql

2020-04-03 Thread GitBox
andrijapanicsb commented on issue #3999: Update schema-41310to41400.sql
URL: https://github.com/apache/cloudstack/pull/3999#issuecomment-608598130
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan removed a comment on issue #3999: Update schema-41310to41400.sql

2020-04-03 Thread GitBox
blueorangutan removed a comment on issue #3999: Update schema-41310to41400.sql
URL: https://github.com/apache/cloudstack/pull/3999#issuecomment-607604832
 
 
   Trillian test result (tid-1341)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 138465 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3999-t1341-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_accounts.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_affinity_groups_projects.py
   Intermittent failure detected: /marvin/tests/smoke/test_async_job.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
   Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_iso.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_deploy_vms_with_varied_deploymentplanners.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_deploy_vm_with_userdata.py
   Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_domain_service_offerings.py
   Intermittent failure detected: /marvin/tests/smoke/test_global_settings.py
   Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermittent failure detected: /marvin/tests/smoke/test_iso.py
   Intermittent failure detected: /marvin/tests/smoke/test_list_ids_parameter.py
   Intermittent failure detected: /marvin/tests/smoke/test_loadbalance.py
   Intermittent failure detected: /marvin/tests/smoke/test_metrics_api.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_multipleips_per_nic.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_nested_virtualization.py
   Intermittent failure detected: /marvin/tests/smoke/test_network_acl.py
   Intermittent failure detected: /marvin/tests/smoke/test_network.py
   Intermittent failure detected: /marvin/tests/smoke/test_nic_adapter_type.py
   Intermittent failure detected: /marvin/tests/smoke/test_password_server.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_portforwardingrules.py
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermittent failure detected: /marvin/tests/smoke/test_projects.py
   Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_resource_accounting.py
   Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
   Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py
   Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_routers_iptables_default_policy.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_routers_network_ops.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers.py
   Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
   Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
   Intermittent failure detected: /marvin/tests/smoke/test_templates.py
   Intermittent failure detected: /marvin/tests/smoke/test_usage.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 35 look OK, 42 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   ContextSuite context=TestAccounts>:setup | `Error` | 0.00 | test_accounts.py
   ContextSuite context=TestAddVmToSubDomain>:setup | `Error` | 0.00 | 
test_accounts.py
   test_DeleteDomain | `Error` | 0.69 | test_accounts.py
   test_forceDeleteDomain | `Error` | 0.69 | test_accounts.py
   ContextSuite context=TestRemoveUserFromAccount>:setup | `Error` | 4.93 | 
test_accounts.py
   ContextSuite context=TestDeployVmWithAffinityGroup>:setup | `Error` | 0.00 | 
test_affinity_groups_projects.py
   test_UpdateConfigParamWithScope | `Error` | 0.07 | test_global_settings.py
   ContextSuite context=TestAsyncJob>:setup | `Error` | 0.00 | test_async_job.py
   ContextSuite context=TestDeployVirtioSCSIVM>:setup | `Error` | 0.00 | 
test_deploy_virtio_scsi_vm.py
   ContextSuite context=TestDeployVMFromISO>:setup | `Error` | 0.00 | 
test_deploy_vm_iso.py
   ContextSuite context=TestInternalLb>:setup | `Error` | 0.00 | 
test_internal_lb.py
   ContextSuite context=TestDeployVmWithVariedPlanners>:setup | `Error` | 0.00 
| test_deploy_vms_with_varied_deploymentplanners.py
   ContextSuite context=TestDeployVmWithUserData>:setup | `Erro

[cloudstack] branch master updated: Fix template registration error (#4008)

2020-04-03 Thread andrijapanic
This is an automated email from the ASF dual-hosted git repository.

andrijapanic pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/master by this push:
 new 22b4cca  Fix template registration error (#4008)
22b4cca is described below

commit 22b4cca50def31e2f2a7487f92308a46747da966
Author: Nicolas Vazquez 
AuthorDate: Fri Apr 3 15:37:00 2020 -0300

Fix template registration error (#4008)
---
 .../java/org/apache/cloudstack/utils/imagestore/ImageStoreUtil.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git 
a/utils/src/main/java/org/apache/cloudstack/utils/imagestore/ImageStoreUtil.java
 
b/utils/src/main/java/org/apache/cloudstack/utils/imagestore/ImageStoreUtil.java
index 5e0811d..da19419 100644
--- 
a/utils/src/main/java/org/apache/cloudstack/utils/imagestore/ImageStoreUtil.java
+++ 
b/utils/src/main/java/org/apache/cloudstack/utils/imagestore/ImageStoreUtil.java
@@ -58,7 +58,7 @@ public class ImageStoreUtil {
 return "";
 }
 // raw
-if ((output.contains("x86 boot") || output.contains("DOS/MBR boot 
sector") || output.contains("data")) && (isCorrectExtension(uripath, "raw") || 
isCorrectExtension(uripath, "img"))) {
+if ((output.contains("x86 boot") || output.contains("DOS/MBR boot 
sector") || output.contains("data")) && isCorrectExtension(uripath, "raw")) {
 s_logger.debug("File at path " + path + " looks like a raw image 
:" + output);
 return "";
 }



[GitHub] [cloudstack] andrijapanicsb merged pull request #4008: Fix template registration error

2020-04-03 Thread GitBox
andrijapanicsb merged pull request #4008: Fix template registration error
URL: https://github.com/apache/cloudstack/pull/4008
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] andrijapanicsb commented on issue #4008: Fix template registration error

2020-04-03 Thread GitBox
andrijapanicsb commented on issue #4008: Fix template registration error
URL: https://github.com/apache/cloudstack/pull/4008#issuecomment-608597338
 
 
   the last commit reverted, so nothing to test again - previous tests are 
valid (we need new packages, since old ones are wiped).
   
   Merging based on 3 x LGTMs/Approvals, manual functional testing and 
automated regression testing (the single failing test is not related to the PR).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #4002: server: Search zone-wide storage pool when allocation algothrim is firstfitleastconsumed

2020-04-03 Thread GitBox
blueorangutan commented on issue #4002: server: Search zone-wide storage pool 
when allocation algothrim is firstfitleastconsumed
URL: https://github.com/apache/cloudstack/pull/4002#issuecomment-608592962
 
 
   Packaging result: ✔centos7 ✔debian. JID-1121


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #4008: Fix template registration error

2020-04-03 Thread GitBox
blueorangutan commented on issue #4008: Fix template registration error
URL: https://github.com/apache/cloudstack/pull/4008#issuecomment-608590239
 
 
   @nvazquez a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] nvazquez commented on issue #4008: Fix template registration error

2020-04-03 Thread GitBox
nvazquez commented on issue #4008: Fix template registration error
URL: https://github.com/apache/cloudstack/pull/4008#issuecomment-608589910
 
 
   @andrijapanicsb reverted
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #4002: server: Search zone-wide storage pool when allocation algothrim is firstfitleastconsumed

2020-04-03 Thread GitBox
blueorangutan commented on issue #4002: server: Search zone-wide storage pool 
when allocation algothrim is firstfitleastconsumed
URL: https://github.com/apache/cloudstack/pull/4002#issuecomment-608585203
 
 
   @andrijapanicsb a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] andrijapanicsb commented on issue #4002: server: Search zone-wide storage pool when allocation algothrim is firstfitleastconsumed

2020-04-03 Thread GitBox
andrijapanicsb commented on issue #4002: server: Search zone-wide storage pool 
when allocation algothrim is firstfitleastconsumed
URL: https://github.com/apache/cloudstack/pull/4002#issuecomment-608585051
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #4008: Fix template registration error

2020-04-03 Thread GitBox
blueorangutan commented on issue #4008: Fix template registration error
URL: https://github.com/apache/cloudstack/pull/4008#issuecomment-608574949
 
 
   Packaging result: ✖centos7 ✖debian. JID-1120


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] nvazquez commented on issue #4008: Fix template registration error

2020-04-03 Thread GitBox
nvazquez commented on issue #4008: Fix template registration error
URL: https://github.com/apache/cloudstack/pull/4008#issuecomment-608572510
 
 
   @andrijapanicsb img extension added for qcow2 format in the last commit
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #4008: Fix template registration error

2020-04-03 Thread GitBox
blueorangutan commented on issue #4008: Fix template registration error
URL: https://github.com/apache/cloudstack/pull/4008#issuecomment-608572796
 
 
   @nvazquez a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan removed a comment on issue #4008: Fix template registration error

2020-04-03 Thread GitBox
blueorangutan removed a comment on issue #4008: Fix template registration error
URL: https://github.com/apache/cloudstack/pull/4008#issuecomment-607803936
 
 
   Trillian test result (tid-1343)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 57106 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4008-t1343-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_global_settings.py
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py
   Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_resource_accounting.py
   Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
   Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py
   Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_routers_iptables_default_policy.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_routers_network_ops.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers.py
   Intermittent failure detected: /marvin/tests/smoke/test_secondary_storage.py
   Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
   Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
   Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
   Intermittent failure detected: /marvin/tests/smoke/test_templates.py
   Intermittent failure detected: /marvin/tests/smoke/test_usage.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
   Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Smoke tests completed. 54 look OK, 23 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_UpdateConfigParamWithScope | `Error` | 0.11 | test_global_settings.py
   test_02_vpc_privategw_static_routes | `Failure` | 139.34 | 
test_privategw_acl.py
   test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 132.13 | 
test_privategw_acl.py
   test_04_rvpc_privategw_static_routes | `Failure` | 188.79 | 
test_privategw_acl.py
   ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | 
test_reset_vm_on_reboot.py
   ContextSuite context=TestRAMCPUResourceAccounting>:setup | `Error` | 0.00 | 
test_resource_accounting.py
   ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | 
test_router_dhcphosts.py
   ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | 
test_router_dhcphosts.py
   ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | 
test_router_dns.py
   test_01_sys_vm_start | `Failure` | 0.08 | test_secondary_storage.py
   ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | 
test_router_dnsservice.py
   ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | 
test_routers_iptables_default_policy.py
   ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | 
test_routers_iptables_default_policy.py
   ContextSuite context=TestIsolatedNetworks>:setup | `Error` | 0.00 | 
test_routers_network_ops.py
   ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 0.00 | 
test_routers_network_ops.py
   ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | 
test_routers.py
   ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | 
test_service_offerings.py
   ContextSuite context=TestServiceOfferings>:setup | `Error` | 0.21 | 
test_service_offerings.py
   ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | 
test_snapshots.py
   test_01_list_sec_storage_vm | `Failure` | 0.03 | test_ssvm.py
   test_02_list_cpvm_vm | `Failure` | 0.03 | test_ssvm.py
   test_03_ssvm_internals | `Failure` | 0.03 | test_ssvm.py
   test_04_cpvm_internals | `Failure` | 0.03 | test_ssvm.py
   test_05_stop_ssvm | `Failure` | 0.03 | test_ssvm.py
   test_06_stop_cpvm | `Failure` | 0.03 | test_ssvm.py
   test_07_reboot_ssvm | `Failure` | 0.03 | test_ssvm.py
   test_08_reboot_cpvm | `Failure` | 0.03 | test_ssvm.py
   test_09_destroy_ssvm | `Failure` | 0.03 | test_ssvm.py
   test_10_destroy_cpvm | `Failure` | 0.03 | test_ssvm.py
   test_02_create_template_with_checksum_sha1 | `Error` | 65.47 | 
test_templates.py
   test_03_create_template_with_checksum_sha256 | `Error` | 65.46 | 
test_templates.py
   test_04

[GitHub] [cloudstack] GabrielBrascher commented on issue #3969: Snapshot deletion issues

2020-04-03 Thread GitBox
GabrielBrascher commented on issue #3969: Snapshot deletion issues
URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-608559503
 
 
   @harikrishna-patnala thanks for sharing that commit. Can you please share a 
branch with that commit?
   
   The access issue is due to the fact that Apache branches are open only for 
committers.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] kioie opened a new pull request #4010: New API endpoint to update size of Pod Management IP Range.

2020-04-03 Thread GitBox
kioie opened a new pull request #4010: New API endpoint to update size of Pod 
Management IP Range.
URL: https://github.com/apache/cloudstack/pull/4010
 
 
   ## Description
   
   **New API endpoint to update size of Pod Management IP Range.**
   
   Currently, pod management IP range can only be expanded under the same 
subnet. Editing the current pod IP management range is a challenge, especially 
as the list of IP ranges is greater than one. The purpose of this feature is to 
allow ADMINS to be able to update size of IP range of management pod, upwards 
or downwards.
   
   PR #2048 and 
[FS](https://cwiki.apache.org/confluence/display/CLOUDSTACK/Expansion+of+Management+IP+Range)
 added two APIs(`createManagementNetworkIpRange` & 
`deleteManagementNetworkIpRange`). This feature is now in addition to the two 
APIs.
   
   **Brief description**
   
   - Updatepodmanagementnetworkiprange will update already existing IP ranges. 
Will not create a new IP range.
   - Will increase/reduce available IPs within the range.
   - PodID/Currentstartip/CurrentendIp are mandatory fields. Newstartip and 
Newendip are optional fields and when left blank, Newstartip will be set to 
Currentstartip and Newendip will be set to Currentendip.
   - Api only available to root admin and does not have any sensitive 
information passed.
   - Will output success response -true/false
   - Does not alter structure of DB, but will update contents.
   
   **When to use**
   
   - Reducing size of existing IP range
   - Increasing size of existing IP range
   
   **How to use**
   
   Run `list pods` command to see existing IP ranges
   ```
   > list pods
   {
 "count": 1,
 "pod": [
   {
 "allocationstate": "Enabled",
 "endip": [
   "172.16.15.210",
   "172.16.15.204"
 ],
 "forsystemvms": [
   "0",
   "0"
 ],
 "gateway": "172.16.15.1",
 "id": "1407da22-a131-4dbd-86a3-45210a26897e",
 "name": "POD0",
 "netmask": "255.255.255.0",
 "startip": [
   "172.16.15.205",
   "172.16.15.2"
 ],
 "vlanid": [
   "vlan://untagged",
   "vlan://untagged"
 ],
 "zoneid": "3ab731d6-efd5-418c-ab2b-cacbfc4b88f0",
 "zonename": "Sandbox-simulator"
   }
 ]
   }
   ```
   2. Update the IP range you'd like to change. In our case, we want to 
increase the range `172.16.15.205-172.16.15.210` to 
`172.16.15.205-172.16.15.215`. Use the command `update 
podmanagementnetworkiprange`
   
   ```
   > update podmanagementnetworkiprange 
podid=1407da22-a131-4dbd-86a3-45210a26897e currentstartip=172.16.15.205 
currentendip=172.16.15.210 newendip=172.16.15.215
   {
 "success": true
   }
   ```
   To reduce size of range to `172.16.15.205-172.16.15.207`
   ```
   > update podmanagementnetworkiprange 
podid=1407da22-a131-4dbd-86a3-45210a26897e currentstartip=172.16.15.205 
currentendip=172.16.15.215 newendip=172.16.15.207
   {
 "success": true
   }
   ```
   Confirm by running `list pods` again
   ```
   > list pods 
   {
 "count": 1,
 "pod": [
   {
 "allocationstate": "Enabled",
 "endip": [
   "172.16.15.207",
   "172.16.15.204"
 ],
 "forsystemvms": [
   "0",
   "0"
 ],
 "gateway": "172.16.15.1",
 "id": "1407da22-a131-4dbd-86a3-45210a26897e",
 "name": "POD0",
 "netmask": "255.255.255.0",
 "startip": [
   "172.16.15.205",
   "172.16.15.2"
 ],
 "vlanid": [
   "vlan://untagged",
   "vlan://untagged"
 ],
 "zoneid": "3ab731d6-efd5-418c-ab2b-cacbfc4b88f0",
 "zonename": "Sandbox-simulator"
   }
 ]
   }
   ```
   
   Touches on #2797 #2735 #3292 
   
   
   
   
   
   
   
   ## Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [x] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Tests
   
   
   
   **Manual Tests**
   Test for invalid parameters for 
Currentstartip/Currentendip/Newstartip/Newendip
   Test for invalid current IP range
   Test for overlapping IP range extensions
   Test for non-existent IP range
   Test for Newstartip>Newendip
   Test for duplicate IP range
   Test for invalid Pod ID
   Test- Reduce existing IP range to not include already allocated IPs
   
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.a

[GitHub] [cloudstack] harikrishna-patnala commented on issue #3969: Snapshot deletion issues

2020-04-03 Thread GitBox
harikrishna-patnala commented on issue #3969: Snapshot deletion issues
URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-608490677
 
 
   Have seen couple of issues when handling deletesnapshot for snapshots backed 
up only in primary storage and snapshots backed up in secondary storage. I have 
made a fix for that but unable to push the changes due to some access issues. 
I'll update the PR once I resolve my access issue.0
   
   Following are the test cases I covered after the fix is made
   1. Create data volumes vol1 and vol2
   2. Set global parameter snapshots.backup.to.secondary = true
   3. Create snapshot snap1vol1 from vol1
   4. Set global parameter snapshots.backup.to.secondary = false
   5. Create snapshot snap2vol2 from vol2 
   6. Create snapshot snap3vol1 form vol1
   7. Delete snap2vol2 // This is deletion of snapshot which is created only in 
primary and no entries in snapshot_store_ref table against store_role ‘Image’
   8. Delete snap3vol1 // This is deletion of snapshot which is created only in 
primary but MS can get a snapshot_store_ref entry against store_role ‘Image’ 
with id of vol1 because snap1vol1 are created in both primary and secondary 
storage from vol1
   9. Delete snap1vol1 // This is deletion of snapshot which is created both in 
primary and secondary
   
   Attached the patch if someone can add it on behalf of me.
   
[0001-Fix-deletesnapshot-worflow-to-handle-both-snapshots-.patch.zip](https://github.com/apache/cloudstack/files/4428067/0001-Fix-deletesnapshot-worflow-to-handle-both-snapshots-.patch.zip)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3976: Enable sending hypervior host name via metadata - VR and Config Drive

2020-04-03 Thread GitBox
DaanHoogland commented on a change in pull request #3976: Enable sending 
hypervior host name via metadata - VR and Config Drive
URL: https://github.com/apache/cloudstack/pull/3976#discussion_r402943211
 
 

 ##
 File path: 
engine/api/src/main/java/org/apache/cloudstack/engine/orchestration/service/NetworkOrchestrationService.java
 ##
 @@ -299,7 +299,7 @@ void 
implementNetworkElementsAndResources(DeployDestination dest, ReservationCon
  * service provider is ConfigDrive or VirtualRouter
  * @param vm
  * @param dest
 
 Review comment:
   please add descriptions or remove


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland commented on issue #4003: Logging framework to use only log4j and wrapper slf4j

2020-04-03 Thread GitBox
DaanHoogland commented on issue #4003: Logging framework to use only log4j and 
wrapper slf4j
URL: https://github.com/apache/cloudstack/pull/4003#issuecomment-608382934
 
 
   > > I think the name of this PR is wrong, is it?
   > > "replace slf4j to standardise on log4j"
   > 
   > But at very less places we are using slf4j. In order to replace slf4j to 
standardise log4j, we need to change almost all the files to use slf4j. I kept 
this name "Logging framework to use only log4j and wrapper slf4j" because java 
util logging framework and apache common logging wrapper are used and we 
removed them now.
   
   I want to not use slf4j anywhere, but standardise on log4j. It is used in 
the far majority of places and needs to be standardised to, to be able to 
reduce the upgrade working needed in the future. Both slf4j and commons-logging 
should be phased out completely.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4003: Logging framework to use only log4j and wrapper slf4j

2020-04-03 Thread GitBox
DaanHoogland commented on a change in pull request #4003: Logging framework to 
use only log4j and wrapper slf4j
URL: https://github.com/apache/cloudstack/pull/4003#discussion_r402939700
 
 

 ##
 File path: 
utils/src/main/java/com/cloud/utils/backoff/impl/ConstantTimeBackoff.java
 ##
 @@ -44,7 +41,7 @@
 public class ConstantTimeBackoff extends AdapterBase implements 
BackoffAlgorithm, ConstantTimeBackoffMBean {
 long _time;
 private final Map _asleep = new ConcurrentHashMap();
-private final static Log LOG = 
LogFactory.getLog(ConstantTimeBackoff.class);
+private static final Logger s_logger = 
Logger.getLogger(ConstantTimeBackoff.class.getName());
 
 Review comment:
   no, please, the s_ is an old convention. LOGGER is ok, but LOG as well. I 
prefer the latter, but as long as we standardise on something I'm fine with it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland commented on issue #4002: server: Search zone-wide storage pool when allocation algothrim is firstfitleastconsumed

2020-04-03 Thread GitBox
DaanHoogland commented on issue #4002: server: Search zone-wide storage pool 
when allocation algothrim is firstfitleastconsumed
URL: https://github.com/apache/cloudstack/pull/4002#issuecomment-608381126
 
 
   @andrijapanicsb can you test this?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3976: Enable sending hypervior host name via metadata - VR and Config Drive

2020-04-03 Thread GitBox
blueorangutan commented on issue #3976: Enable sending hypervior host name via 
metadata - VR and Config Drive
URL: https://github.com/apache/cloudstack/pull/3976#issuecomment-608372532
 
 
   Packaging result: ✔centos7 ✔debian. JID-1119


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3976: Enable sending hypervior host name via metadata - VR and Config Drive

2020-04-03 Thread GitBox
blueorangutan commented on issue #3976: Enable sending hypervior host name via 
metadata - VR and Config Drive
URL: https://github.com/apache/cloudstack/pull/3976#issuecomment-608362068
 
 
   @vladimirpetrov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] vladimirpetrov commented on issue #3976: Enable sending hypervior host name via metadata - VR and Config Drive

2020-04-03 Thread GitBox
vladimirpetrov commented on issue #3976: Enable sending hypervior host name via 
metadata - VR and Config Drive
URL: https://github.com/apache/cloudstack/pull/3976#issuecomment-608361518
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3967: noVNC console integration

2020-04-03 Thread GitBox
blueorangutan commented on issue #3967: noVNC console integration
URL: https://github.com/apache/cloudstack/pull/3967#issuecomment-608306745
 
 
   @vladimirpetrov I understand these words: "help", "hello", "thanks", 
"package", "test"
   Test command usage: test [mgmt os] [hypervisor] [additional tests]
   Mgmt OS options: ['centos6', 'centos7', 'ubuntu']
   Hypervisor options: ['kvm-centos6', 'kvm-centos7', 'kvm-ubuntu', 
'xenserver-71', 'xenserver-65sp1', 'xenserver-62sp1', 'vmware-67u3', 
'vmware-65u2', 'vmware-60u2', 'vmware-55u3', 'vmware-51u1', 'vmware-50u1']
   Additional tests: list of space separated tests with paths relative to the 
`test/integration` directory, for example: component/test_acl_listvm.py 
component/test_volumes.py
   Note: when additional tests are passed, you need to specify mgmt server os 
and hypervisor or use the `matrix` command.
   
   Blessed contributors for kicking Trillian test jobs: ['rhtyd', 'nvazquez', 
'PaulAngus', 'borisstoyanov', 'DaanHoogland', 'shwstppr', 'andrijapanicsb', 
'Spaceman1984', 'Pearl1594', 'davidjumani', 'harikrishna-patnala', 
'vladimirpetrov']


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] vladimirpetrov removed a comment on issue #3967: noVNC console integration

2020-04-03 Thread GitBox
vladimirpetrov removed a comment on issue #3967: noVNC console integration
URL: https://github.com/apache/cloudstack/pull/3967#issuecomment-608304119
 
 
   @blueorangutan  help


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan removed a comment on issue #3967: noVNC console integration

2020-04-03 Thread GitBox
blueorangutan removed a comment on issue #3967: noVNC console integration
URL: https://github.com/apache/cloudstack/pull/3967#issuecomment-608306642
 
 
   @vladimirpetrov I understand these words: "help", "hello", "thanks", 
"package", "test"
   Test command usage: test [mgmt os] [hypervisor] [additional tests]
   Mgmt OS options: ['centos6', 'centos7', 'ubuntu']
   Hypervisor options: ['kvm-centos6', 'kvm-centos7', 'kvm-ubuntu', 
'xenserver-71', 'xenserver-65sp1', 'xenserver-62sp1', 'vmware-67u3', 
'vmware-65u2', 'vmware-60u2', 'vmware-55u3', 'vmware-51u1', 'vmware-50u1']
   Additional tests: list of space separated tests with paths relative to the 
`test/integration` directory, for example: component/test_acl_listvm.py 
component/test_volumes.py
   Note: when additional tests are passed, you need to specify mgmt server os 
and hypervisor or use the `matrix` command.
   
   Blessed contributors for kicking Trillian test jobs: ['rhtyd', 'nvazquez', 
'PaulAngus', 'borisstoyanov', 'DaanHoogland', 'shwstppr', 'andrijapanicsb', 
'Spaceman1984', 'Pearl1594', 'davidjumani', 'harikrishna-patnala', 
'vladimirpetrov']


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd removed a comment on issue #3967: noVNC console integration

2020-04-03 Thread GitBox
rhtyd removed a comment on issue #3967: noVNC console integration
URL: https://github.com/apache/cloudstack/pull/3967#issuecomment-608306379
 
 
   @blueorangutan help


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] vladimirpetrov commented on issue #3967: noVNC console integration

2020-04-03 Thread GitBox
vladimirpetrov commented on issue #3967: noVNC console integration
URL: https://github.com/apache/cloudstack/pull/3967#issuecomment-608306412
 
 
   @blueorangutan help


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3967: noVNC console integration

2020-04-03 Thread GitBox
blueorangutan commented on issue #3967: noVNC console integration
URL: https://github.com/apache/cloudstack/pull/3967#issuecomment-608306642
 
 
   @vladimirpetrov I understand these words: "help", "hello", "thanks", 
"package", "test"
   Test command usage: test [mgmt os] [hypervisor] [additional tests]
   Mgmt OS options: ['centos6', 'centos7', 'ubuntu']
   Hypervisor options: ['kvm-centos6', 'kvm-centos7', 'kvm-ubuntu', 
'xenserver-71', 'xenserver-65sp1', 'xenserver-62sp1', 'vmware-67u3', 
'vmware-65u2', 'vmware-60u2', 'vmware-55u3', 'vmware-51u1', 'vmware-50u1']
   Additional tests: list of space separated tests with paths relative to the 
`test/integration` directory, for example: component/test_acl_listvm.py 
component/test_volumes.py
   Note: when additional tests are passed, you need to specify mgmt server os 
and hypervisor or use the `matrix` command.
   
   Blessed contributors for kicking Trillian test jobs: ['rhtyd', 'nvazquez', 
'PaulAngus', 'borisstoyanov', 'DaanHoogland', 'shwstppr', 'andrijapanicsb', 
'Spaceman1984', 'Pearl1594', 'davidjumani', 'harikrishna-patnala', 
'vladimirpetrov']


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd commented on issue #3967: noVNC console integration

2020-04-03 Thread GitBox
rhtyd commented on issue #3967: noVNC console integration
URL: https://github.com/apache/cloudstack/pull/3967#issuecomment-608306379
 
 
   @blueorangutan help


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] vladimirpetrov commented on issue #3967: noVNC console integration

2020-04-03 Thread GitBox
vladimirpetrov commented on issue #3967: noVNC console integration
URL: https://github.com/apache/cloudstack/pull/3967#issuecomment-608304119
 
 
   @blueorangutan  help


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] shwstppr commented on issue #4008: Fix template registration error

2020-04-03 Thread GitBox
shwstppr commented on issue #4008: Fix template registration error
URL: https://github.com/apache/cloudstack/pull/4008#issuecomment-608302804
 
 
   @andrijapanicsb I've checked into the logs for failing CKS test and it seems 
an intermittent issue while performing the upgrade on a k8s cluster. It fails 
to upgrade one of the cluster nodes in the desired time. I'm sure this has 
nothing to do with PR changes.
   cc @nvazquez 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services