[cloudstack] branch master updated (1e19ea5 -> fbfab5b)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 1e19ea5 systemvmtemplate: move to using Debian10 (#4104) add 851534a server: Honor vm.destroy.forcestop when expunge a vm (#3965) add 50f0488 Merge remote-tracking branch 'origin/4.13' into 4.14 add fbfab5b Merge remote-tracking branch 'origin/4.14' No new revisions were added by this update. Summary of changes: .../src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
[cloudstack] branch 4.14 updated (5335971 -> 50f0488)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch 4.14 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 5335971 Merge remote-tracking branch 'origin/4.13' into 4.14 add 851534a server: Honor vm.destroy.forcestop when expunge a vm (#3965) new 50f0488 Merge remote-tracking branch 'origin/4.13' into 4.14 The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
[cloudstack] 01/01: Merge remote-tracking branch 'origin/4.13' into 4.14
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch 4.14 in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit 50f0488aaea8090c68dd7933edac90bcf67dd01c Merge: 5335971 851534a Author: Rohit Yadav AuthorDate: Tue Jun 9 08:29:39 2020 +0530 Merge remote-tracking branch 'origin/4.13' into 4.14 .../src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
[cloudstack] branch 4.13 updated: server: Honor vm.destroy.forcestop when expunge a vm (#3965)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch 4.13
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/4.13 by this push:
new 851534a server: Honor vm.destroy.forcestop when expunge a vm (#3965)
851534a is described below
commit 851534ac1715af3d0eacd9d81edf85de392c64b5
Author: Wei Zhou
AuthorDate: Tue Jun 9 04:55:51 2020 +0200
server: Honor vm.destroy.forcestop when expunge a vm (#3965)
When expunge a Running vm, vm will be stopped with forcestop=false which
does not make sense. we should honor vm.destroy.forcestop in global setting, or
always set forcestop=true.
---
.../src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java
b/engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java
index c2af76a..aea8cc0 100755
---
a/engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java
+++
b/engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java
@@ -502,7 +502,7 @@ public class VirtualMachineManagerImpl extends ManagerBase
implements VirtualMac
return;
}
-advanceStop(vm.getUuid(), false);
+advanceStop(vm.getUuid(), VmDestroyForcestop.value());
vm = _vmDao.findByUuid(vm.getUuid());
try {
[cloudstack] branch master updated: systemvmtemplate: move to using Debian10 (#4104)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/master by this push:
new 1e19ea5 systemvmtemplate: move to using Debian10 (#4104)
1e19ea5 is described below
commit 1e19ea5bdd4c38d6240031375472c66beb6653fb
Author: Rohit Yadav
AuthorDate: Tue Jun 9 08:20:51 2020 +0530
systemvmtemplate: move to using Debian10 (#4104)
This upgrades the systemvmtemplate base to Debian 10 with openjdk-11 and a
newer strongswan package.
Fixes #3654
Signed-off-by: Rohit Yadav
---
.../com/cloud/upgrade/dao/Upgrade41400to41500.java | 44 -
systemvm/debian/etc/apache2/vhost.template | 2 +-
tools/appliance/systemvmtemplate/http/preseed.cfg | 24 ++---
.../systemvmtemplate/scripts/apt_upgrade.sh| 4 +-
.../scripts/configure_systemvm_services.sh | 4 +-
.../scripts/install_systemvm_packages.sh | 17 +++
tools/appliance/systemvmtemplate/template.json | 57 +-
7 files changed, 63 insertions(+), 89 deletions(-)
diff --git
a/engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade41400to41500.java
b/engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade41400to41500.java
index e88bf6b..13c67d9 100644
--- a/engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade41400to41500.java
+++ b/engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade41400to41500.java
@@ -103,12 +103,12 @@ public class Upgrade41400to41500 implements DbUpgrade {
final Map NewTemplateNameList = new
HashMap() {
{
-put(Hypervisor.HypervisorType.KVM, "systemvm-kvm-4.14.0");
-put(Hypervisor.HypervisorType.VMware,
"systemvm-vmware-4.14.0");
-put(Hypervisor.HypervisorType.XenServer,
"systemvm-xenserver-4.14.0");
-put(Hypervisor.HypervisorType.Hyperv,
"systemvm-hyperv-4.14.0");
-put(Hypervisor.HypervisorType.LXC, "systemvm-lxc-4.14.0");
-put(Hypervisor.HypervisorType.Ovm3, "systemvm-ovm3-4.14.0");
+put(Hypervisor.HypervisorType.KVM, "systemvm-kvm-4.15.0");
+put(Hypervisor.HypervisorType.VMware,
"systemvm-vmware-4.15.0");
+put(Hypervisor.HypervisorType.XenServer,
"systemvm-xenserver-4.15.0");
+put(Hypervisor.HypervisorType.Hyperv,
"systemvm-hyperv-4.15.0");
+put(Hypervisor.HypervisorType.LXC, "systemvm-lxc-4.15.0");
+put(Hypervisor.HypervisorType.Ovm3, "systemvm-ovm3-4.15.0");
}
};
@@ -125,30 +125,30 @@ public class Upgrade41400to41500 implements DbUpgrade {
final Map newTemplateUrl = new
HashMap() {
{
-put(Hypervisor.HypervisorType.KVM,
"https://download.cloudstack.org/systemvm/4.14/systemvmtemplate-4.14.0-kvm.qcow2.bz2;);
-put(Hypervisor.HypervisorType.VMware,
"https://download.cloudstack.org/systemvm/4.14/systemvmtemplate-4.14.0-vmware.ova;);
-put(Hypervisor.HypervisorType.XenServer,
"https://download.cloudstack.org/systemvm/4.14/systemvmtemplate-4.14.0-xen.vhd.bz2;);
-put(Hypervisor.HypervisorType.Hyperv,
"https://download.cloudstack.org/systemvm/4.14/systemvmtemplate-4.14.0-hyperv.vhd.zip;);
-put(Hypervisor.HypervisorType.LXC,
"https://download.cloudstack.org/systemvm/4.14/systemvmtemplate-4.14.0-kvm.qcow2.bz2;);
-put(Hypervisor.HypervisorType.Ovm3,
"https://download.cloudstack.org/systemvm/4.14/systemvmtemplate-4.14.0-ovm.raw.bz2;);
+put(Hypervisor.HypervisorType.KVM,
"https://download.cloudstack.org/systemvm/4.15/systemvmtemplate-4.15.0-kvm.qcow2.bz2;);
+put(Hypervisor.HypervisorType.VMware,
"https://download.cloudstack.org/systemvm/4.15/systemvmtemplate-4.15.0-vmware.ova;);
+put(Hypervisor.HypervisorType.XenServer,
"https://download.cloudstack.org/systemvm/4.15/systemvmtemplate-4.15.0-xen.vhd.bz2;);
+put(Hypervisor.HypervisorType.Hyperv,
"https://download.cloudstack.org/systemvm/4.15/systemvmtemplate-4.15.0-hyperv.vhd.zip;);
+put(Hypervisor.HypervisorType.LXC,
"https://download.cloudstack.org/systemvm/4.15/systemvmtemplate-4.15.0-kvm.qcow2.bz2;);
+put(Hypervisor.HypervisorType.Ovm3,
"https://download.cloudstack.org/systemvm/4.15/systemvmtemplate-4.15.0-ovm.raw.bz2;);
}
};
final Map newTemplateChecksum = new
HashMap() {
{
-put(Hypervisor.HypervisorType.KVM,
"d15ed159be32151b07e3211caf9cb802");
-put(Hypervisor.HypervisorType.XenServer,
"fcaf1abc9aa62e7ed75f62b3092a01a2");
-put(Hypervisor.HypervisorType.VMware,
"eb39f8b5a556dfc93c6be23ae45f34e1");
-put(Hypervisor.HypervisorType.Hyperv,
[GitHub] [cloudstack] blueorangutan commented on pull request #4085: Fix duplicate user entries for vpn usage
blueorangutan commented on pull request #4085: URL: https://github.com/apache/cloudstack/pull/4085#issuecomment-640320771 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4062: [VMware] Cannot migrate VM on PVLAN shared network
rhtyd merged pull request #4062: URL: https://github.com/apache/cloudstack/pull/4062 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd closed pull request #3611: [WIP] Support for CentOS8
rhtyd closed pull request #3611: URL: https://github.com/apache/cloudstack/pull/3611 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4119: kvm: bump jna version to latest
rhtyd merged pull request #4119: URL: https://github.com/apache/cloudstack/pull/4119 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd edited a comment on pull request #4104: Debian10 support
rhtyd edited a comment on pull request #4104: URL: https://github.com/apache/cloudstack/pull/4104#issuecomment-640318726 @weizhouapache Thanks, we'll merge this once the xenserver tests are also in. - I checked python3 was already installed on the built systemvmtemplate, but I've added explicit pkg to be installed - python2->3 migration is not done in the centos8 support PR; the systemvm continue to be on Debian where python2 ships by default (with the python package) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4132: Fix delete network with no services
blueorangutan commented on pull request #4132: URL: https://github.com/apache/cloudstack/pull/4132#issuecomment-640529728 @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4132: Fix delete network with no services
nvazquez commented on pull request #4132: URL: https://github.com/apache/cloudstack/pull/4132#issuecomment-640529128 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4135: Remove use of blacklist/whitelist terms
blueorangutan commented on pull request #4135: URL: https://github.com/apache/cloudstack/pull/4135#issuecomment-640479859 Packaging result: ✖centos7 ✖debian. JID-1314 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4135: Remove use of blacklist/whitelist terms
DaanHoogland commented on a change in pull request #4135:
URL: https://github.com/apache/cloudstack/pull/4135#discussion_r436558049
##
File path: api/src/main/java/org/apache/cloudstack/query/QueryService.java
##
@@ -94,8 +94,8 @@
ConfigKey AllowUserViewDestroyedVM = new ConfigKey<>("Advanced",
Boolean.class, "allow.user.view.destroyed.vm", "false",
"Determines whether users can view their destroyed or expunging vm
", true, ConfigKey.Scope.Account);
-static final ConfigKey UserVMBlacklistedDetails = new
ConfigKey("Advanced", String.class,
-"user.vm.blacklisted.details", "rootdisksize, cpuOvercommitRatio,
memoryOvercommitRatio, Message.ReservedCapacityFreed.Flag",
+static final ConfigKey UserVMDenyListedDetails = new
ConfigKey("Advanced", String.class,
+"user.vm.DenyListed.details", "rootdisksize, cpuOvercommitRatio,
memoryOvercommitRatio, Message.ReservedCapacityFreed.Flag",
Review comment:
not sure if this is an issue but naming convention fro settings is all
lower case.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4048: Update DpdkDriverImpl.java to support DPDK trunk interfaces
blueorangutan commented on pull request #4048: URL: https://github.com/apache/cloudstack/pull/4048#issuecomment-640476042 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4048: Update DpdkDriverImpl.java to support DPDK trunk interfaces
DaanHoogland commented on pull request #4048: URL: https://github.com/apache/cloudstack/pull/4048#issuecomment-640475226 @nvazquez you ok like this? @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4135: Remove use of blacklist/whitelist terms
blueorangutan commented on pull request #4135: URL: https://github.com/apache/cloudstack/pull/4135#issuecomment-640473079 @PaulAngus a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] PaulAngus commented on pull request #4135: Remove use of blacklist/whitelist terms
PaulAngus commented on pull request #4135: URL: https://github.com/apache/cloudstack/pull/4135#issuecomment-640472359 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] PaulAngus opened a new pull request #4135: Remove use of blacklist/whitelist terms
PaulAngus opened a new pull request #4135: URL: https://github.com/apache/cloudstack/pull/4135 ## Description This PR removes the terms blacklist and whitelist in favour of allow list and deny list. ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [x] Cleanup (Code refactoring and cleanup, that may add test cases) ## Screenshots (if appropriate): ## How Has This Been Tested? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4048: Update DpdkDriverImpl.java to support DPDK trunk interfaces
blueorangutan commented on pull request #4048: URL: https://github.com/apache/cloudstack/pull/4048#issuecomment-640454745 Packaging result: ✔centos7 ✔debian. JID-1313 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] shwstppr opened a new pull request #4134: cks: fix k8s cluster network deletion
shwstppr opened a new pull request #4134: URL: https://github.com/apache/cloudstack/pull/4134 ## Description Fixes #4133 ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## Screenshots (if appropriate): ## How Has This Been Tested? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4115: cks: fix k8s cluster deployment planner
blueorangutan commented on pull request #4115: URL: https://github.com/apache/cloudstack/pull/4115#issuecomment-640445433 Packaging result: ✔centos7 ✔debian. JID-1312 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #4084: Added nfs minor version support on SSVM
Spaceman1984 commented on a change in pull request #4084:
URL: https://github.com/apache/cloudstack/pull/4084#discussion_r436520983
##
File path:
engine/components-api/src/main/java/com/cloud/capacity/CapacityManager.java
##
@@ -73,16 +73,26 @@
"If set to true, creates VMs as full clones on ESX
hypervisor",
true,
ConfigKey.Scope.StoragePool);
-static final ConfigKey ImageStoreNFSVersion =
+static final ConfigKey ImageStoreNFSMajorVersion =
Review comment:
@rhtyd If I was to split on `.` I would have to change the Integer data
type to String, basically undoing all the changes I have made. Doing it this
way preserves backward compatibility if a value has already been stored for NFS
version and adding a second variable for minor version is as per the suggestion
in the original issue.
##
File path:
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
##
@@ -831,8 +832,12 @@ protected String mount(String path, String parent, Integer
nfsVersion) {
String result = null;
Script command = new Script(true, "mount", _timeout, s_logger);
command.add("-t", "nfs");
-if (nfsVersion != null){
-command.add("-o", "vers=" + nfsVersion);
+if (nfsMajorVersion != null){
+String nfsVersion = "vers=" + nfsMajorVersion;
+if (nfsMinorVersion != null && nfsMajorVersion >= 4) {
Review comment:
This code does exactly that, I don't understand what you would want to
change.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4048: Update DpdkDriverImpl.java to support DPDK trunk interfaces
DaanHoogland commented on pull request #4048: URL: https://github.com/apache/cloudstack/pull/4048#issuecomment-640439122 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4048: Update DpdkDriverImpl.java to support DPDK trunk interfaces
blueorangutan commented on pull request #4048: URL: https://github.com/apache/cloudstack/pull/4048#issuecomment-640439622 @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4004: Fixed null pointer and deployment issue on Xenserver with L2 Guest network with configDrive
DaanHoogland commented on pull request #4004: URL: https://github.com/apache/cloudstack/pull/4004#issuecomment-640435427 @nvazquez (cc @Spaceman1984 ) I'm leaving this with you for now? it was reviewed and tested. Can you give it a last glance and merge? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4117: [VMware] Explicitly controlling VM hardware version
blueorangutan commented on pull request #4117: URL: https://github.com/apache/cloudstack/pull/4117#issuecomment-640435472 @vladimirpetrov a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] vladimirpetrov commented on pull request #4117: [VMware] Explicitly controlling VM hardware version
vladimirpetrov commented on pull request #4117: URL: https://github.com/apache/cloudstack/pull/4117#issuecomment-640434856 @blueorangutan test centos7 vmware-67u3 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4131: Health Checkplease don't merge this
blueorangutan removed a comment on pull request #4131: URL: https://github.com/apache/cloudstack/pull/4131#issuecomment-639426641 @DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware67, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland removed a comment on pull request #4131: Health Checkplease don't merge this
DaanHoogland removed a comment on pull request #4131: URL: https://github.com/apache/cloudstack/pull/4131#issuecomment-639400811 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4131: Health Checkplease don't merge this
blueorangutan commented on pull request #4131: URL: https://github.com/apache/cloudstack/pull/4131#issuecomment-640407026 @DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware67, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4131: Health Checkplease don't merge this
blueorangutan removed a comment on pull request #4131: URL: https://github.com/apache/cloudstack/pull/4131#issuecomment-639401239 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4131: Health Checkplease don't merge this
DaanHoogland commented on pull request #4131: URL: https://github.com/apache/cloudstack/pull/4131#issuecomment-640406598 @blueorangutan test matrix This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] ravening commented on a change in pull request #4073: Display network name for IP in shared networks
ravening commented on a change in pull request #4073:
URL: https://github.com/apache/cloudstack/pull/4073#discussion_r436483220
##
File path:
api/src/main/java/org/apache/cloudstack/api/response/IPAddressResponse.java
##
@@ -150,6 +150,10 @@
@Param(description = "is public ip for display to the regular user", since
= "4.4", authorized = {RoleType.Admin})
private Boolean forDisplay;
+@SerializedName("networkname")
Review comment:
@rhtyd Done
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] ravening closed pull request #4074: Allow searching networks using name in api
ravening closed pull request #4074: URL: https://github.com/apache/cloudstack/pull/4074 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] ravening commented on pull request #4074: Allow searching networks using name in api
ravening commented on pull request #4074: URL: https://github.com/apache/cloudstack/pull/4074#issuecomment-640393800 > -1 > @ravening can you explain why we need that when we already can search by name using the `keyword` parameter? @rhtyd sorry for the delayed response. Yes "keyword" is working fine. I will close this PR This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
