[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8 Support
blueorangutan commented on pull request #4068: URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-643081171 Packaging result: ✔centos7 ✔debian. JID-1358 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #3991: Multiple dynamic VM Scaling APIs can create duplicate usage events for the same time
harikrishna-patnala commented on pull request #3991: URL: https://github.com/apache/cloudstack/pull/3991#issuecomment-643080537 @rhtyd, This was tested by @borisstoyanov. we can merge this after a final review if required. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4003: Logging framework to use only log4j
blueorangutan commented on pull request #4003: URL: https://github.com/apache/cloudstack/pull/4003#issuecomment-643078553 Packaging result: ✖centos7 ✔debian. JID-1354 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4004: Fixed null pointer and deployment issue on Xenserver with L2 Guest network with configDrive
blueorangutan commented on pull request #4004: URL: https://github.com/apache/cloudstack/pull/4004#issuecomment-643078555 Packaging result: ✔centos7 ✔debian. JID-1355 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3902: vrouter: Save PlaceHolder nic for VR if network does not have source nat
blueorangutan commented on pull request #3902: URL: https://github.com/apache/cloudstack/pull/3902#issuecomment-643078557 Packaging result: ✔centos7 ✔debian. JID-1357 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3944: vpc/server: Fix network statistics for vpc
blueorangutan commented on pull request #3944: URL: https://github.com/apache/cloudstack/pull/3944#issuecomment-643078554 Packaging result: ✔centos7 ✔debian. JID-1356 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4073: Display network name for IP in shared networks
blueorangutan commented on pull request #4073: URL: https://github.com/apache/cloudstack/pull/4073#issuecomment-643078059 Packaging result: ✔centos7 ✔debian. JID-1352 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4032: Suspending the VM prior to deleting snapshots to avoid corruption, th…
blueorangutan commented on pull request #4032: URL: https://github.com/apache/cloudstack/pull/4032#issuecomment-643078058 Packaging result: ✖centos7 ✖debian. JID-1353 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4085: Fix duplicate user entries for vpn usage
blueorangutan commented on pull request #4085: URL: https://github.com/apache/cloudstack/pull/4085#issuecomment-643076604 Packaging result: ✔centos7 ✖debian. JID-1350 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4075: Search VR using redundant state
blueorangutan commented on pull request #4075: URL: https://github.com/apache/cloudstack/pull/4075#issuecomment-643076603 Packaging result: ✖centos7 ✔debian. JID-1351 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8 Support
blueorangutan commented on pull request #4068: URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-643071719 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4068: Adding Centos8 Support
rhtyd commented on pull request #4068: URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-643071390 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #3881: Deploy VM add host gpu device available check
rhtyd commented on pull request #3881: URL: https://github.com/apache/cloudstack/pull/3881#issuecomment-643066810 I tried to close and re-open the PR to rekick Travis... @div8cn I'm unable to reopen the PR, it says the source repo has been deleted. Can you check and re-submit the PR if applicable? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #3902: vrouter: Save PlaceHolder nic for VR if network does not have source nat
rhtyd commented on pull request #3902: URL: https://github.com/apache/cloudstack/pull/3902#issuecomment-643066463 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack] branch master updated (9beec48 -> a9175d3)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 9beec48 docker: upgrade to ubuntu 18.04 and fix two issues (#3955) add 8b234bd kvm: fix CloudRuntimeException in volume stats for migrated volume (#3949) add 4659cff Merge remote-tracking branch 'origin/4.13' into 4.14 add a9175d3 Merge remote-tracking branch 'origin/4.14' No new revisions were added by this update. Summary of changes: .../kvm/resource/wrapper/LibvirtGetVolumeStatsCommandWrapper.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
[cloudstack] branch 4.14 updated (43cb781 -> 4659cff)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch 4.14 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 43cb781 Merge remote-tracking branch 'origin/4.13' into 4.14 add 8b234bd kvm: fix CloudRuntimeException in volume stats for migrated volume (#3949) new 4659cff Merge remote-tracking branch 'origin/4.13' into 4.14 The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../kvm/resource/wrapper/LibvirtGetVolumeStatsCommandWrapper.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
[cloudstack] 01/01: Merge remote-tracking branch 'origin/4.13' into 4.14
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch 4.14 in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit 4659cff59703458af8a817e17b176aaff1648445 Merge: 43cb781 8b234bd Author: Rohit Yadav AuthorDate: Fri Jun 12 10:38:30 2020 +0530 Merge remote-tracking branch 'origin/4.13' into 4.14 .../kvm/resource/wrapper/LibvirtGetVolumeStatsCommandWrapper.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
[GitHub] [cloudstack] rhtyd commented on pull request #3730: Update VR's scripts from python2 to python3
rhtyd commented on pull request #3730: URL: https://github.com/apache/cloudstack/pull/3730#issuecomment-643067101 @GabrielBrascher any update for us, you still working on this? Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #3595: [WIP DO NOT MERGE] KVM dynamic VM scaling
rhtyd commented on pull request #3595: URL: https://github.com/apache/cloudstack/pull/3595#issuecomment-643067266 Okay @nvazquez keep me posted when this is ready for review. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd closed pull request #3881: Deploy VM add host gpu device available check
rhtyd closed pull request #3881: URL: https://github.com/apache/cloudstack/pull/3881 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3902: vrouter: Save PlaceHolder nic for VR if network does not have source nat
blueorangutan commented on pull request #3902: URL: https://github.com/apache/cloudstack/pull/3902#issuecomment-643066680 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3944: vpc/server: Fix network statistics for vpc
blueorangutan commented on pull request #3944: URL: https://github.com/apache/cloudstack/pull/3944#issuecomment-643066450 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd closed pull request #3902: vrouter: Save PlaceHolder nic for VR if network does not have source nat
rhtyd closed pull request #3902: URL: https://github.com/apache/cloudstack/pull/3902 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #3900: systemvm: configurable root disk size based on new systemvm template definition
rhtyd commented on pull request #3900: URL: https://github.com/apache/cloudstack/pull/3900#issuecomment-643066572 @ustcweizhou do we want this for master/4.15+? Can you fix conflicts? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] ustcweizhou opened a new pull request #3902: vrouter: Save PlaceHolder nic for VR if network does not have source nat
ustcweizhou opened a new pull request #3902: URL: https://github.com/apache/cloudstack/pull/3902 ## Description This PR aims to fix the issue below 1. Create a network offering for isolated network, services: Dns/Dhcp/Userdata, and enable it 2. create a isolated network with the new offering 3. create a vm 4. check the guest IP of virtual router, 5. restart network with cleanup 6. check the guest IP of new virtual router 7. The IP in step4 and step6 should be the same, but they are different actually. ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [X] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## Screenshots (if appropriate): ## How Has This Been Tested? tested with steps above, the IPs are same in step 7. change network to another offering with public ip, the placeholder ip is removed from database. tested with shared networks and L2 network as well. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack] branch 4.13 updated: kvm: fix CloudRuntimeException in volume stats for migrated volume (#3949)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch 4.13 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.13 by this push: new 8b234bd kvm: fix CloudRuntimeException in volume stats for migrated volume (#3949) 8b234bd is described below commit 8b234bd14feeaf47b665be825dd0ecfa8f65c401 Author: slavkap <51903378+slav...@users.noreply.github.com> AuthorDate: Fri Jun 12 08:02:01 2020 +0300 kvm: fix CloudRuntimeException in volume stats for migrated volume (#3949) When you migrate volume between data stores CS keeps the original UUID and changes the path of the volume. When volume is not found by the given path the agent throws CloudRuntimeException but it's not catched in LibvirtGetVolumeStatsCommandWrapper.java --- .../kvm/resource/wrapper/LibvirtGetVolumeStatsCommandWrapper.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtGetVolumeStatsCommandWrapper.java b/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtGetVolumeStatsCommandWrapper.java index 6d945b1..00bdfcd 100644 --- a/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtGetVolumeStatsCommandWrapper.java +++ b/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtGetVolumeStatsCommandWrapper.java @@ -33,6 +33,7 @@ import com.cloud.hypervisor.kvm.storage.KVMStoragePool; import com.cloud.resource.CommandWrapper; import com.cloud.resource.ResourceWrapper; import com.cloud.storage.Storage.StoragePoolType; +import com.cloud.utils.exception.CloudRuntimeException; import com.cloud.agent.api.GetVolumeStatsAnswer; import com.cloud.agent.api.GetVolumeStatsCommand; import com.cloud.agent.api.VolumeStatsEntry; @@ -52,7 +53,7 @@ public final class LibvirtGetVolumeStatsCommandWrapper extends CommandWrapper
[GitHub] [cloudstack] rhtyd commented on pull request #3944: vpc/server: Fix network statistics for vpc
rhtyd commented on pull request #3944: URL: https://github.com/apache/cloudstack/pull/3944#issuecomment-643066318 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #3949: Fix: catch CloudRuntimeException in LibvirtGetVolumeStatsCommandWrapper.java
rhtyd merged pull request #3949: URL: https://github.com/apache/cloudstack/pull/3949 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #3955: docker: upgrade to ubuntu 18.04 and fix some issues
rhtyd commented on pull request #3955: URL: https://github.com/apache/cloudstack/pull/3955#issuecomment-643065675 This cannot be checked without docker building the dockerfile, we've enough +1/lgtm/thumbsup so I'll merge this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack] branch master updated (6e47c49 -> 9beec48)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 6e47c49 server: Fix String.format arguments (#3980) add 9beec48 docker: upgrade to ubuntu 18.04 and fix two issues (#3955) No new revisions were added by this update. Summary of changes: tools/docker/Dockerfile | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
[GitHub] [cloudstack] rhtyd merged pull request #3955: docker: upgrade to ubuntu 18.04 and fix some issues
rhtyd merged pull request #3955: URL: https://github.com/apache/cloudstack/pull/3955 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #3976: [Do not merge] Enable sending hypervior host name via metadata - VR and Config Drive
rhtyd commented on pull request #3976: URL: https://github.com/apache/cloudstack/pull/3976#issuecomment-643065386 @borisstoyanov @vladimirpetrov has this passed testing, is it ready for review and merge? Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #3980: Fix String.format unused/misused arguments
rhtyd commented on pull request #3980: URL: https://github.com/apache/cloudstack/pull/3980#issuecomment-643065113 This is purely logging change, Travis has passed we don't need explicit smoketests for this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #3980: Fix String.format unused/misused arguments
rhtyd merged pull request #3980: URL: https://github.com/apache/cloudstack/pull/3980 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack] branch master updated (9727548 -> 6e47c49)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 9727548 kvm: Add support for DPDK trunk interfaces (#4048) add 6e47c49 server: Fix String.format arguments (#3980) No new revisions were added by this update. Summary of changes: .../main/java/com/cloud/baremetal/manager/BareMetalDiscoverer.java | 2 +- .../java/org/apache/cloudstack/api/command/LdapListUsersCmd.java| 6 +++--- .../src/main/java/org/apache/cloudstack/vm/VmImportManagerImpl.java | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-)
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #3980: Fix String.format unused/misused arguments
blueorangutan removed a comment on pull request #3980: URL: https://github.com/apache/cloudstack/pull/3980#issuecomment-605387706 Trillian test result (tid-1330) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 58457 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3980-t1330-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_global_settings.py Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py Intermittent failure detected: /marvin/tests/smoke/test_routers.py Intermittent failure detected: /marvin/tests/smoke/test_secondary_storage.py Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py Intermittent failure detected: /marvin/tests/smoke/test_templates.py Intermittent failure detected: /marvin/tests/smoke/test_usage.py Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py Intermittent failure detected: /marvin/tests/smoke/test_volumes.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py Smoke tests completed. 53 look OK, 24 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_UpdateConfigParamWithScope | `Error` | 0.06 | test_global_settings.py test_02_vpc_privategw_static_routes | `Failure` | 120.55 | test_privategw_acl.py test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 120.63 | test_privategw_acl.py test_04_rvpc_privategw_static_routes | `Failure` | 174.61 | test_privategw_acl.py ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py ContextSuite context=TestRAMCPUResourceAccounting>:setup | `Error` | 0.00 | test_resource_accounting.py ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py test_01_sys_vm_start | `Failure` | 0.06 | test_secondary_storage.py ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py ContextSuite context=TestIsolatedNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py ContextSuite context=TestServiceOfferings>:setup | `Error` | 0.14 | test_service_offerings.py ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py test_01_list_sec_storage_vm | `Failure` | 0.02 | test_ssvm.py test_02_list_cpvm_vm | `Failure` | 0.02 | test_ssvm.py test_03_ssvm_internals | `Failure` | 0.02 | test_ssvm.py test_04_cpvm_internals | `Failure` | 0.02 | test_ssvm.py test_05_stop_ssvm | `Failure` | 0.02 | test_ssvm.py test_06_stop_cpvm | `Failure` | 0.02 | test_ssvm.py test_07_reboot_ssvm | `Failure` | 0.06 | test_ssvm.py test_08_reboot_cpvm | `Failure` | 0.02 | test_ssvm.py test_09_destroy_ssvm | `Failure` | 0.02 | test_ssvm.py test_10_destroy_cpvm | `Failure` | 0.02 | test_ssvm.py test_02_create_template_with_checksum_sha1 | `Error` | 65.31 | test_templates.py test_03_create_template_with_checksum_sha256
[GitHub] [cloudstack] rhtyd commented on pull request #3982: Updated 3 error messages to replace the word 'matches' with 'match'
rhtyd commented on pull request #3982: URL: https://github.com/apache/cloudstack/pull/3982#issuecomment-643064753 Let's merge this once Travis passes Fixes #3642 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3998: NPE when VM is planned to migrate to other host during dynamic scaling
blueorangutan commented on pull request #3998: URL: https://github.com/apache/cloudstack/pull/3998#issuecomment-643064253 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd edited a comment on pull request #3991: Multiple dynamic VM Scaling APIs can create duplicate usage events for the same time
rhtyd edited a comment on pull request #3991: URL: https://github.com/apache/cloudstack/pull/3991#issuecomment-643064218 @harikrishna-patnala @borisstoyanov - is this ready for merge post-testing, if we do a final review? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #3991: Multiple dynamic VM Scaling APIs can create duplicate usage events for the same time
rhtyd commented on pull request #3991: URL: https://github.com/apache/cloudstack/pull/3991#issuecomment-643064218 @harikrishna-patnala @borisstoyanov - is this ready for merge post-testing, if we a final review? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd closed pull request #3991: Multiple dynamic VM Scaling APIs can create duplicate usage events for the same time
rhtyd closed pull request #3991: URL: https://github.com/apache/cloudstack/pull/3991 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #3998: NPE when VM is planned to migrate to other host during dynamic scaling
rhtyd commented on pull request #3998: URL: https://github.com/apache/cloudstack/pull/3998#issuecomment-643063895 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4003: Logging framework to use only log4j
blueorangutan commented on pull request #4003: URL: https://github.com/apache/cloudstack/pull/4003#issuecomment-643063430 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4004: Fixed null pointer and deployment issue on Xenserver with L2 Guest network with configDrive
blueorangutan commented on pull request #4004: URL: https://github.com/apache/cloudstack/pull/4004#issuecomment-643063507 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4000: vm: Reset deviceId to fix missing nic with vm
rhtyd commented on pull request #4000: URL: https://github.com/apache/cloudstack/pull/4000#issuecomment-643063586 @ustcweizhou please check and address Travis failures This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #4001: server: Dedicated hosts should be 'Not Suitable' while find host for m migration
rhtyd commented on a change in pull request #4001: URL: https://github.com/apache/cloudstack/pull/4001#discussion_r439205308 ## File path: server/src/main/java/com/cloud/server/ManagementServerImpl.java ## @@ -1321,6 +1321,11 @@ private HypervisorType getHypervisorType(VMInstanceVO vm, StoragePool srcVolumeP } } +if (vm.getType() == VirtualMachine.Type.User || vm.getType() == VirtualMachine.Type.DomainRouter) { Review comment: @ustcweizhou what about other systemvms? CPVM, SSVM, ILB etc? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4004: Fixed null pointer and deployment issue on Xenserver with L2 Guest network with configDrive
rhtyd commented on pull request #4004: URL: https://github.com/apache/cloudstack/pull/4004#issuecomment-643063124 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4032: Suspending the VM prior to deleting snapshots to avoid corruption, th…
blueorangutan commented on pull request #4032: URL: https://github.com/apache/cloudstack/pull/4032#issuecomment-643063240 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4003: Logging framework to use only log4j
blueorangutan removed a comment on pull request #4003: URL: https://github.com/apache/cloudstack/pull/4003#issuecomment-641691692 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4007: Restarting all networks that needs a restart in a VPC
blueorangutan commented on pull request #4007: URL: https://github.com/apache/cloudstack/pull/4007#issuecomment-643063177 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4003: Logging framework to use only log4j
rhtyd commented on pull request #4003: URL: https://github.com/apache/cloudstack/pull/4003#issuecomment-643063307 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4007: Restarting all networks that needs a restart in a VPC
blueorangutan removed a comment on pull request #4007: URL: https://github.com/apache/cloudstack/pull/4007#issuecomment-641544436 Trillian test result (tid-1653) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 60402 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4007-t1653-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_nic.py Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py Intermittent failure detected: /marvin/tests/smoke/test_routers.py Intermittent failure detected: /marvin/tests/smoke/test_secondary_storage.py Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py Intermittent failure detected: /marvin/tests/smoke/test_templates.py Intermittent failure detected: /marvin/tests/smoke/test_usage.py Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py Intermittent failure detected: /marvin/tests/smoke/test_volumes.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py Smoke tests completed. 54 look OK, 23 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_nic | `Error` | 51.24 | test_nic.py test_02_vpc_privategw_static_routes | `Failure` | 178.85 | test_privategw_acl.py test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 181.39 | test_privategw_acl.py test_04_rvpc_privategw_static_routes | `Failure` | 239.51 | test_privategw_acl.py ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py ContextSuite context=TestRAMCPUResourceAccounting>:setup | `Error` | 0.00 | test_resource_accounting.py ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py test_01_sys_vm_start | `Failure` | 0.08 | test_secondary_storage.py ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py ContextSuite context=TestIsolatedNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py ContextSuite context=TestServiceOfferings>:setup | `Error` | 0.17 | test_service_offerings.py ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py test_01_list_sec_storage_vm | `Failure` | 0.03 | test_ssvm.py test_02_list_cpvm_vm | `Failure` | 0.03 | test_ssvm.py test_03_ssvm_internals | `Failure` | 0.03 | test_ssvm.py test_04_cpvm_internals | `Failure` | 0.04 | test_ssvm.py test_05_stop_ssvm | `Failure` | 0.03 | test_ssvm.py test_06_stop_cpvm | `Failure` | 0.03 | test_ssvm.py test_07_reboot_ssvm | `Failure` | 0.03 | test_ssvm.py test_08_reboot_cpvm | `Failure` | 0.03 | test_ssvm.py test_09_destroy_ssvm | `Failure` | 0.03 | test_ssvm.py test_10_destroy_cpvm | `Failure` | 0.02 | test_ssvm.py test_02_create_template_with_checksum_sha1 | `Error` | 66.94 | test_templates.py test_03_create_template_with_checksum_sha256 | `Error` | 66.71 | test_templates.py test_04_create_template_with_checksum_md5 | `Error` | 65.99 | test_templates.py
[GitHub] [cloudstack] rhtyd commented on pull request #4007: Restarting all networks that needs a restart in a VPC
rhtyd commented on pull request #4007: URL: https://github.com/apache/cloudstack/pull/4007#issuecomment-643063051 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4032: Suspending the VM prior to deleting snapshots to avoid corruption, th…
rhtyd commented on pull request #4032: URL: https://github.com/apache/cloudstack/pull/4032#issuecomment-643062751 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4040: [KVM] Enable PVLAN support on L2 networks
rhtyd commented on pull request #4040: URL: https://github.com/apache/cloudstack/pull/4040#issuecomment-643062600 Is this ready for review, and can it be merged after review @davidjumani @borisstoyanov ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack] branch master updated (195385f -> 9727548)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 195385f ui: Allow set IPv6 when deploying advanced network Zone with SG via UI (#4083) add 9727548 kvm: Add support for DPDK trunk interfaces (#4048) No new revisions were added by this update. Summary of changes: .../main/java/com/cloud/hypervisor/kvm/dpdk/DpdkDriverImpl.java | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-)
[GitHub] [cloudstack] rhtyd merged pull request #4048: Update DpdkDriverImpl.java to support DPDK trunk interfaces
rhtyd merged pull request #4048: URL: https://github.com/apache/cloudstack/pull/4048 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4048: Update DpdkDriverImpl.java to support DPDK trunk interfaces
rhtyd commented on pull request #4048: URL: https://github.com/apache/cloudstack/pull/4048#issuecomment-643062351 Travis has passed, our smoketests test only kvm with bridge driver. Merging based on this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4073: Display network name for IP in shared networks
blueorangutan commented on pull request #4073: URL: https://github.com/apache/cloudstack/pull/4073#issuecomment-643061449 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4071: Dynamic roles improvements
rhtyd commented on pull request #4071: URL: https://github.com/apache/cloudstack/pull/4071#issuecomment-643061308 Thanks @sureshanaparti I'll do another review pass and ping you. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4075: Search VR using redundant state
blueorangutan commented on pull request #4075: URL: https://github.com/apache/cloudstack/pull/4075#issuecomment-643061192 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd closed pull request #4073: Display network name for IP in shared networks
rhtyd closed pull request #4073: URL: https://github.com/apache/cloudstack/pull/4073 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4073: Display network name for IP in shared networks
rhtyd commented on pull request #4073: URL: https://github.com/apache/cloudstack/pull/4073#issuecomment-643061185 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4075: Search VR using redundant state
rhtyd commented on pull request #4075: URL: https://github.com/apache/cloudstack/pull/4075#issuecomment-643061078 Business layer change, explicit smoketests not necessary as Travis passed. @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4083: Allow set IPv6 when deploying advanced network Zone with SG via UI
rhtyd merged pull request #4083: URL: https://github.com/apache/cloudstack/pull/4083 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack] branch master updated (9361fef -> 195385f)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 9361fef Merge remote-tracking branch 'origin/4.14' add 195385f ui: Allow set IPv6 when deploying advanced network Zone with SG via UI (#4083) No new revisions were added by this update. Summary of changes: ui/scripts/zoneWizard.js | 38 -- 1 file changed, 36 insertions(+), 2 deletions(-)
[GitHub] [cloudstack] blueorangutan commented on pull request #4085: Fix duplicate user entries for vpn usage
blueorangutan commented on pull request #4085: URL: https://github.com/apache/cloudstack/pull/4085#issuecomment-643060512 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4117: [VMware] Explicitly controlling VM hardware version
blueorangutan commented on pull request #4117: URL: https://github.com/apache/cloudstack/pull/4117#issuecomment-643060324 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #4084: Added nfs minor version support on SSVM
rhtyd commented on a change in pull request #4084: URL: https://github.com/apache/cloudstack/pull/4084#discussion_r439202556 ## File path: plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java ## @@ -831,8 +832,12 @@ protected String mount(String path, String parent, Integer nfsVersion) { String result = null; Script command = new Script(true, "mount", _timeout, s_logger); command.add("-t", "nfs"); -if (nfsVersion != null){ -command.add("-o", "vers=" + nfsVersion); +if (nfsMajorVersion != null){ +String nfsVersion = "vers=" + nfsMajorVersion; +if (nfsMinorVersion != null && nfsMajorVersion >= 4) { Review comment: @Spaceman1984 why not simply pass the version (a single variable) than two? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4122: Maximum data volumes limit is picked from "default" version of hypervisor, instead of actual hypervisor version
blueorangutan commented on pull request #4122: URL: https://github.com/apache/cloudstack/pull/4122#issuecomment-643060393 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4103: [VMware] Enable unmanaging guest VMs
rhtyd commented on pull request #4103: URL: https://github.com/apache/cloudstack/pull/4103#issuecomment-643060179 Is this ready for review @nvazquez ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4117: [VMware] Explicitly controlling VM hardware version
rhtyd commented on pull request #4117: URL: https://github.com/apache/cloudstack/pull/4117#issuecomment-643060060 @blueorangutan test centos7 vmware-67u3 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4085: Fix duplicate user entries for vpn usage
rhtyd commented on pull request #4085: URL: https://github.com/apache/cloudstack/pull/4085#issuecomment-643060225 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4132: Fix delete network with no services
blueorangutan commented on pull request #4132: URL: https://github.com/apache/cloudstack/pull/4132#issuecomment-643060041 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4122: Maximum data volumes limit is picked from "default" version of hypervisor, instead of actual hypervisor version
rhtyd commented on pull request #4122: URL: https://github.com/apache/cloudstack/pull/4122#issuecomment-643059963 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4132: Fix delete network with no services
rhtyd commented on pull request #4132: URL: https://github.com/apache/cloudstack/pull/4132#issuecomment-643059845 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.
blueorangutan commented on pull request #4137: URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-643059824 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.
rhtyd commented on pull request #4137: URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-643059727 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack] branch master updated (e02801b -> 9361fef)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from e02801b xenserver: add support for XCP-ng 7/8 to create it's heartbeat LVM properly (#4109) add f433db9 ui: Invalid character encountered in file ui/l10n/pt_BR.js at line 1134 for encoding UTF-8. (#4142) add 43cb781 Merge remote-tracking branch 'origin/4.13' into 4.14 new 9361fef Merge remote-tracking branch 'origin/4.14' The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: ui/l10n/pt_BR.js | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-)
[cloudstack] 01/01: Merge remote-tracking branch 'origin/4.14'
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit 9361fef20fc1e1028675240ce3fc1e93b3971d21 Merge: e02801b 43cb781 Author: Rohit Yadav AuthorDate: Fri Jun 12 10:01:42 2020 +0530 Merge remote-tracking branch 'origin/4.14' ui/l10n/pt_BR.js | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-)
[cloudstack] branch 4.14 updated (50f0488 -> 43cb781)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch 4.14 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 50f0488 Merge remote-tracking branch 'origin/4.13' into 4.14 add f433db9 ui: Invalid character encountered in file ui/l10n/pt_BR.js at line 1134 for encoding UTF-8. (#4142) new 43cb781 Merge remote-tracking branch 'origin/4.13' into 4.14 The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: ui/l10n/pt_BR.js | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-)
[cloudstack] 01/01: Merge remote-tracking branch 'origin/4.13' into 4.14
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch 4.14 in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit 43cb781d3b284993b107bde532f68e668a061df3 Merge: 50f0488 f433db9 Author: Rohit Yadav AuthorDate: Fri Jun 12 09:59:36 2020 +0530 Merge remote-tracking branch 'origin/4.13' into 4.14 ui/l10n/pt_BR.js | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --cc ui/l10n/pt_BR.js index d3969a3,b3aacfb..eb5a290 --- a/ui/l10n/pt_BR.js +++ b/ui/l10n/pt_BR.js @@@ -1849,9 -1847,8 +1849,9 @@@ var dictionary = "message.action.delete.zone": "Confirme que você deseja remover esta Zona.", "message.action.destroy.instance": "Por favor, confirme que você deseja excluir esta Instância.", "message.action.destroy.systemvm": "Confirme que você deseja excluir esta VM de Sistema.", +"message.action.destroy.volume":"Please confirm that you want to destroy this volume.", "message.action.disable.cluster": "Confirma a desativação do cluster.", - "message.action.disable.nexusVswitch": "Por favor confirme que voc� deseja desabilitar este nexusVswitch", + "message.action.disable.nexusVswitch": "Por favor confirme que você deseja desabilitar este nexusVswitch", "message.action.disable.physical.network": "Por favor confirme que você deseja desabilitar esta rede física.", "message.action.disable.pod": "Confirma a desativação do POD.", "message.action.disable.static.NAT": "Confirme que você deseja desativar o NAT Estático.", @@@ -1872,9 -1869,8 +1872,9 @@@ "message.action.manage.cluster": "Confirma a vinculação do cluster.", "message.action.primarystorage.enable.maintenance.mode": "Aviso: Colocar o Storage primário em modo de Manutenção irá causar a parada de todas as VMs hospedadas nesta unidade. Deseja continuar?", "message.action.reboot.instance": "Por favor, confirme que você deseja reiniciar esta instância.", - "message.action.reboot.router": "Confirme que voc� deseja reiniciar este roteador.", + "message.action.reboot.router": "Confirme que você deseja reiniciar este roteador.", "message.action.reboot.systemvm": "Confirme que você deseja reiniciar esta VM de sistema.", +"message.action.recover.volume":"Please confirm that you would like to recover this volume.", "message.action.release.ip": "Confirme que você deseja liberar este IP.", "message.action.remove.host": "Favor confirmar que você deseja remover este host.", "message.action.reset.password.off": "Sua Instância não suporta esta funcionalidade.",
[GitHub] [cloudstack] blueorangutan commented on pull request #3976: [Do not merge] Enable sending hypervior host name via metadata - VR and Config Drive
blueorangutan commented on pull request #3976: URL: https://github.com/apache/cloudstack/pull/3976#issuecomment-643052235 @Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #3976: [Do not merge] Enable sending hypervior host name via metadata - VR and Config Drive
Pearl1594 commented on pull request #3976: URL: https://github.com/apache/cloudstack/pull/3976#issuecomment-643052043 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4071: Dynamic roles improvements
sureshanaparti commented on a change in pull request #4071: URL: https://github.com/apache/cloudstack/pull/4071#discussion_r439191916 ## File path: engine/schema/src/main/resources/META-INF/db/schema-41400to41500.sql ## @@ -18,3 +18,81 @@ --; -- Schema upgrade from 4.14.0.0 to 4.15.0.0 --; + +ALTER TABLE `cloud`.`roles` ADD COLUMN `is_default` tinyint(1) NOT NULL DEFAULT '0' COMMENT 'is this a default role'; +UPDATE `cloud`.`roles` SET `is_default` = 1 WHERE id IN (1, 2, 3, 4); + +-- Updated Default CloudStack roles with read-only and support admin and user roles +INSERT INTO `cloud`.`roles` (`uuid`, `name`, `role_type`, `description`, `is_default`) VALUES (UUID(), 'Read-Only Admin', 'Admin', 'Default read-only admin role', 1) ON DUPLICATE KEY UPDATE name=name; +INSERT INTO `cloud`.`roles` (`uuid`, `name`, `role_type`, `description`, `is_default`) VALUES (UUID(), 'Read-Only User', 'User', 'Default read-only user role', 1) ON DUPLICATE KEY UPDATE name=name; +INSERT INTO `cloud`.`roles` (`uuid`, `name`, `role_type`, `description`, `is_default`) VALUES (UUID(), 'Admin-Support', 'Admin', 'Default admin support role', 1) ON DUPLICATE KEY UPDATE name=name; +INSERT INTO `cloud`.`roles` (`uuid`, `name`, `role_type`, `description`, `is_default`) VALUES (UUID(), 'User-Support', 'User', 'Default user support role', 1) ON DUPLICATE KEY UPDATE name=name; + +-- Role permissions for Read-Only Admin +SELECT id INTO @ReadOnlyAdminRoleId FROM `cloud`.`roles` WHERE name = 'Read-Only Admin' AND is_default = 1; +SELECT @ReadOnlyAdminSortOrder:=-1; Review comment: @rhtyd Moved permissions update to the Upgrade* class. Please check. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd edited a comment on issue #4143: The internal instance name is returned for non-root admin in listVirtualMachineMetrics API
rhtyd edited a comment on issue #4143: URL: https://github.com/apache/cloudstack/issues/4143#issuecomment-643018505 Np @onitake - not really because root admin should be able to know more infrastructure specific information, for example the host where the VM is running on but not to the normal user. Because of this, we need to return information for root admin for many APIs, but not for users. The asymmetrical response is a feature. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on issue #4143: The internal instance name is returned for non-root admin in listVirtualMachineMetrics API
rhtyd commented on issue #4143: URL: https://github.com/apache/cloudstack/issues/4143#issuecomment-643018505 Np @onitake - not really because root admin should be able to know more infrastructure specific information, for example the host where the VM is running on but not to the normal user. Because of this, we need to return information for root admin for many APIs, but not for users. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4071: Dynamic roles improvements
blueorangutan commented on pull request #4071: URL: https://github.com/apache/cloudstack/pull/4071#issuecomment-642941492 Trillian test result (tid-1674) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 48018 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4071-t1674-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py Smoke tests completed. 82 look OK, 1 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 347.44 | test_vpc_redundant.py test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 342.00 | test_vpc_redundant.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] div8cn opened a new pull request #4144: Fix Usage failed to get pid
div8cn opened a new pull request #4144: URL: https://github.com/apache/cloudstack/pull/4144 ## Description cloudstack-usage use System.getProperty("pid") to get the process PID System.getProperty cannot get the Pid, which will cause the service to stay in the config stage. Cannot continue to start, and there will be no log output. This PR uses ManagementFactory instead of System.getProperty to get Pid, and throws an exception when Pid cannot be obtained ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## Screenshots (if appropriate): ## How Has This Been Tested? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] onitake commented on issue #4143: The internal instance name is returned for non-root admin in listVirtualMachineMetrics API
onitake commented on issue #4143: URL: https://github.com/apache/cloudstack/issues/4143#issuecomment-642713882 Sorry @rhtyd , I didn't see that you were talking about two different API calls. My point wasn't about the asymmetry between listVirtualMachineMetrics and listVirtualMachines, but between root and non-root. Wouldn't it be cleaner to return the same set of values for all types of users? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4142: Invalid character encountered in file ui/l10n/pt_BR.js at line 1134 for encoding UTF-8.
rhtyd merged pull request #4142: URL: https://github.com/apache/cloudstack/pull/4142 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack] branch 4.13 updated: ui: Invalid character encountered in file ui/l10n/pt_BR.js at line 1134 for encoding UTF-8. (#4142)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch 4.13 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.13 by this push: new f433db9 ui: Invalid character encountered in file ui/l10n/pt_BR.js at line 1134 for encoding UTF-8. (#4142) f433db9 is described below commit f433db98818049b7d1215b0f478895412bd56858 Author: Wei Zhou AuthorDate: Thu Jun 11 16:08:58 2020 +0200 ui: Invalid character encountered in file ui/l10n/pt_BR.js at line 1134 for encoding UTF-8. (#4142) --- ui/l10n/pt_BR.js | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/ui/l10n/pt_BR.js b/ui/l10n/pt_BR.js index 43f7252..b3aacfb 100644 --- a/ui/l10n/pt_BR.js +++ b/ui/l10n/pt_BR.js @@ -1129,7 +1129,7 @@ var dictionary = { "label.network.device": "Dispositivo de Rede", "label.network.device.type": "Tipo de Dispositivo de Rede", "label.network.domain": "Domínio de Rede", -"label.network.domain.text": "Texto do dom�nio de rede", +"label.network.domain.text": "Texto do domínio de rede", "label.network.id": "ID de Rede", "label.network.label.display.for.blank.value": "Utilizar gateway default", "label.network.limits": "Limites de rede", @@ -1831,7 +1831,7 @@ var dictionary = { "message.action.delete.external.load.balancer": "Confirme que você gostaria de remover este Load Balancer Externo. Aviso: Se você Está planejando adicionar novamente este mesmo Load Balancer, é necessário apagar os contadores do dispositivo.", "message.action.delete.ingress.rule": "Confirme que você deseja excluir esta regra de entrada.", "message.action.delete.network": "Confirme que você deseja remover esta rede.", -"message.action.delete.nexusVswitch": "Por favor confirme que voc� deseja remover este nexusVswitch.", +"message.action.delete.nexusVswitch": "Por favor confirme que você deseja remover este nexusVswitch.", "message.action.delete.nic": "Por favor, confirme que deseja remover esta Interface de Rede, esta ação também irá remover a rede associada à VM.", "message.action.delete.physical.network": "Por favor confirme que você deseja deletar esta rede física", "message.action.delete.pod": "Confirme que você deseja remover este POD.", @@ -1848,7 +1848,7 @@ var dictionary = { "message.action.destroy.instance": "Por favor, confirme que você deseja excluir esta Instância.", "message.action.destroy.systemvm": "Confirme que você deseja excluir esta VM de Sistema.", "message.action.disable.cluster": "Confirma a desativação do cluster.", -"message.action.disable.nexusVswitch": "Por favor confirme que voc� deseja desabilitar este nexusVswitch", +"message.action.disable.nexusVswitch": "Por favor confirme que você deseja desabilitar este nexusVswitch", "message.action.disable.physical.network": "Por favor confirme que você deseja desabilitar esta rede física.", "message.action.disable.pod": "Confirma a desativação do POD.", "message.action.disable.static.NAT": "Confirme que você deseja desativar o NAT Estático.", @@ -1858,7 +1858,7 @@ var dictionary = { "message.action.downloading.template": "Baixando template", "message.action.enable.cluster": "Confirma a ativação do cluster.", "message.action.enable.maintenance": "O Host foi preparado com sucesso para Manutenção. Este processo poderá levar alguns minutos ou mais dependendo do número de VMs hospedadas neste Host.", -"message.action.enable.nexusVswitch": "Por favor confirme que voc� deseja habilitar este nexusVswitch.", +"message.action.enable.nexusVswitch": "Por favor confirme que você deseja habilitar este nexusVswitch.", "message.action.enable.physical.network": "Por favor confirme que você deseja habilitar esta rede física.", "message.action.enable.pod": "Confirma a ativação do POD.", "message.action.enable.zone": "Confirma a ativação da zona.", @@ -1869,7 +1869,7 @@ var dictionary = { "message.action.manage.cluster": "Confirma a vinculação do cluster.", "message.action.primarystorage.enable.maintenance.mode": "Aviso: Colocar o Storage primário em modo de Manutenção irá causar a parada de todas as VMs hospedadas nesta unidade. Deseja continuar?", "message.action.reboot.instance": "Por favor, confirme que você deseja reiniciar esta instância.", -"message.action.reboot.router": "Confirme que voc� deseja reiniciar este roteador.", +"message.action.reboot.router": "Confirme que você deseja reiniciar este roteador.", "message.action.reboot.systemvm": "Confirme que você deseja reiniciar esta VM de sistema.", "message.action.release.ip": "Confirme que você deseja liberar este IP.", "message.action.remove.host": "Favor confirmar que você deseja remover este host.", @@ -1881,7 +1881,7 @@ var dictionary = { "message.action.start.router": "Confirme que
[GitHub] [cloudstack] ggoodrich-ipp commented on pull request #4032: Suspending the VM prior to deleting snapshots to avoid corruption, th…
ggoodrich-ipp commented on pull request #4032: URL: https://github.com/apache/cloudstack/pull/4032#issuecomment-642671150 > @ggoodrich-ipp can you fix the conflicts, thanks. Conflicts resolved. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3998: NPE when VM is planned to migrate to other host during dynamic scaling
blueorangutan commented on pull request #3998: URL: https://github.com/apache/cloudstack/pull/3998#issuecomment-642615520 Packaging result: ✔centos7 ✔debian. JID-1349 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on issue #4143: The internal instance name is returned for non-root admin in listVirtualMachineMetrics API
rhtyd commented on issue #4143: URL: https://github.com/apache/cloudstack/issues/4143#issuecomment-642613162 @onitake you're repeating the bug-report, sorry I didn't get your point? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4122: Maximum data volumes limit is picked from "default" version of hypervisor, instead of actual hypervisor version
blueorangutan commented on pull request #4122: URL: https://github.com/apache/cloudstack/pull/4122#issuecomment-642613279 Packaging result: ✔centos7 ✔debian. JID-1348 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4019: server: Move restoreVM to vm work job queue
weizhouapache commented on pull request #4019: URL: https://github.com/apache/cloudstack/pull/4019#issuecomment-642605420 rebased with latest 4.14 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4001: server: Dedicated hosts should be 'Not Suitable' while find host for m migration
weizhouapache commented on pull request #4001: URL: https://github.com/apache/cloudstack/pull/4001#issuecomment-642603642 @rhtyd @DaanHoogland I missed Daan's comment. steps for manual test (1) login as root admin, (2) dedicate a host H to account A (3) migrate a vm of account B, the host H is suitable. it should be "Not Suitable" it is an issue with api findHostsForMigration. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3998: NPE when VM is planned to migrate to other host during dynamic scaling
blueorangutan commented on pull request #3998: URL: https://github.com/apache/cloudstack/pull/3998#issuecomment-64262 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4001: server: Dedicated hosts should be 'Not Suitable' while find host for m migration
rhtyd commented on pull request #4001: URL: https://github.com/apache/cloudstack/pull/4001#issuecomment-642598944 Ping @ustcweizhou - can you respond to Daan's comment? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org