[GitHub] [cloudstack] blueorangutan commented on pull request #4128: Role based users in Projects
blueorangutan commented on pull request #4128: URL: https://github.com/apache/cloudstack/pull/4128#issuecomment-655883983 Trillian test result (tid-2037) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 47034 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4128-t2037-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_enable_role_based_users_in_projects.py Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Smoke tests completed. 83 look OK, 1 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_add_user_to_project_with_project_role | `Error` | 1.49 | test_enable_role_based_users_in_projects.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support
blueorangutan commented on pull request #4068: URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-655810252 Trillian test result (tid-2035) Environment: kvm-centos8 (x2), Advanced Networking with Mgmt server 8 Total time taken: 43356 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4068-t2035-kvm-centos8.zip Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py Smoke tests completed. 82 look OK, 1 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_deploy_kubernetes_cluster | `Error` | 3619.74 | test_kubernetes_clusters.py test_02_deploy_kubernetes_ha_cluster | `Error` | 0.06 | test_kubernetes_clusters.py test_04_deploy_and_upgrade_kubernetes_cluster | `Error` | 130.26 | test_kubernetes_clusters.py test_05_deploy_and_upgrade_kubernetes_ha_cluster | `Error` | 0.05 | test_kubernetes_clusters.py test_06_deploy_and_invalid_upgrade_kubernetes_cluster | `Error` | 0.05 | test_kubernetes_clusters.py test_07_deploy_and_scale_kubernetes_cluster | `Error` | 0.04 | test_kubernetes_clusters.py ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 35.80 | test_kubernetes_clusters.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4116: cks: fix template, deployment issues
blueorangutan commented on pull request #4116: URL: https://github.com/apache/cloudstack/pull/4116#issuecomment-655806907 @shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4116: cks: fix template, deployment issues
shwstppr commented on pull request #4116: URL: https://github.com/apache/cloudstack/pull/4116#issuecomment-655806567 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4116: cks: fix template, deployment issues
blueorangutan commented on pull request #4116: URL: https://github.com/apache/cloudstack/pull/4116#issuecomment-655804069 Packaging result: ✔centos7 ✔debian. JID-1562 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4156: Fixed removal of hosts from certsmap when running certificate auto-renew
blueorangutan commented on pull request #4156: URL: https://github.com/apache/cloudstack/pull/4156#issuecomment-655764802 Trillian test result (tid-2034) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 1 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4156-t2034-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Smoke tests completed. 82 look OK, 1 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 362.40 | test_vpc_redundant.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4114: hypervisor: XCP-ng 8.1 support
blueorangutan commented on pull request #4114: URL: https://github.com/apache/cloudstack/pull/4114#issuecomment-655749730 Packaging result: ✖centos7 ✖debian. JID-1561 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4114: hypervisor: XCP-ng 8.1 support
blueorangutan commented on pull request #4114: URL: https://github.com/apache/cloudstack/pull/4114#issuecomment-655734304 Packaging result: ✖centos7 ✖debian. JID-1560 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] dimsijul commented on pull request #4070: Update cloud-set-guest-password.in
dimsijul commented on pull request #4070: URL: https://github.com/apache/cloudstack/pull/4070#issuecomment-655723061 > How do I set this up? the doc instructions dont seem to work. > I am running a centos 7 VM > downloaded cloud-set-guest-password.in and renamed it cloud-set-guest-password > moved it to /etc/init.d/ > chmod +x /etc/init.d/cloud-set-guest-password > reset the password. > > when the vm boots up, I am able to log in with the old password. > > it works on windows. > > what am I doing wrong? > > CS: 4.14. Hi @gaaray2k, you are right, one step is missing. In order to make the script work (wether it is Ubuntu, Debian or CentOS) you have to add a systemd service that will launch the password script at boot time. What we do to make this work is to create the file /etc/systemd/system/setpassword.service and set it to mode +x with the following content : [Unit] Description=script to reset the root password Wants=network-online.target After=network-online.target [Service] Type=oneshot ExecStart=/bin/bash /etc/init.d/cloud-set-guest-password.sh [Install] WantedBy=default.target This procedure should allow the system to run the cloud-set-guest-password script at boot time and as soon as the network is detected and therefore, if a password change is pending on the DHCP of the VM, it should be reset. Don't forget that this feature only works if the VM's network is set to DHCP. Let me know if it's ok or if you need further assistance. Cheers, Julien This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher closed pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)
GabrielBrascher closed pull request #4190: URL: https://github.com/apache/cloudstack/pull/4190 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4128: Role based users in Projects
blueorangutan commented on pull request #4128: URL: https://github.com/apache/cloudstack/pull/4128#issuecomment-655647262 @Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4128: Role based users in Projects
Pearl1594 commented on pull request #4128: URL: https://github.com/apache/cloudstack/pull/4128#issuecomment-655647038 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4128: Role based users in Projects
blueorangutan commented on pull request #4128: URL: https://github.com/apache/cloudstack/pull/4128#issuecomment-655646684 Packaging result: ✔centos7 ✔debian. JID-1559 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4116: cks: fix template, deployment issues
blueorangutan commented on pull request #4116: URL: https://github.com/apache/cloudstack/pull/4116#issuecomment-655639188 Trillian test result (tid-2028) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 37747 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4116-t2028-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py Smoke tests completed. 82 look OK, 1 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_add_delete_kubernetes_supported_version | `Error` | 5.23 | test_kubernetes_supported_versions.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4128: Role based users in Projects
blueorangutan commented on pull request #4128: URL: https://github.com/apache/cloudstack/pull/4128#issuecomment-655633672 @Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4128: Role based users in Projects
Pearl1594 commented on pull request #4128: URL: https://github.com/apache/cloudstack/pull/4128#issuecomment-655633286 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4128: Role based users in Projects
blueorangutan commented on pull request #4128: URL: https://github.com/apache/cloudstack/pull/4128#issuecomment-655622957 Trillian test result (tid-2027) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 43048 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4128-t2027-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Smoke tests completed. 83 look OK, 1 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 348.68 | test_vpc_redundant.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] gaaray2k commented on pull request #4070: Update cloud-set-guest-password.in
gaaray2k commented on pull request #4070: URL: https://github.com/apache/cloudstack/pull/4070#issuecomment-655575703 How do I set this up? the doc instructions dont seem to work. I am running a centos 7 VM downloaded cloud-set-guest-password.in and renamed it cloud-set-guest-password moved it to /etc/init.d/ chmod +x /etc/init.d/cloud-set-guest-password reset the password. when the vm boots up, I am able to log in with the old password. it works on windows. what am I doing wrong? CS: 4.14. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on issue #3526: Incorrect work of getFreeMemory() in LibvirtStartCommandWrapper.java
GabrielBrascher commented on issue #3526: URL: https://github.com/apache/cloudstack/issues/3526#issuecomment-67745 Sorry for the late reply, @DmB991. Just updating that I have been trying to reproduce this error on KVM nodes but so far I had no success. For instance, I deployed more than 150 VMs on a node (via API call s done by a script), reaching its CPU limits, but could not reproduce the issue raised here. Also, I was able to list those VMs and delete all of them at once without any problem. Have you been able to upgrade from 4.11.3 to 4.13.0.0 or 4.14.0.0? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4128: Role based users in Projects
blueorangutan commented on pull request #4128: URL: https://github.com/apache/cloudstack/pull/4128#issuecomment-62328 @Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4128: Role based users in Projects
Pearl1594 commented on pull request #4128: URL: https://github.com/apache/cloudstack/pull/4128#issuecomment-61560 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4128: Role based users in Projects
blueorangutan commented on pull request #4128: URL: https://github.com/apache/cloudstack/pull/4128#issuecomment-655547761 Packaging result: ✔centos7 ✔debian. JID-1558 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4128: Role based users in Projects
blueorangutan commented on pull request #4128: URL: https://github.com/apache/cloudstack/pull/4128#issuecomment-655531825 @Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4128: Role based users in Projects
Pearl1594 commented on pull request #4128: URL: https://github.com/apache/cloudstack/pull/4128#issuecomment-655531294 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] RodrigoDLopez closed pull request #4194: enable update tags on disk offerings
RodrigoDLopez closed pull request #4194: URL: https://github.com/apache/cloudstack/pull/4194 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4172: [VMware] Support to attach more than 15 data disks in VMware VM
blueorangutan commented on pull request #4172: URL: https://github.com/apache/cloudstack/pull/4172#issuecomment-655372305 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4156: Fixed removal of hosts from certsmap when running certificate auto-renew
blueorangutan commented on pull request #4156: URL: https://github.com/apache/cloudstack/pull/4156#issuecomment-655372449 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support
rhtyd commented on pull request #4068: URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-655371422 I'll kick test for centos7+centos7 kvm combination @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4172: [VMware] Support to attach more than 15 data disks in VMware VM
rhtyd commented on pull request #4172: URL: https://github.com/apache/cloudstack/pull/4172#issuecomment-655371675 @blueorangutan test centos7 vmware-67u3 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4156: Fixed removal of hosts from certsmap when running certificate auto-renew
rhtyd commented on pull request #4156: URL: https://github.com/apache/cloudstack/pull/4156#issuecomment-655371515 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support
rhtyd commented on pull request #4068: URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-655371266 @shwstppr please kick test from jenkins for the centos8mgmt server + centos8 kvm host combination. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support
blueorangutan commented on pull request #4068: URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-655368948 Packaging result: ✔centos7 ✔debian. JID-1557 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support
shwstppr commented on pull request #4068: URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-655357757 Volume test passing after the latest changes This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support
blueorangutan commented on pull request #4068: URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-655352521 @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support
shwstppr commented on pull request #4068: URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-655351990 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack-primate] branch master updated: image: Allows viewing delete/copy iso/template buttons for non ready resources and enables settings (#517)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git
The following commit(s) were added to refs/heads/master by this push:
new 75469a9 image: Allows viewing delete/copy iso/template buttons for
non ready resources and enables settings (#517)
75469a9 is described below
commit 75469a922f4da54f8c59a2aeecd2dbf25662d550
Author: Pearl Dsilva
AuthorDate: Wed Jul 8 13:01:23 2020 +0530
image: Allows viewing delete/copy iso/template buttons for non ready
resources and enables settings (#517)
Fixes #511
---
src/components/view/DetailSettings.vue | 3 ++-
src/views/image/IsoZones.vue | 3 +--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/components/view/DetailSettings.vue
b/src/components/view/DetailSettings.vue
index 1e9fc8c..641f25f 100644
--- a/src/components/view/DetailSettings.vue
+++ b/src/components/view/DetailSettings.vue
@@ -173,7 +173,8 @@ export default {
},
isAdminOrOwner () {
return ['Admin'].includes(this.$store.getters.userInfo.roletype) ||
-(this.resource.domainid === this.$store.getters.userInfo.domainid &&
this.resource.account === this.$store.getters.userInfo.account)
+(this.resource.domainid === this.$store.getters.userInfo.domainid &&
this.resource.account === this.$store.getters.userInfo.account) ||
+this.resource.project && this.resource.projectid ===
this.$store.getters.project.id
},
runApi () {
var apiName = ''
diff --git a/src/views/image/IsoZones.vue b/src/views/image/IsoZones.vue
index f76c034..3dcd960 100644
--- a/src/views/image/IsoZones.vue
+++ b/src/views/image/IsoZones.vue
@@ -228,8 +228,7 @@ export default {
isActionPermitted () {
return (['Admin'].includes(this.$store.getters.userInfo.roletype) ||
(this.resource.domainid === this.$store.getters.userInfo.domainid &&
this.resource.account === this.$store.getters.userInfo.account)) &&
-!(this.resource.account !== 'SYSTEM' && this.resource.domainid === 1)
&&
-this.resource.isready
+!(this.resource.account !== 'SYSTEM' && this.resource.domainid === 1)
},
deleteIso (record) {
const params = {
[GitHub] [cloudstack] blueorangutan commented on pull request #4131: [HEALTH] Master/4.15 Health Check please don't merge this
blueorangutan commented on pull request #4131: URL: https://github.com/apache/cloudstack/pull/4131#issuecomment-655331368 Packaging result: ✔centos7 ✔debian. JID-1555 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4150: [HEALTH][4.14] Health Check Run
blueorangutan commented on pull request #4150: URL: https://github.com/apache/cloudstack/pull/4150#issuecomment-655331369 Packaging result: ✔centos7 ✔debian. JID-1556 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack-primate] branch master updated: compute: Simplifying Deploy VM Wizard (#499)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git
The following commit(s) were added to refs/heads/master by this push:
new 9e61270 compute: Simplifying Deploy VM Wizard (#499)
9e61270 is described below
commit 9e61270a9b87ab840a8a885f3996ef5f097a8f33
Author: davidjumani
AuthorDate: Wed Jul 8 12:32:39 2020 +0530
compute: Simplifying Deploy VM Wizard (#499)
Fixes #490
Fixes #491
---
src/locales/en.json| 1 +
src/views/compute/DeployVM.vue | 95 +-
.../compute/wizard/AffinityGroupSelection.vue | 1 +
src/views/compute/wizard/DiskSizeSelection.vue | 36 +---
4 files changed, 82 insertions(+), 51 deletions(-)
diff --git a/src/locales/en.json b/src/locales/en.json
index 285fafa..f8530b4 100644
--- a/src/locales/en.json
+++ b/src/locales/en.json
@@ -1408,6 +1408,7 @@
"label.overprovisionfactor": "Overprovisioning Factor",
"label.override.guest.traffic": "Override Guest-Traffic",
"label.override.public.traffic": "Override Public-Traffic",
+"label.override.rootdisk.size": "Override Root Disk Size",
"label.overrideguesttraffic": "Override Guest-Traffic",
"label.overridepublictraffic": "Override Public-Traffic",
"label.ovf.properties": "OVF Properties",
diff --git a/src/views/compute/DeployVM.vue b/src/views/compute/DeployVM.vue
index ce7084b..cd1836e 100644
--- a/src/views/compute/DeployVM.vue
+++ b/src/views/compute/DeployVM.vue
@@ -89,12 +89,18 @@
:selected="tabKey"
:loading="loading.templates"
:preFillContent="dataPreFill"
- @update-template-iso="updateFieldValue"
->
+ @update-template-iso="updateFieldValue" />
+
+ {{ $t('label.override.rootdisk.size') }}
+
+
+ :minDiskSize="dataPreFill.minrootdisksize"
+ @update-disk-size="updateFieldValue"
+ style="margin-top: 10px;"/>
{{ $t('message.iso.desc') }}
@@ -204,24 +210,6 @@
-
-
-
-
-
-
-
@@ -265,25 +253,14 @@
- {{ $t('message.vm.review.launch') }}
-
-
-
-
-
-
-
-
-
-
+
+{{ $t('label.isadvanced') }}
+
+
+
@@ -317,6 +294,40 @@
v-decorator="['userdata']">
+
+
+
+
+
+
+
+
+
+{{ $t('message.vm.review.launch') }}
+
+
+
+
+
+
+
+
+
@@ -505,7 +516,9 @@ export default {
}
],
tabKey: 'templateid',
- dataPreFill: {}
+ dataPreFill: {},
+ showDetails: false,
+ showRootDiskSizeChanger: false
}
},
computed: {
@@ -880,6 +893,10 @@ export default {
templateid: value,
isoid: null
})
+const templates = this.options.templates.filter(x => x.id === value)
+if (templates.length > 0) {
+ this.dataPreFill.minrootdisksize = templates[0].size / (1024 * 1024
* 1024) || 0 // bytes to GB
+}
} else if (name === 'isoid') {
this.tabKey = 'isoid'
this.form.setFieldsValue({
diff --git a/src/views/compute/wizard/AffinityGroupSelection.vue
b/src/views/compute/wizard/AffinityGroupSelection.vue
index 25a9fbd..8c6d5e9 100644
--- a/src/views/compute/wizard/AffinityGroupSelection.vue
+++ b/src/views/compute/wizard/AffinityGroupSelection.vue
@@ -17,6 +17,7 @@
+{{ $t('message.select.affinity.groups') }}
-
-
-
- GB
+ GB
+ {{ $t(error) }}
@@ -52,11 +45,23 @@ export default {
[cloudstack-primate] branch master updated (8815643 -> 989d8ca)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git. from 8815643 infocard: Add missing internationalization on resources tags and annotations (#514) add 989d8ca compute: Fix ListResourceTable (#513) No new revisions were added by this update. Summary of changes: src/components/view/ListResourceTable.vue | 118 -- src/views/compute/InstanceTab.vue | 11 ++- 2 files changed, 104 insertions(+), 25 deletions(-)
[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #4138: Fixed incorrect error message on invalid template type download
Spaceman1984 commented on a change in pull request #4138:
URL: https://github.com/apache/cloudstack/pull/4138#discussion_r451315166
##
File path:
core/src/main/java/com/cloud/storage/template/HttpTemplateDownloader.java
##
@@ -243,7 +247,6 @@ private boolean copyBytes(File file, InputStream in,
RandomAccessFile out) throw
offset = writeBlock(bytes, out, block, offset);
if (!verifyFormat.isVerifiedFormat() && (offset >= 1048576 ||
offset >= remoteSize)) { //let's check format after we get 1MB or full file
verifyFormat.invoke();
-if (verifyFormat.isInvalid()) return true;
Review comment:
@rhtyd If validation fails, an exception is thrown, so there is no
setting of an invalid state that has to be checked. Validation happens inside
verifyFormat.invoke();
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #4138: Fixed incorrect error message on invalid template type download
Spaceman1984 commented on a change in pull request #4138:
URL: https://github.com/apache/cloudstack/pull/4138#discussion_r451315166
##
File path:
core/src/main/java/com/cloud/storage/template/HttpTemplateDownloader.java
##
@@ -243,7 +247,6 @@ private boolean copyBytes(File file, InputStream in,
RandomAccessFile out) throw
offset = writeBlock(bytes, out, block, offset);
if (!verifyFormat.isVerifiedFormat() && (offset >= 1048576 ||
offset >= remoteSize)) { //let's check format after we get 1MB or full file
verifyFormat.invoke();
-if (verifyFormat.isInvalid()) return true;
Review comment:
@rhtyd If validation fails, an exception is thrown, so there is no
setting of an invalid state that has to be checked.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4150: [HEALTH][4.14] Health Check Run
blueorangutan commented on pull request #4150: URL: https://github.com/apache/cloudstack/pull/4150#issuecomment-655318494 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4131: [HEALTH] Master/4.15 Health Check please don't merge this
blueorangutan commented on pull request #4131: URL: https://github.com/apache/cloudstack/pull/4131#issuecomment-655318364 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4150: [HEALTH][4.14] Health Check Run
rhtyd commented on pull request #4150: URL: https://github.com/apache/cloudstack/pull/4150#issuecomment-655317945 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4131: [HEALTH] Master/4.15 Health Check please don't merge this
rhtyd commented on pull request #4131: URL: https://github.com/apache/cloudstack/pull/4131#issuecomment-655317994 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4156: Fixed removal of hosts from certsmap when running certificate auto-renew
blueorangutan commented on pull request #4156: URL: https://github.com/apache/cloudstack/pull/4156#issuecomment-655317151 Packaging result: ✔centos7 ✔debian. JID-1554 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4172: [VMware] Support to attach more than 15 data disks in VMware VM
blueorangutan commented on pull request #4172: URL: https://github.com/apache/cloudstack/pull/4172#issuecomment-655316211 Packaging result: ✔centos7 ✔debian. JID-1553 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd closed issue #4056: The listKubernetesSupportedVersions API does not honour searching
rhtyd closed issue #4056: URL: https://github.com/apache/cloudstack/issues/4056 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on issue #3364: LDAP users with similar permissions do not see each other's networks
rhtyd commented on issue #3364: URL: https://github.com/apache/cloudstack/issues/3364#issuecomment-655309779 Can you test Primate @PPisz we're targeting GA/1.0 now This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on issue #4052: Remove 'make redundant' option from the restart network pop-up.
rhtyd commented on issue #4052: URL: https://github.com/apache/cloudstack/issues/4052#issuecomment-655309492 @borisstoyanov this is fixed in Primate  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd closed issue #4052: Remove 'make redundant' option from the restart network pop-up.
rhtyd closed issue #4052: URL: https://github.com/apache/cloudstack/issues/4052 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on issue #4179: Regions
rhtyd commented on issue #4179: URL: https://github.com/apache/cloudstack/issues/4179#issuecomment-655308936 This is largely an unsupported feature, right now it's serves as a bookmark to other mgmt server. Please ask questions or discuss them on the users ML list instead: http://cloudstack.apache.org/mailing-lists.html Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd closed issue #4179: Regions
rhtyd closed issue #4179: URL: https://github.com/apache/cloudstack/issues/4179 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on issue #4183: Fail to do a Live Migration with storage via migrateVirtualMachineWithVolume API.
rhtyd commented on issue #4183: URL: https://github.com/apache/cloudstack/issues/4183#issuecomment-655308669 ping @GabrielBrascher @wido any thoughts? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack] 01/01: Merge remote-tracking branch 'origin/4.14'
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit dfc76e02783b642551c67209d9ba23a7e7a254d6 Merge: 64c6938 ba76778 Author: Rohit Yadav AuthorDate: Wed Jul 8 11:37:14 2020 +0530 Merge remote-tracking branch 'origin/4.14' .../src/main/java/org/apache/cloudstack/saml/SAMLUtils.java | 2 +- server/src/main/java/com/cloud/api/ApiServlet.java | 13 + 2 files changed, 10 insertions(+), 5 deletions(-)
[cloudstack] 01/01: Merge remote-tracking branch 'origin/4.13' into 4.14
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch 4.14 in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit ba767783bd733832524fabdc7a683c300e309b49 Merge: db9f825 139aa13 Author: Rohit Yadav AuthorDate: Wed Jul 8 11:36:30 2020 +0530 Merge remote-tracking branch 'origin/4.13' into 4.14 .../src/main/java/org/apache/cloudstack/saml/SAMLUtils.java | 2 +- server/src/main/java/com/cloud/api/ApiServlet.java | 13 + 2 files changed, 10 insertions(+), 5 deletions(-)
[cloudstack] branch master updated (64c6938 -> dfc76e0)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 64c6938 db: VMware Guest OS Mappings fix (#4196) add 139aa13 server: Purge all cookies on logout, set /client path on login (#4176) add ba76778 Merge remote-tracking branch 'origin/4.13' into 4.14 new dfc76e0 Merge remote-tracking branch 'origin/4.14' The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../src/main/java/org/apache/cloudstack/saml/SAMLUtils.java | 2 +- server/src/main/java/com/cloud/api/ApiServlet.java | 13 + 2 files changed, 10 insertions(+), 5 deletions(-)
[cloudstack] branch 4.14 updated (db9f825 -> ba76778)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch 4.14 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from db9f825 server: don't export B APIs if feature is not enabled globally (#4202) add 139aa13 server: Purge all cookies on logout, set /client path on login (#4176) new ba76778 Merge remote-tracking branch 'origin/4.13' into 4.14 The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../src/main/java/org/apache/cloudstack/saml/SAMLUtils.java | 2 +- server/src/main/java/com/cloud/api/ApiServlet.java | 13 + 2 files changed, 10 insertions(+), 5 deletions(-)
[cloudstack-primate] branch master updated: infocard: Add missing internationalization on resources tags and annotations (#514)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git
The following commit(s) were added to refs/heads/master by this push:
new 8815643 infocard: Add missing internationalization on resources tags
and annotations (#514)
8815643 is described below
commit 881564323fd9bf7eb5cee0fc1e0e8fac2698e93d
Author: Nicolas Vazquez
AuthorDate: Wed Jul 8 03:03:07 2020 -0300
infocard: Add missing internationalization on resources tags and
annotations (#514)
* Add missing internationalization on instance view and instance detail view
* Remove scale VM translation from this PR
---
src/components/view/InfoCard.vue | 10 +-
src/locales/en.json | 1 +
src/locales/es.json | 4 +++-
3 files changed, 9 insertions(+), 6 deletions(-)
diff --git a/src/components/view/InfoCard.vue b/src/components/view/InfoCard.vue
index 067cacb..ec0bfcb 100644
--- a/src/components/view/InfoCard.vue
+++ b/src/components/view/InfoCard.vue
@@ -559,9 +559,9 @@
@blur="handleInputConfirm"
@keyup.enter="handleInputConfirm"
compact>
-
+
-
+
@@ -571,7 +571,7 @@
- New Tag
+ {{ $t('label.new.tag') }}
@@ -579,7 +579,7 @@
- Comments ({{ notes.length }})
+ {{ $t('label.comments') }} ({{ notes.length }})
- Save
+ {{ $t('label.save') }}
diff --git a/src/locales/en.json b/src/locales/en.json
index 46eea6e..285fafa 100644
--- a/src/locales/en.json
+++ b/src/locales/en.json
@@ -530,6 +530,7 @@
"label.clustertype": "Cluster Type",
"label.clvm": "CLVM",
"label.code": "Code",
+"label.comments": "Comments",
"label.community": "Community",
"label.compute": "Compute",
"label.compute.and.storage": "Compute and Storage",
diff --git a/src/locales/es.json b/src/locales/es.json
index 36a2dc6..3f80161 100644
--- a/src/locales/es.json
+++ b/src/locales/es.json
@@ -478,6 +478,7 @@
"label.clustertype": "Tipo de Cl\u00faster",
"label.clvm": "CLVM",
"label.code": "C\u00f3digo",
+"label.comments": "Comentarios",
"label.community": "Comunidad",
"label.compute": "Computo",
"label.compute.and.storage": "Computo y Almacenamiento",
@@ -947,7 +948,7 @@
"label.japanese.keyboard": "Teclado Japones",
"label.keep": "Mantener",
"label.keep.colon": "Conservar:",
-"label.key": "Llave",
+"label.key": "Clave",
"label.keyboard": "Lenguaje del Teclado",
"label.keyboardtype": "Tipo de teclado",
"label.keypair": "Par de Claves SSH",
@@ -1157,6 +1158,7 @@
"label.new.instance.group": "Nuevo Grupo de Instancias",
"label.new.password": "Nueva contrase\u00f1a",
"label.new.project": "Nuevo Proyecto",
+"label.new.tag": "Nueva Etiqueta",
"label.new.vm": "Nueva MV",
"label.newdiskoffering": "Nueva Oferta",
"label.newsize": "Nuevo Tama\u00f1o (GB)",
[cloudstack-primate] branch master updated: compute: Add missing internationalization on instance groups view (#515)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git
The following commit(s) were added to refs/heads/master by this push:
new a3defe4 compute: Add missing internationalization on instance groups
view (#515)
a3defe4 is described below
commit a3defe48e48e04e4f16151a704e5c5bce3e7ea65
Author: Nicolas Vazquez
AuthorDate: Wed Jul 8 03:02:28 2020 -0300
compute: Add missing internationalization on instance groups view (#515)
---
src/config/section/compute.js | 6 +++---
src/locales/en.json | 3 +++
src/locales/es.json | 3 +++
3 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/src/config/section/compute.js b/src/config/section/compute.js
index 2931764..ad18bfc 100644
--- a/src/config/section/compute.js
+++ b/src/config/section/compute.js
@@ -491,21 +491,21 @@ export default {
{
api: 'createInstanceGroup',
icon: 'plus',
- label: 'New Instance Group',
+ label: 'label.new.instance.group',
listView: true,
args: ['name']
},
{
api: 'updateInstanceGroup',
icon: 'edit',
- label: 'Update Instance Group',
+ label: 'label.update.instance.group',
dataView: true,
args: ['name']
},
{
api: 'deleteInstanceGroup',
icon: 'delete',
- label: 'Delete Instance Group',
+ label: 'label.delete.instance.group',
dataView: true
}
]
diff --git a/src/locales/en.json b/src/locales/en.json
index d71decb..46eea6e 100644
--- a/src/locales/en.json
+++ b/src/locales/en.json
@@ -628,6 +628,7 @@
"label.delete.events": "Delete events",
"label.delete.f5": "Delete F5",
"label.delete.gateway": "Delete gateway",
+"label.delete.instance.group": "Delete Instance Group",
"label.delete.internal.lb": "Delete Internal LB",
"label.delete.netscaler": "Delete NetScaler",
"label.delete.niciranvp": "Remove Nvp Controller",
@@ -1333,6 +1334,7 @@
"label.networktype": "Network Type",
"label.networkwrite": "Network Write",
"label.new": "New",
+"label.new.instance.group": "New Instance Group",
"label.new.password": "New Password",
"label.new.project": "New Project",
"label.new.tag": "New Tag",
@@ -1975,6 +1977,7 @@
"label.unit": "Usage Unit",
"label.unlimited": "Unlimited",
"label.untagged": "Untagged",
+"label.update.instance.group": "Update Instance Group",
"label.update.project.resources": "Update project resources",
"label.update.ssl": " SSL Certificate",
"label.update.ssl.cert": " SSL Certificate",
diff --git a/src/locales/es.json b/src/locales/es.json
index 071bf0d..36a2dc6 100644
--- a/src/locales/es.json
+++ b/src/locales/es.json
@@ -561,6 +561,7 @@
"label.delete.events": "Eliminar sucesos",
"label.delete.f5": "Borrar F5",
"label.delete.gateway": "Borrar gateway",
+"label.delete.instance.group": "Borrar Grupo de Instancias",
"label.delete.internal.lb": "Borrar LB Interno",
"label.delete.netscaler": "Borrar NetScaler",
"label.delete.niciranvp": "Quitar Controlado Nvp",
@@ -1153,6 +1154,7 @@
"label.networktype": "Tipo de red",
"label.networkwrite": "Escritura Red",
"label.new": "Nuevo",
+"label.new.instance.group": "Nuevo Grupo de Instancias",
"label.new.password": "Nueva contrase\u00f1a",
"label.new.project": "Nuevo Proyecto",
"label.new.vm": "Nueva MV",
@@ -1705,6 +1707,7 @@
"label.unit": "Unidad de Uso",
"label.unlimited": "Ilimitado",
"label.untagged": "Sin etiquetar",
+"label.update.instance.group": "Actualizar Grupo de Instancias",
"label.update.project.resources": "Actualizar recursos del proyecto",
"label.update.ssl": " Certificado SSL",
"label.update.ssl.cert": " Certificado SSL",
