[GitHub] [cloudstack] nvazquez commented on a change in pull request #4250: [VMware] OVF Full properties support

[GitBox]

nvazquez commented on a change in pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#discussion_r475041891



##
File path: engine/schema/src/main/resources/META-INF/db/schema-41400to41500.sql
##
@@ -309,3 +309,86 @@ INSERT IGNORE INTO `cloud`.`hypervisor_capabilities`(uuid, 
hypervisor_type, hype
 
 -- Copy XenServer 8.0 hypervisor guest OS mappings to XenServer8.1
 INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, 
hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) 
SELECT UUID(),'Xenserver', '8.1.0', guest_os_name, guest_os_id, 
utc_timestamp(), 0 FROM `cloud`.`guest_os_hypervisor` WHERE 
hypervisor_type='Xenserver' AND hypervisor_version='8.0.0';
+
+-- Add mincpu, maxcpu, minmemory and maxmemory to the view supporting 
constrained offerings
+ALTER VIEW `cloud`.`service_offering_view` AS

Review comment:
   Thanks, fixed





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4111: API-call to declare host as Degraded

[GitBox]

blueorangutan commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-678525214


   Packaging result: ✖centos7 ✖centos8 ✖debian. JID-1802



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4264: Changed test failure to warning

[GitBox]

blueorangutan commented on pull request #4264:
URL: https://github.com/apache/cloudstack/pull/4264#issuecomment-678525106


   Trillian test result (tid-2537)
   Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 48110 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4264-t2537-vmware-67u3.zip
   Intermittent failure detected: 
/marvin/tests/smoke/test_deploy_vm_root_resize.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
   Smoke tests completed. 79 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_00_deploy_vm_root_resize | `Failure` | 288.90 | 
test_deploy_vm_root_resize.py
   test_01_deploy_kubernetes_cluster | `Error` | 0.07 | 
test_kubernetes_clusters.py
   test_02_deploy_kubernetes_ha_cluster | `Error` | 0.04 | 
test_kubernetes_clusters.py
   test_04_deploy_and_upgrade_kubernetes_cluster | `Error` | 0.03 | 
test_kubernetes_clusters.py
   test_05_deploy_and_upgrade_kubernetes_ha_cluster | `Error` | 0.03 | 
test_kubernetes_clusters.py
   test_06_deploy_and_invalid_upgrade_kubernetes_cluster | `Error` | 0.03 | 
test_kubernetes_clusters.py
   test_07_deploy_and_scale_kubernetes_cluster | `Error` | 0.03 | 
test_kubernetes_clusters.py
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4111: API-call to declare host as Degraded

[GitBox]

blueorangutan commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-678490301


   @GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] GabrielBrascher commented on pull request #4111: API-call to declare host as Degraded

[GitBox]

GabrielBrascher commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-678489932


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] GabrielBrascher commented on issue #4159: Fail to deploy VM with Ceph (Octopus) as primary storage

[GitBox]

GabrielBrascher commented on issue #4159:
URL: https://github.com/apache/cloudstack/issues/4159#issuecomment-678425055


   @rhtyd @wido I created an issue at 
https://issues.sonatype.org/browse/OSSRH-60110 requesting permission to sync 
`com.ceph.rados`. If they do not provide permission, I hope that someone at 
sonar with proper permission will help us.
   
   They already host com.ceph.rados artifacts here: 
https://search.maven.org/artifact/com.ceph/rados



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] GabrielBrascher opened a new pull request #4279: Avoid Null pointer at DomainChecker and enhance AssignVMCmd

[GitBox]

GabrielBrascher opened a new pull request #4279:
URL: https://github.com/apache/cloudstack/pull/4279


   ## Description
   
   When executing request 
[assignVirtualMachine](https://cloudstack.apache.org/api/apidocs-4.14/apis/assignVirtualMachine.html)
 with null `domainID` and a valid `projectID` then a `NullPointerException` 
happens at 
[DomainChecker.java](https://github.com/apache/cloudstack/blob/bb73bedb5511880c91abaa409462ba879cb0d7b7/server/src/main/java/com/cloud/acl/DomainChecker.java#L109).
   
   Command example:
   ```
   assign virtualmachine virtualmachineid=VM-ID projectid=ProjectID 
account=admin
   ```
   
   The `NullPointerException` that is thrown at `DomainChecker` is handled at 
[AssignVMCmd.java#L142](https://github.com/apache/cloudstack/blob/bb73bedb5511880c91abaa409462ba879cb0d7b7/api/src/main/java/org/apache/cloudstack/api/command/admin/vm/AssignVMCmd.java#L142),
 resulting in the following log message: `Failed to move vm null`.
   
   
   **My question is:** does it make sense to assign VM to a project with 
`domainID=null`? If so, then the handling should be different. However, I think 
that it should not be `null` and therefore I added a proper log message.
   
   Prior to commit 
   ## Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## How Has This Been Tested?
   Via API request of API command  
[assignVirtualMachine](https://cloudstack.apache.org/api/apidocs-4.14/apis/assignVirtualMachine.html).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] RodrigoDLopez commented on pull request #4278: Usage-server update message improvement

[GitBox]

RodrigoDLopez commented on pull request #4278:
URL: https://github.com/apache/cloudstack/pull/4278#issuecomment-678361364


   LGMT



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] RodrigoDLopez edited a comment on pull request #4278: Usage-server update message improvement

[GitBox]

RodrigoDLopez edited a comment on pull request #4278:
URL: https://github.com/apache/cloudstack/pull/4278#issuecomment-678361364


   LGTM



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] Spaceman1984 commented on issue #4082: [Vmware] ISO gets detached after stop and start VM

[GitBox]

Spaceman1984 commented on issue #4082:
URL: https://github.com/apache/cloudstack/issues/4082#issuecomment-678280729


   Tested on 4.14 and master, the iso is still attached after stopping and 
starting the instance.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[cloudstack-primate] branch master updated: src: assorted bug fixes (#594)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git


The following commit(s) were added to refs/heads/master by this push:
 new 70760d5  src: assorted bug fixes (#594)
70760d5 is described below

commit 70760d557a05590b721436778ed988f91ba84ec3
Author: davidjumani 
AuthorDate: Fri Aug 21 17:51:51 2020 +0530

src: assorted bug fixes (#594)

Fixes:
#588
#589
#590
#591
#601
---
 src/config/eventBus.js| 19 ++
 src/config/section/compute.js | 10 --
 src/locales/en.json   | 23 ++--
 src/views/AutogenView.vue | 51 ---
 src/views/compute/DeployVM.vue| 16 ++---
 src/views/compute/wizard/ComputeSelection.vue | 20 ++-
 src/views/image/RegisterOrUploadIso.vue   |  1 +
 src/views/image/RegisterOrUploadTemplate.vue  |  1 +
 src/views/offering/AddComputeOffering.vue |  2 +-
 9 files changed, 95 insertions(+), 48 deletions(-)

diff --git a/src/config/eventBus.js b/src/config/eventBus.js
new file mode 100644
index 000..ed61648
--- /dev/null
+++ b/src/config/eventBus.js
@@ -0,0 +1,19 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+import Vue from 'vue'
+export default new Vue()
diff --git a/src/config/section/compute.js b/src/config/section/compute.js
index 818f6bc..03d68b1 100644
--- a/src/config/section/compute.js
+++ b/src/config/section/compute.js
@@ -94,8 +94,11 @@ export default {
   groupAction: true,
   groupMap: (selection) => { return selection.map(x => { return { id: 
x } }) },
   show: (record) => { return ['Stopped'].includes(record.state) },
-  args: (record, store) => {
+  args: (record, store, group) => {
 var fields = []
+if (group) {
+  return fields
+}
 if (store.userInfo.roletype === 'Admin') {
   fields = ['podid', 'clusterid', 'hostid']
 }
@@ -116,7 +119,7 @@ export default {
   docHelp: 
'adminguide/virtual_machines.html#stopping-and-starting-vms',
   dataView: true,
   groupAction: true,
-  groupMap: (selection) => { return selection.map(x => { return { id: 
x } }) },
+  groupMap: (selection, values) => { return selection.map(x => { 
return { id: x, forced: values.forced } }) },
   args: ['forced'],
   show: (record) => { return ['Running'].includes(record.state) }
 },
@@ -384,8 +387,9 @@ export default {
   docHelp: 'adminguide/virtual_machines.html#deleting-vms',
   dataView: true,
   groupAction: true,
+  args: ['expunge'],
   popup: true,
-  groupMap: (selection) => { return selection.map(x => { return { id: 
x, expunge: true } }) },
+  groupMap: (selection, values) => { return selection.map(x => { 
return { id: x, expunge: values.expunge } }) },
   show: (record) => { return ['Running', 'Stopped', 
'Error'].includes(record.state) },
   component: () => import('@/views/compute/DestoryVM.vue')
 }
diff --git a/src/locales/en.json b/src/locales/en.json
index a400472..00dc048 100644
--- a/src/locales/en.json
+++ b/src/locales/en.json
@@ -612,11 +612,11 @@
 "label.create.nfs.secondary.staging.store": "Create NFS secondary staging 
store",
 "label.create.project": "Create project",
 "label.create.project.role": "Create Project Role",
-"label.create.user": "Create user",
 "label.create.site.vpn.connection": "Create Site-to-Site VPN Connection",
 "label.create.site.vpn.gateway": "Create Site-to-Site VPN Gateway",
 "label.create.ssh.key.pair": "Create a SSH Key Pair",
 "label.create.template": "Create template",
+"label.create.user": "Create user",
 "label.create.vpn.connection": "Create VPN Connection",
 "label.created": "Created",
 "label.created.by.system": "Created by system",
@@ -635,6 +635,7 @@
 "label.daily": "Daily",
 "label.dashboard": "Dashboard",
 "label.dashboard.endpoint": "Dashboard endpoint",
+"label.data.disk": "Data Disk",
 

Build failed in Jenkins: Cloudstack » cloudstack-marvin #4

[Apache Jenkins Server]

See 


Changes:


--
Started by upstream project "Cloudstack/cloudstack-apidocs-master" build number 
5
originally caused by:
 Started by an SCM change
 Started by an SCM change
 Started by an SCM change
 Started by an SCM change
 Started by an SCM change
 Started by an SCM change
 Started by an SCM change
Running as SYSTEM
[EnvInject] - Loading node environment variables.
Building remotely on H43 (ubuntu) in workspace 

No credentials specified
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url 
 > https://git-wip-us.apache.org/repos/asf/cloudstack.git # timeout=10
Fetching upstream changes from 
https://git-wip-us.apache.org/repos/asf/cloudstack.git
 > git --version # timeout=10
 > git fetch --tags --progress -- 
 > https://git-wip-us.apache.org/repos/asf/cloudstack.git 
 > +refs/heads/*:refs/remotes/origin/* # timeout=10
 > git rev-parse origin/master^{commit} # timeout=10
Checking out Revision bb73bedb5511880c91abaa409462ba879cb0d7b7 (origin/master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f bb73bedb5511880c91abaa409462ba879cb0d7b7 # timeout=10
Commit message: "Merge remote-tracking branch 'origin/4.14'"
 > git rev-list --no-walk 3872bf1ff94659fb234a7dd938ccdf6254fad3e7 # timeout=10
 > git tag -a -f -m Jenkins Build #4 jenkins-cloudstack-marvin-4 # timeout=10
FATAL: Could not apply tag jenkins-cloudstack-marvin-4
hudson.plugins.git.GitException: Command "git tag -a -f -m Jenkins Build #4 
jenkins-cloudstack-marvin-4" returned status code 128:
stdout: 
stderr: 
*** Please tell me who you are.

Run

  git config --global user.email "y...@example.com"
  git config --global user.name "Your Name"

to set your account's default identity.
Omit --global to set the identity only in this repository.

fatal: empty ident name (for ) not allowed

at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2372)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2302)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2298)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommand(CliGitAPIImpl.java:1857)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommand(CliGitAPIImpl.java:1869)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.tag(CliGitAPIImpl.java:1738)
Also:   hudson.remoting.Channel$CallSiteStackTrace: Remote call to H43
at 
hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1788)
at 
hudson.remoting.UserRequest$ExceptionResponse.retrieve(UserRequest.java:356)
at hudson.remoting.Channel.call(Channel.java:998)
at 
hudson.remoting.RemoteInvocationHandler.invoke(RemoteInvocationHandler.java:285)
at com.sun.proxy.$Proxy151.tag(Unknown Source)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl.tag(RemoteGitImpl.java:500)
at 
hudson.plugins.git.extensions.impl.PerBuildTag.onCheckoutCompleted(PerBuildTag.java:30)
at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1245)
at hudson.scm.SCM.checkout(SCM.java:505)
at 
hudson.model.AbstractProject.checkout(AbstractProject.java:1206)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
at 
jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
at hudson.model.Run.execute(Run.java:1880)
at 
hudson.maven.MavenModuleSetBuild.run(MavenModuleSetBuild.java:543)
at 
hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:428)
Caused: hudson.plugins.git.GitException: Could not apply tag 
jenkins-cloudstack-marvin-4
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.tag(CliGitAPIImpl.java:1740)
at hudson.plugins.git.GitAPI.tag(GitAPI.java:274)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
hudson.remoting.RemoteInvocationHandler$RPCRequest.perform(RemoteInvocationHandler.java:931)
at 
hudson.remoting.RemoteInvocationHandler$RPCRequest.call(RemoteInvocationHandler.java:905)
at 

[cloudstack] 01/01: Merge remote-tracking branch 'origin/4.13' into 4.14

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch 4.14
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit 05ae3f8d8181696abfce367609ef9101e6d9f88d
Merge: 9681a28 1da76d2
Author: Rohit Yadav 
AuthorDate: Fri Aug 21 15:38:18 2020 +0530

Merge remote-tracking branch 'origin/4.13' into 4.14

 agent/conf/agent.properties |  5 +
 .../hypervisor/kvm/resource/LibvirtComputingResource.java   | 13 ++---
 .../hypervisor/kvm/storage/IscsiStorageCleanupMonitor.java  |  3 ++-
 3 files changed, 17 insertions(+), 4 deletions(-)

[cloudstack] branch master updated (961f3ec -> bb73bed)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


from 961f3ec  Merge remote-tracking branch 'origin/4.14'
 add 1da76d2  iscsi session cleanup now configurable, filters iscsi 
partitions (#4219)
 add 05ae3f8  Merge remote-tracking branch 'origin/4.13' into 4.14
 add bb73bed  Merge remote-tracking branch 'origin/4.14'

No new revisions were added by this update.

Summary of changes:
 agent/conf/agent.properties |  5 +
 .../hypervisor/kvm/resource/LibvirtComputingResource.java   | 13 ++---
 .../hypervisor/kvm/storage/IscsiStorageCleanupMonitor.java  |  3 ++-
 3 files changed, 17 insertions(+), 4 deletions(-)

[cloudstack] branch 4.14 updated (9681a28 -> 05ae3f8)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a change to branch 4.14
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


from 9681a28  api: Display hypervisor type for VM snapshot (#4275)
 add 1da76d2  iscsi session cleanup now configurable, filters iscsi 
partitions (#4219)
 new 05ae3f8  Merge remote-tracking branch 'origin/4.13' into 4.14

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 agent/conf/agent.properties |  5 +
 .../hypervisor/kvm/resource/LibvirtComputingResource.java   | 13 ++---
 .../hypervisor/kvm/storage/IscsiStorageCleanupMonitor.java  |  3 ++-
 3 files changed, 17 insertions(+), 4 deletions(-)

[GitHub] [cloudstack] blueorangutan commented on pull request #4278: Usage-server update message improvement

[GitBox]

blueorangutan commented on pull request #4278:
URL: https://github.com/apache/cloudstack/pull/4278#issuecomment-678144745


   Packaging result: ✔centos7 ✔centos8 ✔debian. JID-1801



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] andrijapanicsb commented on a change in pull request #4250: [VMware] OVF Full properties support

[GitBox]

andrijapanicsb commented on a change in pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#discussion_r474564204



##
File path: engine/schema/src/main/resources/META-INF/db/schema-41400to41500.sql
##
@@ -309,3 +309,86 @@ INSERT IGNORE INTO `cloud`.`hypervisor_capabilities`(uuid, 
hypervisor_type, hype
 
 -- Copy XenServer 8.0 hypervisor guest OS mappings to XenServer8.1
 INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, 
hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) 
SELECT UUID(),'Xenserver', '8.1.0', guest_os_name, guest_os_id, 
utc_timestamp(), 0 FROM `cloud`.`guest_os_hypervisor` WHERE 
hypervisor_type='Xenserver' AND hypervisor_version='8.0.0';
+
+-- Add mincpu, maxcpu, minmemory and maxmemory to the view supporting 
constrained offerings
+ALTER VIEW `cloud`.`service_offering_view` AS

Review comment:
   @nvazquez afaik, we've discussed that we always want to drop/replace 
view, not alter it, due to whatever issues someone noticed in some cases





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rhtyd merged pull request #4219: iscsi session cleanup now configurable, filters iscsi partitions

[GitBox]

rhtyd merged pull request #4219:
URL: https://github.com/apache/cloudstack/pull/4219


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[cloudstack] branch 4.13 updated: iscsi session cleanup now configurable, filters iscsi partitions (#4219)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch 4.13
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/4.13 by this push:
 new 1da76d2  iscsi session cleanup now configurable, filters iscsi 
partitions (#4219)
1da76d2 is described below

commit 1da76d27f13e045ac88e6c494d604d6133486c9c
Author: Sid Kattoju <45833770+skatto...@users.noreply.github.com>
AuthorDate: Fri Aug 21 05:08:36 2020 -0400

iscsi session cleanup now configurable, filters iscsi partitions (#4219)

Added property to agent.properties that enables or disables the iscsi 
session clean up feature. #4210
Added a condition to prevent disk partitions from being cleaned up. #4216
---
 agent/conf/agent.properties |  5 +
 .../hypervisor/kvm/resource/LibvirtComputingResource.java   | 13 ++---
 .../hypervisor/kvm/storage/IscsiStorageCleanupMonitor.java  |  3 ++-
 3 files changed, 17 insertions(+), 4 deletions(-)

diff --git a/agent/conf/agent.properties b/agent/conf/agent.properties
index b45526a..426c701 100644
--- a/agent/conf/agent.properties
+++ b/agent/conf/agent.properties
@@ -218,3 +218,8 @@ hypervisor.type=kvm
 # timer.
 # For all actions refer to the libvirt documentation.
 # Recommended values are: none, reset and poweroff.
+#
+iscsi.session.cleanup.enabled=false
+# Automatically clean up iscsi sessions not attached to any VM.
+# Should be enabled for users using managed storage for example solidfire.
+# Should be disabled for users with unmanaged iscsi connections on their hosts
diff --git 
a/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 
b/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
index 950dffa..580d628 100644
--- 
a/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
+++ 
b/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
@@ -61,6 +61,7 @@ import org.apache.cloudstack.utils.security.KeyStoreUtils;
 import org.apache.commons.collections.MapUtils;
 import org.apache.commons.io.FileUtils;
 import org.apache.commons.lang.ArrayUtils;
+import org.apache.commons.lang.BooleanUtils;
 import org.apache.commons.lang.math.NumberUtils;
 import org.apache.log4j.Logger;
 import org.joda.time.Duration;
@@ -1088,9 +1089,15 @@ public class LibvirtComputingResource extends 
ServerResourceBase implements Serv
 storageProcessor.configure(name, params);
 storageHandler = new 
StorageSubsystemCommandHandlerBase(storageProcessor);
 
-IscsiStorageCleanupMonitor isciCleanupMonitor = new 
IscsiStorageCleanupMonitor();
-final Thread cleanupMonitor = new Thread(isciCleanupMonitor);
-cleanupMonitor.start();
+Boolean _iscsiCleanUpEnabled = 
Boolean.parseBoolean((String)params.get("iscsi.session.cleanup.enabled"));
+
+if (BooleanUtils.isTrue(_iscsiCleanUpEnabled)) {
+IscsiStorageCleanupMonitor isciCleanupMonitor = new 
IscsiStorageCleanupMonitor();
+final Thread cleanupMonitor = new Thread(isciCleanupMonitor);
+cleanupMonitor.start();
+} else {
+s_logger.info("iscsi session clean up is disabled");
+}
 
 return true;
 }
diff --git 
a/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/IscsiStorageCleanupMonitor.java
 
b/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/IscsiStorageCleanupMonitor.java
index e5ce6bbd..c8a5fc8 100644
--- 
a/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/IscsiStorageCleanupMonitor.java
+++ 
b/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/IscsiStorageCleanupMonitor.java
@@ -38,6 +38,7 @@ public class IscsiStorageCleanupMonitor implements Runnable{
 private static final String ISCSI_PATH_PREFIX = "/dev/disk/by-path";
 private static final String KEYWORD_ISCSI = "iscsi";
 private static final String KEYWORD_IQN = "iqn";
+private static final String REGEX_PART = "\\S+part\\d+$";
 
 private IscsiAdmStorageAdaptor iscsiStorageAdaptor;
 
@@ -114,7 +115,7 @@ public class IscsiStorageCleanupMonitor implements Runnable{
 
 //check the volume map. If an entry exists change the 
status to True
 for (final LibvirtVMDef.DiskDef disk : disks) {
-if (diskStatusMap.containsKey(disk.getDiskPath())) {
+if 
(diskStatusMap.containsKey(disk.getDiskPath())&&!disk.getDiskPath().matches(REGEX_PART))
 {
 diskStatusMap.put(disk.getDiskPath(), true);
 s_logger.debug("active disk found by cleanup 
thread" + disk.getDiskPath());
 }

[GitHub] [cloudstack] blueorangutan commented on pull request #4278: Usage-server update message improvement

[GitBox]

blueorangutan commented on pull request #4278:
URL: https://github.com/apache/cloudstack/pull/4278#issuecomment-678129656


   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4278: Usage-server update message improvement

[GitBox]

rhtyd commented on pull request #4278:
URL: https://github.com/apache/cloudstack/pull/4278#issuecomment-678129424


   LGTM full test run not necessary, only echo statement changes
   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[cloudstack] branch master updated (3872bf1 -> 961f3ec)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


from 3872bf1  kvm: Enable PVLAN support on L2 networks (#4040)
 add 9681a28  api: Display hypervisor type for VM snapshot (#4275)
 add 961f3ec  Merge remote-tracking branch 'origin/4.14'

No new revisions were added by this update.

Summary of changes:
 .../apache/cloudstack/api/response/VMSnapshotResponse.java  | 13 +
 server/src/main/java/com/cloud/api/ApiResponseHelper.java   |  1 +
 2 files changed, 14 insertions(+)

[cloudstack] branch update-message-for-usage-server updated (62214e0 -> b3eacaf)

[andrijapanic]

This is an automated email from the ASF dual-hosted git repository.

andrijapanic pushed a change to branch update-message-for-usage-server
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


from 62214e0  Update cloud.spec
 add b3eacaf  Update cloudstack-usage.postinst

No new revisions were added by this update.

Summary of changes:
 debian/cloudstack-usage.postinst | 2 ++
 1 file changed, 2 insertions(+)

[cloudstack] branch update-message-for-usage-server updated (0e08dff -> 62214e0)

[andrijapanic]

This is an automated email from the ASF dual-hosted git repository.

andrijapanic pushed a change to branch update-message-for-usage-server
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


from 0e08dff  Update cloud.spec
 add 62214e0  Update cloud.spec

No new revisions were added by this update.

Summary of changes:
 packaging/centos8/cloud.spec | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

[cloudstack] branch update-message-for-usage-server created (now 0e08dff)

[andrijapanic]

This is an automated email from the ASF dual-hosted git repository.

andrijapanic pushed a change to branch update-message-for-usage-server
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


  at 0e08dff  Update cloud.spec

No new revisions were added by this update.

[GitHub] [cloudstack] andrijapanicsb opened a new pull request #4278: Update cloud.spec

[GitBox]

andrijapanicsb opened a new pull request #4278:
URL: https://github.com/apache/cloudstack/pull/4278


   Minor improvement of the usage-server's update message, to make it clear to 
the user what is being done.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support

[GitBox]

blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-678092108


   Packaging result: ✔centos7 ✔centos8 ✔debian. JID-1800



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4264: Changed test failure to warning

[GitBox]

blueorangutan commented on pull request #4264:
URL: https://github.com/apache/cloudstack/pull/4264#issuecomment-678087632


   @Spaceman1984 a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has 
been kicked to run smoke tests



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] Spaceman1984 commented on pull request #4264: Changed test failure to warning

[GitBox]

Spaceman1984 commented on pull request #4264:
URL: https://github.com/apache/cloudstack/pull/4264#issuecomment-678087175


   @blueorangutan test centos7 vmware-67u3



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4264: Changed test failure to warning

[GitBox]

blueorangutan commented on pull request #4264:
URL: https://github.com/apache/cloudstack/pull/4264#issuecomment-678086884


   @Spaceman1984 unsupported parameters provided. Supported mgmt server os are: 
`centos6, centos7, centos8, ubuntu`. Supported hypervisors are: `kvm-centos6, 
kvm-centos7, kvm-centos8, kvm-ubuntu, xenserver-71, xenserver-65sp1, 
vmware-67u3, vmware-65u2, vmware-60u2, vmware-55u3, xcpng76, xcpng80, xcpng81, 
xenserver-74, xcpng74`



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] Spaceman1984 commented on pull request #4264: Changed test failure to warning

[GitBox]

Spaceman1984 commented on pull request #4264:
URL: https://github.com/apache/cloudstack/pull/4264#issuecomment-678086567


   @blueorangutan test vmware-67u3



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] Spaceman1984 commented on pull request #4264: Changed test failure to warning

[GitBox]

Spaceman1984 commented on pull request #4264:
URL: https://github.com/apache/cloudstack/pull/4264#issuecomment-678085954


   @blueorangutan test vmware-67u3



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4264: Changed test failure to warning

[GitBox]

blueorangutan commented on pull request #4264:
URL: https://github.com/apache/cloudstack/pull/4264#issuecomment-678086142


   @Spaceman1984 unsupported parameters provided. Supported mgmt server os are: 
`centos6, centos7, centos8, ubuntu`. Supported hypervisors are: `kvm-centos6, 
kvm-centos7, kvm-centos8, kvm-ubuntu, xenserver-71, xenserver-65sp1, 
vmware-67u3, vmware-65u2, vmware-60u2, vmware-55u3, xcpng76, xcpng80, xcpng81, 
xenserver-74, xcpng74`



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on a change in pull request #4269: cks: test refactoring

[GitBox]

shwstppr commented on a change in pull request #4269:
URL: https://github.com/apache/cloudstack/pull/4269#discussion_r474456659



##
File path: tools/marvin/marvin/config/test_data.py
##
@@ -1847,119 +1847,187 @@
 },
 },
 "configurableData":
-{
-"portableIpRange": {
-"gateway": "10.223.59.1",
-"netmask": "255.255.255.0",
-"startip": "10.223.59.200",
-"endip": "10.223.59.240",
-"vlan": "1000"
-},
-"netscaler": {
-"ipaddress": "",
-"username": "",
-"password": "",
-"networkdevicetype": "",
-"publicinterface": "",
-"privateinterface": "",
-"numretries": "",
-"lbdevicededicated": "False",
-"lbdevicecapacity": 2,
-"port": 22
-},
-"iscsi": {
-"url": "",
-"name": "Primary iSCSI"
-},
-"host": {
-"publicport": 22,
-"username": "root",
-"password": "password",
-},
-"ldap_account": {
-"email": "",
-"firstname": "",
-"lastname": "",
-"username": "",
-"password": "",
-},
-"link_ldap_details": {
-"domain_name": "",
-"accounttype": "",
-"name": "",
-"type": "",
-"admin": "",
-"linkLdapUsername": "",
-"linkLdapPassword": "",
-"linkLdapNestedUser": "",
-"linkLdapNestedPassword": ""
+{
+"portableIpRange": {
+"gateway": "10.223.59.1",
+"netmask": "255.255.255.0",
+"startip": "10.223.59.200",
+"endip": "10.223.59.240",
+"vlan": "1000"
+},
+"netscaler": {
+"ipaddress": "",
+"username": "",
+"password": "",
+"networkdevicetype": "",
+"publicinterface": "",
+"privateinterface": "",
+"numretries": "",
+"lbdevicededicated": "False",
+"lbdevicecapacity": 2,
+"port": 22
+},
+"iscsi": {
+"url": "",
+"name": "Primary iSCSI"
+},
+"host": {
+"publicport": 22,
+"username": "root",
+"password": "password",
+},
+"ldap_account": {
+"email": "",
+"firstname": "",
+"lastname": "",
+"username": "",
+"password": "",
+},
+"link_ldap_details": {
+"domain_name": "",
+"accounttype": "",
+"name": "",
+"type": "",
+"admin": "",
+"linkLdapUsername": "",
+"linkLdapPassword": "",
+"linkLdapNestedUser": "",
+"linkLdapNestedPassword": ""
 
+},
+"ldap_configuration": {
+"basedn": "",
+"emailAttribute": "",
+"userObject": "",
+"usernameAttribute": "",
+"hostname": "",
+"port": "",
+"ldapUsername": "",
+"ldapPassword": ""
+},
+"systemVmDelay": 120,
+"setUsageConfigurationThroughTestCase": True,
+"vmware_cluster": {
+"hypervisor": 'VMware',
+"clustertype": 'ExternalManaged',
+"username": '',
+"password": '',
+"url": '',
+"clustername": 'VMWare Cluster with Space in DC name',
+},
+"upload_volume": {
+"diskname": "UploadVol",
+"format": "VHD",
+"url": 
"http://download.cloudstack.org/releases/2.0.0/UbuntuServer-10-04-64bit.vhd.bz2;,
+"checksum": "",
+},
+"bootableIso":
+{
+"displaytext": "Test Bootable ISO",
+"name": "testISO",
+"bootable": True,
+"ispublic": False,
+"url": "http://dl.openvm.eu/cloudstack/iso/TinyCore-8.0.iso;,
+"ostype": 'Other Linux (64-bit)',
+"mode": 'HTTP_DOWNLOAD'
 },
-"ldap_configuration": {
-"basedn": "",
-"emailAttribute": "",
-"userObject": "",
-"usernameAttribute": "",
-"hostname": "",
-"port": "",
-"ldapUsername": "",
-"ldapPassword": ""
+"setHostConfigurationForIngressRule": False,
+"restartManagementServerThroughTestCase": False,
+"vmxnet3template": {
+"displaytext": "VMXNET3 Template",
+"name": "VMXNET3 template",
+   

[GitHub] [cloudstack] Pearl1594 commented on pull request #4193: Fix usage record count

[GitBox]

Pearl1594 commented on pull request #4193:
URL: https://github.com/apache/cloudstack/pull/4193#issuecomment-678080007


   Hi @olivierlemasle , I've been tied up with other stuff and haven't been 
able to give time to this. However, to get the right count when 
hideIpAddressUsage is true, can be a bit involved inorder to make it efficient. 
   As a first level fix, we can get the pagination issue sorted, as it 
currently works, and for handling hiding IP usage records, we can have another 
PR?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support

[GitBox]

blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-678078831


   @andrijapanicsb a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] andrijapanicsb commented on pull request #4250: [VMware] OVF Full properties support

[GitBox]

andrijapanicsb commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-678076807


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] olivierlemasle commented on pull request #4193: Fix usage record count

[GitBox]

olivierlemasle commented on pull request #4193:
URL: https://github.com/apache/cloudstack/pull/4193#issuecomment-678076531


   Hi @Pearl1594, did you get any chance to look into the pagination issue? 
Thank you!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org