Re: [PR] UI: fix CreateIsolatedNetworkForm.vue [cloudstack]
codecov[bot] commented on PR #9359: URL: https://github.com/apache/cloudstack/pull/9359#issuecomment-2216740962 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9359?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 4.17%. Comparing base [(`0af8835`)](https://app.codecov.io/gh/apache/cloudstack/commit/0af88353fbd08b5c8aecff2cea9ded782f228dd4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`dad8f11`)](https://app.codecov.io/gh/apache/cloudstack/commit/dad8f11461af0c97fae82e6bf0b2bb9590731fb1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > :exclamation: There is a different number of reports uploaded between BASE (0af8835) and HEAD (dad8f11). Click for more details. > > HEAD has 1 upload less than BASE > >| Flag | BASE (0af8835) | HEAD (dad8f11) | >|--|--|--| >|unittests|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #9359 +/- ## - Coverage 15.53% 4.17% -11.37% Files 5492 371 -5121 Lines480931 30420 -450511 Branches 618535390-56463 - Hits 747111269-73442 + Misses 397959 29007 -368952 + Partials 8261 144 -8117 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/9359/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/9359/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.17% <ø> (+<0.01%)` | :arrow_up: | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/9359/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/9359?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch 4.19 updated: NPE fix, for test_hostha_kvm_host_fencing (#9355)
This is an automated email from the ASF dual-hosted git repository.
sureshanaparti pushed a commit to branch 4.19
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/4.19 by this push:
new 37c91abd3d4 NPE fix, for test_hostha_kvm_host_fencing (#9355)
37c91abd3d4 is described below
commit 37c91abd3d4f306cb53fdbe33a37680a5b1f230e
Author: Suresh Kumar Anaparti
AuthorDate: Tue Jul 9 12:20:10 2024 +0530
NPE fix, for test_hostha_kvm_host_fencing (#9355)
---
server/src/main/java/com/cloud/capacity/CapacityManagerImpl.java | 2 ++
1 file changed, 2 insertions(+)
diff --git a/server/src/main/java/com/cloud/capacity/CapacityManagerImpl.java
b/server/src/main/java/com/cloud/capacity/CapacityManagerImpl.java
index 6926f67daea..221f054e9bb 100644
--- a/server/src/main/java/com/cloud/capacity/CapacityManagerImpl.java
+++ b/server/src/main/java/com/cloud/capacity/CapacityManagerImpl.java
@@ -718,6 +718,8 @@ public class CapacityManagerImpl extends ManagerBase
implements CapacityManager,
if (vmDetailCpu != null) {
//if vmDetail_cpu is not null it means it is running in a
overcommited cluster.
cpuOvercommitRatio =
Float.parseFloat(vmDetailCpu.getValue());
+}
+if (vmDetailRam != null) {
ramOvercommitRatio =
Float.parseFloat(vmDetailRam.getValue());
}
ServiceOffering so =
offeringsMap.get(vm.getServiceOfferingId());
Re: [PR] NPE fix, addresses test_hostha_kvm_host_fencing failure [cloudstack]
sureshanaparti merged PR #9355: URL: https://github.com/apache/cloudstack/pull/9355 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] UI: fix CreateIsolatedNetworkForm.vue [cloudstack]
weizhouapache opened a new pull request, #9359:
URL: https://github.com/apache/cloudstack/pull/9359
### Description
This PR fixes the CreateIsolatedNetworkForm.vue in main/4.20 branch.
Due to PR #8919 , the PR #9348 should be ignored in main/4.20 branch.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
How did you try to break this feature and the system with this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NPE fix, addresses test_hostha_kvm_host_fencing failure [cloudstack]
blueorangutan commented on PR #9355: URL: https://github.com/apache/cloudstack/pull/9355#issuecomment-2216709995 [SF] Trillian test result (tid-10771) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 45909 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9355-t10771-kvm-centos7.zip Smoke tests completed. 132 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2216707831 [SF] Trillian test result (tid-10761) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8 Total time taken: 72818 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9315-t10761-vmware-67u3.zip Smoke tests completed. 128 look OK, 4 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_restore_vm | `Error` | 3605.56 | test_restore_vm.py test_02_restore_vm_allocated_root | `Error` | 8.89 | test_restore_vm.py test_02_list_cpvm_vm | `Failure` | 0.05 | test_ssvm.py test_04_cpvm_internals | `Failure` | 0.05 | test_ssvm.py test_11_destroy_ssvm | `Error` | 6.35 | test_ssvm.py test_01_deploy_vm_on_specific_host | `Error` | 18.78 | test_vm_deployment_planner.py test_02_deploy_vm_on_specific_cluster | `Error` | 3601.72 | test_vm_deployment_planner.py test_03_deploy_vm_on_specific_pod | `Error` | 2.35 | test_vm_deployment_planner.py test_04_deploy_vm_on_host_override_pod_and_cluster | `Error` | 1.37 | test_vm_deployment_planner.py test_05_deploy_vm_on_cluster_override_pod | `Error` | 2.38 | test_vm_deployment_planner.py test_09_expunge_vm | `Failure` | 424.68 | test_vm_life_cycle.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] pre-commit: enable Python flake8 rule `E271` [cloudstack]
blueorangutan commented on PR #9358: URL: https://github.com/apache/cloudstack/pull/9358#issuecomment-2216649363 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10303 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] systemvmtemplate: bump new systemvmtemplate 4.19.1 [cloudstack]
blueorangutan commented on PR #9349: URL: https://github.com/apache/cloudstack/pull/9349#issuecomment-2216644279 [SF] Trillian Build Failed (tid-10773) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch main updated (b69cc0272d4 -> 0af88353fbd)
This is an automated email from the ASF dual-hosted git repository. vishesh pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git from b69cc0272d4 pre-commit: enable Python Flake8 rule `E713` (#9016) add f35f3f6a965 UI: create network form constantly tries to list domains - which is not permitted for normal users (#9348) add c35ba606a10 ui: fix account list on domain change in filterview (#9345) add f381763917a test: fix simulator CI failure test_cluster_drs (#9354) add 7977d1475e2 plugins: make default signature check mandatory (#9357) add ca66b76cb92 Fix instance & backup resource table columns (#9147) new 0af88353fbd Merge branch '4.19' The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../apache/cloudstack/saml/SAML2AuthManager.java | 2 +- test/integration/smoke/test_cluster_drs.py | 4 ++- ui/src/components/view/SearchView.vue | 35 +- ui/src/views/network/CreateIsolatedNetworkForm.vue | 3 ++ 4 files changed, 35 insertions(+), 9 deletions(-)
(cloudstack) 01/01: Merge branch '4.19'
This is an automated email from the ASF dual-hosted git repository.
vishesh pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
commit 0af88353fbd08b5c8aecff2cea9ded782f228dd4
Merge: b69cc0272d4 ca66b76cb92
Author: Vishesh
AuthorDate: Tue Jul 9 10:40:21 2024 +0530
Merge branch '4.19'
.../apache/cloudstack/saml/SAML2AuthManager.java | 2 +-
test/integration/smoke/test_cluster_drs.py | 4 ++-
ui/src/components/view/SearchView.vue | 35 +-
ui/src/views/network/CreateIsolatedNetworkForm.vue | 3 ++
4 files changed, 35 insertions(+), 9 deletions(-)
diff --cc ui/src/components/view/SearchView.vue
index b81f1b3c800,a43dfabf868..f642ddf938d
--- a/ui/src/components/view/SearchView.vue
+++ b/ui/src/components/view/SearchView.vue
@@@ -85,10 -86,7 +86,10 @@@
+
+
+
- {{ $t(opt.path || opt.name) }}
+ {{ $t((['storageid'].includes(field.name) ||
!opt.path) ? opt.name : opt.path) }}
Re: [I] Created date not displayed in UI for backups [cloudstack]
sureshanaparti commented on issue #9343: URL: https://github.com/apache/cloudstack/issues/9343#issuecomment-2216541653 @hsato03 @rajujith Fix merged to 4.19 as well, will be available in 4.19.1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Created date not displayed in UI for backups [cloudstack]
sureshanaparti closed issue #9343: Created date not displayed in UI for backups URL: https://github.com/apache/cloudstack/issues/9343 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] saml: make default signature check mandatory [cloudstack]
blueorangutan commented on PR #9357: URL: https://github.com/apache/cloudstack/pull/9357#issuecomment-2216534595 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10301 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Copy on pool host when storage pool has ScopeType.HOST [cloudstack]
blueorangutan commented on PR #9356: URL: https://github.com/apache/cloudstack/pull/9356#issuecomment-2216534593 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10302 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] pre-commit: enable Python flake8 rule `E271` [cloudstack]
blueorangutan commented on PR #9358: URL: https://github.com/apache/cloudstack/pull/9358#issuecomment-2216527792 @jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] pre-commit: enable Python flake8 rule `E271` [cloudstack]
jbampton commented on PR #9358: URL: https://github.com/apache/cloudstack/pull/9358#issuecomment-2216526636 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] pre-commit: enable Python flake8 rule `E271` [cloudstack]
codecov[bot] commented on PR #9358: URL: https://github.com/apache/cloudstack/pull/9358#issuecomment-2216524729 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9358?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 4.17%. Comparing base [(`b69cc02`)](https://app.codecov.io/gh/apache/cloudstack/commit/b69cc0272d48f0aea7353627d760c27c284dad84?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`57417d2`)](https://app.codecov.io/gh/apache/cloudstack/commit/57417d23f1e97227932e23f2d7d838dc747adffa?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > :exclamation: There is a different number of reports uploaded between BASE (b69cc02) and HEAD (57417d2). Click for more details. > > HEAD has 1 upload less than BASE > >| Flag | BASE (b69cc02) | HEAD (57417d2) | >|--|--|--| >|unittests|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #9358 +/- ## - Coverage 15.53% 4.17% -11.37% Files 5492 371 -5121 Lines480917 30408 -450509 Branches 621875384-56803 - Hits 747111269-73442 + Misses 397945 28995 -368950 + Partials 8261 144 -8117 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/9358/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/9358/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.17% <ø> (ø)` | | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/9358/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/9358?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Copy on pool host when storage pool has ScopeType.HOST [cloudstack]
blueorangutan commented on PR #9356: URL: https://github.com/apache/cloudstack/pull/9356#issuecomment-2216521262 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10299 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch 4.19 updated: Fix instance & backup resource table columns (#9147)
This is an automated email from the ASF dual-hosted git repository.
vishesh pushed a commit to branch 4.19
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/4.19 by this push:
new ca66b76cb92 Fix instance & backup resource table columns (#9147)
ca66b76cb92 is described below
commit ca66b76cb92be368bbea40a3bdb2f4e54c0a32d2
Author: Henrique Sato
AuthorDate: Fri Jun 7 04:55:54 2024 -0300
Fix instance & backup resource table columns (#9147)
Co-authored-by: Henrique Sato
---
ui/src/components/view/ListResourceTable.vue | 21 ++---
1 file changed, 10 insertions(+), 11 deletions(-)
diff --git a/ui/src/components/view/ListResourceTable.vue
b/ui/src/components/view/ListResourceTable.vue
index 16c1b388c5d..a7e805b5443 100644
--- a/ui/src/components/view/ListResourceTable.vue
+++ b/ui/src/components/view/ListResourceTable.vue
@@ -41,21 +41,20 @@
{{ text }}
-
-
- {{ text }}
-
+
+{{ text }}
+
-
- {{ text }}
-
-
+
+{{ $toLocaleDate(text) }}
+
-
-{{ $toLocaleDate(item) }}
+
+{{ text }}
+
+
-
[PR] pre-commit: enable Python flake8 rule `E271` [cloudstack]
jbampton opened a new pull request, #9358:
URL: https://github.com/apache/cloudstack/pull/9358
E271 Multiple spaces after keyword.
There should be only one space after a keyword.
https://www.flake8rules.com/rules/E271.html
### Description
This PR cleans up and standardizes the Python code.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [X] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
Ran locally:
`pre-commit run --all-files`
How did you try to break this feature and the system with this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
(cloudstack) branch 4.19 updated: plugins: make default signature check mandatory (#9357)
This is an automated email from the ASF dual-hosted git repository.
sureshanaparti pushed a commit to branch 4.19
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/4.19 by this push:
new 7977d1475e2 plugins: make default signature check mandatory (#9357)
7977d1475e2 is described below
commit 7977d1475e23c1a801d7d300810e0dd2d429158f
Author: Rohit Yadav
AuthorDate: Tue Jul 9 09:49:27 2024 +0530
plugins: make default signature check mandatory (#9357)
This improves upon #9219, to make the signature checks mandatory by
default but allows for users to relax the setting if they really must.
Signed-off-by: Rohit Yadav
---
.../src/main/java/org/apache/cloudstack/saml/SAML2AuthManager.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/plugins/user-authenticators/saml2/src/main/java/org/apache/cloudstack/saml/SAML2AuthManager.java
b/plugins/user-authenticators/saml2/src/main/java/org/apache/cloudstack/saml/SAML2AuthManager.java
index a5dae36581c..27f17cee6b1 100644
---
a/plugins/user-authenticators/saml2/src/main/java/org/apache/cloudstack/saml/SAML2AuthManager.java
+++
b/plugins/user-authenticators/saml2/src/main/java/org/apache/cloudstack/saml/SAML2AuthManager.java
@@ -70,7 +70,7 @@ public interface SAML2AuthManager extends
PluggableAPIAuthenticator, PluggableSe
ConfigKey SAMLTimeout = new ConfigKey("Advanced",
Integer.class, "saml2.timeout", "1800",
"SAML2 IDP Metadata refresh interval in seconds, minimum value is
set to 300", true);
-ConfigKey SAMLCheckSignature = new ConfigKey("Advanced",
Boolean.class, "saml2.check.signature", "false",
+ConfigKey SAMLCheckSignature = new ConfigKey("Advanced",
Boolean.class, "saml2.check.signature", "true",
"Whether SAML2 signature must be checked, when enforced and when
the SAML response does not have a signature would lead to login exception",
true);
public SAMLProviderMetadata getSPMetadata();
Re: [PR] saml: make default signature check mandatory [cloudstack]
sureshanaparti merged PR #9357: URL: https://github.com/apache/cloudstack/pull/9357 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] saml: make default signature check mandatory [cloudstack]
codecov[bot] commented on PR #9357: URL: https://github.com/apache/cloudstack/pull/9357#issuecomment-2216473822 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9357?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 4.27%. Comparing base [(`f381763`)](https://app.codecov.io/gh/apache/cloudstack/commit/f381763917a73420a4dbc553ec800bf5c153da8b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`0c4a9b0`)](https://app.codecov.io/gh/apache/cloudstack/commit/0c4a9b03a155cc508ec4bab014c79002dcbfcf6c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > :exclamation: There is a different number of reports uploaded between BASE (f381763) and HEAD (0c4a9b0). Click for more details. > > HEAD has 1 upload less than BASE > >| Flag | BASE (f381763) | HEAD (0c4a9b0) | >|--|--|--| >|unittests|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## 4.19 #9357 +/- ## - Coverage 15.07% 4.27% -10.81% Files 5405 365 -5040 Lines472667 29505 -443162 Branches 608665161-55705 - Hits 712691261-70008 + Misses 393468 28101 -365367 + Partials 7930 143 -7787 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/9357/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/9357/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.27% <ø> (ø)` | | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/9357/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/9357?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Copy on pool host when storage pool has ScopeType.HOST [cloudstack]
blueorangutan commented on PR #9356: URL: https://github.com/apache/cloudstack/pull/9356#issuecomment-2216465469 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Copy on pool host when storage pool has ScopeType.HOST [cloudstack]
sureshanaparti commented on PR #9356: URL: https://github.com/apache/cloudstack/pull/9356#issuecomment-2216458737 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] saml: make default signature check mandatory [cloudstack]
blueorangutan commented on PR #9357: URL: https://github.com/apache/cloudstack/pull/9357#issuecomment-2216451087 @rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] saml: make default signature check mandatory [cloudstack]
rohityadavcloud commented on PR #9357: URL: https://github.com/apache/cloudstack/pull/9357#issuecomment-2216447002 Smoketests/Github actions may be enough + packaging tests @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] plugins: make default signature check mandatory [cloudstack]
rohityadavcloud opened a new pull request, #9357: URL: https://github.com/apache/cloudstack/pull/9357 This improves upon #9219, to make the signature checks mandatory by default but allows for users to relax the setting if they really must. ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [x] Enhancement (improves an existing feature and functionality) - [x] Cleanup (Code refactoring and cleanup, that may add test cases) - [ ] build/CI - [ ] test (unit or integration test code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] systemvmtemplate: bump new systemvmtemplate 4.19.1 [cloudstack]
blueorangutan commented on PR #9349: URL: https://github.com/apache/cloudstack/pull/9349#issuecomment-2216423878 @rohityadavcloud a [SL] Trillian-Jenkins test job (alma8 mgmt + xcpng82) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] systemvmtemplate: bump new systemvmtemplate 4.19.1 [cloudstack]
rohityadavcloud commented on PR #9349: URL: https://github.com/apache/cloudstack/pull/9349#issuecomment-2216415092 @blueorangutan test alma8 xcpng82 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Copy on pool host when storage pool has ScopeType.HOST [cloudstack]
codecov[bot] commented on PR #9356: URL: https://github.com/apache/cloudstack/pull/9356#issuecomment-2216404831 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9356?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 4.27%. Comparing base [(`f381763`)](https://app.codecov.io/gh/apache/cloudstack/commit/f381763917a73420a4dbc553ec800bf5c153da8b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`e0f80db`)](https://app.codecov.io/gh/apache/cloudstack/commit/e0f80db933dee620611a240794639e6aebfadc63?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > :exclamation: There is a different number of reports uploaded between BASE (f381763) and HEAD (e0f80db). Click for more details. > > HEAD has 1 upload less than BASE > >| Flag | BASE (f381763) | HEAD (e0f80db) | >|--|--|--| >|unittests|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## 4.19 #9356 +/- ## - Coverage 15.07% 4.27% -10.81% Files 5405 365 -5040 Lines472667 29505 -443162 Branches 608665161-55705 - Hits 712691261-70008 + Misses 393468 28101 -365367 + Partials 7930 143 -7787 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/9356/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/9356/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.27% <ø> (ø)` | | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/9356/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/9356?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] systemvmtemplate: bump new systemvmtemplate 4.19.1 [cloudstack]
blueorangutan commented on PR #9349: URL: https://github.com/apache/cloudstack/pull/9349#issuecomment-2216400097 [SF] Trillian test result (tid-10765) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 60342 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9349-t10765-kvm-centos7.zip Smoke tests completed. 128 look OK, 4 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_11_destroy_ssvm | `Error` | 3.18 | test_ssvm.py test_03_secured_to_nonsecured_vm_migration | `Error` | 355.20 | test_vm_life_cycle.py test_05_rvpc_multi_tiers | `Failure` | 498.57 | test_vpc_redundant.py test_05_rvpc_multi_tiers | `Error` | 498.59 | test_vpc_redundant.py test_hostha_enable_ha_when_host_disabled | `Error` | 3.73 | test_hostha_kvm.py test_hostha_enable_ha_when_host_in_maintenance | `Error` | 301.85 | test_hostha_kvm.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] systemvmtemplate: bump new systemvmtemplate 4.19.1 [cloudstack]
blueorangutan commented on PR #9349: URL: https://github.com/apache/cloudstack/pull/9349#issuecomment-2216383028 @rohityadavcloud [SL] I understand these words: "help", "hello", "thanks", "package", "test" Test command usage: test [mgmt os] [hypervisor] [keepEnv] [qemuEv] [basicZone|securityGroups] Mgmt OS options: ['centos7', 'centos6', 'alma9', 'suse15', 'alma8', 'ubuntu18', 'ubuntu22', 'ubuntu20', 'rocky8', 'ubuntu24'] Hypervisor options: ['kvm-centos6', 'kvm-centos7', 'kvm-rocky8', 'kvm-alma8', 'kvm-alma9', 'kvm-ubuntu18', 'kvm-ubuntu20', 'kvm-ubuntu22', 'kvm-ubuntu24', 'kvm-suse15', 'vmware-55u3', 'vmware-60u2', 'vmware-65u2', 'vmware-67u3', 'vmware-70u1', 'vmware-70u2', 'vmware-70u3', 'vmware-80', 'vmware-80u1', 'xenserver-65sp1', 'xenserver-71', 'xenserver-74', 'xcpng74', 'xcpng76', 'xcpng80', 'xcpng81', 'xcpng82'] Note: when keepEnv is passed, you need to specify mgmt server os and hypervisor or use the `matrix` command. when qemuEv is passed, it will deploy KVM hyperviosr hosts with qemu-kvm-ev, else it will default to stock qemu. When basicZone and/or securityGroups are passed it will create a zone of the last type specified (default is Advanced) Package command usage: package [all(default value),kvm,xen,vmware,hyperv,ovm] - a comma separated list can be passed with package command to bundle the required hypervisor's systemVM templates. Not passing any argument will bundle all - kvm,xen and vmware templates. Blessed contributors for kicking Trillian test jobs: ['rohityadavcloud', 'shwstppr', 'vishesh92', 'Pearl1594', 'harikrishna-patnala', 'nvazquez', 'DaanHoogland', 'weizhouapache', 'borisstoyanov', 'vladimirpetrov', 'kiranchavala', 'andrijapanicsb', 'NuxRo', 'rajujith', 'alexandremattioli', 'sureshanaparti', 'mlsorensen', 'oscaralvaro', 'abh1sar'] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Copy on pool host when storage pool has ScopeType.HOST [cloudstack]
blueorangutan commented on PR #9356: URL: https://github.com/apache/cloudstack/pull/9356#issuecomment-2216375278 @rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] systemvmtemplate: bump new systemvmtemplate 4.19.1 [cloudstack]
rohityadavcloud commented on PR #9349: URL: https://github.com/apache/cloudstack/pull/9349#issuecomment-2216375094 @blueorangutan help -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Copy on pool host when storage pool has ScopeType.HOST [cloudstack]
rohityadavcloud commented on PR #9356: URL: https://github.com/apache/cloudstack/pull/9356#issuecomment-2216373955 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2216354728 [SF] Trillian test result (tid-10769) Environment: kvm-alma8 (x2), Advanced Networking with Mgmt server a8 Total time taken: 44904 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9315-t10769-kvm-alma8.zip Smoke tests completed. 132 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] pre-commit: check more file types for trailing whitespace [cloudstack]
jbampton commented on code in PR #9352: URL: https://github.com/apache/cloudstack/pull/9352#discussion_r1669622409 ## .pre-commit-config.yaml: ## @@ -59,8 +59,9 @@ repos: - id: mixed-line-ending exclude: \.(cs|xml)$ - id: trailing-whitespace -files: \.(in|java|md|py|rb|sh|vue|yaml|yml)$ +files: \.(header|in|java|md|properties|py|rb|sh|sql|txt|vue|yaml|yml)$ Review Comment: At least one https://github.com/apache/cloudstack/blob/main/LICENSE.header -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] IPv4 Static Routing (Routed mode) [cloudstack]
blueorangutan commented on PR #9346: URL: https://github.com/apache/cloudstack/pull/9346#issuecomment-2216316730 [SF] Trillian test result (tid-10768) Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8 Total time taken: 53374 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9346-t10768-kvm-rocky8.zip Smoke tests completed. 136 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_06_purge_expunged_vm_background_task | `Failure` | 341.59 | test_purge_expunged_vms.py test_01_secure_vm_migration | `Error` | 134.42 | test_vm_life_cycle.py test_01_secure_vm_migration | `Error` | 134.42 | test_vm_life_cycle.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] IPv4 Static Routing (Routed mode) [cloudstack]
blueorangutan commented on PR #9346: URL: https://github.com/apache/cloudstack/pull/9346#issuecomment-2216304953 [SF] Trillian test result (tid-10767) Environment: vmware-80 (x2), Advanced Networking with Mgmt server r8 Total time taken: 53032 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9346-t10767-vmware-80.zip Smoke tests completed. 135 look OK, 3 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_06_purge_expunged_vm_background_task | `Failure` | 351.62 | test_purge_expunged_vms.py test_02_restore_vm_with_disk_offering | `Error` | 63.56 | test_restore_vm.py test_03_restore_vm_with_disk_offering_custom_size | `Error` | 56.38 | test_restore_vm.py test_01_sys_vm_start | `Failure` | 0.10 | test_secondary_storage.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] systemvmtemplate: bump new systemvmtemplate 4.19.1 [cloudstack]
blueorangutan commented on PR #9349: URL: https://github.com/apache/cloudstack/pull/9349#issuecomment-2216262267 [SF] Trillian test result (tid-10766) Environment: kvm-alma8 (x2), Advanced Networking with Mgmt server a8 Total time taken: 51298 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9349-t10766-kvm-alma8.zip Smoke tests completed. 131 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_list_cpvm_vm | `Failure` | 0.05 | test_ssvm.py test_04_cpvm_internals | `Failure` | 0.05 | test_ssvm.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2215875092 [SF] Trillian test result (tid-10762) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 51883 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9315-t10762-kvm-centos7.zip Smoke tests completed. 129 look OK, 3 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_redundant_VPC_default_routes | `Failure` | 371.27 | test_vpc_redundant.py test_05_rvpc_multi_tiers | `Failure` | 509.30 | test_vpc_redundant.py test_05_rvpc_multi_tiers | `Error` | 509.31 | test_vpc_redundant.py test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 225.04 | test_host_maintenance.py test_hostha_kvm_host_fencing | `Error` | 111.61 | test_hostha_kvm.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] systemvmtemplate: bump new systemvmtemplate 4.19.1 [cloudstack]
blueorangutan commented on PR #9349: URL: https://github.com/apache/cloudstack/pull/9349#issuecomment-2215811512 [SF] Trillian test result (tid-10764) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8 Total time taken: 48772 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9349-t10764-vmware-67u3.zip Smoke tests completed. 132 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2215440467 [SF] Trillian test result (tid-10760) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 42406 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9315-t10760-xenserver-71.zip Smoke tests completed. 132 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Copy on pool host when storage pool has ScopeType.HOST [cloudstack]
rg9975 opened a new pull request, #9356:
URL: https://github.com/apache/cloudstack/pull/9356
### Description
This PR fixes an issue with storage volume migrations when a storage pool
(source or destination) has ScopeType.HOST set. Prior to this PR, the code in
StorageSystemDataMotionStrategy selected any host in the cluster if the source
storage pool did not have a cluster ID, or a host in the cluster if it did.
This effectively breaks ScopeType.HOST copies except when the selection
resulted in the specific host the other storage pool resides on.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [X] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [X] Major
- [ ] Minor
- [ ] Trivial
### How Has This Been Tested?
Performed copies between a local KVM storage pool and a FiberChannelAdapter
storage pool.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [HEALTH] 4.18 LTS Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #9317: URL: https://github.com/apache/cloudstack/pull/9317#issuecomment-2215225022 [SF] Trillian test result (tid-10755) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8 Total time taken: 49506 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9317-t10755-vmware-67u3.zip Smoke tests completed. 110 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] pre-commit: check more file types for trailing whitespace [cloudstack]
blueorangutan commented on PR #9352: URL: https://github.com/apache/cloudstack/pull/9352#issuecomment-2215205201 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10297 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump actions/cache to `v4` [cloudstack]
blueorangutan commented on PR #9353: URL: https://github.com/apache/cloudstack/pull/9353#issuecomment-2215195814 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10296 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] test: fix simulator CI failure test_cluster_drs [cloudstack]
vishesh92 merged PR #9354: URL: https://github.com/apache/cloudstack/pull/9354 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch 4.19 updated: test: fix simulator CI failure test_cluster_drs (#9354)
This is an automated email from the ASF dual-hosted git repository. vishesh pushed a commit to branch 4.19 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.19 by this push: new f381763917a test: fix simulator CI failure test_cluster_drs (#9354) f381763917a is described below commit f381763917a73420a4dbc553ec800bf5c153da8b Author: Wei Zhou AuthorDate: Mon Jul 8 21:48:50 2024 +0200 test: fix simulator CI failure test_cluster_drs (#9354) --- test/integration/smoke/test_cluster_drs.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/test/integration/smoke/test_cluster_drs.py b/test/integration/smoke/test_cluster_drs.py index 8b4801849fd..f1eb48f92f5 100644 --- a/test/integration/smoke/test_cluster_drs.py +++ b/test/integration/smoke/test_cluster_drs.py @@ -100,7 +100,9 @@ class TestClusterDRS(cloudstackTestCase): ) cls._cleanup.append(cls.network) -cls.migrateSvms(cls.cluster) +cls.hypervisor = cls.testClient.getHypervisorInfo() +if cls.hypervisor.lower() not in ['simulator']: +cls.migrateSvms(cls.cluster) @classmethod def migrateSvms(cls, cluster):
Re: [PR] [HEALTH] 4.18 LTS Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #9317: URL: https://github.com/apache/cloudstack/pull/9317#issuecomment-2215049527 [SF] Trillian test result (tid-10756) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 46626 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9317-t10756-kvm-centos7.zip Smoke tests completed. 108 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 201.87 | test_host_maintenance.py test_hostha_kvm_host_fencing | `Error` | 111.60 | test_hostha_kvm.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] pre-commit: check more file types for trailing whitespace [cloudstack]
DaanHoogland commented on code in PR #9352: URL: https://github.com/apache/cloudstack/pull/9352#discussion_r1669171260 ## .pre-commit-config.yaml: ## @@ -59,8 +59,9 @@ repos: - id: mixed-line-ending exclude: \.(cs|xml)$ - id: trailing-whitespace -files: \.(in|java|md|py|rb|sh|vue|yaml|yml)$ +files: \.(header|in|java|md|properties|py|rb|sh|sql|txt|vue|yaml|yml)$ Review Comment: any .header files? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump actions/cache to `v4` [cloudstack]
blueorangutan commented on PR #9353: URL: https://github.com/apache/cloudstack/pull/9353#issuecomment-2214971282 @jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] pre-commit: check more file types for trailing whitespace [cloudstack]
blueorangutan commented on PR #9352: URL: https://github.com/apache/cloudstack/pull/9352#issuecomment-2214971363 @jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump actions/cache to `v4` [cloudstack]
jbampton commented on PR #9353: URL: https://github.com/apache/cloudstack/pull/9353#issuecomment-2214966620 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] pre-commit: check more file types for trailing whitespace [cloudstack]
jbampton commented on PR #9352: URL: https://github.com/apache/cloudstack/pull/9352#issuecomment-2214965878 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.18 LTS Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #9317: URL: https://github.com/apache/cloudstack/pull/9317#issuecomment-2214913227 [SF] Trillian test result (tid-10754) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 42721 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9317-t10754-xenserver-71.zip Smoke tests completed. 110 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Created date not displayed in UI for backups [cloudstack]
hsato03 commented on issue #9343: URL: https://github.com/apache/cloudstack/issues/9343#issuecomment-2214838461 #9147 fixed this, but was merged into main. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NPE fix, addresses test_hostha_kvm_host_fencing failure [cloudstack]
blueorangutan commented on PR #9355: URL: https://github.com/apache/cloudstack/pull/9355#issuecomment-2214786144 @sureshanaparti a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NPE fix, addresses test_hostha_kvm_host_fencing failure [cloudstack]
sureshanaparti commented on PR #9355: URL: https://github.com/apache/cloudstack/pull/9355#issuecomment-2214783069 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NPE fix, addresses test_hostha_kvm_host_fencing failure [cloudstack]
blueorangutan commented on PR #9355: URL: https://github.com/apache/cloudstack/pull/9355#issuecomment-2214781613 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10295 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.18 LTS Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #9317: URL: https://github.com/apache/cloudstack/pull/9317#issuecomment-2214733908 [SF] Trillian Build Failed (tid-10770) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NPE fix, addresses test_hostha_kvm_host_fencing failure [cloudstack]
codecov[bot] commented on PR #9355: URL: https://github.com/apache/cloudstack/pull/9355#issuecomment-2214638774 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9355?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 4.27%. Comparing base [(`c35ba60`)](https://app.codecov.io/gh/apache/cloudstack/commit/c35ba606a10242a218d0686015288d8363cf30d5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`596b462`)](https://app.codecov.io/gh/apache/cloudstack/commit/596b4628fa1ee95e0d48808387857bd649be8e9c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > :exclamation: There is a different number of reports uploaded between BASE (c35ba60) and HEAD (596b462). Click for more details. > > HEAD has 1 upload less than BASE > >| Flag | BASE (c35ba60) | HEAD (596b462) | >|--|--|--| >|unittests|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## 4.19 #9355 +/- ## - Coverage 15.07% 4.27% -10.81% Files 5405 365 -5040 Lines472667 29505 -443162 Branches 599455161-54784 - Hits 712681261-70007 + Misses 393468 28101 -365367 + Partials 7931 143 -7788 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/9355/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/9355/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.27% <ø> (ø)` | | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/9355/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/9355?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NPE fix, addresses test_hostha_kvm_host_fencing failure [cloudstack]
blueorangutan commented on PR #9355: URL: https://github.com/apache/cloudstack/pull/9355#issuecomment-2214614225 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NPE fix, addresses test_hostha_kvm_host_fencing failure [cloudstack]
sureshanaparti commented on PR #9355: URL: https://github.com/apache/cloudstack/pull/9355#issuecomment-2214611200 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] NPE fix, addresses test_hostha_kvm_host_fencing failure [cloudstack]
sureshanaparti opened a new pull request, #9355:
URL: https://github.com/apache/cloudstack/pull/9355
### Description
This PR fixes NPE issue, addresses test_hostha_kvm_host_fencing failure.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [x] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
Tested the marvin test.
**Before fix =>**
```
Marvin Init Started
=== Marvin Parse Config Successful ===
=== Marvin Setting TestData Successful===
Log Folder Path: /marvin/MarvinLogs/Jul_08_2024_14_43_35_J24KMY All
logs will be available here
=== Marvin Init Logging Successful===
Marvin Init Successful
checkForState:: expected=Available, actual={haenable : True, hastate :
'Available', haprovider : 'kvmhaprovider'}
checkForState:: expected=Suspect, actual={haenable : True, hastate :
'Suspect', haprovider : 'kvmhaprovider'}
checkForState:: expected=Fencing, actual={haenable : True, hastate :
'Suspect', haprovider : 'kvmhaprovider'}
checkForState:: expected=Fencing, actual={haenable : True, hastate :
'Suspect', haprovider : 'kvmhaprovider'}
checkForState:: expected=Fencing, actual={haenable : True, hastate :
'Suspect', haprovider : 'kvmhaprovider'}
checkForState:: expected=Fencing, actual={haenable : True, hastate :
'Suspect', haprovider : 'kvmhaprovider'}
checkForState:: expected=Fencing, actual={haenable : True, hastate :
'Suspect', haprovider : 'kvmhaprovider'}
checkForState:: expected=Fencing, actual={haenable : True, hastate :
'Suspect', haprovider : 'kvmhaprovider'}
checkForState:: expected=Fencing, actual={haenable : True, hastate :
'Suspect', haprovider : 'kvmhaprovider'}
checkForState:: expected=Fencing, actual={haenable : True, hastate :
'Suspect', haprovider : 'kvmhaprovider'}
checkForState:: expected=Fencing, actual={haenable : True, hastate :
'Suspect', haprovider : 'kvmhaprovider'}
checkForState:: expected=Fencing, actual={haenable : True, hastate :
'Suspect', haprovider : 'kvmhaprovider'}
checkForState:: expected=Fencing, actual={haenable : True, hastate :
'Degraded', haprovider : 'kvmhaprovider'}
checkForState:: expected=Fencing, actual={haenable : True, hastate :
'Degraded', haprovider : 'kvmhaprovider'}
checkForState:: expected=Fencing, actual={haenable : True, hastate :
'Degraded', haprovider : 'kvmhaprovider'}
checkForState:: expected=Fencing, actual={haenable : True, hastate :
'Degraded', haprovider : 'kvmhaprovider'}
checkForState:: expected=Fencing, actual={haenable : True, hastate :
'Degraded', haprovider : 'kvmhaprovider'}
checkForState:: expected=Fencing, actual={haenable : True, hastate :
'Degraded', haprovider : 'kvmhaprovider'}
checkForState:: expected=Fencing, actual={haenable : True, hastate :
'Degraded', haprovider : 'kvmhaprovider'}
checkForState:: expected=Fencing, actual={haenable : True, hastate :
'Degraded', haprovider : 'kvmhaprovider'}
checkForState:: expected=Fencing, actual={haenable : True, hastate :
'Degraded', haprovider : 'kvmhaprovider'}
checkForState:: expected=Fencing, actual={haenable : True, hastate :
'Degraded', haprovider : 'kvmhaprovider'}
checkForState:: expected=Fencing, actual={haenable : True, hastate :
'Degraded', haprovider : 'kvmhaprovider'}
checkForState:: expected=Fencing, actual={haenable : True, hastate :
'Suspect', haprovider : 'kvmhaprovider'}
checkForState:: expected=Fencing, actual={haenable : True, hastate :
'Suspect', haprovider : 'kvmhaprovider'}
checkForState:: expected=Fencing, actual={haenable : True, hastate :
'Suspect', haprovider : 'kvmhaprovider'}
checkForState:: expected=Fencing, actual={haenable : True, hastate :
'Suspect', haprovider : 'kvmhaprovider'}
checkForState:: expected=Fencing, actual={haenable : True, hastate :
'Suspect', haprovider : 'kvmhaprovider'}
checkForState:: expected=Fencing, actual={haenable : True, hastate :
'Suspect', haprovider : 'kvmhaprovider'}
checkForState:: expected=Fencing, actual={haenable : True, hastate :
'Suspect', haprovider : 'kvmhaprovider'}
checkForState:: expected=Fencing, actual={haenable : True, hastate :
'Suspect', haprovider : 'kvmhaprovider'}
checkForSt
Re: [PR] test: fix simulator CI test_cluster_drs [cloudstack]
codecov[bot] commented on PR #9354: URL: https://github.com/apache/cloudstack/pull/9354#issuecomment-2214476216 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9354?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 4.27%. Comparing base [(`c35ba60`)](https://app.codecov.io/gh/apache/cloudstack/commit/c35ba606a10242a218d0686015288d8363cf30d5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`18904ae`)](https://app.codecov.io/gh/apache/cloudstack/commit/18904aed17f9af7f8a44f0fb27696e1363be0ec4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > :exclamation: There is a different number of reports uploaded between BASE (c35ba60) and HEAD (18904ae). Click for more details. > > HEAD has 1 upload less than BASE > >| Flag | BASE (c35ba60) | HEAD (18904ae) | >|--|--|--| >|unittests|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## 4.19 #9354 +/- ## - Coverage 15.07% 4.27% -10.81% Files 5405 365 -5040 Lines472667 29505 -443162 Branches 599455161-54784 - Hits 712681261-70007 + Misses 393468 28101 -365367 + Partials 7931 143 -7788 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/9354/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/9354/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.27% <ø> (ø)` | | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/9354/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/9354?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] test: fix simulator CI test_cluster_drs [cloudstack]
weizhouapache opened a new pull request, #9354:
URL: https://github.com/apache/cloudstack/pull/9354
### Description
This PR...
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
How did you try to break this feature and the system with this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2214238799 @sureshanaparti a [SL] Trillian-Jenkins test job (alma8 mgmt + kvm-alma8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]
sureshanaparti commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2214232993 @blueorangutan test alma8 kvm-alma8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump actions/cache to `v4` [cloudstack]
codecov[bot] commented on PR #9353: URL: https://github.com/apache/cloudstack/pull/9353#issuecomment-2214216529 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9353?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 4.17%. Comparing base [(`b69cc02`)](https://app.codecov.io/gh/apache/cloudstack/commit/b69cc0272d48f0aea7353627d760c27c284dad84?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`5c59629`)](https://app.codecov.io/gh/apache/cloudstack/commit/5c5962947bf4c1fe014d7ddd178ed6a24d6efd37?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > :exclamation: There is a different number of reports uploaded between BASE (b69cc02) and HEAD (5c59629). Click for more details. > > HEAD has 1 upload less than BASE > >| Flag | BASE (b69cc02) | HEAD (5c59629) | >|--|--|--| >|unittests|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #9353 +/- ## - Coverage 15.53% 4.17% -11.37% Files 5492 371 -5121 Lines480917 30408 -450509 Branches 621875384-56803 - Hits 747111269-73442 + Misses 397945 28995 -368950 + Partials 8261 144 -8117 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/9353/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/9353/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.17% <ø> (ø)` | | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/9353/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/9353?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump actions/cache to `v4` [cloudstack]
jbampton opened a new pull request, #9353:
URL: https://github.com/apache/cloudstack/pull/9353
https://github.com/actions/cache
### Description
This PR bumps actions/cache to version 4.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [X] build/CI
- [ ] test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
How did you try to break this feature and the system with this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] pre-commit: check more file types for trailing whitespace [cloudstack]
codecov[bot] commented on PR #9352: URL: https://github.com/apache/cloudstack/pull/9352#issuecomment-2214120699 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9352?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 4.17%. Comparing base [(`b69cc02`)](https://app.codecov.io/gh/apache/cloudstack/commit/b69cc0272d48f0aea7353627d760c27c284dad84?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`cffe9c9`)](https://app.codecov.io/gh/apache/cloudstack/commit/cffe9c92be348edd11228b3805c92f1f1bb49bef?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > :exclamation: There is a different number of reports uploaded between BASE (b69cc02) and HEAD (cffe9c9). Click for more details. > > HEAD has 1 upload less than BASE > >| Flag | BASE (b69cc02) | HEAD (cffe9c9) | >|--|--|--| >|unittests|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #9352 +/- ## - Coverage 15.53% 4.17% -11.37% Files 5492 371 -5121 Lines480917 30408 -450509 Branches 621875384-56803 - Hits 747111269-73442 + Misses 397945 28995 -368950 + Partials 8261 144 -8117 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/9352/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/9352/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.17% <ø> (ø)` | | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/9352/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/9352?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] pre-commit: check more file types for trailing whitespace [cloudstack]
jbampton opened a new pull request, #9352:
URL: https://github.com/apache/cloudstack/pull/9352
### Description
This PR checks more file types for unneeded trailing whitespace.
Trailing whitespace is just extra data that we don't need.
This hook when run locally will automatically trim the trailing whitespace.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [X] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
How did you try to break this feature and the system with this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2214022969 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10293 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] pre-commit: add `XML` files to the `trailing-whitespace` check [cloudstack]
jbampton commented on PR #9131: URL: https://github.com/apache/cloudstack/pull/9131#issuecomment-2213993106 Hey @DaanHoogland I want to focus this PR just on one check or test for trailing whitespace in the XML files. In future we can do more clean ups since this PR already has over 3,000+ lines changed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] pre-commit: add `codespell` to check spelling [cloudstack]
jbampton commented on PR #8197: URL: https://github.com/apache/cloudstack/pull/8197#issuecomment-2213959538 Hey @DaanHoogland the list of words in `.github/linters/codespell.txt` will need fixing in other PRs in future. Basically codespell ignores those words when it runs the spell check. So this PR is just adding the codespell test and making sure it passes. You can see that on the last commit in this PR we are regressing and new misspelled words have been added. https://github.com/apache/cloudstack/pull/8197/commits/7384e8220cda32f5674e9133527a3e514f802858 So until we get this PR merged misspelled words will continue to be added the codebase. In future as we clean up and and fix spelling we will recreate the ignored word list hopefully with less misspelled words each time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] ui: fix account list on domain change in filterview [cloudstack]
blueorangutan commented on PR #9345: URL: https://github.com/apache/cloudstack/pull/9345#issuecomment-2213852240 UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9345 (QA-JID-399) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2213832538 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]
sureshanaparti commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2213824159 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch healthcheck-4.19 updated (4f2258786fa -> 21ecf990247)
This is an automated email from the ASF dual-hosted git repository. sureshanaparti pushed a change to branch healthcheck-4.19 in repository https://gitbox.apache.org/repos/asf/cloudstack.git omit 4f2258786fa DO NOT MERGE add c35ba606a10 ui: fix account list on domain change in filterview (#9345) add 21ecf990247 DO NOT MERGE This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (4f2258786fa) \ N -- N -- N refs/heads/healthcheck-4.19 (21ecf990247) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes: ui/src/components/view/SearchView.vue | 35 --- 1 file changed, 28 insertions(+), 7 deletions(-)
Re: [I] Search filter does not work for domain/account [cloudstack]
sureshanaparti commented on issue #9274: URL: https://github.com/apache/cloudstack/issues/9274#issuecomment-2213810991 Fixed in #9345 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Search filter does not work for domain/account [cloudstack]
sureshanaparti closed issue #9274: Search filter does not work for domain/account URL: https://github.com/apache/cloudstack/issues/9274 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch 4.19 updated: ui: fix account list on domain change in filterview (#9345)
This is an automated email from the ASF dual-hosted git repository.
sureshanaparti pushed a commit to branch 4.19
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/4.19 by this push:
new c35ba606a10 ui: fix account list on domain change in filterview (#9345)
c35ba606a10 is described below
commit c35ba606a10242a218d0686015288d8363cf30d5
Author: Abhishek Kumar
AuthorDate: Mon Jul 8 17:24:38 2024 +0530
ui: fix account list on domain change in filterview (#9345)
* ui: fix account list on domain change in filterview
Fixes #9274
* fix
* filter accounts for selected domain
Signed-off-by: Abhishek Kumar
---
ui/src/components/view/SearchView.vue | 35 ---
1 file changed, 28 insertions(+), 7 deletions(-)
diff --git a/ui/src/components/view/SearchView.vue
b/ui/src/components/view/SearchView.vue
index c284b8a635a..a43dfabf868 100644
--- a/ui/src/components/view/SearchView.vue
+++ b/ui/src/components/view/SearchView.vue
@@ -66,12 +66,13 @@
return
option.label.toLowerCase().indexOf(input.toLowerCase()) >= 0
}"
:loading="field.loading"
-@input="onchange($event, field.name)">
+@input="onchange($event, field.name)"
+@change="onSelectFieldChange(field.name)">
+ :value="['account'].includes(field.name) ? opt.name :
opt.id"
+ :label="$t((['storageid'].includes(field.name) ||
!opt.path) ? opt.name : opt.path)">
@@ -85,7 +86,7 @@
-{{ $t(opt.path || opt.name) }}
+{{ $t((['storageid'].includes(field.name) ||
!opt.path) ? opt.name : opt.path) }}
@@ -241,6 +242,11 @@ export default {
onchange: async function (event, fieldname) {
this.fetchDynamicFieldData(fieldname, event.target.value)
},
+onSelectFieldChange (fieldname) {
+ if (fieldname === 'domainid') {
+this.fetchDynamicFieldData('account')
+ }
+},
onVisibleForm () {
this.visibleFilter = !this.visibleFilter
if (!this.visibleFilter) return
@@ -563,6 +569,9 @@ export default {
if (domainIndex > -1) {
this.fields[domainIndex].loading = false
}
+if (accountIndex > -1) {
+ this.fields[accountIndex].loading = false
+}
if (imageStoreIndex > -1) {
this.fields[imageStoreIndex].loading = false
}
@@ -584,7 +593,9 @@ export default {
if (diskOfferingIndex > -1) {
this.fields[diskOfferingIndex].loading = false
}
-this.fillFormFieldValues()
+if (Array.isArray(arrayField)) {
+ this.fillFormFieldValues()
+}
})
},
initFormFieldData () {
@@ -595,6 +606,9 @@ export default {
this.fetchDynamicFieldData(arrayField)
},
sortArray (data, key = 'name') {
+ if (!data) {
+return []
+ }
return data.sort(function (a, b) {
if (a[key] < b[key]) { return -1 }
if (a[key] > b[key]) { return 1 }
@@ -644,8 +658,15 @@ export default {
},
fetchAccounts (searchKeyword) {
return new Promise((resolve, reject) => {
-api('listAccounts', { listAll: true, showicon: true, keyword:
searchKeyword }).then(json => {
- const account = json.listaccountsresponse.account
+const params = { listAll: true, isrecursive: false, showicon: true,
keyword: searchKeyword }
+if (this.form.domainid) {
+ params.domainid = this.form.domainid
+}
+api('listAccounts', params).then(json => {
+ var account = json.listaccountsresponse.account
+ if (this.form.domainid) {
+account = account.filter(a => a.domainid === this.form.domainid)
+ }
resolve({
type: 'account',
data: account
Re: [PR] ui: fix account list on domain change in filterview [cloudstack]
sureshanaparti merged PR #9345: URL: https://github.com/apache/cloudstack/pull/9345 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] ui: fix account list on domain change in filterview [cloudstack]
blueorangutan commented on PR #9345: URL: https://github.com/apache/cloudstack/pull/9345#issuecomment-2213804042 UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9345 (QA-JID-398) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] ui: fix account list on domain change in filterview [cloudstack]
blueorangutan commented on PR #9345: URL: https://github.com/apache/cloudstack/pull/9345#issuecomment-2213800764 @sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] ui: fix account list on domain change in filterview [cloudstack]
sureshanaparti commented on PR #9345: URL: https://github.com/apache/cloudstack/pull/9345#issuecomment-2213798211 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] ui: fix account list on domain change in filterview [cloudstack]
blueorangutan commented on PR #9345: URL: https://github.com/apache/cloudstack/pull/9345#issuecomment-2213772463 @shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] ui: fix account list on domain change in filterview [cloudstack]
shwstppr commented on PR #9345: URL: https://github.com/apache/cloudstack/pull/9345#issuecomment-2213771790 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] IPv4 Static Routing (Routed mode) [cloudstack]
blueorangutan commented on PR #9346: URL: https://github.com/apache/cloudstack/pull/9346#issuecomment-2213770724 @weizhouapache a [SL] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] IPv4 Static Routing (Routed mode) [cloudstack]
blueorangutan commented on PR #9346: URL: https://github.com/apache/cloudstack/pull/9346#issuecomment-2213767064 @weizhouapache a [SL] Trillian-Jenkins test job (rocky8 mgmt + vmware-80) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] IPv4 Static Routing (Routed mode) [cloudstack]
weizhouapache commented on PR #9346: URL: https://github.com/apache/cloudstack/pull/9346#issuecomment-2213767852 @blueorangutan test rocky8 kvm-rocky8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] IPv4 Static Routing (Routed mode) [cloudstack]
weizhouapache commented on PR #9346: URL: https://github.com/apache/cloudstack/pull/9346#issuecomment-2213764676 @blueorangutan test rocky8 vmware-80 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] systemvmtemplate: bump new systemvmtemplate 4.19.1 [cloudstack]
blueorangutan commented on PR #9349: URL: https://github.com/apache/cloudstack/pull/9349#issuecomment-2213763412 @rohityadavcloud a [SL] Trillian-Jenkins test job (alma8 mgmt + kvm-alma8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] systemvmtemplate: bump new systemvmtemplate 4.19.1 [cloudstack]
rohityadavcloud commented on PR #9349: URL: https://github.com/apache/cloudstack/pull/9349#issuecomment-2213762449 @blueorangutan test alma8 kvm-alma8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] ui: fix account list on domain change in filterview [cloudstack]
shwstppr commented on PR #9345: URL: https://github.com/apache/cloudstack/pull/9345#issuecomment-2213757679 @weizhouapache done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] ui: fix account list on domain change in filterview [cloudstack]
weizhouapache commented on PR #9345:
URL: https://github.com/apache/cloudstack/pull/9345#issuecomment-2213711547
> @weizhouapache cc @vishesh92 I guess that needs an API change,
>
> ```
> (qaserver) 🐱 > list accounts domainid=b32b3316-6c14-11ed-86c2-1e0093003d07
filter=id,name,domainid
> {
> "account": [
> {
> "domainid": "b32b3316-6c14-11ed-86c2-1e0093003d07",
> "id": "fda39ec5-6c14-11ed-86c2-1e0093003d07",
> "name": "admin"
> },
> {
> "domainid": "b32b3316-6c14-11ed-86c2-1e0093003d07",
> "id": "ef45928c-b2cb-4f9d-93cd-a484e761d4f9",
> "name": "baremetal-system-account"
> },
> {
> "domainid": "b32b3316-6c14-11ed-86c2-1e0093003d07",
> "id": "cd9ebe99-e02c-4385-b6ae-bac1ea677489",
> "name": "rohit"
> },
> {
> "domainid": "b32b3316-6c14-11ed-86c2-1e0093003d07",
> "id": "4e9e632c-ee02-49c1-9868-b53700246c73",
> "name": "euler"
> },
> {
> "domainid": "b32b3316-6c14-11ed-86c2-1e0093003d07",
> "id": "36b4c0a4-b339-40f0-9991-b17282a686a9",
> "name": "rick"
> },
> {
> "domainid": "b32b3316-6c14-11ed-86c2-1e0093003d07",
> "id": "04efc774-1777-4056-9cd7-21e27aa52a72",
> "name": "testy"
> },
> {
> "domainid": "b32b3316-6c14-11ed-86c2-1e0093003d07",
> "id": "705e654b-d85d-456d-8e51-cbe6a14865ad",
> "name": "user"
> },
> {
> "domainid": "b32b3316-6c14-11ed-86c2-1e0093003d07",
> "id": "f79af173-32c1-4f0b-bb0a-6acb433aabb3",
> "name": "capc"
> },
> {
> "domainid": "ae613512-769e-48cd-bd93-a685b9ac9c0a",
> "id": "3dd88047-73dd-4795-833d-da87e13c0698",
> "name": "test"
> }
> ],
> "count": 9
> }
> (qaserver) 🐱 > list accounts domainid=b32b3316-6c14-11ed-86c2-1e0093003d07
filter=id,name,domainid isrecursive=false
> {
> "account": [
> {
> "domainid": "b32b3316-6c14-11ed-86c2-1e0093003d07",
> "id": "fda39ec5-6c14-11ed-86c2-1e0093003d07",
> "name": "admin"
> },
> {
> "domainid": "b32b3316-6c14-11ed-86c2-1e0093003d07",
> "id": "ef45928c-b2cb-4f9d-93cd-a484e761d4f9",
> "name": "baremetal-system-account"
> },
> {
> "domainid": "b32b3316-6c14-11ed-86c2-1e0093003d07",
> "id": "cd9ebe99-e02c-4385-b6ae-bac1ea677489",
> "name": "rohit"
> },
> {
> "domainid": "b32b3316-6c14-11ed-86c2-1e0093003d07",
> "id": "4e9e632c-ee02-49c1-9868-b53700246c73",
> "name": "euler"
> },
> {
> "domainid": "b32b3316-6c14-11ed-86c2-1e0093003d07",
> "id": "36b4c0a4-b339-40f0-9991-b17282a686a9",
> "name": "rick"
> },
> {
> "domainid": "b32b3316-6c14-11ed-86c2-1e0093003d07",
> "id": "04efc774-1777-4056-9cd7-21e27aa52a72",
> "name": "testy"
> },
> {
> "domainid": "b32b3316-6c14-11ed-86c2-1e0093003d07",
> "id": "705e654b-d85d-456d-8e51-cbe6a14865ad",
> "name": "user"
> },
> {
> "domainid": "b32b3316-6c14-11ed-86c2-1e0093003d07",
> "id": "f79af173-32c1-4f0b-bb0a-6acb433aabb3",
> "name": "capc"
> },
> {
> "domainid": "ae613512-769e-48cd-bd93-a685b9ac9c0a",
> "id": "3dd88047-73dd-4795-833d-da87e13c0698",
> "name": "test"
> }
> ],
> "count": 9
> }
> (qaserver) 🐱 > list accounts domainid=b32b3316-6c14-11ed-86c2-1e0093003d07
filter=id,name,domainid isrecursive=false listall=false
> {
> "account": [
> {
> "domainid": "b32b3316-6c14-11ed-86c2-1e0093003d07",
> "id": "fda39ec5-6c14-11ed-86c2-1e0093003d07",
> "name": "admin"
> },
> {
> "domainid": "b32b3316-6c14-11ed-86c2-1e0093003d07",
> "id": "ef45928c-b2cb-4f9d-93cd-a484e761d4f9",
> "name": "baremetal-system-account"
> },
> {
> "domainid": "b32b3316-6c14-11ed-86c2-1e0093003d07",
> "id": "cd9ebe99-e02c-4385-b6ae-bac1ea677489",
> "name": "rohit"
> },
> {
> "domainid": "b32b3316-6c14-11ed-86c2-1e0093003d07",
> "id": "4e9e632c-ee02-49c1-9868-b53700246c73",
> "name": "euler"
> },
> {
> "domainid": "b32b3316-6c14-11ed-86c2-1e0093003d07",
> "id": "36b4c0a4-b339-40f0-9991-b17282a686a9",
> "name": "rick"
> },
> {
> "domainid": "b32b3316-6c14-11ed-86c2-1e0093003d07",
> "id": "04efc774-1777-4056-9cd7-21e27aa52a72",
> "name": "testy"
> },
> {
> "domainid": "b32b3316-6c14-11ed-86c2-1e0093003d07",
> "id": "705e654b-d85d-456d-8e51-cbe6a14865ad",
> "name": "user"
Re: [I] Can't create Isolated network after update [cloudstack]
DaanHoogland commented on issue #9350: URL: https://github.com/apache/cloudstack/issues/9350#issuecomment-2213703917 @UAnton , what is this a duplicate off? can we close it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] systemvmtemplate: bump new systemvmtemplate 4.19.1 [cloudstack]
blueorangutan commented on PR #9349: URL: https://github.com/apache/cloudstack/pull/9349#issuecomment-2213692776 [SF] Trillian Build Failed (tid-10763) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
