[GitHub] cloudmonger commented on issue #1894: CLOUDSTACK-9700 Allow user to Register/Copy templates to multiple zones at the same time

2017-05-02 Thread git
cloudmonger commented on issue #1894: CLOUDSTACK-9700 Allow user to 
Register/Copy templates to multiple zones at the same time
URL: https://github.com/apache/cloudstack/pull/1894#issuecomment-298774022
 
 
   ### ACS CI BVT Run
**Sumarry:**
Build Number 613
Hypervisor xenserver
NetworkType Advanced
Passed=112
Failed=0
Skipped=12
   
   _Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0
   
   
   **Failed tests:**
   
   **Skipped tests:**
   test_vm_nic_adapter_vmxnet3
   test_01_verify_libvirt
   test_02_verify_libvirt_after_restart
   test_03_verify_libvirt_attach_disk
   test_04_verify_guest_lspci
   test_05_change_vm_ostype_restart
   test_06_verify_guest_lspci_again
   test_static_role_account_acls
   test_11_ss_nfs_version_on_ssvm
   test_nested_virtualization_vmware
   test_3d_gpu_support
   test_deploy_vgpu_enabled_vm
   
   **Passed test suits:**
   test_deploy_vm_with_userdata.py
   test_affinity_groups_projects.py
   test_portable_publicip.py
   test_vm_snapshots.py
   test_over_provisioning.py
   test_global_settings.py
   test_scale_vm.py
   test_service_offerings.py
   test_routers_iptables_default_policy.py
   test_loadbalance.py
   test_routers.py
   test_reset_vm_on_reboot.py
   test_deploy_vms_with_varied_deploymentplanners.py
   test_network.py
   test_router_dns.py
   test_non_contigiousvlan.py
   test_login.py
   test_deploy_vm_iso.py
   test_list_ids_parameter.py
   test_public_ip_range.py
   test_multipleips_per_nic.py
   test_metrics_api.py
   test_regions.py
   test_affinity_groups.py
   test_network_acl.py
   test_pvlan.py
   test_volumes.py
   test_nic.py
   test_deploy_vm_root_resize.py
   test_resource_detail.py
   test_secondary_storage.py
   test_vm_life_cycle.py
   test_routers_network_ops.py
   test_disk_offerings.py
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] cloudmonger commented on issue #1894: CLOUDSTACK-9700 Allow user to Register/Copy templates to multiple zones at the same time

2017-05-02 Thread git
cloudmonger commented on issue #1894: CLOUDSTACK-9700 Allow user to 
Register/Copy templates to multiple zones at the same time
URL: https://github.com/apache/cloudstack/pull/1894#issuecomment-298819708
 
 
   ### ACS CI BVT Run
**Sumarry:**
Build Number 614
Hypervisor xenserver
NetworkType Advanced
Passed=109
Failed=3
Skipped=12
   
   _Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0
   
   
   **Failed tests:**
   * test_vm_snapshots.py
   
* test_change_service_offering_for_vm_with_snapshots Failed
   
   * test_routers_network_ops.py
   
* test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true Failed
   
* test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false Failed
   
   
   **Skipped tests:**
   test_vm_nic_adapter_vmxnet3
   test_01_verify_libvirt
   test_02_verify_libvirt_after_restart
   test_03_verify_libvirt_attach_disk
   test_04_verify_guest_lspci
   test_05_change_vm_ostype_restart
   test_06_verify_guest_lspci_again
   test_static_role_account_acls
   test_11_ss_nfs_version_on_ssvm
   test_nested_virtualization_vmware
   test_3d_gpu_support
   test_deploy_vgpu_enabled_vm
   
   **Passed test suits:**
   test_deploy_vm_with_userdata.py
   test_affinity_groups_projects.py
   test_portable_publicip.py
   test_over_provisioning.py
   test_global_settings.py
   test_scale_vm.py
   test_service_offerings.py
   test_routers_iptables_default_policy.py
   test_loadbalance.py
   test_routers.py
   test_reset_vm_on_reboot.py
   test_deploy_vms_with_varied_deploymentplanners.py
   test_network.py
   test_router_dns.py
   test_non_contigiousvlan.py
   test_login.py
   test_deploy_vm_iso.py
   test_list_ids_parameter.py
   test_public_ip_range.py
   test_multipleips_per_nic.py
   test_metrics_api.py
   test_regions.py
   test_affinity_groups.py
   test_network_acl.py
   test_pvlan.py
   test_volumes.py
   test_nic.py
   test_deploy_vm_root_resize.py
   test_resource_detail.py
   test_secondary_storage.py
   test_vm_life_cycle.py
   test_disk_offerings.py
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rhtyd opened a new pull request #2075: [4.9+] CLOUDSTACK-9900: Fix high CPU deviation issues seen in metrics view

2017-05-03 Thread git
rhtyd opened a new pull request #2075: [4.9+] CLOUDSTACK-9900: Fix high CPU 
deviation issues seen in metrics view
URL: https://github.com/apache/cloudstack/pull/2075
 
 
   HostStats returns cpu usage in percentage while memory usage in bytes.
   This fixes a regression in maximum CPU usage deviation that did not
   assume the values to be in percentage and multiple the final ratios
   with 100 which leads to 100x the actual deviation value.
   
   Pinging for review - @karuturi @DaanHoogland @abhinandanprateek 
@borisstoyanov @rashmidixit 
   @blueorangutan package
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rhtyd commented on issue #2075: [4.9+] CLOUDSTACK-9900: Fix high CPU deviation issues seen in metrics view

2017-05-03 Thread git
rhtyd commented on issue #2075: [4.9+] CLOUDSTACK-9900: Fix high CPU deviation 
issues seen in metrics view
URL: https://github.com/apache/cloudstack/pull/2075#issuecomment-298854263
 
 
   Screenshots:
   ![screenshot from 2017-05-03 
14-03-55](https://cloud.githubusercontent.com/assets/95203/25653539/e03bb254-300a-11e7-91d9-80852a0ab8ab.png)
   ![screenshot from 2017-05-03 
14-04-03](https://cloud.githubusercontent.com/assets/95203/25653540/e052f1d0-300a-11e7-9db5-f0f2b9537fc3.png)
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] DaanHoogland commented on a change in pull request #2075: [4.9+] CLOUDSTACK-9900: Fix high CPU deviation issues seen in metrics view

2017-05-03 Thread git
DaanHoogland commented on a change in pull request #2075: [4.9+] 
CLOUDSTACK-9900: Fix high CPU deviation issues seen in metrics view
URL: https://github.com/apache/cloudstack/pull/2075#discussion_r114502094
 
 

 ##
 File path: 
plugins/metrics/src/org/apache/cloudstack/response/ZoneMetricsResponse.java
 ##
 @@ -123,10 +123,10 @@ public void setCpuAllocated(final Long cpuAllocated, 
final Long cpuTotal) {
 }
 }
 
-public void setCpuMaxDeviation(final Double maxCpuDeviation, final Double 
totalCpuUsed, final Long totalHosts) {
-if (maxCpuDeviation != null && totalCpuUsed != null && totalHosts != 
null && totalHosts != 0) {
-final Double averageCpuUsage = totalCpuUsed / totalHosts;
-this.cpuMaxDeviation = String.format("%.2f%%", (maxCpuDeviation - 
averageCpuUsage) * 100.0 / averageCpuUsage);
+public void setCpuMaxDeviation(final Double maxCpuUsagePercentage, final 
Double totalCpuUsedPercentage, final Long totalHosts) {
+if (maxCpuUsagePercentage != null && totalCpuUsedPercentage != null && 
totalHosts != null && totalHosts != 0) {
+final Double averageCpuUsagePercentage = totalCpuUsedPercentage / 
totalHosts;
+this.cpuMaxDeviation = String.format("%.2f%%", 
(maxCpuUsagePercentage - averageCpuUsagePercentage) * 1.0 / 
averageCpuUsagePercentage);
 
 Review comment:
   but i think th '* 1.0' can be removed
 
----
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] DaanHoogland commented on a change in pull request #2075: [4.9+] CLOUDSTACK-9900: Fix high CPU deviation issues seen in metrics view

2017-05-03 Thread git
DaanHoogland commented on a change in pull request #2075: [4.9+] 
CLOUDSTACK-9900: Fix high CPU deviation issues seen in metrics view
URL: https://github.com/apache/cloudstack/pull/2075#discussion_r114501952
 
 

 ##
 File path: 
plugins/metrics/src/org/apache/cloudstack/response/ClusterMetricsResponse.java
 ##
 @@ -128,10 +128,10 @@ public void setCpuAllocated(final Long cpuAllocated, 
final Long cpuTotal) {
 }
 }
 
-public void setCpuMaxDeviation(final Double maxCpuDeviation, final Double 
totalCpuUsed, final Long totalHosts) {
-if (maxCpuDeviation != null && totalCpuUsed != null && totalHosts != 
null && totalHosts != 0) {
-final Double averageCpuUsage = totalCpuUsed / totalHosts;
-this.cpuMaxDeviation = String.format("%.2f%%", (maxCpuDeviation - 
averageCpuUsage) * 100.0 / averageCpuUsage);
+public void setCpuMaxDeviation(final Double maxCpuUsagePercentage, final 
Double totalCpuUsedPercentage, final Long totalHosts) {
+if (maxCpuUsagePercentage != null && totalCpuUsedPercentage != null && 
totalHosts != null && totalHosts != 0) {
+final Double averageCpuUsagePercentage = totalCpuUsedPercentage / 
totalHosts;
+this.cpuMaxDeviation = String.format("%.2f%%", 
(maxCpuUsagePercentage - averageCpuUsagePercentage) * 1.0 / 
averageCpuUsagePercentage);
 
 Review comment:
   is the '* 1.0' needed when it is devided next? I would rather see a cast if 
it is, in this case
 
----
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] DaanHoogland commented on issue #2074: CLOUDSTACK-9899 Url validation disabling

2017-05-03 Thread git
DaanHoogland commented on issue #2074: CLOUDSTACK-9899 Url validation disabling
URL: https://github.com/apache/cloudstack/pull/2074#issuecomment-298862111
 
 
   @blueorangutan test
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] blueorangutan commented on issue #2074: CLOUDSTACK-9899 Url validation disabling

2017-05-03 Thread git
blueorangutan commented on issue #2074: CLOUDSTACK-9899 Url validation disabling
URL: https://github.com/apache/cloudstack/pull/2074#issuecomment-298862135
 
 
   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] karuturi commented on issue #927: CLOUDSTACK-9901 secure and hidden config values are returned as plaintext string

2017-05-03 Thread git
karuturi commented on issue #927: CLOUDSTACK-9901 secure and hidden config 
values are returned as plaintext string
URL: https://github.com/apache/cloudstack/pull/927#issuecomment-298863250
 
 
   update the PR with testcase fix
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rhtyd commented on issue #2075: [4.9+] CLOUDSTACK-9900: Fix high CPU deviation issues seen in metrics view

2017-05-03 Thread git
rhtyd commented on issue #2075: [4.9+] CLOUDSTACK-9900: Fix high CPU deviation 
issues seen in metrics view
URL: https://github.com/apache/cloudstack/pull/2075#issuecomment-298866549
 
 
   @DaanHoogland fixed thanks
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rashmidixit commented on issue #2075: [4.9+] CLOUDSTACK-9900: Fix high CPU deviation issues seen in metrics view

2017-05-03 Thread git
rashmidixit commented on issue #2075: [4.9+] CLOUDSTACK-9900: Fix high CPU 
deviation issues seen in metrics view
URL: https://github.com/apache/cloudstack/pull/2075#issuecomment-298867373
 
 
   LGTM
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] jayapalu commented on issue #2018: CLOUDSTACK-9848: Added exit status checking for the iptables commands

2017-05-03 Thread git
jayapalu commented on issue #2018: CLOUDSTACK-9848: Added  exit status checking 
for the iptables commands
URL: https://github.com/apache/cloudstack/pull/2018#issuecomment-298873490
 
 
   few of the cleanup of test cases are failing and these are not related my 
changes.
   @borisstoyanov  Can you trigger the tests again.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] yvsubhash commented on issue #2047: CLOUDSTACK-8186: make setRemoved to null possible

2017-05-03 Thread git
yvsubhash commented on issue #2047: CLOUDSTACK-8186: make setRemoved to null 
possible
URL: https://github.com/apache/cloudstack/pull/2047#issuecomment-298885131
 
 
   @ustcweizhou  LGTM for the code  I have updated my PR to make use of this fix
   https://github.com/apache/cloudstack/pull/1716/files
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rhtyd commented on issue #2075: [4.9+] CLOUDSTACK-9900: Fix high CPU deviation issues seen in metrics view

2017-05-03 Thread git
rhtyd commented on issue #2075: [4.9+] CLOUDSTACK-9900: Fix high CPU deviation 
issues seen in metrics view
URL: https://github.com/apache/cloudstack/pull/2075#issuecomment-29353
 
 
   Thanks @rashmidixit for reviewing
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rhtyd commented on issue #2075: [4.9+] CLOUDSTACK-9900: Fix high CPU deviation issues seen in metrics view

2017-05-03 Thread git
rhtyd commented on issue #2075: [4.9+] CLOUDSTACK-9900: Fix high CPU deviation 
issues seen in metrics view
URL: https://github.com/apache/cloudstack/pull/2075#issuecomment-29322
 
 
   @blueorangutan package
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] DaanHoogland commented on issue #2075: [4.9+] CLOUDSTACK-9900: Fix high CPU deviation issues seen in metrics view

2017-05-03 Thread git
DaanHoogland commented on issue #2075: [4.9+] CLOUDSTACK-9900: Fix high CPU 
deviation issues seen in metrics view
URL: https://github.com/apache/cloudstack/pull/2075#issuecomment-29382
 
 
   LGTM, I already approved but since we have this string in our policy... ;) 
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] jayapalu commented on issue #1996: CLOUDSTACK-9099: SecretKey is returned from the APIs

2017-05-03 Thread git
jayapalu commented on issue #1996: CLOUDSTACK-9099: SecretKey is returned from 
the APIs
URL: https://github.com/apache/cloudstack/pull/1996#issuecomment-298597383
 
 
   @borisstoyanov Can you upload the your "mgtSvr" from the .cfg. I am getting 
the error when port is 8080 and apikey and secretkey is empty. I want to 
confirm that you/trillian has the same configuration.
"mgtSvr": [
   {
   "mgtSvrIp": "10.233.88.88",
   "passwd": "password",
   "user": "root",
   "port": 8080,
   "useHttps": "False",
   "certCAPath":  "NA",
   "certPath":  "NA",
   "apiKey": "",
       "securityKey": ""
   }
   ]
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] jayapalu commented on issue #1996: CLOUDSTACK-9099: SecretKey is returned from the APIs

2017-05-03 Thread git
jayapalu commented on issue #1996: CLOUDSTACK-9099: SecretKey is returned from 
the APIs
URL: https://github.com/apache/cloudstack/pull/1996#issuecomment-298893728
 
 
   @borisstoyanov  In marvin config with port 8080 and without keys, Is this 
valid configuration test ? Because with port 8080 and with out keys there is no 
way to get the keys first time unless it uses 8096 for the first time and then 
fall back to 8080
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rohit57 commented on issue #1908: CLOUDSTACK-9317: Fixed disable static nat on leaving ips on interface

2017-05-03 Thread git
rohit57 commented on issue #1908: CLOUDSTACK-9317: Fixed disable static nat on 
leaving ips on interface
URL: https://github.com/apache/cloudstack/pull/1908#issuecomment-298896670
 
 
   Disable static NAT working fine, IP's are leaving interface as soon as they 
are disabled.
   ![screenshot 
125](https://cloud.githubusercontent.com/assets/11736429/25660503/249d6400-302a-11e7-9a57-116300d77f02.png)
   ![screenshot 
127](https://cloud.githubusercontent.com/assets/11736429/25660505/281291a0-302a-11e7-95d0-dbe58909bee3.png)
   ![screenshot 
126](https://cloud.githubusercontent.com/assets/11736429/25660508/2da6c9a6-302a-11e7-81f4-145b3294bd97.png)
   
   Test results are as expected. LGTM
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] kiwiflyer commented on issue #2008: [CLOUDSTACK-9840] Fix datetime format of snapshots events

2017-05-03 Thread git
kiwiflyer commented on issue #2008: [CLOUDSTACK-9840] Fix datetime format of 
snapshots events
URL: https://github.com/apache/cloudstack/pull/2008#issuecomment-298952645
 
 
   Simple fix for log consistency. LGTM
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] kiwiflyer commented on issue #2008: [CLOUDSTACK-9840] Fix datetime format of snapshots events

2017-05-03 Thread git
kiwiflyer commented on issue #2008: [CLOUDSTACK-9840] Fix datetime format of 
snapshots events
URL: https://github.com/apache/cloudstack/pull/2008#issuecomment-298952645
 
 
   Simple fix for log consistency. LGTM
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] kiwiflyer commented on issue #2070: [4.9+] hyperv: Fix log4j to have @AGENTLOG@ replaced

2017-05-03 Thread git
kiwiflyer commented on issue #2070: [4.9+] hyperv: Fix log4j to have @AGENTLOG@ 
replaced
URL: https://github.com/apache/cloudstack/pull/2070#issuecomment-298962214
 
 
   @rhtyd Can we create a jira issue for this?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] blueorangutan commented on issue #2074: CLOUDSTACK-9899 Url validation disabling

2017-05-03 Thread git
 | 218.15 | test_loadbalance.py
   test_03_list_snapshots | Success | 0.06 | test_list_ids_parameter.py
   test_02_list_templates | Success | 0.04 | test_list_ids_parameter.py
   test_01_list_volumes | Success | 0.05 | test_list_ids_parameter.py
   test_07_list_default_iso | Success | 0.06 | test_iso.py
   test_05_iso_permissions | Success | 0.06 | test_iso.py
   test_04_extract_Iso | Success | 5.17 | test_iso.py
   test_03_delete_iso | Success | 95.22 | test_iso.py
   test_02_edit_iso | Success | 0.11 | test_iso.py
   test_01_create_iso | Success | 21.05 | test_iso.py
   test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | Success | 208.73 | 
test_internal_lb.py
   test_03_vpc_internallb_haproxy_stats_on_all_interfaces | Success | 158.03 | 
test_internal_lb.py
   test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | Success | 511.12 | 
test_internal_lb.py
   test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Success | 431.62 | 
test_internal_lb.py
   test_dedicateGuestVlanRange | Success | 10.46 | test_guest_vlan_range.py
   test_UpdateConfigParamWithScope | Success | 0.17 | test_global_settings.py
   test_rolepermission_lifecycle_update | Success | 6.29 | test_dynamicroles.py
   test_rolepermission_lifecycle_list | Success | 6.05 | test_dynamicroles.py
   test_rolepermission_lifecycle_delete | Success | 5.90 | test_dynamicroles.py
   test_rolepermission_lifecycle_create | Success | 5.94 | test_dynamicroles.py
   test_rolepermission_lifecycle_concurrent_updates | Success | 6.05 | 
test_dynamicroles.py
   test_role_lifecycle_update_role_inuse | Success | 5.96 | test_dynamicroles.py
   test_role_lifecycle_update | Success | 11.07 | test_dynamicroles.py
   test_role_lifecycle_list | Success | 5.93 | test_dynamicroles.py
   test_role_lifecycle_delete | Success | 5.95 | test_dynamicroles.py
   test_role_lifecycle_create | Success | 5.94 | test_dynamicroles.py
   test_role_inuse_deletion | Success | 5.90 | test_dynamicroles.py
   test_role_account_acls_multiple_mgmt_servers | Success | 8.21 | 
test_dynamicroles.py
   test_role_account_acls | Success | 8.85 | test_dynamicroles.py
   test_default_role_deletion | Success | 6.11 | test_dynamicroles.py
   test_04_create_fat_type_disk_offering | Success | 0.08 | 
test_disk_offerings.py
   test_03_delete_disk_offering | Success | 0.06 | test_disk_offerings.py
   test_02_edit_disk_offering | Success | 0.06 | test_disk_offerings.py
   test_02_create_sparse_type_disk_offering | Success | 0.07 | 
test_disk_offerings.py
   test_01_create_disk_offering | Success | 0.11 | test_disk_offerings.py
   test_deployvm_userdispersing | Success | 20.66 | 
test_deploy_vms_with_varied_deploymentplanners.py
   test_deployvm_userconcentrated | Success | 45.93 | 
test_deploy_vms_with_varied_deploymentplanners.py
   test_deployvm_firstfit | Success | 55.84 | 
test_deploy_vms_with_varied_deploymentplanners.py
   test_deployvm_userdata_post | Success | 10.44 | 
test_deploy_vm_with_userdata.py
   test_deployvm_userdata | Success | 50.85 | test_deploy_vm_with_userdata.py
   test_02_deploy_vm_root_resize | Success | 6.06 | 
test_deploy_vm_root_resize.py
   test_01_deploy_vm_root_resize | Success | 6.08 | 
test_deploy_vm_root_resize.py
   test_00_deploy_vm_root_resize | Success | 227.94 | 
test_deploy_vm_root_resize.py
   test_deploy_vm_from_iso | Success | 212.79 | test_deploy_vm_iso.py
   test_06_verify_guest_lspci_again | Success | 64.47 | 
test_deploy_virtio_scsi_vm.py
   test_05_change_vm_ostype_restart | Success | 11.01 | 
test_deploy_virtio_scsi_vm.py
   test_04_verify_guest_lspci | Success | 40.44 | test_deploy_virtio_scsi_vm.py
   test_03_verify_libvirt_attach_disk | Success | 10.77 | 
test_deploy_virtio_scsi_vm.py
   test_02_verify_libvirt_after_restart | Success | 131.57 | 
test_deploy_virtio_scsi_vm.py
   test_01_verify_libvirt | Success | 0.53 | test_deploy_virtio_scsi_vm.py
   test_DeployVmAntiAffinityGroup | Success | 66.07 | test_affinity_groups.py
   test_change_service_offering_for_vm_with_snapshots | Skipped | 0.00 | 
test_vm_snapshots.py
   test_06_copy_template | Skipped | 0.00 | test_templates.py
   test_static_role_account_acls | Skipped | 0.05 | test_staticroles.py
   test_11_ss_nfs_version_on_ssvm | Skipped | 0.02 | test_ssvm.py
   test_01_scale_vm | Skipped | 0.00 | test_scale_vm.py
   test_01_primary_storage_iscsi | Skipped | 0.04 | test_primary_storage.py
   test_nested_virtualization_vmware | Skipped | 0.00 | 
test_nested_virtualization.py
   test_06_copy_iso | Skipped | 0.00 | test_iso.py
   test_deploy_vgpu_enabled_vm | Skipped | 0.04 | test_deploy_vgpu_enabled_vm.py
   test_3d_gpu_support | Skipped | 0.04 | test_deploy_vgpu_enabled_vm.py
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With

[GitHub] leprechau commented on issue #1606: Allow CGN (RFC6598) to be used within a VPC

2017-05-03 Thread git
leprechau commented on issue #1606: Allow CGN (RFC6598) to be used within a VPC
URL: https://github.com/apache/cloudstack/pull/1606#issuecomment-299039096
 
 
   @rossor @nathanejohnson Can we get the code formatted correctly so the tests 
pass?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] abhinandanprateek commented on issue #2075: [4.9+] CLOUDSTACK-9900: Fix high CPU deviation issues seen in metrics view

2017-05-03 Thread git
abhinandanprateek commented on issue #2075: [4.9+] CLOUDSTACK-9900: Fix high 
CPU deviation issues seen in metrics view
URL: https://github.com/apache/cloudstack/pull/2075#issuecomment-299088351
 
 
   LGTM, on code review.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] sateesh-chodapuneedi commented on issue #1878: CLOUDSTACK-9717: [VMware] RVRs have mismatching MAC addresses for extra public NICs.

2017-05-03 Thread git
sateesh-chodapuneedi commented on issue #1878: CLOUDSTACK-9717: [VMware] RVRs 
have mismatching MAC addresses for extra public NICs.
URL: https://github.com/apache/cloudstack/pull/1878#issuecomment-299098640
 
 
   @sureshanaparti LGTM code change, please incorporate changes suggested by 
@rafaelweingartner 
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] sateesh-chodapuneedi commented on issue #1253: CLOUDSTACK-9184: [VMware] vmware.ports.per.dvportgroup global setting is not useful from vCenter 5.0 onwards

2017-05-03 Thread git
sateesh-chodapuneedi commented on issue #1253: CLOUDSTACK-9184: [VMware] 
vmware.ports.per.dvportgroup global setting is not useful from vCenter 5.0 
onwards
URL: https://github.com/apache/cloudstack/pull/1253#issuecomment-299100369
 
 
   >Can we remove the config param "vmware.ports.per.dvportgroup" now or hold 
it sometime?
   @sureshanaparti Yes, we can remove this config param. 
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] sureshanaparti commented on issue #1875: CLOUDSTACK-8608: [VMware] System VMs failed to start due to permissions issue. Provide permissions to template folder when mounted on management serve

2017-05-03 Thread git
sureshanaparti commented on issue #1875: CLOUDSTACK-8608: [VMware] System VMs 
failed to start due to permissions issue. Provide permissions to template 
folder when mounted on management server.
URL: https://github.com/apache/cloudstack/pull/1875#issuecomment-299101726
 
 
   The above intermitten failures are not related to this PR changes.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] borisstoyanov commented on issue #1996: CLOUDSTACK-9099: SecretKey is returned from the APIs

2017-05-03 Thread git
borisstoyanov commented on issue #1996: CLOUDSTACK-9099: SecretKey is returned 
from the APIs
URL: https://github.com/apache/cloudstack/pull/1996#issuecomment-299101715
 
 
   Hi @jayapalu, sorry for the delay, 
   we're using port 8096 in the config file and no API keys are configured in 
the cfg file. Are you able to execute the tests successfully, if yes can you 
share your config.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] borisstoyanov commented on issue #2018: CLOUDSTACK-9848: Added exit status checking for the iptables commands

2017-05-03 Thread git
borisstoyanov commented on issue #2018: CLOUDSTACK-9848: Added  exit status 
checking for the iptables commands
URL: https://github.com/apache/cloudstack/pull/2018#issuecomment-299101888
 
 
   @blueorangutan test centos7 vmware-55u3
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] blueorangutan commented on issue #2018: CLOUDSTACK-9848: Added exit status checking for the iptables commands

2017-05-03 Thread git
blueorangutan commented on issue #2018: CLOUDSTACK-9848: Added  exit status 
checking for the iptables commands
URL: https://github.com/apache/cloudstack/pull/2018#issuecomment-299101965
 
 
   @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + vmware-55u3) has 
been kicked to run smoke tests
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] kishankavala commented on a change in pull request #1897: CLOUDSTACK-9733: Concurrent volume snapshots of a VM are not allowed and are not limited per host as per the global configuration par

2017-05-03 Thread git
kishankavala commented on a change in pull request #1897: CLOUDSTACK-9733: 
Concurrent volume snapshots of a VM are not allowed and are not limited per 
host as per the global configuration parameter 
"concurrent.snapshots.threshold.perhost".
URL: https://github.com/apache/cloudstack/pull/1897#discussion_r114494969
 
 

 ##
 File path: setup/db/db/schema-4920to41000.sql
 ##
 @@ -232,3 +232,5 @@ WHERE (o.cpu is null AND o.speed IS NULL AND o.ram_size IS 
NULL) AND
 
 -- CLOUDSTACK-9827: Storage tags stored in multiple places
 DROP VIEW IF EXISTS `cloud`.`storage_tag_view`;
+
+DELETE FROM `cloud`.`configuration` where name = 
'concurrent.snapshots.threshold.perhost';
 
 Review comment:
   Need not delete this config param. Earlier config will be lost otherwise
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] kishankavala commented on a change in pull request #1897: CLOUDSTACK-9733: Concurrent volume snapshots of a VM are not allowed and are not limited per host as per the global configuration par

2017-05-03 Thread git
kishankavala commented on a change in pull request #1897: CLOUDSTACK-9733: 
Concurrent volume snapshots of a VM are not allowed and are not limited per 
host as per the global configuration parameter 
"concurrent.snapshots.threshold.perhost".
URL: https://github.com/apache/cloudstack/pull/1897#discussion_r114495600
 
 

 ##
 File path: 
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/XenserverSnapshotStrategy.java
 ##
 @@ -374,10 +374,14 @@ public SnapshotInfo takeSnapshot(SnapshotInfo snapshot) {
 throw new CloudRuntimeException(result.getResult());
 }
 } finally {
-if (result != null && result.isSuccess()) {
-volumeInfo.stateTransit(Volume.Event.OperationSucceeded);
-} else {
-volumeInfo.stateTransit(Volume.Event.OperationFailed);
+List activeVolumeSnapshots = 
snapshotDao.listByStatus(snapshot.getVolumeId(), Snapshot.State.Creating);
+if (activeVolumeSnapshots.isEmpty()) {
 
 Review comment:
   There could be a race condition here. 
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] sureshanaparti commented on a change in pull request #1872: CLOUDSTACK-3223 Exception observed while creating CPVM in VMware Setup with DVS

2017-05-03 Thread git
sureshanaparti commented on a change in pull request #1872: CLOUDSTACK-3223 
Exception observed while creating CPVM in VMware Setup with DVS
URL: https://github.com/apache/cloudstack/pull/1872#discussion_r114280010
 
 

 ##
 File path: 
vmware-base/src/com/cloud/hypervisor/vmware/mo/DistributedVirtualSwitchMO.java
 ##
 @@ -36,24 +37,67 @@
 public class DistributedVirtualSwitchMO extends BaseMO {
 @SuppressWarnings("unused")
 private static final Logger s_logger = 
Logger.getLogger(DistributedVirtualSwitchMO.class);
+private static ConcurrentHashMap> 
s_dvPortGroupCacheMap = null;
 
 public DistributedVirtualSwitchMO(VmwareContext context, 
ManagedObjectReference morDvs) {
 super(context, morDvs);
+s_dvPortGroupCacheMap = new ConcurrentHashMap>();
 }
 
 public DistributedVirtualSwitchMO(VmwareContext context, String morType, 
String morValue) {
 super(context, morType, morValue);
+s_dvPortGroupCacheMap = new ConcurrentHashMap>();
 }
 
 public void createDVPortGroup(DVPortgroupConfigSpec dvPortGroupSpec) 
throws Exception {
 List dvPortGroupSpecArray = new 
ArrayList();
 dvPortGroupSpecArray.add(dvPortGroupSpec);
-_context.getService().addDVPortgroupTask(_mor, dvPortGroupSpecArray);
+boolean dvPortGroupExists = false;
+String dvSwitchInstance = _mor.getValue();
+String dvPortGroupName = dvPortGroupSpec.getName();
+String uniquedvPortGroupPerDvs = dvSwitchInstance + dvPortGroupName;
+List dvPortGroupList = null;
+synchronized (uniquedvPortGroupPerDvs.intern()) {
+// Looking up local cache rather than firing another API call to 
see if dvPortGroup exists already.
+if (s_dvPortGroupCacheMap.containsKey(dvSwitchInstance)) {
+dvPortGroupList = s_dvPortGroupCacheMap.get(dvSwitchInstance);
+if (dvPortGroupList != null && 
dvPortGroupList.contains(dvPortGroupName)) {
+dvPortGroupExists = true;
+}
+}
+if (!dvPortGroupExists) {
+ManagedObjectReference task = 
_context.getService().addDVPortgroupTask(_mor, dvPortGroupSpecArray);
+if (!_context.getVimClient().waitForTask(task)) {
+throw new Exception("Failed to create dvPortGroup " + 
dvPortGroupSpec.getName());
+} else {
+if (s_dvPortGroupCacheMap.containsKey(dvSwitchInstance)) {
+dvPortGroupList = 
s_dvPortGroupCacheMap.get(dvSwitchInstance);
+if (dvPortGroupList == null) {
+dvPortGroupList = new ArrayList();
+}
+dvPortGroupList.add(dvPortGroupName); //does this 
update map?
 
 Review comment:
Thanks for the confirmation
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] jayapalu commented on issue #1996: CLOUDSTACK-9099: SecretKey is returned from the APIs

2017-05-03 Thread git
jayapalu commented on issue #1996: CLOUDSTACK-9099: SecretKey is returned from 
the APIs
URL: https://github.com/apache/cloudstack/pull/1996#issuecomment-299103191
 
 
   @borisstoyanov  With 8096, I did not get see any test failures in my local 
setup. But in Trillian it seems the test setup itself is failing.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] sureshanaparti commented on issue #1878: CLOUDSTACK-9717: [VMware] RVRs have mismatching MAC addresses for extra public NICs.

2017-05-03 Thread git
sureshanaparti commented on issue #1878: CLOUDSTACK-9717: [VMware] RVRs have 
mismatching MAC addresses for extra public NICs.
URL: https://github.com/apache/cloudstack/pull/1878#issuecomment-299103325
 
 
   @sateesh-chodapuneedi Sure. Thanks for the review.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] sureshanaparti commented on issue #1253: CLOUDSTACK-9184: [VMware] vmware.ports.per.dvportgroup global setting is not useful from vCenter 5.0 onwards

2017-05-03 Thread git
sureshanaparti commented on issue #1253: CLOUDSTACK-9184: [VMware] 
vmware.ports.per.dvportgroup global setting is not useful from vCenter 5.0 
onwards
URL: https://github.com/apache/cloudstack/pull/1253#issuecomment-299103280
 
 
   @sateesh-chodapuneedi Thanks for confirming this. I'll update the code to 
remove the config param "vmware.ports.per.dvportgroup".
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] sureshanaparti commented on a change in pull request #1897: CLOUDSTACK-9733: Concurrent volume snapshots of a VM are not allowed and are not limited per host as per the global configuration p

2017-05-03 Thread git
sureshanaparti commented on a change in pull request #1897: CLOUDSTACK-9733: 
Concurrent volume snapshots of a VM are not allowed and are not limited per 
host as per the global configuration parameter 
"concurrent.snapshots.threshold.perhost".
URL: https://github.com/apache/cloudstack/pull/1897#discussion_r114704514
 
 

 ##
 File path: setup/db/db/schema-4920to41000.sql
 ##
 @@ -232,3 +232,5 @@ WHERE (o.cpu is null AND o.speed IS NULL AND o.ram_size IS 
NULL) AND
 
 -- CLOUDSTACK-9827: Storage tags stored in multiple places
 DROP VIEW IF EXISTS `cloud`.`storage_tag_view`;
+
+DELETE FROM `cloud`.`configuration` where name = 
'concurrent.snapshots.threshold.perhost';
 
 Review comment:
   @kishankavala Will update.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] nitin-maharana commented on issue #2031: CLOUDSTACK - 8672 : Alternate PR for NCC Integration with CloudStack (Original PR : #1859)

2017-05-03 Thread git
nitin-maharana commented on issue #2031: CLOUDSTACK - 8672 : Alternate PR for 
NCC Integration with CloudStack (Original PR : #1859)
URL: https://github.com/apache/cloudstack/pull/2031#issuecomment-299103460
 
 
   @rafaelweingartner: You are correct. This PR is about the new feature 
mentioned in the FS 
(https://cwiki.apache.org/confluence/display/CLOUDSTACK/NCC+Integration+With+Auto+Provision+VPX+in+CloudStack).
 Yes, it was reviewed.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] sureshanaparti commented on a change in pull request #1897: CLOUDSTACK-9733: Concurrent volume snapshots of a VM are not allowed and are not limited per host as per the global configuration p

2017-05-03 Thread git
sureshanaparti commented on a change in pull request #1897: CLOUDSTACK-9733: 
Concurrent volume snapshots of a VM are not allowed and are not limited per 
host as per the global configuration parameter 
"concurrent.snapshots.threshold.perhost".
URL: https://github.com/apache/cloudstack/pull/1897#discussion_r114704542
 
 

 ##
 File path: 
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/XenserverSnapshotStrategy.java
 ##
 @@ -374,10 +374,14 @@ public SnapshotInfo takeSnapshot(SnapshotInfo snapshot) {
 throw new CloudRuntimeException(result.getResult());
 }
 } finally {
-if (result != null && result.isSuccess()) {
-volumeInfo.stateTransit(Volume.Event.OperationSucceeded);
-} else {
-volumeInfo.stateTransit(Volume.Event.OperationFailed);
+List activeVolumeSnapshots = 
snapshotDao.listByStatus(snapshot.getVolumeId(), Snapshot.State.Creating);
+if (activeVolumeSnapshots.isEmpty()) {
 
 Review comment:
   @kishankavala will check and update accordingly.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] koushik-das commented on issue #2007: CLOUDSTACK-9834: prepareTemplate API call doesn't work well with XenServer & Local SR (Db_exn.Uniqueness_constraint_violation)

2017-05-03 Thread git
koushik-das commented on issue #2007: CLOUDSTACK-9834: prepareTemplate API call 
doesn't work well with XenServer & Local SR 
(Db_exn.Uniqueness_constraint_violation)
URL: https://github.com/apache/cloudstack/pull/2007#issuecomment-299107199
 
 
   Code changes LGTM
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rhtyd commented on issue #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KVM HA provider

2017-05-04 Thread git
rhtyd commented on issue #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KVM 
HA provider
URL: https://github.com/apache/cloudstack/pull/1960#issuecomment-299110561
 
 
   @koushik-das Host-HA is disabled by default, it needs explicit configuration 
and to be enabled in order to be used. It further provides kill-switches 
(explicit disable APIs) for hosts across partitions (zone/cluster/host). 
Further, it has strict eligibility checks with pluggable 
mechanism/implementation that ensure only eligible resources take part in the 
HA lifecycle.
   
   The framework is written in an agnostic way to re-think our HA approach, and 
in comparison with the status quo this work provides mechanisms for eligibility 
checks, to degrade and recover a HA resource and policies/mechanisms to conduct 
(configurable) rounds of investigation and decisions based on a threshold 
ratios (granular/configurable). The new agnostic HA framework also has resource 
life cycle management using bounded ephemeral queues for managing very large 
environments (10k+ hosts), improved background polling task management against 
a FSM, reporting/alerting, ownership management of resource (in case of 
multiple-mgmt servers). Pluggability of the framework was another reason, it 
cleanly allows for large scale users to implement their own algorithms/logic to 
carry out various operations such as 
investigate/activity-checks/degrade/recover/fence etc. Due to several reasons 
and requirements, oobm could not been simply put in existing KVM specific VM-HA.
   
   In order for this to work, VM-HA and Host-HA must work in tandem and the 
cleanest way was to control VM-HA in a safe and backward-compatible way to 
over-ride the status returned by the KVM investigator based on Host HA FSM 
states. This strictly works only when host-ha is enabled for a host, I'll tag 
you on the specific code where this happen for you to verify. Any 
regressions/issues (if it creeps in) will not affect all HVs since the injected 
override is specific to KVM only. See our FS, last section on VM-HA Host-HA 
coordination. Lastly, remember this should not cause any issues post-upgrade 
for general users as the feature itself is disabled by default.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rhtyd commented on a change in pull request #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KVM HA provider

2017-05-04 Thread git
rhtyd commented on a change in pull request #1960: [4.11/Future] 
CLOUDSTACK-9782: Host HA and KVM HA provider
URL: https://github.com/apache/cloudstack/pull/1960#discussion_r114709474
 
 

 ##
 File path: plugins/hypervisors/kvm/src/com/cloud/ha/KVMInvestigator.java
 ##
 @@ -40,17 +40,23 @@
 public class KVMInvestigator extends AdapterBase implements Investigator {
 private final static Logger s_logger = 
Logger.getLogger(KVMInvestigator.class);
 @Inject
-HostDao _hostDao;
+private HostDao _hostDao;
+@Inject
+private AgentManager _agentMgr;
 @Inject
-AgentManager _agentMgr;
+private ResourceManager _resourceMgr;
 @Inject
-ResourceManager _resourceMgr;
+private PrimaryDataStoreDao _storagePoolDao;
 @Inject
-PrimaryDataStoreDao _storagePoolDao;
+private HAManager haManager;
 
 @Override
 public boolean isVmAlive(com.cloud.vm.VirtualMachine vm, Host host) throws 
UnknownVM {
+if (haManager.isHAEligible(host)) {
 
 Review comment:
   @koushik-das FYI - injections here for VM-HA Host-HA coordination, the 
eligibility checks several things -- including that the feature is explicitly 
enabled for a host.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rhtyd commented on a change in pull request #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KVM HA provider

2017-05-04 Thread git
rhtyd commented on a change in pull request #1960: [4.11/Future] 
CLOUDSTACK-9782: Host HA and KVM HA provider
URL: https://github.com/apache/cloudstack/pull/1960#discussion_r114709491
 
 

 ##
 File path: plugins/hypervisors/kvm/src/com/cloud/ha/KVMInvestigator.java
 ##
 @@ -67,6 +73,10 @@ public Status isAgentAlive(Host agent) {
 return null;
 }
 
+if (haManager.isHAEligible(agent)) {
 
 Review comment:
   @koushik-das FYI - injections here for VM-HA Host-HA coordination, the 
eligibility checks several things -- including that the feature is explicitly 
enabled for a host.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rhtyd commented on a change in pull request #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KVM HA provider

2017-05-04 Thread git
rhtyd commented on a change in pull request #1960: [4.11/Future] 
CLOUDSTACK-9782: Host HA and KVM HA provider
URL: https://github.com/apache/cloudstack/pull/1960#discussion_r114709646
 
 

 ##
 File path: plugins/hypervisors/kvm/src/com/cloud/ha/KVMInvestigator.java
 ##
 @@ -67,6 +73,10 @@ public Status isAgentAlive(Host agent) {
 return null;
 }
 
+if (haManager.isHAEligible(agent)) {
 
 Review comment:
   Other than this, I don't see any explicit change to the VM-HA framework 
itself.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rhtyd commented on a change in pull request #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KVM HA provider

2017-05-04 Thread git
rhtyd commented on a change in pull request #1960: [4.11/Future] 
CLOUDSTACK-9782: Host HA and KVM HA provider
URL: https://github.com/apache/cloudstack/pull/1960#discussion_r114709634
 
 

 ##
 File path: plugins/hypervisors/kvm/src/com/cloud/ha/KVMInvestigator.java
 ##
 @@ -40,17 +40,23 @@
 public class KVMInvestigator extends AdapterBase implements Investigator {
 private final static Logger s_logger = 
Logger.getLogger(KVMInvestigator.class);
 @Inject
-HostDao _hostDao;
+private HostDao _hostDao;
+@Inject
+private AgentManager _agentMgr;
 @Inject
-AgentManager _agentMgr;
+private ResourceManager _resourceMgr;
 @Inject
-ResourceManager _resourceMgr;
+private PrimaryDataStoreDao _storagePoolDao;
 @Inject
-PrimaryDataStoreDao _storagePoolDao;
+private HAManager haManager;
 
 @Override
 public boolean isVmAlive(com.cloud.vm.VirtualMachine vm, Host host) throws 
UnknownVM {
+if (haManager.isHAEligible(host)) {
 
 Review comment:
   Other than this, I don't see any explicit change to the VM-HA framework 
itself.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] shwetaag opened a new pull request #1949: Automated Cloudstack bugs 9277 9276 9275 9274 9273 9179 9178 9177

2017-05-04 Thread git
shwetaag opened a new pull request #1949: Automated Cloudstack bugs 9277 9276 
9275 9274 9273 9179 9178 9177 
URL: https://github.com/apache/cloudstack/pull/1949
 
 
   Addressed all review comments. Changed all URL to pubic available url where 
ever possible . For few  tests needing rhel7 template or windows server 
templates added a comment in test case to provide a valid urls for those 
templates before executing those test cases
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] shwetaag closed pull request #1949: Automated Cloudstack bugs 9277 9276 9275 9274 9273 9179 9178 9177

2017-05-04 Thread git
shwetaag closed pull request #1949: Automated Cloudstack bugs 9277 9276 9275 
9274 9273 9179 9178 9177 
URL: https://github.com/apache/cloudstack/pull/1949
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rhtyd commented on issue #2070: [4.9+] hyperv: Fix log4j to have @AGENTLOG@ replaced

2017-05-04 Thread git
rhtyd commented on issue #2070: [4.9+] hyperv: Fix log4j to have @AGENTLOG@ 
replaced
URL: https://github.com/apache/cloudstack/pull/2070#issuecomment-299122904
 
 
   @kiwiflyer thanks, done
   https://issues.apache.org/jira/browse/CLOUDSTACK-9904
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rhtyd commented on issue #2070: CLOUDSTACK-9904: Fix log4j to have @AGENTLOG@ replaced

2017-05-04 Thread git
rhtyd commented on issue #2070: CLOUDSTACK-9904: Fix log4j to have @AGENTLOG@ 
replaced
URL: https://github.com/apache/cloudstack/pull/2070#issuecomment-299123277
 
 
   @blueorangutan package
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] blueorangutan commented on issue #2070: CLOUDSTACK-9904: Fix log4j to have @AGENTLOG@ replaced

2017-05-04 Thread git
blueorangutan commented on issue #2070: CLOUDSTACK-9904: Fix log4j to have 
@AGENTLOG@ replaced
URL: https://github.com/apache/cloudstack/pull/2070#issuecomment-299123363
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] SowjanyaPatha commented on issue #1940: CLOUDSTACK-9781:ACS records ID in events tables instead of UUID.

2017-05-04 Thread git
SowjanyaPatha commented on issue #1940: CLOUDSTACK-9781:ACS records ID in 
events tables instead of UUID.
URL: https://github.com/apache/cloudstack/pull/1940#issuecomment-299131855
 
 
   LGTM for Testing. 
   
   Checked  the Events Tab for the ID it is referring to UUID.
   Attached  screenshot

   
   
![screenshot1](https://cloud.githubusercontent.com/assets/26593242/25695653/9fce606e-30d1-11e7-8da6-fd8b8991a731.png)
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] cloudmonger commented on issue #927: CLOUDSTACK-9901 secure and hidden config values are returned as plaintext string

2017-05-04 Thread git
cloudmonger commented on issue #927: CLOUDSTACK-9901 secure and hidden config 
values are returned as plaintext string
URL: https://github.com/apache/cloudstack/pull/927#issuecomment-297779185
 
 
   ### ACS CI BVT Run
**Sumarry:**
Build Number 591
Hypervisor xenserver
NetworkType Advanced
Passed=109
Failed=10
Skipped=6
   
   _Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0
   
   
   **Failed tests:**
   * test_network.py
   
* test_public_ip_admin_account Failing since 2 runs
   
   * test_deploy_virtio_scsi_vm.py
   
* test_01_verify_libvirt Failing since 10 runs
   
* test_02_verify_libvirt_after_restart Failing since 10 runs
   
* test_03_verify_libvirt_attach_disk Failing since 10 runs
   
* test_04_verify_guest_lspci Failing since 10 runs
   
* test_05_change_vm_ostype_restart Failing since 10 runs
   
* test_06_verify_guest_lspci_again Failing since 10 runs
   
* ContextSuite context=TestDeployVirtioSCSIVM>:teardown Failing since 10 
runs
   
   * test_routers_network_ops.py
   
* test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true Failed
   
* test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false Failed
   
   
   **Skipped tests:**
   test_vm_nic_adapter_vmxnet3
   test_static_role_account_acls
   test_11_ss_nfs_version_on_ssvm
   test_nested_virtualization_vmware
   test_3d_gpu_support
   test_deploy_vgpu_enabled_vm
   
   **Passed test suits:**
   test_deploy_vm_with_userdata.py
   test_affinity_groups_projects.py
   test_portable_publicip.py
   test_vm_snapshots.py
   test_over_provisioning.py
   test_global_settings.py
   test_scale_vm.py
   test_service_offerings.py
   test_routers_iptables_default_policy.py
   test_loadbalance.py
   test_routers.py
   test_reset_vm_on_reboot.py
   test_deploy_vms_with_varied_deploymentplanners.py
   test_router_dns.py
   test_non_contigiousvlan.py
   test_login.py
   test_deploy_vm_iso.py
   test_list_ids_parameter.py
   test_public_ip_range.py
   test_multipleips_per_nic.py
   test_metrics_api.py
   test_regions.py
   test_affinity_groups.py
   test_network_acl.py
   test_pvlan.py
   test_volumes.py
   test_nic.py
   test_deploy_vm_root_resize.py
   test_resource_detail.py
   test_secondary_storage.py
   test_vm_life_cycle.py
   test_disk_offerings.py
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] cloudmonger commented on issue #927: CLOUDSTACK-9901 secure and hidden config values are returned as plaintext string

2017-05-04 Thread git
cloudmonger commented on issue #927: CLOUDSTACK-9901 secure and hidden config 
values are returned as plaintext string
URL: https://github.com/apache/cloudstack/pull/927#issuecomment-299137118
 
 
   ### ACS CI BVT Run
**Sumarry:**
Build Number 619
Hypervisor xenserver
NetworkType Advanced
Passed=110
Failed=2
Skipped=12
   
   _Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/r2si930m8xxzavs/AAAzNrnoF1fC3auFrvsKo_8-a?dl=0
   
   **Failed tests:**
   * test_vm_snapshots.py
   
* test_change_service_offering_for_vm_with_snapshots Failing since 2 runs
   
   * test_routers_network_ops.py
   
* test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false Failing since 2 
runs
   
   
   **Skipped tests:**
   test_vm_nic_adapter_vmxnet3
   test_01_verify_libvirt
   test_02_verify_libvirt_after_restart
   test_03_verify_libvirt_attach_disk
   test_04_verify_guest_lspci
   test_05_change_vm_ostype_restart
   test_06_verify_guest_lspci_again
   test_static_role_account_acls
   test_11_ss_nfs_version_on_ssvm
   test_nested_virtualization_vmware
   test_3d_gpu_support
   test_deploy_vgpu_enabled_vm
   
   **Passed test suits:**
   test_deploy_vm_with_userdata.py
   test_affinity_groups_projects.py
   test_portable_publicip.py
   test_over_provisioning.py
   test_global_settings.py
   test_scale_vm.py
   test_service_offerings.py
   test_routers_iptables_default_policy.py
   test_loadbalance.py
   test_routers.py
   test_reset_vm_on_reboot.py
   test_deploy_vms_with_varied_deploymentplanners.py
   test_network.py
   test_router_dns.py
   test_non_contigiousvlan.py
   test_login.py
   test_deploy_vm_iso.py
   test_list_ids_parameter.py
   test_public_ip_range.py
   test_multipleips_per_nic.py
   test_metrics_api.py
   test_regions.py
   test_affinity_groups.py
   test_network_acl.py
   test_pvlan.py
   test_volumes.py
   test_nic.py
   test_deploy_vm_root_resize.py
   test_resource_detail.py
   test_secondary_storage.py
   test_vm_life_cycle.py
   test_disk_offerings.py
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] mrunalinikankariya opened a new pull request #2076: CLOUDSTACK-9905 : VPN Gateway with Public Subnet

2017-05-04 Thread git
mrunalinikankariya opened a new pull request #2076: CLOUDSTACK-9905 : VPN 
Gateway with Public Subnet
URL: https://github.com/apache/cloudstack/pull/2076
 
 
   When we attempt to use a /24 subnet with a public IP ranges, for 
example,153.97.140.0/24. VPN Customer Gateways can be created with this type of 
CIDR, but cannot be updated, for example to 153.97.181.0/24 . Attempting to do 
so produces the error "The customer gateway cidr list 153.97.181.0/24 contains 
invalid guest cidr!"
   REPRO STEPS
   ==
   I was able to repro this in 4.5.1
   1) Created a new VPN Customer Gateway using the same settings as the customer
   2) Attempted to change the CIDR list entry from 153.97.180.0/24 to 
153.97.181.0/24
   3) The UI became unresponsive
   4) The Management-server log shows the following:
   2017-03-31 17:10:42,471 WARN [c.c.u.n.NetUtils] 
(API-Job-Executor-9:ctx-ed9b5816 job-172 ctx-32369258) (logid:3a16f24b) cidr 
153.97.181.0/24 is not RFC 1918 compliant
   153.97.181.0/24
   EXPECTED BEHAVIOR
   ==
   Users should be able to update existing VPN Customer Gateway CIDR list as 
needed
   
   Resolution
   
   Removed RFC 1918 compliant check during updation of VPN Customer Gateway CIDR
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] cloudmonger commented on issue #1894: CLOUDSTACK-9700 Allow user to Register/Copy templates to multiple zones at the same time

2017-05-04 Thread git
cloudmonger commented on issue #1894: CLOUDSTACK-9700 Allow user to 
Register/Copy templates to multiple zones at the same time
URL: https://github.com/apache/cloudstack/pull/1894#issuecomment-298819708
 
 
   ### ACS CI BVT Run
**Sumarry:**
Build Number 614
Hypervisor xenserver
NetworkType Advanced
Passed=109
Failed=3
Skipped=12
   
   _Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0
   
   
   **Failed tests:**
   * test_vm_snapshots.py
   
* test_change_service_offering_for_vm_with_snapshots Failed
   
   * test_routers_network_ops.py
   
* test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true Failed
   
* test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false Failed
   
   
   **Skipped tests:**
   test_vm_nic_adapter_vmxnet3
   test_01_verify_libvirt
   test_02_verify_libvirt_after_restart
   test_03_verify_libvirt_attach_disk
   test_04_verify_guest_lspci
   test_05_change_vm_ostype_restart
   test_06_verify_guest_lspci_again
   test_static_role_account_acls
   test_11_ss_nfs_version_on_ssvm
   test_nested_virtualization_vmware
   test_3d_gpu_support
   test_deploy_vgpu_enabled_vm
   
   **Passed test suits:**
   test_deploy_vm_with_userdata.py
   test_affinity_groups_projects.py
   test_portable_publicip.py
   test_over_provisioning.py
   test_global_settings.py
   test_scale_vm.py
   test_service_offerings.py
   test_routers_iptables_default_policy.py
   test_loadbalance.py
   test_routers.py
   test_reset_vm_on_reboot.py
   test_deploy_vms_with_varied_deploymentplanners.py
   test_network.py
   test_router_dns.py
   test_non_contigiousvlan.py
   test_login.py
   test_deploy_vm_iso.py
   test_list_ids_parameter.py
   test_public_ip_range.py
   test_multipleips_per_nic.py
   test_metrics_api.py
   test_regions.py
   test_affinity_groups.py
   test_network_acl.py
   test_pvlan.py
   test_volumes.py
   test_nic.py
   test_deploy_vm_root_resize.py
   test_resource_detail.py
   test_secondary_storage.py
   test_vm_life_cycle.py
   test_disk_offerings.py
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] cloudmonger commented on issue #1894: CLOUDSTACK-9700 Allow user to Register/Copy templates to multiple zones at the same time

2017-05-04 Thread git
cloudmonger commented on issue #1894: CLOUDSTACK-9700 Allow user to 
Register/Copy templates to multiple zones at the same time
URL: https://github.com/apache/cloudstack/pull/1894#issuecomment-299191802
 
 
   ### ACS CI BVT Run
**Sumarry:**
Build Number 620
Hypervisor xenserver
NetworkType Advanced
Passed=110
Failed=2
Skipped=12
   
   _Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/r2si930m8xxzavs/AAAzNrnoF1fC3auFrvsKo_8-a?dl=0
   
   **Failed tests:**
   * test_routers_network_ops.py
   
* test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true Failed
   
* test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false Failing since 3 
runs
   
   
   **Skipped tests:**
   test_vm_nic_adapter_vmxnet3
   test_01_verify_libvirt
   test_02_verify_libvirt_after_restart
   test_03_verify_libvirt_attach_disk
   test_04_verify_guest_lspci
   test_05_change_vm_ostype_restart
   test_06_verify_guest_lspci_again
   test_static_role_account_acls
   test_11_ss_nfs_version_on_ssvm
   test_nested_virtualization_vmware
   test_3d_gpu_support
   test_deploy_vgpu_enabled_vm
   
   **Passed test suits:**
   test_deploy_vm_with_userdata.py
   test_affinity_groups_projects.py
   test_portable_publicip.py
   test_vm_snapshots.py
   test_over_provisioning.py
   test_global_settings.py
   test_scale_vm.py
   test_service_offerings.py
   test_routers_iptables_default_policy.py
   test_loadbalance.py
   test_routers.py
   test_reset_vm_on_reboot.py
   test_deploy_vms_with_varied_deploymentplanners.py
   test_network.py
   test_router_dns.py
   test_non_contigiousvlan.py
   test_login.py
   test_deploy_vm_iso.py
   test_list_ids_parameter.py
   test_public_ip_range.py
   test_multipleips_per_nic.py
   test_metrics_api.py
   test_regions.py
   test_affinity_groups.py
   test_network_acl.py
   test_pvlan.py
   test_volumes.py
   test_nic.py
   test_deploy_vm_root_resize.py
   test_resource_detail.py
   test_secondary_storage.py
   test_vm_life_cycle.py
   test_disk_offerings.py
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] nathanejohnson opened a new pull request #2078: CLOUDSTACK-9902: add consoleproxy.sslEnable toggle

2017-05-04 Thread git
nathanejohnson opened a new pull request #2078: CLOUDSTACK-9902: add 
consoleproxy.sslEnable toggle
URL: https://github.com/apache/cloudstack/pull/2078
 
 
   This adds the missing global configuration parameter consoleproxy.sslEnable 
required for enabling SSL on the console proxy VM.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] serg38 commented on issue #927: CLOUDSTACK-9901 secure and hidden config values are returned as plaintext string

2017-05-04 Thread git
serg38 commented on issue #927: CLOUDSTACK-9901 secure and hidden config values 
are returned as plaintext string
URL: https://github.com/apache/cloudstack/pull/927#issuecomment-299225065
 
 
   LGTM @rhtyd @borisstoyanov @DaanHoogland Can we run B.O. for this PR?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] blueorangutan commented on issue #2018: CLOUDSTACK-9848: Added exit status checking for the iptables commands

2017-05-04 Thread git
ers.py
   test_deployvm_firstfit | Success | 231.93 | 
test_deploy_vms_with_varied_deploymentplanners.py
   test_deployvm_userdata_post | Success | 35.80 | 
test_deploy_vm_with_userdata.py
   test_deployvm_userdata | Success | 171.53 | test_deploy_vm_with_userdata.py
   test_02_deploy_vm_root_resize | Success | 5.92 | 
test_deploy_vm_root_resize.py
   test_01_deploy_vm_root_resize | Success | 5.95 | 
test_deploy_vm_root_resize.py
   test_00_deploy_vm_root_resize | Success | 6.03 | 
test_deploy_vm_root_resize.py
   test_deploy_vm_from_iso | Success | 227.78 | test_deploy_vm_iso.py
   test_3d_gpu_support | Success | 505.44 | test_deploy_vgpu_enabled_vm.py
   test_DeployVmAntiAffinityGroup | Success | 287.41 | test_affinity_groups.py
   test_08_resize_volume | Skipped | 10.14 | test_volumes.py
   test_07_resize_fail | Skipped | 10.33 | test_volumes.py
   test_06_copy_template | Skipped | 0.00 | test_templates.py
   test_static_role_account_acls | Skipped | 0.03 | test_staticroles.py
   test_11_ss_nfs_version_on_ssvm | Skipped | 0.02 | test_ssvm.py
   test_01_scale_vm | Skipped | 66.36 | test_scale_vm.py
   test_01_primary_storage_iscsi | Skipped | 0.04 | test_primary_storage.py
   test_06_copy_iso | Skipped | 0.00 | test_iso.py
   test_deploy_vgpu_enabled_vm | Skipped | 1.16 | test_deploy_vgpu_enabled_vm.py
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] leprechau commented on issue #1606: Allow CGN (RFC6598) to be used within a VPC

2017-05-04 Thread git
leprechau commented on issue #1606: Allow CGN (RFC6598) to be used within a VPC
URL: https://github.com/apache/cloudstack/pull/1606#issuecomment-299309549
 
 
   @kiwiflyer @karuturi Tests passed!
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] cloudmonger commented on issue #1894: CLOUDSTACK-9700 Allow user to Register/Copy templates to multiple zones at the same time

2017-05-04 Thread git
cloudmonger commented on issue #1894: CLOUDSTACK-9700 Allow user to 
Register/Copy templates to multiple zones at the same time
URL: https://github.com/apache/cloudstack/pull/1894#issuecomment-299191802
 
 
   ### ACS CI BVT Run
**Sumarry:**
Build Number 620
Hypervisor xenserver
NetworkType Advanced
Passed=110
Failed=2
Skipped=12
   
   _Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/r2si930m8xxzavs/AAAzNrnoF1fC3auFrvsKo_8-a?dl=0
   
   **Failed tests:**
   * test_routers_network_ops.py
   
* test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true Failed
   
* test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false Failing since 3 
runs
   
   
   **Skipped tests:**
   test_vm_nic_adapter_vmxnet3
   test_01_verify_libvirt
   test_02_verify_libvirt_after_restart
   test_03_verify_libvirt_attach_disk
   test_04_verify_guest_lspci
   test_05_change_vm_ostype_restart
   test_06_verify_guest_lspci_again
   test_static_role_account_acls
   test_11_ss_nfs_version_on_ssvm
   test_nested_virtualization_vmware
   test_3d_gpu_support
   test_deploy_vgpu_enabled_vm
   
   **Passed test suits:**
   test_deploy_vm_with_userdata.py
   test_affinity_groups_projects.py
   test_portable_publicip.py
   test_vm_snapshots.py
   test_over_provisioning.py
   test_global_settings.py
   test_scale_vm.py
   test_service_offerings.py
   test_routers_iptables_default_policy.py
   test_loadbalance.py
   test_routers.py
   test_reset_vm_on_reboot.py
   test_deploy_vms_with_varied_deploymentplanners.py
   test_network.py
   test_router_dns.py
   test_non_contigiousvlan.py
   test_login.py
   test_deploy_vm_iso.py
   test_list_ids_parameter.py
   test_public_ip_range.py
   test_multipleips_per_nic.py
   test_metrics_api.py
   test_regions.py
   test_affinity_groups.py
   test_network_acl.py
   test_pvlan.py
   test_volumes.py
   test_nic.py
   test_deploy_vm_root_resize.py
   test_resource_detail.py
   test_secondary_storage.py
   test_vm_life_cycle.py
   test_disk_offerings.py
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] cloudmonger commented on issue #1894: CLOUDSTACK-9700 Allow user to Register/Copy templates to multiple zones at the same time

2017-05-04 Thread git
cloudmonger commented on issue #1894: CLOUDSTACK-9700 Allow user to 
Register/Copy templates to multiple zones at the same time
URL: https://github.com/apache/cloudstack/pull/1894#issuecomment-299320546
 
 
   ### ACS CI BVT Run
**Sumarry:**
Build Number 622
Hypervisor xenserver
NetworkType Advanced
Passed=111
Failed=1
Skipped=12
   
   _Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/r2si930m8xxzavs/AAAzNrnoF1fC3auFrvsKo_8-a?dl=0
   
   **Failed tests:**
   * test_ssvm.py
   
* test_07_reboot_ssvm Failed
   
   
   **Skipped tests:**
   test_vm_nic_adapter_vmxnet3
   test_01_verify_libvirt
   test_02_verify_libvirt_after_restart
   test_03_verify_libvirt_attach_disk
   test_04_verify_guest_lspci
   test_05_change_vm_ostype_restart
   test_06_verify_guest_lspci_again
   test_static_role_account_acls
   test_11_ss_nfs_version_on_ssvm
   test_nested_virtualization_vmware
   test_3d_gpu_support
   test_deploy_vgpu_enabled_vm
   
   **Passed test suits:**
   test_deploy_vm_with_userdata.py
   test_affinity_groups_projects.py
   test_portable_publicip.py
   test_vm_snapshots.py
   test_over_provisioning.py
   test_global_settings.py
   test_scale_vm.py
   test_service_offerings.py
   test_routers_iptables_default_policy.py
   test_loadbalance.py
   test_routers.py
   test_reset_vm_on_reboot.py
   test_deploy_vms_with_varied_deploymentplanners.py
   test_network.py
   test_router_dns.py
   test_non_contigiousvlan.py
   test_login.py
   test_deploy_vm_iso.py
   test_list_ids_parameter.py
   test_public_ip_range.py
   test_multipleips_per_nic.py
   test_metrics_api.py
   test_regions.py
   test_affinity_groups.py
   test_network_acl.py
   test_pvlan.py
   test_volumes.py
   test_nic.py
   test_deploy_vm_root_resize.py
   test_resource_detail.py
   test_secondary_storage.py
   test_vm_life_cycle.py
   test_routers_network_ops.py
   test_disk_offerings.py
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] cloudmonger commented on issue #1894: CLOUDSTACK-9700 Allow user to Register/Copy templates to multiple zones at the same time

2017-05-04 Thread git
cloudmonger commented on issue #1894: CLOUDSTACK-9700 Allow user to 
Register/Copy templates to multiple zones at the same time
URL: https://github.com/apache/cloudstack/pull/1894#issuecomment-299320546
 
 
   ### ACS CI BVT Run
**Sumarry:**
Build Number 622
Hypervisor xenserver
NetworkType Advanced
Passed=111
Failed=1
Skipped=12
   
   _Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/r2si930m8xxzavs/AAAzNrnoF1fC3auFrvsKo_8-a?dl=0
   
   **Failed tests:**
   * test_ssvm.py
   
* test_07_reboot_ssvm Failed
   
   
   **Skipped tests:**
   test_vm_nic_adapter_vmxnet3
   test_01_verify_libvirt
   test_02_verify_libvirt_after_restart
   test_03_verify_libvirt_attach_disk
   test_04_verify_guest_lspci
   test_05_change_vm_ostype_restart
   test_06_verify_guest_lspci_again
   test_static_role_account_acls
   test_11_ss_nfs_version_on_ssvm
   test_nested_virtualization_vmware
   test_3d_gpu_support
   test_deploy_vgpu_enabled_vm
   
   **Passed test suits:**
   test_deploy_vm_with_userdata.py
   test_affinity_groups_projects.py
   test_portable_publicip.py
   test_vm_snapshots.py
   test_over_provisioning.py
   test_global_settings.py
   test_scale_vm.py
   test_service_offerings.py
   test_routers_iptables_default_policy.py
   test_loadbalance.py
   test_routers.py
   test_reset_vm_on_reboot.py
   test_deploy_vms_with_varied_deploymentplanners.py
   test_network.py
   test_router_dns.py
   test_non_contigiousvlan.py
   test_login.py
   test_deploy_vm_iso.py
   test_list_ids_parameter.py
   test_public_ip_range.py
   test_multipleips_per_nic.py
   test_metrics_api.py
   test_regions.py
   test_affinity_groups.py
   test_network_acl.py
   test_pvlan.py
   test_volumes.py
   test_nic.py
   test_deploy_vm_root_resize.py
   test_resource_detail.py
   test_secondary_storage.py
   test_vm_life_cycle.py
   test_routers_network_ops.py
   test_disk_offerings.py
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] cloudmonger commented on issue #1894: CLOUDSTACK-9700 Allow user to Register/Copy templates to multiple zones at the same time

2017-05-04 Thread git
cloudmonger commented on issue #1894: CLOUDSTACK-9700 Allow user to 
Register/Copy templates to multiple zones at the same time
URL: https://github.com/apache/cloudstack/pull/1894#issuecomment-299364306
 
 
   ### ACS CI BVT Run
**Sumarry:**
Build Number 623
Hypervisor xenserver
NetworkType Advanced
Passed=110
Failed=2
Skipped=12
   
   _Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/r2si930m8xxzavs/AAAzNrnoF1fC3auFrvsKo_8-a?dl=0
   
   **Failed tests:**
   * test_router_dns.py
   
* test_router_dns_guestipquery Failed
   
   * test_routers_network_ops.py
   
* test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true Failed
   
   
   **Skipped tests:**
   test_vm_nic_adapter_vmxnet3
   test_01_verify_libvirt
   test_02_verify_libvirt_after_restart
   test_03_verify_libvirt_attach_disk
   test_04_verify_guest_lspci
   test_05_change_vm_ostype_restart
   test_06_verify_guest_lspci_again
   test_static_role_account_acls
   test_11_ss_nfs_version_on_ssvm
   test_nested_virtualization_vmware
   test_3d_gpu_support
   test_deploy_vgpu_enabled_vm
   
   **Passed test suits:**
   test_deploy_vm_with_userdata.py
   test_affinity_groups_projects.py
   test_portable_publicip.py
   test_vm_snapshots.py
   test_over_provisioning.py
   test_global_settings.py
   test_scale_vm.py
   test_service_offerings.py
   test_routers_iptables_default_policy.py
   test_loadbalance.py
   test_routers.py
   test_reset_vm_on_reboot.py
   test_deploy_vms_with_varied_deploymentplanners.py
   test_network.py
   test_non_contigiousvlan.py
   test_login.py
   test_deploy_vm_iso.py
   test_list_ids_parameter.py
   test_public_ip_range.py
   test_multipleips_per_nic.py
   test_metrics_api.py
   test_regions.py
   test_affinity_groups.py
   test_network_acl.py
   test_pvlan.py
   test_volumes.py
   test_nic.py
   test_deploy_vm_root_resize.py
   test_resource_detail.py
   test_secondary_storage.py
   test_vm_life_cycle.py
   test_disk_offerings.py
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] jayapalu commented on issue #1996: CLOUDSTACK-9099: SecretKey is returned from the APIs

2017-05-04 Thread git
jayapalu commented on issue #1996: CLOUDSTACK-9099: SecretKey is returned from 
the APIs
URL: https://github.com/apache/cloudstack/pull/1996#issuecomment-299368310
 
 
   Previously Travis CI is failed. Now Travis CI is passed.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] mrunalinikankariya commented on issue #1940: CLOUDSTACK-9781:ACS records ID in events tables instead of UUID.

2017-05-04 Thread git
mrunalinikankariya commented on issue #1940: CLOUDSTACK-9781:ACS records ID in 
events tables instead of UUID.
URL: https://github.com/apache/cloudstack/pull/1940#issuecomment-299374950
 
 
   Code changes looks good, Code LGTM
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] mrunalinikankariya commented on issue #1940: CLOUDSTACK-9781:ACS records ID in events tables instead of UUID.

2017-05-04 Thread git
mrunalinikankariya commented on issue #1940: CLOUDSTACK-9781:ACS records ID in 
events tables instead of UUID.
URL: https://github.com/apache/cloudstack/pull/1940#issuecomment-299374950
 
 
   Code changes looks good, Code LGTM
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] sudhansu7 commented on issue #1849: CLOUDSTACK-9690: Scale CentOS7 VM fails with error

2017-05-04 Thread git
sudhansu7 commented on issue #1849: CLOUDSTACK-9690: Scale CentOS7 VM fails 
with error
URL: https://github.com/apache/cloudstack/pull/1849#issuecomment-299381856
 
 
   @jayantpatil1234, I have  removed Upgrade4910to4920.java from commit.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] sudhansu7 commented on issue #1849: CLOUDSTACK-9690: Scale CentOS7 VM fails with error

2017-05-04 Thread git
sudhansu7 commented on issue #1849: CLOUDSTACK-9690: Scale CentOS7 VM fails 
with error
URL: https://github.com/apache/cloudstack/pull/1849#issuecomment-299381952
 
 
   tag:mergeready
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] borisstoyanov commented on issue #927: CLOUDSTACK-9901 secure and hidden config values are returned as plaintext string

2017-05-04 Thread git
borisstoyanov commented on issue #927: CLOUDSTACK-9901 secure and hidden config 
values are returned as plaintext string
URL: https://github.com/apache/cloudstack/pull/927#issuecomment-299390982
 
 
   @blueorangutan package
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] blueorangutan commented on issue #927: CLOUDSTACK-9901 secure and hidden config values are returned as plaintext string

2017-05-04 Thread git
blueorangutan commented on issue #927: CLOUDSTACK-9901 secure and hidden config 
values are returned as plaintext string
URL: https://github.com/apache/cloudstack/pull/927#issuecomment-299391021
 
 
   @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] borisstoyanov commented on issue #1996: CLOUDSTACK-9099: SecretKey is returned from the APIs

2017-05-04 Thread git
borisstoyanov commented on issue #1996: CLOUDSTACK-9099: SecretKey is returned 
from the APIs
URL: https://github.com/apache/cloudstack/pull/1996#issuecomment-299393911
 
 
   Hi @jayapalu, 
   try setting API keys to the admin user and execute the tests again. I think 
that's the difference between Trillian environments and your instance. 
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] borisstoyanov commented on issue #927: CLOUDSTACK-9901 secure and hidden config values are returned as plaintext string

2017-05-04 Thread git
borisstoyanov commented on issue #927: CLOUDSTACK-9901 secure and hidden config 
values are returned as plaintext string
URL: https://github.com/apache/cloudstack/pull/927#issuecomment-299393981
 
 
   @blueorangutan test
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] blueorangutan commented on issue #927: CLOUDSTACK-9901 secure and hidden config values are returned as plaintext string

2017-05-04 Thread git
blueorangutan commented on issue #927: CLOUDSTACK-9901 secure and hidden config 
values are returned as plaintext string
URL: https://github.com/apache/cloudstack/pull/927#issuecomment-299394071
 
 
   @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] jayapalu commented on issue #1996: CLOUDSTACK-9099: SecretKey is returned from the APIs

2017-05-05 Thread git
jayapalu commented on issue #1996: CLOUDSTACK-9099: SecretKey is returned from 
the APIs
URL: https://github.com/apache/cloudstack/pull/1996#issuecomment-299397684
 
 
   @borisstoyanov Now Travis CI is passed can you please trigger the Trillian.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] jayapalu commented on issue #1870: CLOUDSTACK-9708: Router deployment failed due to two threads start VR simultaneously.

2017-05-05 Thread git
jayapalu commented on issue #1870: CLOUDSTACK-9708: Router deployment failed 
due to two threads start VR simultaneously.
URL: https://github.com/apache/cloudstack/pull/1870#issuecomment-299398428
 
 
   LGTM
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] borisstoyanov commented on issue #1996: CLOUDSTACK-9099: SecretKey is returned from the APIs

2017-05-05 Thread git
borisstoyanov commented on issue #1996: CLOUDSTACK-9099: SecretKey is returned 
from the APIs
URL: https://github.com/apache/cloudstack/pull/1996#issuecomment-299400325
 
 
   @blueorangutan package
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] blueorangutan commented on issue #1996: CLOUDSTACK-9099: SecretKey is returned from the APIs

2017-05-05 Thread git
blueorangutan commented on issue #1996: CLOUDSTACK-9099: SecretKey is returned 
from the APIs
URL: https://github.com/apache/cloudstack/pull/1996#issuecomment-299400409
 
 
   @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] borisstoyanov commented on issue #1996: CLOUDSTACK-9099: SecretKey is returned from the APIs

2017-05-05 Thread git
borisstoyanov commented on issue #1996: CLOUDSTACK-9099: SecretKey is returned 
from the APIs
URL: https://github.com/apache/cloudstack/pull/1996#issuecomment-299408245
 
 
   @blueorangutan test
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] blueorangutan commented on issue #1996: CLOUDSTACK-9099: SecretKey is returned from the APIs

2017-05-05 Thread git
blueorangutan commented on issue #1996: CLOUDSTACK-9099: SecretKey is returned 
from the APIs
URL: https://github.com/apache/cloudstack/pull/1996#issuecomment-299408283
 
 
   @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rhtyd commented on issue #2078: CLOUDSTACK-9902: add consoleproxy.sslEnable toggle

2017-05-05 Thread git
rhtyd commented on issue #2078: CLOUDSTACK-9902: add consoleproxy.sslEnable 
toggle
URL: https://github.com/apache/cloudstack/pull/2078#issuecomment-299413211
 
 
   Lgtm
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] sureshanaparti opened a new pull request #2079: WIP: CLOUDSTACK-9906 Create snapshot after volume resize for the volume with existing snapshot(s)

2017-05-05 Thread git
sureshanaparti opened a new pull request #2079: WIP: CLOUDSTACK-9906 Create 
snapshot after volume resize for the volume with existing snapshot(s)
URL: https://github.com/apache/cloudstack/pull/2079
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] nitt10prashant opened a new pull request #2080: Changing vlan to None since network offering being used has Specify Vlan set to No

2017-05-05 Thread git
nitt10prashant opened a new pull request #2080: Changing vlan to None since 
network offering being used has Specify Vlan set to No
URL: https://github.com/apache/cloudstack/pull/2080
 
 
   Default isolated network offering with SourceNat service has Specify Vlan 
parameter set to No. When specify vlan is "No" we can't pass vlan number for 
network creation api. Three tests are passing vlan id. Hence setting it to None.
   
   Test results:
   
   Validate that Admin should be able to create network for himslef ... === 
TestName: test_01_createNetwork_admin | Status : SUCCESS ===
   
   ok
   
   Validate that Admin should be able to create network for users in his domain 
... === TestName: test_02_createNetwork_admin_foruserinsamedomain | Status : 
SUCCESS ===
   
   ok
   
   Validate that Admin should be able to create network for users in his sub 
domain ... === TestName: test_03_createNetwork_admin_foruserinotherdomain | 
Status : SUCCESS ===
   
   ok
   
   Ran 3 tests in 440.959s
   
   OK
   
   this will close PR   https://github.com/apache/cloudstack/pull/1571
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] DaanHoogland commented on issue #2061: CLOUDSTACK-8308 automation test for Delta Snapshot

2017-05-05 Thread git
DaanHoogland commented on issue #2061: CLOUDSTACK-8308 automation test for 
Delta Snapshot
URL: https://github.com/apache/cloudstack/pull/2061#issuecomment-299424925
 
 
   @blueorangutan package
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] blueorangutan commented on issue #2061: CLOUDSTACK-8308 automation test for Delta Snapshot

2017-05-05 Thread git
blueorangutan commented on issue #2061: CLOUDSTACK-8308 automation test for 
Delta Snapshot
URL: https://github.com/apache/cloudstack/pull/2061#issuecomment-299425036
 
 
   @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] yvsubhash commented on issue #1940: CLOUDSTACK-9781:ACS records ID in events tables instead of UUID.

2017-05-05 Thread git
yvsubhash commented on issue #1940: CLOUDSTACK-9781:ACS records ID in events 
tables instead of UUID.
URL: https://github.com/apache/cloudstack/pull/1940#issuecomment-299431987
 
 
   @DaanHoogland  Current approach is not consistent between uuid and id.  This 
change does not impact the usage events. Can you please provide the possible 
reasons for using events for billing rather than usage events. 
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] yvsubhash commented on issue #1940: CLOUDSTACK-9781:ACS records ID in events tables instead of UUID.

2017-05-05 Thread git
yvsubhash commented on issue #1940: CLOUDSTACK-9781:ACS records ID in events 
tables instead of UUID.
URL: https://github.com/apache/cloudstack/pull/1940#issuecomment-299431987
 
 
   @DaanHoogland  Current approach is not consistent between uuid and id.  This 
change does not impact the usage events. Can you please provide the possible 
reasons for using events for billing rather than usage events. 
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] koteswararavipati commented on issue #1870: CLOUDSTACK-9708: Router deployment failed due to two threads start VR simultaneously.

2017-05-05 Thread git
koteswararavipati commented on issue #1870: CLOUDSTACK-9708: Router deployment 
failed due to two threads start VR simultaneously.
URL: https://github.com/apache/cloudstack/pull/1870#issuecomment-299436884
 
 
   LGTM
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] nitin-maharana commented on issue #1870: CLOUDSTACK-9708: Router deployment failed due to two threads start VR simultaneously.

2017-05-05 Thread git
nitin-maharana commented on issue #1870: CLOUDSTACK-9708: Router deployment 
failed due to two threads start VR simultaneously.
URL: https://github.com/apache/cloudstack/pull/1870#issuecomment-299442287
 
 
   Thanks @koteswararavipati @jayapalu.
   
   tag:mergeready
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] blueorangutan commented on issue #2061: CLOUDSTACK-8308 automation test for Delta Snapshot

2017-05-05 Thread git
blueorangutan commented on issue #2061: CLOUDSTACK-8308 automation test for 
Delta Snapshot
URL: https://github.com/apache/cloudstack/pull/2061#issuecomment-299442950
 
 
   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] DaanHoogland commented on issue #2061: CLOUDSTACK-8308 automation test for Delta Snapshot

2017-05-05 Thread git
DaanHoogland commented on issue #2061: CLOUDSTACK-8308 automation test for 
Delta Snapshot
URL: https://github.com/apache/cloudstack/pull/2061#issuecomment-299442910
 
 
   @blueorangutan test
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] sgoeminn commented on issue #1925: CLOUDSTACK-9751: Fix public ip not applied, when added while VR is starting

2017-05-05 Thread git
sgoeminn commented on issue #1925: CLOUDSTACK-9751: Fix public ip not applied, 
when added while VR is starting
URL: https://github.com/apache/cloudstack/pull/1925#issuecomment-299480829
 
 
   LGTM
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] blueorangutan commented on issue #927: CLOUDSTACK-9901 secure and hidden config values are returned as plaintext string

2017-05-05 Thread git
   test_03_list_snapshots | Success | 0.09 | test_list_ids_parameter.py
   test_02_list_templates | Success | 0.04 | test_list_ids_parameter.py
   test_01_list_volumes | Success | 0.03 | test_list_ids_parameter.py
   test_07_list_default_iso | Success | 0.06 | test_iso.py
   test_05_iso_permissions | Success | 0.06 | test_iso.py
   test_04_extract_Iso | Success | 5.15 | test_iso.py
   test_03_delete_iso | Success | 95.19 | test_iso.py
   test_02_edit_iso | Success | 0.08 | test_iso.py
   test_01_create_iso | Success | 20.97 | test_iso.py
   test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | Success | 188.16 | 
test_internal_lb.py
   test_03_vpc_internallb_haproxy_stats_on_all_interfaces | Success | 147.37 | 
test_internal_lb.py
   test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | Success | 479.94 | 
test_internal_lb.py
   test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Success | 415.23 | 
test_internal_lb.py
   test_dedicateGuestVlanRange | Success | 10.24 | test_guest_vlan_range.py
   test_UpdateConfigParamWithScope | Success | 0.13 | test_global_settings.py
   test_rolepermission_lifecycle_update | Success | 6.13 | test_dynamicroles.py
   test_rolepermission_lifecycle_list | Success | 5.95 | test_dynamicroles.py
   test_rolepermission_lifecycle_delete | Success | 5.84 | test_dynamicroles.py
   test_rolepermission_lifecycle_create | Success | 5.99 | test_dynamicroles.py
   test_rolepermission_lifecycle_concurrent_updates | Success | 6.00 | 
test_dynamicroles.py
   test_role_lifecycle_update_role_inuse | Success | 5.88 | test_dynamicroles.py
   test_role_lifecycle_update | Success | 11.22 | test_dynamicroles.py
   test_role_lifecycle_list | Success | 5.87 | test_dynamicroles.py
   test_role_lifecycle_delete | Success | 10.95 | test_dynamicroles.py
   test_role_lifecycle_create | Success | 5.88 | test_dynamicroles.py
   test_role_inuse_deletion | Success | 5.86 | test_dynamicroles.py
   test_role_account_acls_multiple_mgmt_servers | Success | 8.06 | 
test_dynamicroles.py
   test_role_account_acls | Success | 8.26 | test_dynamicroles.py
   test_default_role_deletion | Success | 6.02 | test_dynamicroles.py
   test_04_create_fat_type_disk_offering | Success | 0.06 | 
test_disk_offerings.py
   test_03_delete_disk_offering | Success | 0.08 | test_disk_offerings.py
   test_02_edit_disk_offering | Success | 0.04 | test_disk_offerings.py
   test_02_create_sparse_type_disk_offering | Success | 0.06 | 
test_disk_offerings.py
   test_01_create_disk_offering | Success | 0.10 | test_disk_offerings.py
   test_deployvm_userdispersing | Success | 20.64 | 
test_deploy_vms_with_varied_deploymentplanners.py
   test_deployvm_userconcentrated | Success | 20.57 | 
test_deploy_vms_with_varied_deploymentplanners.py
   test_deployvm_firstfit | Success | 80.81 | 
test_deploy_vms_with_varied_deploymentplanners.py
   test_deployvm_userdata_post | Success | 10.50 | 
test_deploy_vm_with_userdata.py
   test_deployvm_userdata | Success | 45.79 | test_deploy_vm_with_userdata.py
   test_02_deploy_vm_root_resize | Success | 5.97 | 
test_deploy_vm_root_resize.py
   test_01_deploy_vm_root_resize | Success | 5.98 | 
test_deploy_vm_root_resize.py
   test_00_deploy_vm_root_resize | Success | 207.32 | 
test_deploy_vm_root_resize.py
   test_deploy_vm_from_iso | Success | 202.19 | test_deploy_vm_iso.py
   test_06_verify_guest_lspci_again | Success | 33.41 | 
test_deploy_virtio_scsi_vm.py
   test_05_change_vm_ostype_restart | Success | 15.94 | 
test_deploy_virtio_scsi_vm.py
   test_04_verify_guest_lspci | Success | 37.39 | test_deploy_virtio_scsi_vm.py
   test_03_verify_libvirt_attach_disk | Success | 10.65 | 
test_deploy_virtio_scsi_vm.py
   test_02_verify_libvirt_after_restart | Success | 136.32 | 
test_deploy_virtio_scsi_vm.py
   test_01_verify_libvirt | Success | 0.39 | test_deploy_virtio_scsi_vm.py
   test_DeployVmAntiAffinityGroup | Success | 55.82 | test_affinity_groups.py
   test_change_service_offering_for_vm_with_snapshots | Skipped | 0.00 | 
test_vm_snapshots.py
   test_06_copy_template | Skipped | 0.00 | test_templates.py
   test_static_role_account_acls | Skipped | 0.03 | test_staticroles.py
   test_11_ss_nfs_version_on_ssvm | Skipped | 0.02 | test_ssvm.py
   test_01_scale_vm | Skipped | 0.00 | test_scale_vm.py
   test_01_primary_storage_iscsi | Skipped | 0.04 | test_primary_storage.py
   test_nested_virtualization_vmware | Skipped | 0.00 | 
test_nested_virtualization.py
   test_06_copy_iso | Skipped | 0.00 | test_iso.py
   test_deploy_vgpu_enabled_vm | Skipped | 0.03 | test_deploy_vgpu_enabled_vm.py
   test_3d_gpu_support | Skipped | 0.03 | test_deploy_vgpu_enabled_vm.py
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] serg38 commented on issue #927: CLOUDSTACK-9901 secure and hidden config values are returned as plaintext string

2017-05-05 Thread git
serg38 commented on issue #927: CLOUDSTACK-9901 secure and hidden config values 
are returned as plaintext string
URL: https://github.com/apache/cloudstack/pull/927#issuecomment-299486140
 
 
   tag:mergeready
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] kiwiflyer commented on issue #2078: CLOUDSTACK-9902: add consoleproxy.sslEnable toggle

2017-05-05 Thread git
kiwiflyer commented on issue #2078: CLOUDSTACK-9902: add consoleproxy.sslEnable 
toggle
URL: https://github.com/apache/cloudstack/pull/2078#issuecomment-299487460
 
 
   LGTM.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rafaelweingartner commented on issue #2078: CLOUDSTACK-9902: add consoleproxy.sslEnable toggle

2017-05-05 Thread git
rafaelweingartner commented on issue #2078: CLOUDSTACK-9902: add 
consoleproxy.sslEnable toggle
URL: https://github.com/apache/cloudstack/pull/2078#issuecomment-299492024
 
 
   @nathanejohnson thanks ;)
   LGTM
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rafaelweingartner commented on issue #2078: CLOUDSTACK-9902: add consoleproxy.sslEnable toggle

2017-05-05 Thread git
rafaelweingartner commented on issue #2078: CLOUDSTACK-9902: add 
consoleproxy.sslEnable toggle
URL: https://github.com/apache/cloudstack/pull/2078#issuecomment-299492024
 
 
   @nathanejohnson thanks ;)
   LGTM
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] blueorangutan commented on issue #2061: CLOUDSTACK-8308 automation test for Delta Snapshot

2017-05-05 Thread git
 | 207.64 | test_loadbalance.py
   test_03_list_snapshots | Success | 0.09 | test_list_ids_parameter.py
   test_02_list_templates | Success | 0.05 | test_list_ids_parameter.py
   test_01_list_volumes | Success | 0.03 | test_list_ids_parameter.py
   test_07_list_default_iso | Success | 0.07 | test_iso.py
   test_05_iso_permissions | Success | 0.08 | test_iso.py
   test_04_extract_Iso | Success | 5.15 | test_iso.py
   test_03_delete_iso | Success | 95.21 | test_iso.py
   test_02_edit_iso | Success | 0.08 | test_iso.py
   test_01_create_iso | Success | 21.00 | test_iso.py
   test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | Success | 182.78 | 
test_internal_lb.py
   test_03_vpc_internallb_haproxy_stats_on_all_interfaces | Success | 117.81 | 
test_internal_lb.py
   test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | Success | 511.11 | 
test_internal_lb.py
   test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Success | 439.41 | 
test_internal_lb.py
   test_dedicateGuestVlanRange | Success | 10.26 | test_guest_vlan_range.py
   test_UpdateConfigParamWithScope | Success | 0.13 | test_global_settings.py
   test_rolepermission_lifecycle_update | Success | 6.19 | test_dynamicroles.py
   test_rolepermission_lifecycle_list | Success | 6.02 | test_dynamicroles.py
   test_rolepermission_lifecycle_delete | Success | 5.87 | test_dynamicroles.py
   test_rolepermission_lifecycle_create | Success | 5.96 | test_dynamicroles.py
   test_rolepermission_lifecycle_concurrent_updates | Success | 6.04 | 
test_dynamicroles.py
   test_role_lifecycle_update_role_inuse | Success | 5.92 | test_dynamicroles.py
   test_role_lifecycle_update | Success | 11.01 | test_dynamicroles.py
   test_role_lifecycle_list | Success | 5.90 | test_dynamicroles.py
   test_role_lifecycle_delete | Success | 10.96 | test_dynamicroles.py
   test_role_lifecycle_create | Success | 5.90 | test_dynamicroles.py
   test_role_inuse_deletion | Success | 5.90 | test_dynamicroles.py
   test_role_account_acls_multiple_mgmt_servers | Success | 8.22 | 
test_dynamicroles.py
   test_role_account_acls | Success | 8.39 | test_dynamicroles.py
   test_default_role_deletion | Success | 6.01 | test_dynamicroles.py
   test_04_create_fat_type_disk_offering | Success | 0.07 | 
test_disk_offerings.py
   test_03_delete_disk_offering | Success | 0.04 | test_disk_offerings.py
   test_02_edit_disk_offering | Success | 0.05 | test_disk_offerings.py
   test_02_create_sparse_type_disk_offering | Success | 0.08 | 
test_disk_offerings.py
   test_01_create_disk_offering | Success | 0.11 | test_disk_offerings.py
   test_deployvm_userdispersing | Success | 20.62 | 
test_deploy_vms_with_varied_deploymentplanners.py
   test_deployvm_userconcentrated | Success | 20.58 | 
test_deploy_vms_with_varied_deploymentplanners.py
   test_deployvm_firstfit | Success | 90.83 | 
test_deploy_vms_with_varied_deploymentplanners.py
   test_deployvm_userdata_post | Success | 30.63 | 
test_deploy_vm_with_userdata.py
   test_deployvm_userdata | Success | 45.75 | test_deploy_vm_with_userdata.py
   test_02_deploy_vm_root_resize | Success | 6.02 | 
test_deploy_vm_root_resize.py
   test_01_deploy_vm_root_resize | Success | 6.00 | 
test_deploy_vm_root_resize.py
   test_00_deploy_vm_root_resize | Success | 222.56 | 
test_deploy_vm_root_resize.py
   test_deploy_vm_from_iso | Success | 212.52 | test_deploy_vm_iso.py
   test_06_verify_guest_lspci_again | Success | 40.48 | 
test_deploy_virtio_scsi_vm.py
   test_05_change_vm_ostype_restart | Success | 11.05 | 
test_deploy_virtio_scsi_vm.py
   test_04_verify_guest_lspci | Success | 40.52 | test_deploy_virtio_scsi_vm.py
   test_03_verify_libvirt_attach_disk | Success | 10.75 | 
test_deploy_virtio_scsi_vm.py
   test_02_verify_libvirt_after_restart | Success | 131.51 | 
test_deploy_virtio_scsi_vm.py
   test_01_verify_libvirt | Success | 0.58 | test_deploy_virtio_scsi_vm.py
   test_DeployVmAntiAffinityGroup | Success | 65.94 | test_affinity_groups.py
   test_change_service_offering_for_vm_with_snapshots | Skipped | 0.00 | 
test_vm_snapshots.py
   test_06_copy_template | Skipped | 0.00 | test_templates.py
   test_static_role_account_acls | Skipped | 0.02 | test_staticroles.py
   test_11_ss_nfs_version_on_ssvm | Skipped | 0.02 | test_ssvm.py
   test_01_scale_vm | Skipped | 0.00 | test_scale_vm.py
   test_01_primary_storage_iscsi | Skipped | 0.04 | test_primary_storage.py
   test_nested_virtualization_vmware | Skipped | 0.00 | 
test_nested_virtualization.py
   test_06_copy_iso | Skipped | 0.00 | test_iso.py
   test_deploy_vgpu_enabled_vm | Skipped | 0.03 | test_deploy_vgpu_enabled_vm.py
   test_3d_gpu_support | Skipped | 0.03 | test_deploy_vgpu_enabled_vm.py
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] rajesh-battala commented on issue #2031: CLOUDSTACK - 8672 : Alternate PR for NCC Integration with CloudStack (Original PR : #1859)

2017-05-05 Thread git
rajesh-battala commented on issue #2031: CLOUDSTACK - 8672 : Alternate PR for 
NCC Integration with CloudStack (Original PR : #1859)
URL: https://github.com/apache/cloudstack/pull/2031#issuecomment-299620556
 
 
   LGTM.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


<    1   2   3   4   5   6   7   8   9   10   >