[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3778: Endless settings on templates and instances

[GitBox]

DaanHoogland commented on a change in pull request #3778: Endless settings on 
templates and instances
URL: https://github.com/apache/cloudstack/pull/3778#discussion_r360579834
 
 

 ##
 File path: ui/scripts/templates.js
 ##
 @@ -2489,6 +2489,13 @@
custom: 
cloudStack.uiCustom.granularDetails({
 resourceType: 'Template',

dataProvider: function(args) {
+// no paging for listTemplates details
+if (args.page > 1){
+args.response.success({
+data: []
+});
+return;
+}
 
 Review comment:
   or here?!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3778: Endless settings on templates and instances

[GitBox]

DaanHoogland commented on a change in pull request #3778: Endless settings on 
templates and instances
URL: https://github.com/apache/cloudstack/pull/3778#discussion_r360579718
 
 

 ##
 File path: ui/scripts/instances.js
 ##
 @@ -3437,6 +3437,13 @@
custom: 
cloudStack.uiCustom.granularDetails({
 resourceType: 'UserVm',
dataProvider: 
function(args) {
+// no paging for listVirtualMachines details
+if (args.page > 1){
+args.response.success({
+data: []
+});
+return;
+}
 
 Review comment:
   What do you mean @anuragaw ? I see no problem with the indentation here.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services