[GitHub] [cloudstack] DaanHoogland commented on pull request #4089: extra guard in vmwareresource

2020-05-20 Thread GitBox 


DaanHoogland commented on pull request #4089:
URL: https://github.com/apache/cloudstack/pull/4089#issuecomment-631260153


   closing due to false alarm



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #4089: extra guard in vmwareresource

2020-05-19 Thread GitBox 


DaanHoogland commented on pull request #4089:
URL: https://github.com/apache/cloudstack/pull/4089#issuecomment-630742693


   @pavanaravapalli unfortunately this change does not seem to give the system 
enough protection. I have been able to break it based on this PR :(



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org