[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #3659: Fix typo: the past tense of shutdown is shutdown, not shutdowned
GabrielBrascher commented on a change in pull request #3659: Fix typo: the past tense of shutdown is shutdown, not shutdowned URL: https://github.com/apache/cloudstack/pull/3659#discussion_r344995918 ## File path: api/src/main/java/com/cloud/vm/VirtualMachine.java ## @@ -52,7 +52,7 @@ Migrating(true, "VM is being migrated. host id holds to from host"), Error(false, "VM is in error"), Unknown(false, "VM state is unknown."), -Shutdowned(false, "VM is shutdowned from inside"); +Shutdown(false, "VM is shutdown from inside"); Review comment: @rhtyd added a database upgrade schema from 4.13.0.0 to 4.13.1.0 upgrading VMs from state `Shutdowned` to `Shutdown`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #3659: Fix typo: the past tense of shutdown is shutdown, not shutdowned
GabrielBrascher commented on a change in pull request #3659: Fix typo: the past tense of shutdown is shutdown, not shutdowned URL: https://github.com/apache/cloudstack/pull/3659#discussion_r346482546 ## File path: api/src/main/java/com/cloud/vm/VirtualMachine.java ## @@ -52,7 +52,7 @@ Migrating(true, "VM is being migrated. host id holds to from host"), Error(false, "VM is in error"), Unknown(false, "VM state is unknown."), -Shutdowned(false, "VM is shutdowned from inside"); +Shutdown(false, "VM is shutdown from inside"); Review comment: @rhtyd does it look like a 4.13.1 fix? I had mapped it to 4.13.1.0, but I can target it to master/4.14.0.0; not really a bug fix, more likely an enhancement. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
