[GitHub] [cloudstack] GabrielBrascher edited a comment on issue #3186: Add possibility to set KVM MTU size for all NIC
GabrielBrascher edited a comment on issue #3186: Add possibility to set KVM MTU size for all NIC URL: https://github.com/apache/cloudstack/pull/3186#issuecomment-57070 @svenvogel parsing data to systemvms requires a bit of work indeed; here follows a bit of explanation. The [common.sh](https://github.com/apache/cloudstack/blob/master/systemvm/debian/opt/cloud/bin/setup/common.sh) script (_cloudstack/systemvm/debian/opt/cloud/bin/setup/common.sh_) parses the 'cmdline' values (as mentioned above by @wido ). That script is the base for multipe scripts such as: - [consoleproxy.sh](https://github.com/apache/cloudstack/blob/master/systemvm/debian/opt/cloud/bin/setup/consoleproxy.sh) - [router.sh](https://github.com/apache/cloudstack/blob/master/systemvm/debian/opt/cloud/bin/setup/router.sh) - [secstorage.sh](https://github.com/apache/cloudstack/blob/master/systemvm/debian/opt/cloud/bin/setup/secstorage.sh) - [vpcrouter.sh](https://github.com/apache/cloudstack/blob/master/systemvm/debian/opt/cloud/bin/setup/vpcrouter.sh) On VRs we can see the **cmdline** values at _/var/cache/cloud/cmdline_: `root@r-2293-VM:~# cat /var/cache/cloud/cmdline` `template=domP name=r-2293-VM eth0ip=123.123.123.123 eth0mask=255.255.255.0 gateway=123.123.123.1 domain=cs1cloud.internal cidrsize=24 dhcprange=123.123.123.1 eth1ip=169.254.0.52 eth1mask=255.255.0.0 type=dhcpsrvr disable_rp_filter=true dns1=1.1.1.1 dns2=2.2.2.2 (etc)` For VRs, there is [router.sh](https://github.com/apache/cloudstack/blob/master/systemvm/debian/opt/cloud/bin/setup/router.sh), used for configuring virtual router (e.g. network interfaces). On the management server side, there is the preparation code that sets up a StringBuilder that will contain all these configuration data. For (non-VPC) VRs we can find a bit of details at method finalizeVirtualMachineProfile in [VirtualNetworkApplianceManagerImpl.java](https://github.com/apache/cloudstack/blob/master/server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java#L1311) On the execution flow, there are also the python scripts [merge.py](https://github.com/apache/cloudstack/blob/master/systemvm/debian/opt/cloud/bin/merge.py) & [CsAddress.py](https://github.com/apache/cloudstack/blob/master/systemvm/debian/opt/cloud/bin/cs/CsAddress.py). The question now is how to proceed with this. Does it fit as a new PR or should we add the MTU configuration into systemvms/VRs at this PR? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] GabrielBrascher edited a comment on issue #3186: Add possibility to set KVM MTU size for all NIC
GabrielBrascher edited a comment on issue #3186: Add possibility to set KVM MTU size for all NIC URL: https://github.com/apache/cloudstack/pull/3186#issuecomment-57070 @svenvogel parsing data to systemvms requires a bit of work indeed; here follows a bit of explanation. The [common.sh](https://github.com/apache/cloudstack/blob/master/systemvm/debian/opt/cloud/bin/setup/common.sh) script (_cloudstack/systemvm/debian/opt/cloud/bin/setup/common.sh_) parses the 'cmdline' values (as mentioned above by @wido ). That script is the base for multipe scripts such as: - [consoleproxy.sh](https://github.com/apache/cloudstack/blob/master/systemvm/debian/opt/cloud/bin/setup/consoleproxy.sh) - [router.sh](https://github.com/apache/cloudstack/blob/master/systemvm/debian/opt/cloud/bin/setup/router.sh) - [secstorage.sh](https://github.com/apache/cloudstack/blob/master/systemvm/debian/opt/cloud/bin/setup/secstorage.sh) - [vpcrouter.sh](https://github.com/apache/cloudstack/blob/master/systemvm/debian/opt/cloud/bin/setup/vpcrouter.sh) On VRs we can see the **cmdline** values at _/var/cache/cloud/cmdline_: `root@r-2293-VM:~# cat /var/cache/cloud/cmdline` `template=domP name=r-2293-VM eth0ip=109.72.91.50 eth0mask=255.255.255.192 gateway=109.72.91.1 domain=cs1cloud.internal cidrsize=26 dhcprange=109.72.91.1 eth1ip=169.254.0.52 eth1mask=255.255.0.0 type=dhcpsrvr disable_rp_filter=true dns1=93.180.70.22 dns2=93.180.70.30 (etc)` For VRs, there is [router.sh](https://github.com/apache/cloudstack/blob/master/systemvm/debian/opt/cloud/bin/setup/router.sh), used for configuring virtual router (e.g. network interfaces). On the management server side, there is the preparation code that sets up a StringBuilder that will contain all these configuration data. For (non-VPC) VRs we can find a bit of details at method finalizeVirtualMachineProfile in [VirtualNetworkApplianceManagerImpl.java](https://github.com/apache/cloudstack/blob/master/server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java#L1311) On the execution flow, there are also the python scripts [merge.py](https://github.com/apache/cloudstack/blob/master/systemvm/debian/opt/cloud/bin/merge.py) & [CsAddress.py](https://github.com/apache/cloudstack/blob/master/systemvm/debian/opt/cloud/bin/cs/CsAddress.py). The question now is how to proceed with this. Does it fit as a new PR? Would it best fit in this PR? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] GabrielBrascher edited a comment on issue #3186: Add possibility to set KVM MTU size for all NIC
GabrielBrascher edited a comment on issue #3186: Add possibility to set KVM MTU size for all NIC URL: https://github.com/apache/cloudstack/pull/3186#issuecomment-553909811 @svenvogel I am testing it right now; should have feedback soon (based on code and manual tests). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
