[GitHub] [cloudstack] Pearl1594 commented on pull request #4193: Fix usage record count
Pearl1594 commented on pull request #4193: URL: https://github.com/apache/cloudstack/pull/4193#issuecomment-713309122 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4193: Fix usage record count
Pearl1594 commented on pull request #4193: URL: https://github.com/apache/cloudstack/pull/4193#issuecomment-712803656 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4193: Fix usage record count
Pearl1594 commented on pull request #4193: URL: https://github.com/apache/cloudstack/pull/4193#issuecomment-712803494 It's good to go @olivierlemasle This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4193: Fix usage record count
Pearl1594 commented on pull request #4193: URL: https://github.com/apache/cloudstack/pull/4193#issuecomment-694654396 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4193: Fix usage record count
Pearl1594 commented on pull request #4193: URL: https://github.com/apache/cloudstack/pull/4193#issuecomment-693811664 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4193: Fix usage record count
Pearl1594 commented on pull request #4193: URL: https://github.com/apache/cloudstack/pull/4193#issuecomment-692455059 > @Pearl1594 @rhtyd Is that what you proposed? > > * First, fix the `count` value with [5b5a2e5](https://github.com/apache/cloudstack/commit/5b5a2e54dd2016481385d3b8558f23280d5047d1) AND return all usage records (incl. usages for IP addresses on networks flagged with "Hide IP address usage", which means reverting temporarily #3235) > > * Then, in a separate PR, handle the hiding with a proper solution. I think the best solution (performance-wise) would require a DB schema update: > > * Adding a flag (e.g. `hidden`) in table `cloud_usage.cloud_usage` ; `listUsageRecords` would then simply filter out these usages. > * It would also require adding a new column in `cloud_usage.usage_ip_address` to know if the corresponding usage should be hidden. This new flag would be set in`UsageManagerImpl`. > > > @Pearl1594 Is that what you thought? Do you want me to do the PRs (both or only the second) or do you want to do it? @olivierlemasle Apologies for the delay in response, but this was precisely what I meant. Sounds like a good plan - to revert my PR to https://github.com/apache/cloudstack/commit/5b5a2e54dd2016481385d3b8558f23280d5047d1. Thanks a lot for the PR! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4193: Fix usage record count
Pearl1594 commented on pull request #4193: URL: https://github.com/apache/cloudstack/pull/4193#issuecomment-678080007 Hi @olivierlemasle , I've been tied up with other stuff and haven't been able to give time to this. However, to get the right count when hideIpAddressUsage is true, can be a bit involved inorder to make it efficient. As a first level fix, we can get the pagination issue sorted, as it currently works, and for handling hiding IP usage records, we can have another PR? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4193: Fix usage record count
Pearl1594 commented on pull request #4193: URL: https://github.com/apache/cloudstack/pull/4193#issuecomment-660045113 @olivierlemasle It will probably require another round of testing before it can be merged. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4193: Fix usage record count
Pearl1594 commented on pull request #4193: URL: https://github.com/apache/cloudstack/pull/4193#issuecomment-654372196 @rhtyd since startdate and enddate are mandatory fields in the API , the usageRecords fetched from the database will be within the (date) range provided and further processing is then done on that list obtained This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4193: Fix usage record count
Pearl1594 commented on pull request #4193: URL: https://github.com/apache/cloudstack/pull/4193#issuecomment-653611920 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4193: Fix usage record count
Pearl1594 commented on pull request #4193: URL: https://github.com/apache/cloudstack/pull/4193#issuecomment-653605175 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4193: Fix usage record count
Pearl1594 commented on pull request #4193: URL: https://github.com/apache/cloudstack/pull/4193#issuecomment-653536294 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4193: Fix usage record count
Pearl1594 commented on pull request #4193: URL: https://github.com/apache/cloudstack/pull/4193#issuecomment-652930395 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4193: Fix usage record count fix
Pearl1594 commented on pull request #4193: URL: https://github.com/apache/cloudstack/pull/4193#issuecomment-652385913 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
