[GitHub] [cloudstack] Spaceman1984 opened a new pull request #4016: Fixed private gateway can't be deleted
Spaceman1984 opened a new pull request #4016: URL: https://github.com/apache/cloudstack/pull/4016 ## Description When the static route service is not available on the VPC and a static route is created, the static route is created in a revoked state. Currently, the UI doesn't distinguish between active or revoked static routes. This PR adds the missing state filter to the list routes command and only lists active routes in the UI. It also ignores revoked routes when the private gateway is being removed but clears out the inactive routes before the gateway is removed. Fixes #2908 ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [x] Bug fix (non-breaking change which fixes an issue) - [x] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## Screenshots (if appropriate): ## How Has This Been Tested? This has been tested by creating a VPC with no services, adding a private gateway, adding a static route and deleting the gateway. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 opened a new pull request #4016: Fixed private gateway can't be deleted
Spaceman1984 opened a new pull request #4016: Fixed private gateway can't be deleted URL: https://github.com/apache/cloudstack/pull/4016 ## Description When the static route service is not available on the VPC when a static route is created, the static route is created in a revoked state. Currently, the UI doesn't distinguish between active or revoked static routes. This PR adds the missing state filter to the list routes command and only lists active routes in the UI. It also ignores revoked routes when the private gateway is being removed but clears out the inactive routes after the gateway is removed. Fixes #2908 ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [x] Bug fix (non-breaking change which fixes an issue) - [x] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## Screenshots (if appropriate): ## How Has This Been Tested? This has been tested by creating a VPC with no services, adding a private gateway, adding a static route and deleting the gateway. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
