[GitHub] [cloudstack] andrijapanicsb commented on issue #3371: Fix virtual template size for managed storage for KVM / refactor cloud-install-sys-tmplt
andrijapanicsb commented on issue #3371: Fix virtual template size for managed storage for KVM / refactor cloud-install-sys-tmplt URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-566566974 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3371: Fix virtual template size for managed storage for KVM / refactor cloud-install-sys-tmplt
andrijapanicsb commented on issue #3371: Fix virtual template size for managed storage for KVM / refactor cloud-install-sys-tmplt URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-566565399 Apologies @svenvogel , I have reverted this PR/merge - since tests have NOT complete (there is no output) - let me kick the tests again, and if all fine, you can merge it after that, please. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3371: Fix virtual template size for managed storage for KVM / refactor cloud-install-sys-tmplt
andrijapanicsb commented on issue #3371: Fix virtual template size for managed storage for KVM / refactor cloud-install-sys-tmplt URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-559590637 @svenvogel , if others agree @weizhouapache @rhtyd - see this PR from Rohit on how package dependencies are added, and then: - simply add depedency on qemu-img for both Debian/CentOS mgmt server packages - remove any checks whether qemu-img is present or not (since it has to be present in order even install the mgmt server) - remove the flag and unconditionally store the right value in the virtual size properties (only for KVM, as per the current implementation) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3371: Fix virtual template size for managed storage for KVM / refactor cloud-install-sys-tmplt
andrijapanicsb commented on issue #3371: Fix virtual template size for managed storage for KVM / refactor cloud-install-sys-tmplt URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-554788542 @svenvogel @rhtyd @PaulAngus - I've just checked/tested the thing and the decision to store the VIRTUAL size (vs. the physical size that we do currently) in the "qcow2.virtualsize" and "virtualsize"" is the correct thing to do. This is exactly what is done when we download a template from i.e. internet into ACS - otherwise, trying to spin a system VM on SF will fail. Now, a few points from my side: - In ideal world, we should make qemu-img a mandatory/dependency binary while installing the "cloudstack-management" binaries and remove that -M flag in this PR, and **ALWAYS** store the VIRTUAL size in those 2 values, irrelevant of what storage is used. - we are refactoring something that has been working ever since (some needless refactoring like putting ELSE in the same line, vs. a new line previously - I really don't see a need to do so) - If you stick to the current PR, then you are relying on having qemu-img installed, so this needs documentation update (I see error messages raised etc) - or do a better solution as I suggested above and make it a dependency and remove the -M flag conditions completely. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3371: Fix virtual template size for managed storage for KVM / refactor cloud-install-sys-tmplt
andrijapanicsb commented on issue #3371: Fix virtual template size for managed storage for KVM / refactor cloud-install-sys-tmplt URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-554783973 qemuimgcmd=$(which qemu-img) ... vrtmpltsize=$($qemuimgcmd info $tmpltfile | grep -i 'virtual size' | ... This suggests that in order for it to work, you need to have qemu-img installed on the management server - do you plan to add some documentation on this? @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3371: Fix virtual template size for managed storage for KVM / refactor cloud-install-sys-tmplt
andrijapanicsb commented on issue #3371: Fix virtual template size for managed storage for KVM / refactor cloud-install-sys-tmplt URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-554665953 hm... I've personally used KVM with SolidFire, including hosting all system VMs on SF. I read the explanation but still don't get it why it is now required @svenvogel This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
