[GitHub] [cloudstack] andrijapanicsb commented on issue #3617: [KVM] Agent LB Fix: Connections from disabled KVM host agents are refused
andrijapanicsb commented on issue #3617: [KVM] Agent LB Fix: Connections from disabled KVM host agents are refused URL: https://github.com/apache/cloudstack/pull/3617#issuecomment-559004597 LGTM. (Extensive manual testing) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3617: [KVM] Agent LB Fix: Connections from disabled KVM host agents are refused
andrijapanicsb commented on issue #3617: [KVM] Agent LB Fix: Connections from disabled KVM host agents are refused URL: https://github.com/apache/cloudstack/pull/3617#issuecomment-558704164 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3617: [KVM] Agent LB Fix: Connections from disabled KVM host agents are refused
andrijapanicsb commented on issue #3617: [KVM] Agent LB Fix: Connections from disabled KVM host agents are refused URL: https://github.com/apache/cloudstack/pull/3617#issuecomment-558610806 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3617: [KVM] Agent LB Fix: Connections from disabled KVM host agents are refused
andrijapanicsb commented on issue #3617: [KVM] Agent LB Fix: Connections from disabled KVM host agents are refused URL: https://github.com/apache/cloudstack/pull/3617#issuecomment-558389089 LGTM. Tested manually as following: TestID | Test Name | Steps | Expected Result | Status -- | -- | -- | -- | -- 1 | New configuration values are propagated to host in “Disabled” state | Disable a host. Change value of the “host” and/or “indirect.agent.lb.algorithm” global settings. | Observe the content of the /etc/cloudstack/agent/agent.properties contain the new values, even though the host is still Disabled. | Pass 2 | New setting values are propagated to the host in the PrepareForMaintenance | Put host in maintenance mode. While the host is in the PrepareForMaintenance state, change the values of “host” and/or “indirect.agent.lb.algorithm”. | Observe the content of the /etc/cloudstack/agent/agent.properties contain the new values from the “host” and/or ” indirect.agent.lb.algorithm” almost immediately (i.e. no more than few seconds after the values are changed via API call) | Pass 3 | New configuration values are propagated to the host that is already in Maintenance mode | Put host in maintenance mode. After the host is in the Maintenance state, change the values of “host” and/or “indirect.agent.lb.algorithm”. | Observe the content of the /etc/cloudstack/agent/agent.properties contain the new values from the “host” and/or ” indirect.agent.lb.algorithm” almost immediately (i.e. no more than few seconds after the values are changed via API call) | Pass 5 | Host is able to connect back to management server, after the restart | Disable the host.Change the values of “host” and/or “indirect.agent.lb.algorithm”. Restart the cloudstack-agent on the host | Observe that host will temporarily be in the “Connecting” state and will eventually transition to the “Up” state (connected to a management server) | Pass 6 | A host doesn’t require agent restart in order to exit Maintenance mode | While having "kvm.ssh.to.agent" seto to false , put the host into the Maintenance mode. Do NOT restart cloudstack-agent . Cancel the Maintenance mode for the host | Observe that host “Resource state” will transition from “Maintenance” to “Enabled” | Pass | | | | | | | | This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3617: [KVM] Agent LB Fix: Connections from disabled KVM host agents are refused
andrijapanicsb commented on issue #3617: [KVM] Agent LB Fix: Connections from disabled KVM host agents are refused URL: https://github.com/apache/cloudstack/pull/3617#issuecomment-558387712 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3617: [KVM] Agent LB Fix: Connections from disabled KVM host agents are refused
andrijapanicsb commented on issue #3617: [KVM] Agent LB Fix: Connections from disabled KVM host agents are refused URL: https://github.com/apache/cloudstack/pull/3617#issuecomment-558139022 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3617: [KVM] Agent LB Fix: Connections from disabled KVM host agents are refused
andrijapanicsb commented on issue #3617: [KVM] Agent LB Fix: Connections from disabled KVM host agents are refused URL: https://github.com/apache/cloudstack/pull/3617#issuecomment-553800862 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
