[GitHub] [cloudstack] anuragaw commented on a change in pull request #3391: ui: fix for disk offering quickview details, actions
anuragaw commented on a change in pull request #3391: ui: fix for disk offering
quickview details, actions
URL: https://github.com/apache/cloudstack/pull/3391#discussion_r292327591
##
File path: ui/scripts/configuration.js
##
@@ -2403,16 +2403,19 @@
dataProvider: function(args) {
var data = {
+isrecursive: true,
id: args.context.diskOfferings[0].id
};
-var listDiskOfferingsOptions = {
-isRecursive: true,
-data: data
-};
-var diskOfferings =
cloudStack.listDiskOfferings(listDiskOfferingsOptions);
-args.response.success({
-actionFilter: diskOfferingActionfilter,
-data: diskOfferings[0]
+$.ajax({
Review comment:
async false?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] anuragaw commented on a change in pull request #3391: ui: fix for disk offering quickview details, actions
anuragaw commented on a change in pull request #3391: ui: fix for disk offering
quickview details, actions
URL: https://github.com/apache/cloudstack/pull/3391#discussion_r292328029
##
File path: ui/scripts/configuration.js
##
@@ -2403,16 +2403,19 @@
dataProvider: function(args) {
var data = {
+isrecursive: true,
id: args.context.diskOfferings[0].id
};
-var listDiskOfferingsOptions = {
-isRecursive: true,
-data: data
-};
-var diskOfferings =
cloudStack.listDiskOfferings(listDiskOfferingsOptions);
-args.response.success({
-actionFilter: diskOfferingActionfilter,
-data: diskOfferings[0]
+$.ajax({
Review comment:
Also any value to fixing the cloudStack.listDiskOfferings method itself?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
