[GitHub] [cloudstack] nvazquez commented on a change in pull request #3967: noVNC console integration
nvazquez commented on a change in pull request #3967: noVNC console integration
URL: https://github.com/apache/cloudstack/pull/3967#discussion_r398866057
##
File path: server/src/main/java/com/cloud/consoleproxy/ConsoleProxyManager.java
##
@@ -31,9 +33,14 @@
public static final int DEFAULT_PROXY_URL_PORT = 80;
public static final int DEFAULT_PROXY_SESSION_TIMEOUT = 30;//
5 minutes
+public static final int DEFAULT_NOVNC_PORT = 8080;
+
public static final String ALERT_SUBJECT = "proxy-alert";
public static final String CERTIFICATE_NAME = "CPVMCertificate";
+public static final ConfigKey NoVncConsoleDefault = new
ConfigKey("Advanced", Boolean.class, "novnc.console.default", "true",
+"If true, noVNC console will be default console for virtual machines",
true);
Review comment:
I think it should be disabled by default at least until all hypervisors
tested working properly
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] nvazquez commented on a change in pull request #3967: noVNC console integration
nvazquez commented on a change in pull request #3967: noVNC console integration
URL: https://github.com/apache/cloudstack/pull/3967#discussion_r398863880
##
File path: server/src/main/java/com/cloud/servlet/ConsoleProxyServlet.java
##
@@ -478,7 +481,12 @@ private String composeConsoleAccessUrl(String rootUrl,
VirtualMachine vm, HostVO
param.setClientTunnelSession(parsedHostInfo.third());
}
-sb.append("/ajax?token=" +
encryptor.encryptObject(ConsoleProxyClientParam.class, param));
+if (param.getHypervHost() != null ||
!ConsoleProxyManager.NoVncConsoleDefault.value()) {
+sb.append("/ajax?token=" +
encryptor.encryptObject(ConsoleProxyClientParam.class, param));
+} else {
+sb.append("/resource/noVNC/vnc_lite.html?port=" +
ConsoleProxyManager.DEFAULT_NOVNC_PORT + "&token="
Review comment:
Why not using `vnc.html` which provides more functionalities? Briefly tested
invoking it and got this extra functionalities:
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
