[GitHub] [cloudstack] olivierlemasle commented on pull request #4193: Fix usage record count
olivierlemasle commented on pull request #4193: URL: https://github.com/apache/cloudstack/pull/4193#issuecomment-713870794 Thanks @DaanHoogland This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] olivierlemasle commented on pull request #4193: Fix usage record count
olivierlemasle commented on pull request #4193: URL: https://github.com/apache/cloudstack/pull/4193#issuecomment-713642861 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] olivierlemasle commented on pull request #4193: Fix usage record count
olivierlemasle commented on pull request #4193: URL: https://github.com/apache/cloudstack/pull/4193#issuecomment-712777900 @Pearl1594 Any new on this? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] olivierlemasle commented on pull request #4193: Fix usage record count
olivierlemasle commented on pull request #4193: URL: https://github.com/apache/cloudstack/pull/4193#issuecomment-704232698 IMHO, this should be backported in 4.13, 4.14 and recent releases, as it fixes a regression in 4.13. The "long-term fix" #4327 should be included in the next release. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] olivierlemasle commented on pull request #4193: Fix usage record count
olivierlemasle commented on pull request #4193: URL: https://github.com/apache/cloudstack/pull/4193#issuecomment-703694530 @Pearl1594 Any chance merging this PR? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] olivierlemasle commented on pull request #4193: Fix usage record count
olivierlemasle commented on pull request #4193: URL: https://github.com/apache/cloudstack/pull/4193#issuecomment-692926410 > Sounds like a good plan - to revert my PR to 5b5a2e5. @Pearl1594 Don't you want to also remove https://github.com/apache/cloudstack/blob/caefb0c9b5f3b7234291f13d272c15a928489b3f/server/src/main/java/com/cloud/api/ApiResponseHelper.java#L3437-L3441 (as you did in 69eeac38)? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] olivierlemasle commented on pull request #4193: Fix usage record count
olivierlemasle commented on pull request #4193: URL: https://github.com/apache/cloudstack/pull/4193#issuecomment-692159524 @Pearl1594 I suggest you revert in this PR the change on `UsageServiceImpl.java`. This PR will then do two things: - Fix the `count` issue; - Return all usages (even usages for IP addresses on networks flagged with "Hide IP address usage"). This would fix #4191. On my side, I've just opened a new PR, #4327, which fixes the issue for hidden IP address usages. However, this PR includes a DB schema change, so I guess it could not be merged in all impacted branches (since 4.13). @Pearl1594 @rhtyd Is that ok? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] olivierlemasle commented on pull request #4193: Fix usage record count
olivierlemasle commented on pull request #4193: URL: https://github.com/apache/cloudstack/pull/4193#issuecomment-688447107 @Pearl1594 @rhtyd Is that what you propose? - First, fix the `count` value with https://github.com/apache/cloudstack/pull/4193/commits/5b5a2e54dd2016481385d3b8558f23280d5047d1 AND return all usage records (incl. usages for IP addresses on networks flagged with "Hide IP address usage", which means reverting temporarily #3235) - Then, in a separate PR, handle the hiding with a proper solution. I think the best solution (performance-wise) would require a DB schema update: - Adding a flag (e.g. `hidden`) in table `cloud_usage.cloud_usage` ; `listUsageRecords` would then simply filter out these usages. - It would also require adding a new column in `cloud_usage.usage_ip_address` to know if the corresponding usage should be hidden. This new flag would be set in`UsageManagerImpl`. @Pearl1594 Is that what you thought? Do you want me to do the PRs (both or only the second) or do you want to do it? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] olivierlemasle commented on pull request #4193: Fix usage record count
olivierlemasle commented on pull request #4193: URL: https://github.com/apache/cloudstack/pull/4193#issuecomment-678076531 Hi @Pearl1594, did you get any chance to look into the pagination issue? Thank you! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] olivierlemasle commented on pull request #4193: Fix usage record count
olivierlemasle commented on pull request #4193: URL: https://github.com/apache/cloudstack/pull/4193#issuecomment-658865965 Hi @Pearl1594 @rhtyd What are the required steps before merging this? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
