[GitHub] [cloudstack] olivierlemasle commented on pull request #4327: Re-enable IP address usage hiding

2020-11-06 Thread GitBox 


olivierlemasle commented on pull request #4327:
URL: https://github.com/apache/cloudstack/pull/4327#issuecomment-723013415


   @DaanHoogland I've just updated the PR after your comment.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] olivierlemasle commented on pull request #4327: Re-enable IP address usage hiding

2020-10-21 Thread GitBox 


olivierlemasle commented on pull request #4327:
URL: https://github.com/apache/cloudstack/pull/4327#issuecomment-713634956


   :+1: for 4.15! Without it, IP addresses will generate usages on networks 
flagged "Hide IP address usages"...



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] olivierlemasle commented on pull request #4327: Re-enable IP address usage hiding

2020-09-28 Thread GitBox 


olivierlemasle commented on pull request #4327:
URL: https://github.com/apache/cloudstack/pull/4327#issuecomment-700130909


@DaanHoogland I must say I do not know CloudStack smoke tests well; are 
there any smoke tests on usages data in CloudStack currently, that I could use 
as a basis?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] olivierlemasle commented on pull request #4327: Re-enable IP address usage hiding

2020-09-25 Thread GitBox 


olivierlemasle commented on pull request #4327:
URL: https://github.com/apache/cloudstack/pull/4327#issuecomment-698437757


   Kindly ping @rhtyd 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] olivierlemasle commented on pull request #4327: Re-enable IP address usage hiding

2020-09-24 Thread GitBox 


olivierlemasle commented on pull request #4327:
URL: https://github.com/apache/cloudstack/pull/4327#issuecomment-698437757


   Kindly ping @rhtyd 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org