rhtyd commented on a change in pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#discussion_r425916165
##########
File path: scripts/vm/hypervisor/xenserver/vmops
##########
@@ -162,7 +162,7 @@ def setLinkLocalIP(session, args):
if result.lower().strip() == "bridge":
try:
- cmd = ["brctl", "addbr", brName]
+ cmd = ["ip", "link", "add", "name", brName, "type", "bridge"]
Review comment:
I suggest you check if this needs to be done for xenserver; the
xenserver scripts run only xenserver host (even though they are part of
cloudstack-common; cloudstack copies these scripts to XenServer/XCP-ng hosts
where they get executed, not on mgmt server). @shwstppr
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
