[GitHub] [cloudstack] rhtyd commented on pull request #4071: Dynamic roles improvements

2020-07-06 Thread GitBox 


rhtyd commented on pull request #4071:
URL: https://github.com/apache/cloudstack/pull/4071#issuecomment-654608839


   Test LGTM, failures not related to the PR



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4071: Dynamic roles improvements

2020-07-02 Thread GitBox 


rhtyd commented on pull request #4071:
URL: https://github.com/apache/cloudstack/pull/4071#issuecomment-653017853


   Cheers @borisstoyanov I'll merge this tomorrow if tests pass.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4071: Dynamic roles improvements

2020-06-16 Thread GitBox 


rhtyd commented on pull request #4071:
URL: https://github.com/apache/cloudstack/pull/4071#issuecomment-644578371


   @blueorangutan test



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4071: Dynamic roles improvements

2020-06-15 Thread GitBox 


rhtyd commented on pull request #4071:
URL: https://github.com/apache/cloudstack/pull/4071#issuecomment-644551264


   @sureshanaparti I've converted the PR to draft, until testing concludes so 
we don't accidently merge this cc @borisstoyanov @vladimirpetrov
   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4071: Dynamic roles improvements

2020-06-15 Thread GitBox 


rhtyd commented on pull request #4071:
URL: https://github.com/apache/cloudstack/pull/4071#issuecomment-644528040


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4071: Dynamic roles improvements

2020-06-12 Thread GitBox 


rhtyd commented on pull request #4071:
URL: https://github.com/apache/cloudstack/pull/4071#issuecomment-643152653


   @sureshanaparti I've completed another pass, please see the comments. Next, 
I'll test/review the Primate PR against this branch.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4071: Dynamic roles improvements

2020-06-11 Thread GitBox 


rhtyd commented on pull request #4071:
URL: https://github.com/apache/cloudstack/pull/4071#issuecomment-643061308


   Thanks @sureshanaparti I'll do another review pass and ping you.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4071: Dynamic roles improvements

2020-06-09 Thread GitBox 


rhtyd commented on pull request #4071:
URL: https://github.com/apache/cloudstack/pull/4071#issuecomment-640998000







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4071: Dynamic roles improvements

2020-05-14 Thread GitBox 


rhtyd commented on pull request #4071:
URL: https://github.com/apache/cloudstack/pull/4071#issuecomment-628521853


   @blueorangutan test 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org