shwstppr commented on a change in pull request #4116:
URL: https://github.com/apache/cloudstack/pull/4116#discussion_r436462951
##
File path:
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterManagerImpl.java
##
@@ -908,6 +910,10 @@ private void
validateKubernetesClusterUpgradeParameters(UpgradeKubernetesCluster
if
(!KubernetesCluster.State.Running.equals(kubernetesCluster.getState())) {
throw new InvalidParameterValueException(String.format("Kubernetes
cluster ID: %s is not in running state", kubernetesCluster.getUuid()));
}
+final DataCenter zone =
dataCenterDao.findById(kubernetesCluster.getZoneId());
+if (zone == null) {
+logAndThrow(Level.WARN, String.format("Unable to find zone for
Kubernetes cluster ID: %s", kubernetesCluster.getUuid()));
Review comment:
Just some helper methods to log and throw exceptions for similar error
https://github.com/apache/cloudstack/blob/8c6861bdc0f6b9fbf58a1c099f36ba08348dd204/plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterManagerImpl.java#L216-L249
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org