[GitHub] [cloudstack] svenvogel commented on issue #3186: Add possibility to set KVM MTU size for all NIC

2019-12-17 Thread GitBox
svenvogel commented on issue #3186: Add possibility to set KVM MTU size for all 
NIC
URL: https://github.com/apache/cloudstack/pull/3186#issuecomment-566575607
 
 
   @GabrielBrascher @andrijapanicsb sure we can put it on-hold and work in 
progress. at the moment there are no resources to get the things done with the 
router scripts.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] svenvogel commented on issue #3186: Add possibility to set KVM MTU size for all NIC

2019-12-14 Thread GitBox
svenvogel commented on issue #3186: Add possibility to set KVM MTU size for all 
NIC
URL: https://github.com/apache/cloudstack/pull/3186#issuecomment-565712280
 
 
   @DaanHoogland is 
https://github.com/apache/cloudstack/pull/3186/commits/1a91c457c1f16ce6d7e2750c85aacc7e30f91e2c
 correctly?
   
   possibly the wrong PR?  


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] svenvogel commented on issue #3186: Add possibility to set KVM MTU size for all NIC

2019-12-10 Thread GitBox
svenvogel commented on issue #3186: Add possibility to set KVM MTU size for all 
NIC
URL: https://github.com/apache/cloudstack/pull/3186#issuecomment-563928926
 
 
   Hi @GabrielBrascher @mdominka yes we should start another PR after this one. 
Make this sense? we can approve this one so this PR seems ready.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] svenvogel commented on issue #3186: Add possibility to set KVM MTU size for all NIC

2019-11-18 Thread GitBox
svenvogel commented on issue #3186: Add possibility to set KVM MTU size for all 
NIC
URL: https://github.com/apache/cloudstack/pull/3186#issuecomment-555101797
 
 
   @andrijapanicsb we test both thing but we dont encounter any problem. can 
you check this too?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] svenvogel commented on issue #3186: Add possibility to set KVM MTU size for all NIC

2019-11-18 Thread GitBox
svenvogel commented on issue #3186: Add possibility to set KVM MTU size for all 
NIC
URL: https://github.com/apache/cloudstack/pull/3186#issuecomment-555101284
 
 
   @wido you are completely right. we will test it tomorrow. the main problem 
is we dont have the knowledge about the router internal scripts. you know? 
there is nobody who know where "cmdline" will be used. a grep inside a virtual 
router gave ~20 script where this variable will be used. 
   
   i will repeat. we dont have the skills to change this. we can try to add the 
mtu value to the "cmdline" but we need help by the change of the router 
scripts? can you or @GabrielBrascher help?
   
   Cheers
   
   Sven
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] svenvogel commented on issue #3186: Add possibility to set KVM MTU size for all NIC

2019-11-18 Thread GitBox
svenvogel commented on issue #3186: Add possibility to set KVM MTU size for all 
NIC
URL: https://github.com/apache/cloudstack/pull/3186#issuecomment-555071361
 
 
   >When a VR is deployed, the MTU is being correctly configured on the KVM 
(e.g. /run/libvirt/qemu/r-2293-VM.xml) but the VR OS is still configured with 
default MTU (1500). It still would be needed to pass this in 'cmdline' to the 
VR on boot to have VRs booted with correct MTU.
   
   @GabrielBrascher thanks for testing! we dont know about the router scripts 
in VPC or virtual router an how we can implement it. i think its not so easy. 
maybe you can implement it?
   
   @andrijapanicsb yes we tested it on a new 4.13 install. seems to work fine.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] svenvogel commented on issue #3186: Add possibility to set KVM MTU size for all NIC

2019-11-05 Thread GitBox
svenvogel commented on issue #3186: Add possibility to set KVM MTU size for all 
NIC
URL: https://github.com/apache/cloudstack/pull/3186#issuecomment-549796291
 
 
   @andrijapanicsb @wido can you please take a look again?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] svenvogel commented on issue #3186: Add possibility to set KVM MTU size for all NIC

2019-11-01 Thread GitBox
svenvogel commented on issue #3186: Add possibility to set KVM MTU size for all 
NIC
URL: https://github.com/apache/cloudstack/pull/3186#issuecomment-548749456
 
 
   @andrijapanicsb can you take  a look again?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] svenvogel commented on issue #3186: Add possibility to set KVM MTU size for all NIC

2019-10-17 Thread GitBox
svenvogel commented on issue #3186: Add possibility to set KVM MTU size for all 
NIC
URL: https://github.com/apache/cloudstack/pull/3186#issuecomment-543182427
 
 
   @wido @GabrielBrascher could you find time to look at it?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] svenvogel commented on issue #3186: Add possibility to set KVM MTU size for all NIC

2019-10-03 Thread GitBox
svenvogel commented on issue #3186: Add possibility to set KVM MTU size for all 
NIC
URL: https://github.com/apache/cloudstack/pull/3186#issuecomment-537893981
 
 
   LGTM now i think.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] svenvogel commented on issue #3186: Add possibility to set KVM MTU size for all NIC

2019-10-03 Thread GitBox
svenvogel commented on issue #3186: Add possibility to set KVM MTU size for all 
NIC
URL: https://github.com/apache/cloudstack/pull/3186#issuecomment-537893544
 
 
   @rhtyd what do you think looks good?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] svenvogel commented on issue #3186: Add possibility to set KVM MTU size for all NIC

2019-09-30 Thread GitBox
svenvogel commented on issue #3186: Add possibility to set KVM MTU size for all 
NIC
URL: https://github.com/apache/cloudstack/pull/3186#issuecomment-536569813
 
 
   @rhtyd can you kick tests again? @wido can you check again. i think we are 
now ready to merge.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services