[GitHub] [cloudstack] svenvogel commented on issue #3371: Fix virtual template size for managed storage for KVM / refactor cloud-install-sys-tmplt
svenvogel commented on issue #3371: Fix virtual template size for managed storage for KVM / refactor cloud-install-sys-tmplt URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-566563730 4 LGTM, checks passed tested in different environments CentOS and Ubuntu. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] svenvogel commented on issue #3371: Fix virtual template size for managed storage for KVM / refactor cloud-install-sys-tmplt
svenvogel commented on issue #3371: Fix virtual template size for managed storage for KVM / refactor cloud-install-sys-tmplt URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-561817488 > @svenvogel I will test it. it looks ok. > by the way, you need to "git rebase" with latest master,or "Resolve conflicts" above. @weizhouapache thanks for checking. yes you are sure. now it should be rebased 👍 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] svenvogel commented on issue #3371: Fix virtual template size for managed storage for KVM / refactor cloud-install-sys-tmplt
svenvogel commented on issue #3371: Fix virtual template size for managed storage for KVM / refactor cloud-install-sys-tmplt URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-561574087 @rhtyd can you kick the the tests for me? @weizhouapache @andrijapanicsb can you take a look again? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] svenvogel commented on issue #3371: Fix virtual template size for managed storage for KVM / refactor cloud-install-sys-tmplt
svenvogel commented on issue #3371: Fix virtual template size for managed storage for KVM / refactor cloud-install-sys-tmplt URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-561215635 @weizhouapache @andrijapanicsb i will change it and then we should ready to go. @PaulAngus no problem. yes i looked at the document. it looks like a new solution to upgrade the image. i speak about initial prepare and we mostly use command line script for upgrade the SystemVM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] svenvogel commented on issue #3371: Fix virtual template size for managed storage for KVM / refactor cloud-install-sys-tmplt
svenvogel commented on issue #3371: Fix virtual template size for managed storage for KVM / refactor cloud-install-sys-tmplt URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-559587932 @ustcweizhou what do you think about the flag or remove it completely? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] svenvogel commented on issue #3371: Fix virtual template size for managed storage for KVM / refactor cloud-install-sys-tmplt
svenvogel commented on issue #3371: Fix virtual template size for managed storage for KVM / refactor cloud-install-sys-tmplt URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-558529707 @syed can you take a look. i thinks its ready now. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] svenvogel commented on issue #3371: Fix virtual template size for managed storage for KVM / refactor cloud-install-sys-tmplt
svenvogel commented on issue #3371: Fix virtual template size for managed storage for KVM / refactor cloud-install-sys-tmplt URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-30684 > In ideal world, we should make qemu-img a mandatory/dependency binary while installing the "cloudstack-management" binaries and remove that -M flag in this PR, and ALWAYS store the VIRTUAL size in those 2 values, irrelevant of what storage is used. @andrijapanicsb @rhtyd should we do it? i remove the flag and we use always virtualsize? after that we can move forward. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] svenvogel commented on issue #3371: Fix virtual template size for managed storage for KVM / refactor cloud-install-sys-tmplt
svenvogel commented on issue #3371: Fix virtual template size for managed storage for KVM / refactor cloud-install-sys-tmplt URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-554956879 @andrijapanicsb * for me its absolute okay to make it mandatory and remove the flag. if other storages dont have a problem with virtual size i would prefer your way. i think too its a good solution. if its necessary i will upgrade the documentation. should we do it? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] svenvogel commented on issue #3371: Fix virtual template size for managed storage for KVM / refactor cloud-install-sys-tmplt
svenvogel commented on issue #3371: Fix virtual template size for managed storage for KVM / refactor cloud-install-sys-tmplt URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-554669880 > hm... I've personally used KVM with SolidFire, including hosting all system VMs on SF. > > I read the explanation but still don't get it why it is now required @svenvogel @andrijapanicsb we use Netapp Solidfire since end of 2018 and work with them in KVM. you will see from testing to production the timeframe is not so large. The term "now" is not entirely correct. its 6 month of tests and wip. the PR is open since June 2019 with some changes and to find out how it works. i dont think its good to edit the database for new install and/or change values all the time i need an upgrade. except an emergency, I do not think it makes sense to edit in the database. do you change always the database? we want to min the change of the database. I think the video of @mike-tutkowski is a good explanation. > i.e. what EXACTLY doesn't work atm in 4.11+? i dont know before or after this release. i know that since we use the solidfire we have described problem above. the red rectangle with virtualsize is set without this fix to the disk disk size from the qcow2 and not virtualsize. if you upgrade the systemvm and change and the copy process will start it uses the disk size. SF system refuses the disk size. it needs an virtualsize and refuse the copy process. with fix.  without fix. solidfire copy process will not work.  make that sense? maybe @syed can add more historical information in this case. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] svenvogel commented on issue #3371: Fix virtual template size for managed storage for KVM / refactor cloud-install-sys-tmplt
svenvogel commented on issue #3371: Fix virtual template size for managed storage for KVM / refactor cloud-install-sys-tmplt URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-554647663 Hi @PaulAngus thanks for question. i will try to explain it. if you use a managed storage like "netapp solidfire" you need a systemvm template with virtualsize parameter in the template.properties file and not with the physical size. in java code there is xen and vmware already implemented to create the virtualsize automatically. but not for kvm. this virtualsize is set in the "template.properties" file. if there is no correctly set in the template.properties file it cant copied from the SSVM to Solidfire System. the systemvm is always be copyied from the qcow2 systemvm template to the solidfire system if there is not present. if there is an update we will delete it and it will copied again. At the moment there was the only workaround to set the values in the database. this is not very useful and dangerous. i added a flag "-M Managed Storage (QCOW2/KVM only)" for QCOW2/KVM with managed storage to get the virtualsize created in the template.properties file. every time if an "admin" will update the systemvm template with that script he can get the virtualsize with this parameter and dont set it manually. you can see that here in the video from @mike-tutkowski https://youtu.be/-tExEvkMJYs?list=PLqOXKM0Bt13DFnQnwUx8ZtJzoyDV0Uuye&t=550 @syed @mike-tutkowski is this the correct explanation? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
