[GitHub] [cloudstack] weizhouapache commented on issue #3179: Redundant VRouter guest network on wrong interface
weizhouapache commented on issue #3179: Redundant VRouter guest network on wrong interface URL: https://github.com/apache/cloudstack/issues/3179#issuecomment-578937748 @DennisKonrad @svenvogel @DaanHoogland I am testing my changes. If everything goes fine I will create pr tomorrow. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] weizhouapache commented on issue #3179: Redundant VRouter guest network on wrong interface
weizhouapache commented on issue #3179: Redundant VRouter guest network on wrong interface URL: https://github.com/apache/cloudstack/issues/3179#issuecomment-575882424 @svenvogel I will create a PR next week. I did not fully test it. Hope it will be good :-D This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] weizhouapache commented on issue #3179: Redundant VRouter guest network on wrong interface
weizhouapache commented on issue #3179: Redundant VRouter guest network on wrong interface URL: https://github.com/apache/cloudstack/issues/3179#issuecomment-571098748 @DaanHoogland what's the plan for 4.13.1 and 4.14 ? sorry I came back from holiday today and missed some discussion. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] weizhouapache commented on issue #3179: Redundant VRouter guest network on wrong interface
weizhouapache commented on issue #3179: Redundant VRouter guest network on wrong interface URL: https://github.com/apache/cloudstack/issues/3179#issuecomment-562600864 @svenvogel @DennisKonrad I push 3 new commits to the branch. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] weizhouapache commented on issue #3179: Redundant VRouter guest network on wrong interface
weizhouapache commented on issue #3179: Redundant VRouter guest network on wrong interface URL: https://github.com/apache/cloudstack/issues/3179#issuecomment-562039753 @svenvogel there are still some issues in my testing. I will create a PR when everything is fully tested. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] weizhouapache commented on issue #3179: Redundant VRouter guest network on wrong interface
weizhouapache commented on issue #3179: Redundant VRouter guest network on wrong interface URL: https://github.com/apache/cloudstack/issues/3179#issuecomment-559507839 @DennisKonrad do you use the network offering created by following http://docs.cloudstack.apache.org/en/latest/plugins/ovs-plugin.html ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] weizhouapache commented on issue #3179: Redundant VRouter guest network on wrong interface
weizhouapache commented on issue #3179: Redundant VRouter guest network on wrong interface URL: https://github.com/apache/cloudstack/issues/3179#issuecomment-559398532 @DennisKonrad vpc looks good now. However I found an issue with isolated networks (rvr or non-rvr both) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] weizhouapache commented on issue #3179: Redundant VRouter guest network on wrong interface
weizhouapache commented on issue #3179: Redundant VRouter guest network on wrong interface URL: https://github.com/apache/cloudstack/issues/3179#issuecomment-558989300 @DennisKonrad thanks for feedback ! InsufficientServerCapacityException might be caused by two reasons (1) capacity on the platform (2) some issues when apply network rules in virtual routers. Can you see some Exception in the agent.log on the server where the VR is running ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] weizhouapache commented on issue #3179: Redundant VRouter guest network on wrong interface
weizhouapache commented on issue #3179: Redundant VRouter guest network on wrong interface URL: https://github.com/apache/cloudstack/issues/3179#issuecomment-558522479 @DennisKonrad I have uploaded a commit to fix the regression issue. https://github.com/ustcweizhou/cloudstack/commits/4.14.0-vpc-vr-issues I am writing scripts for automation test. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] weizhouapache commented on issue #3179: Redundant VRouter guest network on wrong interface
weizhouapache commented on issue #3179: Redundant VRouter guest network on wrong interface URL: https://github.com/apache/cloudstack/issues/3179#issuecomment-557720278 @DennisKonrad it is still in progress. The issue you mentioned should be caused by the last commit. It is difficult to test all scenarios. I will write some test scripts at first. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] weizhouapache commented on issue #3179: Redundant VRouter guest network on wrong interface
weizhouapache commented on issue #3179: Redundant VRouter guest network on wrong interface URL: https://github.com/apache/cloudstack/issues/3179#issuecomment-555401374 @DennisKonrad There are many issues actually and all these issues are correlated. we need to make sure all following settings are working network/vpc type in cloudstack (1) vpc with single VR (2) network with single VR (3) vpc with RvR (4) network with RvR network type on kvm (1) linux bridge (2) ovs actions (1) associate public IP (same range as source nat) (2) release public IP (same range as source nat) (3) associate first /second/third... public ip (different range as source nat) (4) release first /second/third... public IP (different range as source nat) It is not a easy fix. I have made some bug fixes. see https://github.com/ustcweizhou/cloudstack/commits/4.14.0-vpc-vr-issues This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] weizhouapache commented on issue #3179: Redundant VRouter guest network on wrong interface
weizhouapache commented on issue #3179: Redundant VRouter guest network on wrong interface URL: https://github.com/apache/cloudstack/issues/3179#issuecomment-554680933 @svenvogel #2304 is helpful for VPC with single router. we do not need to revert it. we need to make similar change for OVS in LibvirtComputingResource.java. I have found some issues with isolated networks in my setup with OVS. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] weizhouapache commented on issue #3179: Redundant VRouter guest network on wrong interface
weizhouapache commented on issue #3179: Redundant VRouter guest network on wrong interface URL: https://github.com/apache/cloudstack/issues/3179#issuecomment-554555283 @DennisKonrad I have set up a testing environment with OVS. I cannot reproduce this issue. Do you test on official cloudstack release or with some your changes ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] weizhouapache commented on issue #3179: Redundant VRouter guest network on wrong interface
weizhouapache commented on issue #3179: Redundant VRouter guest network on wrong interface URL: https://github.com/apache/cloudstack/issues/3179#issuecomment-554486187 @DennisKonrad if you look at CommandSetupHelper.java, you may find that IpAssocVpcCommand is send to hypervisors when associate a public IP, if VPC does not have redundant VRs. However, for VPC with RvRs, it always send IpAssocCommand (in createRedundantAssociateIPCommands), which does not make any sense. There should be some issues caused by it in the past, some of them have been fixed by different way, for example 6fc389a044288e8f12f41a651a711a1ab7113b86 . However, I insist that we should send IpAssocVpcCommand instead of IpAssocCommand , even it might lead to some issues. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] weizhouapache commented on issue #3179: Redundant VRouter guest network on wrong interface
weizhouapache commented on issue #3179: Redundant VRouter guest network on wrong interface URL: https://github.com/apache/cloudstack/issues/3179#issuecomment-554404116 @DennisKonrad @svenvogel I will create a PR when I test ok with VPC & RvR & linux bridge. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] weizhouapache commented on issue #3179: Redundant VRouter guest network on wrong interface
weizhouapache commented on issue #3179: Redundant VRouter guest network on wrong interface URL: https://github.com/apache/cloudstack/issues/3179#issuecomment-554395688 @DennisKonrad I did not see any IpAssocVpcCommand in management server log, so I think all are IpAssocCommand , even when ip is associated to a VPC. Please correct me if I am wrong We have seen and fixed many issues with VPC & RvRs in cloudstack 4.7.1, especially when there are multiple public ip ranges. For example, network element should not be cleaned up when de-associate a public ip. https://github.com/apache/cloudstack/blob/master/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java#L377-L382 If IP is associated/de-associated to an isolated network, the command should be IpAssocCommand If IP is associated/de-associated to a VPC, the command should be IpAssocVpcCommand the second function ```prepareNetworkElementCommand(final IpAssocVpcCommand cmd)``` does NOT work for normal setup (linux bridge), if we apply the change in https://github.com/apache/cloudstack/issues/3179#issuecomment-552463825 as you said in https://github.com/apache/cloudstack/issues/3179#issuecomment-553641686 I have changed the first function to similar behavior as the second function. I got the same result as the description. Now I can conclude that the issue is a regression issue after #2304, but the root cause should be wrong mac address of public ip addresses. https://github.com/apache/cloudstack/blob/master/server/src/main/java/com/cloud/network/router/CommandSetupHelper.java#L812-L814 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] weizhouapache commented on issue #3179: Redundant VRouter guest network on wrong interface
weizhouapache commented on issue #3179: Redundant VRouter guest network on
wrong interface
URL: https://github.com/apache/cloudstack/issues/3179#issuecomment-554354605
@svenvogel @DennisKonrad
there are two methods to handle ip association in
LibvirtComputingResource.java
```
public ExecutionResult prepareNetworkElementCommand(final IpAssocCommand
cmd) {
protected ExecutionResult prepareNetworkElementCommand(final
IpAssocVpcCommand cmd) {
```
In the past they have almost same processing. @fmaximus has changed the
second method in #2304 for openvswitch setup. the first method is not changed
which might be the root cause of this issue #3679 @DennisKonrad .
For now all ip association in normal setup(vpc with rvr, linux bridge) are
handled by the first method, which work fine. I did not see any
IpAssocVpcCommand (all are IpAssocCommand ) so I am confused how issue
mentioned in #2304 is fixed. @svenvogel can you give me more details ?
I found the mac address of nic and ip addresses are different, which might
be why nic device id is determined by broadcast uri instead of mac address, and
also the reason device id is null reported by @DennisKonrad in
https://github.com/apache/cloudstack/issues/3179#issuecomment-553940664
in my opinion, we should
(1) apply the change in
https://github.com/apache/cloudstack/issues/3179#issuecomment-552463825
(2) different process for ovs and linux bridge in the two method above. to
be clear, nic device id is determined by mac address map (if ovs) or broadcast
url (if linux bridge).
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] weizhouapache commented on issue #3179: Redundant VRouter guest network on wrong interface
weizhouapache commented on issue #3179: Redundant VRouter guest network on wrong interface URL: https://github.com/apache/cloudstack/issues/3179#issuecomment-554266163 @DennisKonrad I believe this is a regress issue caused by #2304 I think we should revert #2304, and look for another solution for the issue mentioned in in the title of #2304 However, I did not find more information about the issue. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] weizhouapache commented on issue #3179: Redundant VRouter guest network on wrong interface
weizhouapache commented on issue #3179: Redundant VRouter guest network on wrong interface URL: https://github.com/apache/cloudstack/issues/3179#issuecomment-553952656 @DennisKonrad I reverted #2304, and it works This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] weizhouapache commented on issue #3179: Redundant VRouter guest network on wrong interface
weizhouapache commented on issue #3179: Redundant VRouter guest network on wrong interface URL: https://github.com/apache/cloudstack/issues/3179#issuecomment-553839855 @DennisKonrad I will test it as well This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] weizhouapache commented on issue #3179: Redundant VRouter guest network on wrong interface
weizhouapache commented on issue #3179: Redundant VRouter guest network on
wrong interface
URL: https://github.com/apache/cloudstack/issues/3179#issuecomment-552463825
@DennisKonrad we have a fix for another issue with VPC, maybe it solves this
bug.
```
diff --git
a/server/src/main/java/com/cloud/network/router/CommandSetupHelper.java
b/server/src/main/java/com/cloud/network/router/CommandSetupHelper.java
index f9ffeb9..e2da241 100644
--- a/server/src/main/java/com/cloud/network/router/CommandSetupHelper.java
+++ b/server/src/main/java/com/cloud/network/router/CommandSetupHelper.java
@@ -866,7 +866,12 @@ public class CommandSetupHelper {
}
}
-final IpAssocCommand cmd = new IpAssocCommand(ipsToSend);
+final IpAssocCommand cmd;
+if (router.getVpcId() != null) {
+cmd = new IpAssocVpcCommand(ipsToSend);
+} else {
+cmd = new IpAssocCommand(ipsToSend);
+}
cmd.setAccessDetail(NetworkElementCommand.ROUTER_IP,
_routerControlHelper.getRouterControlIp(router.getId()));
cmd.setAccessDetail(NetworkElementCommand.ROUTER_GUEST_IP,
_routerControlHelper.getRouterIpInNetwork(associatedWithNetworkId,
router.getId()));
cmd.setAccessDetail(NetworkElementCommand.ROUTER_NAME,
router.getInstanceName());
```
can you try with it ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] weizhouapache commented on issue #3179: Redundant VRouter guest network on wrong interface
weizhouapache commented on issue #3179: Redundant VRouter guest network on wrong interface URL: https://github.com/apache/cloudstack/issues/3179#issuecomment-551915251 @DennisKonrad can you reproduce the issue and upload some mgt logs ? you can grep the log by job id (job-X). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] weizhouapache commented on issue #3179: Redundant VRouter guest network on wrong interface
weizhouapache commented on issue #3179: Redundant VRouter guest network on wrong interface URL: https://github.com/apache/cloudstack/issues/3179#issuecomment-551863291 @DennisKonrad now we can conclude the issue happens with ovs and redundant VPC offering. did you have this issue in old versions ? for example, 4.9.X or 4.11.X ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
